Re: [Lldb-commits] [PATCH] TestPrintStackTraces - made XFAIL more precise

[Vince Harron]

Hi Greg,

Do you want us to wait for review from you on changes that are fairly Linux 
specific?



Comment at: test/python_api/lldbutil/process/TestPrintStackTraces.py:34
@@ +33,3 @@
+if self.getArchitecture() in ['i386'] and "linux" in sys.platform:
+self.skipTest("Skipping because this test is known to fail on i386 
Linux")
+

sivachandra wrote:
> The test is already marked xfail for i386 and linux. Why have this?
It was marked as expectedFailureLinux but seems to be passing on x86_64.

http://reviews.llvm.org/D8677

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/



___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] TestPrintStackTraces - made XFAIL more precise

[Vince Harron]

Hi clayborg, sivachandra,

Works with x86_64 inferior, fails w/i386 inferior - updated test to reflect

http://reviews.llvm.org/D8677

Files:
  test/python_api/lldbutil/process/TestPrintStackTraces.py

Index: test/python_api/lldbutil/process/TestPrintStackTraces.py
===
--- test/python_api/lldbutil/process/TestPrintStackTraces.py
+++ test/python_api/lldbutil/process/TestPrintStackTraces.py
@@ -18,15 +18,21 @@
 # Find the line number to break inside main().
 self.line = line_number('main.cpp', '// Set break point at this line.')
 
-@expectedFailureLinux # llvm.org/pr15415 -- partial stack trace in thread 
1 (while stopped inside a read() call)
+# llvm.org/pr23043 - leaving the next two lines in so it's easy to find 
this 
+# test will appear when searching for expectedFailure(Linux|i386)
+#@expectedFailureLinux
+#@expectedFailurei386
 @python_api_test
 def test_stack_traces(self):
 """Test SBprocess and SBThread APIs with printing of the stack 
traces."""
 self.buildDefault()
 self.break_and_print_stacktraces()
 
 def break_and_print_stacktraces(self):
 """Break at main.cpp:68 and do a threads dump"""
+if self.getArchitecture() in ['i386'] and "linux" in sys.platform:
+self.skipTest("Skipping because this test is known to fail on i386 
Linux")
+
 exe = os.path.join(os.getcwd(), "a.out")
 
 target = self.dbg.CreateTarget(exe)

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
Index: test/python_api/lldbutil/process/TestPrintStackTraces.py
===
--- test/python_api/lldbutil/process/TestPrintStackTraces.py
+++ test/python_api/lldbutil/process/TestPrintStackTraces.py
@@ -18,15 +18,21 @@
 # Find the line number to break inside main().
 self.line = line_number('main.cpp', '// Set break point at this line.')
 
-@expectedFailureLinux # llvm.org/pr15415 -- partial stack trace in thread 1 (while stopped inside a read() call)
+# llvm.org/pr23043 - leaving the next two lines in so it's easy to find this 
+# test will appear when searching for expectedFailure(Linux|i386)
+#@expectedFailureLinux
+#@expectedFailurei386
 @python_api_test
 def test_stack_traces(self):
 """Test SBprocess and SBThread APIs with printing of the stack traces."""
 self.buildDefault()
 self.break_and_print_stacktraces()
 
 def break_and_print_stacktraces(self):
 """Break at main.cpp:68 and do a threads dump"""
+if self.getArchitecture() in ['i386'] and "linux" in sys.platform:
+self.skipTest("Skipping because this test is known to fail on i386 Linux")
+
 exe = os.path.join(os.getcwd(), "a.out")
 
 target = self.dbg.CreateTarget(exe)
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits