Re: [Lldb-commits] [PATCH] Change executable name to a.out.

2015-07-02 Thread Vince Harron
Will discuss offline.
On Jul 1, 2015 8:24 PM, Chaoren Lin chaor...@google.com wrote:

  Does the LLDB API output a clear and actionable error code if the
 filename you are launching is too long?

 Nope, it'll try to launch the inferior, and it'll think the inferior ran
 and exited with an error code.

  If not please add a test for this

 I don't think this is testable, it's completely dependent on the shell,
 your choice of working directory, and whatever extra arguments there are.

 On Wed, Jul 1, 2015 at 8:12 PM, Vince Harron vi...@nethacker.com wrote:

  LoL


 LL

 Spectacular speech to text failure


 REPOSITORY
   rL LLVM

 http://reviews.llvm.org/D10888

 EMAIL PREFERENCES
   http://reviews.llvm.org/settings/panel/emailpreferences/




___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits


Re: [Lldb-commits] [PATCH] Change executable name to a.out.

2015-07-02 Thread Bruce Mitchener
REPOSITORY
  rL LLVM


Comment at: 
lldb/trunk/test/functionalities/watchpoint/hello_watchpoint/TestMyFirstWatchpoint.py:41
@@ -40,2 +40,3 @@
 self.decl = line_number(self.source, '// Watchpoint variable 
declaration.')
 # Build dictionary to have unique executable names for each test 
method.
+self.exe_name = 'a.out'

A bit late, but shouldn't this comment be updated?

http://reviews.llvm.org/D10888

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/



___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits


Re: [Lldb-commits] [PATCH] Change executable name to a.out.

2015-07-02 Thread Chaoren Lin
Oops. Yeah, that doesn't make sense anymore. I'll remove it.
On Jul 2, 2015 04:06, Bruce Mitchener bruce.mitche...@gmail.com wrote:

 REPOSITORY
   rL LLVM

 
 Comment at:
 lldb/trunk/test/functionalities/watchpoint/hello_watchpoint/TestMyFirstWatchpoint.py:41
 @@ -40,2 +40,3 @@
  self.decl = line_number(self.source, '// Watchpoint variable
 declaration.')
  # Build dictionary to have unique executable names for each test
 method.
 +self.exe_name = 'a.out'
 
 A bit late, but shouldn't this comment be updated?

 http://reviews.llvm.org/D10888

 EMAIL PREFERENCES
   http://reviews.llvm.org/settings/panel/emailpreferences/



___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits


Re: [Lldb-commits] [PATCH] Change executable name to a.out.

2015-07-01 Thread Vince Harron
Does the LoL DB API output a clear and actionable error code if the
filename you are launching is too long? If not please add a test for this
On Jul 1, 2015 6:26 PM, Chaoren Lin chaor...@google.com wrote:

 Hi sivachandra,

 The long name causes problems with some shells.

 http://reviews.llvm.org/D10888

 Files:
   test/functionalities/watchpoint/hello_watchpoint/TestMyFirstWatchpoint.py

 Index:
 test/functionalities/watchpoint/hello_watchpoint/TestMyFirstWatchpoint.py
 ===
 ---
 test/functionalities/watchpoint/hello_watchpoint/TestMyFirstWatchpoint.py
 +++
 test/functionalities/watchpoint/hello_watchpoint/TestMyFirstWatchpoint.py
 @@ -39,7 +39,7 @@
  # And the watchpoint variable declaration line number.
  self.decl = line_number(self.source, '// Watchpoint variable
 declaration.')
  # Build dictionary to have unique executable names for each test
 method.
 -self.exe_name = self.testMethodName
 +self.exe_name = 'a.out'
  self.d = {'C_SOURCES': self.source, 'EXE': self.exe_name}

  def hello_watchpoint(self):

 EMAIL PREFERENCES
   http://reviews.llvm.org/settings/panel/emailpreferences/

 ___
 lldb-commits mailing list
 lldb-commits@cs.uiuc.edu
 http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits


___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits


Re: [Lldb-commits] [PATCH] Change executable name to a.out.

2015-07-01 Thread Vince Harron
 LoL

LL

Spectacular speech to text failure
On Jul 1, 2015 8:11 PM, Vince Harron vi...@nethacker.com wrote:

 Does the LoL DB API output a clear and actionable error code if the
 filename you are launching is too long? If not please add a test for this
 On Jul 1, 2015 6:26 PM, Chaoren Lin chaor...@google.com wrote:

 Hi sivachandra,

 The long name causes problems with some shells.

 http://reviews.llvm.org/D10888

 Files:

 test/functionalities/watchpoint/hello_watchpoint/TestMyFirstWatchpoint.py

 Index:
 test/functionalities/watchpoint/hello_watchpoint/TestMyFirstWatchpoint.py
 ===
 ---
 test/functionalities/watchpoint/hello_watchpoint/TestMyFirstWatchpoint.py
 +++
 test/functionalities/watchpoint/hello_watchpoint/TestMyFirstWatchpoint.py
 @@ -39,7 +39,7 @@
  # And the watchpoint variable declaration line number.
  self.decl = line_number(self.source, '// Watchpoint variable
 declaration.')
  # Build dictionary to have unique executable names for each test
 method.
 -self.exe_name = self.testMethodName
 +self.exe_name = 'a.out'
  self.d = {'C_SOURCES': self.source, 'EXE': self.exe_name}

  def hello_watchpoint(self):

 EMAIL PREFERENCES
   http://reviews.llvm.org/settings/panel/emailpreferences/

 ___
 lldb-commits mailing list
 lldb-commits@cs.uiuc.edu
 http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits


___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits


Re: [Lldb-commits] [PATCH] Change executable name to a.out.

2015-07-01 Thread Vince Harron
Does the LoL DB API output a clear and actionable error code if the
filename you are launching is too long? If not please add a test for this


REPOSITORY
  rL LLVM

http://reviews.llvm.org/D10888

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/



___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits


Re: [Lldb-commits] [PATCH] Change executable name to a.out.

2015-07-01 Thread Vince Harron
 LoL


LL

Spectacular speech to text failure


REPOSITORY
  rL LLVM

http://reviews.llvm.org/D10888

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/



___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits