Re: [Lldb-commits] [lldb] r278197 - Undid LLVM macro usage in test suite test subject files.
Hmm, the common Makefile.rules configures it to be a force include from the command line. It's possible this isn't being done with gcc or some other compiler. I suppose I can change test_common.h to #define __PRETTY_FUNCTION__ __FUNCSIG__ on windows which would also fix those tests. On Tue, Aug 9, 2016 at 8:26 PM Todd Fialawrote: > Maybe those tests aren't including test_common.h? Dunno. > > On Tue, Aug 9, 2016 at 8:25 PM, Todd Fiala wrote: > >> No, sorry, it does not. >> >> Each of those got undefined macro errors on macOS. >> >> -Todd >> >> On Tue, Aug 9, 2016 at 7:18 PM, Zachary Turner >> wrote: >> >>> This will make the tests start failing again on Windows. I #defined >>> these in test_common.h, it should work. Does it not? >>> >>> On Tue, Aug 9, 2016 at 6:45 PM Todd Fiala via lldb-commits < >>> lldb-commits@lists.llvm.org> wrote: >>> Author: tfiala Date: Tue Aug 9 20:37:27 2016 New Revision: 278197 URL: http://llvm.org/viewvc/llvm-project?rev=278197=rev Log: Undid LLVM macro usage in test suite test subject files. Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/cpp/main.cpp lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/diamond/main.cpp lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/virtual/main.cpp Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/cpp/main.cpp URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/cpp/main.cpp?rev=278197=278196=278197=diff == --- lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/cpp/main.cpp (original) +++ lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/cpp/main.cpp Tue Aug 9 20:37:27 2016 @@ -16,15 +16,15 @@ namespace a { ~c(); void func1() { -puts (LLVM_PRETTY_FUNCTION); +puts (__PRETTY_FUNCTION__); } void func2() { -puts (LLVM_PRETTY_FUNCTION); +puts (__PRETTY_FUNCTION__); } void func3() { -puts (LLVM_PRETTY_FUNCTION); +puts (__PRETTY_FUNCTION__); } }; @@ -39,11 +39,11 @@ namespace b { ~c(); void func1() { -puts (LLVM_PRETTY_FUNCTION); +puts (__PRETTY_FUNCTION__); } void func3() { -puts (LLVM_PRETTY_FUNCTION); +puts (__PRETTY_FUNCTION__); } }; @@ -58,11 +58,11 @@ namespace c { ~d() {} void func2() { -puts (LLVM_PRETTY_FUNCTION); +puts (__PRETTY_FUNCTION__); } void func3() { -puts (LLVM_PRETTY_FUNCTION); +puts (__PRETTY_FUNCTION__); } }; } Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/diamond/main.cpp URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/diamond/main.cpp?rev=278197=278196=278197=diff == --- lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/diamond/main.cpp (original) +++ lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/diamond/main.cpp Tue Aug 9 20:37:27 2016 @@ -17,7 +17,7 @@ public: virtual ~VBase() {} void Print() { -printf("%p: %s\n%p: m_value = 0x%8.8x\n", this, LLVM_PRETTY_FUNCTION, _value, m_value); +printf("%p: %s\n%p: m_value = 0x%8.8x\n", this, __PRETTY_FUNCTION__, _value, m_value); } int m_value; }; @@ -28,7 +28,7 @@ public: Derived1() {}; void Print () { -printf("%p: %s\n", this, LLVM_PRETTY_FUNCTION); +printf("%p: %s\n", this, __PRETTY_FUNCTION__); VBase::Print(); } @@ -41,7 +41,7 @@ public: void Print () { -printf("%p: %s\n", this, LLVM_PRETTY_FUNCTION); +printf("%p: %s\n", this, __PRETTY_FUNCTION__); VBase::Print(); } }; @@ -56,7 +56,7 @@ public: { printf("%p: %s \n%p: m_joiner1 = 0x%8.8x\n%p: m_joiner2 = 0x%8.8x\n", this, - LLVM_PRETTY_FUNCTION, + __PRETTY_FUNCTION__, _joiner1,
Re: [Lldb-commits] [lldb] r278197 - Undid LLVM macro usage in test suite test subject files.
Maybe those tests aren't including test_common.h? Dunno. On Tue, Aug 9, 2016 at 8:25 PM, Todd Fialawrote: > No, sorry, it does not. > > Each of those got undefined macro errors on macOS. > > -Todd > > On Tue, Aug 9, 2016 at 7:18 PM, Zachary Turner wrote: > >> This will make the tests start failing again on Windows. I #defined these >> in test_common.h, it should work. Does it not? >> >> On Tue, Aug 9, 2016 at 6:45 PM Todd Fiala via lldb-commits < >> lldb-commits@lists.llvm.org> wrote: >> >>> Author: tfiala >>> Date: Tue Aug 9 20:37:27 2016 >>> New Revision: 278197 >>> >>> URL: http://llvm.org/viewvc/llvm-project?rev=278197=rev >>> Log: >>> Undid LLVM macro usage in test suite test subject files. >>> >>> Modified: >>> lldb/trunk/packages/Python/lldbsuite/test/functionalities/ >>> breakpoint/cpp/main.cpp >>> lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/diamond/main.cpp >>> lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/virtual/main.cpp >>> >>> Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/ >>> breakpoint/cpp/main.cpp >>> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Pyth >>> on/lldbsuite/test/functionalities/breakpoint/cpp/main.cpp? >>> rev=278197=278196=278197=diff >>> >>> == >>> --- >>> lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/cpp/main.cpp >>> (original) >>> +++ >>> lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/cpp/main.cpp >>> Tue Aug 9 20:37:27 2016 >>> @@ -16,15 +16,15 @@ namespace a { >>> ~c(); >>> void func1() >>> { >>> -puts (LLVM_PRETTY_FUNCTION); >>> +puts (__PRETTY_FUNCTION__); >>> } >>> void func2() >>> { >>> -puts (LLVM_PRETTY_FUNCTION); >>> +puts (__PRETTY_FUNCTION__); >>> } >>> void func3() >>> { >>> -puts (LLVM_PRETTY_FUNCTION); >>> +puts (__PRETTY_FUNCTION__); >>> } >>> }; >>> >>> @@ -39,11 +39,11 @@ namespace b { >>> ~c(); >>> void func1() >>> { >>> -puts (LLVM_PRETTY_FUNCTION); >>> +puts (__PRETTY_FUNCTION__); >>> } >>> void func3() >>> { >>> -puts (LLVM_PRETTY_FUNCTION); >>> +puts (__PRETTY_FUNCTION__); >>> } >>> }; >>> >>> @@ -58,11 +58,11 @@ namespace c { >>> ~d() {} >>> void func2() >>> { >>> -puts (LLVM_PRETTY_FUNCTION); >>> +puts (__PRETTY_FUNCTION__); >>> } >>> void func3() >>> { >>> -puts (LLVM_PRETTY_FUNCTION); >>> +puts (__PRETTY_FUNCTION__); >>> } >>> }; >>> } >>> >>> Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/diamond/ >>> main.cpp >>> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Pyth >>> on/lldbsuite/test/lang/cpp/diamond/main.cpp?rev=278197& >>> r1=278196=278197=diff >>> >>> == >>> --- lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/diamond/main.cpp >>> (original) >>> +++ lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/diamond/main.cpp >>> Tue Aug 9 20:37:27 2016 >>> @@ -17,7 +17,7 @@ public: >>> virtual ~VBase() {} >>> void Print() >>> { >>> -printf("%p: %s\n%p: m_value = 0x%8.8x\n", this, >>> LLVM_PRETTY_FUNCTION, _value, m_value); >>> +printf("%p: %s\n%p: m_value = 0x%8.8x\n", this, >>> __PRETTY_FUNCTION__, _value, m_value); >>> } >>> int m_value; >>> }; >>> @@ -28,7 +28,7 @@ public: >>> Derived1() {}; >>> void Print () >>> { >>> -printf("%p: %s\n", this, LLVM_PRETTY_FUNCTION); >>> +printf("%p: %s\n", this, __PRETTY_FUNCTION__); >>> VBase::Print(); >>> } >>> >>> @@ -41,7 +41,7 @@ public: >>> >>> void Print () >>> { >>> -printf("%p: %s\n", this, LLVM_PRETTY_FUNCTION); >>> +printf("%p: %s\n", this, __PRETTY_FUNCTION__); >>> VBase::Print(); >>> } >>> }; >>> @@ -56,7 +56,7 @@ public: >>> { >>> printf("%p: %s \n%p: m_joiner1 = 0x%8.8x\n%p: m_joiner2 = >>> 0x%8.8x\n", >>> this, >>> - LLVM_PRETTY_FUNCTION, >>> + __PRETTY_FUNCTION__, >>> _joiner1, >>> m_joiner1, >>> _joiner2, >>> >>> Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/virtual/ >>> main.cpp >>> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Pyth >>> on/lldbsuite/test/lang/cpp/virtual/main.cpp?rev=278197& >>> r1=278196=278197=diff >>> >>> == >>> --- lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/virtual/main.cpp >>> (original) >>> +++
Re: [Lldb-commits] [lldb] r278197 - Undid LLVM macro usage in test suite test subject files.
No, sorry, it does not. Each of those got undefined macro errors on macOS. -Todd On Tue, Aug 9, 2016 at 7:18 PM, Zachary Turnerwrote: > This will make the tests start failing again on Windows. I #defined these > in test_common.h, it should work. Does it not? > > On Tue, Aug 9, 2016 at 6:45 PM Todd Fiala via lldb-commits < > lldb-commits@lists.llvm.org> wrote: > >> Author: tfiala >> Date: Tue Aug 9 20:37:27 2016 >> New Revision: 278197 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=278197=rev >> Log: >> Undid LLVM macro usage in test suite test subject files. >> >> Modified: >> lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/ >> cpp/main.cpp >> lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/diamond/main.cpp >> lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/virtual/main.cpp >> >> Modified: lldb/trunk/packages/Python/lldbsuite/test/ >> functionalities/breakpoint/cpp/main.cpp >> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/ >> Python/lldbsuite/test/functionalities/breakpoint/ >> cpp/main.cpp?rev=278197=278196=278197=diff >> >> == >> --- >> lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/cpp/main.cpp >> (original) >> +++ >> lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/cpp/main.cpp >> Tue Aug 9 20:37:27 2016 >> @@ -16,15 +16,15 @@ namespace a { >> ~c(); >> void func1() >> { >> -puts (LLVM_PRETTY_FUNCTION); >> +puts (__PRETTY_FUNCTION__); >> } >> void func2() >> { >> -puts (LLVM_PRETTY_FUNCTION); >> +puts (__PRETTY_FUNCTION__); >> } >> void func3() >> { >> -puts (LLVM_PRETTY_FUNCTION); >> +puts (__PRETTY_FUNCTION__); >> } >> }; >> >> @@ -39,11 +39,11 @@ namespace b { >> ~c(); >> void func1() >> { >> -puts (LLVM_PRETTY_FUNCTION); >> +puts (__PRETTY_FUNCTION__); >> } >> void func3() >> { >> -puts (LLVM_PRETTY_FUNCTION); >> +puts (__PRETTY_FUNCTION__); >> } >> }; >> >> @@ -58,11 +58,11 @@ namespace c { >> ~d() {} >> void func2() >> { >> -puts (LLVM_PRETTY_FUNCTION); >> +puts (__PRETTY_FUNCTION__); >> } >> void func3() >> { >> -puts (LLVM_PRETTY_FUNCTION); >> +puts (__PRETTY_FUNCTION__); >> } >> }; >> } >> >> Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/ >> diamond/main.cpp >> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/ >> Python/lldbsuite/test/lang/cpp/diamond/main.cpp?rev= >> 278197=278196=278197=diff >> >> == >> --- lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/diamond/main.cpp >> (original) >> +++ lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/diamond/main.cpp >> Tue Aug 9 20:37:27 2016 >> @@ -17,7 +17,7 @@ public: >> virtual ~VBase() {} >> void Print() >> { >> -printf("%p: %s\n%p: m_value = 0x%8.8x\n", this, >> LLVM_PRETTY_FUNCTION, _value, m_value); >> +printf("%p: %s\n%p: m_value = 0x%8.8x\n", this, >> __PRETTY_FUNCTION__, _value, m_value); >> } >> int m_value; >> }; >> @@ -28,7 +28,7 @@ public: >> Derived1() {}; >> void Print () >> { >> -printf("%p: %s\n", this, LLVM_PRETTY_FUNCTION); >> +printf("%p: %s\n", this, __PRETTY_FUNCTION__); >> VBase::Print(); >> } >> >> @@ -41,7 +41,7 @@ public: >> >> void Print () >> { >> -printf("%p: %s\n", this, LLVM_PRETTY_FUNCTION); >> +printf("%p: %s\n", this, __PRETTY_FUNCTION__); >> VBase::Print(); >> } >> }; >> @@ -56,7 +56,7 @@ public: >> { >> printf("%p: %s \n%p: m_joiner1 = 0x%8.8x\n%p: m_joiner2 = >> 0x%8.8x\n", >> this, >> - LLVM_PRETTY_FUNCTION, >> + __PRETTY_FUNCTION__, >> _joiner1, >> m_joiner1, >> _joiner2, >> >> Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/ >> virtual/main.cpp >> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/ >> Python/lldbsuite/test/lang/cpp/virtual/main.cpp?rev= >> 278197=278196=278197=diff >> >> == >> --- lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/virtual/main.cpp >> (original) >> +++ lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/virtual/main.cpp >> Tue Aug 9 20:37:27 2016 >> @@ -10,17 +10,17 @@ public: >> >> virtual const char * a() >> { >> -return LLVM_PRETTY_FUNCTION; >> +return __PRETTY_FUNCTION__; >> } >> >> virtual const char * b()
Re: [Lldb-commits] [lldb] r278197 - Undid LLVM macro usage in test suite test subject files.
This will make the tests start failing again on Windows. I #defined these in test_common.h, it should work. Does it not? On Tue, Aug 9, 2016 at 6:45 PM Todd Fiala via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: tfiala > Date: Tue Aug 9 20:37:27 2016 > New Revision: 278197 > > URL: http://llvm.org/viewvc/llvm-project?rev=278197=rev > Log: > Undid LLVM macro usage in test suite test subject files. > > Modified: > > lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/cpp/main.cpp > lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/diamond/main.cpp > lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/virtual/main.cpp > > Modified: > lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/cpp/main.cpp > URL: > http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/cpp/main.cpp?rev=278197=278196=278197=diff > > == > --- > lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/cpp/main.cpp > (original) > +++ > lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/cpp/main.cpp > Tue Aug 9 20:37:27 2016 > @@ -16,15 +16,15 @@ namespace a { > ~c(); > void func1() > { > -puts (LLVM_PRETTY_FUNCTION); > +puts (__PRETTY_FUNCTION__); > } > void func2() > { > -puts (LLVM_PRETTY_FUNCTION); > +puts (__PRETTY_FUNCTION__); > } > void func3() > { > -puts (LLVM_PRETTY_FUNCTION); > +puts (__PRETTY_FUNCTION__); > } > }; > > @@ -39,11 +39,11 @@ namespace b { > ~c(); > void func1() > { > -puts (LLVM_PRETTY_FUNCTION); > +puts (__PRETTY_FUNCTION__); > } > void func3() > { > -puts (LLVM_PRETTY_FUNCTION); > +puts (__PRETTY_FUNCTION__); > } > }; > > @@ -58,11 +58,11 @@ namespace c { > ~d() {} > void func2() > { > -puts (LLVM_PRETTY_FUNCTION); > +puts (__PRETTY_FUNCTION__); > } > void func3() > { > -puts (LLVM_PRETTY_FUNCTION); > +puts (__PRETTY_FUNCTION__); > } > }; > } > > Modified: > lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/diamond/main.cpp > URL: > http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/diamond/main.cpp?rev=278197=278196=278197=diff > > == > --- lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/diamond/main.cpp > (original) > +++ lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/diamond/main.cpp > Tue Aug 9 20:37:27 2016 > @@ -17,7 +17,7 @@ public: > virtual ~VBase() {} > void Print() > { > -printf("%p: %s\n%p: m_value = 0x%8.8x\n", this, > LLVM_PRETTY_FUNCTION, _value, m_value); > +printf("%p: %s\n%p: m_value = 0x%8.8x\n", this, > __PRETTY_FUNCTION__, _value, m_value); > } > int m_value; > }; > @@ -28,7 +28,7 @@ public: > Derived1() {}; > void Print () > { > -printf("%p: %s\n", this, LLVM_PRETTY_FUNCTION); > +printf("%p: %s\n", this, __PRETTY_FUNCTION__); > VBase::Print(); > } > > @@ -41,7 +41,7 @@ public: > > void Print () > { > -printf("%p: %s\n", this, LLVM_PRETTY_FUNCTION); > +printf("%p: %s\n", this, __PRETTY_FUNCTION__); > VBase::Print(); > } > }; > @@ -56,7 +56,7 @@ public: > { > printf("%p: %s \n%p: m_joiner1 = 0x%8.8x\n%p: m_joiner2 = > 0x%8.8x\n", > this, > - LLVM_PRETTY_FUNCTION, > + __PRETTY_FUNCTION__, > _joiner1, > m_joiner1, > _joiner2, > > Modified: > lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/virtual/main.cpp > URL: > http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/virtual/main.cpp?rev=278197=278196=278197=diff > > == > --- lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/virtual/main.cpp > (original) > +++ lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/virtual/main.cpp > Tue Aug 9 20:37:27 2016 > @@ -10,17 +10,17 @@ public: > > virtual const char * a() > { > -return LLVM_PRETTY_FUNCTION; > +return __PRETTY_FUNCTION__; > } > > virtual const char * b() > { > -return LLVM_PRETTY_FUNCTION; > +return __PRETTY_FUNCTION__; > } > > virtual const char * c() > { > -return LLVM_PRETTY_FUNCTION; > +return __PRETTY_FUNCTION__; > } > protected: > char m_pad; > @@ -34,7 +34,7 @@ public: > > virtual const char * aa() > { > -
Re: [Lldb-commits] [lldb] r278158 - Remove CFData from the xcodeproj as well
My mistake -- I should have updated the *.pbxproj file with r278142. Thanks for fixing this Enrico! vedant > On Aug 9, 2016, at 1:32 PM, Enrico Granata via lldb-commits >wrote: > > Author: enrico > Date: Tue Aug 9 15:32:42 2016 > New Revision: 278158 > > URL: http://llvm.org/viewvc/llvm-project?rev=278158=rev > Log: > Remove CFData from the xcodeproj as well > > Modified: >lldb/trunk/tools/debugserver/debugserver.xcodeproj/project.pbxproj > > Modified: lldb/trunk/tools/debugserver/debugserver.xcodeproj/project.pbxproj > URL: > http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/debugserver/debugserver.xcodeproj/project.pbxproj?rev=278158=278157=278158=diff > == > --- lldb/trunk/tools/debugserver/debugserver.xcodeproj/project.pbxproj > (original) > +++ lldb/trunk/tools/debugserver/debugserver.xcodeproj/project.pbxproj Tue > Aug 9 15:32:42 2016 > @@ -38,7 +38,6 @@ > 26CE05C1115C36510022F371 /* DNBArchImpl.cpp in Sources */ = > {isa = PBXBuildFile; fileRef = 2675D4220CCEB705000F49AF /* DNBArchImpl.cpp > */; }; > 26CE05C2115C36550022F371 /* DNBArchImpl.cpp in Sources */ = > {isa = PBXBuildFile; fileRef = 26C637FB0C71334A0024798E /* DNBArchImpl.cpp > */; }; > 26CE05C3115C36580022F371 /* CFString.cpp in Sources */ = {isa = > PBXBuildFile; fileRef = 2695DD9B0D3EC160007E4CA2 /* CFString.cpp */; }; > - 26CE05C4115C36590022F371 /* CFData.cpp in Sources */ = {isa = > PBXBuildFile; fileRef = 2695DE2E0D3EE55B007E4CA2 /* CFData.cpp */; }; > 26CE05C5115C36590022F371 /* CFBundle.cpp in Sources */ = {isa = > PBXBuildFile; fileRef = 2695DD910D3EBFF6007E4CA2 /* CFBundle.cpp */; }; > 26CE05CF115C36F70022F371 /* CoreFoundation.framework in > Frameworks */ = {isa = PBXBuildFile; fileRef = 26ACA3340D3E956300A2120B /* > CoreFoundation.framework */; settings = {ATTRIBUTES = (Required, ); }; }; > 26CE05F1115C387C0022F371 /* PseudoTerminal.cpp in Sources */ = > {isa = PBXBuildFile; fileRef = AF67ABFF0D34604D0022D128 /* PseudoTerminal.cpp > */; }; > @@ -71,7 +70,6 @@ > 456F67601AD46CE9002850C2 /* DNBArchImpl.cpp in Sources */ = > {isa = PBXBuildFile; fileRef = 2675D4220CCEB705000F49AF /* DNBArchImpl.cpp > */; }; > 456F67611AD46CE9002850C2 /* DNBArchImpl.cpp in Sources */ = > {isa = PBXBuildFile; fileRef = 26C637FB0C71334A0024798E /* DNBArchImpl.cpp > */; }; > 456F67621AD46CE9002850C2 /* CFString.cpp in Sources */ = {isa = > PBXBuildFile; fileRef = 2695DD9B0D3EC160007E4CA2 /* CFString.cpp */; }; > - 456F67631AD46CE9002850C2 /* CFData.cpp in Sources */ = {isa = > PBXBuildFile; fileRef = 2695DE2E0D3EE55B007E4CA2 /* CFData.cpp */; }; > 456F67641AD46CE9002850C2 /* CFBundle.cpp in Sources */ = {isa = > PBXBuildFile; fileRef = 2695DD910D3EBFF6007E4CA2 /* CFBundle.cpp */; }; > 456F67651AD46CE9002850C2 /* PseudoTerminal.cpp in Sources */ = > {isa = PBXBuildFile; fileRef = AF67ABFF0D34604D0022D128 /* PseudoTerminal.cpp > */; }; > 456F67661AD46CE9002850C2 /* StringExtractor.cpp in Sources */ = > {isa = PBXBuildFile; fileRef = 2660D9CC1192280900958FBD /* > StringExtractor.cpp */; }; > @@ -104,8 +102,6 @@ > 2695DD920D3EBFF6007E4CA2 /* CFBundle.h */ = {isa = > PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path > = CFBundle.h; sourceTree = ""; }; > 2695DD9A0D3EC160007E4CA2 /* CFString.h */ = {isa = > PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path > = CFString.h; sourceTree = ""; }; > 2695DD9B0D3EC160007E4CA2 /* CFString.cpp */ = {isa = > PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; > path = CFString.cpp; sourceTree = ""; }; > - 2695DE2D0D3EE55B007E4CA2 /* CFData.h */ = {isa = > PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path > = CFData.h; sourceTree = ""; }; > - 2695DE2E0D3EE55B007E4CA2 /* CFData.cpp */ = {isa = > PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; > path = CFData.cpp; sourceTree = ""; }; > 269E8DF8164B2ED200AD65F6 /* com.apple.debugserver.posix.plist > */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = > text.plist.xml; path = com.apple.debugserver.posix.plist; sourceTree = > ""; }; > 26A02918114AB9240029C479 /* debugserver.cpp */ = {isa = > PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; > path = debugserver.cpp; sourceTree = ""; }; > 26A4BAED0D498B7D00A9BEAB /* com.apple.debugserver.plist */ = > {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = > text.plist.xml; path = com.apple.debugserver.plist; sourceTree = ""; }; > @@ -323,8 +319,6 @@ >
[Lldb-commits] [lldb] r278197 - Undid LLVM macro usage in test suite test subject files.
Author: tfiala Date: Tue Aug 9 20:37:27 2016 New Revision: 278197 URL: http://llvm.org/viewvc/llvm-project?rev=278197=rev Log: Undid LLVM macro usage in test suite test subject files. Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/cpp/main.cpp lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/diamond/main.cpp lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/virtual/main.cpp Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/cpp/main.cpp URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/cpp/main.cpp?rev=278197=278196=278197=diff == --- lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/cpp/main.cpp (original) +++ lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/cpp/main.cpp Tue Aug 9 20:37:27 2016 @@ -16,15 +16,15 @@ namespace a { ~c(); void func1() { -puts (LLVM_PRETTY_FUNCTION); +puts (__PRETTY_FUNCTION__); } void func2() { -puts (LLVM_PRETTY_FUNCTION); +puts (__PRETTY_FUNCTION__); } void func3() { -puts (LLVM_PRETTY_FUNCTION); +puts (__PRETTY_FUNCTION__); } }; @@ -39,11 +39,11 @@ namespace b { ~c(); void func1() { -puts (LLVM_PRETTY_FUNCTION); +puts (__PRETTY_FUNCTION__); } void func3() { -puts (LLVM_PRETTY_FUNCTION); +puts (__PRETTY_FUNCTION__); } }; @@ -58,11 +58,11 @@ namespace c { ~d() {} void func2() { -puts (LLVM_PRETTY_FUNCTION); +puts (__PRETTY_FUNCTION__); } void func3() { -puts (LLVM_PRETTY_FUNCTION); +puts (__PRETTY_FUNCTION__); } }; } Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/diamond/main.cpp URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/diamond/main.cpp?rev=278197=278196=278197=diff == --- lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/diamond/main.cpp (original) +++ lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/diamond/main.cpp Tue Aug 9 20:37:27 2016 @@ -17,7 +17,7 @@ public: virtual ~VBase() {} void Print() { -printf("%p: %s\n%p: m_value = 0x%8.8x\n", this, LLVM_PRETTY_FUNCTION, _value, m_value); +printf("%p: %s\n%p: m_value = 0x%8.8x\n", this, __PRETTY_FUNCTION__, _value, m_value); } int m_value; }; @@ -28,7 +28,7 @@ public: Derived1() {}; void Print () { -printf("%p: %s\n", this, LLVM_PRETTY_FUNCTION); +printf("%p: %s\n", this, __PRETTY_FUNCTION__); VBase::Print(); } @@ -41,7 +41,7 @@ public: void Print () { -printf("%p: %s\n", this, LLVM_PRETTY_FUNCTION); +printf("%p: %s\n", this, __PRETTY_FUNCTION__); VBase::Print(); } }; @@ -56,7 +56,7 @@ public: { printf("%p: %s \n%p: m_joiner1 = 0x%8.8x\n%p: m_joiner2 = 0x%8.8x\n", this, - LLVM_PRETTY_FUNCTION, + __PRETTY_FUNCTION__, _joiner1, m_joiner1, _joiner2, Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/virtual/main.cpp URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/virtual/main.cpp?rev=278197=278196=278197=diff == --- lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/virtual/main.cpp (original) +++ lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/virtual/main.cpp Tue Aug 9 20:37:27 2016 @@ -10,17 +10,17 @@ public: virtual const char * a() { -return LLVM_PRETTY_FUNCTION; +return __PRETTY_FUNCTION__; } virtual const char * b() { -return LLVM_PRETTY_FUNCTION; +return __PRETTY_FUNCTION__; } virtual const char * c() { -return LLVM_PRETTY_FUNCTION; +return __PRETTY_FUNCTION__; } protected: char m_pad; @@ -34,7 +34,7 @@ public: virtual const char * aa() { -return LLVM_PRETTY_FUNCTION; +return __PRETTY_FUNCTION__; } protected: @@ -50,12 +50,12 @@ public: virtual const char * a() { -return LLVM_PRETTY_FUNCTION; +return __PRETTY_FUNCTION__; } virtual const char * b() { -return LLVM_PRETTY_FUNCTION; +return __PRETTY_FUNCTION__; } protected: char m_pad; @@ -70,7 +70,7 @@ public: virtual const char * a() { -return
[Lldb-commits] [lldb] r278190 - Undo usage of LLVM macros in debugserver
Author: tfiala Date: Tue Aug 9 19:53:21 2016 New Revision: 278190 URL: http://llvm.org/viewvc/llvm-project?rev=278190=rev Log: Undo usage of LLVM macros in debugserver We don't take a dependency on LLVM in debugserver. This was failing to compile before. Modified: lldb/trunk/tools/debugserver/source/RNBRemote.cpp Modified: lldb/trunk/tools/debugserver/source/RNBRemote.cpp URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/debugserver/source/RNBRemote.cpp?rev=278190=278189=278190=diff == --- lldb/trunk/tools/debugserver/source/RNBRemote.cpp (original) +++ lldb/trunk/tools/debugserver/source/RNBRemote.cpp Tue Aug 9 19:53:21 2016 @@ -183,14 +183,14 @@ RNBRemote::RNBRemote () : m_enable_compression_next_send_packet (false), m_compression_mode (compression_types::none) { -DNBLogThreadedIf (LOG_RNB_REMOTE, "%s", LLVM_PRETTY_FUNCTION); +DNBLogThreadedIf (LOG_RNB_REMOTE, "%s", __PRETTY_FUNCTION__); CreatePacketTable (); } RNBRemote::~RNBRemote() { -DNBLogThreadedIf (LOG_RNB_REMOTE, "%s", LLVM_PRETTY_FUNCTION); +DNBLogThreadedIf (LOG_RNB_REMOTE, "%s", __PRETTY_FUNCTION__); StopReadRemoteDataThread(); } ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r278188 - Add a newline to the end of the file to remove the clang warnings.
Author: jingham Date: Tue Aug 9 19:45:58 2016 New Revision: 278188 URL: http://llvm.org/viewvc/llvm-project?rev=278188=rev Log: Add a newline to the end of the file to remove the clang warnings. Modified: lldb/trunk/include/lldb/Host/PosixApi.h Modified: lldb/trunk/include/lldb/Host/PosixApi.h URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Host/PosixApi.h?rev=278188=278187=278188=diff == --- lldb/trunk/include/lldb/Host/PosixApi.h (original) +++ lldb/trunk/include/lldb/Host/PosixApi.h Tue Aug 9 19:45:58 2016 @@ -20,4 +20,4 @@ #include "lldb/Host/windows/PosixApi.h" #endif -#endif \ No newline at end of file +#endif ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r278182 - Fix build on android and Linux.
Author: zturner Date: Tue Aug 9 19:02:58 2016 New Revision: 278182 URL: http://llvm.org/viewvc/llvm-project?rev=278182=rev Log: Fix build on android and Linux. gettimeofday() isn't defined without a special header. Rather than rely on C apis, let's just use modern C++11 to do this portably on all platforms using std::chrono. Modified: lldb/trunk/include/lldb/Host/TimeValue.h lldb/trunk/source/Host/common/TimeValue.cpp Modified: lldb/trunk/include/lldb/Host/TimeValue.h URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Host/TimeValue.h?rev=278182=278181=278182=diff == --- lldb/trunk/include/lldb/Host/TimeValue.h (original) +++ lldb/trunk/include/lldb/Host/TimeValue.h Tue Aug 9 19:02:58 2016 @@ -35,7 +35,7 @@ public: TimeValue(); TimeValue(const TimeValue& rhs); TimeValue(const struct timespec& ts); -explicit TimeValue(uint32_t seconds, uint32_t nanos = 0); +explicit TimeValue(uint32_t seconds, uint64_t nanos = 0); ~TimeValue(); //-- Modified: lldb/trunk/source/Host/common/TimeValue.cpp URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Host/common/TimeValue.cpp?rev=278182=278181=278182=diff == --- lldb/trunk/source/Host/common/TimeValue.cpp (original) +++ lldb/trunk/source/Host/common/TimeValue.cpp Tue Aug 9 19:02:58 2016 @@ -20,6 +20,8 @@ #endif // C++ Includes +#include + // Other libraries and framework includes // Project includes #include "lldb/Core/Stream.h" @@ -48,7 +50,7 @@ TimeValue::TimeValue(const struct timesp { } -TimeValue::TimeValue(uint32_t seconds, uint32_t nanos) : +TimeValue::TimeValue(uint32_t seconds, uint64_t nanos) : m_nano_seconds((uint64_t) seconds * NanoSecPerSec + nanos) { } @@ -123,23 +125,11 @@ TimeValue::OffsetWithNanoSeconds (uint64 TimeValue TimeValue::Now() { -uint32_t seconds, nanoseconds; -#if _MSC_VER -SYSTEMTIME st; -GetSystemTime(); -nanoseconds = st.wMilliseconds * 100; -FILETIME ft; -SystemTimeToFileTime(, ); - -seconds = uint64_t)ft.dwHighDateTime) << 32 | ft.dwLowDateTime) / 1000) - 11644473600ULL; -#else -struct timeval tv; -gettimeofday(, NULL); -seconds = tv.tv_sec; -nanoseconds = tv.tv_usec * NanoSecPerMicroSec; -#endif -TimeValue now(seconds, nanoseconds); -return now; + using namespace std::chrono; + auto now = system_clock::now(); + auto ns_since_epoch = duration_cast(now.time_since_epoch()).count(); + + return TimeValue(0, ns_since_epoch); } //-- ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r278177 - Delete Host/windows/win32.h
Author: zturner Date: Tue Aug 9 18:06:08 2016 New Revision: 278177 URL: http://llvm.org/viewvc/llvm-project?rev=278177=rev Log: Delete Host/windows/win32.h It's always hard to remember when to include this file, and when you do include it it's hard to remember what preprocessor check it needs to be behind, and then you further have to remember whether it's windows.h or win32.h which you need to include. This patch changes the name to PosixApi.h, which is more appropriately named, and makes it independent of any preprocessor setting. There's still the issue of people not knowing when to include this, because there's not a well-defined set of things it exposes other than "whatever is missing on Windows", but at least this should make it less painful to fix when problems arise. This patch depends on LLVM revision r278170. Added: lldb/trunk/include/lldb/Host/PosixApi.h lldb/trunk/include/lldb/Host/windows/PosixApi.h - copied, changed from r278166, lldb/trunk/include/lldb/Host/windows/win32.h Removed: lldb/trunk/include/lldb/Host/windows/win32.h Modified: lldb/trunk/include/lldb/Host/File.h lldb/trunk/include/lldb/Host/TimeValue.h lldb/trunk/include/lldb/lldb-private.h lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/cpp/main.cpp lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/diamond/main.cpp lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/virtual/main.cpp lldb/trunk/packages/Python/lldbsuite/test/make/test_common.h lldb/trunk/source/API/SystemInitializerFull.cpp lldb/trunk/source/Commands/CommandObjectTarget.cpp lldb/trunk/source/Core/ConnectionSharedMemory.cpp lldb/trunk/source/Core/CxaDemangle.cpp lldb/trunk/source/Core/Disassembler.cpp lldb/trunk/source/Core/Error.cpp lldb/trunk/source/Core/Mangled.cpp lldb/trunk/source/Core/Module.cpp lldb/trunk/source/Core/Stream.cpp lldb/trunk/source/Host/common/NativeRegisterContext.cpp lldb/trunk/source/Host/common/SocketAddress.cpp lldb/trunk/source/Host/common/Symbols.cpp lldb/trunk/source/Host/common/Terminal.cpp lldb/trunk/source/Host/windows/FileSystem.cpp lldb/trunk/source/Host/windows/Windows.cpp lldb/trunk/source/Initialization/SystemInitializerCommon.cpp lldb/trunk/source/Interpreter/CommandInterpreter.cpp lldb/trunk/source/Interpreter/OptionValueBoolean.cpp lldb/trunk/source/Plugins/Instruction/ARM/EmulateInstructionARM.cpp lldb/trunk/source/Plugins/Instruction/MIPS64/EmulateInstructionMIPS64.cpp lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp lldb/trunk/source/Plugins/ObjectContainer/BSD-Archive/ObjectContainerBSDArchive.cpp lldb/trunk/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp lldb/trunk/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp lldb/trunk/source/Plugins/Platform/Android/AdbClient.cpp lldb/trunk/source/Plugins/Process/MacOSX-Kernel/CommunicationKDP.cpp lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp lldb/trunk/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp lldb/trunk/source/Plugins/ScriptInterpreter/Python/lldb-python.h lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugAranges.cpp lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.cpp lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugLine.cpp lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugPubnames.cpp lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp lldb/trunk/source/Plugins/SymbolVendor/ELF/SymbolVendorELF.cpp lldb/trunk/source/Plugins/SymbolVendor/MacOSX/SymbolVendorMacOSX.cpp lldb/trunk/source/Symbol/DWARFCallFrameInfo.cpp lldb/trunk/source/Symbol/ObjectFile.cpp lldb/trunk/source/Symbol/Symtab.cpp lldb/trunk/source/Target/FileAction.cpp lldb/trunk/source/Target/PathMappingList.cpp lldb/trunk/source/Target/Platform.cpp lldb/trunk/source/Target/ProcessInfo.cpp lldb/trunk/source/Target/Target.cpp lldb/trunk/source/Target/TargetList.cpp lldb/trunk/source/Target/ThreadPlan.cpp lldb/trunk/source/Target/ThreadPlanPython.cpp lldb/trunk/source/Utility/PseudoTerminal.cpp lldb/trunk/source/Utility/TimeSpecTimeout.h lldb/trunk/tools/debugserver/source/PThreadEvent.cpp lldb/trunk/tools/debugserver/source/RNBRemote.cpp Modified: lldb/trunk/include/lldb/Host/File.h URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Host/File.h?rev=278177=278176=278177=diff == --- lldb/trunk/include/lldb/Host/File.h (original) +++ lldb/trunk/include/lldb/Host/File.h Tue Aug 9 18:06:08 2016 @@ -20,6 +20,7 @@ // Project includes #include "lldb/lldb-private.h" #include
[Lldb-commits] [lldb] r278166 - Adjust LLDB's iOS simulator interface for changes in CoreSimulator
Author: enrico Date: Tue Aug 9 16:16:58 2016 New Revision: 278166 URL: http://llvm.org/viewvc/llvm-project?rev=278166=rev Log: Adjust LLDB's iOS simulator interface for changes in CoreSimulator rdar://27732333 and rdar://27732377 Modified: lldb/trunk/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.cpp lldb/trunk/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.h lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulator.cpp lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulator.h lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.h lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm Modified: lldb/trunk/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.cpp URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.cpp?rev=278166=278165=278166=diff == --- lldb/trunk/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.cpp (original) +++ lldb/trunk/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.cpp Tue Aug 9 16:16:58 2016 @@ -52,7 +52,9 @@ PlatformAppleSimulator::Terminate () //-- PlatformAppleSimulator::PlatformAppleSimulator () : PlatformDarwin (true), -m_core_simulator_framework_path() +m_core_sim_path_mutex (), +m_core_simulator_framework_path(), +m_device () { } @@ -105,7 +107,7 @@ PlatformAppleSimulator::GetStatus (Strea // current simulator PlatformAppleSimulator::LoadCoreSimulator(); -CoreSimulatorSupport::DeviceSet devices = CoreSimulatorSupport::DeviceSet::GetAvailableDevices(); +CoreSimulatorSupport::DeviceSet devices = CoreSimulatorSupport::DeviceSet::GetAvailableDevices(GetDeveloperDirectory()); const size_t num_devices = devices.GetNumDevices(); if (num_devices) { @@ -155,7 +157,7 @@ PlatformAppleSimulator::ConnectRemote (A if (arg_cstr) { std::string arg_str(arg_cstr); -CoreSimulatorSupport::DeviceSet devices = CoreSimulatorSupport::DeviceSet::GetAvailableDevices(); +CoreSimulatorSupport::DeviceSet devices = CoreSimulatorSupport::DeviceSet::GetAvailableDevices(GetDeveloperDirectory()); devices.ForEach([this, _str](const CoreSimulatorSupport::Device ) -> bool { if (arg_str == device.GetUDID() || arg_str == device.GetName()) { @@ -252,7 +254,7 @@ FileSpec PlatformAppleSimulator::GetCoreSimulatorPath() { #if defined(__APPLE__) -std::lock_guard guard(m_mutex); +std::lock_guard guard(m_core_sim_path_mutex); if (!m_core_simulator_framework_path.hasValue()) { const char *developer_dir = GetDeveloperDirectory(); @@ -291,7 +293,7 @@ PlatformAppleSimulator::GetSimulatorDevi if (!m_device.hasValue()) { const CoreSimulatorSupport::DeviceType::ProductFamilyID dev_id = CoreSimulatorSupport::DeviceType::ProductFamilyID::iPhone; -m_device = CoreSimulatorSupport::DeviceSet::GetAvailableDevices().GetFanciest(dev_id); +m_device = CoreSimulatorSupport::DeviceSet::GetAvailableDevices(GetDeveloperDirectory()).GetFanciest(dev_id); } if (m_device.hasValue()) Modified: lldb/trunk/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.h URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.h?rev=278166=278165=278166=diff == --- lldb/trunk/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.h (original) +++ lldb/trunk/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.h Tue Aug 9 16:16:58 2016 @@ -12,6 +12,8 @@ // C Includes // C++ Includes +#include + // Other libraries and framework includes // Project includes #include "lldb/Host/FileSpec.h" @@ -59,6 +61,7 @@ public: lldb_private::Error ) override; protected: +std::mutex m_core_sim_path_mutex; llvm::Optional m_core_simulator_framework_path; llvm::Optional m_device; Modified: lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulator.cpp URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulator.cpp?rev=278166=278165=278166=diff == --- lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulator.cpp (original) +++ lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulator.cpp Tue Aug 9 16:16:58 2016 @@ -172,7 +172,9 @@ PlatformiOSSimulator::GetDescriptionStat //-- PlatformiOSSimulator::PlatformiOSSimulator () : PlatformAppleSimulator (), -m_sdk_directory () +m_sdk_dir_mutex (), +m_sdk_directory (), +m_build_update ()
Re: [Lldb-commits] [PATCH] D22831: [LLDB] Documentation for SBAddress class
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good, thanks for the changes and the documentation. Repository: rL LLVM https://reviews.llvm.org/D22831 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r278158 - Remove CFData from the xcodeproj as well
Author: enrico Date: Tue Aug 9 15:32:42 2016 New Revision: 278158 URL: http://llvm.org/viewvc/llvm-project?rev=278158=rev Log: Remove CFData from the xcodeproj as well Modified: lldb/trunk/tools/debugserver/debugserver.xcodeproj/project.pbxproj Modified: lldb/trunk/tools/debugserver/debugserver.xcodeproj/project.pbxproj URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/debugserver/debugserver.xcodeproj/project.pbxproj?rev=278158=278157=278158=diff == --- lldb/trunk/tools/debugserver/debugserver.xcodeproj/project.pbxproj (original) +++ lldb/trunk/tools/debugserver/debugserver.xcodeproj/project.pbxproj Tue Aug 9 15:32:42 2016 @@ -38,7 +38,6 @@ 26CE05C1115C36510022F371 /* DNBArchImpl.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 2675D4220CCEB705000F49AF /* DNBArchImpl.cpp */; }; 26CE05C2115C36550022F371 /* DNBArchImpl.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 26C637FB0C71334A0024798E /* DNBArchImpl.cpp */; }; 26CE05C3115C36580022F371 /* CFString.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 2695DD9B0D3EC160007E4CA2 /* CFString.cpp */; }; - 26CE05C4115C36590022F371 /* CFData.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 2695DE2E0D3EE55B007E4CA2 /* CFData.cpp */; }; 26CE05C5115C36590022F371 /* CFBundle.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 2695DD910D3EBFF6007E4CA2 /* CFBundle.cpp */; }; 26CE05CF115C36F70022F371 /* CoreFoundation.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 26ACA3340D3E956300A2120B /* CoreFoundation.framework */; settings = {ATTRIBUTES = (Required, ); }; }; 26CE05F1115C387C0022F371 /* PseudoTerminal.cpp in Sources */ = {isa = PBXBuildFile; fileRef = AF67ABFF0D34604D0022D128 /* PseudoTerminal.cpp */; }; @@ -71,7 +70,6 @@ 456F67601AD46CE9002850C2 /* DNBArchImpl.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 2675D4220CCEB705000F49AF /* DNBArchImpl.cpp */; }; 456F67611AD46CE9002850C2 /* DNBArchImpl.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 26C637FB0C71334A0024798E /* DNBArchImpl.cpp */; }; 456F67621AD46CE9002850C2 /* CFString.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 2695DD9B0D3EC160007E4CA2 /* CFString.cpp */; }; - 456F67631AD46CE9002850C2 /* CFData.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 2695DE2E0D3EE55B007E4CA2 /* CFData.cpp */; }; 456F67641AD46CE9002850C2 /* CFBundle.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 2695DD910D3EBFF6007E4CA2 /* CFBundle.cpp */; }; 456F67651AD46CE9002850C2 /* PseudoTerminal.cpp in Sources */ = {isa = PBXBuildFile; fileRef = AF67ABFF0D34604D0022D128 /* PseudoTerminal.cpp */; }; 456F67661AD46CE9002850C2 /* StringExtractor.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 2660D9CC1192280900958FBD /* StringExtractor.cpp */; }; @@ -104,8 +102,6 @@ 2695DD920D3EBFF6007E4CA2 /* CFBundle.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = CFBundle.h; sourceTree = ""; }; 2695DD9A0D3EC160007E4CA2 /* CFString.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = CFString.h; sourceTree = ""; }; 2695DD9B0D3EC160007E4CA2 /* CFString.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = CFString.cpp; sourceTree = ""; }; - 2695DE2D0D3EE55B007E4CA2 /* CFData.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = CFData.h; sourceTree = ""; }; - 2695DE2E0D3EE55B007E4CA2 /* CFData.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = CFData.cpp; sourceTree = ""; }; 269E8DF8164B2ED200AD65F6 /* com.apple.debugserver.posix.plist */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.plist.xml; path = com.apple.debugserver.posix.plist; sourceTree = ""; }; 26A02918114AB9240029C479 /* debugserver.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = debugserver.cpp; sourceTree = ""; }; 26A4BAED0D498B7D00A9BEAB /* com.apple.debugserver.plist */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.plist.xml; path = com.apple.debugserver.plist; sourceTree = ""; }; @@ -323,8 +319,6 @@ AF0934BB18E12B92005A11FD /* GenealogySPI.h */, 2695DD920D3EBFF6007E4CA2 /* CFBundle.h */, 2695DD910D3EBFF6007E4CA2 /* CFBundle.cpp */, - 2695DE2D0D3EE55B007E4CA2 /* CFData.h */, - 2695DE2E0D3EE55B007E4CA2 /* CFData.cpp */,
Re: [Lldb-commits] [PATCH] D20386: Correct makefile.rules to use arm/aarch64 target specific AR and OBJCOPY
omjavaid added inline comments. Comment at: packages/Python/lldbsuite/test/make/Makefile.rules:304 @@ +303,3 @@ + $(subst $(3),$(1),$(2)), \ + $(if $(findstring ar,$(1)), \ +$(if $(findstring gcc,$(3)), \ labath wrote: > I think like we should replace ar with gcc-ar always, and not just when we > don't have a version suffix present. When I have a gcc installed to a custom > prefix, I get `$prefix/gcc-ar`, but not `$prefix/ar`. (Previously we would > just use `ar` unconditionally, which was probably a bug.) > > Next, when you specify a clang compiler as `clang-3.5`, you will produce > `ar-3.5`, which almost certainly does not exist. I think that in case of > clang we should just strip the version suffix (produce `XXX-ar`) and hope for > the best (should work for all our current use cases). > > Finally, I don't think objcopy is ever versioned with gcc (correct me if I am > wrong), so I think that in case of objcopy we should strip the version suffix > unconditionally `XXX-objcopy`. > > So, to summarize, these are the transformations I think are wrong: > `foo/gcc` -> `foo/ar` (should be `foo/gcc-ar`) > `clang-3.5` -> `ar-3.5` (should be `ar`) > `gcc-4.8` -> `objcopy-4.8` (should be `objcopy`) > > Let me know if these are compatible with your requirements. If we can't find > a set of rules that work everywhere, we will have to abandon the magic (or > maybe just leave a simple one), and require the user to specify the paths > manually... I checked with gcc people in my team and here is what they have to say. omjavaid, gcc-ar is a version of ar with LTO support omjavaid, ar is just ar omjavaid, likewise with gcc-nm and gcc-ranlib omjavaid, ar comes from binutils, gcc-ar comes from gcc I agree with all other points you raised except for using gcc-ar in all cases. We should decide between ar (binutils) or gcc-ar (LTO support gcc packaged). Also present code doesnt generate obcopy-4.8 for me when i specify gcc-4.8. If it does for you let me know. https://reviews.llvm.org/D20386 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] D22831: [LLDB] Documentation for SBAddress class
jafl updated this revision to Diff 67405. jafl added a comment. Incorporate additional feedback from Greg Clayton. Repository: rL LLVM https://reviews.llvm.org/D22831 Files: include/lldb/API/SBAddress.h Index: include/lldb/API/SBAddress.h === --- include/lldb/API/SBAddress.h +++ include/lldb/API/SBAddress.h @@ -15,6 +15,93 @@ namespace lldb { +//-- +/// \class SBAddress +/// +/// Represents an address. An address may refer to code or data from an +/// existing module (SBModule), or it may refer to something on the stack +/// or heap. +/// +/// SBAddress objects use two different kinds of addresses: file addresses +/// and load addresses. +/// +/// File addresses refer to the raw address as it is known in the object +/// file that the module is using. File addresses will match the virtual +/// addresses that are found in the object file, such as the address values +/// in the symbols in the native symbol tables, unwind tables and any other +/// data structures in the object file format (ELF, mach-o, COFF). File +/// addresses are not unique across multiple modules as many modules might +/// contain a file address of 0x0 (possibly the first function in the .text +/// section) since many object files, like shared libraries, have their +/// virtual addresses start at 0x0. Since file addresses are only unique +/// within an SBModule, you must use a valid module object to resolve a +/// file address into an SBAddress: +/// +/// lldb::SBAddress SBModule::ResolveFileAddress (lldb::addr_t vm_addr); +/// +/// File addresses are also useful in case you want to use other command +/// line tools that know how to extract data from an object file, like +/// objdump or many other tools that dump mach-o, ELF and COFF files. +/// +/// Load addresses represent a unique location within a process' address +/// space. A load address might represent a section/offset address within a +/// process. In this case the SBAddress will have a valid section +/// (lldb::SBAddress::GetSection() will return a SBSection that is valid), +/// and a valid offset (lldb::addr_t lldb::SBAddress::GetOffset()) into +/// that section. Or a load address might represent a unique location in +/// the process' memory space that doesn't resolve to a section within an +/// object file, like a location on the stack or heap. In this case the +/// address will not have a valid section (lldb::SBSection +/// lldb::SBAddress::GetSection() will return an SBSection that is *not* +/// valid), and lldb::SBAddress::GetOffset() will return the value load +/// address. You can resolve a load address back into a SBAddress by using +/// either of: +/// +/// SBAddress (lldb::addr_t load_addr, lldb::SBTarget ); +/// void SBAddress::SetLoadAddress (lldb::addr_t load_addr, lldb::SBTarget ); +/// +/// This will take the "load_addr" and figure out which section, if any, +/// that the load address belongs to within the specified target. If +/// "load_addr" belongs to a section, the resulting SBAddress objects will +/// contain a valid section and offset (address that matches data in an +/// object file's sections), otherwise it will have no section and the +/// offset will match "load_addr" (stack or heap address). +/// +/// If an address has a valid section, the address might refer to things +/// found in the debug information: +/// +/// SBModule - the module that contains the section +/// SBCompileUnit - the source file that was compiled to create this code +/// SBFunction - the function that contains this address +/// SBBlock - the deepest lexical block that contains the address within the SBFucntion +/// SBLineEntry - the file and line and column that contains the address +/// SBVariable - the static/global variable that contains the address +/// +/// If there is no debug information, then the address might also refer to +/// a symbol from the symbol table: +/// +/// SBSymbol - the symbol that contains the address +/// +/// If an address comes from an existing module, then it will be resolved +/// into an offset from its containing section in that module. That way it +/// can refer to the same logical location in the module that holds it even +/// if the module is unloaded and loaded at different addresses. Module +/// based SBAddresses are not bound to a particular target or process, but +/// you can ask the SBAddress where/if it has been loaded in a particular +/// target. +/// +/// The individual Get*() functions grab individual objects for a given +/// address and are less efficient if you want more than one symbol related +/// objects. Use one of the following when you want multiple debug symbol +/// related objects for an address: +/// ~~~ +/// * lldb::SBSymbolContext SBAddress::GetSymbolContext (uint32_t resolve_scope); +/// * lldb::SBSymbolContext SBTarget::ResolveSymbolContextForAddress (const SBAddress , uint32_t
Re: [Lldb-commits] [PATCH] D23070: [debugserver] Delete CFData.{h, cpp}, since they appear to be dead (NFCI)
This revision was automatically updated to reflect the committed changes. Closed by commit rL278142: [debugserver] Delete CFData.{h,cpp}, since they appear to be dead (NFCI) (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D23070?vs=66499=67373#toc Repository: rL LLVM https://reviews.llvm.org/D23070 Files: lldb/trunk/tools/debugserver/source/MacOSX/CFData.cpp lldb/trunk/tools/debugserver/source/MacOSX/CFData.h lldb/trunk/tools/debugserver/source/MacOSX/CMakeLists.txt lldb/trunk/tools/debugserver/source/MacOSX/MachProcess.mm Index: lldb/trunk/tools/debugserver/source/MacOSX/MachProcess.mm === --- lldb/trunk/tools/debugserver/source/MacOSX/MachProcess.mm +++ lldb/trunk/tools/debugserver/source/MacOSX/MachProcess.mm @@ -43,7 +43,6 @@ #include "PseudoTerminal.h" #include "CFBundle.h" -#include "CFData.h" #include "CFString.h" #ifdef WITH_SPRINGBOARD Index: lldb/trunk/tools/debugserver/source/MacOSX/CMakeLists.txt === --- lldb/trunk/tools/debugserver/source/MacOSX/CMakeLists.txt +++ lldb/trunk/tools/debugserver/source/MacOSX/CMakeLists.txt @@ -37,7 +37,6 @@ add_lldb_executable(debugserver HasAVX.s CFBundle.cpp - CFData.cpp CFString.cpp Genealogy.cpp MachException.cpp Index: lldb/trunk/tools/debugserver/source/MacOSX/CFData.h === --- lldb/trunk/tools/debugserver/source/MacOSX/CFData.h +++ lldb/trunk/tools/debugserver/source/MacOSX/CFData.h @@ -1,38 +0,0 @@ -//===-- CFData.h *- C++ -*-===// -// -// The LLVM Compiler Infrastructure -// -// This file is distributed under the University of Illinois Open Source -// License. See LICENSE.TXT for details. -// -//===--===// -// -// Created by Greg Clayton on 1/16/08. -// -//===--===// - -#ifndef __CFData_h__ -#define __CFData_h__ - -#include "CFUtils.h" - -class CFData : public CFReleaser -{ -public: -//-- -// Constructors and Destructors -//-- -CFData(CFDataRef data = NULL); -CFData(const CFData& rhs); -virtual ~CFData(); - -CFDataRef Serialize(CFPropertyListRef plist, CFPropertyListFormat format); -const uint8_t* GetBytePtr () const; -CFIndex GetLength () const; -protected: -//-- -// Classes that inherit from CFData can see and modify these -//-- -}; - -#endif // #ifndef __CFData_h__ Index: lldb/trunk/tools/debugserver/source/MacOSX/CFData.cpp === --- lldb/trunk/tools/debugserver/source/MacOSX/CFData.cpp +++ lldb/trunk/tools/debugserver/source/MacOSX/CFData.cpp @@ -1,74 +0,0 @@ -//===-- CFData.cpp --*- C++ -*-===// -// -// The LLVM Compiler Infrastructure -// -// This file is distributed under the University of Illinois Open Source -// License. See LICENSE.TXT for details. -// -//===--===// -// -// Created by Greg Clayton on 1/16/08. -// -//===--===// - -#include "CFData.h" - -//-- -// CFData constructor -//-- -CFData::CFData(CFDataRef data) : -CFReleaser(data) -{ - -} - -//-- -// CFData copy constructor -//-- -CFData::CFData(const CFData& rhs) : -CFReleaser(rhs) -{ - -} - -//-- -// Destructor -//-- -CFData::~CFData() -{ -} - - -CFIndex -CFData::GetLength() const -{ -CFDataRef data = get(); -if (data) -return CFDataGetLength (data); -return 0; -} - - -const uint8_t* -CFData::GetBytePtr() const -{ -CFDataRef data = get(); -if (data) -return CFDataGetBytePtr (data); -return NULL; -} - -CFDataRef -CFData::Serialize(CFPropertyListRef plist, CFPropertyListFormat format) -{ -CFAllocatorRef alloc = kCFAllocatorDefault; -reset(); -CFReleaser stream (::CFWriteStreamCreateWithAllocatedBuffers (alloc, alloc)); -::CFWriteStreamOpen (stream.get()); -CFIndex len =
[Lldb-commits] [lldb] r278142 - [debugserver] Delete CFData.{h, cpp}, since they appear to be dead (NFCI)
Author: vedantk Date: Tue Aug 9 12:42:11 2016 New Revision: 278142 URL: http://llvm.org/viewvc/llvm-project?rev=278142=rev Log: [debugserver] Delete CFData.{h,cpp}, since they appear to be dead (NFCI) Differential Revision: https://reviews.llvm.org/D23070 Removed: lldb/trunk/tools/debugserver/source/MacOSX/CFData.cpp lldb/trunk/tools/debugserver/source/MacOSX/CFData.h Modified: lldb/trunk/tools/debugserver/source/MacOSX/CMakeLists.txt lldb/trunk/tools/debugserver/source/MacOSX/MachProcess.mm Removed: lldb/trunk/tools/debugserver/source/MacOSX/CFData.cpp URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/debugserver/source/MacOSX/CFData.cpp?rev=278141=auto == --- lldb/trunk/tools/debugserver/source/MacOSX/CFData.cpp (original) +++ lldb/trunk/tools/debugserver/source/MacOSX/CFData.cpp (removed) @@ -1,74 +0,0 @@ -//===-- CFData.cpp --*- C++ -*-===// -// -// The LLVM Compiler Infrastructure -// -// This file is distributed under the University of Illinois Open Source -// License. See LICENSE.TXT for details. -// -//===--===// -// -// Created by Greg Clayton on 1/16/08. -// -//===--===// - -#include "CFData.h" - -//-- -// CFData constructor -//-- -CFData::CFData(CFDataRef data) : -CFReleaser(data) -{ - -} - -//-- -// CFData copy constructor -//-- -CFData::CFData(const CFData& rhs) : -CFReleaser(rhs) -{ - -} - -//-- -// Destructor -//-- -CFData::~CFData() -{ -} - - -CFIndex -CFData::GetLength() const -{ -CFDataRef data = get(); -if (data) -return CFDataGetLength (data); -return 0; -} - - -const uint8_t* -CFData::GetBytePtr() const -{ -CFDataRef data = get(); -if (data) -return CFDataGetBytePtr (data); -return NULL; -} - -CFDataRef -CFData::Serialize(CFPropertyListRef plist, CFPropertyListFormat format) -{ -CFAllocatorRef alloc = kCFAllocatorDefault; -reset(); -CFReleaser stream (::CFWriteStreamCreateWithAllocatedBuffers (alloc, alloc)); -::CFWriteStreamOpen (stream.get()); -CFIndex len = ::CFPropertyListWriteToStream (plist, stream.get(), format, NULL); -if (len > 0) -reset((CFDataRef)::CFWriteStreamCopyProperty (stream.get(), kCFStreamPropertyDataWritten)); -::CFWriteStreamClose (stream.get()); -return get(); -} - Removed: lldb/trunk/tools/debugserver/source/MacOSX/CFData.h URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/debugserver/source/MacOSX/CFData.h?rev=278141=auto == --- lldb/trunk/tools/debugserver/source/MacOSX/CFData.h (original) +++ lldb/trunk/tools/debugserver/source/MacOSX/CFData.h (removed) @@ -1,38 +0,0 @@ -//===-- CFData.h *- C++ -*-===// -// -// The LLVM Compiler Infrastructure -// -// This file is distributed under the University of Illinois Open Source -// License. See LICENSE.TXT for details. -// -//===--===// -// -// Created by Greg Clayton on 1/16/08. -// -//===--===// - -#ifndef __CFData_h__ -#define __CFData_h__ - -#include "CFUtils.h" - -class CFData : public CFReleaser -{ -public: -//-- -// Constructors and Destructors -//-- -CFData(CFDataRef data = NULL); -CFData(const CFData& rhs); -virtual ~CFData(); - -CFDataRef Serialize(CFPropertyListRef plist, CFPropertyListFormat format); -const uint8_t* GetBytePtr () const; -CFIndex GetLength () const; -protected: -//-- -// Classes that inherit from CFData can see and modify these -//-- -}; - -#endif // #ifndef __CFData_h__ Modified: lldb/trunk/tools/debugserver/source/MacOSX/CMakeLists.txt URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/debugserver/source/MacOSX/CMakeLists.txt?rev=278142=278141=278142=diff == ---
Re: [Lldb-commits] [PATCH] D22914: [WIP] Add concurrent packets support to gdb-remote client
clayborg added a comment. Let me know how things look on Mac. Our lock primitives are not as fast as linux. If all looks good on Mac speed wise, we should be good to go. https://reviews.llvm.org/D22914 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] D22914: [WIP] Add concurrent packets support to gdb-remote client
labath added a comment. These are the results before and after applying this change (on linux): Before: (lldb) process plugin packet speed-test Testing sending 1000 packets of various sizes: qSpeedTest(send=0 , recv=0 ) in 0.057456000 sec for 17404.62 packets/sec ( 0.057456 ms per packet) with standard deviation of 0.012368 ms qSpeedTest(send=0 , recv=4 ) in 0.048495000 sec for 20620.68 packets/sec ( 0.048495 ms per packet) with standard deviation of 0.002189 ms qSpeedTest(send=0 , recv=8 ) in 0.04827 sec for 20716.80 packets/sec ( 0.048270 ms per packet) with standard deviation of 0.001979 ms qSpeedTest(send=0 , recv=16 ) in 0.048686000 sec for 20539.79 packets/sec ( 0.048686 ms per packet) with standard deviation of 0.001992 ms qSpeedTest(send=0 , recv=32 ) in 0.050556000 sec for 19780.04 packets/sec ( 0.050556 ms per packet) with standard deviation of 0.005152 ms qSpeedTest(send=0 , recv=64 ) in 0.051095000 sec for 19571.39 packets/sec ( 0.051095 ms per packet) with standard deviation of 0.004969 ms qSpeedTest(send=0 , recv=128) in 0.056365000 sec for 17741.51 packets/sec ( 0.056365 ms per packet) with standard deviation of 0.007733 ms qSpeedTest(send=0 , recv=256) in 0.061426000 sec for 16279.75 packets/sec ( 0.061426 ms per packet) with standard deviation of 0.003777 ms qSpeedTest(send=0 , recv=512) in 0.065135000 sec for 15352.73 packets/sec ( 0.065135 ms per packet) with standard deviation of 0.003205 ms qSpeedTest(send=0 , recv=1024 ) in 0.070767000 sec for 14130.88 packets/sec ( 0.070767 ms per packet) with standard deviation of 0.005090 ms qSpeedTest(send=4 , recv=0 ) in 0.053847000 sec for 18571.14 packets/sec ( 0.053847 ms per packet) with standard deviation of 0.003236 ms qSpeedTest(send=4 , recv=4 ) in 0.054817000 sec for 18242.52 packets/sec ( 0.054817 ms per packet) with standard deviation of 0.002795 ms qSpeedTest(send=4 , recv=8 ) in 0.054378000 sec for 18389.79 packets/sec ( 0.054378 ms per packet) with standard deviation of 0.002432 ms qSpeedTest(send=4 , recv=16 ) in 0.054126000 sec for 18475.41 packets/sec ( 0.054126 ms per packet) with standard deviation of 0.005307 ms qSpeedTest(send=4 , recv=32 ) in 0.047904000 sec for 20875.08 packets/sec ( 0.047904 ms per packet) with standard deviation of 0.003132 ms qSpeedTest(send=4 , recv=64 ) in 0.051456000 sec for 19434.08 packets/sec ( 0.051456 ms per packet) with standard deviation of 0.004501 ms qSpeedTest(send=4 , recv=128) in 0.054608000 sec for 18312.34 packets/sec ( 0.054608 ms per packet) with standard deviation of 0.003507 ms qSpeedTest(send=4 , recv=256) in 0.054924000 sec for 18206.98 packets/sec ( 0.054924 ms per packet) with standard deviation of 0.005625 ms qSpeedTest(send=4 , recv=512) in 0.06418 sec for 15581.18 packets/sec ( 0.064180 ms per packet) with standard deviation of 0.005875 ms qSpeedTest(send=4 , recv=1024 ) in 0.068276000 sec for 14646.44 packets/sec ( 0.068276 ms per packet) with standard deviation of 0.003039 ms qSpeedTest(send=8 , recv=0 ) in 0.053046000 sec for 18851.56 packets/sec ( 0.053046 ms per packet) with standard deviation of 0.003500 ms qSpeedTest(send=8 , recv=4 ) in 0.054089000 sec for 18488.05 packets/sec ( 0.054089 ms per packet) with standard deviation of 0.006284 ms qSpeedTest(send=8 , recv=8 ) in 0.049932000 sec for 20027.24 packets/sec ( 0.049932 ms per packet) with standard deviation of 0.004150 ms qSpeedTest(send=8 , recv=16 ) in 0.058777000 sec for 17013.46 packets/sec ( 0.058777 ms per packet) with standard deviation of 0.008652 ms qSpeedTest(send=8 , recv=32 ) in 0.051253000 sec for 19511.05 packets/sec ( 0.051253 ms per packet) with standard deviation of 0.008256 ms qSpeedTest(send=8 , recv=64 ) in 0.052551000 sec for 19029.13 packets/sec ( 0.052551 ms per packet) with standard deviation of 0.006581 ms qSpeedTest(send=8 , recv=128) in 0.049986000 sec for 20005.60 packets/sec ( 0.049986 ms per packet) with standard deviation of 0.005448 ms qSpeedTest(send=8 , recv=256) in 0.054557000 sec for 18329.46 packets/sec ( 0.054557 ms per packet) with standard deviation of 0.006423 ms qSpeedTest(send=8 , recv=512) in 0.052093000 sec for 19196.44 packets/sec ( 0.052093 ms per packet) with standard deviation of 0.002142 ms qSpeedTest(send=8 , recv=1024 ) in 0.057268000 sec for 17461.76 packets/sec ( 0.057268 ms per packet) with standard deviation of 0.001820 ms qSpeedTest(send=16 , recv=0 ) in 0.044685000 sec for 22378.87 packets/sec ( 0.044685 ms per packet) with standard deviation of 0.001565
Re: [Lldb-commits] [PATCH] D22950: Centralize all calls to select() into a single class so we always call select properly
I patched it in this morning, but it doesn't compile on Windows. I was able to make it work with a few tweaks at the top of SelectHelper.cpp: // C Includes #include #if defined(_WIN32) #define NOMINMAX #include #else #include #endif The key bits: don't include on Windows and #define NOMINMAX on Windows to avoid stupid macros that conflict with std::min and std::max. I'd probably put the #if under "// Other libraries and framework includes" rather than "// C Includes", but that's a minor style nit. Either way, this change makes it compile on Windows. Adrian. On Mon, Aug 8, 2016 at 5:05 PM, Greg Claytonwrote: > clayborg updated this revision to Diff 67253. > clayborg added a comment. > > Updated with all comments taken into account. Zach, please try this out > and let me know if it compiles. > > > https://reviews.llvm.org/D22950 > > Files: > include/lldb/Utility/SelectHelper.h > lldb.xcodeproj/project.pbxproj > source/Host/common/Editline.cpp > source/Host/posix/ConnectionFileDescriptorPosix.cpp > source/Host/posix/PipePosix.cpp > source/Target/Process.cpp > source/Utility/SelectHelper.cpp > > ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] D22369: DWARFDeclContext: Don't add '::' in front of symbol names
labath abandoned this revision. labath added a comment. Ok, thanks for the explanation. It'll take some time for me to parse all the information there, but this is not a priority for us now. Maybe I'll come back to this later, but I'm fine with leaving it like this for now. https://reviews.llvm.org/D22369 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] D20386: Correct makefile.rules to use arm/aarch64 target specific AR and OBJCOPY
labath requested changes to this revision. labath added a comment. This revision now requires changes to proceed. This will break a several use cases we are relying on. More details inline. Comment at: packages/Python/lldbsuite/test/make/Makefile.rules:288 @@ -289,3 +287,3 @@ #-- ifeq "$(OS)" "Android" ifdef PIE Please remove the `if android` part and move it to the generic section above. Comment at: packages/Python/lldbsuite/test/make/Makefile.rules:294 @@ -307,1 +293,3 @@ +CLANG_OR_GCC := $(strip $(if $(findstring clang,$(CC)), \ + $(findstring clang,$(CC)), \ This code will now be under "android-specific options" although it is not. Please move it up, above "windows specific options". Comment at: packages/Python/lldbsuite/test/make/Makefile.rules:304 @@ +303,3 @@ + $(subst $(3),$(1),$(2)), \ + $(if $(findstring ar,$(1)), \ +$(if $(findstring gcc,$(3)), \ I think like we should replace ar with gcc-ar always, and not just when we don't have a version suffix present. When I have a gcc installed to a custom prefix, I get `$prefix/gcc-ar`, but not `$prefix/ar`. (Previously we would just use `ar` unconditionally, which was probably a bug.) Next, when you specify a clang compiler as `clang-3.5`, you will produce `ar-3.5`, which almost certainly does not exist. I think that in case of clang we should just strip the version suffix (produce `XXX-ar`) and hope for the best (should work for all our current use cases). Finally, I don't think objcopy is ever versioned with gcc (correct me if I am wrong), so I think that in case of objcopy we should strip the version suffix unconditionally `XXX-objcopy`. So, to summarize, these are the transformations I think are wrong: `foo/gcc` -> `foo/ar` (should be `foo/gcc-ar`) `clang-3.5` -> `ar-3.5` (should be `ar`) `gcc-4.8` -> `objcopy-4.8` (should be `objcopy`) Let me know if these are compatible with your requirements. If we can't find a set of rules that work everywhere, we will have to abandon the magic (or maybe just leave a simple one), and require the user to specify the paths manually... Comment at: packages/Python/lldbsuite/test/make/Makefile.rules:317 @@ +316,3 @@ +OBJCOPY = $(call replace_cc_with,objcopy) +AR = $(call replace_cc_with,ar) + This will override the darwin-specific setting of AR on line 130, which it probably shouldn't. I guess this should be `ifneq $(OS) darwin` https://reviews.llvm.org/D20386 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] D22999: Resurrect standalone build
labath requested changes to this revision. labath added a comment. This revision now requires changes to proceed. I agree with Tamas that this should somehow be handled in a different way. llvm already installs a bunch of cmake files. I think we should figure out a way to get the things we need installed alongside that, so we can just reuse them from there. Repository: rL LLVM https://reviews.llvm.org/D22999 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [Diffusion] rL277426: [LLVM][MIPS] Add (D)SUBU, (D)ADDU, LUI instructions emulation . Fix emulation…
Thanks Hans -Original Message- From: hwennb...@google.com [mailto:hwennb...@google.com] On Behalf Of Hans Wennborg Sent: 09 August 2016 01:59 To: Greg Clayton Cc: Nitesh Jain; Jaydeep Patil; Bhushan Attarde; lldb-commits@lists.llvm.org Subject: Re: [Diffusion] rL277426: [LLVM][MIPS] Add (D)SUBU, (D)ADDU, LUI instructions emulation . Fix emulation… Thanks! r278047. On Mon, Aug 8, 2016 at 10:26 AM, Greg Claytonwrote: > I am fine with this. It is in MIPS only code so it shouldn't affect anything > else. > >> On Aug 2, 2016, at 8:49 AM, Hans Wennborg wrote: >> >> While this all seems very MIPS-specific, so probably fine to merge if >> you want to, it does look more like new development than just bug >> fixing. >> >> I'm OK with merging this if Clayton approves, though. >> >> Thanks, >> Hans >> >> On Tue, Aug 2, 2016 at 12:49 AM, Nitesh Jain wrote: >>> Hi Hans, >>> >>> Could you please merge this to the LLDB 3.9 release branch ? >>> >>> Thanks & regards, >>> Nitesh Jain >>> >>> -Original Message- >>> From: Nitesh Jain >>> Sent: 02 August 2016 12:56 >>> To: Nitesh Jain >>> Subject: Re: [Diffusion] rL277426: [LLVM][MIPS] Add (D)SUBU, >>> (D)ADDU, LUI instructions emulation . Fix emulation… >>> >>> nitesh.jain committed rL277426: [LLVM][MIPS] Add (D)SUBU, (D)ADDU, LUI >>> instructions emulation . Fix emulation…. >>> >>> [LLVM][MIPS] Add (D)SUBU, (D)ADDU, LUI instructions emulation . Fix >>> emulation for (D)ADDIU, SD/SW and LW/LD instructions >>> >>> Reviewers: clayborg, jaydeep, bhushan >>> >>> Subscribers: mohit.bhakkad, slthakur, sdardis, lldb-commits >>> >>> Differential Revision: https://reviews.llvm.org/D22851 >>> >>> >>> Files: >>> >>> /lldb/trunk/source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.c >>> pp >>> /lldb/trunk/source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.h >>> >>> /lldb/trunk/source/Plugins/Instruction/MIPS64/EmulateInstructionMIPS >>> 64.cpp >>> /lldb/trunk/source/Plugins/Instruction/MIPS64/EmulateInstructionMIPS >>> 64.h >>> >>> Users: >>> nitesh.jain (Author) >>> >>> https://reviews.llvm.org/rL277426 >>> >>> >>> > ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] D20357: [LLDB][MIPS] Fix FPU Size Based on Dynamic FR (Merge Request)
Thanks Hans. -Original Message- From: hwennb...@google.com [mailto:hwennb...@google.com] On Behalf Of Hans Wennborg Sent: 09 August 2016 01:58 To: Greg Clayton Cc: Nitesh Jain; Jaydeep Patil; Bhushan Attarde; lldb-commits@lists.llvm.org Subject: Re: [PATCH] D20357: [LLDB][MIPS] Fix FPU Size Based on Dynamic FR (Merge Request) Thanks! Merged in r278046. On Mon, Aug 8, 2016 at 10:25 AM, Greg Claytonwrote: > I am fine with this going in, but this fix is for MIPS only. > > >> On Aug 2, 2016, at 8:47 AM, Hans Wennborg wrote: >> >> Looks like a pretty big change to merge at this stage. >> >> I'll let Clayton decide. >> >> Thanks, >> Hans >> >> On Mon, Aug 1, 2016 at 11:25 PM, Nitesh Jain wrote: >>> Hi Hans, >>> >>> Could you please add this to the LLDB 3.9 release branch ? >>> >>> Thanks & regards, >>> Nitesh Jain >>> >>> >>> -Original Message- >>> From: Nitesh Jain >>> Sent: 01 August 2016 19:24 >>> To: Nitesh Jain; jing...@apple.com; clayb...@gmail.com >>> Cc: ema...@freebsd.org; nemanja.i@gmail.com; lab...@google.com; >>> lldb-commits@lists.llvm.org; Simon Dardis; Mohit Bhakkad; Sagar >>> Thakur; Bhushan Attarde; Jaydeep Patil >>> Subject: Re: [PATCH] D20357: [LLDB][MIPS] Fix FPU Size Based on >>> Dynamic FR >>> >>> This revision was automatically updated to reflect the committed changes. >>> Closed by commit rL277343: [LLVM][MIPS] Fix FPU Size Based on Dynamic FR. >>> (authored by nitesh.jain). >>> >>> Changed prior to commit: >>> https://reviews.llvm.org/D20357?vs=65923=66314#toc >>> >>> Repository: >>> rL LLVM >>> >>> https://reviews.llvm.org/D20357 >>> >>> Files: >>> lldb/trunk/include/lldb/Target/RegisterContext.h >>> lldb/trunk/include/lldb/lldb-private-types.h >>> lldb/trunk/source/Plugins/Process/Utility/DynamicRegisterInfo.cpp >>> lldb/trunk/source/Plugins/Process/Utility/DynamicRegisterInfo.h >>> >>> lldb/trunk/source/Plugins/Process/Utility/RegisterContextDarwin_arm. >>> cpp >>> lldb/trunk/source/Plugins/Process/Utility/RegisterContextDarwin_arm6 >>> 4.cpp >>> lldb/trunk/source/Plugins/Process/Utility/RegisterContextFreeBSD_arm >>> .cpp >>> lldb/trunk/source/Plugins/Process/Utility/RegisterContextFreeBSD_arm >>> 64.cpp >>> lldb/trunk/source/Plugins/Process/Utility/RegisterContextLinux_arm.c >>> pp >>> lldb/trunk/source/Plugins/Process/Utility/RegisterContextLinux_arm64 >>> .cpp lldb/trunk/source/Plugins/Process/Utility/RegisterInfos_arm.h >>> lldb/trunk/source/Plugins/Process/Utility/RegisterInfos_arm64.h >>> lldb/trunk/source/Plugins/Process/Utility/RegisterInfos_i386.h >>> lldb/trunk/source/Plugins/Process/Utility/RegisterInfos_mips.h >>> lldb/trunk/source/Plugins/Process/Utility/RegisterInfos_mips64.h >>> lldb/trunk/source/Plugins/Process/Utility/RegisterInfos_powerpc.h >>> lldb/trunk/source/Plugins/Process/Utility/RegisterInfos_s390x.h >>> lldb/trunk/source/Plugins/Process/Utility/RegisterInfos_x86_64.h >>> >>> lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationS >>> erverLLGS.cpp >>> lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteRegisterContex >>> t.cpp >>> lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp >>> lldb/trunk/source/Target/RegisterContext.cpp >>> > ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits