[Lldb-commits] [PATCH] D44752: Implement TypeAndOrName::TypeAndOrName(const CompilerType &)
clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. We probably need a test then. https://reviews.llvm.org/D44752 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D44752: Implement TypeAndOrName::TypeAndOrName(const CompilerType &)
tromey added a comment. In https://reviews.llvm.org/D44752#1052027, @clayborg wrote: > Can you add this to the patch for the rust plug-in then? Yes, I already did; I just thought that since it was a latent bug in upstream that I would submit it separately. https://reviews.llvm.org/D44752 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D44752: Implement TypeAndOrName::TypeAndOrName(const CompilerType &)
clayborg added a comment. Can you add this to the patch for the rust plug-in then? https://reviews.llvm.org/D44752 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D44907: Remove Scalar::Cast
davide added a comment. OK, I'll commit it for you later today. https://reviews.llvm.org/D44907 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D44907: Remove Scalar::Cast
tromey added a comment. In https://reviews.llvm.org/D44907#1051931, @davide wrote: > @tromey thanks! do you need somebody to commit this for you? Yes. I do not have commit access. https://reviews.llvm.org/D44907 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D44752: Implement TypeAndOrName::TypeAndOrName(const CompilerType &)
tromey added a comment. I only found this because I tried to use it in my rust plugin. So, I would rather implement it, because if I removed it, I would have to find a new way to do this. https://reviews.llvm.org/D44752 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D44752: Implement TypeAndOrName::TypeAndOrName(const CompilerType &)
davide added a comment. Just remove it I'd say (bonus point if you can remove other bits) https://reviews.llvm.org/D44752 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D44907: Remove Scalar::Cast
davide added a comment. @tromey thanks! do you need somebody to commit this for you? https://reviews.llvm.org/D44907 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D44752: Implement TypeAndOrName::TypeAndOrName(const CompilerType &)
clayborg added a comment. Should this be removed then? If not one was using it, we should remove it from the header file. https://reviews.llvm.org/D44752 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D44907: Remove Scalar::Cast
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Very nice. Thanks for doing this. Someone a while back had converted Scalar to use APInt and APFloat and never got around to all of these details. https://reviews.llvm.org/D44907 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D41909: Fix deadlock in dwarf logging
fjricci abandoned this revision. fjricci added a comment. I'm not going to get to this https://reviews.llvm.org/D41909 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D44998: ObjectFileELF: Add support for arbitrarily named code sections
labath added a comment. We already have section dumping code in the lldb-test utility. Extending the output to dump the detected section type seems like a good (and simple) thing to do. Repository: rL LLVM https://reviews.llvm.org/D44998 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r328770 - NativeThreadProtocol: delete dead code
Author: labath
Date: Thu Mar 29 03:09:11 2018
New Revision: 328770
URL: http://llvm.org/viewvc/llvm-project?rev=328770=rev
Log:
NativeThreadProtocol: delete dead code
These functions were unused as everyone just went straight for the
direct operations on the register context. In fact, the
Save/RestoreAllRegisters actually appear to be wrong (inverted). Thanks
to Tatyana for pointing this out.
These functions are not very useful now that we can guarantee that each
thread always contains a valid register context, so I just delete them.
Modified:
lldb/trunk/include/lldb/Host/common/NativeThreadProtocol.h
lldb/trunk/source/Host/common/NativeThreadProtocol.cpp
Modified: lldb/trunk/include/lldb/Host/common/NativeThreadProtocol.h
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Host/common/NativeThreadProtocol.h?rev=328770=328769=328770=diff
==
--- lldb/trunk/include/lldb/Host/common/NativeThreadProtocol.h (original)
+++ lldb/trunk/include/lldb/Host/common/NativeThreadProtocol.h Thu Mar 29
03:09:11 2018
@@ -32,14 +32,6 @@ public:
virtual NativeRegisterContext () = 0;
- virtual Status ReadRegister(uint32_t reg, RegisterValue _value);
-
- virtual Status WriteRegister(uint32_t reg, const RegisterValue _value);
-
- virtual Status SaveAllRegisters(lldb::DataBufferSP _sp);
-
- virtual Status RestoreAllRegisters(lldb::DataBufferSP _sp);
-
virtual bool GetStopReason(ThreadStopInfo _info,
std::string ) = 0;
Modified: lldb/trunk/source/Host/common/NativeThreadProtocol.cpp
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Host/common/NativeThreadProtocol.cpp?rev=328770=328769=328770=diff
==
--- lldb/trunk/source/Host/common/NativeThreadProtocol.cpp (original)
+++ lldb/trunk/source/Host/common/NativeThreadProtocol.cpp Thu Mar 29 03:09:11
2018
@@ -19,36 +19,3 @@ using namespace lldb_private;
NativeThreadProtocol::NativeThreadProtocol(NativeProcessProtocol ,
lldb::tid_t tid)
: m_process(process), m_tid(tid) {}
-
-Status NativeThreadProtocol::ReadRegister(uint32_t reg,
- RegisterValue _value) {
- NativeRegisterContext _context = GetRegisterContext();
-
- const RegisterInfo *const reg_info =
- register_context.GetRegisterInfoAtIndex(reg);
- if (!reg_info)
-return Status("no register info for reg num %" PRIu32, reg);
-
- return register_context.ReadRegister(reg_info, reg_value);
- ;
-}
-
-Status NativeThreadProtocol::WriteRegister(uint32_t reg,
- const RegisterValue _value) {
- NativeRegisterContext& register_context = GetRegisterContext();
-
- const RegisterInfo *const reg_info =
- register_context.GetRegisterInfoAtIndex(reg);
- if (!reg_info)
-return Status("no register info for reg num %" PRIu32, reg);
-
- return register_context.WriteRegister(reg_info, reg_value);
-}
-
-Status NativeThreadProtocol::SaveAllRegisters(lldb::DataBufferSP _sp) {
- return GetRegisterContext().WriteAllRegisterValues(data_sp);
-}
-
-Status NativeThreadProtocol::RestoreAllRegisters(lldb::DataBufferSP _sp) {
- return GetRegisterContext().ReadAllRegisterValues(data_sp);
-}
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
