[Lldb-commits] [PATCH] D146058: [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

> Oh I still saw that one running a few days back! @stella.stamenova in the 
> review you mention a second windows lldb bot, is it x86 as well? I don't see 
> it in https://lab.llvm.org/buildbot/#/console

The one I was referring to is https://lab.llvm.org/buildbot/#/builders/219.

Also, the one that was removed was not x86 either, it was x64.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146058/new/

https://reviews.llvm.org/D146058

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D145242: [lldb][TypeSystemClang] Use the CXXFunctionPointerSummaryProvider for member-function pointers

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

In D145242#4173592 , @Michael137 
wrote:

> In D145242#4173577 , 
> @stella.stamenova wrote:
>
>> Looks like either this change or D125241  
>> broke the Windows lldb bot: 
>> https://lab.llvm.org/buildbot/#/builders/83/builds/29800. Since it's been 
>> broken for a few days, if you can't address the failure soon, I'll go ahead 
>> and revert the changes to bring it back to green.
>
> Ah thanks for pointing it out. Thought I had fixed it with 
> https://reviews.llvm.org/rG96e39fdbb90b26191fc79b6226f299e3c10e559b
>
> Will check on my Windows machine. But feel free to revert, since I'm only 
> going to be able to look at it tomorrow

The lldb bot I pointed you is not an arm buildbot, it's x64. Also the test you 
fixed is `ast-types`, but there were actually two failing tests - 
`TestDataFormatterCpp.py` is still failing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145242/new/

https://reviews.llvm.org/D145242

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D145242: [lldb][TypeSystemClang] Use the CXXFunctionPointerSummaryProvider for member-function pointers

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

Looks like either this change or D125241  
broke the Windows lldb bot: 
https://lab.llvm.org/buildbot/#/builders/83/builds/29800. Since it's been 
broken for a few days, if you can't address the failure soon, I'll go ahead and 
revert the changes to bring it back to green.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145242/new/

https://reviews.llvm.org/D145242

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D143104: [lldb/Plugins] Add Attach capabilities to ScriptedProcess

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

Looks like this change broke the windows lldb build: 
https://lab.llvm.org/buildbot/#/builders/83/builds/29801


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143104/new/

https://reviews.llvm.org/D143104

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D144665: Use Resume not PrivateResume when asynchronously continuing after the start at stop

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

Looks like the new test is failing on the windows lldb bot: 
https://lab.llvm.org/buildbot/#/builders/83/builds/29680. The buildbot was 
already red because of `TestCommandScript.py`, so you might have missed this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144665/new/

https://reviews.llvm.org/D144665

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D138724: [lldb][Target] Flush the scratch TypeSystem when process gets deleted

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

Looks like this broke the windows lldb bot as well: 
https://lab.llvm.org/buildbot/#/builders/83/builds/26822


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138724/new/

https://reviews.llvm.org/D138724

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D136650: Make CompilerType safe [Was: Add a check for TypeSystem use-after-free problems]

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

Looks like the windows lldb bot is still broken: 
https://lab.llvm.org/buildbot/#/builders/83/builds/26083


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136650/new/

https://reviews.llvm.org/D136650

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D136650: Make CompilerType safe [Was: Add a check for TypeSystem use-after-free problems]

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

Looks like this broke the windows lldb bot: 
https://lab.llvm.org/buildbot/#/builders/83/builds/26042


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136650/new/

https://reviews.llvm.org/D136650

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D133366: [lldb] Fix SBFileSpec.fullpath for Windows

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

In D133366#3923291 , @kastiglione 
wrote:

> Ugh, the test that is failing uses windows paths but runs on both windows and 
> non-windows machines. I will revert this and the two fix commits.

You should be able to test for the operating system and set the paths 
accordingly in the test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133366/new/

https://reviews.llvm.org/D133366

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D133366: [lldb] Fix SBFileSpec.fullpath for Windows

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

This broke the Windows lldb bot: 
https://lab.llvm.org/buildbot/#/builders/83/builds/25854


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133366/new/

https://reviews.llvm.org/D133366

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D135622: [lldb] Add a "diagnostics dump" command

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

The newly added test is failing on the windows buildbot: 
https://lab.llvm.org/buildbot/#/builders/83/builds/25446


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135622/new/

https://reviews.llvm.org/D135622

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D136761: [lldb][CPlusPlus] Implement CPlusPlusLanguage::GetFunctionDisplayName

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

Looks like in addition to the Linux failure, this also broke the Windows LLDB 
bot: https://lab.llvm.org/buildbot/#/builders/83/builds/25424/steps/7/logs/stdio


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136761/new/

https://reviews.llvm.org/D136761

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D135998: Make sure Target::EvaluateExpression() passes up an error instead of silently dropping it.

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.
Herald added subscribers: Michael137, JDevlieghere.

I think this change broke the windows lldb bot: 
https://lab.llvm.org/buildbot/#/builders/83/builds/24905


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135998/new/

https://reviews.llvm.org/D135998

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D135413: [lldb][CPlusPlusLanguage] Respect the step-avoid-regex for functions with auto return types

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

Looks like this change broke the windows lldb bot: 
https://lab.llvm.org/buildbot/#/builders/83/builds/24631


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135413/new/

https://reviews.llvm.org/D135413

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D131983: [LLDB][NFC] Fix optons parsing and misc. reliability in CommandObjectThread

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

This broke the windows lldb bot: 
https://lab.llvm.org/buildbot/#/builders/83/builds/22557/steps/7/logs/stdio


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131983/new/

https://reviews.llvm.org/D131983

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D81471: [lldb] Add support for using integral const static data members in the expression evaluator

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

Looks like this broke the Windows lldb bot as well: 
https://lab.llvm.org/buildbot/#/builders/83/builds/21186


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81471/new/

https://reviews.llvm.org/D81471

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D127999: [lldb] fix stepping through POSIX trampolines

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

Looks like this broke the windows lldb bot: 
https://lab.llvm.org/buildbot/#/builders/83/builds/20566


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127999/new/

https://reviews.llvm.org/D127999

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D127436: [lldb] Resolve exe location for `target create`

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

This broke the Windows LLDB bot:

https://lab.llvm.org/buildbot/#/builders/83/builds/20295/steps/7/logs/stdio


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127436/new/

https://reviews.llvm.org/D127436

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D125943: [trace][intelpt] Support system-wide tracing [11] - Read warnings and perf conversion in the client

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

In D125943#3587778 , @wallace wrote:

> @stella.stamenova, I've just tried that compile command with several versions 
> of gcc, including g++ (GCC) 8.5.0 on CentOS and got no error Sadly I couldn't 
> install 7.3.1. Could you try again in top of tree?

Yes, it is still failing with 7.3.1 with the same error as before.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125943/new/

https://reviews.llvm.org/D125943

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D125943: [trace][intelpt] Support system-wide tracing [11] - Read warnings and perf conversion in the client

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

In D125943#3586910 , @wallace wrote:

> yes, i'm trying to fix it now. Thanks!

Thanks!

One more to add to the list:

  FAILED: 
tools/lldb/source/Plugins/Process/Linux/CMakeFiles/lldbPluginProcessLinux.dir/IntelPTPerThreadProcessTrace.cpp.o
 
  /usr/bin/g++ -DHAVE_ROUND -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS 
-D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS 
-I/__w/1/b/llvm/Release/tools/lldb/source/Plugins/Process/Linux 
-I/__w/1/llvm-project/lldb/source/Plugins/Process/Linux 
-I/__w/1/llvm-project/lldb/include -I/__w/1/b/llvm/Release/tools/lldb/include 
-I/__w/1/b/llvm/Release/include -I/__w/1/llvm-project/llvm/include 
-I/__w/1/llvm-project/llvm/../clang/include 
-I/__w/1/b/llvm/Release/tools/lldb/../clang/include 
-I/__w/1/llvm-project/lldb/source -I/__w/1/b/llvm/Release/tools/lldb/source 
-fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time 
-Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual 
-Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough 
-Wno-maybe-uninitialized -Wno-noexcept-type -Wdelete-non-virtual-dtor 
-Wno-comment -Wmisleading-indentation -fdiagnostics-color -ffunction-sections 
-fdata-sections -Wno-deprecated-declarations -Wno-unknown-pragmas 
-Wno-strict-aliasing -O3 -DNDEBUG  -fno-exceptions -UNDEBUG -std=c++14 -MD -MT 
tools/lldb/source/Plugins/Process/Linux/CMakeFiles/lldbPluginProcessLinux.dir/IntelPTPerThreadProcessTrace.cpp.o
 -MF 
tools/lldb/source/Plugins/Process/Linux/CMakeFiles/lldbPluginProcessLinux.dir/IntelPTPerThreadProcessTrace.cpp.o.d
 -o 
tools/lldb/source/Plugins/Process/Linux/CMakeFiles/lldbPluginProcessLinux.dir/IntelPTPerThreadProcessTrace.cpp.o
 -c 
/__w/1/llvm-project/lldb/source/Plugins/Process/Linux/IntelPTPerThreadProcessTrace.cpp
  
/__w/1/llvm-project/lldb/source/Plugins/Process/Linux/IntelPTPerThreadProcessTrace.cpp:
 In static member function 'static 
llvm::Expected
 > lldb_private::process_linux::IntelPTPerThreadProcessTrace::Start(const 
lldb_private::TraceIntelPTStartRequest&, llvm::ArrayRef)':
  
/__w/1/llvm-project/lldb/source/Plugins/Process/Linux/IntelPTPerThreadProcessTrace.cpp:65:10:
 error: could not convert 'trace' from 
'lldb_private::process_linux::IntelPTProcessTraceUP {aka 
std::unique_ptr}' to 
'llvm::Expected
 >'
 return trace;
^

This is on CentOS with gcc 7.3.1


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125943/new/

https://reviews.llvm.org/D125943

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D125943: [trace][intelpt] Support system-wide tracing [11] - Read warnings and perf conversion in the client

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

These changes (the set of [trace][intelpt] changes) broke the windows lldb bot. 
It's most likely this particular change, but it could be one of the others. 
Unfortunately, the bot had just been broken by 
https://reviews.llvm.org/D127882, so it didn't show the failure until that was 
reverted:

https://lab.llvm.org/buildbot/#/builders/83/builds/19994


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125943/new/

https://reviews.llvm.org/D125943

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

Looks like this broke the windows lldb bot: 
https://lab.llvm.org/buildbot/#/builders/83/builds/18228


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121631/new/

https://reviews.llvm.org/D121631

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D119146: [lldb/Platform] Prepare decouple instance and plugin names

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

It looks like this broke the windows lldb bot:

https://lab.llvm.org/buildbot/#/builders/83/builds/15999


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119146/new/

https://reviews.llvm.org/D119146

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D113498: [lldb] Constant-resolve operands to `getelementptr`

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

It looks like the new test is failing on the Windows bot:

https://lab.llvm.org/buildbot/#/builders/83/builds/15049


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113498/new/

https://reviews.llvm.org/D113498

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D118866: [LLDB] Fix window bot failure

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

Thanks!

It looks like there's a failure that was previously hidden by the unexpected 
passes:

https://lab.llvm.org/buildbot/#/builders/83/builds/14781

It seems like it's been in all of the previous builds as well, but it was not 
reported separately for some reason.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118866/new/

https://reviews.llvm.org/D118866

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D118866: [LLDB] Fix window bot failure

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added inline comments.



Comment at: 
lldb/test/API/functionalities/inferior-crashing/TestInferiorCrashingStep.py:46
 @skipIfTargetAndroid()  # debuggerd interferes with this test on Android
 @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24778")
 def test_inferior_crashing_step_after_break(self):

zequanwu wrote:
> stella.stamenova wrote:
> > Do all the places where this bug was mentioned pass now?
> I don't know. I failed to run lldb api tests with my current windows 
> environment. I just removed the expected failures based on the bot output.
That makes sense. Please commit this and let's see.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118866/new/

https://reviews.llvm.org/D118866

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D118866: [LLDB] Fix window bot failure

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova accepted this revision.
stella.stamenova added a comment.
This revision is now accepted and ready to land.

LGTM, I think there might be a couple more places to remove the xfail, but 
otherwise ship it!




Comment at: 
lldb/test/API/functionalities/inferior-crashing/TestInferiorCrashingStep.py:46
 @skipIfTargetAndroid()  # debuggerd interferes with this test on Android
 @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24778")
 def test_inferior_crashing_step_after_break(self):

Do all the places where this bug was mentioned pass now?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118866/new/

https://reviews.llvm.org/D118866

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D118866: [LLDB] Fix window bot failure

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

They should correspond to these files:

  lldb-api :: functionalities/inferior-crashing/TestInferiorCrashing.py => 
test/API/functionalities/inferior-crashing/TestInferiorCrashing.py
  lldb-api :: functionalities/inferior-crashing/TestInferiorCrashingStep.py => 
test/API/functionalities/inferior-crashing/TestInferiorCrashingStep.py
  lldb-api :: 
functionalities/inferior-crashing/recursive-inferior/TestRecursiveInferior.py 
=> 
test/API/functionalities/inferior-crashing/recursive-inferior/TestRecursiveInferior.py
  lldb-api :: 
functionalities/inferior-crashing/recursive-inferior/TestRecursiveInferiorStep.py
 => 
test/API/functionalities/inferior-crashing/recursive-inferior/TestRecursiveInferiorStep.py


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118866/new/

https://reviews.llvm.org/D118866

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D118750: [LLDB] add sub register enums on x64 Windows

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.
Herald added a subscriber: JDevlieghere.

This broke the windows bot in the best way possible - by making some tests pass 
now that didn't use to. Could you un-xfail those too?

https://lab.llvm.org/buildbot/#/builders/83/builds/14736


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118750/new/

https://reviews.llvm.org/D118750

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D118425: [lldb] Update the lldb build instructions on Windows

[Stella Stamenova via Phabricator via lldb-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rG738d73fbf4ed: [lldb] Update the lldb build instructions on 
Windows (authored by stella.stamenova).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118425/new/

https://reviews.llvm.org/D118425

Files:
  lldb/docs/resources/build.rst


Index: lldb/docs/resources/build.rst
===
--- lldb/docs/resources/build.rst
+++ lldb/docs/resources/build.rst
@@ -92,24 +92,30 @@
 * `GnuWin32 `_ for CoreUtils and Make.
 * `Python 3 `_.  Make sure to (1) 
get
   the x64 variant if that's what you're targetting and (2) install the debug
-  library if you want to build a debug lldb.
+  library if you want to build a debug lldb. The standalone installer is the
+  easiest way to get the debug library.
 * `Python Tools for Visual Studio
-  `_. If you plan to debug test
-  failures or even write new tests at all, PTVS is an indispensable debugging
+  `_. If you plan to debug test failures
+  or even write new tests at all, PTVS is an indispensable debugging
   extension to VS that enables full editing and debugging support for Python
   (including mixed native/managed debugging).
+* `SWIG for Windows _`
 
 The steps outlined here describes how to set up your system and install the
 required dependencies such that they can be found when needed during the build
 process. They only need to be performed once.
 
-#. Install Visual Studio with the Windows SDK and ATL components.
+#. Install Visual Studio with the "Desktop Development with C++" workload and
+   the "Python Development" workload.
 #. Install GnuWin32, making sure ``\bin`` is added to
your PATH environment variable. Verify that utilities like ``dirname`` and
``make`` are available from your terminal.
 #. Install SWIG for Windows, making sure  is added to
your PATH environment variable. Verify that ``swig`` is available from your
terminal.
+#. Install Python 3 from the standalone installer and include the debug 
libraries
+   in the install, making sure the Python install path is added to your PATH
+   environment variable.
 #. Register the Debug Interface Access DLLs with the Registry from a privileged
terminal.
 
@@ -119,9 +125,10 @@
 > regsvr32 "C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\DIA 
 > SDK\bin\amd64\msdia140.dll"
 
 Any command prompt from which you build LLDB should have a valid Visual Studio
-environment setup. This means you should run ``vcvarsall.bat`` or open an
-appropriate Visual Studio Command Prompt corresponding to the version you wish
-to use.
+environment setup. This means you should open an appropriate `Developer Command
+Prompt for VS 
`_
+corresponding to the version you wish to use or run ``vcvarsall.bat`` or
+``VsDevCmd.bat``.
 
 macOS
 *


Index: lldb/docs/resources/build.rst
===
--- lldb/docs/resources/build.rst
+++ lldb/docs/resources/build.rst
@@ -92,24 +92,30 @@
 * `GnuWin32 `_ for CoreUtils and Make.
 * `Python 3 `_.  Make sure to (1) get
   the x64 variant if that's what you're targetting and (2) install the debug
-  library if you want to build a debug lldb.
+  library if you want to build a debug lldb. The standalone installer is the
+  easiest way to get the debug library.
 * `Python Tools for Visual Studio
-  `_. If you plan to debug test
-  failures or even write new tests at all, PTVS is an indispensable debugging
+  `_. If you plan to debug test failures
+  or even write new tests at all, PTVS is an indispensable debugging
   extension to VS that enables full editing and debugging support for Python
   (including mixed native/managed debugging).
+* `SWIG for Windows _`
 
 The steps outlined here describes how to set up your system and install the
 required dependencies such that they can be found when needed during the build
 process. They only need to be performed once.
 
-#. Install Visual Studio with the Windows SDK and ATL components.
+#. Install Visual Studio with the "Desktop Development with C++" workload and
+   the "Python Development" workload.
 #. Install GnuWin32, making sure ``\bin`` is added to
your PATH environment variable. Verify that utilities like ``dirname`` and
``make`` are available from your terminal.
 #. Install SWIG for Windows, making sure  is added to
your PATH environment variable. Verify that ``swig`` is

[Lldb-commits] [PATCH] D114639: Raise the minimum Visual Studio version to VS2019

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added inline comments.



Comment at: lldb/docs/resources/build.rst:296
 
-  $ cmake -G "Visual Studio 15 2017 Win64" -Thost=x64  
+  $ cmake -G "Visual Studio 16 2019" -A x64 -T host=x64 -Thost=x64  
 

You accidentally added `-T host=x64` twice now. It can be included with or 
without the space, but it's only needed once.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114639/new/

https://reviews.llvm.org/D114639

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D114639: Raise the minimum Visual Studio version to VS2019

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added inline comments.



Comment at: lldb/docs/resources/build.rst:296
 
-  $ cmake -G "Visual Studio 15 2017 Win64" -Thost=x64  
+  $ cmake -G "Visual Studio 16 2019 Win64" -Thost=x64  
 

This line should change a bit more. For VS2019, it also needs to include `-A 
64` like so: `cmake -G "Visual Studio 16 2019" -A x64 -T host=x64`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114639/new/

https://reviews.llvm.org/D114639

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D118425: [lldb] Update the lldb build instructions on Windows

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova updated this revision to Diff 404065.
stella.stamenova added a comment.

Add more details for developer command prompt


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118425/new/

https://reviews.llvm.org/D118425

Files:
  lldb/docs/resources/build.rst


Index: lldb/docs/resources/build.rst
===
--- lldb/docs/resources/build.rst
+++ lldb/docs/resources/build.rst
@@ -92,24 +92,30 @@
 * `GnuWin32 `_ for CoreUtils and Make.
 * `Python 3 `_.  Make sure to (1) 
get
   the x64 variant if that's what you're targetting and (2) install the debug
-  library if you want to build a debug lldb.
+  library if you want to build a debug lldb. The standalone installer is the
+  easiest way to get the debug library.
 * `Python Tools for Visual Studio
-  `_. If you plan to debug test
-  failures or even write new tests at all, PTVS is an indispensable debugging
+  `_. If you plan to debug test failures
+  or even write new tests at all, PTVS is an indispensable debugging
   extension to VS that enables full editing and debugging support for Python
   (including mixed native/managed debugging).
+* `SWIG for Windows _`
 
 The steps outlined here describes how to set up your system and install the
 required dependencies such that they can be found when needed during the build
 process. They only need to be performed once.
 
-#. Install Visual Studio with the Windows SDK and ATL components.
+#. Install Visual Studio with the "Desktop Development with C++" workload and
+   the "Python Development" workload.
 #. Install GnuWin32, making sure ``\bin`` is added to
your PATH environment variable. Verify that utilities like ``dirname`` and
``make`` are available from your terminal.
 #. Install SWIG for Windows, making sure  is added to
your PATH environment variable. Verify that ``swig`` is available from your
terminal.
+#. Install Python 3 from the standalone installer and include the debug 
libraries
+   in the install, making sure the Python install path is added to your PATH
+   environment variable.
 #. Register the Debug Interface Access DLLs with the Registry from a privileged
terminal.
 
@@ -119,9 +125,10 @@
 > regsvr32 "C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\DIA 
 > SDK\bin\amd64\msdia140.dll"
 
 Any command prompt from which you build LLDB should have a valid Visual Studio
-environment setup. This means you should run ``vcvarsall.bat`` or open an
-appropriate Visual Studio Command Prompt corresponding to the version you wish
-to use.
+environment setup. This means you should open an appropriate `Developer Command
+Prompt for VS 
`_
+corresponding to the version you wish to use or run ``vcvarsall.bat`` or
+``VsDevCmd.bat``.
 
 macOS
 *


Index: lldb/docs/resources/build.rst
===
--- lldb/docs/resources/build.rst
+++ lldb/docs/resources/build.rst
@@ -92,24 +92,30 @@
 * `GnuWin32 `_ for CoreUtils and Make.
 * `Python 3 `_.  Make sure to (1) get
   the x64 variant if that's what you're targetting and (2) install the debug
-  library if you want to build a debug lldb.
+  library if you want to build a debug lldb. The standalone installer is the
+  easiest way to get the debug library.
 * `Python Tools for Visual Studio
-  `_. If you plan to debug test
-  failures or even write new tests at all, PTVS is an indispensable debugging
+  `_. If you plan to debug test failures
+  or even write new tests at all, PTVS is an indispensable debugging
   extension to VS that enables full editing and debugging support for Python
   (including mixed native/managed debugging).
+* `SWIG for Windows _`
 
 The steps outlined here describes how to set up your system and install the
 required dependencies such that they can be found when needed during the build
 process. They only need to be performed once.
 
-#. Install Visual Studio with the Windows SDK and ATL components.
+#. Install Visual Studio with the "Desktop Development with C++" workload and
+   the "Python Development" workload.
 #. Install GnuWin32, making sure ``\bin`` is added to
your PATH environment variable. Verify that utilities like ``dirname`` and
``make`` are available from your terminal.
 #. Install SWIG for Windows, making sure  is added to
your PATH environment variable. Verify that ``swig`` is available from your
terminal.
+#. Install Python 3 from the standalone installer and inclu

[Lldb-commits] [PATCH] D118425: [lldb] Update the lldb build instructions on Windows

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova created this revision.
stella.stamenova added reviewers: JDevlieghere, dblaikie.
stella.stamenova requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

The existing instructions for lldb on Windows can be more explicit. This adds a 
few details on how to install various components and the easiest way to get to 
a working build.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D118425

Files:
  lldb/docs/resources/build.rst


Index: lldb/docs/resources/build.rst
===
--- lldb/docs/resources/build.rst
+++ lldb/docs/resources/build.rst
@@ -92,24 +92,30 @@
 * `GnuWin32 `_ for CoreUtils and Make.
 * `Python 3 `_.  Make sure to (1) 
get
   the x64 variant if that's what you're targetting and (2) install the debug
-  library if you want to build a debug lldb.
+  library if you want to build a debug lldb. The standalone installer is the
+  easiest way to get the debug library.
 * `Python Tools for Visual Studio
-  `_. If you plan to debug test
-  failures or even write new tests at all, PTVS is an indispensable debugging
+  `_. If you plan to debug test failures
+  or even write new tests at all, PTVS is an indispensable debugging
   extension to VS that enables full editing and debugging support for Python
   (including mixed native/managed debugging).
+* `SWIG for Windows _`
 
 The steps outlined here describes how to set up your system and install the
 required dependencies such that they can be found when needed during the build
 process. They only need to be performed once.
 
-#. Install Visual Studio with the Windows SDK and ATL components.
+#. Install Visual Studio with the "Desktop Development with C++" workload and
+   the "Python Development" workload.
 #. Install GnuWin32, making sure ``\bin`` is added to
your PATH environment variable. Verify that utilities like ``dirname`` and
``make`` are available from your terminal.
 #. Install SWIG for Windows, making sure  is added to
your PATH environment variable. Verify that ``swig`` is available from your
terminal.
+#. Install Python 3 from the standalone installer and include the debug 
libraries
+   in the install, making sure the Python install path is added to your PATH
+   environment variable.
 #. Register the Debug Interface Access DLLs with the Registry from a privileged
terminal.
 


Index: lldb/docs/resources/build.rst
===
--- lldb/docs/resources/build.rst
+++ lldb/docs/resources/build.rst
@@ -92,24 +92,30 @@
 * `GnuWin32 `_ for CoreUtils and Make.
 * `Python 3 `_.  Make sure to (1) get
   the x64 variant if that's what you're targetting and (2) install the debug
-  library if you want to build a debug lldb.
+  library if you want to build a debug lldb. The standalone installer is the
+  easiest way to get the debug library.
 * `Python Tools for Visual Studio
-  `_. If you plan to debug test
-  failures or even write new tests at all, PTVS is an indispensable debugging
+  `_. If you plan to debug test failures
+  or even write new tests at all, PTVS is an indispensable debugging
   extension to VS that enables full editing and debugging support for Python
   (including mixed native/managed debugging).
+* `SWIG for Windows _`
 
 The steps outlined here describes how to set up your system and install the
 required dependencies such that they can be found when needed during the build
 process. They only need to be performed once.
 
-#. Install Visual Studio with the Windows SDK and ATL components.
+#. Install Visual Studio with the "Desktop Development with C++" workload and
+   the "Python Development" workload.
 #. Install GnuWin32, making sure ``\bin`` is added to
your PATH environment variable. Verify that utilities like ``dirname`` and
``make`` are available from your terminal.
 #. Install SWIG for Windows, making sure  is added to
your PATH environment variable. Verify that ``swig`` is available from your
terminal.
+#. Install Python 3 from the standalone installer and include the debug libraries
+   in the install, making sure the Python install path is added to your PATH
+   environment variable.
 #. Register the Debug Interface Access DLLs with the Registry from a privileged
terminal.
 
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D117581: [lldb] Use lldb-server by default on Windows

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova abandoned this revision.
stella.stamenova added a comment.

I spent a bit of time trying to investigate the failures, but I couldn't make 
much progress and I don't have time to dedicate to a more thorough 
investigation. It looks like there are a few tests that outright fail 
(including some of the shell tests) as well as a number of tests where 
lldb-server hangs indefinitely causing the whole suite to hang (again, 
including some shell tests).

I'm going to abandon this change for the moment and see about some of the other 
suggestion for the tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117581/new/

https://reviews.llvm.org/D117581

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D117637: Fix build break on CentOS due to gcc 7.3.1

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova accepted this revision.
stella.stamenova added a comment.
This revision is now accepted and ready to land.

LGTM


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117637/new/

https://reviews.llvm.org/D117637

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D117581: [lldb] Use lldb-server by default on Windows

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

So, sadly, I am going to have to backtrack here. When I set 
`LLDB_USE_LLDB_SERVER` in my environment and ran the tests, they did appear to 
be more stable (fewer failures across 10 test runs), but it was all a joke my 
machine was playing on me.

Running the tests with this current change to default `LLDB_USE_LLDB_SERVER` to 
ON has significantly more failures than without. I haven't investigated yet 
exactly where the failures are coming from, but I did figure out that by 
default not all variables from the environment are preserved when the tests are 
executed, so my setting of `LLDB_USE_LLDB_SERVER` locally did absolutely 
nothing and it wasn't until it was defaulted to ON that the tests ran as 
intended.

I'm going to spend a bit of time to see if I can figure out where the failures 
are coming from, but I suspect it won't be trivial. One of the fun new errors 
is: `error: Execution was interrupted, reason: Attempted to dereference an 
invalid pointer..`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117581/new/

https://reviews.llvm.org/D117581

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D117113: [lldb] [llgs] Implement qXfer:siginfo:read

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.
Herald added a subscriber: JDevlieghere.

This does not build correctly with gcc 7.3.1 on CentOS:

  /usr/bin/g++ -DGTEST_HAS_RTTI=0 -DHAVE_ROUND -D_DEBUG -D_GNU_SOURCE 
-D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS 
-I/mnt/resource/1/b/llvm/Release/tools/lldb/source/Plugins/Process/Linux 
-I/mnt/resource/1/s/llvm-project/lldb/source/Plugins/Process/Linux 
-I/mnt/resource/1/s/llvm-project/lldb/include 
-I/mnt/resource/1/b/llvm/Release/tools/lldb/include 
-I/mnt/resource/1/b/llvm/Release/include 
-I/mnt/resource/1/s/llvm-project/llvm/include 
-I/mnt/resource/1/s/llvm-project/llvm/../clang/include 
-I/mnt/resource/1/b/llvm/Release/tools/lldb/../clang/include 
-I/mnt/resource/1/s/llvm-project/lldb/source 
-I/mnt/resource/1/b/llvm/Release/tools/lldb/source -fPIC 
-fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall 
-Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual 
-Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough 
-Wno-maybe-uninitialized -Wno-noexcept-type -Wdelete-non-virtual-dtor 
-Wno-comment -Wmisleading-indentation -fdiagnostics-color -ffunction-sections 
-fdata-sections -Wno-deprecated-declarations -Wno-unknown-pragmas 
-Wno-strict-aliasing -Wno-deprecated-register -Wno-vla-extension -O3 -DNDEBUG  
-fno-exceptions -fno-rtti -UNDEBUG -std=c++14 -MD -MT 
tools/lldb/source/Plugins/Process/Linux/CMakeFiles/lldbPluginProcessLinux.dir/NativeThreadLinux.cpp.o
 -MF 
tools/lldb/source/Plugins/Process/Linux/CMakeFiles/lldbPluginProcessLinux.dir/NativeThreadLinux.cpp.o.d
 -o 
tools/lldb/source/Plugins/Process/Linux/CMakeFiles/lldbPluginProcessLinux.dir/NativeThreadLinux.cpp.o
 -c 
/mnt/resource/1/s/llvm-project/lldb/source/Plugins/Process/Linux/NativeThreadLinux.cpp
  
/mnt/resource/1/s/llvm-project/lldb/source/Plugins/Process/Linux/NativeThreadLinux.cpp:
 In member function ‘virtual llvm::Expected 
> lldb_private::process_linux::NativeThreadLinux::GetSiginfo() const’:
  
/mnt/resource/1/s/llvm-project/lldb/source/Plugins/Process/Linux/NativeThreadLinux.cpp:552:10:
 error: could not convert ‘siginfo_buf’ from 
‘std::unique_ptr’ to 
‘llvm::Expected >’
 return siginfo_buf;


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117113/new/

https://reviews.llvm.org/D117113

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D117581: [lldb] Use lldb-server by default on Windows

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova created this revision.
stella.stamenova added reviewers: JDevlieghere, clayborg, labath.
stella.stamenova requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

The current default is to not use lldb-server on Windows, however, lldb-server 
is more stable than ProcessWindows, so default to using lldb-server.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D117581

Files:
  lldb/source/Plugins/Process/Windows/Common/ProcessWindows.cpp


Index: lldb/source/Plugins/Process/Windows/Common/ProcessWindows.cpp
===
--- lldb/source/Plugins/Process/Windows/Common/ProcessWindows.cpp
+++ lldb/source/Plugins/Process/Windows/Common/ProcessWindows.cpp
@@ -79,17 +79,16 @@
 
 ProcessSP ProcessWindows::CreateInstance(lldb::TargetSP target_sp,
  lldb::ListenerSP listener_sp,
- const FileSpec *,
- bool can_connect) {
+ const FileSpec *, bool can_connect) {
   return ProcessSP(new ProcessWindows(target_sp, listener_sp));
 }
 
 static bool ShouldUseLLDBServer() {
   llvm::StringRef use_lldb_server = ::getenv("LLDB_USE_LLDB_SERVER");
-  return use_lldb_server.equals_insensitive("on") ||
- use_lldb_server.equals_insensitive("yes") ||
- use_lldb_server.equals_insensitive("1") ||
- use_lldb_server.equals_insensitive("true");
+  return !use_lldb_server.equals_insensitive("off") &&
+ !use_lldb_server.equals_insensitive("no") &&
+ !use_lldb_server.equals_insensitive("0") &&
+ !use_lldb_server.equals_insensitive("false");
 }
 
 void ProcessWindows::Initialize() {
@@ -97,9 +96,8 @@
 static llvm::once_flag g_once_flag;
 
 llvm::call_once(g_once_flag, []() {
-  PluginManager::RegisterPlugin(GetPluginNameStatic(),
-GetPluginDescriptionStatic(),
-CreateInstance);
+  PluginManager::RegisterPlugin(
+  GetPluginNameStatic(), GetPluginDescriptionStatic(), CreateInstance);
 });
   }
 }
@@ -115,9 +113,8 @@
 ProcessWindows::ProcessWindows(lldb::TargetSP target_sp,
lldb::ListenerSP listener_sp)
 : lldb_private::Process(target_sp, listener_sp),
-  m_watchpoint_ids(
-  RegisterContextWindows::GetNumHardwareBreakpointSlots(),
-  LLDB_INVALID_BREAK_ID) {}
+  m_watchpoint_ids(RegisterContextWindows::GetNumHardwareBreakpointSlots(),
+   LLDB_INVALID_BREAK_ID) {}
 
 ProcessWindows::~ProcessWindows() {}
 


Index: lldb/source/Plugins/Process/Windows/Common/ProcessWindows.cpp
===
--- lldb/source/Plugins/Process/Windows/Common/ProcessWindows.cpp
+++ lldb/source/Plugins/Process/Windows/Common/ProcessWindows.cpp
@@ -79,17 +79,16 @@
 
 ProcessSP ProcessWindows::CreateInstance(lldb::TargetSP target_sp,
  lldb::ListenerSP listener_sp,
- const FileSpec *,
- bool can_connect) {
+ const FileSpec *, bool can_connect) {
   return ProcessSP(new ProcessWindows(target_sp, listener_sp));
 }
 
 static bool ShouldUseLLDBServer() {
   llvm::StringRef use_lldb_server = ::getenv("LLDB_USE_LLDB_SERVER");
-  return use_lldb_server.equals_insensitive("on") ||
- use_lldb_server.equals_insensitive("yes") ||
- use_lldb_server.equals_insensitive("1") ||
- use_lldb_server.equals_insensitive("true");
+  return !use_lldb_server.equals_insensitive("off") &&
+ !use_lldb_server.equals_insensitive("no") &&
+ !use_lldb_server.equals_insensitive("0") &&
+ !use_lldb_server.equals_insensitive("false");
 }
 
 void ProcessWindows::Initialize() {
@@ -97,9 +96,8 @@
 static llvm::once_flag g_once_flag;
 
 llvm::call_once(g_once_flag, []() {
-  PluginManager::RegisterPlugin(GetPluginNameStatic(),
-GetPluginDescriptionStatic(),
-CreateInstance);
+  PluginManager::RegisterPlugin(
+  GetPluginNameStatic(), GetPluginDescriptionStatic(), CreateInstance);
 });
   }
 }
@@ -115,9 +113,8 @@
 ProcessWindows::ProcessWindows(lldb::TargetSP target_sp,
lldb::ListenerSP listener_sp)
 : lldb_private::Process(target_sp, listener_sp),
-  m_watchpoint_ids(
-  RegisterContextWindows::GetNumHardwareBreakpointSlots(),
-  LLDB_INVALID_BREAK_ID) {}
+  m_watchpoint_ids(RegisterContextWindows::GetNumHardwareBreakpointSlots(),
+   LLDB_INVALID_BREAK_ID) {}
 
 ProcessWindows::~ProcessWindows() {}
 
___
lldb-commi

[Lldb-commits] [PATCH] D116972: [lldb] Run the test suite in verbose mode

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

Since @omjavaid is working on a related change in 
https://reviews.llvm.org/D117363, perhaps he can make the necessary changes 
there to support `-j` for the tests?


Repository:
  rZORG LLVM Github Zorg

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116972/new/

https://reviews.llvm.org/D116972

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D117564: [lldb] Remove the requirement for windows clients to specify -DIMPORT_LIBLLDB

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova accepted this revision.
stella.stamenova added a comment.
This revision is now accepted and ready to land.

LGTM.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117564/new/

https://reviews.llvm.org/D117564

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D104886: [lldb] Fix that the embedded Python REPL crashes if it receives SIGINT

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova accepted this revision.
stella.stamenova added a comment.
This revision is now accepted and ready to land.

LGTM.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104886/new/

https://reviews.llvm.org/D104886

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D104886: [lldb] Fix that the embedded Python REPL crashes if it receives SIGINT

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added inline comments.



Comment at: 
lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:73
 
+#if defined(_WIN32)
+// Don't mess with the signal handlers on Windows.

Were these not used on Windows at all before?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104886/new/

https://reviews.llvm.org/D104886

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D116972: [lldb] Run the test suite in verbose mode

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova accepted this revision.
stella.stamenova added a comment.
This revision is now accepted and ready to land.

LGTM


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116972/new/

https://reviews.llvm.org/D116972

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D115324: Added the ability to cache the finalized symbol tables subsequent debug sessions to start faster.

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

The new test (TestModuleCacheSimple) is failing on the windows lldb bot. It 
looks like the deletion of the executable is failing due to permissions and 
other similar tests are skipped on windows for that reason. I haven't looked at 
the test in more detail to see if it would be appropriate to modify somehow so 
it would work:

https://lab.llvm.org/buildbot/#/builders/83/builds/12914

(The bot is rather angry at me for the VS2019 update, but everything should be 
working OK again)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115324/new/

https://reviews.llvm.org/D115324

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D115482: [lldb] Update the PDB tests to pass with the VS2019 toolset

[Stella Stamenova via Phabricator via lldb-commits]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rGf4abf28c0a0b: [lldb] Update the PDB tests to pass with the 
VS2019 toolset (authored by stella.stamenova).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115482/new/

https://reviews.llvm.org/D115482

Files:
  lldb/test/Shell/SymbolFile/PDB/ast-restore.test
  lldb/test/Shell/SymbolFile/PDB/class-layout.test
  lldb/test/Shell/SymbolFile/PDB/enums-layout.test
  lldb/test/Shell/SymbolFile/PDB/typedefs.test
  lldb/test/Shell/SymbolFile/PDB/variables.test

Index: lldb/test/Shell/SymbolFile/PDB/variables.test
===
--- lldb/test/Shell/SymbolFile/PDB/variables.test
+++ lldb/test/Shell/SymbolFile/PDB/variables.test
@@ -51,7 +51,7 @@
 FUNC-MAIN-NEXT: Variable{{.*}}, name = "a"
 FUNC-MAIN-SAME: scope = local
 
-FUNC-CONSTRUCTOR:  Function{{.*}}, mangled = ??0Class@@QEAA@H@Z
+FUNC-CONSTRUCTOR:  Function{{.*}}, {{(de)?}}mangled = {{.*}}{{(Class::)?}}Class{{.*}}
 FUNC-CONSTRUCTOR-NEXT:   Block
 FUNC-CONSTRUCTOR-NEXT: Variable{{.*}}, name = "this"
 FUNC-CONSTRUCTOR-SAME: scope = parameter
@@ -59,7 +59,7 @@
 FUNC-CONSTRUCTOR-NEXT: Variable{{.*}}, name = "a"
 FUNC-CONSTRUCTOR-SAME: scope = parameter
 
-FUNC-MEMBER:  Function{{.*}}, mangled = ?Func@Class@@QEAAXXZ
+FUNC-MEMBER:  Function{{.*}}, {{(de)?}}mangled = {{.*}}{{(Class::)?}}Func{{.*}}
 FUNC-MEMBER-NEXT:   Block
 FUNC-MEMBER-NEXT: Variable{{.*}}, name = "this"
 FUNC-MEMBER-SAME: scope = parameter
Index: lldb/test/Shell/SymbolFile/PDB/typedefs.test
===
--- lldb/test/Shell/SymbolFile/PDB/typedefs.test
+++ lldb/test/Shell/SymbolFile/PDB/typedefs.test
@@ -17,7 +17,6 @@
 CHECK-DAG: name = "char16_t", size = 2, compiler_type = {{.*}} char16_t
 CHECK-DAG: Type{{.*}} , name = "unsigned long", size = 4, compiler_type = {{.*}} unsigned long
 CHECK-DAG: Type{{.*}} , size = 40, compiler_type = {{.*}} unsigned long[10]
-CHECK-DAG: Type{{.*}} , name = "ULongArrayTypedef", compiler_type = {{.*}} typedef ULongArrayTypedef
 
 ; Note: compiler_type of `long double` is represented by the one for `double`
 CHECK-DAG: Type{{.*}} , name = "double", size = 8, compiler_type = {{.*}} double
Index: lldb/test/Shell/SymbolFile/PDB/enums-layout.test
===
--- lldb/test/Shell/SymbolFile/PDB/enums-layout.test
+++ lldb/test/Shell/SymbolFile/PDB/enums-layout.test
@@ -10,35 +10,35 @@
 ; FIXME: PDB does not have information about scoped enumeration (Enum class) so the  
 ; compiler type used is the same as the one for unscoped enumeration.
 
-ENUM:  Type{{.*}} , name = "Enum", size = 4, decl = simpletypestest.cpp:19, compiler_type = {{.*}} enum Enum {
+ENUM:  Type{{.*}} , name = "Enum", size = 4, decl = {{[Ss]}}imple{{[Tt]}}ypes{{[Tt]}}est.cpp:19, compiler_type = {{.*}} enum Enum {
 ENUM_NEXT:RED,
 ENUM_NEXT:GREEN,
 ENUM_NEXT:BLUE
 ENUM_NEXT:}
 
-ENUM_CONST:  Type{{.*}} , name = "EnumConst", size = 4,  decl = simpletypestest.cpp:22, compiler_type = {{.*}} enum EnumConst {
+ENUM_CONST:  Type{{.*}} , name = "EnumConst", size = 4,  decl = {{[Ss]}}imple{{[Tt]}}ypes{{[Tt]}}est.cpp:22, compiler_type = {{.*}} enum EnumConst {
 ENUM_CONST-NEXT:LOW,
 ENUM_CONST-NEXT:NORMAL,
 ENUM_CONST-NEXT:HIGH
 ENUM_CONST-NEXT:}
 
-ENUM_EMPTY:  Type{{.*}} , name = "EnumEmpty", size = 4,  decl = simpletypestest.cpp:25, compiler_type = {{.*}} enum EnumEmpty {
+ENUM_EMPTY:  Type{{.*}} , name = "EnumEmpty", size = 4,  decl = {{[Ss]}}imple{{[Tt]}}ypes{{[Tt]}}est.cpp:25, compiler_type = {{.*}} enum EnumEmpty {
 ENUM_EMPTY-NEXT:}
 
-ENUM_UCHAR:  Type{{.*}} , name = "EnumUChar", size = 1,  decl = simpletypestest.cpp:28, compiler_type = {{.*}} enum EnumUChar {
+ENUM_UCHAR:  Type{{.*}} , name = "EnumUChar", size = 1,  decl = {{[Ss]}}imple{{[Tt]}}ypes{{[Tt]}}est.cpp:28, compiler_type = {{.*}} enum EnumUChar {
 ENUM_UCHAR-NEXT:ON,
 ENUM_UCHAR-NEXT:OFF,
 ENUM_UCHAR-NEXT:AUTO
 ENUM_UCHAR-NEXT:}
 
 ; Note that `enum EnumClass` is tested instead of `enum class EnumClass`
-ENUM_CLASS:  Type{{.*}} , name = "EnumClass", size = 4,  decl = simpletypestest.cpp:32, compiler_type = {{.*}} enum EnumClass {
+ENUM_CLASS:  Type{{.*}} , name = "EnumClass", size = 4,  decl = {{[Ss]}}imple{{[Tt]}}ypes{{[Tt]}}est.cpp:32, compiler_type = {{.*}} enum EnumClass {
 ENUM_CLASS-NEXT:YES,
 ENUM_CLASS-NEXT:NO,
 ENUM_CLASS-NEXT:DEFAULT
 ENUM_CLASS-NEXT:}
 
-ENUM_STRUCT:  Type{{.*}} , name = "EnumStruct", size = 4,  decl = simpletypestest.cpp:35, compiler_type = {{.*}} enum EnumStruct {
+ENUM_STRUCT:  Type{{.*}} , name = "EnumStruct", size = 4,  decl = {{[Ss

[Lldb-commits] [PATCH] D115482: [lldb] Update the PDB tests to pass with the VS2019 toolset

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added inline comments.
Herald added a subscriber: JDevlieghere.



Comment at: lldb/test/Shell/SymbolFile/PDB/enums-layout.test:13
 
-ENUM:  Type{{.*}} , name = "Enum", size = 4, decl = 
simpletypestest.cpp:19, compiler_type = {{.*}} enum Enum {
+ENUM:  Type{{.*}} , name = "Enum", size = 4, decl = 
{{[Ss]}}imple{{[Tt]}}ypes{{[Tt]}}est.cpp:19, compiler_type = {{.*}} enum Enum {
 ENUM_NEXT:RED,

This is particularly absurd. VS2017 toolset does not capitalize the name of the 
file, but VS2019 toolset does.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115482/new/

https://reviews.llvm.org/D115482

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D115482: [lldb] Update the PDB tests to pass with the VS2019 toolset

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova created this revision.
stella.stamenova requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

The pdb lldb tests do not work correctly with both the VS2019 and VS2017 
toolsets at the moment. This change updates several of the tests to work with 
both toolsets. Unfortunately, this makes the tests suboptimal for both 
toolsets, but we can update them to be better for VS2019 once we officially 
drop VS2017. This change is meant to bridge the gap until the update happens, 
so that the buildbots can work with either toolset.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D115482

Files:
  lldb/test/Shell/SymbolFile/PDB/ast-restore.test
  lldb/test/Shell/SymbolFile/PDB/class-layout.test
  lldb/test/Shell/SymbolFile/PDB/enums-layout.test
  lldb/test/Shell/SymbolFile/PDB/typedefs.test
  lldb/test/Shell/SymbolFile/PDB/variables.test

Index: lldb/test/Shell/SymbolFile/PDB/variables.test
===
--- lldb/test/Shell/SymbolFile/PDB/variables.test
+++ lldb/test/Shell/SymbolFile/PDB/variables.test
@@ -51,7 +51,7 @@
 FUNC-MAIN-NEXT: Variable{{.*}}, name = "a"
 FUNC-MAIN-SAME: scope = local
 
-FUNC-CONSTRUCTOR:  Function{{.*}}, mangled = ??0Class@@QEAA@H@Z
+FUNC-CONSTRUCTOR:  Function{{.*}}, {{(de)?}}mangled = {{.*}}{{(Class::)?}}Class{{.*}}
 FUNC-CONSTRUCTOR-NEXT:   Block
 FUNC-CONSTRUCTOR-NEXT: Variable{{.*}}, name = "this"
 FUNC-CONSTRUCTOR-SAME: scope = parameter
@@ -59,7 +59,7 @@
 FUNC-CONSTRUCTOR-NEXT: Variable{{.*}}, name = "a"
 FUNC-CONSTRUCTOR-SAME: scope = parameter
 
-FUNC-MEMBER:  Function{{.*}}, mangled = ?Func@Class@@QEAAXXZ
+FUNC-MEMBER:  Function{{.*}}, {{(de)?}}mangled = {{.*}}{{(Class::)?}}Func{{.*}}
 FUNC-MEMBER-NEXT:   Block
 FUNC-MEMBER-NEXT: Variable{{.*}}, name = "this"
 FUNC-MEMBER-SAME: scope = parameter
Index: lldb/test/Shell/SymbolFile/PDB/typedefs.test
===
--- lldb/test/Shell/SymbolFile/PDB/typedefs.test
+++ lldb/test/Shell/SymbolFile/PDB/typedefs.test
@@ -17,7 +17,6 @@
 CHECK-DAG: name = "char16_t", size = 2, compiler_type = {{.*}} char16_t
 CHECK-DAG: Type{{.*}} , name = "unsigned long", size = 4, compiler_type = {{.*}} unsigned long
 CHECK-DAG: Type{{.*}} , size = 40, compiler_type = {{.*}} unsigned long[10]
-CHECK-DAG: Type{{.*}} , name = "ULongArrayTypedef", compiler_type = {{.*}} typedef ULongArrayTypedef
 
 ; Note: compiler_type of `long double` is represented by the one for `double`
 CHECK-DAG: Type{{.*}} , name = "double", size = 8, compiler_type = {{.*}} double
Index: lldb/test/Shell/SymbolFile/PDB/enums-layout.test
===
--- lldb/test/Shell/SymbolFile/PDB/enums-layout.test
+++ lldb/test/Shell/SymbolFile/PDB/enums-layout.test
@@ -10,35 +10,35 @@
 ; FIXME: PDB does not have information about scoped enumeration (Enum class) so the  
 ; compiler type used is the same as the one for unscoped enumeration.
 
-ENUM:  Type{{.*}} , name = "Enum", size = 4, decl = simpletypestest.cpp:19, compiler_type = {{.*}} enum Enum {
+ENUM:  Type{{.*}} , name = "Enum", size = 4, decl = {{[Ss]}}imple{{[Tt]}}ypes{{[Tt]}}est.cpp:19, compiler_type = {{.*}} enum Enum {
 ENUM_NEXT:RED,
 ENUM_NEXT:GREEN,
 ENUM_NEXT:BLUE
 ENUM_NEXT:}
 
-ENUM_CONST:  Type{{.*}} , name = "EnumConst", size = 4,  decl = simpletypestest.cpp:22, compiler_type = {{.*}} enum EnumConst {
+ENUM_CONST:  Type{{.*}} , name = "EnumConst", size = 4,  decl = {{[Ss]}}imple{{[Tt]}}ypes{{[Tt]}}est.cpp:22, compiler_type = {{.*}} enum EnumConst {
 ENUM_CONST-NEXT:LOW,
 ENUM_CONST-NEXT:NORMAL,
 ENUM_CONST-NEXT:HIGH
 ENUM_CONST-NEXT:}
 
-ENUM_EMPTY:  Type{{.*}} , name = "EnumEmpty", size = 4,  decl = simpletypestest.cpp:25, compiler_type = {{.*}} enum EnumEmpty {
+ENUM_EMPTY:  Type{{.*}} , name = "EnumEmpty", size = 4,  decl = {{[Ss]}}imple{{[Tt]}}ypes{{[Tt]}}est.cpp:25, compiler_type = {{.*}} enum EnumEmpty {
 ENUM_EMPTY-NEXT:}
 
-ENUM_UCHAR:  Type{{.*}} , name = "EnumUChar", size = 1,  decl = simpletypestest.cpp:28, compiler_type = {{.*}} enum EnumUChar {
+ENUM_UCHAR:  Type{{.*}} , name = "EnumUChar", size = 1,  decl = {{[Ss]}}imple{{[Tt]}}ypes{{[Tt]}}est.cpp:28, compiler_type = {{.*}} enum EnumUChar {
 ENUM_UCHAR-NEXT:ON,
 ENUM_UCHAR-NEXT:OFF,
 ENUM_UCHAR-NEXT:AUTO
 ENUM_UCHAR-NEXT:}
 
 ; Note that `enum EnumClass` is tested instead of `enum class EnumClass`
-ENUM_CLASS:  Type{{.*}} , name = "EnumClass", size = 4,  decl = simpletypestest.cpp:32, compiler_type = {{.*}} enum EnumClass {
+ENUM_CLASS:  Type{{.*}} , name = "EnumClass", size = 4,  decl = {{[Ss]}}imple{{[Tt]}}ypes{{[Tt]}}est.cpp:32, compiler_type = {{.*}} enum EnumClass {
 ENUM_CLASS-NEXT:YES,
 ENUM_CLASS-NEXT:NO,
 ENUM_CLASS-NE

[Lldb-commits] [PATCH] D114907: [lldb] Skip two lldb tests on Windows because they are flaky

[Stella Stamenova via Phabricator via lldb-commits]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rGc24860118a7e: [lldb] Skip two lldb tests on Windows because 
they are flaky (authored by stella.stamenova).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114907/new/

https://reviews.llvm.org/D114907

Files:
  
lldb/test/API/functionalities/thread/thread_specific_break_plus_condition/TestThreadSpecificBpPlusCondition.py
  lldb/test/API/python_api/lldbutil/iter/TestLLDBIterator.py


Index: lldb/test/API/python_api/lldbutil/iter/TestLLDBIterator.py
===
--- lldb/test/API/python_api/lldbutil/iter/TestLLDBIterator.py
+++ lldb/test/API/python_api/lldbutil/iter/TestLLDBIterator.py
@@ -89,6 +89,7 @@
 self.assertEqual(yours[i], mine[i],
 "ID of yours[{0}] and mine[{0}] matches".format(i))
 
+@skipIfWindows # This test is flaky on Windows
 def test_lldb_iter_frame(self):
 """Test iterator works correctly for SBProcess->SBThread->SBFrame."""
 self.build()
Index: 
lldb/test/API/functionalities/thread/thread_specific_break_plus_condition/TestThreadSpecificBpPlusCondition.py
===
--- 
lldb/test/API/functionalities/thread/thread_specific_break_plus_condition/TestThreadSpecificBpPlusCondition.py
+++ 
lldb/test/API/functionalities/thread/thread_specific_break_plus_condition/TestThreadSpecificBpPlusCondition.py
@@ -20,6 +20,7 @@
 # hits break in another thread in testrun
 @add_test_categories(['pyapi'])
 @expectedFlakeyNetBSD
+@skipIfWindows # This test is flaky on Windows
 def test_python(self):
 """Test that we obey thread conditioned breakpoints."""
 self.build()


Index: lldb/test/API/python_api/lldbutil/iter/TestLLDBIterator.py
===
--- lldb/test/API/python_api/lldbutil/iter/TestLLDBIterator.py
+++ lldb/test/API/python_api/lldbutil/iter/TestLLDBIterator.py
@@ -89,6 +89,7 @@
 self.assertEqual(yours[i], mine[i],
 "ID of yours[{0}] and mine[{0}] matches".format(i))
 
+@skipIfWindows # This test is flaky on Windows
 def test_lldb_iter_frame(self):
 """Test iterator works correctly for SBProcess->SBThread->SBFrame."""
 self.build()
Index: lldb/test/API/functionalities/thread/thread_specific_break_plus_condition/TestThreadSpecificBpPlusCondition.py
===
--- lldb/test/API/functionalities/thread/thread_specific_break_plus_condition/TestThreadSpecificBpPlusCondition.py
+++ lldb/test/API/functionalities/thread/thread_specific_break_plus_condition/TestThreadSpecificBpPlusCondition.py
@@ -20,6 +20,7 @@
 # hits break in another thread in testrun
 @add_test_categories(['pyapi'])
 @expectedFlakeyNetBSD
+@skipIfWindows # This test is flaky on Windows
 def test_python(self):
 """Test that we obey thread conditioned breakpoints."""
 self.build()
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D114907: [lldb] Skip two lldb tests on Windows because they are flaky

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova created this revision.
stella.stamenova requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

These tests work fine with VS2017, but become more flaky with VS2019 and the 
buildbot is about to get upgraded.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D114907

Files:
  
lldb/test/API/functionalities/thread/thread_specific_break_plus_condition/TestThreadSpecificBpPlusCondition.py
  lldb/test/API/python_api/lldbutil/iter/TestLLDBIterator.py


Index: lldb/test/API/python_api/lldbutil/iter/TestLLDBIterator.py
===
--- lldb/test/API/python_api/lldbutil/iter/TestLLDBIterator.py
+++ lldb/test/API/python_api/lldbutil/iter/TestLLDBIterator.py
@@ -89,6 +89,7 @@
 self.assertEqual(yours[i], mine[i],
 "ID of yours[{0}] and mine[{0}] matches".format(i))
 
+@skipIfWindows # This test is flaky on Windows
 def test_lldb_iter_frame(self):
 """Test iterator works correctly for SBProcess->SBThread->SBFrame."""
 self.build()
Index: 
lldb/test/API/functionalities/thread/thread_specific_break_plus_condition/TestThreadSpecificBpPlusCondition.py
===
--- 
lldb/test/API/functionalities/thread/thread_specific_break_plus_condition/TestThreadSpecificBpPlusCondition.py
+++ 
lldb/test/API/functionalities/thread/thread_specific_break_plus_condition/TestThreadSpecificBpPlusCondition.py
@@ -20,6 +20,7 @@
 # hits break in another thread in testrun
 @add_test_categories(['pyapi'])
 @expectedFlakeyNetBSD
+@skipIfWindows # This test is flaky on Windows
 def test_python(self):
 """Test that we obey thread conditioned breakpoints."""
 self.build()


Index: lldb/test/API/python_api/lldbutil/iter/TestLLDBIterator.py
===
--- lldb/test/API/python_api/lldbutil/iter/TestLLDBIterator.py
+++ lldb/test/API/python_api/lldbutil/iter/TestLLDBIterator.py
@@ -89,6 +89,7 @@
 self.assertEqual(yours[i], mine[i],
 "ID of yours[{0}] and mine[{0}] matches".format(i))
 
+@skipIfWindows # This test is flaky on Windows
 def test_lldb_iter_frame(self):
 """Test iterator works correctly for SBProcess->SBThread->SBFrame."""
 self.build()
Index: lldb/test/API/functionalities/thread/thread_specific_break_plus_condition/TestThreadSpecificBpPlusCondition.py
===
--- lldb/test/API/functionalities/thread/thread_specific_break_plus_condition/TestThreadSpecificBpPlusCondition.py
+++ lldb/test/API/functionalities/thread/thread_specific_break_plus_condition/TestThreadSpecificBpPlusCondition.py
@@ -20,6 +20,7 @@
 # hits break in another thread in testrun
 @add_test_categories(['pyapi'])
 @expectedFlakeyNetBSD
+@skipIfWindows # This test is flaky on Windows
 def test_python(self):
 """Test that we obey thread conditioned breakpoints."""
 self.build()
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D114467: [LLDB][NativePDB] Allow find functions by full names

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

@zequanwu : It looks like the bot is still broken: 
https://lab.llvm.org/buildbot/#/builders/83/builds/12413


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114467/new/

https://reviews.llvm.org/D114467

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D114467: [LLDB][NativePDB] Allow find functions by full names

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

This broke the windows bot:

https://lab.llvm.org/buildbot/#/builders/83/builds/12270

I'd like to get it back to green, so please address this ASAP or I'll follow up 
with a reverting change later today.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114467/new/

https://reviews.llvm.org/D114467

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D113821: [LLDB][NativePDB] Fix image lookup by address

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

I think this broke the windows bot:

https://lab.llvm.org/buildbot/#/builders/83/builds/12036


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113821/new/

https://reviews.llvm.org/D113821

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D104886: [lldb] Fix that the embedded Python REPL crashes if it receives SIGINT

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

This broke the build on Windows. The buildbot was, sadly, already red because 
of another test failure:

https://lab.llvm.org/buildbot/#/builders/83/builds/11931


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104886/new/

https://reviews.llvm.org/D104886

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D113650: [lldb] fix -print-script-interpreter-info on windows

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

Can you please disable the test on Windows or back your change out until 
there's a fix? There are already other failures that are getting missed because 
the bot is red.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113650/new/

https://reviews.llvm.org/D113650

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D113650: [lldb] fix -print-script-interpreter-info on windows

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added inline comments.



Comment at: 
lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:432
+  elif os.name == 'posix':
+  exename = "python" + str(sys.version_info[0])
+  info['executable'] = os.path.join(sys.prefix, 'bin', exename)

lawrence_danna wrote:
> stella.stamenova wrote:
> > Python on windows could have a version too (e.g. python3.exe)
> Under what circumstances?   How do we determine if it does? The one from 
> python.org doesn't.
I am not sure. I *think* it depends on whether you have python 2 and python 3 
installed at the same time.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113650/new/

https://reviews.llvm.org/D113650

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D113650: [lldb] fix -print-script-interpreter-info on windows

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added inline comments.



Comment at: 
lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:413
 
+static const char GetInterpreterInfoScript[] = R"(
+import os

Does `sys.executable` not work for some reason?



Comment at: 
lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:432
+  elif os.name == 'posix':
+  exename = "python" + str(sys.version_info[0])
+  info['executable'] = os.path.join(sys.prefix, 'bin', exename)

Python on windows could have a version too (e.g. python3.exe)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113650/new/

https://reviews.llvm.org/D113650

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D112973: [lldb] make it easier to find LLDB's python

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

Windows buildbot is broken:

https://lab.llvm.org/buildbot/#/builders/83/builds/11865


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112973/new/

https://reviews.llvm.org/D112973

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D113047: [lldb] update TestEchoCommands

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

The Windows buildbot is still broken after this change:

https://lab.llvm.org/buildbot/#/builders/83/builds/11630


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113047/new/

https://reviews.llvm.org/D113047

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D113047: [lldb] update TestEchoCommands

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added inline comments.



Comment at: lldb/test/Shell/Settings/TestEchoCommands.test:4
 # RUN: %lldb -x -b -o 'settings set interpreter.echo-commands false' 
-s %S/Inputs/EchoCommandsTest.in | FileCheck %S/Inputs/EchoCommandsNone.out
-# RUN: %lldb -x -b --source-quietly  
-s %S/Inputs/EchoCommandsTest.in | FileCheck %S/Inputs/EchoCommandsQuiet.out
+# RUN: ( echo start ; %lldb -x -b --source-quietly -s 
%S/Inputs/EchoCommandsTest.in ; echo done ) | FileCheck  
%S/Inputs/EchoCommandsQuiet.out

The Windows buildbot is not happy with this line:

https://lab.llvm.org/buildbot/#/builders/83/builds/11630


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113047/new/

https://reviews.llvm.org/D113047

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D112988: [lldb] fix --source-quietly

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

It looks like some of the tests need to be updated after this change (at least 
on Windows, the Windows LLDB bot is broken now):

https://lab.llvm.org/buildbot/#/builders/83/builds/11623/steps/7/logs/stdio


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112988/new/

https://reviews.llvm.org/D112988

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D111659: [lldb] Skip several lldb tests that are flaky on Windows

[Stella Stamenova via Phabricator via lldb-commits]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rG58917054c298: [lldb] Skip several lldb tests that are flaky 
on Windows (authored by stella.stamenova).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111659/new/

https://reviews.llvm.org/D111659

Files:
  lldb/test/API/commands/process/attach/TestProcessAttach.py
  
lldb/test/API/commands/target/auto-install-main-executable/TestAutoInstallMainExecutable.py
  lldb/test/API/tools/lldb-server/TestGdbRemoteAttachOrWait.py
  lldb/test/API/tools/lldb-server/TestGdbRemoteAttachWait.py


Index: lldb/test/API/tools/lldb-server/TestGdbRemoteAttachWait.py
===
--- lldb/test/API/tools/lldb-server/TestGdbRemoteAttachWait.py
+++ lldb/test/API/tools/lldb-server/TestGdbRemoteAttachWait.py
@@ -13,6 +13,7 @@
 
 mydir = TestBase.compute_mydir(__file__)
 
+@skipIfWindows # This test is flaky on Windows
 def test_attach_with_vAttachWait(self):
 exe = '%s_%d' % (self.testMethodName, os.getpid())
 
Index: lldb/test/API/tools/lldb-server/TestGdbRemoteAttachOrWait.py
===
--- lldb/test/API/tools/lldb-server/TestGdbRemoteAttachOrWait.py
+++ lldb/test/API/tools/lldb-server/TestGdbRemoteAttachOrWait.py
@@ -13,6 +13,7 @@
 
 mydir = TestBase.compute_mydir(__file__)
 
+@skipIfWindows # This test is flaky on Windows
 def test_launch_before_attach_with_vAttachOrWait(self):
 exe = '%s_%d' % (self.testMethodName, os.getpid())
 self.build(dictionary={'EXE': exe})
@@ -57,6 +58,7 @@
 reported_pid = int(pid_text, base=16)
 self.assertEqual(reported_pid, inferior.pid)
 
+@skipIfWindows # This test is flaky on Windows
 def test_launch_after_attach_with_vAttachOrWait(self):
 exe = '%s_%d' % (self.testMethodName, os.getpid())
 self.build(dictionary={'EXE': exe})
Index: 
lldb/test/API/commands/target/auto-install-main-executable/TestAutoInstallMainExecutable.py
===
--- 
lldb/test/API/commands/target/auto-install-main-executable/TestAutoInstallMainExecutable.py
+++ 
lldb/test/API/commands/target/auto-install-main-executable/TestAutoInstallMainExecutable.py
@@ -16,6 +16,7 @@
 NO_DEBUG_INFO_TESTCASE = True
 
 @skipIfRemote
+@skipIfWindows # This test is flaky on Windows
 def test_target_auto_install_main_executable(self):
 if lldbgdbserverutils.get_lldb_server_exe() is None:
   self.skipTest("lldb-server not found")
Index: lldb/test/API/commands/process/attach/TestProcessAttach.py
===
--- lldb/test/API/commands/process/attach/TestProcessAttach.py
+++ lldb/test/API/commands/process/attach/TestProcessAttach.py
@@ -101,6 +101,7 @@
 process = target.GetProcess()
 self.assertTrue(process, PROCESS_IS_VALID)
 
+@skipIfWindows # This test is flaky on Windows
 @expectedFailureNetBSD
 def test_attach_to_process_by_id_correct_executable_offset(self):
 """


Index: lldb/test/API/tools/lldb-server/TestGdbRemoteAttachWait.py
===
--- lldb/test/API/tools/lldb-server/TestGdbRemoteAttachWait.py
+++ lldb/test/API/tools/lldb-server/TestGdbRemoteAttachWait.py
@@ -13,6 +13,7 @@
 
 mydir = TestBase.compute_mydir(__file__)
 
+@skipIfWindows # This test is flaky on Windows
 def test_attach_with_vAttachWait(self):
 exe = '%s_%d' % (self.testMethodName, os.getpid())
 
Index: lldb/test/API/tools/lldb-server/TestGdbRemoteAttachOrWait.py
===
--- lldb/test/API/tools/lldb-server/TestGdbRemoteAttachOrWait.py
+++ lldb/test/API/tools/lldb-server/TestGdbRemoteAttachOrWait.py
@@ -13,6 +13,7 @@
 
 mydir = TestBase.compute_mydir(__file__)
 
+@skipIfWindows # This test is flaky on Windows
 def test_launch_before_attach_with_vAttachOrWait(self):
 exe = '%s_%d' % (self.testMethodName, os.getpid())
 self.build(dictionary={'EXE': exe})
@@ -57,6 +58,7 @@
 reported_pid = int(pid_text, base=16)
 self.assertEqual(reported_pid, inferior.pid)
 
+@skipIfWindows # This test is flaky on Windows
 def test_launch_after_attach_with_vAttachOrWait(self):
 exe = '%s_%d' % (self.testMethodName, os.getpid())
 self.build(dictionary={'EXE': exe})
Index: lldb/test/API/commands/target/auto-install-main-executable/TestAutoInstallMainExecutable.py
===
--- lldb/test/API/commands/target/auto-install-main-executable/TestAutoInstallMainExecutable.py
+++ lldb/test/API/commands/target/auto-install-main-executable/TestAutoInsta

[Lldb-commits] [PATCH] D111659: [lldb] Skip several lldb tests that are flaky on Windows

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova created this revision.
stella.stamenova added a reviewer: labath.
stella.stamenova requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

These tests fail every 10 or so runs on Windows causing both local failures as 
well as buildbot failures.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D111659

Files:
  lldb/test/API/commands/process/attach/TestProcessAttach.py
  
lldb/test/API/commands/target/auto-install-main-executable/TestAutoInstallMainExecutable.py
  lldb/test/API/tools/lldb-server/TestGdbRemoteAttachOrWait.py
  lldb/test/API/tools/lldb-server/TestGdbRemoteAttachWait.py


Index: lldb/test/API/tools/lldb-server/TestGdbRemoteAttachWait.py
===
--- lldb/test/API/tools/lldb-server/TestGdbRemoteAttachWait.py
+++ lldb/test/API/tools/lldb-server/TestGdbRemoteAttachWait.py
@@ -13,6 +13,7 @@
 
 mydir = TestBase.compute_mydir(__file__)
 
+@skipIfWindows # This test is flaky on Windows
 def test_attach_with_vAttachWait(self):
 exe = '%s_%d' % (self.testMethodName, os.getpid())
 
Index: lldb/test/API/tools/lldb-server/TestGdbRemoteAttachOrWait.py
===
--- lldb/test/API/tools/lldb-server/TestGdbRemoteAttachOrWait.py
+++ lldb/test/API/tools/lldb-server/TestGdbRemoteAttachOrWait.py
@@ -13,6 +13,7 @@
 
 mydir = TestBase.compute_mydir(__file__)
 
+@skipIfWindows # This test is flaky on Windows
 def test_launch_before_attach_with_vAttachOrWait(self):
 exe = '%s_%d' % (self.testMethodName, os.getpid())
 self.build(dictionary={'EXE': exe})
@@ -57,6 +58,7 @@
 reported_pid = int(pid_text, base=16)
 self.assertEqual(reported_pid, inferior.pid)
 
+@skipIfWindows # This test is flaky on Windows
 def test_launch_after_attach_with_vAttachOrWait(self):
 exe = '%s_%d' % (self.testMethodName, os.getpid())
 self.build(dictionary={'EXE': exe})
Index: 
lldb/test/API/commands/target/auto-install-main-executable/TestAutoInstallMainExecutable.py
===
--- 
lldb/test/API/commands/target/auto-install-main-executable/TestAutoInstallMainExecutable.py
+++ 
lldb/test/API/commands/target/auto-install-main-executable/TestAutoInstallMainExecutable.py
@@ -16,6 +16,7 @@
 NO_DEBUG_INFO_TESTCASE = True
 
 @skipIfRemote
+@skipIfWindows # This test is flaky on Windows
 def test_target_auto_install_main_executable(self):
 if lldbgdbserverutils.get_lldb_server_exe() is None:
   self.skipTest("lldb-server not found")
Index: lldb/test/API/commands/process/attach/TestProcessAttach.py
===
--- lldb/test/API/commands/process/attach/TestProcessAttach.py
+++ lldb/test/API/commands/process/attach/TestProcessAttach.py
@@ -101,6 +101,7 @@
 process = target.GetProcess()
 self.assertTrue(process, PROCESS_IS_VALID)
 
+@skipIfWindows # This test is flaky on Windows
 @expectedFailureNetBSD
 def test_attach_to_process_by_id_correct_executable_offset(self):
 """


Index: lldb/test/API/tools/lldb-server/TestGdbRemoteAttachWait.py
===
--- lldb/test/API/tools/lldb-server/TestGdbRemoteAttachWait.py
+++ lldb/test/API/tools/lldb-server/TestGdbRemoteAttachWait.py
@@ -13,6 +13,7 @@
 
 mydir = TestBase.compute_mydir(__file__)
 
+@skipIfWindows # This test is flaky on Windows
 def test_attach_with_vAttachWait(self):
 exe = '%s_%d' % (self.testMethodName, os.getpid())
 
Index: lldb/test/API/tools/lldb-server/TestGdbRemoteAttachOrWait.py
===
--- lldb/test/API/tools/lldb-server/TestGdbRemoteAttachOrWait.py
+++ lldb/test/API/tools/lldb-server/TestGdbRemoteAttachOrWait.py
@@ -13,6 +13,7 @@
 
 mydir = TestBase.compute_mydir(__file__)
 
+@skipIfWindows # This test is flaky on Windows
 def test_launch_before_attach_with_vAttachOrWait(self):
 exe = '%s_%d' % (self.testMethodName, os.getpid())
 self.build(dictionary={'EXE': exe})
@@ -57,6 +58,7 @@
 reported_pid = int(pid_text, base=16)
 self.assertEqual(reported_pid, inferior.pid)
 
+@skipIfWindows # This test is flaky on Windows
 def test_launch_after_attach_with_vAttachOrWait(self):
 exe = '%s_%d' % (self.testMethodName, os.getpid())
 self.build(dictionary={'EXE': exe})
Index: lldb/test/API/commands/target/auto-install-main-executable/TestAutoInstallMainExecutable.py
===
--- lldb/test/API/commands/target/auto-install-main-executable/TestAutoInstallMainExecutable.py
+++ lldb/test/API/commands/target/auto-install-main-executable/TestAutoInstallMainExecutable.py
@@ -16,6 +16

[Lldb-commits] [PATCH] D107585: [lldb/Plugins] Add support for ScriptedThread in ScriptedProcess

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

This broke the windows lldb bot:

https://lab.llvm.org/buildbot/#/builders/83/builds/10836


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107585/new/

https://reviews.llvm.org/D107585

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D107475: [lldb] [gdb-remote] Use hexadecimal numbers in vFile packets for GDB compliance

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

This change is causing failures on the Windows lldb bot:

https://lab.llvm.org/buildbot/#/builders/83/builds/9098


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107475/new/

https://reviews.llvm.org/D107475

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D100299: Be lazier about loading .dwo files

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

In D100299#2917598 , @jankratochvil 
wrote:

> In D100299#2917467 , @Eric wrote:
>
>> Is arm hardware necessary to test this,
>
> In this case it is not as it does not require linking. Usually I find easier 
> to run it natively than to setup all the cross-compilation libraries and 
> include files. I agree it was my mistake as the cross-compilation is easier 
> in this case.
>
>> or can the test be modified to cross-compile to arm to see what is going on?
>
> In fact it is visible already from the build log 
>  and it is then 
> obvious from source code 
> .
>  I did not see it first from the default shortened dump.
>
>> Is there a way to determine what build target the test bot is using?
>
> Yes, `armv8l-unknown-linux-gnueabihf`.
>
>> In any case the broken test doesn't exercise lldb at all so it could be 
>> separated from the patch.
>
> If the test did not exercise LLDB it should have been removed. But it does 
> exercise LLDB.
>
> I have added to `lldb/test/Shell/SymbolFile/DWARF/split-optimized.c`:
>
>   +// ObjectFileELF::ApplyRelocations does not implement arm32.
>   +// XFAIL: target-arm && linux-gnu
>
> Hopefully it will satisfy the buildbot now.

This also fails on the Windows lldb bot:

https://lab.llvm.org/buildbot/#/builders/83/builds/8842

Perhaps something more than several xfails is needed?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100299/new/

https://reviews.llvm.org/D100299

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D105471: [lldb] Generalize empty record size computation to avoid giving empty C++ structs a size of 0

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

In D105471#2896533 , 
@stella.stamenova wrote:

> I think this change broke the Windows LLDB bot. More specifically the 
> TestStructTypes test:
>
> https://lab.llvm.org/buildbot/#/builders/83/builds/8528

Looks like you fixed it already :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105471/new/

https://reviews.llvm.org/D105471

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D105471: [lldb] Generalize empty record size computation to avoid giving empty C++ structs a size of 0

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

I think this change broke the Windows LLDB bot. More specifically the 
TestStructTypes test:

https://lab.llvm.org/buildbot/#/builders/83/builds/8528


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105471/new/

https://reviews.llvm.org/D105471

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D105160: Create synthetic symbol names on demand to improve memory consumption and startup times.

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

In D105160#2848805 , @clayborg wrote:

> @stella.stamenova all test suite failures should be fixed now. This is a redo 
> on https://reviews.llvm.org/D104488 which was reverted in less that a day...

@clayborg : Thanks! We ended up with several more failing tests because of 
issues that were committed while the bot was red and was not sending 
notifications. It's always good to keep things green, so that issues don't pile 
up. I'm sorry I didn't get to it sooner.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105160/new/

https://reviews.llvm.org/D105160

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D104488: Create synthetic symbol names on demand to improve memory consumption and startup times.

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

This broke the windows lldb bot and the follow up changes did not fix it:

https://lab.llvm.org/buildbot/#/builders/83/builds/7748

Can you have a look?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104488/new/

https://reviews.llvm.org/D104488

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D101128: [lldb-vscode] only report long running progress events

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

In D101128#2831098 , @wallace wrote:

> I'm reverting it asap

Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101128/new/

https://reviews.llvm.org/D101128

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D101128: [lldb-vscode] only report long running progress events

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

@wallace : Your most recent change to comment out ProgressEventThreadFunction 
is causing warnings to be generated when building with clang. Please have a 
look:

  /usr/bin/clang++ -DGTEST_HAS_RTTI=0 -DHAVE_ROUND -D_DEBUG -D_GNU_SOURCE 
-D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS 
-Itools/lldb/tools/lldb-vscode -I/mnt/vss/_work/1/s/lldb/tools/lldb-vscode 
-I/mnt/vss/_work/1/s/lldb/include -Itools/lldb/include -Iinclude 
-I/mnt/vss/_work/1/s/llvm/include -I/mnt/vss/_work/1/s/llvm/../clang/include 
-Itools/lldb/../clang/include -I/usr/include/libxml2 -fPIC 
-fvisibility-inlines-hidden -Werror -Werror=date-time 
-Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter 
-Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic 
-Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough 
-Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor 
-Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion 
-Wmisleading-indentation -fdiagnostics-color -ffunction-sections 
-fdata-sections -Wno-deprecated-declarations -Wno-unknown-pragmas 
-Wno-strict-aliasing -Wno-deprecated-register -Wno-vla-extension -O3 -DNDEBUG  
-fno-exceptions -fno-rtti -UNDEBUG -std=c++14 -MD -MT 
tools/lldb/tools/lldb-vscode/CMakeFiles/lldb-vscode.dir/lldb-vscode.cpp.o -MF 
tools/lldb/tools/lldb-vscode/CMakeFiles/lldb-vscode.dir/lldb-vscode.cpp.o.d -o 
tools/lldb/tools/lldb-vscode/CMakeFiles/lldb-vscode.dir/lldb-vscode.cpp.o -c 
/mnt/vss/_work/1/s/lldb/tools/lldb-vscode/lldb-vscode.cpp
  /mnt/vss/_work/1/s/lldb/tools/lldb-vscode/lldb-vscode.cpp:370:6: error: 
unused function 'ProgressEventThreadFunction' [-Werror,-Wunused-function]
  void ProgressEventThreadFunction() {
   ^
  1 error generated.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101128/new/

https://reviews.llvm.org/D101128

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D103575: Allow signposts to take advantage of deferred string substitution

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

The Windows buildbot does not like signposts:

https://lab.llvm.org/buildbot/#/builders/83/builds/7271


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103575/new/

https://reviews.llvm.org/D103575

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D104047: [lldb, win] Remove obsolete workaround for MSVC and python libs

[Stella Stamenova via Phabricator via lldb-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rGca10add5dbe4: [lldb, win] Remove obsolete workaround for 
MSVC and python libs (authored by stella.stamenova).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104047/new/

https://reviews.llvm.org/D104047

Files:
  lldb/source/API/CMakeLists.txt


Index: lldb/source/API/CMakeLists.txt
===
--- lldb/source/API/CMakeLists.txt
+++ lldb/source/API/CMakeLists.txt
@@ -182,13 +182,7 @@
   set_target_properties(liblldb_exports PROPERTIES FOLDER "lldb misc")
 endif()
 
-if (MSVC)
-  # Only MSVC has the ABI compatibility problem and avoids using 
FindPythonLibs,
-  # so only it needs to explicitly link against ${Python3_LIBRARIES}
-  if (LLDB_ENABLE_PYTHON)
-target_link_libraries(liblldb PRIVATE ${Python3_LIBRARIES})
-  endif()
-else()
+if (NOT MSVC)
   set_target_properties(liblldb
 PROPERTIES
 OUTPUT_NAME lldb


Index: lldb/source/API/CMakeLists.txt
===
--- lldb/source/API/CMakeLists.txt
+++ lldb/source/API/CMakeLists.txt
@@ -182,13 +182,7 @@
   set_target_properties(liblldb_exports PROPERTIES FOLDER "lldb misc")
 endif()
 
-if (MSVC)
-  # Only MSVC has the ABI compatibility problem and avoids using FindPythonLibs,
-  # so only it needs to explicitly link against ${Python3_LIBRARIES}
-  if (LLDB_ENABLE_PYTHON)
-target_link_libraries(liblldb PRIVATE ${Python3_LIBRARIES})
-  endif()
-else()
+if (NOT MSVC)
   set_target_properties(liblldb
 PROPERTIES
 OUTPUT_NAME lldb
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D104047: [lldb, win] Remove obsolete workaround for MSVC and python libs

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova created this revision.
stella.stamenova added a reviewer: JDevlieghere.
Herald added a subscriber: mgorny.
stella.stamenova requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

This workaround was necessary before the major changes of managing python 
versions, but it is not needed anymore.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D104047

Files:
  lldb/source/API/CMakeLists.txt


Index: lldb/source/API/CMakeLists.txt
===
--- lldb/source/API/CMakeLists.txt
+++ lldb/source/API/CMakeLists.txt
@@ -182,13 +182,7 @@
   set_target_properties(liblldb_exports PROPERTIES FOLDER "lldb misc")
 endif()
 
-if (MSVC)
-  # Only MSVC has the ABI compatibility problem and avoids using 
FindPythonLibs,
-  # so only it needs to explicitly link against ${Python3_LIBRARIES}
-  if (LLDB_ENABLE_PYTHON)
-target_link_libraries(liblldb PRIVATE ${Python3_LIBRARIES})
-  endif()
-else()
+if (NOT MSVC)
   set_target_properties(liblldb
 PROPERTIES
 OUTPUT_NAME lldb


Index: lldb/source/API/CMakeLists.txt
===
--- lldb/source/API/CMakeLists.txt
+++ lldb/source/API/CMakeLists.txt
@@ -182,13 +182,7 @@
   set_target_properties(liblldb_exports PROPERTIES FOLDER "lldb misc")
 endif()
 
-if (MSVC)
-  # Only MSVC has the ABI compatibility problem and avoids using FindPythonLibs,
-  # so only it needs to explicitly link against ${Python3_LIBRARIES}
-  if (LLDB_ENABLE_PYTHON)
-target_link_libraries(liblldb PRIVATE ${Python3_LIBRARIES})
-  endif()
-else()
+if (NOT MSVC)
   set_target_properties(liblldb
 PROPERTIES
 OUTPUT_NAME lldb
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D102208: Remove Windows editline from LLDB

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

I don't have context into this either. Does this cause any test failures or is 
everything still green after the change?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102208/new/

https://reviews.llvm.org/D102208

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D101333: Also display the underlying error message when displaying a fixit

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.
Herald added a subscriber: JDevlieghere.

It looks like this broke the Windows LLDB bot: 
https://lab.llvm.org/buildbot/#/builders/83/builds/6085


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101333/new/

https://reviews.llvm.org/D101333

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D100977: [lldb] Use forward type in pointer-to-member

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

Looks like this is failing on the Windows LLDB bot:

https://lab.llvm.org/buildbot/#/builders/83/builds/6033


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100977/new/

https://reviews.llvm.org/D100977

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D97786: LLDB: Use path relative to binary, not relative to debugger CWD, for finding .dwo files.

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

This broke the windows LLDB bot. Please fix it soon or revert.

https://lab.llvm.org/buildbot/#/builders/83/builds/5685


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97786/new/

https://reviews.llvm.org/D97786

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D99694: Add support for getting signed ObjC tagged pointer values

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a subscriber: teemperor.
stella.stamenova added a comment.

It looks like @teemperor fixed it already!

In D99694#2671640 , @stella.stamenova 
wrote:

> The latest change (commit be0ced03 
> ) issues 
> the following warning:
>
>   /usr/bin/clang++ -DGTEST_HAS_RTTI=0 -DHAVE_ROUND -D_DEBUG -D_GNU_SOURCE 
> -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS 
> -Itools/lldb/source/Plugins/Language/ObjC 
> -I/mnt/vss/_work/2/s/lldb/source/Plugins/Language/ObjC -Itools/lldb/source 
> -I/mnt/vss/_work/2/s/lldb/include -Itools/lldb/include -Iinclude 
> -I/mnt/vss/_work/2/s/llvm/include -I/usr/include/python3.8 
> -I/mnt/vss/_work/2/s/llvm/../clang/include -Itools/lldb/../clang/include 
> -I/usr/include/libxml2 -I/mnt/vss/_work/2/s/lldb/source/. -fPIC 
> -fvisibility-inlines-hidden -Werror -Werror=date-time 
> -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter 
> -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic 
> -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough 
> -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor 
> -Wdelete-non-virtual-dtor -Wstring-conversion -fdiagnostics-color 
> -ffunction-sections -fdata-sections -Wno-deprecated-declarations 
> -Wno-unknown-pragmas -Wno-strict-aliasing -Wno-deprecated-register 
> -Wno-vla-extension -O3   -fno-exceptions -fno-rtti -UNDEBUG -std=c++14 -MD 
> -MT 
> tools/lldb/source/Plugins/Language/ObjC/CMakeFiles/lldbPluginObjCLanguage.dir/Cocoa.cpp.o
>  -MF 
> tools/lldb/source/Plugins/Language/ObjC/CMakeFiles/lldbPluginObjCLanguage.dir/Cocoa.cpp.o.d
>  -o 
> tools/lldb/source/Plugins/Language/ObjC/CMakeFiles/lldbPluginObjCLanguage.dir/Cocoa.cpp.o
>  -c /mnt/vss/_work/2/s/lldb/source/Plugins/Language/ObjC/Cocoa.cpp
>   /mnt/vss/_work/2/s/lldb/source/Plugins/Language/ObjC/Cocoa.cpp:528:11: 
> error: misleading indentation; statement is not part of the previous 'if' 
> [-Werror,-Wmisleading-indentation]
> return false;
> ^
>   /mnt/vss/_work/2/s/lldb/source/Plugins/Language/ObjC/Cocoa.cpp:525:9: note: 
> previous statement is here
>   if (log) 
>
> For this badly indented code:
>
>   if (is_preserved_number) {
>   if (log) 
> log->Printf("Unsupported preserved NSNumber tagged pointer 0x%" 
> PRIu64, valobj_addr);
> return false;
>   }




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99694/new/

https://reviews.llvm.org/D99694

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D99694: Add support for getting signed ObjC tagged pointer values

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

The latest change (commit be0ced03 
) issues 
the following warning:

  /usr/bin/clang++ -DGTEST_HAS_RTTI=0 -DHAVE_ROUND -D_DEBUG -D_GNU_SOURCE 
-D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS 
-Itools/lldb/source/Plugins/Language/ObjC 
-I/mnt/vss/_work/2/s/lldb/source/Plugins/Language/ObjC -Itools/lldb/source 
-I/mnt/vss/_work/2/s/lldb/include -Itools/lldb/include -Iinclude 
-I/mnt/vss/_work/2/s/llvm/include -I/usr/include/python3.8 
-I/mnt/vss/_work/2/s/llvm/../clang/include -Itools/lldb/../clang/include 
-I/usr/include/libxml2 -I/mnt/vss/_work/2/s/lldb/source/. -fPIC 
-fvisibility-inlines-hidden -Werror -Werror=date-time 
-Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter 
-Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic 
-Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough 
-Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor 
-Wdelete-non-virtual-dtor -Wstring-conversion -fdiagnostics-color 
-ffunction-sections -fdata-sections -Wno-deprecated-declarations 
-Wno-unknown-pragmas -Wno-strict-aliasing -Wno-deprecated-register 
-Wno-vla-extension -O3   -fno-exceptions -fno-rtti -UNDEBUG -std=c++14 -MD -MT 
tools/lldb/source/Plugins/Language/ObjC/CMakeFiles/lldbPluginObjCLanguage.dir/Cocoa.cpp.o
 -MF 
tools/lldb/source/Plugins/Language/ObjC/CMakeFiles/lldbPluginObjCLanguage.dir/Cocoa.cpp.o.d
 -o 
tools/lldb/source/Plugins/Language/ObjC/CMakeFiles/lldbPluginObjCLanguage.dir/Cocoa.cpp.o
 -c /mnt/vss/_work/2/s/lldb/source/Plugins/Language/ObjC/Cocoa.cpp
  /mnt/vss/_work/2/s/lldb/source/Plugins/Language/ObjC/Cocoa.cpp:528:11: error: 
misleading indentation; statement is not part of the previous 'if' 
[-Werror,-Wmisleading-indentation]
return false;
^
  /mnt/vss/_work/2/s/lldb/source/Plugins/Language/ObjC/Cocoa.cpp:525:9: note: 
previous statement is here
  if (log) 

For this badly indented code:

  if (is_preserved_number) {
  if (log) 
log->Printf("Unsupported preserved NSNumber tagged pointer 0x%" 
PRIu64, valobj_addr);
return false;
  }


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99694/new/

https://reviews.llvm.org/D99694

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D98482: [lldb] [server] Support for multiprocess extension

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

Looks like this broke the Windows lldb buildbot:

https://lab.llvm.org/buildbot/#/builders/83/builds/5173


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98482/new/

https://reviews.llvm.org/D98482

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added inline comments.



Comment at: lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp:69
+
+  StructuredData::ObjectSP object_sp = GetInterface().CreatePluginObject(
+  m_launch_info.GetClassName().c_str(), target_sp,

This is where the AV happens on Windows. It looks like GetInterface returns null


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95713/new/

https://reviews.llvm.org/D95713

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

In D95713#2647548 , @teemperor wrote:

> The tests are failing because Dave's bot is running without enabled Python. 
> The same is true for the Windows bot. Putting the plugin behind `#ifdef 
> LLDB_ENABLE_PYTHON` should fix this.

The windows bot actually has LLDB_ENABLE_PYTHON set to true, so the failure has 
a different root cause. The error it is reporting is access violation. I'll get 
@mib some logs to investigate when I get a chance.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95713/new/

https://reviews.llvm.org/D95713

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added inline comments.



Comment at: lldb/bindings/python/CMakeLists.txt:114
 
+  create_python_package(
+${swig_target}

How is this different than the package on line 107?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95713/new/

https://reviews.llvm.org/D95713

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D98842: [lldb] Make the api, shell and unit tests independent lit test suites

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

This did end up breaking the windows build bot...

https://lab.llvm.org/buildbot/#/builders/83/builds/4808


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98842/new/

https://reviews.llvm.org/D98842

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D98842: [lldb] Make the api, shell and unit tests independent lit test suites

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

In D98842#2634902 , @teemperor wrote:

> Just gonna post a comment to point out that this apparently adds all tests 
> twice to `check-all` which makes the tests go kaputt (but I only messaged 
> Jonas directly about that, hence the lack of detailed errors here).

Oh, I have a vague recollection of this happening when he tried to split the 
targets before.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98842/new/

https://reviews.llvm.org/D98842

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D98842: [lldb] Make the api, shell and unit tests independent lit test suites

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova accepted this revision.
stella.stamenova added a comment.
This revision is now accepted and ready to land.

Looks good as long as it doesn't break windows :O


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98842/new/

https://reviews.llvm.org/D98842

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D98749: [lldb] [test] Fix TestGdbRemote_vContThreads.py logic

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.
Herald added a subscriber: JDevlieghere.

This broke the windows bot:

https://lab.llvm.org/buildbot/#/builders/83/builds/4725


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98749/new/

https://reviews.llvm.org/D98749

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D97586: [mlir][lldb] Fix several gcc warnings in mlir and lldb

[Stella Stamenova via Phabricator via lldb-commits]

This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG801067f4c09b: [mlir][lldb] Fix several gcc warnings in mlir 
and lldb (authored by stella.stamenova).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97586/new/

https://reviews.llvm.org/D97586

Files:
  lldb/source/Commands/CommandObjectTrace.cpp
  mlir/lib/Conversion/VectorToSPIRV/VectorToSPIRV.cpp
  mlir/tools/mlir-linalg-ods-gen/mlir-linalg-ods-yaml-gen.cpp


Index: mlir/tools/mlir-linalg-ods-gen/mlir-linalg-ods-yaml-gen.cpp
===
--- mlir/tools/mlir-linalg-ods-gen/mlir-linalg-ods-yaml-gen.cpp
+++ mlir/tools/mlir-linalg-ods-gen/mlir-linalg-ods-yaml-gen.cpp
@@ -129,12 +129,12 @@
 // Mapping traits.
 
//===--===//
 
-LLVM_YAML_IS_SEQUENCE_VECTOR(LinalgTensorDef);
-LLVM_YAML_IS_SEQUENCE_VECTOR(SerializedAffineMap);
-LLVM_YAML_IS_SEQUENCE_VECTOR(LinalgIteratorTypeDef);
-LLVM_YAML_IS_SEQUENCE_VECTOR(ScalarAssign);
-LLVM_YAML_IS_SEQUENCE_VECTOR(ScalarExpression);
-LLVM_YAML_IS_DOCUMENT_LIST_VECTOR(LinalgOpConfig);
+LLVM_YAML_IS_SEQUENCE_VECTOR(LinalgTensorDef)
+LLVM_YAML_IS_SEQUENCE_VECTOR(SerializedAffineMap)
+LLVM_YAML_IS_SEQUENCE_VECTOR(LinalgIteratorTypeDef)
+LLVM_YAML_IS_SEQUENCE_VECTOR(ScalarAssign)
+LLVM_YAML_IS_SEQUENCE_VECTOR(ScalarExpression)
+LLVM_YAML_IS_DOCUMENT_LIST_VECTOR(LinalgOpConfig)
 
 namespace llvm {
 namespace yaml {
Index: mlir/lib/Conversion/VectorToSPIRV/VectorToSPIRV.cpp
===
--- mlir/lib/Conversion/VectorToSPIRV/VectorToSPIRV.cpp
+++ mlir/lib/Conversion/VectorToSPIRV/VectorToSPIRV.cpp
@@ -27,7 +27,7 @@
 /// attribute.
 static uint64_t getFirstIntValue(ArrayAttr attr) {
   return (*attr.getAsValueRange().begin()).getZExtValue();
-};
+}
 
 namespace {
 
Index: lldb/source/Commands/CommandObjectTrace.cpp
===
--- lldb/source/Commands/CommandObjectTrace.cpp
+++ lldb/source/Commands/CommandObjectTrace.cpp
@@ -116,7 +116,7 @@
 Trace::FindPlugin(GetDebugger(), *session_file,
   json_file.GetDirectory().AsCString())) {
   lldb::TraceSP trace_sp = traceOrErr.get();
-  if (m_options.m_verbose)
+  if (m_options.m_verbose && trace_sp)
 result.AppendMessageWithFormat("loading trace with plugin %s\n",
trace_sp->GetPluginName().AsCString());
 } else


Index: mlir/tools/mlir-linalg-ods-gen/mlir-linalg-ods-yaml-gen.cpp
===
--- mlir/tools/mlir-linalg-ods-gen/mlir-linalg-ods-yaml-gen.cpp
+++ mlir/tools/mlir-linalg-ods-gen/mlir-linalg-ods-yaml-gen.cpp
@@ -129,12 +129,12 @@
 // Mapping traits.
 //===--===//
 
-LLVM_YAML_IS_SEQUENCE_VECTOR(LinalgTensorDef);
-LLVM_YAML_IS_SEQUENCE_VECTOR(SerializedAffineMap);
-LLVM_YAML_IS_SEQUENCE_VECTOR(LinalgIteratorTypeDef);
-LLVM_YAML_IS_SEQUENCE_VECTOR(ScalarAssign);
-LLVM_YAML_IS_SEQUENCE_VECTOR(ScalarExpression);
-LLVM_YAML_IS_DOCUMENT_LIST_VECTOR(LinalgOpConfig);
+LLVM_YAML_IS_SEQUENCE_VECTOR(LinalgTensorDef)
+LLVM_YAML_IS_SEQUENCE_VECTOR(SerializedAffineMap)
+LLVM_YAML_IS_SEQUENCE_VECTOR(LinalgIteratorTypeDef)
+LLVM_YAML_IS_SEQUENCE_VECTOR(ScalarAssign)
+LLVM_YAML_IS_SEQUENCE_VECTOR(ScalarExpression)
+LLVM_YAML_IS_DOCUMENT_LIST_VECTOR(LinalgOpConfig)
 
 namespace llvm {
 namespace yaml {
Index: mlir/lib/Conversion/VectorToSPIRV/VectorToSPIRV.cpp
===
--- mlir/lib/Conversion/VectorToSPIRV/VectorToSPIRV.cpp
+++ mlir/lib/Conversion/VectorToSPIRV/VectorToSPIRV.cpp
@@ -27,7 +27,7 @@
 /// attribute.
 static uint64_t getFirstIntValue(ArrayAttr attr) {
   return (*attr.getAsValueRange().begin()).getZExtValue();
-};
+}
 
 namespace {
 
Index: lldb/source/Commands/CommandObjectTrace.cpp
===
--- lldb/source/Commands/CommandObjectTrace.cpp
+++ lldb/source/Commands/CommandObjectTrace.cpp
@@ -116,7 +116,7 @@
 Trace::FindPlugin(GetDebugger(), *session_file,
   json_file.GetDirectory().AsCString())) {
   lldb::TraceSP trace_sp = traceOrErr.get();
-  if (m_options.m_verbose)
+  if (m_options.m_verbose && trace_sp)
 result.AppendMessageWithFormat("loading trace with plugin %s\n",
trace_sp->GetPluginName().AsCString());
 } else
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D97586: [mlir][lldb] Fix several gcc warnings in mlir and lldb

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added inline comments.



Comment at: lldb/source/Commands/CommandObjectTrace.cpp:119
   lldb::TraceSP trace_sp = traceOrErr.get();
-  if (m_options.m_verbose)
+  if (m_options.m_verbose && trace_sp)
 result.AppendMessageWithFormat("loading trace with plugin %s\n",

teemperor wrote:
> Do you still have that GCC warning around (or the GCC version that produced 
> that warning)? I'm kinda curious what GCC is assuming here. The interface 
> never returns a "null" shared_ptr, the shared_ptr either contains a valid 
> object or llvm::Error is returned. IIRC the Expected return is the "new" 
> version of how the Plugin interface should work (the old was just a ptr with 
> `nullptr` being an error), so if some GCC version doesn't understand the 
> Expected pattern then we should maybe have some more centralized 
> workaround instead of adding all the unnecessary nullptr checks.
> 
> But that shouldn't block this patch, so feel free to land.
The gcc version is:

`gcc (Ubuntu 9.3.0-17ubuntu1~20.04) 9.3.0`

The warning is:

```
/mnt/_work/9/s/llvm-project/lldb/source/Commands/CommandObjectTrace.cpp: In 
member function ‘virtual bool 
CommandObjectTraceLoad::DoExecute(lldb_private::Args&, 
lldb_private::CommandReturnObject&)’:
/mnt/_work/9/s/llvm-project/lldb/source/Commands/CommandObjectTrace.cpp:120:39: 
error: ‘%s’ directive argument is null [-Werror=format-overflow=]
  120 | result.AppendMessageWithFormat("loading trace with plugin %s\n",
  | ~~^~
  121 |
trace_sp->GetPluginName().AsCString());
  |
~~
/mnt/_work/9/s/llvm-project/lldb/source/Commands/CommandObjectTrace.cpp:120:39: 
error: ‘%s’ directive argument is null [-Werror=format-overflow=]
```

Interestingly, this is the only place in all of llvm (well, llvm, lld, clang 
and lldb) that produces this warning.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97586/new/

https://reviews.llvm.org/D97586

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D95711: [lldb/Interpreter] Add ScriptInterpreter Wrapper for ScriptedProcess

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

In D95711#2595566 , @mib wrote:

> In D95711#2595458 , 
> @stella.stamenova wrote:
>
>> This does not build on the Windows bot:
>>
>> https://lab.llvm.org/buildbot/#/builders/83/builds/4214
>
> Should be fixed with 5a9c34918bb1526b7e8c29aa5e4fb8d8e27e27b4 
>  ... I'm 
> also investigating some test failures that are happening on Linux, that will 
> also probably happen on Windows. I should have a fix for that soon.

Are these the same failures?

https://lab.llvm.org/buildbot/#/builders/83/builds/4217


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95711/new/

https://reviews.llvm.org/D95711

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D95711: [lldb/Interpreter] Add ScriptInterpreter Wrapper for ScriptedProcess

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

This does not build on the Windows bot:

https://lab.llvm.org/buildbot/#/builders/83/builds/4214


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95711/new/

https://reviews.llvm.org/D95711

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D96778: [lldb] Fix handling of `DW_AT_decl_file` according to D91014

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

In D96778#2595162 , @jankratochvil 
wrote:

> In D96778#2595110 , 
> @stella.stamenova wrote:
>
>> What is the actual test requirement?
>
> It requires x86_64 (it is incompatible with x86_32) and hopefully it is 
> OS-agnostic (after fixing the %clang_host).

It sounds like the statement should be either:

`REQUIRES: x86_64-linux`

or:

`REQUIRES: target-x86_64`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96778/new/

https://reviews.llvm.org/D96778

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D96778: [lldb] Fix handling of `DW_AT_decl_file` according to D91014

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

Considering this broke two bots, you might want to commit a fix or revert soon.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96778/new/

https://reviews.llvm.org/D96778

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D96778: [lldb] Fix handling of `DW_AT_decl_file` according to D91014

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

In D96778#2594405 , @jankratochvil 
wrote:

> @stella.stamenova It failed on a Windows box:
> https://lab.llvm.org/buildbot/#/builders/83/builds/4202
>
>   $ "c:\buildbot\lldb-x64-windows-ninja\build\bin\clang.exe" 
> "--target=specify-a-target-or-use-a-_host-substitution" "-o" 
> "C:\buildbot\lldb-x64-windows-ninja\build\tools\lldb\test\SymbolFile\DWARF\Output\DW_TAG_variable-DW_AT_decl_file-DW_AT_abstract_origin-crosscu1.s.tmp"
>  "--target=x86_64-pc-linux" 
> "C:\buildbot\lldb-x64-windows-ninja\llvm-project\lldb\test\Shell\SymbolFile\DWARF\DW_TAG_variable-DW_AT_decl_file-DW_AT_abstract_origin-crosscu1.s"
>  
> "C:\buildbot\lldb-x64-windows-ninja\llvm-project\lldb\test\Shell\SymbolFile\DWARF/Inputs/DW_TAG_variable-DW_AT_decl_file-DW_AT_abstract_origin-crosscu2.s"
>   # command stderr:
>   clang: error: unable to execute command: program not executable
>
> Do you think the following change would fix it?
>
>   -// RUN: %clang -o %t --target=x86_64-pc-linux %s \
>   +// RUN: %clang_host -o %t %s \

Yes, I would expect it to.

> The test was also executed on lldb-aarch64-ubuntu -- 
> https://lab.llvm.org/buildbot/#/changes/13868
> But we have REQUIRES: x86, shouldn't it exclude ARM?

My understanding it that `REQUIRES` indicates a target that should be included 
in the build. This particular buildbot includes the X86 target, so the test 
ran. What is the actual test requirement?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96778/new/

https://reviews.llvm.org/D96778

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D97586: [mlir][lldb] Fix several gcc warnings in mlir and lldb

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova created this revision.
Herald added subscribers: cota, teijeong, rdzhabarov, tatianashp, ThomasRaoux, 
AlexeySotkin, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, 
aartbik, lucyrfox, mgester, arpith-jacob, antiagainst, shauheen, rriddle, 
mehdi_amini.
Herald added a reviewer: mravishankar.
Herald added a reviewer: antiagainst.
Herald added a reviewer: aartbik.
stella.stamenova requested review of this revision.
Herald added subscribers: lldb-commits, stephenneuendorffer, nicolasvasilache.
Herald added projects: LLDB, MLIR.

These warnings are raised when compiling with gcc due to either having too few 
or too many commas, or in the case of lldb, the possibility of a nullptr.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D97586

Files:
  lldb/source/Commands/CommandObjectTrace.cpp
  mlir/lib/Conversion/VectorToSPIRV/VectorToSPIRV.cpp
  mlir/tools/mlir-linalg-ods-gen/mlir-linalg-ods-yaml-gen.cpp


Index: mlir/tools/mlir-linalg-ods-gen/mlir-linalg-ods-yaml-gen.cpp
===
--- mlir/tools/mlir-linalg-ods-gen/mlir-linalg-ods-yaml-gen.cpp
+++ mlir/tools/mlir-linalg-ods-gen/mlir-linalg-ods-yaml-gen.cpp
@@ -119,12 +119,12 @@
 // Mapping traits.
 
//===--===//
 
-LLVM_YAML_IS_SEQUENCE_VECTOR(LinalgTensorDef);
-LLVM_YAML_IS_SEQUENCE_VECTOR(SerializedAffineMap);
-LLVM_YAML_IS_SEQUENCE_VECTOR(LinalgIteratorTypeDef);
-LLVM_YAML_IS_SEQUENCE_VECTOR(ScalarAssign);
-LLVM_YAML_IS_SEQUENCE_VECTOR(ScalarExpression);
-LLVM_YAML_IS_DOCUMENT_LIST_VECTOR(LinalgOpConfig);
+LLVM_YAML_IS_SEQUENCE_VECTOR(LinalgTensorDef)
+LLVM_YAML_IS_SEQUENCE_VECTOR(SerializedAffineMap)
+LLVM_YAML_IS_SEQUENCE_VECTOR(LinalgIteratorTypeDef)
+LLVM_YAML_IS_SEQUENCE_VECTOR(ScalarAssign)
+LLVM_YAML_IS_SEQUENCE_VECTOR(ScalarExpression)
+LLVM_YAML_IS_DOCUMENT_LIST_VECTOR(LinalgOpConfig)
 
 namespace llvm {
 namespace yaml {
Index: mlir/lib/Conversion/VectorToSPIRV/VectorToSPIRV.cpp
===
--- mlir/lib/Conversion/VectorToSPIRV/VectorToSPIRV.cpp
+++ mlir/lib/Conversion/VectorToSPIRV/VectorToSPIRV.cpp
@@ -27,7 +27,7 @@
 /// attribute.
 static uint64_t getFirstIntValue(ArrayAttr attr) {
   return (*attr.getAsValueRange().begin()).getZExtValue();
-};
+}
 
 namespace {
 
Index: lldb/source/Commands/CommandObjectTrace.cpp
===
--- lldb/source/Commands/CommandObjectTrace.cpp
+++ lldb/source/Commands/CommandObjectTrace.cpp
@@ -116,7 +116,7 @@
 Trace::FindPlugin(GetDebugger(), *session_file,
   json_file.GetDirectory().AsCString())) {
   lldb::TraceSP trace_sp = traceOrErr.get();
-  if (m_options.m_verbose)
+  if (m_options.m_verbose && trace_sp)
 result.AppendMessageWithFormat("loading trace with plugin %s\n",
trace_sp->GetPluginName().AsCString());
 } else


Index: mlir/tools/mlir-linalg-ods-gen/mlir-linalg-ods-yaml-gen.cpp
===
--- mlir/tools/mlir-linalg-ods-gen/mlir-linalg-ods-yaml-gen.cpp
+++ mlir/tools/mlir-linalg-ods-gen/mlir-linalg-ods-yaml-gen.cpp
@@ -119,12 +119,12 @@
 // Mapping traits.
 //===--===//
 
-LLVM_YAML_IS_SEQUENCE_VECTOR(LinalgTensorDef);
-LLVM_YAML_IS_SEQUENCE_VECTOR(SerializedAffineMap);
-LLVM_YAML_IS_SEQUENCE_VECTOR(LinalgIteratorTypeDef);
-LLVM_YAML_IS_SEQUENCE_VECTOR(ScalarAssign);
-LLVM_YAML_IS_SEQUENCE_VECTOR(ScalarExpression);
-LLVM_YAML_IS_DOCUMENT_LIST_VECTOR(LinalgOpConfig);
+LLVM_YAML_IS_SEQUENCE_VECTOR(LinalgTensorDef)
+LLVM_YAML_IS_SEQUENCE_VECTOR(SerializedAffineMap)
+LLVM_YAML_IS_SEQUENCE_VECTOR(LinalgIteratorTypeDef)
+LLVM_YAML_IS_SEQUENCE_VECTOR(ScalarAssign)
+LLVM_YAML_IS_SEQUENCE_VECTOR(ScalarExpression)
+LLVM_YAML_IS_DOCUMENT_LIST_VECTOR(LinalgOpConfig)
 
 namespace llvm {
 namespace yaml {
Index: mlir/lib/Conversion/VectorToSPIRV/VectorToSPIRV.cpp
===
--- mlir/lib/Conversion/VectorToSPIRV/VectorToSPIRV.cpp
+++ mlir/lib/Conversion/VectorToSPIRV/VectorToSPIRV.cpp
@@ -27,7 +27,7 @@
 /// attribute.
 static uint64_t getFirstIntValue(ArrayAttr attr) {
   return (*attr.getAsValueRange().begin()).getZExtValue();
-};
+}
 
 namespace {
 
Index: lldb/source/Commands/CommandObjectTrace.cpp
===
--- lldb/source/Commands/CommandObjectTrace.cpp
+++ lldb/source/Commands/CommandObjectTrace.cpp
@@ -116,7 +116,7 @@
 Trace::FindPlugin(GetDebugger(), *session_file,
   json_file.GetDirectory().AsCString())) {
   lldb::TraceSP trace_sp = traceOrErr.get();
-  if (m_options.m_verbose)
+  if (m_options.m_verbose && trace_sp)
 result.AppendMe

[Lldb-commits] [PATCH] D96779: [lldb] Fix shared library directory computation on windows

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova accepted this revision.
stella.stamenova added a comment.

LGTM.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96779/new/

https://reviews.llvm.org/D96779

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D96427: Support multi-configuration generators correctly in several config files

[Stella Stamenova via Phabricator via lldb-commits]

This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGed98676fa483: Support multi-configuration generators 
correctly in several config files (authored by stella.stamenova).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96427/new/

https://reviews.llvm.org/D96427

Files:
  clang/test/Unit/lit.site.cfg.py.in
  lld/test/CMakeLists.txt
  lld/test/Unit/lit.site.cfg.py.in
  lld/test/lit.site.cfg.py.in
  lldb/test/API/lit.site.cfg.py.in
  llvm/cmake/modules/AddLLVM.cmake
  llvm/test/CMakeLists.txt
  llvm/test/Unit/lit.site.cfg.py.in
  llvm/test/lit.site.cfg.py.in
  mlir/examples/standalone/test/lit.site.cfg.py.in
  mlir/integration_test/lit.site.cfg.py.in
  mlir/test/Unit/lit.site.cfg.py.in
  mlir/test/lit.site.cfg.py.in

Index: mlir/test/lit.site.cfg.py.in
===
--- mlir/test/lit.site.cfg.py.in
+++ mlir/test/lit.site.cfg.py.in
@@ -7,7 +7,7 @@
 config.llvm_src_root = "@LLVM_SOURCE_DIR@"
 config.llvm_obj_root = "@LLVM_BINARY_DIR@"
 config.llvm_tools_dir = "@LLVM_TOOLS_DIR@"
-config.llvm_lib_dir = "@LLVM_LIBRARY_DIR@"
+config.llvm_lib_dir = "@LLVM_LIBS_DIR@"
 config.llvm_shlib_dir = "@SHLIBDIR@"
 config.llvm_shlib_ext = "@SHLIBEXT@"
 config.llvm_exe_ext = "@EXEEXT@"
@@ -51,6 +51,7 @@
 # used when we can't determine the tool dir at configuration time.
 try:
 config.llvm_tools_dir = config.llvm_tools_dir % lit_config.params
+config.llvm_lib_dir = config.llvm_lib_dir % lit_config.params
 config.llvm_shlib_dir = config.llvm_shlib_dir % lit_config.params
 except KeyError:
 e = sys.exc_info()[1]
Index: mlir/test/Unit/lit.site.cfg.py.in
===
--- mlir/test/Unit/lit.site.cfg.py.in
+++ mlir/test/Unit/lit.site.cfg.py.in
@@ -17,6 +17,7 @@
 try:
 config.llvm_tools_dir = config.llvm_tools_dir % lit_config.params
 config.llvm_build_mode = config.llvm_build_mode % lit_config.params
+config.shlibdir = config.shlibdir % lit_config.params
 except KeyError:
 e = sys.exc_info()[1]
 key, = e.args
Index: mlir/integration_test/lit.site.cfg.py.in
===
--- mlir/integration_test/lit.site.cfg.py.in
+++ mlir/integration_test/lit.site.cfg.py.in
@@ -7,7 +7,7 @@
 config.llvm_src_root = "@LLVM_SOURCE_DIR@"
 config.llvm_obj_root = "@LLVM_BINARY_DIR@"
 config.llvm_tools_dir = "@LLVM_TOOLS_DIR@"
-config.llvm_lib_dir = "@LLVM_LIBRARY_DIR@"
+config.llvm_lib_dir = "@LLVM_LIBS_DIR@"
 config.llvm_shlib_dir = "@SHLIBDIR@"
 config.llvm_shlib_ext = "@SHLIBEXT@"
 config.llvm_exe_ext = "@EXEEXT@"
@@ -40,6 +40,7 @@
 # used when we can't determine the tool dir at configuration time.
 try:
 config.llvm_tools_dir = config.llvm_tools_dir % lit_config.params
+config.llvm_lib_dir = config.llvm_lib_dir % lit_config.params
 config.llvm_shlib_dir = config.llvm_shlib_dir % lit_config.params
 except KeyError:
 e = sys.exc_info()[1]
Index: mlir/examples/standalone/test/lit.site.cfg.py.in
===
--- mlir/examples/standalone/test/lit.site.cfg.py.in
+++ mlir/examples/standalone/test/lit.site.cfg.py.in
@@ -7,7 +7,7 @@
 config.llvm_src_root = "@LLVM_SOURCE_DIR@"
 config.llvm_obj_root = "@LLVM_BINARY_DIR@"
 config.llvm_tools_dir = "@LLVM_TOOLS_DIR@"
-config.llvm_lib_dir = "@LLVM_LIBRARY_DIR@"
+config.llvm_lib_dir = "@LLVM_LIBS_DIR@"
 config.llvm_shlib_dir = "@SHLIBDIR@"
 config.llvm_shlib_ext = "@SHLIBEXT@"
 config.llvm_exe_ext = "@EXEEXT@"
@@ -35,6 +35,7 @@
 # used when we can't determine the tool dir at configuration time.
 try:
 config.llvm_tools_dir = config.llvm_tools_dir % lit_config.params
+config.llvm_lib_dir = config.llvm_lib_dir % lit_config.params
 config.llvm_shlib_dir = config.llvm_shlib_dir % lit_config.params
 except KeyError:
 e = sys.exc_info()[1]
Index: llvm/test/lit.site.cfg.py.in
===
--- llvm/test/lit.site.cfg.py.in
+++ llvm/test/lit.site.cfg.py.in
@@ -7,7 +7,7 @@
 config.llvm_src_root = path(r"@LLVM_SOURCE_DIR@")
 config.llvm_obj_root = path(r"@LLVM_BINARY_DIR@")
 config.llvm_tools_dir = path(r"@LLVM_TOOLS_DIR@")
-config.llvm_lib_dir = path(r"@LLVM_LIBRARY_DIR@")
+config.llvm_lib_dir = path(r"@LLVM_LIBS_DIR@")
 config.llvm_shlib_dir = path(r"@SHLIBDIR@")
 config.llvm_shlib_ext = "@SHLIBEXT@"
 config.llvm_exe_ext = "@EXEEXT@"
@@ -56,6 +56,7 @@
 # used when we can't determine the tool dir at configuration time.
 try:
 config.llvm_tools_dir = config.llvm_tools_dir % lit_config.params
+config.llvm_lib_dir = config.llvm_lib_dir % lit_config.params
 config.llvm_shlib_dir = config.llvm_shlib_dir % lit_config.params
 except KeyError:
 e = sys.exc_info()[1]
Index: llvm/test/Unit/lit.site.cfg.py.in
===

[Lldb-commits] [PATCH] D96427: Support multi-configuration generators correctly in several config files

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova updated this revision to Diff 323053.
stella.stamenova edited the summary of this revision.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96427/new/

https://reviews.llvm.org/D96427

Files:
  clang/test/Unit/lit.site.cfg.py.in
  lld/test/CMakeLists.txt
  lld/test/Unit/lit.site.cfg.py.in
  lld/test/lit.site.cfg.py.in
  lldb/test/API/lit.site.cfg.py.in
  llvm/cmake/modules/AddLLVM.cmake
  llvm/test/CMakeLists.txt
  llvm/test/Unit/lit.site.cfg.py.in
  llvm/test/lit.site.cfg.py.in
  mlir/examples/standalone/test/lit.site.cfg.py.in
  mlir/integration_test/lit.site.cfg.py.in
  mlir/test/Unit/lit.site.cfg.py.in
  mlir/test/lit.site.cfg.py.in

Index: mlir/test/lit.site.cfg.py.in
===
--- mlir/test/lit.site.cfg.py.in
+++ mlir/test/lit.site.cfg.py.in
@@ -7,7 +7,7 @@
 config.llvm_src_root = "@LLVM_SOURCE_DIR@"
 config.llvm_obj_root = "@LLVM_BINARY_DIR@"
 config.llvm_tools_dir = "@LLVM_TOOLS_DIR@"
-config.llvm_lib_dir = "@LLVM_LIBRARY_DIR@"
+config.llvm_lib_dir = "@LLVM_LIBS_DIR@"
 config.llvm_shlib_dir = "@SHLIBDIR@"
 config.llvm_shlib_ext = "@SHLIBEXT@"
 config.llvm_exe_ext = "@EXEEXT@"
@@ -51,6 +51,7 @@
 # used when we can't determine the tool dir at configuration time.
 try:
 config.llvm_tools_dir = config.llvm_tools_dir % lit_config.params
+config.llvm_lib_dir = config.llvm_lib_dir % lit_config.params
 config.llvm_shlib_dir = config.llvm_shlib_dir % lit_config.params
 except KeyError:
 e = sys.exc_info()[1]
Index: mlir/test/Unit/lit.site.cfg.py.in
===
--- mlir/test/Unit/lit.site.cfg.py.in
+++ mlir/test/Unit/lit.site.cfg.py.in
@@ -17,6 +17,7 @@
 try:
 config.llvm_tools_dir = config.llvm_tools_dir % lit_config.params
 config.llvm_build_mode = config.llvm_build_mode % lit_config.params
+config.shlibdir = config.shlibdir % lit_config.params
 except KeyError:
 e = sys.exc_info()[1]
 key, = e.args
Index: mlir/integration_test/lit.site.cfg.py.in
===
--- mlir/integration_test/lit.site.cfg.py.in
+++ mlir/integration_test/lit.site.cfg.py.in
@@ -7,7 +7,7 @@
 config.llvm_src_root = "@LLVM_SOURCE_DIR@"
 config.llvm_obj_root = "@LLVM_BINARY_DIR@"
 config.llvm_tools_dir = "@LLVM_TOOLS_DIR@"
-config.llvm_lib_dir = "@LLVM_LIBRARY_DIR@"
+config.llvm_lib_dir = "@LLVM_LIBS_DIR@"
 config.llvm_shlib_dir = "@SHLIBDIR@"
 config.llvm_shlib_ext = "@SHLIBEXT@"
 config.llvm_exe_ext = "@EXEEXT@"
@@ -40,6 +40,7 @@
 # used when we can't determine the tool dir at configuration time.
 try:
 config.llvm_tools_dir = config.llvm_tools_dir % lit_config.params
+config.llvm_lib_dir = config.llvm_lib_dir % lit_config.params
 config.llvm_shlib_dir = config.llvm_shlib_dir % lit_config.params
 except KeyError:
 e = sys.exc_info()[1]
Index: mlir/examples/standalone/test/lit.site.cfg.py.in
===
--- mlir/examples/standalone/test/lit.site.cfg.py.in
+++ mlir/examples/standalone/test/lit.site.cfg.py.in
@@ -7,7 +7,7 @@
 config.llvm_src_root = "@LLVM_SOURCE_DIR@"
 config.llvm_obj_root = "@LLVM_BINARY_DIR@"
 config.llvm_tools_dir = "@LLVM_TOOLS_DIR@"
-config.llvm_lib_dir = "@LLVM_LIBRARY_DIR@"
+config.llvm_lib_dir = "@LLVM_LIBS_DIR@"
 config.llvm_shlib_dir = "@SHLIBDIR@"
 config.llvm_shlib_ext = "@SHLIBEXT@"
 config.llvm_exe_ext = "@EXEEXT@"
@@ -35,6 +35,7 @@
 # used when we can't determine the tool dir at configuration time.
 try:
 config.llvm_tools_dir = config.llvm_tools_dir % lit_config.params
+config.llvm_lib_dir = config.llvm_lib_dir % lit_config.params
 config.llvm_shlib_dir = config.llvm_shlib_dir % lit_config.params
 except KeyError:
 e = sys.exc_info()[1]
Index: llvm/test/lit.site.cfg.py.in
===
--- llvm/test/lit.site.cfg.py.in
+++ llvm/test/lit.site.cfg.py.in
@@ -7,7 +7,7 @@
 config.llvm_src_root = path(r"@LLVM_SOURCE_DIR@")
 config.llvm_obj_root = path(r"@LLVM_BINARY_DIR@")
 config.llvm_tools_dir = path(r"@LLVM_TOOLS_DIR@")
-config.llvm_lib_dir = path(r"@LLVM_LIBRARY_DIR@")
+config.llvm_lib_dir = path(r"@LLVM_LIBS_DIR@")
 config.llvm_shlib_dir = path(r"@SHLIBDIR@")
 config.llvm_shlib_ext = "@SHLIBEXT@"
 config.llvm_exe_ext = "@EXEEXT@"
@@ -56,6 +56,7 @@
 # used when we can't determine the tool dir at configuration time.
 try:
 config.llvm_tools_dir = config.llvm_tools_dir % lit_config.params
+config.llvm_lib_dir = config.llvm_lib_dir % lit_config.params
 config.llvm_shlib_dir = config.llvm_shlib_dir % lit_config.params
 except KeyError:
 e = sys.exc_info()[1]
Index: llvm/test/Unit/lit.site.cfg.py.in
===
--- llvm/test/Unit/lit.site.cfg.py.in
+++ llvm/test/Unit/lit.site.cfg.py.in
@@ -14,6 +14,7 @@
 try:
 config.llvm_tools_dir = co