[Lldb-commits] [PATCH] D137337: Replace LLVM_LIBDIR_SUFFIX by CMAKE_INSTALL_LIBDIR

2022-12-07 Thread Sylvestre Ledru via Phabricator via lldb-commits 
sylvestre.ledru added a comment.

Maybe add it to the release notes?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137337/new/

https://reviews.llvm.org/D137337

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D125860: [clang] Only use major version in resource dir

2022-11-03 Thread Sylvestre Ledru via Phabricator via lldb-commits 
sylvestre.ledru added a comment.

i hope not too many people rely on it.
LGTM but please add it to the release notes


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125860/new/

https://reviews.llvm.org/D125860

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D119186: [lldb][gdb-remote] Fix linking of gdb-remote when LLVM_ENABLE_ZLIB is ON

2022-02-08 Thread Sylvestre Ledru via Phabricator via lldb-commits 
sylvestre.ledru added a comment.

Log:
https://llvm-jenkins.debian.net/job/llvm-toolchain-impish-14-binaries/12/architecture=amd64,distribution=impish,label=amd64/console


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119186/new/

https://reviews.llvm.org/D119186

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D119186: [lldb][gdb-remote] Fix linking of gdb-remote when LLVM_ENABLE_ZLIB is ON

2022-02-08 Thread Sylvestre Ledru via Phabricator via lldb-commits 
sylvestre.ledru added a comment.

Debian is still broken with this patch on -14:

  
lib/liblldbPluginProcessGDBRemote.a(GDBRemoteCommunication.cpp.o):GDBRemoteCommunication.cpp:function
 lldb_private::process_gdb_remote::GDBRemoteCommunication::DecompressPacket(): 
error: undefined reference to 'inflateInit2_' 
lib/liblldbPluginProcessGDBRemote.a(GDBRemoteCommunication.cpp.o):GDBRemoteCommunication.cpp:function
 lldb_private::process_gdb_remote::GDBRemoteCommunication::DecompressPacket(): 
error: undefined reference to 'inflate' 
lib/liblldbPluginProcessGDBRemote.a(GDBRemoteCommunication.cpp.o):GDBRemoteCommunication.cpp:function
 lldb_private::process_gdb_remote::GDBRemoteCommunication::DecompressPacket(): 
error: undefined reference to 'inflateEnd'


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119186/new/

https://reviews.llvm.org/D119186

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D114722: [LLDB] Fix Python GIL-not-held issues

2022-01-19 Thread Sylvestre Ledru via Phabricator via lldb-commits 
sylvestre.ledru added a comment.

Seems that it broke apt.llvm.org on ubuntu bionic with Python 3.6:
I reported this issue: https://github.com/llvm/llvm-project/issues/53291


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114722/new/

https://reviews.llvm.org/D114722

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D115877: [lldb][docs] Update instructions for building libc++

2021-12-16 Thread Sylvestre Ledru via Phabricator via lldb-commits 
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG427f6e11e68a: [lldb][docs] Update instructions for building 
libc++ (authored by torarnv, committed by sylvestre.ledru).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115877/new/

https://reviews.llvm.org/D115877

Files:
  lldb/docs/resources/build.rst


Index: lldb/docs/resources/build.rst
===
--- lldb/docs/resources/build.rst
+++ lldb/docs/resources/build.rst
@@ -304,8 +304,8 @@
 macOS
 ^
 
-On macOS the LLDB test suite requires libc++. Either add ``libcxx`` to
-``LLVM_ENABLE_PROJECTS`` or disable the test suite with
+On macOS the LLDB test suite requires libc++. Either add
+``LLVM_ENABLE_RUNTIMES="libcxx;libcxxabi"`` or disable the test suite with
 ``LLDB_INCLUDE_TESTS=OFF``. Further useful options:
 
 * ``LLDB_BUILD_FRAMEWORK:BOOL``: Builds the LLDB.framework.
@@ -343,7 +343,8 @@
 
   $ cmake -B /path/to/lldb-build -G Ninja \
   -C /path/to/llvm-project/lldb/cmake/caches/Apple-lldb-macOS.cmake \
-  -DLLVM_ENABLE_PROJECTS="clang;libcxx;lldb" \
+  -DLLVM_ENABLE_PROJECTS="clang;lldb" \
+  -DLLVM_ENABLE_RUNTIMES="libcxx;libcxxabi" \
   llvm-project/llvm
 
   $ DESTDIR=/path/to/lldb-install ninja -C /path/to/lldb-build check-lldb 
install-distribution
@@ -358,7 +359,8 @@
 
   $ cmake -B /path/to/llvm-build -G Ninja \
   -C /path/to/llvm-project/lldb/cmake/caches/Apple-lldb-base.cmake \
-  -DLLVM_ENABLE_PROJECTS="clang;libcxx" \
+  -DLLVM_ENABLE_PROJECTS="clang" \
+  -DLLVM_ENABLE_RUNTIMES="libcxx;libcxxabi" \
   llvm-project/llvm
   $ ninja -C /path/to/llvm-build
 


Index: lldb/docs/resources/build.rst
===
--- lldb/docs/resources/build.rst
+++ lldb/docs/resources/build.rst
@@ -304,8 +304,8 @@
 macOS
 ^
 
-On macOS the LLDB test suite requires libc++. Either add ``libcxx`` to
-``LLVM_ENABLE_PROJECTS`` or disable the test suite with
+On macOS the LLDB test suite requires libc++. Either add
+``LLVM_ENABLE_RUNTIMES="libcxx;libcxxabi"`` or disable the test suite with
 ``LLDB_INCLUDE_TESTS=OFF``. Further useful options:
 
 * ``LLDB_BUILD_FRAMEWORK:BOOL``: Builds the LLDB.framework.
@@ -343,7 +343,8 @@
 
   $ cmake -B /path/to/lldb-build -G Ninja \
   -C /path/to/llvm-project/lldb/cmake/caches/Apple-lldb-macOS.cmake \
-  -DLLVM_ENABLE_PROJECTS="clang;libcxx;lldb" \
+  -DLLVM_ENABLE_PROJECTS="clang;lldb" \
+  -DLLVM_ENABLE_RUNTIMES="libcxx;libcxxabi" \
   llvm-project/llvm
 
   $ DESTDIR=/path/to/lldb-install ninja -C /path/to/lldb-build check-lldb install-distribution
@@ -358,7 +359,8 @@
 
   $ cmake -B /path/to/llvm-build -G Ninja \
   -C /path/to/llvm-project/lldb/cmake/caches/Apple-lldb-base.cmake \
-  -DLLVM_ENABLE_PROJECTS="clang;libcxx" \
+  -DLLVM_ENABLE_PROJECTS="clang" \
+  -DLLVM_ENABLE_RUNTIMES="libcxx;libcxxabi" \
   llvm-project/llvm
   $ ninja -C /path/to/llvm-build
 
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D115877: [lldb][docs] Update instructions for building libc++

2021-12-16 Thread Sylvestre Ledru via Phabricator via lldb-commits 
sylvestre.ledru added a comment.

I will push it for you. What do you want to use as full name + email ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115877/new/

https://reviews.llvm.org/D115877

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D115877: [lldb][docs] Update instructions for building libc++

2021-12-16 Thread Sylvestre Ledru via Phabricator via lldb-commits 
sylvestre.ledru accepted this revision.
sylvestre.ledru added a comment.
This revision is now accepted and ready to land.

LGTM, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115877/new/

https://reviews.llvm.org/D115877

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D102872: Fix lldb-server build failure on mips

2021-10-23 Thread Sylvestre Ledru via Phabricator via lldb-commits 
sylvestre.ledru added a comment.

> Maybe it would be better to disable the binary completely (in cmake) for 
> unsupported architectures instead?

+1, having an error message like "lldb isn't supported on arch foo" would save 
hours of work :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102872/new/

https://reviews.llvm.org/D102872

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D92759: [lldb] Introduce separate scratch ASTs for debug info types and types imported from C++ modules.

2021-01-25 Thread Sylvestre Ledru via Phabricator via lldb-commits 
sylvestre.ledru added a comment.

This change doesn't build with gcc 5.3.1.
More details: https://bugs.llvm.org/show_bug.cgi?id=48869

It would be great if you have could have a look! thanks


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92759/new/

https://reviews.llvm.org/D92759

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D78807: Fix gendered documentation

2020-10-31 Thread Sylvestre Ledru via Phabricator via lldb-commits 
This revision was automatically updated to reflect the committed changes.
Closed by commit rG43e451f9f316: Fix gendered documentation (authored by 
pedro.gonnet, committed by sylvestre.ledru).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78807/new/

https://reviews.llvm.org/D78807

Files:
  
clang-tools-extra/docs/clang-tidy/checks/google-objc-global-variable-declaration.rst
  lldb/docs/use/variable.rst


Index: lldb/docs/use/variable.rst
===
--- lldb/docs/use/variable.rst
+++ lldb/docs/use/variable.rst
@@ -993,7 +993,7 @@
 user to see.
 
 A filter will solve this issue by only letting the user see those member
-variables he cares about. Of course, the equivalent of a filter can be
+variables they care about. Of course, the equivalent of a filter can be
 implemented easily using synthetic children, but a filter lets you get the job
 done without having to write Python code.
 
Index: 
clang-tools-extra/docs/clang-tidy/checks/google-objc-global-variable-declaration.rst
===
--- 
clang-tools-extra/docs/clang-tidy/checks/google-objc-global-variable-declaration.rst
+++ 
clang-tools-extra/docs/clang-tidy/checks/google-objc-global-variable-declaration.rst
@@ -44,4 +44,4 @@
   static NSString* __anotherString = @"world";
 
 The check will give a warning message but will not be able to suggest a fix. 
The
-user need to fix it on his own.
+user needs to fix it on their own.


Index: lldb/docs/use/variable.rst
===
--- lldb/docs/use/variable.rst
+++ lldb/docs/use/variable.rst
@@ -993,7 +993,7 @@
 user to see.
 
 A filter will solve this issue by only letting the user see those member
-variables he cares about. Of course, the equivalent of a filter can be
+variables they care about. Of course, the equivalent of a filter can be
 implemented easily using synthetic children, but a filter lets you get the job
 done without having to write Python code.
 
Index: clang-tools-extra/docs/clang-tidy/checks/google-objc-global-variable-declaration.rst
===
--- clang-tools-extra/docs/clang-tidy/checks/google-objc-global-variable-declaration.rst
+++ clang-tools-extra/docs/clang-tidy/checks/google-objc-global-variable-declaration.rst
@@ -44,4 +44,4 @@
   static NSString* __anotherString = @"world";
 
 The check will give a warning message but will not be able to suggest a fix. The
-user need to fix it on his own.
+user needs to fix it on their own.
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D89859: Remove .svn from exclude list as we moved to git

2020-10-21 Thread Sylvestre Ledru via Phabricator via lldb-commits 
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG0784e17f1b4a: Remove .svn from exclude list as we moved to 
git (authored by sylvestre.ledru).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89859/new/

https://reviews.llvm.org/D89859

Files:
  clang/CMakeLists.txt
  clang/tools/libclang/CMakeLists.txt
  lld/CMakeLists.txt
  lldb/cmake/modules/LLDBConfig.cmake
  llvm/CMakeLists.txt
  llvm/cmake/modules/CMakeLists.txt
  polly/CMakeLists.txt
  polly/lib/External/CMakeLists.txt

Index: polly/lib/External/CMakeLists.txt
===
--- polly/lib/External/CMakeLists.txt
+++ polly/lib/External/CMakeLists.txt
@@ -279,7 +279,6 @@
   FILES_MATCHING
   PATTERN "*.h"
   PATTERN "CMakeFiles" EXCLUDE
-  PATTERN ".svn" EXCLUDE
   )
   endif()
 
Index: polly/CMakeLists.txt
===
--- polly/CMakeLists.txt
+++ polly/CMakeLists.txt
@@ -125,7 +125,6 @@
 DESTINATION include
 FILES_MATCHING
 PATTERN "*.h"
-PATTERN ".svn" EXCLUDE
 )
 
   install(DIRECTORY ${POLLY_BINARY_DIR}/include/
@@ -133,7 +132,6 @@
 FILES_MATCHING
 PATTERN "*.h"
 PATTERN "CMakeFiles" EXCLUDE
-PATTERN ".svn" EXCLUDE
 )
 endif()
 
Index: llvm/cmake/modules/CMakeLists.txt
===
--- llvm/cmake/modules/CMakeLists.txt
+++ llvm/cmake/modules/CMakeLists.txt
@@ -93,7 +93,6 @@
 file(COPY .
   DESTINATION ${llvm_cmake_builddir}
   FILES_MATCHING PATTERN *.cmake
-  PATTERN .svn EXCLUDE
   PATTERN CMakeFiles EXCLUDE
   )
 
@@ -152,7 +151,6 @@
 DESTINATION ${LLVM_INSTALL_PACKAGE_DIR}
 COMPONENT cmake-exports
 FILES_MATCHING PATTERN *.cmake
-PATTERN .svn EXCLUDE
 PATTERN LLVMConfig.cmake EXCLUDE
 PATTERN LLVMConfigExtensions.cmake EXCLUDE
 PATTERN LLVMConfigVersion.cmake EXCLUDE
Index: llvm/CMakeLists.txt
===
--- llvm/CMakeLists.txt
+++ llvm/CMakeLists.txt
@@ -1104,7 +1104,6 @@
 PATTERN "*.td"
 PATTERN "*.inc"
 PATTERN "LICENSE.TXT"
-PATTERN ".svn" EXCLUDE
 )
 
   install(DIRECTORY ${LLVM_INCLUDE_DIR}/llvm ${LLVM_INCLUDE_DIR}/llvm-c
@@ -1118,7 +1117,6 @@
 # Exclude include/llvm/CMakeFiles/intrinsics_gen.dir, matched by "*.def"
 PATTERN "CMakeFiles" EXCLUDE
 PATTERN "config.h" EXCLUDE
-PATTERN ".svn" EXCLUDE
 )
 
   if (LLVM_INSTALL_MODULEMAPS)
Index: lldb/cmake/modules/LLDBConfig.cmake
===
--- lldb/cmake/modules/LLDBConfig.cmake
+++ lldb/cmake/modules/LLDBConfig.cmake
@@ -228,7 +228,6 @@
 DESTINATION include
 FILES_MATCHING
 PATTERN "*.h"
-PATTERN ".svn" EXCLUDE
 PATTERN ".cmake" EXCLUDE
 )
 
@@ -237,7 +236,6 @@
 DESTINATION include
 FILES_MATCHING
 PATTERN "*.h"
-PATTERN ".svn" EXCLUDE
 PATTERN ".cmake" EXCLUDE
 )
 
Index: lld/CMakeLists.txt
===
--- lld/CMakeLists.txt
+++ lld/CMakeLists.txt
@@ -195,7 +195,6 @@
 DESTINATION include
 FILES_MATCHING
 PATTERN "*.h"
-PATTERN ".svn" EXCLUDE
 )
 endif()
 
Index: clang/tools/libclang/CMakeLists.txt
===
--- clang/tools/libclang/CMakeLists.txt
+++ clang/tools/libclang/CMakeLists.txt
@@ -174,7 +174,6 @@
   DESTINATION "${LIBCLANG_HEADERS_INSTALL_DESTINATION}"
   FILES_MATCHING
   PATTERN "*.h"
-  PATTERN ".svn" EXCLUDE
   )
 
 # LLVM_DISTRIBUTION_COMPONENTS requires that each component have both a
Index: clang/CMakeLists.txt
===
--- clang/CMakeLists.txt
+++ clang/CMakeLists.txt
@@ -446,7 +446,6 @@
 PATTERN "*.def"
 PATTERN "*.h"
 PATTERN "config.h" EXCLUDE
-PATTERN ".svn" EXCLUDE
 )
 
   install(DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/include/clang
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D89859: Remove .svn from exclude list as we moved to git

2020-10-21 Thread Sylvestre Ledru via Phabricator via lldb-commits 
sylvestre.ledru added a comment.

ed if you want to approve it ;)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89859/new/

https://reviews.llvm.org/D89859

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D89859: Remove .svn from exclude list as we moved to git

2020-10-21 Thread Sylvestre Ledru via Phabricator via lldb-commits 
sylvestre.ledru created this revision.
sylvestre.ledru added a reviewer: serge-sans-paille.
Herald added subscribers: llvm-commits, lldb-commits, cfe-commits, mgorny.
Herald added a reviewer: bollu.
Herald added projects: clang, LLDB, LLVM.
sylvestre.ledru requested review of this revision.
Herald added a subscriber: JDevlieghere.

Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D89859

Files:
  clang/CMakeLists.txt
  clang/tools/libclang/CMakeLists.txt
  lld/CMakeLists.txt
  lldb/cmake/modules/LLDBConfig.cmake
  llvm/CMakeLists.txt
  llvm/cmake/modules/CMakeLists.txt
  polly/CMakeLists.txt
  polly/lib/External/CMakeLists.txt

Index: polly/lib/External/CMakeLists.txt
===
--- polly/lib/External/CMakeLists.txt
+++ polly/lib/External/CMakeLists.txt
@@ -279,7 +279,6 @@
   FILES_MATCHING
   PATTERN "*.h"
   PATTERN "CMakeFiles" EXCLUDE
-  PATTERN ".svn" EXCLUDE
   )
   endif()
 
Index: polly/CMakeLists.txt
===
--- polly/CMakeLists.txt
+++ polly/CMakeLists.txt
@@ -125,7 +125,6 @@
 DESTINATION include
 FILES_MATCHING
 PATTERN "*.h"
-PATTERN ".svn" EXCLUDE
 )
 
   install(DIRECTORY ${POLLY_BINARY_DIR}/include/
@@ -133,7 +132,6 @@
 FILES_MATCHING
 PATTERN "*.h"
 PATTERN "CMakeFiles" EXCLUDE
-PATTERN ".svn" EXCLUDE
 )
 endif()
 
Index: llvm/cmake/modules/CMakeLists.txt
===
--- llvm/cmake/modules/CMakeLists.txt
+++ llvm/cmake/modules/CMakeLists.txt
@@ -93,7 +93,6 @@
 file(COPY .
   DESTINATION ${llvm_cmake_builddir}
   FILES_MATCHING PATTERN *.cmake
-  PATTERN .svn EXCLUDE
   PATTERN CMakeFiles EXCLUDE
   )
 
@@ -152,7 +151,6 @@
 DESTINATION ${LLVM_INSTALL_PACKAGE_DIR}
 COMPONENT cmake-exports
 FILES_MATCHING PATTERN *.cmake
-PATTERN .svn EXCLUDE
 PATTERN LLVMConfig.cmake EXCLUDE
 PATTERN LLVMConfigExtensions.cmake EXCLUDE
 PATTERN LLVMConfigVersion.cmake EXCLUDE
Index: llvm/CMakeLists.txt
===
--- llvm/CMakeLists.txt
+++ llvm/CMakeLists.txt
@@ -1104,7 +1104,6 @@
 PATTERN "*.td"
 PATTERN "*.inc"
 PATTERN "LICENSE.TXT"
-PATTERN ".svn" EXCLUDE
 )
 
   install(DIRECTORY ${LLVM_INCLUDE_DIR}/llvm ${LLVM_INCLUDE_DIR}/llvm-c
@@ -1118,7 +1117,6 @@
 # Exclude include/llvm/CMakeFiles/intrinsics_gen.dir, matched by "*.def"
 PATTERN "CMakeFiles" EXCLUDE
 PATTERN "config.h" EXCLUDE
-PATTERN ".svn" EXCLUDE
 )
 
   if (LLVM_INSTALL_MODULEMAPS)
Index: lldb/cmake/modules/LLDBConfig.cmake
===
--- lldb/cmake/modules/LLDBConfig.cmake
+++ lldb/cmake/modules/LLDBConfig.cmake
@@ -228,7 +228,6 @@
 DESTINATION include
 FILES_MATCHING
 PATTERN "*.h"
-PATTERN ".svn" EXCLUDE
 PATTERN ".cmake" EXCLUDE
 )
 
@@ -237,7 +236,6 @@
 DESTINATION include
 FILES_MATCHING
 PATTERN "*.h"
-PATTERN ".svn" EXCLUDE
 PATTERN ".cmake" EXCLUDE
 )
 
Index: lld/CMakeLists.txt
===
--- lld/CMakeLists.txt
+++ lld/CMakeLists.txt
@@ -195,7 +195,6 @@
 DESTINATION include
 FILES_MATCHING
 PATTERN "*.h"
-PATTERN ".svn" EXCLUDE
 )
 endif()
 
Index: clang/tools/libclang/CMakeLists.txt
===
--- clang/tools/libclang/CMakeLists.txt
+++ clang/tools/libclang/CMakeLists.txt
@@ -174,7 +174,6 @@
   DESTINATION "${LIBCLANG_HEADERS_INSTALL_DESTINATION}"
   FILES_MATCHING
   PATTERN "*.h"
-  PATTERN ".svn" EXCLUDE
   )
 
 # LLVM_DISTRIBUTION_COMPONENTS requires that each component have both a
Index: clang/CMakeLists.txt
===
--- clang/CMakeLists.txt
+++ clang/CMakeLists.txt
@@ -446,7 +446,6 @@
 PATTERN "*.def"
 PATTERN "*.h"
 PATTERN "config.h" EXCLUDE
-PATTERN ".svn" EXCLUDE
 )
 
   install(DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/include/clang
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D78807: Fix gendered documentation

2020-04-24 Thread Sylvestre Ledru via Phabricator via lldb-commits 
sylvestre.ledru accepted this revision.
sylvestre.ledru added a comment.
This revision is now accepted and ready to land.

thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78807/new/

https://reviews.llvm.org/D78807



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D76471: Remap the target SDK directory to the host SDK directory

2020-04-10 Thread Sylvestre Ledru via Phabricator via lldb-commits 
sylvestre.ledru added inline comments.



Comment at: lldb/source/Utility/XcodeSDK.cpp:72
+  llvm::VersionTuple version = ParseSDKVersion(input);
+  return {sdk, version};
+}

With older version of the libcstdc++ (some Ubuntu LTS), it fails with:

```
 error: chosen constructor is explicit in copy-initialization
  return {sdk, version};
 ^~
/usr/lib/gcc/i686-linux-gnu/5.3.1/../../../../include/c++/5.3.1/tuple:612:19: 
note: explicit constructor declared here
constexpr tuple(_U1&& __a1, _U2&& __a2)
```

@aprantl  Could you please have a look ? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76471/new/

https://reviews.llvm.org/D76471



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D68537: Do not install lit-cpuid

2019-10-05 Thread Sylvestre Ledru via Phabricator via lldb-commits 
sylvestre.ledru added a comment.

Sure, happy to try, do you have some docs on this? Thanks :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68537/new/

https://reviews.llvm.org/D68537



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D67965: Have ABI plugins vend llvm MCRegisterInfo data

2019-09-26 Thread Sylvestre Ledru via Phabricator via lldb-commits 
sylvestre.ledru added a comment.

@labath 
I am building with AVR as experimental target and this change probably broke 
the build.

  In file included from 
/home/sylvestre/dev/debian/pkg-llvm/llvm-toolchain/branches/llvm-toolchain-snapshot_10~svn372978/tools/lldb/source/API/SystemInitializerFull.cpp:208:
  
/home/sylvestre/dev/debian/pkg-llvm/llvm-toolchain/branches/llvm-toolchain-snapshot_10~svn372978/build-llvm/tools/clang/stage2-bins/include/llvm/Config/Targets.def:42:1:
 error: reference to non-static member function must be called; did you mean to 
call it with no arguments?
  LLVM_TARGET(AVR)
  ^~~~
  
/home/sylvestre/dev/debian/pkg-llvm/llvm-toolchain/branches/llvm-toolchain-snapshot_10~svn372978/tools/lldb/source/API/SystemInitializerFull.cpp:207:43:
 note: expanded from macro 'LLVM_TARGET'
  #define LLVM_TARGET(t) LLDB_PROCESS_ ## t(Initialize)
^~
  In file included from 
/home/sylvestre/dev/debian/pkg-llvm/llvm-toolchain/branches/llvm-toolchain-snapshot_10~svn372978/tools/lldb/source/API/SystemInitializerFull.cpp:208:
  
/home/sylvestre/dev/debian/pkg-llvm/llvm-toolchain/branches/llvm-toolchain-snapshot_10~svn372978/build-llvm/tools/clang/stage2-bins/include/llvm/Config/Targets.def:42:1:
 error: use of undeclared identifier 'LLDB_PROCESS_AVR'
  
/home/sylvestre/dev/debian/pkg-llvm/llvm-toolchain/branches/llvm-toolchain-snapshot_10~svn372978/tools/lldb/source/API/SystemInitializerFull.cpp:207:24:
 note: expanded from macro 'LLVM_TARGET'
  #define LLVM_TARGET(t) LLDB_PROCESS_ ## t(Initialize)
 ^

Could you please have a look?
thanks


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67965/new/

https://reviews.llvm.org/D67965



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D55434: ObjectFileBreakpad: Implement sections

2019-01-10 Thread Sylvestre Ledru via Phabricator via lldb-commits 
sylvestre.ledru added a comment.

On i386


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55434/new/

https://reviews.llvm.org/D55434



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D55434: ObjectFileBreakpad: Implement sections

2019-01-10 Thread Sylvestre Ledru via Phabricator via lldb-commits 
sylvestre.ledru added a comment.

@labath This broke lldb on Debian stable:

  In file included from 
/build/llvm-toolchain-snapshot-8~svn350764/tools/lldb/source/Utility/DataExtractor.cpp:10:
  
/build/llvm-toolchain-snapshot-8~svn350764/tools/lldb/include/lldb/Utility/DataExtractor.h:1099:29:
 error: non-constant-expression cannot be narrowed from type 'uint64_t' (aka 
'unsigned long long') to 'size_t' (aka 'unsigned int') in initializer list 
[-Wc++11-narrowing]
  return {GetDataStart(), GetByteSize()};
  ^
  
/build/llvm-toolchain-snapshot-8~svn350764/tools/lldb/include/lldb/Utility/DataExtractor.h:1099:29:
 note: insert an explicit cast to silence this issue
  return {GetDataStart(), GetByteSize()};
  ^
  static_cast( )


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55434/new/

https://reviews.llvm.org/D55434



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D39246: Fix LLVM_LINK_LLVM_DYLIB build (pr35053)

2017-10-24 Thread Sylvestre Ledru via Phabricator via lldb-commits 
sylvestre.ledru added a comment.

This fixed the issue, thanks!


https://reviews.llvm.org/D39246



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D29078: This patch implements a command to access and manipulate the Intel(R) MPX Boundary Tables.

2017-02-01 Thread Sylvestre Ledru via Phabricator via lldb-commits 
sylvestre.ledru added a comment.

Like llvm or lldb in general, just integrate it into liblldb?

By the way, liblldb-intel-mpxtable.so-5.0 is incorrect should be 
liblldb-intel-mpxtable.so.5.0


Repository:
  rL LLVM

https://reviews.llvm.org/D29078



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D29078: This patch implements a command to access and manipulate the Intel(R) MPX Boundary Tables.

2017-02-01 Thread Sylvestre Ledru via Phabricator via lldb-commits 
sylvestre.ledru added a comment.

This change is creating a new library 
usr/lib/llvm-5.0/bin/liblldb-intel-mpxtable.so on GNU/Linux 64b
That sounds pretty specific, is that really something that we want to do?


Repository:
  rL LLVM

https://reviews.llvm.org/D29078



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D28155: Force the installation of lldb-server and lldb-argdumper

2017-01-30 Thread Sylvestre Ledru via Phabricator via lldb-commits 
sylvestre.ledru abandoned this revision.
sylvestre.ledru added a comment.

Thanks!


https://reviews.llvm.org/D28155



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D28155: Force the installation of lldb-server and lldb-argdumper

2016-12-30 Thread Sylvestre Ledru via Phabricator via lldb-commits 
sylvestre.ledru added a comment.

Probably, I did it the easy way

I don't know what ARG_GENERATE_INSTALL in cmake/modules/AddLLDB.cmake is for


https://reviews.llvm.org/D28155



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D28155: Force the installation of lldb-server and lldb-argdumper

2016-12-29 Thread Sylvestre Ledru via Phabricator via lldb-commits 
sylvestre.ledru created this revision.
sylvestre.ledru added a reviewer: beanz.
sylvestre.ledru added a subscriber: LLDB.
Herald added a subscriber: mgorny.

For some reasons, the usage of add_lldb_tool instead of add_lldb_executable 
causes these two binaries not be installed.
This patch fixes the issue


https://reviews.llvm.org/D28155

Files:
  llvm-toolchain-snapshot-4.0~svn290518/lldb/tools/argdumper/CMakeLists.txt
  llvm-toolchain-snapshot-4.0~svn290518/lldb/tools/lldb-server/CMakeLists.txt


Index: 
llvm-toolchain-snapshot-4.0~svn290518/lldb/tools/lldb-server/CMakeLists.txt
===
--- llvm-toolchain-snapshot-4.0~svn290518/lldb/tools/lldb-server/CMakeLists.txt
+++ llvm-toolchain-snapshot-4.0~svn290518/lldb/tools/lldb-server/CMakeLists.txt
@@ -188,3 +188,7 @@
 target_link_libraries(lldb-server ${LLDB_SYSTEM_LIBS})
 
 set_target_properties(lldb-server PROPERTIES VERSION ${LLDB_VERSION})
+
+install(TARGETS lldb-server
+  RUNTIME DESTINATION bin)
+
Index: llvm-toolchain-snapshot-4.0~svn290518/lldb/tools/argdumper/CMakeLists.txt
===
--- llvm-toolchain-snapshot-4.0~svn290518/lldb/tools/argdumper/CMakeLists.txt
+++ llvm-toolchain-snapshot-4.0~svn290518/lldb/tools/argdumper/CMakeLists.txt
@@ -11,3 +11,5 @@
 endif()
 llvm_config(lldb-argdumper ${LLVM_LINK_COMPONENTS})
 
+install(TARGETS lldb-argdumper
+  RUNTIME DESTINATION bin)


Index: llvm-toolchain-snapshot-4.0~svn290518/lldb/tools/lldb-server/CMakeLists.txt
===
--- llvm-toolchain-snapshot-4.0~svn290518/lldb/tools/lldb-server/CMakeLists.txt
+++ llvm-toolchain-snapshot-4.0~svn290518/lldb/tools/lldb-server/CMakeLists.txt
@@ -188,3 +188,7 @@
 target_link_libraries(lldb-server ${LLDB_SYSTEM_LIBS})
 
 set_target_properties(lldb-server PROPERTIES VERSION ${LLDB_VERSION})
+
+install(TARGETS lldb-server
+  RUNTIME DESTINATION bin)
+
Index: llvm-toolchain-snapshot-4.0~svn290518/lldb/tools/argdumper/CMakeLists.txt
===
--- llvm-toolchain-snapshot-4.0~svn290518/lldb/tools/argdumper/CMakeLists.txt
+++ llvm-toolchain-snapshot-4.0~svn290518/lldb/tools/argdumper/CMakeLists.txt
@@ -11,3 +11,5 @@
 endif()
 llvm_config(lldb-argdumper ${LLVM_LINK_COMPONENTS})
 
+install(TARGETS lldb-argdumper
+  RUNTIME DESTINATION bin)
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits