[Lldb-commits] [lldb] r314849 - cmake + xcode: prevent gtests from using includes from project root

[Tim Hammerquist via lldb-commits]

Author: penryu
Date: Tue Oct  3 14:20:18 2017
New Revision: 314849

URL: http://llvm.org/viewvc/llvm-project?rev=314849=rev
Log:
cmake + xcode: prevent gtests from using includes from project root

Summary:
At present, several gtests in the lldb open source codebase are using
#include statements rooted at $(SOURCE_ROOT)/${LLDB_PROJECT_ROOT}.

This patch cleans up this directory/include structure for both CMake and
Xcode build systems.

rdar://problem/33835795

Reviewers: zturner, jingham, beanz

Reviewed By: beanz

Subscribers: emaste, lldb-commits, mgorny

Differential Revision: https://reviews.llvm.org/D36598

Added:
lldb/trunk/unittests/TestingSupport/
lldb/trunk/unittests/TestingSupport/CMakeLists.txt
  - copied, changed from r314832, 
lldb/trunk/unittests/Utility/Helpers/CMakeLists.txt
lldb/trunk/unittests/TestingSupport/MockTildeExpressionResolver.cpp
  - copied, changed from r314832, 
lldb/trunk/unittests/Utility/Helpers/MockTildeExpressionResolver.cpp
lldb/trunk/unittests/TestingSupport/MockTildeExpressionResolver.h
  - copied, changed from r314832, 
lldb/trunk/unittests/Utility/Helpers/MockTildeExpressionResolver.h
lldb/trunk/unittests/TestingSupport/TestUtilities.cpp
  - copied, changed from r314832, 
lldb/trunk/unittests/Utility/Helpers/TestUtilities.cpp
lldb/trunk/unittests/TestingSupport/TestUtilities.h
  - copied, changed from r314832, 
lldb/trunk/unittests/Utility/Helpers/TestUtilities.h
Removed:
lldb/trunk/unittests/Utility/Helpers/CMakeLists.txt
lldb/trunk/unittests/Utility/Helpers/MockTildeExpressionResolver.cpp
lldb/trunk/unittests/Utility/Helpers/MockTildeExpressionResolver.h
lldb/trunk/unittests/Utility/Helpers/TestUtilities.cpp
lldb/trunk/unittests/Utility/Helpers/TestUtilities.h
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
lldb/trunk/unittests/CMakeLists.txt
lldb/trunk/unittests/Interpreter/TestCompletion.cpp
lldb/trunk/unittests/ObjectFile/ELF/TestObjectFileELF.cpp
lldb/trunk/unittests/Process/minidump/MinidumpParserTest.cpp
lldb/trunk/unittests/Symbol/TestDWARFCallFrameInfo.cpp
lldb/trunk/unittests/SymbolFile/DWARF/SymbolFileDWARFTests.cpp
lldb/trunk/unittests/SymbolFile/PDB/SymbolFilePDBTests.cpp
lldb/trunk/unittests/Target/ModuleCacheTest.cpp
lldb/trunk/unittests/Utility/CMakeLists.txt
lldb/trunk/unittests/Utility/StructuredDataTest.cpp
lldb/trunk/unittests/Utility/TildeExpressionResolverTest.cpp

Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/lldb.xcodeproj/project.pbxproj?rev=314849=314848=314849=diff
==
--- lldb/trunk/lldb.xcodeproj/project.pbxproj (original)
+++ lldb/trunk/lldb.xcodeproj/project.pbxproj Tue Oct  3 14:20:18 2017
@@ -876,8 +876,8 @@
966C6B7C18E6A56A0093F5EC /* libz.dylib in Frameworks */ = {isa 
= PBXBuildFile; fileRef = 966C6B7818E6A56A0093F5EC /* libz.dylib */; };
9694FA711B32AA64005EBB16 /* ABISysV_mips.cpp in Sources */ = 
{isa = PBXBuildFile; fileRef = 9694FA6F1B32AA64005EBB16 /* ABISysV_mips.cpp */; 
};
9A0FDEA71E8EF5110086B2F5 /* RegisterContextLinux_mips.cpp in 
Sources */ = {isa = PBXBuildFile; fileRef = 9A0FDE971E8EF5010086B2F5 /* 
RegisterContextLinux_mips.cpp */; };
-   9A1542F91F0EE48600DEA1D8 /* MockTildeExpressionResolver.cpp in 
Sources */ = {isa = PBXBuildFile; fileRef = 9A1542F51F0EE44000DEA1D8 /* 
MockTildeExpressionResolver.cpp */; };
-   9A1542FA1F0EE48600DEA1D8 /* TestUtilities.cpp in Sources */ = 
{isa = PBXBuildFile; fileRef = 9A1542F71F0EE44000DEA1D8 /* TestUtilities.cpp 
*/; };
+   9A18903B1F47D5E600394BCA /* MockTildeExpressionResolver.cpp in 
Sources */ = {isa = PBXBuildFile; fileRef = 9A1890321F47D5D400394BCA /* 
MockTildeExpressionResolver.cpp */; };
+   9A18903C1F47D5E600394BCA /* TestUtilities.cpp in Sources */ = 
{isa = PBXBuildFile; fileRef = 9A1890341F47D5D400394BCA /* TestUtilities.cpp 
*/; };
9A19A6AF1163BBB200E0D453 /* SBValue.h in Headers */ = {isa = 
PBXBuildFile; fileRef = 9A19A6A51163BB7E00E0D453 /* SBValue.h */; settings = 
{ATTRIBUTES = (Public, ); }; };
9A19A6B01163BBB300E0D453 /* SBValue.cpp in Sources */ = {isa = 
PBXBuildFile; fileRef = 9A19A6AD1163BB9800E0D453 /* SBValue.cpp */; };
9A1E595C1EB2B141002206A5 /* SBTrace.cpp in Sources */ = {isa = 
PBXBuildFile; fileRef = 9A1E59521EB2B0B9002206A5 /* SBTrace.cpp */; };
@@ -2864,11 +2864,11 @@
9A0FDE991E8EF5010086B2F5 /* RegisterInfos_arm.h */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = 
RegisterInfos_arm.h; path = Utility/RegisterInfos_arm.h; sourceTree = 
""; };
9A0FDE9A1E8EF5010086B2F5 /* RegisterInfos_arm64.h */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = 

[Lldb-commits] [lldb] r310512 - Add remainder of unittests to Xcode project

[Tim Hammerquist via lldb-commits]

Author: penryu
Date: Wed Aug  9 12:44:18 2017
New Revision: 310512

URL: http://llvm.org/viewvc/llvm-project?rev=310512=rev
Log:
Add remainder of unittests to Xcode project

Resolves a few build settings required to run DWARF tests as well.

rdar://problem/33664378

Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj

Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/lldb.xcodeproj/project.pbxproj?rev=310512=310511=310512=diff
==
--- lldb/trunk/lldb.xcodeproj/project.pbxproj (original)
+++ lldb/trunk/lldb.xcodeproj/project.pbxproj Wed Aug  9 12:44:18 2017
@@ -876,6 +876,20 @@
9A1E595C1EB2B141002206A5 /* SBTrace.cpp in Sources */ = {isa = 
PBXBuildFile; fileRef = 9A1E59521EB2B0B9002206A5 /* SBTrace.cpp */; };
9A1E595D1EB2B141002206A5 /* SBTraceOptions.cpp in Sources */ = 
{isa = PBXBuildFile; fileRef = 9A1E59531EB2B0B9002206A5 /* SBTraceOptions.cpp 
*/; };
9A2057031F3A605200F6C293 /* VASprintfTest.cpp in Sources */ = 
{isa = PBXBuildFile; fileRef = 9A3D43C41F3150D200EB767C /* VASprintfTest.cpp 
*/; };
+   9A2057081F3B819100F6C293 /* MemoryRegionInfoTest.cpp in Sources 
*/ = {isa = PBXBuildFile; fileRef = 9A2057061F3B818600F6C293 /* 
MemoryRegionInfoTest.cpp */; };
+   9A20570F1F3B821A00F6C293 /* test-dwarf.cpp in CopyFiles */ = 
{isa = PBXBuildFile; fileRef = 9A20570D1F3B821A00F6C293 /* test-dwarf.cpp */; };
+   9A2057101F3B821A00F6C293 /* test-dwarf.exe in CopyFiles */ = 
{isa = PBXBuildFile; fileRef = 9A20570E1F3B821A00F6C293 /* test-dwarf.exe */; };
+   9A2057121F3B824B00F6C293 /* SymbolFileDWARFTests.cpp in Sources 
*/ = {isa = PBXBuildFile; fileRef = 9A20570A1F3B81F300F6C293 /* 
SymbolFileDWARFTests.cpp */; };
+   9A2057171F3B861400F6C293 /* TestDWARFCallFrameInfo.cpp in 
Sources */ = {isa = PBXBuildFile; fileRef = 9A2057131F3B860D00F6C293 /* 
TestDWARFCallFrameInfo.cpp */; };
+   9A2057181F3B861400F6C293 /* TestType.cpp in Sources */ = {isa = 
PBXBuildFile; fileRef = 9A2057141F3B860D00F6C293 /* TestType.cpp */; };
+   9A20571C1F3B867400F6C293 /* PlatformDarwinTest.cpp in Sources 
*/ = {isa = PBXBuildFile; fileRef = 9A20571A1F3B866F00F6C293 /* 
PlatformDarwinTest.cpp */; };
+   9A2057201F3B8D2500F6C293 /* UnixSignalsTest.cpp in Sources */ = 
{isa = PBXBuildFile; fileRef = 9A20571E1F3B8D2100F6C293 /* UnixSignalsTest.cpp 
*/; };
+   9A2057281F3B8DDB00F6C293 /* TestELFHeader.cpp in Sources */ = 
{isa = PBXBuildFile; fileRef = 9A2057241F3B8DD200F6C293 /* TestELFHeader.cpp 
*/; };
+   9A2057291F3B8DDB00F6C293 /* TestObjectFileELF.cpp in Sources */ 
= {isa = PBXBuildFile; fileRef = 9A2057251F3B8DD200F6C293 /* 
TestObjectFileELF.cpp */; };
+   9A20572D1F3B8E6600F6C293 /* TestCompletion.cpp in Sources */ = 
{isa = PBXBuildFile; fileRef = 9A20572B1F3B8E6200F6C293 /* TestCompletion.cpp 
*/; };
+   9A2057381F3B8E7E00F6C293 /* FileSystemTest.cpp in Sources */ = 
{isa = PBXBuildFile; fileRef = 9A20572E1F3B8E7600F6C293 /* FileSystemTest.cpp 
*/; };
+   9A2057391F3B8E7E00F6C293 /* HostTest.cpp in Sources */ = {isa = 
PBXBuildFile; fileRef = 9A20572F1F3B8E7600F6C293 /* HostTest.cpp */; };
+   9A20573A1F3B8E7E00F6C293 /* MainLoopTest.cpp in Sources */ = 
{isa = PBXBuildFile; fileRef = 9A2057301F3B8E7600F6C293 /* MainLoopTest.cpp */; 
};
9A22A161135E30370024DDC3 /* EmulateInstructionARM.cpp in 
Sources */ = {isa = PBXBuildFile; fileRef = 9A22A15D135E30370024DDC3 /* 
EmulateInstructionARM.cpp */; };
9A22A163135E30370024DDC3 /* EmulationStateARM.cpp in Sources */ 
= {isa = PBXBuildFile; fileRef = 9A22A15F135E30370024DDC3 /* 
EmulationStateARM.cpp */; };
9A357583116CFDEE00E8ED2F /* SBValueList.h in Headers */ = {isa 
= PBXBuildFile; fileRef = 9A357582116CFDEE00E8ED2F /* SBValueList.h */; 
settings = {ATTRIBUTES = (Public, ); }; };
@@ -897,7 +911,6 @@
9A3D43EC1F3237F900EB767C /* ListenerTest.cpp in Sources */ = 
{isa = PBXBuildFile; fileRef = 9A3D43E31F3237D500EB767C /* ListenerTest.cpp */; 
};
9A3D43ED1F3237F900EB767C /* StateTest.cpp in Sources */ = {isa 
= PBXBuildFile; fileRef = 9A3D43E21F3237D500EB767C /* StateTest.cpp */; };
9A3D43EE1F3237F900EB767C /* StreamCallbackTest.cpp in Sources 
*/ = {isa = PBXBuildFile; fileRef = 9A3D43E11F3237D500EB767C /* 
StreamCallbackTest.cpp */; };
-   9A3D43F01F32380D00EB767C /* debugserver in CopyFiles */ = {isa 
= PBXBuildFile; fileRef = 9A3D43EF1F32380D00EB767C /* debugserver */; };
9A4F35101368A51A00823F52 /* StreamAsynchronousIO.cpp in Sources 
*/ = {isa = PBXBuildFile; fileRef = 9A4F350F1368A51A00823F52 /* 
StreamAsynchronousIO.cpp */; };
9A77AD541E64E2760025CE04 /* RegisterInfoPOSIX_arm.cpp in 

[Lldb-commits] [lldb] r310499 - Fix VASprintfTest.cpp for Darwin, add checks

[Tim Hammerquist via lldb-commits]

Author: penryu
Date: Wed Aug  9 10:27:02 2017
New Revision: 310499

URL: http://llvm.org/viewvc/llvm-project?rev=310499=rev
Log:
Fix VASprintfTest.cpp for Darwin, add checks

Summary:
The EncodingError test ensures that trying to encode a multibyte wchar
with a given codepage fails. If setlocale() fails, the encoding is
performed using the current locale, which may or may not fail.

This patch asserts that both setlocale() operations are successful, as
well as falling back to a widely available unibyte encoding for
non-Windows systems.



Reviewers: zturner, labath, lhames

Reviewed By: zturner

Subscribers: lldb-commits

Differential Revision: https://reviews.llvm.org/D36496

Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
lldb/trunk/unittests/Utility/VASprintfTest.cpp

Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/lldb.xcodeproj/project.pbxproj?rev=310499=310498=310499=diff
==
--- lldb/trunk/lldb.xcodeproj/project.pbxproj (original)
+++ lldb/trunk/lldb.xcodeproj/project.pbxproj Wed Aug  9 10:27:02 2017
@@ -875,6 +875,7 @@
9A19A6B01163BBB300E0D453 /* SBValue.cpp in Sources */ = {isa = 
PBXBuildFile; fileRef = 9A19A6AD1163BB9800E0D453 /* SBValue.cpp */; };
9A1E595C1EB2B141002206A5 /* SBTrace.cpp in Sources */ = {isa = 
PBXBuildFile; fileRef = 9A1E59521EB2B0B9002206A5 /* SBTrace.cpp */; };
9A1E595D1EB2B141002206A5 /* SBTraceOptions.cpp in Sources */ = 
{isa = PBXBuildFile; fileRef = 9A1E59531EB2B0B9002206A5 /* SBTraceOptions.cpp 
*/; };
+   9A2057031F3A605200F6C293 /* VASprintfTest.cpp in Sources */ = 
{isa = PBXBuildFile; fileRef = 9A3D43C41F3150D200EB767C /* VASprintfTest.cpp 
*/; };
9A22A161135E30370024DDC3 /* EmulateInstructionARM.cpp in 
Sources */ = {isa = PBXBuildFile; fileRef = 9A22A15D135E30370024DDC3 /* 
EmulateInstructionARM.cpp */; };
9A22A163135E30370024DDC3 /* EmulationStateARM.cpp in Sources */ 
= {isa = PBXBuildFile; fileRef = 9A22A15F135E30370024DDC3 /* 
EmulationStateARM.cpp */; };
9A357583116CFDEE00E8ED2F /* SBValueList.h in Headers */ = {isa 
= PBXBuildFile; fileRef = 9A357582116CFDEE00E8ED2F /* SBValueList.h */; 
settings = {ATTRIBUTES = (Public, ); }; };
@@ -7092,6 +7093,7 @@
AFEC5FD81D94F9380076A480 /* 
Testx86AssemblyInspectionEngine.cpp in Sources */,
23CB15401D66DA9300EDDDE1 /* 
TestClangASTContext.cpp in Sources */,
23CB15411D66DA9300EDDDE1 /* 
StringExtractorTest.cpp in Sources */,
+   9A2057031F3A605200F6C293 /* VASprintfTest.cpp 
in Sources */,
23CB15421D66DA9300EDDDE1 /* TaskPoolTest.cpp in 
Sources */,
23CB15431D66DA9300EDDDE1 /* BroadcasterTest.cpp 
in Sources */,
9A3D43EE1F3237F900EB767C /* 
StreamCallbackTest.cpp in Sources */,

Modified: lldb/trunk/unittests/Utility/VASprintfTest.cpp
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/unittests/Utility/VASprintfTest.cpp?rev=310499=310498=310499=diff
==
--- lldb/trunk/unittests/Utility/VASprintfTest.cpp (original)
+++ lldb/trunk/unittests/Utility/VASprintfTest.cpp Wed Aug  9 10:27:02 2017
@@ -14,6 +14,12 @@
 
 #include 
 
+#if defined (_WIN32)
+#define TEST_ENCODING ".932"  // On Windows, test codepage 932
+#else
+#define TEST_ENCODING "C" // ...otherwise, any widely available uni-byte LC
+#endif
+
 using namespace lldb_private;
 using namespace llvm;
 
@@ -46,7 +52,8 @@ TEST(VASprintfTest, EncodingError) {
   // Save the current locale first.
   std::string Current(::setlocale(LC_ALL, nullptr));
 
-  setlocale(LC_ALL, ".932");
+  // Ensure tested locale is successfully set
+  ASSERT_TRUE(setlocale(LC_ALL, TEST_ENCODING));
 
   wchar_t Invalid[2];
   Invalid[0] = 0x100;
@@ -55,5 +62,6 @@ TEST(VASprintfTest, EncodingError) {
   EXPECT_FALSE(Sprintf(Buffer, "%ls", Invalid));
   EXPECT_EQ("", Buffer);
 
-  setlocale(LC_ALL, Current.c_str());
+  // Ensure we've restored the original locale once tested
+  ASSERT_TRUE(setlocale(LC_ALL, Current.c_str()));
 }


___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r310417 - Add existing unit tests to Xcode project

[Tim Hammerquist via lldb-commits]

Author: penryu
Date: Tue Aug  8 13:59:20 2017
New Revision: 310417

URL: http://llvm.org/viewvc/llvm-project?rev=310417=rev
Log:
Add existing unit tests to Xcode project

Summary:
This adds gtest test files to the Xcode project which were
previously only in the cmake config. This is the first of several
planned merges.

Reviewers: beanz, spyffe, jingham

Reviewed By: jingham

Subscribers: lldb-commits

Differential Revision: https://reviews.llvm.org/D36485

Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj

Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/lldb.xcodeproj/project.pbxproj?rev=310417=310416=310417=diff
==
--- lldb/trunk/lldb.xcodeproj/project.pbxproj (original)
+++ lldb/trunk/lldb.xcodeproj/project.pbxproj Tue Aug  8 13:59:20 2017
@@ -885,6 +885,18 @@
9A3576AA116E9AC700E8ED2F /* SBHostOS.cpp in Sources */ = {isa = 
PBXBuildFile; fileRef = 9A3576A9116E9AC700E8ED2F /* SBHostOS.cpp */; };
9A36D24D1EB3BE7F00AAD9EA /* SBTrace.h in Headers */ = {isa = 
PBXBuildFile; fileRef = 9A1E59581EB2B10D002206A5 /* SBTrace.h */; settings = 
{ATTRIBUTES = (Public, ); }; };
9A36D24E1EB3BE7F00AAD9EA /* SBTraceOptions.h in Headers */ = 
{isa = PBXBuildFile; fileRef = 9A1E59591EB2B10D002206A5 /* SBTraceOptions.h */; 
settings = {ATTRIBUTES = (Public, ); }; };
+   9A3D43D61F3151C400EB767C /* ConstStringTest.cpp in Sources */ = 
{isa = PBXBuildFile; fileRef = 9A3D43C81F3150D200EB767C /* ConstStringTest.cpp 
*/; };
+   9A3D43D71F3151C400EB767C /* LogTest.cpp in Sources */ = {isa = 
PBXBuildFile; fileRef = 9A3D43C71F3150D200EB767C /* LogTest.cpp */; };
+   9A3D43D81F3151C400EB767C /* NameMatchesTest.cpp in Sources */ = 
{isa = PBXBuildFile; fileRef = 9A3D43CB1F3150D200EB767C /* NameMatchesTest.cpp 
*/; };
+   9A3D43D91F3151C400EB767C /* StatusTest.cpp in Sources */ = {isa 
= PBXBuildFile; fileRef = 9A3D43C61F3150D200EB767C /* StatusTest.cpp */; };
+   9A3D43DA1F3151C400EB767C /* StructuredDataTest.cpp in Sources 
*/ = {isa = PBXBuildFile; fileRef = 9A3D43CA1F3150D200EB767C /* 
StructuredDataTest.cpp */; };
+   9A3D43DB1F3151C400EB767C /* TildeExpressionResolverTest.cpp in 
Sources */ = {isa = PBXBuildFile; fileRef = 9A3D43C91F3150D200EB767C /* 
TildeExpressionResolverTest.cpp */; };
+   9A3D43DC1F3151C400EB767C /* TimeoutTest.cpp in Sources */ = 
{isa = PBXBuildFile; fileRef = 9A3D43CC1F3150D200EB767C /* TimeoutTest.cpp */; 
};
+   9A3D43DD1F3151C400EB767C /* TimerTest.cpp in Sources */ = {isa 
= PBXBuildFile; fileRef = 9A3D43C51F3150D200EB767C /* TimerTest.cpp */; };
+   9A3D43EC1F3237F900EB767C /* ListenerTest.cpp in Sources */ = 
{isa = PBXBuildFile; fileRef = 9A3D43E31F3237D500EB767C /* ListenerTest.cpp */; 
};
+   9A3D43ED1F3237F900EB767C /* StateTest.cpp in Sources */ = {isa 
= PBXBuildFile; fileRef = 9A3D43E21F3237D500EB767C /* StateTest.cpp */; };
+   9A3D43EE1F3237F900EB767C /* StreamCallbackTest.cpp in Sources 
*/ = {isa = PBXBuildFile; fileRef = 9A3D43E11F3237D500EB767C /* 
StreamCallbackTest.cpp */; };
+   9A3D43F01F32380D00EB767C /* debugserver in CopyFiles */ = {isa 
= PBXBuildFile; fileRef = 9A3D43EF1F32380D00EB767C /* debugserver */; };
9A4F35101368A51A00823F52 /* StreamAsynchronousIO.cpp in Sources 
*/ = {isa = PBXBuildFile; fileRef = 9A4F350F1368A51A00823F52 /* 
StreamAsynchronousIO.cpp */; };
9A77AD541E64E2760025CE04 /* RegisterInfoPOSIX_arm.cpp in 
Sources */ = {isa = PBXBuildFile; fileRef = 9A77AD501E64E24E0025CE04 /* 
RegisterInfoPOSIX_arm.cpp */; };
9AC7038E117674FB0086C050 /* SBInstruction.h in Headers */ = 
{isa = PBXBuildFile; fileRef = 9AC7038D117674EB0086C050 /* SBInstruction.h */; 
settings = {ATTRIBUTES = (Public, ); }; };
@@ -1200,6 +1212,7 @@
dstSubfolderSpec = 0;
files = (
AF90106515AB7D3600FF120D /* lldb.1 in CopyFiles 
*/,
+   9A3D43F01F32380D00EB767C /* debugserver in 
CopyFiles */,
);
runOnlyForDeploymentPostprocessing = 1;
};
@@ -2843,6 +2856,20 @@
9A357672116E7B6400E8ED2F /* SBStringList.cpp */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; 
name = SBStringList.cpp; path = source/API/SBStringList.cpp; sourceTree = 
""; };
9A3576A7116E9AB700E8ED2F /* SBHostOS.h */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = 
SBHostOS.h; path = include/lldb/API/SBHostOS.h; sourceTree = ""; };
9A3576A9116E9AC700E8ED2F /* SBHostOS.cpp */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; 
name = 

Re: [Lldb-commits] [lldb] r295369 - Fix build

[Tim Hammerquist via lldb-commits]

Hi Zachary, Pavel,

I'm working on integrating the VASprintfTest.cpp test and other unittests
into the Xcode project and I wonder if I can get some information about
the EncodingError test in LLDB's VASprintfTest.cpp.

It seems to try to store the current locale; set the locale to a new,
invalid locale; and then try to output a wide character (asserted to be
invalid) before restoring the original locale and closing.

However, in practice, it seems to be failing to set the new locale
(setlocale(3) returns nullptr) and the locale retains the same value it had
on entering the test. In this case, any 7- or 8-bit locale will succeed
("C", "*/US-ASCII", "*/ISO8859-1", et al. will fail to render the provided
Invalid characters) while wide-char friendly locales ("*/UTF-8") will
succeed in representing the "Invalid" wchar_t string, causing the test to
fail.

I've witnessed this behavior ('setlocale(LC_ALL, ".932") => nullptr) in
Darwin, Linux, and FreeBSD and want to make sure I'm not misunderstanding
something about how this test works. Do I understand this test correctly?

Thanks for your input!
-Tim


On Fri, Feb 17, 2017 at 7:42 AM, Zachary Turner via lldb-commits <
lldb-commits@lists.llvm.org> wrote:

> Sorry about that, it's often frustrating to check every single buildbot
> that was failing because 99% of the time they fail for exactly the same
> reason, and when one is fixed all of them get fixed. In this case i used
> http://lab.llvm.org:8011/builders/lldb-amd64-ninja-freebsd11/builds/5417
> as evidence that the change was good, but in hindsight this one doesn't run
> tests, so that was my mistake.
>
> Regarding the tests, i ran all of UtilityTests but not the whole test
> suite.  Again my mistake, was trying to cut corners and it backfired :(
>
>
>
> On Fri, Feb 17, 2017 at 2:35 AM Pavel Labath  wrote:
>
> Hey Zach,
>
> after you think you've fixed the build, could you check back on the
> buildbot to make sure that it actually fixes things? In this case you
> would've seen that after the build is fixed, the next thing it runs
> into is about a dozen test failures.
>
> In fact, this breakage was something that would have been already
> caught by running the unit tests on windows, which leads me to believe
> you didn't run them before submission.
>
> Thanks,
> pl
>
>
> 2017-02-16 20:15 GMT+00:00 Zachary Turner via lldb-commits
> :
> > Author: zturner
> > Date: Thu Feb 16 14:15:26 2017
> > New Revision: 295369
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=295369=rev
> > Log:
> > Fix build
> >
> > Modified:
> > lldb/trunk/source/Utility/VASprintf.cpp
> > lldb/trunk/unittests/Utility/VASprintfTest.cpp
> >
> > Modified: lldb/trunk/source/Utility/VASprintf.cpp
> > URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/
> Utility/VASprintf.cpp?rev=295369=295368=295369=diff
> > 
> ==
> > --- lldb/trunk/source/Utility/VASprintf.cpp (original)
> > +++ lldb/trunk/source/Utility/VASprintf.cpp Thu Feb 16 14:15:26 2017
> > @@ -7,7 +7,7 @@
> >  //
> >  //===---
> ---===//
> >
> > -#include "lldb/Utility/VASprintf.h"
> > +#include "lldb/Utility/VASPrintf.h"
> >
> >  #include "llvm/ADT/SmallString.h"
> >
> >
> > Modified: lldb/trunk/unittests/Utility/VASprintfTest.cpp
> > URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/unittests/
> Utility/VASprintfTest.cpp?rev=295369=295368=295369=diff
> > 
> ==
> > --- lldb/trunk/unittests/Utility/VASprintfTest.cpp (original)
> > +++ lldb/trunk/unittests/Utility/VASprintfTest.cpp Thu Feb 16 14:15:26
> 2017
> > @@ -7,7 +7,7 @@
> >  //
> >  //===---
> ---===//
> >
> > -#include "lldb/Utility/VASprintf.h"
> > +#include "lldb/Utility/VASPrintf.h"
> >  #include "llvm/ADT/SmallString.h"
> >
> >  #include "gtest/gtest.h"
> >
> >
> > ___
> > lldb-commits mailing list
> > lldb-commits@lists.llvm.org
> > http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
>
>
> ___
> lldb-commits mailing list
> lldb-commits@lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
>
>


-- 
Tim 
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r308393 - cmake build needs to run tests AND collect results

[Tim Hammerquist via lldb-commits]

Author: penryu
Date: Tue Jul 18 16:45:06 2017
New Revision: 308393

URL: http://llvm.org/viewvc/llvm-project?rev=308393=rev
Log:
cmake build needs to run tests AND collect results

CMake target "check-lldb" runs the lldb dotest.py suite, but doesn't
collect the results in a usable format. In adding the arguments
necessary to collect these results, I found some minor bugs in CMake
that prevented dotest overrides from being used. This patch fixes them.

 cmake build needs to run tests AND collect results

Modified:
lldb/trunk/test/CMakeLists.txt

Modified: lldb/trunk/test/CMakeLists.txt
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/test/CMakeLists.txt?rev=308393=308392=308393=diff
==
--- lldb/trunk/test/CMakeLists.txt (original)
+++ lldb/trunk/test/CMakeLists.txt Tue Jul 18 16:45:06 2017
@@ -49,8 +49,8 @@ endif()
 
 # Users can override LLDB_TEST_USER_ARGS to specify arbitrary arguments to 
pass to the script
 set(LLDB_TEST_USER_ARGS
-  "${LLDB_TEST_USER_ARGS_New}"
-  CACHE STRING "Specify additional arguments to pass to test runner. For 
example: '-C gcc -C clang -A i386 -A x86_64'" FORCE)
+  ""
+  CACHE STRING "Specify additional arguments to pass to test runner. For 
example: '-C gcc -C clang -A i386 -A x86_64'")
 
 set(LLDB_TEST_COMMON_ARGS
   --arch=${LLDB_TEST_ARCH}
@@ -101,19 +101,19 @@ if(CMAKE_HOST_APPLE)
   list(APPEND LLDB_TEST_COMMON_ARGS --server $)
 endif()
 
+set(LLDB_DOTEST_ARGS ${LLDB_TEST_COMMON_ARGS};${LLDB_TEST_USER_ARGS})
+
 add_python_test_target(check-lldb-single
   ${LLDB_SOURCE_DIR}/test/dotest.py
-  "--no-multiprocess;${LLDB_TEST_COMMON_ARGS};${LLDB_TEST_USER_ARGS}"
-  "Testing LLDB with args: ${LLDB_TEST_COMMON_ARGS};${LLDB_TEST_USER_ARGS}"
+  "--no-multiprocess;${LLDB_DOTEST_ARGS}"
+  "Testing LLDB with args: ${LLDB_DOTEST_ARGS}"
   )
 
-set(LLDB_DOTEST_ARGS -q;${LLDB_TEST_COMMON_ARGS};${LLDB_TEST_USER_ARGS})
-
 # If tests crash cause LLDB to crash, or things are otherwise unstable, or if 
machine-parsable
 # output is desired (i.e. in continuous integration contexts) 
check-lldb-single is a better target.
 add_python_test_target(check-lldb
   ${LLDB_SOURCE_DIR}/test/dotest.py
-  "${LLDB_DOTEST_ARGS}"
+  "-q;${LLDB_DOTEST_ARGS}"
   "Testing LLDB (parallel execution, with a separate subprocess per test)"
   )
 


___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r307712 - switch on enum should be exhaustive and warning-free

[Tim Hammerquist via lldb-commits]

Author: penryu
Date: Tue Jul 11 14:06:20 2017
New Revision: 307712

URL: http://llvm.org/viewvc/llvm-project?rev=307712=rev
Log:
switch on enum should be exhaustive and warning-free

Summary:
Testing the value of type_code against the closed enum TypeCodes
provides statically verifiable completeness of testing. However, one
branch assigns to type_code by casting directly from a masked integer
value. This is currently handled by adding a default: case after
checking each TypeCodes instance. This patch introduces a bool variable
containing the "default" state value, allowing the switch to be
exhaustive, protect against future instances not being handled in the
switch, and preserves the original logic.

This addresses the warning:
warning: default label in switch which covers all enumeration values
[-Wcovered-switch-default]

As an issue of maintainability, the bitmask on line 524 handles the
current values of TypeCodes enum, but this will be invalid if the enum
is extended. This patch does not address this, and a more closed
conversion from cfinfoa -> TypeCodes would help protect against this.

Reviewers: spyffe, lhames, sas

Reviewed By: sas

Subscribers: sas, lldb-commits

Differential Revision: https://reviews.llvm.org/D35036

Modified:
lldb/trunk/source/Plugins/Language/ObjC/Cocoa.cpp

Modified: lldb/trunk/source/Plugins/Language/ObjC/Cocoa.cpp
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Language/ObjC/Cocoa.cpp?rev=307712=307711=307712=diff
==
--- lldb/trunk/source/Plugins/Language/ObjC/Cocoa.cpp (original)
+++ lldb/trunk/source/Plugins/Language/ObjC/Cocoa.cpp Tue Jul 11 14:06:20 2017
@@ -543,6 +543,7 @@ bool lldb_private::formatters::NSNumberS
   }
   
   uint64_t value = 0;
+  bool success = false;
   switch (type_code) {
 case TypeCodes::sint8:
 value = process_sp->ReadUnsignedIntegerFromMemory(data_location, 1, 0,
@@ -550,6 +551,7 @@ bool lldb_private::formatters::NSNumberS
 if (error.Fail())
   return false;
 NSNumber_FormatChar(valobj, stream, (char)value, 
options.GetLanguage());
+success = true;
 break;
 case TypeCodes::sint16:
 value = process_sp->ReadUnsignedIntegerFromMemory(data_location, 2, 0,
@@ -558,6 +560,7 @@ bool lldb_private::formatters::NSNumberS
   return false;
 NSNumber_FormatShort(valobj, stream, (short)value,
  options.GetLanguage());
+success = true;
 break;
   case TypeCodes::sint32:
 value = process_sp->ReadUnsignedIntegerFromMemory(data_location, 4, 0,
@@ -565,6 +568,7 @@ bool lldb_private::formatters::NSNumberS
 if (error.Fail())
   return false;
 NSNumber_FormatInt(valobj, stream, (int)value, options.GetLanguage());
+success = true;
 break;
   case TypeCodes::sint64:
 value = process_sp->ReadUnsignedIntegerFromMemory(data_location, 8, 0,
@@ -572,6 +576,7 @@ bool lldb_private::formatters::NSNumberS
 if (error.Fail())
   return false;
 NSNumber_FormatLong(valobj, stream, value, options.GetLanguage());
+success = true;
 break;
   case TypeCodes::f32:
   {
@@ -582,6 +587,7 @@ bool lldb_private::formatters::NSNumberS
 float flt_value = 0.0f;
 memcpy(_value, _as_int, sizeof(flt_as_int));
 NSNumber_FormatFloat(valobj, stream, flt_value, options.GetLanguage());
+success = true;
 break;
   }
   case TypeCodes::f64:
@@ -593,6 +599,7 @@ bool lldb_private::formatters::NSNumberS
 double dbl_value = 0.0;
 memcpy(_value, _as_lng, sizeof(dbl_as_lng));
 NSNumber_FormatDouble(valobj, stream, dbl_value, 
options.GetLanguage());
+success = true;
 break;
   }
   case TypeCodes::sint128: // internally, this is the same
@@ -608,12 +615,11 @@ bool lldb_private::formatters::NSNumberS
   return false;
 llvm::APInt i128_value(128, words);
 NSNumber_FormatInt128(valobj, stream, i128_value, 
options.GetLanguage());
+success = true;
 break;
   }
-  default:
-return false;
   }
-  return true;
+  return success;
 }
   }
 


___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r307335 - Fix Xcode project file for gtest schemes.

[Tim Hammerquist via lldb-commits]

Author: penryu
Date: Thu Jul  6 16:25:35 2017
New Revision: 307335

URL: http://llvm.org/viewvc/llvm-project?rev=307335=rev
Log:
Fix Xcode project file for gtest schemes.



Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj

Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/lldb.xcodeproj/project.pbxproj?rev=307335=307334=307335=diff
==
--- lldb/trunk/lldb.xcodeproj/project.pbxproj (original)
+++ lldb/trunk/lldb.xcodeproj/project.pbxproj Thu Jul  6 16:25:35 2017
@@ -868,6 +868,8 @@
966C6B7C18E6A56A0093F5EC /* libz.dylib in Frameworks */ = {isa 
= PBXBuildFile; fileRef = 966C6B7818E6A56A0093F5EC /* libz.dylib */; };
9694FA711B32AA64005EBB16 /* ABISysV_mips.cpp in Sources */ = 
{isa = PBXBuildFile; fileRef = 9694FA6F1B32AA64005EBB16 /* ABISysV_mips.cpp */; 
};
9A0FDEA71E8EF5110086B2F5 /* RegisterContextLinux_mips.cpp in 
Sources */ = {isa = PBXBuildFile; fileRef = 9A0FDE971E8EF5010086B2F5 /* 
RegisterContextLinux_mips.cpp */; };
+   9A1542F91F0EE48600DEA1D8 /* MockTildeExpressionResolver.cpp in 
Sources */ = {isa = PBXBuildFile; fileRef = 9A1542F51F0EE44000DEA1D8 /* 
MockTildeExpressionResolver.cpp */; };
+   9A1542FA1F0EE48600DEA1D8 /* TestUtilities.cpp in Sources */ = 
{isa = PBXBuildFile; fileRef = 9A1542F71F0EE44000DEA1D8 /* TestUtilities.cpp 
*/; };
9A19A6AF1163BBB200E0D453 /* SBValue.h in Headers */ = {isa = 
PBXBuildFile; fileRef = 9A19A6A51163BB7E00E0D453 /* SBValue.h */; settings = 
{ATTRIBUTES = (Public, ); }; };
9A19A6B01163BBB300E0D453 /* SBValue.cpp in Sources */ = {isa = 
PBXBuildFile; fileRef = 9A19A6AD1163BB9800E0D453 /* SBValue.cpp */; };
9A1E595C1EB2B141002206A5 /* SBTrace.cpp in Sources */ = {isa = 
PBXBuildFile; fileRef = 9A1E59521EB2B0B9002206A5 /* SBTrace.cpp */; };
@@ -2815,6 +2817,11 @@
9A0FDE991E8EF5010086B2F5 /* RegisterInfos_arm.h */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = 
RegisterInfos_arm.h; path = Utility/RegisterInfos_arm.h; sourceTree = 
""; };
9A0FDE9A1E8EF5010086B2F5 /* RegisterInfos_arm64.h */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = 
RegisterInfos_arm64.h; path = Utility/RegisterInfos_arm64.h; sourceTree = 
""; };
9A0FDE9B1E8EF5010086B2F5 /* RegisterInfos_mips.h */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = 
RegisterInfos_mips.h; path = Utility/RegisterInfos_mips.h; sourceTree = 
""; };
+   9A1542F41F0EE44000DEA1D8 /* CMakeLists.txt */ = {isa = 
PBXFileReference; lastKnownFileType = text; path = CMakeLists.txt; sourceTree = 
""; };
+   9A1542F51F0EE44000DEA1D8 /* MockTildeExpressionResolver.cpp */ 
= {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = 
MockTildeExpressionResolver.cpp; sourceTree = ""; };
+   9A1542F61F0EE44000DEA1D8 /* MockTildeExpressionResolver.h */ = 
{isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = 
MockTildeExpressionResolver.h; sourceTree = ""; };
+   9A1542F71F0EE44000DEA1D8 /* TestUtilities.cpp */ = {isa = 
PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = 
TestUtilities.cpp; sourceTree = ""; };
+   9A1542F81F0EE44000DEA1D8 /* TestUtilities.h */ = {isa = 
PBXFileReference; lastKnownFileType = sourcecode.c.h; path = TestUtilities.h; 
sourceTree = ""; };
9A19A6A51163BB7E00E0D453 /* SBValue.h */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = 
SBValue.h; path = include/lldb/API/SBValue.h; sourceTree = ""; };
9A19A6AD1163BB9800E0D453 /* SBValue.cpp */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; 
name = SBValue.cpp; path = source/API/SBValue.cpp; sourceTree = ""; };
9A1E59521EB2B0B9002206A5 /* SBTrace.cpp */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; 
name = SBTrace.cpp; path = source/API/SBTrace.cpp; sourceTree = ""; };
@@ -3305,6 +3312,7 @@
2321F9421BDD343A00BA9A93 /* Utility */ = {
isa = PBXGroup;
children = (
+   9A1542F31F0EE44000DEA1D8 /* Helpers */,
2321F9431BDD346100BA9A93 /* CMakeLists.txt */,
23CB15041D66CD9200EDDDE1 /* Inputs */,
2321F9441BDD346100BA9A93 /* 
StringExtractorTest.cpp */,
@@ -6216,6 +6224,18 @@
name = "SysV-mips";
sourceTree = "";
};
+   9A1542F31F0EE44000DEA1D8 /* Helpers */ = {
+   isa = PBXGroup;
+   

[Lldb-commits] [lldb] r307228 - add googlemock include dir to lldb-gtest Xcode target

[Tim Hammerquist via lldb-commits]

Author: penryu
Date: Wed Jul  5 17:08:54 2017
New Revision: 307228

URL: http://llvm.org/viewvc/llvm-project?rev=307228=rev
Log:
add googlemock include dir to lldb-gtest Xcode target

Add the googlemock include directory from LLVM to CFLAGS arguments in
Xcode's lldb-gtest.



Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj

Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/lldb.xcodeproj/project.pbxproj?rev=307228=307227=307228=diff
==
--- lldb/trunk/lldb.xcodeproj/project.pbxproj (original)
+++ lldb/trunk/lldb.xcodeproj/project.pbxproj Wed Jul  5 17:08:54 2017
@@ -8256,7 +8256,7 @@

"$(LLVM_SOURCE_DIR)/tools/clang/include",

"$(LLVM_BUILD_DIR)/$(LLVM_BUILD_DIR_ARCH)/tools/clang/include",
);
-   LLDB_GTESTS_CFLAGS = "-I 
$(LLVM_SOURCE_DIR)/utils/unittest/googletest/include -I 
$(LLVM_SOURCE_DIR)/include -I $(LLVM_BUILD_DIR)/x86_64/include -I include -I 
source -I $(PYTHON_FRAMEWORK_PATH)/Headers";
+   LLDB_GTESTS_CFLAGS = "-I 
$(LLVM_SOURCE_DIR)/utils/unittest/googlemock/include -I 
$(LLVM_SOURCE_DIR)/utils/unittest/googletest/include -I 
$(LLVM_SOURCE_DIR)/include -I $(LLVM_BUILD_DIR)/x86_64/include -I include -I 
source -I $(PYTHON_FRAMEWORK_PATH)/Headers";
LLDB_GTESTS_LDFLAGS = 
"$(LLVM_BUILD_DIR)/x86_64/lib/libgtest.a -L 
$(PYTHON_FRAMEWORK_PATH)/Versions/$(PYTHON_VERSION_MAJOR).$(PYTHON_VERSION_MINOR)/lib
 -l python$(PYTHON_VERSION_MAJOR).$(PYTHON_VERSION_MINOR)";
OTHER_CFLAGS = (
"-fno-rtti",
@@ -8298,7 +8298,7 @@

"$(LLVM_SOURCE_DIR)/tools/clang/include",

"$(LLVM_BUILD_DIR)/$(LLVM_BUILD_DIR_ARCH)/tools/clang/include",
);
-   LLDB_GTESTS_CFLAGS = "-I 
$(LLVM_SOURCE_DIR)/utils/unittest/googletest/include -I 
$(LLVM_SOURCE_DIR)/include -I $(LLVM_BUILD_DIR)/x86_64/include -I include -I 
source -I $(PYTHON_FRAMEWORK_PATH)/Headers";
+   LLDB_GTESTS_CFLAGS = "-I 
$(LLVM_SOURCE_DIR)/utils/unittest/googlemock/include -I 
$(LLVM_SOURCE_DIR)/utils/unittest/googletest/include -I 
$(LLVM_SOURCE_DIR)/include -I $(LLVM_BUILD_DIR)/x86_64/include -I include -I 
source -I $(PYTHON_FRAMEWORK_PATH)/Headers";
LLDB_GTESTS_LDFLAGS = 
"$(LLVM_BUILD_DIR)/x86_64/lib/libgtest.a -L 
$(PYTHON_FRAMEWORK_PATH)/Versions/$(PYTHON_VERSION_MAJOR).$(PYTHON_VERSION_MINOR)/lib
 -l python$(PYTHON_VERSION_MAJOR).$(PYTHON_VERSION_MINOR)";
OTHER_CFLAGS = (
"-fno-rtti",
@@ -8340,7 +8340,7 @@

"$(LLVM_SOURCE_DIR)/tools/clang/include",

"$(LLVM_BUILD_DIR)/$(LLVM_BUILD_DIR_ARCH)/tools/clang/include",
);
-   LLDB_GTESTS_CFLAGS = "-I 
$(LLVM_SOURCE_DIR)/utils/unittest/googletest/include -I 
$(LLVM_SOURCE_DIR)/include -I $(LLVM_BUILD_DIR)/x86_64/include -I include -I 
source -I $(PYTHON_FRAMEWORK_PATH)/Headers";
+   LLDB_GTESTS_CFLAGS = "-I 
$(LLVM_SOURCE_DIR)/utils/unittest/googlemock/include -I 
$(LLVM_SOURCE_DIR)/utils/unittest/googletest/include -I 
$(LLVM_SOURCE_DIR)/include -I $(LLVM_BUILD_DIR)/x86_64/include -I include -I 
source -I $(PYTHON_FRAMEWORK_PATH)/Headers";
LLDB_GTESTS_LDFLAGS = 
"$(LLVM_BUILD_DIR)/x86_64/lib/libgtest.a -L 
$(PYTHON_FRAMEWORK_PATH)/Versions/$(PYTHON_VERSION_MAJOR).$(PYTHON_VERSION_MINOR)/lib
 -l python$(PYTHON_VERSION_MAJOR).$(PYTHON_VERSION_MINOR)";
OTHER_CFLAGS = (
"-fno-rtti",
@@ -8382,7 +8382,7 @@

"$(LLVM_SOURCE_DIR)/tools/clang/include",

"$(LLVM_BUILD_DIR)/$(LLVM_BUILD_DIR_ARCH)/tools/clang/include",
);
-   LLDB_GTESTS_CFLAGS = "-I 
$(LLVM_SOURCE_DIR)/utils/unittest/googletest/include -I 
$(LLVM_SOURCE_DIR)/include -I $(LLVM_BUILD_DIR)/x86_64/include -I include -I 
source -I $(PYTHON_FRAMEWORK_PATH)/Headers";
+   LLDB_GTESTS_CFLAGS = "-I 
$(LLVM_SOURCE_DIR)/utils/unittest/googlemock/include -I 
$(LLVM_SOURCE_DIR)/utils/unittest/googletest/include -I 
$(LLVM_SOURCE_DIR)/include -I $(LLVM_BUILD_DIR)/x86_64/include -I include -I 
source -I $(PYTHON_FRAMEWORK_PATH)/Headers";
LLDB_GTESTS_LDFLAGS = 
"$(LLVM_BUILD_DIR)/x86_64/lib/libgtest.a -L 

[Lldb-commits] [lldb] r306765 - Fix some type-based warnings

[Tim Hammerquist via lldb-commits]

Author: penryu
Date: Thu Jun 29 16:33:40 2017
New Revision: 306765

URL: http://llvm.org/viewvc/llvm-project?rev=306765=rev
Log:
Fix some type-based warnings

Modified:
lldb/trunk/source/Commands/CommandObjectThread.cpp
lldb/trunk/source/Plugins/Language/ObjC/Cocoa.cpp
lldb/trunk/tools/debugserver/source/debugserver.cpp

Modified: lldb/trunk/source/Commands/CommandObjectThread.cpp
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Commands/CommandObjectThread.cpp?rev=306765=306764=306765=diff
==
--- lldb/trunk/source/Commands/CommandObjectThread.cpp (original)
+++ lldb/trunk/source/Commands/CommandObjectThread.cpp Thu Jun 29 16:33:40 2017
@@ -209,7 +209,7 @@ protected:
 Process *process = m_exe_ctx.GetProcessPtr();
 Thread *thread = process->GetThreadList().FindThreadByID(tid).get();
 if (thread == nullptr) {
-  result.AppendErrorWithFormat("Failed to process thread# %lu.\n", tid);
+  result.AppendErrorWithFormat("Failed to process thread# %llu.\n", tid);
   result.SetStatus(eReturnStatusFailed);
   return false;
 }

Modified: lldb/trunk/source/Plugins/Language/ObjC/Cocoa.cpp
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Language/ObjC/Cocoa.cpp?rev=306765=306764=306765=diff
==
--- lldb/trunk/source/Plugins/Language/ObjC/Cocoa.cpp (original)
+++ lldb/trunk/source/Plugins/Language/ObjC/Cocoa.cpp Thu Jun 29 16:33:40 2017
@@ -517,11 +517,11 @@ bool lldb_private::formatters::NSNumberS
 
 bool is_preserved_number = cfinfoa & 0x8;
 if (is_preserved_number) {
-  lldbassert(!"We should handle preserved numbers!");
+  lldbassert(!static_cast("We should handle preserved 
numbers!"));
   return false;
 }
 
-type_code = (TypeCodes)(cfinfoa & 0x7);
+type_code = static_cast(cfinfoa & 0x7);
   } else {
 uint8_t data_type =
 process_sp->ReadUnsignedIntegerFromMemory(valobj_addr + ptr_size, 1,

Modified: lldb/trunk/tools/debugserver/source/debugserver.cpp
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/debugserver/source/debugserver.cpp?rev=306765=306764=306765=diff
==
--- lldb/trunk/tools/debugserver/source/debugserver.cpp (original)
+++ lldb/trunk/tools/debugserver/source/debugserver.cpp Thu Jun 29 16:33:40 2017
@@ -876,8 +876,8 @@ static struct option g_long_options[] =
  'u'}, // If we need to handshake with our parent process, an option will 
be
// passed down that specifies a unix socket name to use
 {"fd", required_argument, NULL,
- 'FDSC'}, // A file descriptor was passed to this process when spawned that
-  // is already open and ready for communication
+ '2'}, // A file descriptor was passed to this process when spawned that
+   // is already open and ready for communication
 {"named-pipe", required_argument, NULL, 'P'},
 {"reverse-connect", no_argument, NULL, 'R'},
 {"env", required_argument, NULL,
@@ -1261,7 +1261,7 @@ int main(int argc, char *argv[]) {
   }
   break;
 
-case 'FDSC':
+case '2':
   // File descriptor passed to this process during fork/exec and is already
   // open and ready for communication.
   communication_fd = atoi(optarg);


___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r301686 - Public headers need to be public.

[Tim Hammerquist via lldb-commits]

Author: penryu
Date: Fri Apr 28 16:03:18 2017
New Revision: 301686

URL: http://llvm.org/viewvc/llvm-project?rev=301686=rev
Log:
Public headers need to be public.

Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj

Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/lldb.xcodeproj/project.pbxproj?rev=301686=301685=301686=diff
==
--- lldb/trunk/lldb.xcodeproj/project.pbxproj (original)
+++ lldb/trunk/lldb.xcodeproj/project.pbxproj Fri Apr 28 16:03:18 2017
@@ -877,8 +877,8 @@
9A357673116E7B6400E8ED2F /* SBStringList.cpp in Sources */ = 
{isa = PBXBuildFile; fileRef = 9A357672116E7B6400E8ED2F /* SBStringList.cpp */; 
};
9A3576A8116E9AB700E8ED2F /* SBHostOS.h in Headers */ = {isa = 
PBXBuildFile; fileRef = 9A3576A7116E9AB700E8ED2F /* SBHostOS.h */; settings = 
{ATTRIBUTES = (Public, ); }; };
9A3576AA116E9AC700E8ED2F /* SBHostOS.cpp in Sources */ = {isa = 
PBXBuildFile; fileRef = 9A3576A9116E9AC700E8ED2F /* SBHostOS.cpp */; };
-   9A36D24D1EB3BE7F00AAD9EA /* SBTrace.h in Headers */ = {isa = 
PBXBuildFile; fileRef = 9A1E59581EB2B10D002206A5 /* SBTrace.h */; };
-   9A36D24E1EB3BE7F00AAD9EA /* SBTraceOptions.h in Headers */ = 
{isa = PBXBuildFile; fileRef = 9A1E59591EB2B10D002206A5 /* SBTraceOptions.h */; 
};
+   9A36D24D1EB3BE7F00AAD9EA /* SBTrace.h in Headers */ = {isa = 
PBXBuildFile; fileRef = 9A1E59581EB2B10D002206A5 /* SBTrace.h */; settings = 
{ATTRIBUTES = (Public, ); }; };
+   9A36D24E1EB3BE7F00AAD9EA /* SBTraceOptions.h in Headers */ = 
{isa = PBXBuildFile; fileRef = 9A1E59591EB2B10D002206A5 /* SBTraceOptions.h */; 
settings = {ATTRIBUTES = (Public, ); }; };
9A4F35101368A51A00823F52 /* StreamAsynchronousIO.cpp in Sources 
*/ = {isa = PBXBuildFile; fileRef = 9A4F350F1368A51A00823F52 /* 
StreamAsynchronousIO.cpp */; };
9A77AD541E64E2760025CE04 /* RegisterInfoPOSIX_arm.cpp in 
Sources */ = {isa = PBXBuildFile; fileRef = 9A77AD501E64E24E0025CE04 /* 
RegisterInfoPOSIX_arm.cpp */; };
9AC7038E117674FB0086C050 /* SBInstruction.h in Headers */ = 
{isa = PBXBuildFile; fileRef = 9AC7038D117674EB0086C050 /* SBInstruction.h */; 
settings = {ATTRIBUTES = (Public, ); }; };


___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r301664 - Add remaining SBTrace headers to LLDB framework

[Tim Hammerquist via lldb-commits]

Author: penryu
Date: Fri Apr 28 13:10:53 2017
New Revision: 301664

URL: http://llvm.org/viewvc/llvm-project?rev=301664=rev
Log:
Add remaining SBTrace headers to LLDB framework

Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj

Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/lldb.xcodeproj/project.pbxproj?rev=301664=301663=301664=diff
==
--- lldb/trunk/lldb.xcodeproj/project.pbxproj (original)
+++ lldb/trunk/lldb.xcodeproj/project.pbxproj Fri Apr 28 13:10:53 2017
@@ -877,6 +877,8 @@
9A357673116E7B6400E8ED2F /* SBStringList.cpp in Sources */ = 
{isa = PBXBuildFile; fileRef = 9A357672116E7B6400E8ED2F /* SBStringList.cpp */; 
};
9A3576A8116E9AB700E8ED2F /* SBHostOS.h in Headers */ = {isa = 
PBXBuildFile; fileRef = 9A3576A7116E9AB700E8ED2F /* SBHostOS.h */; settings = 
{ATTRIBUTES = (Public, ); }; };
9A3576AA116E9AC700E8ED2F /* SBHostOS.cpp in Sources */ = {isa = 
PBXBuildFile; fileRef = 9A3576A9116E9AC700E8ED2F /* SBHostOS.cpp */; };
+   9A36D24D1EB3BE7F00AAD9EA /* SBTrace.h in Headers */ = {isa = 
PBXBuildFile; fileRef = 9A1E59581EB2B10D002206A5 /* SBTrace.h */; };
+   9A36D24E1EB3BE7F00AAD9EA /* SBTraceOptions.h in Headers */ = 
{isa = PBXBuildFile; fileRef = 9A1E59591EB2B10D002206A5 /* SBTraceOptions.h */; 
};
9A4F35101368A51A00823F52 /* StreamAsynchronousIO.cpp in Sources 
*/ = {isa = PBXBuildFile; fileRef = 9A4F350F1368A51A00823F52 /* 
StreamAsynchronousIO.cpp */; };
9A77AD541E64E2760025CE04 /* RegisterInfoPOSIX_arm.cpp in 
Sources */ = {isa = PBXBuildFile; fileRef = 9A77AD501E64E24E0025CE04 /* 
RegisterInfoPOSIX_arm.cpp */; };
9AC7038E117674FB0086C050 /* SBInstruction.h in Headers */ = 
{isa = PBXBuildFile; fileRef = 9AC7038D117674EB0086C050 /* SBInstruction.h */; 
settings = {ATTRIBUTES = (Public, ); }; };
@@ -6429,6 +6431,7 @@
254FBBA31A9166F100BD6378 /* SBAttachInfo.h in 
Headers */,
26680221115FD13D008E1FE4 /* SBDefines.h in 
Headers */,
8CCB018219BA4E270009FD44 /* 
SBThreadCollection.h in Headers */,
+   9A36D24D1EB3BE7F00AAD9EA /* SBTrace.h in 
Headers */,
AF0EBBEC185941360059E52F /* SBQueue.h in 
Headers */,
26680222115FD13D008E1FE4 /* SBError.h in 
Headers */,
26680223115FD13D008E1FE4 /* SBEvent.h in 
Headers */,
@@ -6467,6 +6470,7 @@
941BCC8014E48C4000BB969C /* SBTypeFormat.h in 
Headers */,
9475C18F14E5F858001BFC6D /* 
SBTypeNameSpecifier.h in Headers */,
941BCC8114E48C4000BB969C /* SBTypeSummary.h in 
Headers */,
+   9A36D24E1EB3BE7F00AAD9EA /* SBTraceOptions.h in 
Headers */,
23059A121958B3B2007B8189 /* SBUnixSignals.h in 
Headers */,
941BCC8214E48C4000BB969C /* SBTypeSynthetic.h 
in Headers */,
9A19A6AF1163BBB200E0D453 /* SBValue.h in 
Headers */,


___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r301600 - integrate SBTrace changes into Xcode project

[Tim Hammerquist via lldb-commits]

Author: penryu
Date: Thu Apr 27 18:09:08 2017
New Revision: 301600

URL: http://llvm.org/viewvc/llvm-project?rev=301600=rev
Log:
integrate SBTrace changes into Xcode project

Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj

Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/lldb.xcodeproj/project.pbxproj?rev=301600=301599=301600=diff
==
--- lldb/trunk/lldb.xcodeproj/project.pbxproj (original)
+++ lldb/trunk/lldb.xcodeproj/project.pbxproj Thu Apr 27 18:09:08 2017
@@ -867,6 +867,8 @@
9A0FDEA71E8EF5110086B2F5 /* RegisterContextLinux_mips.cpp in 
Sources */ = {isa = PBXBuildFile; fileRef = 9A0FDE971E8EF5010086B2F5 /* 
RegisterContextLinux_mips.cpp */; };
9A19A6AF1163BBB200E0D453 /* SBValue.h in Headers */ = {isa = 
PBXBuildFile; fileRef = 9A19A6A51163BB7E00E0D453 /* SBValue.h */; settings = 
{ATTRIBUTES = (Public, ); }; };
9A19A6B01163BBB300E0D453 /* SBValue.cpp in Sources */ = {isa = 
PBXBuildFile; fileRef = 9A19A6AD1163BB9800E0D453 /* SBValue.cpp */; };
+   9A1E595C1EB2B141002206A5 /* SBTrace.cpp in Sources */ = {isa = 
PBXBuildFile; fileRef = 9A1E59521EB2B0B9002206A5 /* SBTrace.cpp */; };
+   9A1E595D1EB2B141002206A5 /* SBTraceOptions.cpp in Sources */ = 
{isa = PBXBuildFile; fileRef = 9A1E59531EB2B0B9002206A5 /* SBTraceOptions.cpp 
*/; };
9A22A161135E30370024DDC3 /* EmulateInstructionARM.cpp in 
Sources */ = {isa = PBXBuildFile; fileRef = 9A22A15D135E30370024DDC3 /* 
EmulateInstructionARM.cpp */; };
9A22A163135E30370024DDC3 /* EmulationStateARM.cpp in Sources */ 
= {isa = PBXBuildFile; fileRef = 9A22A15F135E30370024DDC3 /* 
EmulationStateARM.cpp */; };
9A357583116CFDEE00E8ED2F /* SBValueList.h in Headers */ = {isa 
= PBXBuildFile; fileRef = 9A357582116CFDEE00E8ED2F /* SBValueList.h */; 
settings = {ATTRIBUTES = (Public, ); }; };
@@ -2809,6 +2811,10 @@
9A0FDE9B1E8EF5010086B2F5 /* RegisterInfos_mips.h */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = 
RegisterInfos_mips.h; path = Utility/RegisterInfos_mips.h; sourceTree = 
""; };
9A19A6A51163BB7E00E0D453 /* SBValue.h */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = 
SBValue.h; path = include/lldb/API/SBValue.h; sourceTree = ""; };
9A19A6AD1163BB9800E0D453 /* SBValue.cpp */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; 
name = SBValue.cpp; path = source/API/SBValue.cpp; sourceTree = ""; };
+   9A1E59521EB2B0B9002206A5 /* SBTrace.cpp */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; 
name = SBTrace.cpp; path = source/API/SBTrace.cpp; sourceTree = ""; };
+   9A1E59531EB2B0B9002206A5 /* SBTraceOptions.cpp */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; 
name = SBTraceOptions.cpp; path = source/API/SBTraceOptions.cpp; sourceTree = 
""; };
+   9A1E59581EB2B10D002206A5 /* SBTrace.h */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = 
SBTrace.h; path = include/lldb/API/SBTrace.h; sourceTree = ""; };
+   9A1E59591EB2B10D002206A5 /* SBTraceOptions.h */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = 
SBTraceOptions.h; path = include/lldb/API/SBTraceOptions.h; sourceTree = 
""; };
9A22A15D135E30370024DDC3 /* EmulateInstructionARM.cpp */ = {isa 
= PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; 
path = EmulateInstructionARM.cpp; sourceTree = ""; };
9A22A15E135E30370024DDC3 /* EmulateInstructionARM.h */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = 
EmulateInstructionARM.h; sourceTree = ""; };
9A22A15F135E30370024DDC3 /* EmulationStateARM.cpp */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; 
path = EmulationStateARM.cpp; sourceTree = ""; };
@@ -4004,6 +4010,10 @@
8CCB017F19BA4DD9FD44 /* 
SBThreadCollection.cpp */,
4C56543419D2297A002E9C44 /* SBThreadPlan.h */,
4C56543619D22B32002E9C44 /* SBThreadPlan.cpp */,
+   9A1E59581EB2B10D002206A5 /* SBTrace.h */,
+   9A1E59521EB2B0B9002206A5 /* SBTrace.cpp */,
+   9A1E59591EB2B10D002206A5 /* SBTraceOptions.h */,
+   9A1E59531EB2B0B9002206A5 /* SBTraceOptions.cpp 
*/,
2617447911685869005ADD65 /* SBType.h */,
261744771168585B005ADD65 /* SBType.cpp */,
   

Re: [Lldb-commits] [lldb] r296925 - Fix Darwin failures introduced in r296909

[Tim Hammerquist via lldb-commits]

Hi Zachary!

Thank you for your prompt attention!

I notice you added DumpHexBytes() back, but Dump() is still missing. Was Dump() 
slated for a later patch?

-Tim

> On 3 Mar 2017, at 15:48, Zachary Turner <ztur...@google.com> wrote:
> 
> Yea, it was a static method of DataExtractor before.  I noticed the same 
> thing when i saw it wasn't using any methods of DataExtractor.  Oops!  Anyway 
> since this is no less weird than before I'll leave it this way for now until 
> we figure out something better.
> 
> On Fri, Mar 3, 2017 at 3:46 PM Jim Ingham <jing...@apple.com 
> <mailto:jing...@apple.com>> wrote:
> Yeah, looks like you need to keep DumpHexBytes in DumpDataExtractor.  That's 
> a little weird because it doesn't actually take a DataExtractor, but...
> 
> Jim
> 
> > On Mar 3, 2017, at 3:45 PM, Zachary Turner via lldb-commits 
> > <lldb-commits@lists.llvm.org <mailto:lldb-commits@lists.llvm.org>> wrote:
> >
> > I can fix that, I didn't see it in my tests because it doesn't compile that 
> > file on Windows.  I'll get a fix in shortly.
> >
> > On Fri, Mar 3, 2017 at 3:38 PM Tim Hammerquist <thammerqu...@apple.com 
> > <mailto:thammerqu...@apple.com>> wrote:
> > Sure, Zachary. I try to step in when I can.
> >
> > Now that you mention it, your r296910 (DumpDataExtractor) patch is breaking 
> > building CommunicationKDP.cpp in MacOSX-Kernel. Namely, the removal of 
> > Dump/DumpHexBytes from DataExtractor. I've coordinated with the Apple LLDB 
> > team on how they want to follow up on that, but they might want to reach 
> > out to you about it.
> >
> > -Tim
> >
> >> On 3 Mar 2017, at 15:33, Zachary Turner <ztur...@google.com 
> >> <mailto:ztur...@google.com>> wrote:
> >>
> >> Thanks Tim!
> >>
> >> I have a few more file moves coming up as well, sorry for the trouble!
> >>
> >> On Fri, Mar 3, 2017 at 3:29 PM Tim Hammerquist via lldb-commits 
> >> <lldb-commits@lists.llvm.org <mailto:lldb-commits@lists.llvm.org>> wrote:
> >> Author: penryu
> >> Date: Fri Mar  3 17:17:29 2017
> >> New Revision: 296925
> >>
> >> URL: http://llvm.org/viewvc/llvm-project?rev=296925=rev 
> >> <http://llvm.org/viewvc/llvm-project?rev=296925=rev>
> >> Log:
> >> Fix Darwin failures introduced in r296909
> >>
> >> Modified:
> >> lldb/trunk/lldb.xcodeproj/project.pbxproj
> >>
> >> Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
> >> URL: 
> >> http://llvm.org/viewvc/llvm-project/lldb/trunk/lldb.xcodeproj/project.pbxproj?rev=296925=296924=296925=diff
> >>  
> >> <http://llvm.org/viewvc/llvm-project/lldb/trunk/lldb.xcodeproj/project.pbxproj?rev=296925=296924=296925=diff>
> >> ==
> >> --- lldb/trunk/lldb.xcodeproj/project.pbxproj (original)
> >> +++ lldb/trunk/lldb.xcodeproj/project.pbxproj Fri Mar  3 17:17:29 2017
> >> @@ -2052,7 +2052,7 @@
> >> 26BC7D6310F1B77400F91463 /* FileSpecList.h */ = {isa = 
> >> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; 
> >> name = FileSpecList.h; path = include/lldb/Core/FileSpecList.h; sourceTree 
> >> = ""; };
> >> 26BC7D6510F1B77400F91463 /* IOStreamMacros.h */ = {isa = 
> >> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; 
> >> name = IOStreamMacros.h; path = include/lldb/Core/IOStreamMacros.h; 
> >> sourceTree = ""; };
> >> 26BC7D6710F1B77400F91463 /* Listener.h */ = {isa = 
> >> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; 
> >> name = Listener.h; path = include/lldb/Core/Listener.h; sourceTree = 
> >> ""; };
> >> -   26BC7D6810F1B77400F91463 /* Log.h */ = {isa = 
> >> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; 
> >> name = Log.h; path = include/lldb/Core/Log.h; sourceTree = ""; };
> >> +   26BC7D6810F1B77400F91463 /* Log.h */ = {isa = 
> >> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; 
> >> name = Log.h; path = include/lldb/Utility/Log.h; sourceTree = ""; };
> >> 26BC7D6910F1B77400F91463 /* Mangled.h */ = {isa = 
> >> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; 
> >> name = Mangled.h; path = include/lldb/Core/Mangled.h; sourceTree = 
>

Re: [Lldb-commits] [lldb] r296925 - Fix Darwin failures introduced in r296909

[Tim Hammerquist via lldb-commits]

Sure, Zachary. I try to step in when I can.

Now that you mention it, your r296910 (DumpDataExtractor) patch is breaking 
building CommunicationKDP.cpp in MacOSX-Kernel. Namely, the removal of 
Dump/DumpHexBytes from DataExtractor. I've coordinated with the Apple LLDB team 
on how they want to follow up on that, but they might want to reach out to you 
about it.

-Tim

> On 3 Mar 2017, at 15:33, Zachary Turner <ztur...@google.com> wrote:
> 
> Thanks Tim!
> 
> I have a few more file moves coming up as well, sorry for the trouble!
> 
> On Fri, Mar 3, 2017 at 3:29 PM Tim Hammerquist via lldb-commits 
> <lldb-commits@lists.llvm.org <mailto:lldb-commits@lists.llvm.org>> wrote:
> Author: penryu
> Date: Fri Mar  3 17:17:29 2017
> New Revision: 296925
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=296925=rev 
> <http://llvm.org/viewvc/llvm-project?rev=296925=rev>
> Log:
> Fix Darwin failures introduced in r296909
> 
> Modified:
> lldb/trunk/lldb.xcodeproj/project.pbxproj
> 
> Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
> URL: 
> http://llvm.org/viewvc/llvm-project/lldb/trunk/lldb.xcodeproj/project.pbxproj?rev=296925=296924=296925=diff
>  
> <http://llvm.org/viewvc/llvm-project/lldb/trunk/lldb.xcodeproj/project.pbxproj?rev=296925=296924=296925=diff>
> ==
> --- lldb/trunk/lldb.xcodeproj/project.pbxproj (original)
> +++ lldb/trunk/lldb.xcodeproj/project.pbxproj Fri Mar  3 17:17:29 2017
> @@ -2052,7 +2052,7 @@
> 26BC7D6310F1B77400F91463 /* FileSpecList.h */ = {isa = 
> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name 
> = FileSpecList.h; path = include/lldb/Core/FileSpecList.h; sourceTree = 
> ""; };
> 26BC7D6510F1B77400F91463 /* IOStreamMacros.h */ = {isa = 
> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name 
> = IOStreamMacros.h; path = include/lldb/Core/IOStreamMacros.h; sourceTree = 
> ""; };
> 26BC7D6710F1B77400F91463 /* Listener.h */ = {isa = 
> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name 
> = Listener.h; path = include/lldb/Core/Listener.h; sourceTree = ""; };
> -   26BC7D6810F1B77400F91463 /* Log.h */ = {isa = 
> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name 
> = Log.h; path = include/lldb/Core/Log.h; sourceTree = ""; };
> +   26BC7D6810F1B77400F91463 /* Log.h */ = {isa = 
> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name 
> = Log.h; path = include/lldb/Utility/Log.h; sourceTree = ""; };
> 26BC7D6910F1B77400F91463 /* Mangled.h */ = {isa = 
> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name 
> = Mangled.h; path = include/lldb/Core/Mangled.h; sourceTree = ""; };
> 26BC7D6A10F1B77400F91463 /* Module.h */ = {isa = 
> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name 
> = Module.h; path = include/lldb/Core/Module.h; sourceTree = ""; };
> 26BC7D6B10F1B77400F91463 /* ModuleChild.h */ = {isa = 
> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name 
> = ModuleChild.h; path = include/lldb/Core/ModuleChild.h; sourceTree = 
> ""; };
> @@ -2139,7 +2139,7 @@
> 26BC7E7910F1B85900F91463 /* Event.cpp */ = {isa = 
> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; 
> name = Event.cpp; path = source/Core/Event.cpp; sourceTree = ""; };
> 26BC7E7B10F1B85900F91463 /* FileSpecList.cpp */ = {isa = 
> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; 
> name = FileSpecList.cpp; path = source/Core/FileSpecList.cpp; sourceTree = 
> ""; };
> 26BC7E7E10F1B85900F91463 /* Listener.cpp */ = {isa = 
> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; 
> name = Listener.cpp; path = source/Core/Listener.cpp; sourceTree = ""; 
> };
> -   26BC7E7F10F1B85900F91463 /* Log.cpp */ = {isa = 
> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; 
> name = Log.cpp; path = source/Core/Log.cpp; sourceTree = ""; };
> +   26BC7E7F10F1B85900F91463 /* Log.cpp */ = {isa = 
> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; 
> name = Log.cpp; path = source/Utility/Log.cpp; sourceTree = ""; };
> 26BC7E8010F1B85900F91463 /* Mangled.cpp */ = {isa = 
> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; 

[Lldb-commits] [lldb] r299261 - add more RegisterContext files to xcode project

[Tim Hammerquist via lldb-commits]

Author: penryu
Date: Fri Mar 31 16:03:58 2017
New Revision: 299261

URL: http://llvm.org/viewvc/llvm-project?rev=299261=rev
Log:
add more RegisterContext files to xcode project

Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj

Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/lldb.xcodeproj/project.pbxproj?rev=299261=299260=299261=diff
==
--- lldb/trunk/lldb.xcodeproj/project.pbxproj (original)
+++ lldb/trunk/lldb.xcodeproj/project.pbxproj Fri Mar 31 16:03:58 2017
@@ -864,6 +864,7 @@
966C6B7A18E6A56A0093F5EC /* libz.dylib in Frameworks */ = {isa 
= PBXBuildFile; fileRef = 966C6B7818E6A56A0093F5EC /* libz.dylib */; };
966C6B7C18E6A56A0093F5EC /* libz.dylib in Frameworks */ = {isa 
= PBXBuildFile; fileRef = 966C6B7818E6A56A0093F5EC /* libz.dylib */; };
9694FA711B32AA64005EBB16 /* ABISysV_mips.cpp in Sources */ = 
{isa = PBXBuildFile; fileRef = 9694FA6F1B32AA64005EBB16 /* ABISysV_mips.cpp */; 
};
+   9A0FDEA71E8EF5110086B2F5 /* RegisterContextLinux_mips.cpp in 
Sources */ = {isa = PBXBuildFile; fileRef = 9A0FDE971E8EF5010086B2F5 /* 
RegisterContextLinux_mips.cpp */; };
9A19A6AF1163BBB200E0D453 /* SBValue.h in Headers */ = {isa = 
PBXBuildFile; fileRef = 9A19A6A51163BB7E00E0D453 /* SBValue.h */; settings = 
{ATTRIBUTES = (Public, ); }; };
9A19A6B01163BBB300E0D453 /* SBValue.cpp in Sources */ = {isa = 
PBXBuildFile; fileRef = 9A19A6AD1163BB9800E0D453 /* SBValue.cpp */; };
9A22A161135E30370024DDC3 /* EmulateInstructionARM.cpp in 
Sources */ = {isa = PBXBuildFile; fileRef = 9A22A15D135E30370024DDC3 /* 
EmulateInstructionARM.cpp */; };
@@ -2795,6 +2796,13 @@
966C6B7818E6A56A0093F5EC /* libz.dylib */ = {isa = 
PBXFileReference; lastKnownFileType = "compiled.mach-o.dylib"; name = 
libz.dylib; path = /usr/lib/libz.dylib; sourceTree = ""; };
9694FA6F1B32AA64005EBB16 /* ABISysV_mips.cpp */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; 
name = ABISysV_mips.cpp; path = "SysV-mips/ABISysV_mips.cpp"; sourceTree = 
""; };
9694FA701B32AA64005EBB16 /* ABISysV_mips.h */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = 
ABISysV_mips.h; path = "SysV-mips/ABISysV_mips.h"; sourceTree = ""; };
+   9A0FDE951E8EF5010086B2F5 /* RegisterContext_mips.h */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = 
RegisterContext_mips.h; path = Utility/RegisterContext_mips.h; sourceTree = 
""; };
+   9A0FDE961E8EF5010086B2F5 /* RegisterContext_s390x.h */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = 
RegisterContext_s390x.h; path = Utility/RegisterContext_s390x.h; sourceTree = 
""; };
+   9A0FDE971E8EF5010086B2F5 /* RegisterContextLinux_mips.cpp */ = 
{isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = 
sourcecode.cpp.cpp; name = RegisterContextLinux_mips.cpp; path = 
Utility/RegisterContextLinux_mips.cpp; sourceTree = ""; };
+   9A0FDE981E8EF5010086B2F5 /* RegisterContextLinux_mips.h */ = 
{isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; 
name = RegisterContextLinux_mips.h; path = Utility/RegisterContextLinux_mips.h; 
sourceTree = ""; };
+   9A0FDE991E8EF5010086B2F5 /* RegisterInfos_arm.h */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = 
RegisterInfos_arm.h; path = Utility/RegisterInfos_arm.h; sourceTree = 
""; };
+   9A0FDE9A1E8EF5010086B2F5 /* RegisterInfos_arm64.h */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = 
RegisterInfos_arm64.h; path = Utility/RegisterInfos_arm64.h; sourceTree = 
""; };
+   9A0FDE9B1E8EF5010086B2F5 /* RegisterInfos_mips.h */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = 
RegisterInfos_mips.h; path = Utility/RegisterInfos_mips.h; sourceTree = 
""; };
9A19A6A51163BB7E00E0D453 /* SBValue.h */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = 
SBValue.h; path = include/lldb/API/SBValue.h; sourceTree = ""; };
9A19A6AD1163BB9800E0D453 /* SBValue.cpp */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; 
name = SBValue.cpp; path = source/API/SBValue.cpp; sourceTree = ""; };
9A22A15D135E30370024DDC3 /* EmulateInstructionARM.cpp */ = {isa 
= PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; 
path = EmulateInstructionARM.cpp; sourceTree = ""; };
@@ -4520,6 +4528,13 @@
26B4666E11A2080F00CF6220 /* Utility */ = {
isa = PBXGroup;

[Lldb-commits] [lldb] r299116 - add NetBSD files to Xcode project to resolve failure from r299109

[Tim Hammerquist via lldb-commits]

Author: penryu
Date: Thu Mar 30 16:27:51 2017
New Revision: 299116

URL: http://llvm.org/viewvc/llvm-project?rev=299116=rev
Log:
add NetBSD files to Xcode project to resolve failure from r299109

Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj

Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/lldb.xcodeproj/project.pbxproj?rev=299116=299115=299116=diff
==
--- lldb/trunk/lldb.xcodeproj/project.pbxproj (original)
+++ lldb/trunk/lldb.xcodeproj/project.pbxproj Thu Mar 30 16:27:51 2017
@@ -880,6 +880,7 @@
9AC70390117675270086C050 /* SBInstructionList.h in Headers */ = 
{isa = PBXBuildFile; fileRef = 9AC7038F117675270086C050 /* SBInstructionList.h 
*/; settings = {ATTRIBUTES = (Public, ); }; };
9AC703AF117675410086C050 /* SBInstruction.cpp in Sources */ = 
{isa = PBXBuildFile; fileRef = 9AC703AE117675410086C050 /* SBInstruction.cpp 
*/; };
9AC703B1117675490086C050 /* SBInstructionList.cpp in Sources */ 
= {isa = PBXBuildFile; fileRef = 9AC703B0117675490086C050 /* 
SBInstructionList.cpp */; };
+   9AD9449F1E8DB26C004796ED /* RegisterContextNetBSD_x86_64.cpp in 
Sources */ = {isa = PBXBuildFile; fileRef = 9AD9449B1E8DB267004796ED /* 
RegisterContextNetBSD_x86_64.cpp */; };
A36FF33C17D8E94600244D40 /* OptionParser.cpp in Sources */ = 
{isa = PBXBuildFile; fileRef = A36FF33B17D8E94600244D40 /* OptionParser.cpp */; 
};
AE44FB301BB07EB20033EB62 /* GoUserExpression.cpp in Sources */ 
= {isa = PBXBuildFile; fileRef = AE44FB2C1BB07DD80033EB62 /* 
GoUserExpression.cpp */; };
AE44FB311BB07EB80033EB62 /* GoLexer.cpp in Sources */ = {isa = 
PBXBuildFile; fileRef = AE44FB2A1BB07DD80033EB62 /* GoLexer.cpp */; };
@@ -2851,6 +2852,8 @@
9AC7038F117675270086C050 /* SBInstructionList.h */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = 
SBInstructionList.h; path = include/lldb/API/SBInstructionList.h; sourceTree = 
""; };
9AC703AE117675410086C050 /* SBInstruction.cpp */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; 
name = SBInstruction.cpp; path = source/API/SBInstruction.cpp; sourceTree = 
""; };
9AC703B0117675490086C050 /* SBInstructionList.cpp */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; 
name = SBInstructionList.cpp; path = source/API/SBInstructionList.cpp; 
sourceTree = ""; };
+   9AD9449B1E8DB267004796ED /* RegisterContextNetBSD_x86_64.cpp */ 
= {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = 
sourcecode.cpp.cpp; name = RegisterContextNetBSD_x86_64.cpp; path = 
Utility/RegisterContextNetBSD_x86_64.cpp; sourceTree = ""; };
+   9AD9449C1E8DB267004796ED /* RegisterContextNetBSD_x86_64.h */ = 
{isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; 
name = RegisterContextNetBSD_x86_64.h; path = 
Utility/RegisterContextNetBSD_x86_64.h; sourceTree = ""; };
9AF16A9C11402D5B007A7B3F /* SBBreakpoint.cpp */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; 
name = SBBreakpoint.cpp; path = source/API/SBBreakpoint.cpp; sourceTree = 
""; };
9AF16A9E11402D69007A7B3F /* SBBreakpoint.h */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = 
SBBreakpoint.h; path = include/lldb/API/SBBreakpoint.h; sourceTree = ""; 
};
9AF16CC611408686007A7B3F /* SBBreakpointLocation.h */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = 
SBBreakpointLocation.h; path = include/lldb/API/SBBreakpointLocation.h; 
sourceTree = ""; };
@@ -4517,6 +4520,8 @@
26B4666E11A2080F00CF6220 /* Utility */ = {
isa = PBXGroup;
children = (
+   9AD9449B1E8DB267004796ED /* 
RegisterContextNetBSD_x86_64.cpp */,
+   9AD9449C1E8DB267004796ED /* 
RegisterContextNetBSD_x86_64.h */,
23F403471926C8D50046DC9B /* 
NativeRegisterContextRegisterInfo.h */,
23F403481926CC250046DC9B /* 
NativeRegisterContextRegisterInfo.cpp */,
B287E63E12EFAE2C00C9BEFE /* ARMDefines.h */,
@@ -7354,6 +7359,7 @@
268900D013353E6F00698AC0 /* Block.cpp in 
Sources */,
268900D113353E6F00698AC0 /* ClangASTContext.cpp 
in Sources */,
265192C61BA8E905002F08F6 /* CompilerDecl.cpp in 
Sources */,
+   9AD9449F1E8DB26C004796ED /* 
RegisterContextNetBSD_x86_64.cpp in Sources */,
268900D213353E6F00698AC0 /* CompilerType.cpp in 

[Lldb-commits] [lldb] r298547 - Merge r298536 changes to Xcode

[Tim Hammerquist via lldb-commits]

Author: penryu
Date: Wed Mar 22 15:21:52 2017
New Revision: 298547

URL: http://llvm.org/viewvc/llvm-project?rev=298547=rev
Log:
Merge r298536 changes to Xcode

rdar://problem/31202813

Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj

Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/lldb.xcodeproj/project.pbxproj?rev=298547=298546=298547=diff
==
--- lldb/trunk/lldb.xcodeproj/project.pbxproj (original)
+++ lldb/trunk/lldb.xcodeproj/project.pbxproj Wed Mar 22 15:21:52 2017
@@ -2301,8 +2301,8 @@
26F5C37410F3F61B009D5894 /* libobjc.dylib */ = {isa = 
PBXFileReference; lastKnownFileType = "compiled.mach-o.dylib"; name = 
libobjc.dylib; path = /usr/lib/libobjc.dylib; sourceTree = ""; };
26F5C39010F3FA26009D5894 /* CoreFoundation.framework */ = {isa 
= PBXFileReference; lastKnownFileType = wrapper.framework; name = 
CoreFoundation.framework; path = 
/System/Library/Frameworks/CoreFoundation.framework; sourceTree = ""; 
};
26F996A7119B79C300412154 /* ARM_DWARF_Registers.h */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = 
ARM_DWARF_Registers.h; path = source/Utility/ARM_DWARF_Registers.h; sourceTree 
= ""; };
-   26FA4315130103F400E71120 /* FileSpec.h */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = 
FileSpec.h; path = include/lldb/Host/FileSpec.h; sourceTree = ""; };
-   26FA43171301048600E71120 /* FileSpec.cpp */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; 
path = FileSpec.cpp; sourceTree = ""; };
+   26FA4315130103F400E71120 /* FileSpec.h */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = 
FileSpec.h; path = include/lldb/Utility/FileSpec.h; sourceTree = ""; };
+   26FA43171301048600E71120 /* FileSpec.cpp */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; 
name = FileSpec.cpp; path = source/Utility/FileSpec.cpp; sourceTree = 
""; };
26FFC19314FC072100087D58 /* AuxVector.cpp */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; 
path = AuxVector.cpp; sourceTree = ""; };
26FFC19414FC072100087D58 /* AuxVector.h */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = 
AuxVector.h; sourceTree = ""; };
26FFC19514FC072100087D58 /* DYLDRendezvous.cpp */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; 
path = DYLDRendezvous.cpp; sourceTree = ""; };
@@ -4181,6 +4181,8 @@
2682F168115ED9C800CCFF99 /* Utility */ = {
isa = PBXGroup;
children = (
+   26FA4315130103F400E71120 /* FileSpec.h */,
+   26FA43171301048600E71120 /* FileSpec.cpp */,
26CF992414428766001E4138 /* AnsiTerminal.h */,
26F996A7119B79C300412154 /* 
ARM_DWARF_Registers.h */,
264A12FF137252C700875C42 /* 
ARM64_DWARF_Registers.h */,
@@ -5032,7 +5034,6 @@
260C6EA013011578005E16B0 /* File.h */,
3FDFDDC0199D34E2009756A7 /* FileCache.h */,
3FDFDDBE199D345E009756A7 /* FileCache.cpp */,
-   26FA4315130103F400E71120 /* FileSpec.h */,
3FDFDDC1199D34E2009756A7 /* FileSystem.h */,
26BC7DD410F1B7D500F91463 /* Host.h */,
3FDFED1F19BA6D55009756A7 /* HostGetOpt.h */,
@@ -5857,7 +5858,6 @@
25420ED11A649D88009ADBCB /* PipeBase.cpp */,
26CFDCA2186163A4000E63E5 /* Editline.cpp */,
260C6EA213011581005E16B0 /* File.cpp */,
-   26FA43171301048600E71120 /* FileSpec.cpp */,
69A01E1C1236C5D400C660B5 /* Host.cpp */,
3FDFE53419A29327009756A7 /* HostInfoBase.cpp */,
3FDFED2419BA6D96009756A7 /* 
HostNativeThreadBase.cpp */,


___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r298517 - Merge changes from r298466 into Xcode project

[Tim Hammerquist via lldb-commits]

Author: penryu
Date: Wed Mar 22 11:47:14 2017
New Revision: 298517

URL: http://llvm.org/viewvc/llvm-project?rev=298517=rev
Log:
Merge changes from r298466 into Xcode project

rdar://problem/31197116

Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj

Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/lldb.xcodeproj/project.pbxproj?rev=298517=298516=298517=diff
==
--- lldb/trunk/lldb.xcodeproj/project.pbxproj (original)
+++ lldb/trunk/lldb.xcodeproj/project.pbxproj Wed Mar 22 11:47:14 2017
@@ -1345,8 +1345,8 @@
23EDE3371926AAD500F6A132 /* RegisterInfoInterface.h */ = {isa = 
PBXFileReference; lastKnownFileType = sourcecode.c.h; name = 
RegisterInfoInterface.h; path = Utility/RegisterInfoInterface.h; sourceTree = 
""; };
23EFE388193D1ABC00E54E54 /* SBTypeEnumMember.h */ = {isa = 
PBXFileReference; lastKnownFileType = sourcecode.c.h; name = 
SBTypeEnumMember.h; path = include/lldb/API/SBTypeEnumMember.h; sourceTree = 
""; };
23EFE38A193D1AEC00E54E54 /* SBTypeEnumMember.cpp */ = {isa = 
PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; name = 
SBTypeEnumMember.cpp; path = source/API/SBTypeEnumMember.cpp; sourceTree = 
""; };
-   23F403471926C8D50046DC9B /* NativeRegisterContextRegisterInfo.h 
*/ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = 
sourcecode.c.h; name = NativeRegisterContextRegisterInfo.h; path = 
include/lldb/Host/common/NativeRegisterContextRegisterInfo.h; sourceTree = 
""; };
-   23F403481926CC250046DC9B /* 
NativeRegisterContextRegisterInfo.cpp */ = {isa = PBXFileReference; 
fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = 
NativeRegisterContextRegisterInfo.cpp; path = 
source/Host/common/NativeRegisterContextRegisterInfo.cpp; sourceTree = 
""; };
+   23F403471926C8D50046DC9B /* NativeRegisterContextRegisterInfo.h 
*/ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = 
sourcecode.c.h; name = NativeRegisterContextRegisterInfo.h; path = 
Utility/NativeRegisterContextRegisterInfo.h; sourceTree = ""; };
+   23F403481926CC250046DC9B /* 
NativeRegisterContextRegisterInfo.cpp */ = {isa = PBXFileReference; 
fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = 
NativeRegisterContextRegisterInfo.cpp; path = 
Utility/NativeRegisterContextRegisterInfo.cpp; sourceTree = ""; };
250D6AE11A9679270049CC70 /* FileSystem.cpp */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; 
path = FileSystem.cpp; sourceTree = ""; };
25420ECC1A6490B8009ADBCB /* OptionValueChar.cpp */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; 
name = OptionValueChar.cpp; path = source/Interpreter/OptionValueChar.cpp; 
sourceTree = ""; };
25420ECE1A64911B009ADBCB /* OptionValueChar.h */ = {isa = 
PBXFileReference; lastKnownFileType = sourcecode.c.h; name = OptionValueChar.h; 
path = include/lldb/Interpreter/OptionValueChar.h; sourceTree = ""; };
@@ -4506,6 +4506,8 @@
26B4666E11A2080F00CF6220 /* Utility */ = {
isa = PBXGroup;
children = (
+   23F403471926C8D50046DC9B /* 
NativeRegisterContextRegisterInfo.h */,
+   23F403481926CC250046DC9B /* 
NativeRegisterContextRegisterInfo.cpp */,
B287E63E12EFAE2C00C9BEFE /* ARMDefines.h */,
B23DD24F12EDFAC1000C3894 /* ARMUtils.h */,
26954EBC1401EE8B00294D09 /* 
DynamicRegisterInfo.cpp */,
@@ -5302,8 +5304,6 @@
26E3EEBD11A9870400FBADB6 /* Unwind.h */,
264D8D4E13661BCC003A368F /* UnwindAssembly.h */,
264D8D4F13661BD7003A368F /* UnwindAssembly.cpp 
*/,
-   23F403471926C8D50046DC9B /* 
NativeRegisterContextRegisterInfo.h */,
-   23F403481926CC250046DC9B /* 
NativeRegisterContextRegisterInfo.cpp */,
);
name = Target;
sourceTree = "";


___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r298451 - Mirror CMake changes from r298412 to Xcode project

[Tim Hammerquist via lldb-commits]

Author: penryu
Date: Tue Mar 21 17:08:16 2017
New Revision: 298451

URL: http://llvm.org/viewvc/llvm-project?rev=298451=rev
Log:
Mirror CMake changes from r298412 to Xcode project


Mlldb.xcodeproj/project.pbxproj

Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj

Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/lldb.xcodeproj/project.pbxproj?rev=298451=298450=298451=diff
==
--- lldb/trunk/lldb.xcodeproj/project.pbxproj (original)
+++ lldb/trunk/lldb.xcodeproj/project.pbxproj Tue Mar 21 17:08:16 2017
@@ -2793,8 +2793,8 @@
9A22A160135E30370024DDC3 /* EmulationStateARM.h */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = 
EmulationStateARM.h; sourceTree = ""; };
9A357582116CFDEE00E8ED2F /* SBValueList.h */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = 
SBValueList.h; path = include/lldb/API/SBValueList.h; sourceTree = ""; };
9A35758D116CFE0F00E8ED2F /* SBValueList.cpp */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; 
name = SBValueList.cpp; path = source/API/SBValueList.cpp; sourceTree = 
""; };
-   9A35765E116E76A700E8ED2F /* StringList.h */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = 
StringList.h; path = include/lldb/Core/StringList.h; sourceTree = ""; };
-   9A35765F116E76B900E8ED2F /* StringList.cpp */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; 
name = StringList.cpp; path = source/Core/StringList.cpp; sourceTree = 
""; };
+   9A35765E116E76A700E8ED2F /* StringList.h */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = 
StringList.h; path = include/lldb/Utility/StringList.h; sourceTree = ""; 
};
+   9A35765F116E76B900E8ED2F /* StringList.cpp */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; 
name = StringList.cpp; path = source/Utility/StringList.cpp; sourceTree = 
""; };
9A357670116E7B5200E8ED2F /* SBStringList.h */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = 
SBStringList.h; path = include/lldb/API/SBStringList.h; sourceTree = ""; 
};
9A357672116E7B6400E8ED2F /* SBStringList.cpp */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; 
name = SBStringList.cpp; path = source/API/SBStringList.cpp; sourceTree = 
""; };
9A3576A7116E9AB700E8ED2F /* SBHostOS.h */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = 
SBHostOS.h; path = include/lldb/API/SBHostOS.h; sourceTree = ""; };
@@ -4235,6 +4235,8 @@
2676A093119C93C8008A98EF /* 
StringExtractorGDBRemote.cpp */,
94380B8019940B0300BFE4A8 /* StringLexer.h */,
94380B8119940B0A00BFE4A8 /* StringLexer.cpp */,
+   9A35765E116E76A700E8ED2F /* StringList.h */,
+   9A35765F116E76B900E8ED2F /* StringList.cpp */,
94BA8B6E176F8CA0005A91B5 /* Range.h */,
94BA8B6C176F8C9B005A91B5 /* Range.cpp */,
6DEC6F3A1BD66D950091ABA6 /* TaskPool.h */,
@@ -4729,8 +4731,6 @@
2623096E13D0EFFB006381D9 /* StreamBuffer.h */,
26BC7D7A10F1B77400F91463 /* StreamFile.h */,
26BC7E9210F1B85900F91463 /* StreamFile.cpp */,
-   9A35765E116E76A700E8ED2F /* StringList.h */,
-   9A35765F116E76B900E8ED2F /* StringList.cpp */,
26F2F8FD1B156678007857DE /* StructuredData.h */,
AFEC3361194A8ABA00FF05C6 /* StructuredData.cpp 
*/,
26B167A41123BF5500DC7B4F /* ThreadSafeValue.h 
*/,


___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r298123 - allow for specification of compiler/lldb executables basename

[Tim Hammerquist via lldb-commits]

Author: penryu
Date: Fri Mar 17 16:00:35 2017
New Revision: 298123

URL: http://llvm.org/viewvc/llvm-project?rev=298123=rev
Log:
allow for specification of compiler/lldb executables basename

Modified:
lldb/trunk/packages/Python/lldbsuite/test/dotest.py

Modified: lldb/trunk/packages/Python/lldbsuite/test/dotest.py
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/dotest.py?rev=298123=298122=298123=diff
==
--- lldb/trunk/packages/Python/lldbsuite/test/dotest.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/dotest.py Fri Mar 17 16:00:35 2017
@@ -278,6 +278,8 @@ def parseOptionsAndInitTestdirs():
 if args.compiler:
 configuration.compiler = os.path.realpath(args.compiler)
 if not is_exe(configuration.compiler):
+configuration.compiler = which(args.compiler)
+if not is_exe(configuration.compiler):
 logging.error(
 '%s is not a valid compiler executable; aborting...',
 args.compiler)
@@ -370,6 +372,8 @@ def parseOptionsAndInitTestdirs():
 # lldb executable is passed explicitly
 lldbtest_config.lldbExec = os.path.realpath(args.executable)
 if not is_exe(lldbtest_config.lldbExec):
+lldbtest_config.lldbExec = which(args.executable)
+if not is_exe(lldbtest_config.lldbExec):
 logging.error(
 '%s is not a valid executable to test; aborting...',
 args.executable)


___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r298111 - executables should be validated before spawning subprocesses

[Tim Hammerquist via lldb-commits]

Author: penryu
Date: Fri Mar 17 13:10:58 2017
New Revision: 298111

URL: http://llvm.org/viewvc/llvm-project?rev=298111=rev
Log:
executables should be validated before spawning subprocesses

dotest.py script doesn't validate executables passed on the command line
before spawning dozens of subprocesses, all of which fail silently,
leaving an empty results file.

We should validate the lldb and compiler executables on
configuration, aborting when given invalid paths, to prevent numerous,
cryptic, and spurious failures.



Modified:
lldb/trunk/packages/Python/lldbsuite/test/dotest.py

Modified: lldb/trunk/packages/Python/lldbsuite/test/dotest.py
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/dotest.py?rev=298111=298110=298111=diff
==
--- lldb/trunk/packages/Python/lldbsuite/test/dotest.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/dotest.py Fri Mar 17 13:10:58 2017
@@ -25,6 +25,7 @@ from __future__ import print_function
 import atexit
 import os
 import errno
+import logging
 import platform
 import re
 import signal
@@ -275,7 +276,12 @@ def parseOptionsAndInitTestdirs():
 do_help = True
 
 if args.compiler:
-configuration.compiler = args.compiler
+configuration.compiler = os.path.realpath(args.compiler)
+if not is_exe(configuration.compiler):
+logging.error(
+'%s is not a valid compiler executable; aborting...',
+args.compiler)
+sys.exit(-1)
 else:
 # Use a compiler appropriate appropriate for the Apple SDK if one was
 # specified
@@ -361,8 +367,14 @@ def parseOptionsAndInitTestdirs():
 configuration.lldbFrameworkPath = args.framework
 
 if args.executable:
+# lldb executable is passed explicitly
 lldbtest_config.lldbExec = os.path.realpath(args.executable)
-
+if not is_exe(lldbtest_config.lldbExec):
+logging.error(
+'%s is not a valid executable to test; aborting...',
+args.executable)
+sys.exit(-1)
+
 if args.server:
 os.environ['LLDB_DEBUGSERVER_PATH'] = args.server
 


___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r297538 - fix xunit attribute parsing

[Tim Hammerquist via lldb-commits]

Author: penryu
Date: Fri Mar 10 18:58:41 2017
New Revision: 297538

URL: http://llvm.org/viewvc/llvm-project?rev=297538=rev
Log:
fix xunit attribute parsing

Modified:
lldb/trunk/packages/Python/lldbsuite/test_event/formatter/xunit.py

Modified: lldb/trunk/packages/Python/lldbsuite/test_event/formatter/xunit.py
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test_event/formatter/xunit.py?rev=297538=297537=297538=diff
==
--- lldb/trunk/packages/Python/lldbsuite/test_event/formatter/xunit.py 
(original)
+++ lldb/trunk/packages/Python/lldbsuite/test_event/formatter/xunit.py Fri Mar 
10 18:58:41 2017
@@ -336,7 +336,7 @@ class XunitFormatter(ResultsFormatter):
 test_event,
 inner_content=(
 ''.format(
-"timeout",
+XunitFormatter._quote_attribute("timeout"),
 XunitFormatter._quote_attribute(message))
 ))
 with self.lock:


___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r297228 - fix format specifier warnings

[Tim Hammerquist via lldb-commits]

Author: penryu
Date: Tue Mar  7 15:26:04 2017
New Revision: 297228

URL: http://llvm.org/viewvc/llvm-project?rev=297228=rev
Log:
fix format specifier warnings

Modified:
lldb/trunk/tools/debugserver/source/MacOSX/DarwinLog/DarwinLogCollector.cpp
lldb/trunk/tools/debugserver/source/MacOSX/MachProcess.mm
lldb/trunk/tools/debugserver/source/MacOSX/MachThread.cpp

Modified: 
lldb/trunk/tools/debugserver/source/MacOSX/DarwinLog/DarwinLogCollector.cpp
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/debugserver/source/MacOSX/DarwinLog/DarwinLogCollector.cpp?rev=297228=297227=297228=diff
==
--- lldb/trunk/tools/debugserver/source/MacOSX/DarwinLog/DarwinLogCollector.cpp 
(original)
+++ lldb/trunk/tools/debugserver/source/MacOSX/DarwinLog/DarwinLogCollector.cpp 
Tue Mar  7 15:26:04 2017
@@ -692,7 +692,7 @@ void DarwinLogCollector::CancelActivityS
 
   DNBLogThreadedIf(LOG_DARWIN_LOG, "DarwinLogCollector::%s(): canceling "
"activity stream %p",
-   __FUNCTION__, m_activity_stream);
+   __FUNCTION__, reinterpret_cast(m_activity_stream));
   (*s_os_activity_stream_cancel)(m_activity_stream);
   m_activity_stream = nullptr;
 }

Modified: lldb/trunk/tools/debugserver/source/MacOSX/MachProcess.mm
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/debugserver/source/MacOSX/MachProcess.mm?rev=297228=297227=297228=diff
==
--- lldb/trunk/tools/debugserver/source/MacOSX/MachProcess.mm (original)
+++ lldb/trunk/tools/debugserver/source/MacOSX/MachProcess.mm Tue Mar  7 
15:26:04 2017
@@ -1269,7 +1269,7 @@ bool MachProcess::Interrupt() {
 bool MachProcess::Signal(int signal, const struct timespec *timeout_abstime) {
   DNBLogThreadedIf(LOG_PROCESS,
"MachProcess::Signal (signal = %d, timeout = %p)", signal,
-   timeout_abstime);
+   reinterpret_cast(timeout_abstime));
   nub_state_t state = GetState();
   if (::kill(ProcessID(), signal) == 0) {
 // If we were running and we have a timeout, wait for the signal to stop
@@ -1277,20 +1277,21 @@ bool MachProcess::Signal(int signal, con
   DNBLogThreadedIf(LOG_PROCESS, "MachProcess::Signal (signal = %d, timeout 
"
 "= %p) waiting for signal to stop "
 "process...",
-   signal, timeout_abstime);
+   signal, reinterpret_cast(timeout_abstime));
   m_private_events.WaitForSetEvents(eEventProcessStoppedStateChanged,
 timeout_abstime);
   state = GetState();
   DNBLogThreadedIf(
   LOG_PROCESS,
   "MachProcess::Signal (signal = %d, timeout = %p) state = %s", signal,
-  timeout_abstime, DNBStateAsString(state));
+  reinterpret_cast(timeout_abstime),
+  DNBStateAsString(state));
   return !IsRunning(state);
 }
 DNBLogThreadedIf(
 LOG_PROCESS,
 "MachProcess::Signal (signal = %d, timeout = %p) not waiting...",
-signal, timeout_abstime);
+signal, reinterpret_cast(timeout_abstime));
 return true;
   }
   DNBError err(errno, DNBError::POSIX);
@@ -1596,7 +1597,8 @@ DNBBreakpoint *MachProcess::CreateBreakp
   if (EnableBreakpoint(addr)) {
 DNBLogThreadedIf(LOG_BREAKPOINTS, "MachProcess::CreateBreakpoint ( addr = "
   "0x%8.8llx, length = %llu) => %p",
- (uint64_t)addr, (uint64_t)length, bp);
+ (uint64_t)addr, (uint64_t)length,
+ reinterpret_cast(bp));
 return bp;
   } else if (bp->Release() == 0) {
 m_breakpoints.Remove(addr);
@@ -1627,7 +1629,8 @@ DNBBreakpoint *MachProcess::CreateWatchp
   if (EnableWatchpoint(addr)) {
 DNBLogThreadedIf(LOG_WATCHPOINTS, "MachProcess::CreateWatchpoint ( addr = "
   "0x%8.8llx, length = %llu) => %p",
- (uint64_t)addr, (uint64_t)length, wp);
+ (uint64_t)addr, (uint64_t)length,
+ reinterpret_cast(wp));
 return wp;
   } else {
 DNBLogThreadedIf(LOG_WATCHPOINTS, "MachProcess::CreateWatchpoint ( addr = "
@@ -2156,7 +2159,7 @@ void MachProcess::AppendSTDOUT(char *s,
 
 size_t MachProcess::GetAvailableSTDOUT(char *buf, size_t buf_size) {
   DNBLogThreadedIf(LOG_PROCESS, "MachProcess::%s (&%p[%llu]) ...", 
__FUNCTION__,
-   buf, (uint64_t)buf_size);
+   reinterpret_cast(buf), (uint64_t)buf_size);
   PTHREAD_MUTEX_LOCKER(locker, m_stdio_mutex);
   size_t bytes_available = m_stdout_data.size();
   if (bytes_available > 0) {
@@ -2316,7 +2319,7 @@ void MachProcess::SignalAsyncProfileData
 
 size_t MachProcess::GetAsyncProfileData(char *buf, size_t buf_size) {
   

[Lldb-commits] [lldb] r296925 - Fix Darwin failures introduced in r296909

[Tim Hammerquist via lldb-commits]

Author: penryu
Date: Fri Mar  3 17:17:29 2017
New Revision: 296925

URL: http://llvm.org/viewvc/llvm-project?rev=296925=rev
Log:
Fix Darwin failures introduced in r296909

Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj

Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/lldb.xcodeproj/project.pbxproj?rev=296925=296924=296925=diff
==
--- lldb/trunk/lldb.xcodeproj/project.pbxproj (original)
+++ lldb/trunk/lldb.xcodeproj/project.pbxproj Fri Mar  3 17:17:29 2017
@@ -2052,7 +2052,7 @@
26BC7D6310F1B77400F91463 /* FileSpecList.h */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = 
FileSpecList.h; path = include/lldb/Core/FileSpecList.h; sourceTree = 
""; };
26BC7D6510F1B77400F91463 /* IOStreamMacros.h */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = 
IOStreamMacros.h; path = include/lldb/Core/IOStreamMacros.h; sourceTree = 
""; };
26BC7D6710F1B77400F91463 /* Listener.h */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = 
Listener.h; path = include/lldb/Core/Listener.h; sourceTree = ""; };
-   26BC7D6810F1B77400F91463 /* Log.h */ = {isa = PBXFileReference; 
fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = Log.h; path = 
include/lldb/Core/Log.h; sourceTree = ""; };
+   26BC7D6810F1B77400F91463 /* Log.h */ = {isa = PBXFileReference; 
fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = Log.h; path = 
include/lldb/Utility/Log.h; sourceTree = ""; };
26BC7D6910F1B77400F91463 /* Mangled.h */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = 
Mangled.h; path = include/lldb/Core/Mangled.h; sourceTree = ""; };
26BC7D6A10F1B77400F91463 /* Module.h */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = 
Module.h; path = include/lldb/Core/Module.h; sourceTree = ""; };
26BC7D6B10F1B77400F91463 /* ModuleChild.h */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = 
ModuleChild.h; path = include/lldb/Core/ModuleChild.h; sourceTree = ""; 
};
@@ -2139,7 +2139,7 @@
26BC7E7910F1B85900F91463 /* Event.cpp */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; 
name = Event.cpp; path = source/Core/Event.cpp; sourceTree = ""; };
26BC7E7B10F1B85900F91463 /* FileSpecList.cpp */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; 
name = FileSpecList.cpp; path = source/Core/FileSpecList.cpp; sourceTree = 
""; };
26BC7E7E10F1B85900F91463 /* Listener.cpp */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; 
name = Listener.cpp; path = source/Core/Listener.cpp; sourceTree = ""; };
-   26BC7E7F10F1B85900F91463 /* Log.cpp */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; 
name = Log.cpp; path = source/Core/Log.cpp; sourceTree = ""; };
+   26BC7E7F10F1B85900F91463 /* Log.cpp */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; 
name = Log.cpp; path = source/Utility/Log.cpp; sourceTree = ""; };
26BC7E8010F1B85900F91463 /* Mangled.cpp */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; 
name = Mangled.cpp; path = source/Core/Mangled.cpp; sourceTree = ""; };
26BC7E8110F1B85900F91463 /* Module.cpp */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; 
name = Module.cpp; path = source/Core/Module.cpp; sourceTree = ""; };
26BC7E8210F1B85900F91463 /* ModuleChild.cpp */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; 
name = ModuleChild.cpp; path = source/Core/ModuleChild.cpp; sourceTree = 
""; };
@@ -2335,8 +2335,8 @@
33E5E8411A672A240024ED68 /* StringConvert.cpp */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; 
path = StringConvert.cpp; sourceTree = ""; };
33E5E8451A6736D30024ED68 /* StringConvert.h */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = 
StringConvert.h; path = include/lldb/Host/StringConvert.h; sourceTree = 
SOURCE_ROOT; };
3F5E8AF31A40D4A500A73232 /* PipeBase.h */ = {isa = 
PBXFileReference; lastKnownFileType = sourcecode.c.h; name = PipeBase.h; path = 
include/lldb/Host/PipeBase.h; sourceTree = ""; };
-   3F8160A51AB9F7DD001DA9DF /* Logging.cpp */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; 
name = Logging.cpp; path = source/Core/Logging.cpp; 

[Lldb-commits] [lldb] r296406 - update pbxproj to match cmake config, broken in r296335

[Tim Hammerquist via lldb-commits]

Author: penryu
Date: Mon Feb 27 16:56:27 2017
New Revision: 296406

URL: http://llvm.org/viewvc/llvm-project?rev=296406=rev
Log:
update pbxproj to match cmake config, broken in r296335

Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj

Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/lldb.xcodeproj/project.pbxproj?rev=296406=296405=296406=diff
==
--- lldb/trunk/lldb.xcodeproj/project.pbxproj (original)
+++ lldb/trunk/lldb.xcodeproj/project.pbxproj Mon Feb 27 16:56:27 2017
@@ -131,7 +131,6 @@
255EFF741AFABA720069F277 /* LockFileBase.cpp in Sources */ = 
{isa = PBXBuildFile; fileRef = 255EFF731AFABA720069F277 /* LockFileBase.cpp */; 
};
255EFF761AFABA950069F277 /* LockFilePosix.cpp in Sources */ = 
{isa = PBXBuildFile; fileRef = 255EFF751AFABA950069F277 /* LockFilePosix.cpp 
*/; };
256CBDB41ADD0EFD00BC6CDC /* RegisterContextPOSIXCore_arm.cpp in 
Sources */ = {isa = PBXBuildFile; fileRef = 256CBDB21ADD0EFD00BC6CDC /* 
RegisterContextPOSIXCore_arm.cpp */; };
-   256CBDBA1ADD107200BC6CDC /* RegisterContextLinux_arm.cpp in 
Sources */ = {isa = PBXBuildFile; fileRef = 256CBDB61ADD107200BC6CDC /* 
RegisterContextLinux_arm.cpp */; };
256CBDBC1ADD107200BC6CDC /* RegisterContextLinux_mips64.cpp in 
Sources */ = {isa = PBXBuildFile; fileRef = 256CBDB81ADD107200BC6CDC /* 
RegisterContextLinux_mips64.cpp */; };
256CBDC01ADD11C000BC6CDC /* RegisterContextPOSIX_arm.cpp in 
Sources */ = {isa = PBXBuildFile; fileRef = 256CBDBE1ADD11C000BC6CDC /* 
RegisterContextPOSIX_arm.cpp */; };
2579065C1BD0488100178368 /* TCPSocket.cpp in Sources */ = {isa 
= PBXBuildFile; fileRef = 2579065A1BD0488100178368 /* TCPSocket.cpp */; };
@@ -880,6 +879,7 @@
9A3576A8116E9AB700E8ED2F /* SBHostOS.h in Headers */ = {isa = 
PBXBuildFile; fileRef = 9A3576A7116E9AB700E8ED2F /* SBHostOS.h */; settings = 
{ATTRIBUTES = (Public, ); }; };
9A3576AA116E9AC700E8ED2F /* SBHostOS.cpp in Sources */ = {isa = 
PBXBuildFile; fileRef = 9A3576A9116E9AC700E8ED2F /* SBHostOS.cpp */; };
9A4F35101368A51A00823F52 /* StreamAsynchronousIO.cpp in Sources 
*/ = {isa = PBXBuildFile; fileRef = 9A4F350F1368A51A00823F52 /* 
StreamAsynchronousIO.cpp */; };
+   9A77AD541E64E2760025CE04 /* RegisterInfoPOSIX_arm.cpp in 
Sources */ = {isa = PBXBuildFile; fileRef = 9A77AD501E64E24E0025CE04 /* 
RegisterInfoPOSIX_arm.cpp */; };
9AC7038E117674FB0086C050 /* SBInstruction.h in Headers */ = 
{isa = PBXBuildFile; fileRef = 9AC7038D117674EB0086C050 /* SBInstruction.h */; 
settings = {ATTRIBUTES = (Public, ); }; };
9AC70390117675270086C050 /* SBInstructionList.h in Headers */ = 
{isa = PBXBuildFile; fileRef = 9AC7038F117675270086C050 /* SBInstructionList.h 
*/; settings = {ATTRIBUTES = (Public, ); }; };
9AC703AF117675410086C050 /* SBInstruction.cpp in Sources */ = 
{isa = PBXBuildFile; fileRef = 9AC703AE117675410086C050 /* SBInstruction.cpp 
*/; };
@@ -970,7 +970,6 @@
B2A58724143119D50092BFBA /* SBWatchpoint.cpp in Sources */ = 
{isa = PBXBuildFile; fileRef = B2A58723143119D50092BFBA /* SBWatchpoint.cpp */; 
};
B2B7CCEB15D1BD6700EEFB57 /* CommandObjectWatchpointCommand.cpp 
in Sources */ = {isa = PBXBuildFile; fileRef = B2B7CCEA15D1BD6600EEFB57 /* 
CommandObjectWatchpointCommand.cpp */; };
B2B7CCF015D1C20F00EEFB57 /* WatchpointOptions.cpp in Sources */ 
= {isa = PBXBuildFile; fileRef = B2B7CCEF15D1C20F00EEFB57 /* 
WatchpointOptions.cpp */; };
-   B5EFAE861AE53B1D007059F3 /* RegisterContextFreeBSD_arm.cpp in 
Sources */ = {isa = PBXBuildFile; fileRef = B5EFAE841AE53B1D007059F3 /* 
RegisterContextFreeBSD_arm.cpp */; };
E769331C1A94D15400C73337 /* lldb-gdbserver.cpp in Sources */ = 
{isa = PBXBuildFile; fileRef = 26D6F3F4183E7F9300194858 /* lldb-gdbserver.cpp 
*/; };
E769331E1A94D18100C73337 /* lldb-server.cpp in Sources */ = 
{isa = PBXBuildFile; fileRef = E769331D1A94D18100C73337 /* lldb-server.cpp */; 
};
E7723D441AC4A7FB002BA082 /* RegisterContextPOSIXCore_arm64.cpp 
in Sources */ = {isa = PBXBuildFile; fileRef = E7723D421AC4A7FB002BA082 /* 
RegisterContextPOSIXCore_arm64.cpp */; };
@@ -1365,8 +1364,6 @@
255EFF751AFABA950069F277 /* LockFilePosix.cpp */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; 
path = LockFilePosix.cpp; sourceTree = ""; };
256CBDB21ADD0EFD00BC6CDC /* RegisterContextPOSIXCore_arm.cpp */ 
= {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = 
sourcecode.cpp.cpp; path = RegisterContextPOSIXCore_arm.cpp; sourceTree = 
""; };
256CBDB31ADD0EFD00BC6CDC /* RegisterContextPOSIXCore_arm.h */ = 
{isa = PBXFileReference; 

Re: [Lldb-commits] [lldb] r295897 - Changed builld-llvm.py to use .json files

[Tim Hammerquist via lldb-commits]

Hi Sean,

Looks like this is breaking builds in Green Dragon (and locally for me from
master branch). Can you take a look at the failures here?

http://lab.llvm.org:8080/green/view/LLDB/job/lldb_build_test/26076/console

Thanks!
-Tim


On Wed, Feb 22, 2017 at 2:57 PM, Sean Callanan via lldb-commits <
lldb-commits@lists.llvm.org> wrote:

> Author: spyffe
> Date: Wed Feb 22 16:57:59 2017
> New Revision: 295897
>
> URL: http://llvm.org/viewvc/llvm-project?rev=295897=rev
> Log:
> Changed builld-llvm.py to use .json files
>
> LLDB has many branches in a variety of repositories.
> The build-script.py file is subtly different for each set.
> This is unnecessary and causes merge headaches.
>
> This patch makes build-llvm.py consult a directory full
> of .json files, each one of which matches a particular
> branch using a regular expression.
>
> Differential revision: https://reviews.llvm.org/D30275
>
> Added:
> lldb/trunk/scripts/Xcode/repo.py
> lldb/trunk/scripts/Xcode/repos/
> lldb/trunk/scripts/Xcode/repos/svn-trunk.json
> Modified:
> lldb/trunk/scripts/Xcode/build-llvm.py
>
> Modified: lldb/trunk/scripts/Xcode/build-llvm.py
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/scripts/
> Xcode/build-llvm.py?rev=295897=295896=295897=diff
> 
> ==
> --- lldb/trunk/scripts/Xcode/build-llvm.py (original)
> +++ lldb/trunk/scripts/Xcode/build-llvm.py Wed Feb 22 16:57:59 2017
> @@ -6,6 +6,7 @@ import fnmatch
>  import os
>  import platform
>  import re
> +import repo
>  import subprocess
>  import sys
>
> @@ -17,42 +18,38 @@ from lldbbuild import *
>  def LLVM_HASH_INCLUDES_DIFFS():
>  return False
>
> -# The use of "x = "..."; return x" here is important because tooling
> looks for
> -# it with regexps.  Only change how this works if you know what you are
> doing.
> -
> -
> -def LLVM_REF():
> -llvm_ref = "master"
> -return llvm_ref
> -
> -
> -def CLANG_REF():
> -clang_ref = "master"
> -return clang_ref
> -
>  # For use with Xcode-style builds
>
> +def process_vcs(vcs):
> +return {
> +"svn": VCS.svn,
> +"git": VCS.git
> +}[vcs]
> +
> +def process_root(name):
> +return {
> +"llvm": llvm_source_path(),
> +"clang": clang_source_path(),
> +"ninja": ninja_source_path()
> +}[name]
> +
> +def process_repo(r):
> +return {
> +'name': r["name"],
> +'vcs': process_vcs(r["vcs"]),
> +'root': process_root(r["name"]),
> +'url': r["url"],
> +'ref': r["ref"]
> +}
>
>  def XCODE_REPOSITORIES():
> -return [
> -{'name': "llvm",
> - 'vcs': VCS.git,
> - 'root': llvm_source_path(),
> - 'url': "http://llvm.org/git/llvm.git;,
> - 'ref': LLVM_REF()},
> -
> -{'name': "clang",
> - 'vcs': VCS.git,
> - 'root': clang_source_path(),
> - 'url': "http://llvm.org/git/clang.git;,
> - 'ref': CLANG_REF()},
> -
> -{'name': "ninja",
> - 'vcs': VCS.git,
> - 'root': ninja_source_path(),
> - 'url': "https://github.com/ninja-build/ninja.git;,
> - 'ref': "master"}
> -]
> +identifier = repo.identifier()
> +if identifier == None:
> +sys.exit("Couldn't identify the current branch")
> +set = repo.find(identifier)
> +if set == None:
> +sys.exit("Couldn't find a repository set for the current branch")
> +return [process_repo(r) for r in set]
>
>
>  def get_c_compiler():
>
> Added: lldb/trunk/scripts/Xcode/repo.py
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/scripts/
> Xcode/repo.py?rev=295897=auto
> 
> ==
> --- lldb/trunk/scripts/Xcode/repo.py (added)
> +++ lldb/trunk/scripts/Xcode/repo.py Wed Feb 22 16:57:59 2017
> @@ -0,0 +1,33 @@
> +import json
> +import os
> +import re
> +import subprocess
> +
> +def identifier():
> +   try:
> +   svn_output = subprocess.check_output(["svn", "info",
> "--show-item", "url"], stderr=subprocess.STDOUT).rstrip()
> +   return svn_output
> +   except:
> +   pass
> +   try:
> +   git_remote_and_branch = subprocess.check_output(["git",
> "rev-parse", "--abbrev-ref", "--symbolic-full-name", "@{u}"]).rstrip()
> +   git_remote = git_remote_and_branch.split("/")[0]
> +   git_branch = "/".join(git_remote_and_
> branch.split("/")[1:])
> +   git_url = subprocess.check_output(["git", "remote",
> "get-url", git_remote]).rstrip()
> +   return git_url + ":" + git_branch
> +   except:
> +   pass
> +   return None
> +
> +def find(identifier):
> +   dir = os.path.dirname(os.path.realpath(__file__))
> +   repos_dir = os.path.join(dir, "repos")
> +   json_regex = re.compile(r"^.*.json$")
> +   override_path = os.path.join(repos_dir, "OVERRIDE.json")
> +

Re: [Lldb-commits] [lldb] r293269 - Unroll r292930 due to TestCallThatThrows test fail is not fixed in reasonable time.

[Tim Hammerquist via lldb-commits]

Thanks for following up! It's really appreciated!

-Tim

On Thu, Jan 26, 2017 at 11:51 PM, Boris Ulasevich via lldb-commits <
lldb-commits@lists.llvm.org> wrote:

> Author: bulasevich
> Date: Fri Jan 27 01:51:43 2017
> New Revision: 293269
>
> URL: http://llvm.org/viewvc/llvm-project?rev=293269=rev
> Log:
> Unroll r292930 due to TestCallThatThrows test fail is not fixed in
> reasonable time.
>
> Removed:
> lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/
> step_over_breakpoint/
> Modified:
> lldb/trunk/include/lldb/Target/Thread.h
> lldb/trunk/include/lldb/Target/ThreadPlan.h
> lldb/trunk/source/Target/StopInfo.cpp
> lldb/trunk/source/Target/Thread.cpp
> lldb/trunk/source/Target/ThreadPlanStepInstruction.cpp
> lldb/trunk/source/Target/ThreadPlanStepRange.cpp
>
> Modified: lldb/trunk/include/lldb/Target/Thread.h
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/
> lldb/Target/Thread.h?rev=293269=293268=293269=diff
> 
> ==
> --- lldb/trunk/include/lldb/Target/Thread.h (original)
> +++ lldb/trunk/include/lldb/Target/Thread.h Fri Jan 27 01:51:43 2017
> @@ -126,7 +126,6 @@ public:
> // bit of data.
>  lldb::StopInfoSP stop_info_sp; // You have to restore the stop info
> or you
> // might continue with the wrong
> signals.
> -std::vector m_completed_plan_stack;
>  lldb::RegisterCheckpointSP
>  register_backup_sp; // You need to restore the registers, of
> course...
>  uint32_t current_inlined_depth;
> @@ -1030,15 +1029,6 @@ public:
>bool WasThreadPlanDiscarded(ThreadPlan *plan);
>
>//--
> -  /// Check if we have completed plan to override breakpoint stop reason
> -  ///
> -  /// @return
> -  /// Returns true if completed plan stack is not empty
> -  /// false otherwise.
> -  //--
> -  bool CompletedPlanOverridesBreakpoint();
> -
> -  //--
>/// Queues a generic thread plan.
>///
>/// @param[in] plan_sp
> @@ -1223,8 +1213,6 @@ public:
>
>void SetStopInfo(const lldb::StopInfoSP _info_sp);
>
> -  void ResetStopInfo();
> -
>void SetShouldReportStop(Vote vote);
>
>//--
> 
>
> Modified: lldb/trunk/include/lldb/Target/ThreadPlan.h
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/
> lldb/Target/ThreadPlan.h?rev=293269=293268=293269=diff
> 
> ==
> --- lldb/trunk/include/lldb/Target/ThreadPlan.h (original)
> +++ lldb/trunk/include/lldb/Target/ThreadPlan.h Fri Jan 27 01:51:43 2017
> @@ -40,10 +40,9 @@ namespace lldb_private {
>  //  The thread maintaining a thread plan stack, and you program the
> actions of a
>  //  particular thread
>  //  by pushing plans onto the plan stack.
> -//  There is always a "Current" plan, which is the top of the plan stack,
> +//  There is always a "Current" plan, which is the head of the plan stack,
>  //  though in some cases
> -//  a plan may defer to plans higher in the stack for some piece of
> information
> -//  (let us define that the plan stack grows downwards).
> +//  a plan may defer to plans higher in the stack for some piece of
> information.
>  //
>  //  The plan stack is never empty, there is always a Base Plan which
> persists
>  //  through the life
> @@ -110,15 +109,6 @@ namespace lldb_private {
>  //  plans in the time between when
>  //  your plan gets unshipped and the next resume.
>  //
> -//  Thread State Checkpoint:
> -//
> -//  Note that calling functions on target process
> (ThreadPlanCallFunction) changes
> -//  current thread state. The function can be called either by direct
> user demand or
> -//  internally, for example lldb allocates memory on device to calculate
> breakpoint
> -//  condition expression - on Linux it is performed by calling mmap on
> device.
> -//  ThreadStateCheckpoint saves Thread state (stop info and completed
> -//  plan stack) to restore it after completing function call.
> -//
>  //  Over the lifetime of the plan, various methods of the ThreadPlan are
> then
>  //  called in response to changes of state in
>  //  the process we are debugging as follows:
> @@ -159,7 +149,7 @@ namespace lldb_private {
>  //  If the Current plan answers "true" then it is asked if the stop should
>  //  percolate all the way to the
>  //  user by calling the ShouldStop method.  If the current plan doesn't
> explain
> -//  the stop, then we query up
> +//  the stop, then we query down
>  //  the plan stack for a plan that does explain the stop.  The plan that
> does
>  //  explain the stop then needs to
>  //  figure out what to do about the plans below it in 

Re: [Lldb-commits] [lldb] r291198 - Make lldb -Werror clean for -Wstring-conversion

[Tim Hammerquist via lldb-commits]

Green Dragon build <
http://lab.llvm.org:8080/green/job/lldb_build_test/23854/> failed with this
commit with the error:

CompileC
build/debugserver.build/Release/debugserver.build/Objects-normal/x86_64/DNBDataRef.o
source/DNBDataRef.cpp normal x86_64 c++
com.apple.compilers.llvm.clang.1_0.compiler cd
"/Users/buildslave/jenkins/sharedspace/lldb@2/lldb/tools/debugserver"
export LANG=en_US.US-ASCII
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang
-x c++ -arch x86_64 -fmessage-length=0
-fdiagnostics-show-note-include-stack -fmacro-backtrace-limit=0 -std=c++11
-stdlib=libc++ -Wno-trigraphs -fpascal-strings -Os -fno-common
-Wno-missing-field-initializers -Wno-missing-prototypes -Wunreachable-code
-Wno-non-virtual-dtor -Wno-overloaded-virtual -Wno-exit-time-destructors
-Wno-missing-braces -Wparentheses -Wswitch -Wunused-function
-Wno-unused-label -Wno-unused-parameter -Wunused-variable -Wunused-value
-Wempty-body -Wuninitialized -Wno-unknown-pragmas -Wno-shadow
-Wno-four-char-constants -Wno-conversion -Wconstant-conversion
-Wint-conversion -Wbool-conversion -Wenum-conversion -Wshorten-64-to-32
-Wno-newline-eof -Wno-c++11-extensions -DLLDB_DEBUGSERVER_RELEASE -isysroot
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.12.sdk
-fasm-blocks -fstrict-aliasing -Wdeprecated-declarations -Winvalid-offsetof
-mmacosx-version-min=10.9 -g -fvisibility=hidden
-fvisibility-inlines-hidden -Wno-sign-conversion -Wno-infinite-recursion
-Wno-move 
-I/Users/buildslave/jenkins/sharedspace/lldb@2/lldb/tools/debugserver/build/debugserver.build/Release/debugserver.build/debugserver.hmap
-Isource -I../../source
-I/Users/buildslave/jenkins/sharedspace/lldb@2/lldb/tools/debugserver/build/debugserver.build/Release/debugserver.build/DerivedSources
-I../../include
-I/Users/buildslave/jenkins/sharedspace/lldb@2/lldb/tools/debugserver/build/Release/include
-I/Users/buildslave/jenkins/sharedspace/lldb@2/lldb/tools/debugserver/build/debugserver.build/Release/debugserver.build/DerivedSources/x86_64
-I/Users/buildslave/jenkins/sharedspace/lldb@2/lldb/tools/debugserver/build/debugserver.build/Release/debugserver.build/DerivedSources
-F/Users/buildslave/jenkins/sharedspace/lldb@2/lldb/tools/debugserver/build/Release
-F/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.12.sdk/System/Library/PrivateFrameworks
-Wparentheses -DDT_VARIANT_ -DHAVE_LIBZ=1 -DLLDB_USE_OS_LOG=0 -MMD -MT
dependencies -MF
/Users/buildslave/jenkins/sharedspace/lldb@2/lldb/tools/debugserver/build/debugserver.build/Release/debugserver.build/Objects-normal/x86_64/DNBDataRef.d
--serialize-diagnostics
/Users/buildslave/jenkins/sharedspace/lldb@2/lldb/tools/debugserver/build/debugserver.build/Release/debugserver.build/Objects-normal/x86_64/DNBDataRef.dia
-c 
/Users/buildslave/jenkins/sharedspace/lldb@2/lldb/tools/debugserver/source/DNBDataRef.cpp
-o 
/Users/buildslave/jenkins/sharedspace/lldb@2/lldb/tools/debugserver/build/debugserver.build/Release/debugserver.build/Objects-normal/x86_64/DNBDataRef.o
/Users/buildslave/jenkins/sharedspace/lldb@2/lldb/tools/debugserver/source/DNBDataRef.cpp:123:5:
error: use of undeclared identifier 'llvm_unreachable'
llvm_unreachable("GetMax32
unhandled case!"); ^
/Users/buildslave/jenkins/sharedspace/lldb@2/lldb/tools/debugserver/source/DNBDataRef.cpp:144:5:
error: use of undeclared identifier 'llvm_unreachable'
llvm_unreachable("GetMax64 unhandled case!"); ^ 2 errors generated.

On Thu, Jan 5, 2017 at 4:38 PM, David Blaikie via lldb-commits <
lldb-commits@lists.llvm.org> wrote:

> Author: dblaikie
> Date: Thu Jan  5 18:38:06 2017
> New Revision: 291198
>
> URL: http://llvm.org/viewvc/llvm-project?rev=291198=rev
> Log:
> Make lldb -Werror clean for -Wstring-conversion
>
> Also found/fixed one bug identified by this warning in
> RenderScriptx86ABIFixups.cpp where a string literal was being used in an
> effort to provide a name for an instruction/register, but was instead
> being passed as the bool 'isVolatile' parameter.
>
> Modified:
> lldb/trunk/include/lldb/Core/MappedHash.h
> lldb/trunk/source/Core/DataEncoder.cpp
> lldb/trunk/source/Core/ValueObjectMemory.cpp
> lldb/trunk/source/Expression/IRInterpreter.cpp
> lldb/trunk/source/Host/windows/EditLineWin.cpp
> lldb/trunk/source/Interpreter/OptionValueProperties.cpp
> lldb/trunk/source/Plugins/LanguageRuntime/RenderScript/
> RenderScriptRuntime/RenderScriptx86ABIFixups.cpp
> lldb/trunk/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp
> lldb/trunk/source/Plugins/Process/MacOSX-Kernel/ThreadKDP.cpp
> lldb/trunk/source/Plugins/Process/Utility/DynamicRegisterInfo.cpp
> lldb/trunk/source/Plugins/Process/Utility/RegisterContextLLDB.cpp
> lldb/trunk/source/Plugins/Process/gdb-remote/
> GDBRemoteCommunicationClient.cpp
> lldb/trunk/source/Plugins/ScriptInterpreter/Python/
> ScriptInterpreterPython.cpp
> 

Re: [Lldb-commits] [lldb] r290819 - [unittests] Split DWARF tests out of PDB, fix standalone build

[Tim Hammerquist via lldb-commits]

It may also be the addition of a source file not being added to the Xcode
project. This is currently handled by manual changes to the xcodeproj.

-Tim



On Tue, Jan 3, 2017 at 9:41 AM, Pavel Labath via lldb-commits <
lldb-commits@lists.llvm.org> wrote:

> I bet it's the Xcode build not replicating the
> if (LLVM_ENABLE_DIA_SDK)
>   add_subdirectory(PDB)
> endif()
> and trying to run the PDB test even though it shouldn't.
>
> (I don't really have a good idea on how to fix this.)
>
> pl
>
> On 3 January 2017 at 17:36, Zachary Turner via lldb-commits
>  wrote:
> > Hi Michal,
> > It looks like this patch may have broken this bot.
> >
> > http://lab.llvm.org:8080/green/job/lldb_build_test/23767/consoleFull#-
> 1083450927b825e790-484f-4586-af29-73c4754ff671
> >
> > What do you think?
> >
> > On Mon, Jan 2, 2017 at 10:31 AM Michal Gorny via lldb-commits
> >  wrote:
> >>
> >> Author: mgorny
> >> Date: Mon Jan  2 12:20:33 2017
> >> New Revision: 290819
> >>
> >> URL: http://llvm.org/viewvc/llvm-project?rev=290819=rev
> >> Log:
> >> [unittests] Split DWARF tests out of PDB, fix standalone build
> >>
> >> Split the PDB tests into DWARF test and actual PDB tests, the latter
> >> requiring DIA SDK. Use the new LLVMConfig.cmake LLVM_ENABLE_DIA_SDK
> >> symbol to enable the PDB tests rather than relying on
> >> llvm/Config/config.h private include file that is not available when
> >> building standalone.
> >>
> >> Differential Revision: https://reviews.llvm.org/D26249
> >>
> >> Added:
> >> lldb/trunk/unittests/SymbolFile/DWARF/
> >> lldb/trunk/unittests/SymbolFile/DWARF/CMakeLists.txt
> >> lldb/trunk/unittests/SymbolFile/DWARF/Inputs/
> >> lldb/trunk/unittests/SymbolFile/DWARF/Inputs/test-dwarf.cpp
> >>   - copied, changed from r290688,
> >> lldb/trunk/unittests/SymbolFile/PDB/Inputs/test-dwarf.cpp
> >> lldb/trunk/unittests/SymbolFile/DWARF/Inputs/test-dwarf.exe
> >>   - copied, changed from r290688,
> >> lldb/trunk/unittests/SymbolFile/PDB/Inputs/test-dwarf.exe
> >> lldb/trunk/unittests/SymbolFile/DWARF/SymbolFileDWARFTests.cpp
> >> Removed:
> >> lldb/trunk/unittests/SymbolFile/PDB/Inputs/test-dwarf.cpp
> >> lldb/trunk/unittests/SymbolFile/PDB/Inputs/test-dwarf.exe
> >> Modified:
> >> lldb/trunk/unittests/SymbolFile/CMakeLists.txt
> >> lldb/trunk/unittests/SymbolFile/PDB/CMakeLists.txt
> >> lldb/trunk/unittests/SymbolFile/PDB/SymbolFilePDBTests.cpp
> >>
> >> Modified: lldb/trunk/unittests/SymbolFile/CMakeLists.txt
> >> URL:
> >> http://llvm.org/viewvc/llvm-project/lldb/trunk/unittests/
> SymbolFile/CMakeLists.txt?rev=290819=290818=290819=diff
> >>
> >> 
> ==
> >> --- lldb/trunk/unittests/SymbolFile/CMakeLists.txt (original)
> >> +++ lldb/trunk/unittests/SymbolFile/CMakeLists.txt Mon Jan  2 12:20:33
> >> 2017
> >> @@ -1 +1,4 @@
> >> -add_subdirectory(PDB)
> >> +add_subdirectory(DWARF)
> >> +if (LLVM_ENABLE_DIA_SDK)
> >> +  add_subdirectory(PDB)
> >> +endif()
> >>
> >> Added: lldb/trunk/unittests/SymbolFile/DWARF/CMakeLists.txt
> >> URL:
> >> http://llvm.org/viewvc/llvm-project/lldb/trunk/unittests/
> SymbolFile/DWARF/CMakeLists.txt?rev=290819=auto
> >>
> >> 
> ==
> >> --- lldb/trunk/unittests/SymbolFile/DWARF/CMakeLists.txt (added)
> >> +++ lldb/trunk/unittests/SymbolFile/DWARF/CMakeLists.txt Mon Jan  2
> >> 12:20:33 2017
> >> @@ -0,0 +1,8 @@
> >> +add_lldb_unittest(SymbolFileDWARFTests
> >> +  SymbolFileDWARFTests.cpp
> >> +  )
> >> +
> >> +set(test_inputs
> >> +   test-dwarf.exe)
> >> +
> >> +add_unittest_inputs(SymbolFileDWARFTests "${test_inputs}")
> >>
> >> Copied: lldb/trunk/unittests/SymbolFile/DWARF/Inputs/test-dwarf.cpp
> (from
> >> r290688, lldb/trunk/unittests/SymbolFile/PDB/Inputs/test-dwarf.cpp)
> >> URL:
> >> http://llvm.org/viewvc/llvm-project/lldb/trunk/unittests/
> SymbolFile/DWARF/Inputs/test-dwarf.cpp?p2=lldb/trunk/
> unittests/SymbolFile/DWARF/Inputs/test-dwarf.cpp=lldb/
> trunk/unittests/SymbolFile/PDB/Inputs/test-dwarf.cpp=
> 290688=290819=290819=diff
> >>
> >> 
> ==
> >> (empty)
> >>
> >> Copied: lldb/trunk/unittests/SymbolFile/DWARF/Inputs/test-dwarf.exe
> (from
> >> r290688, lldb/trunk/unittests/SymbolFile/PDB/Inputs/test-dwarf.exe)
> >> URL:
> >> http://llvm.org/viewvc/llvm-project/lldb/trunk/unittests/
> SymbolFile/DWARF/Inputs/test-dwarf.exe?p2=lldb/trunk/
> unittests/SymbolFile/DWARF/Inputs/test-dwarf.exe=lldb/
> trunk/unittests/SymbolFile/PDB/Inputs/test-dwarf.exe=
> 290688=290819=290819=diff
> >>
> >> 
> ==
> >> (empty)
> >>
> >> Added: lldb/trunk/unittests/SymbolFile/DWARF/SymbolFileDWARFTests.cpp
> >> URL:
> >> http://llvm.org/viewvc/llvm-project/lldb/trunk/unittests/
> 

Re: [Lldb-commits] [lldb] r288542 - Update test expectations after AddressSanitizer text descriptions changed in r288535.

[Tim Hammerquist via lldb-commits]

Thanks, Kuba!

On Fri, Dec 2, 2016 at 2:11 PM, Kuba Mracek via lldb-commits <
lldb-commits@lists.llvm.org> wrote:

> Author: kuba.brecka
> Date: Fri Dec  2 16:11:26 2016
> New Revision: 288542
>
> URL: http://llvm.org/viewvc/llvm-project?rev=288542=rev
> Log:
> Update test expectations after AddressSanitizer text descriptions changed
> in r288535.
>
>
> Modified:
> lldb/trunk/packages/Python/lldbsuite/test/functionalities/asan/
> TestMemoryHistory.py
> lldb/trunk/packages/Python/lldbsuite/test/functionalities/asan/
> TestReportData.py
>
> Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/asan/
> TestMemoryHistory.py
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/
> Python/lldbsuite/test/functionalities/asan/TestMemoryHistory.py?rev=
> 288542=288541=288542=diff
> 
> ==
> --- 
> lldb/trunk/packages/Python/lldbsuite/test/functionalities/asan/TestMemoryHistory.py
> (original)
> +++ 
> lldb/trunk/packages/Python/lldbsuite/test/functionalities/asan/TestMemoryHistory.py
> Fri Dec  2 16:11:26 2016
> @@ -121,7 +121,7 @@ class AsanTestCase(TestBase):
>  "Process should be stopped due to ASan report",
>  substrs=[
>  'stopped',
> -'stop reason = Use of deallocated memory detected'])
> +'stop reason = Use of deallocated memory'])
>
>  # make sure the 'memory history' command still works even when
> we're
>  # generating a report now
>
> Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/asan/
> TestReportData.py
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/
> Python/lldbsuite/test/functionalities/asan/TestReportData.py?rev=288542&
> r1=288541=288542=diff
> 
> ==
> --- 
> lldb/trunk/packages/Python/lldbsuite/test/functionalities/asan/TestReportData.py
> (original)
> +++ 
> lldb/trunk/packages/Python/lldbsuite/test/functionalities/asan/TestReportData.py
> Fri Dec  2 16:11:26 2016
> @@ -56,7 +56,7 @@ class AsanTestReportDataCase(TestBase):
>  "Process should be stopped due to ASan report",
>  substrs=[
>  'stopped',
> -'stop reason = Use of deallocated memory detected'])
> +'stop reason = Use of deallocated memory'])
>
>  self.assertEqual(
>  self.dbg.GetSelectedTarget().process.GetSelectedThread().
> GetStopReason(),
>
>
> ___
> lldb-commits mailing list
> lldb-commits@lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
>



-- 
Tim 
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D27017: Support more report types in AddressSanitizerRuntime.cpp

[Tim Hammerquist via lldb-commits]

This commit is causing tests to fail in Darwin:

TestReportData.AsanTestReportDataCase
TestMemoryHistory.AsanTestCase

http://lab.llvm.org:8080/green/job/lldb_build_test/22768/
http://lab.llvm.org:8080/green/job/lldb_build_test/22769/

FAIL: test_dwarf (TestReportData.AsanTestReportDataCase)
--
Traceback (most recent call last):
  File 
"/Users/buildslave/jenkins/sharedspace/lldb@2/lldb/packages/Python/lldbsuite/test/lldbtest.py",
line 1723, in dwarf_test_method
return attrvalue(self)
  File 
"/Users/buildslave/jenkins/sharedspace/lldb@2/lldb/packages/Python/lldbsuite/test/decorators.py",
line 110, in wrapper
func(*args, **kwargs)
  File 
"/Users/buildslave/jenkins/sharedspace/lldb@2/lldb/packages/Python/lldbsuite/test/decorators.py",
line 140, in wrapper
func(*args, **kwargs)
  File 
"/Users/buildslave/jenkins/sharedspace/lldb@2/lldb/packages/Python/lldbsuite/test/decorators.py",
line 140, in wrapper
func(*args, **kwargs)
  File 
"/Users/buildslave/jenkins/sharedspace/lldb@2/lldb/packages/Python/lldbsuite/test/decorators.py",
line 110, in wrapper
func(*args, **kwargs)
  File 
"/Users/buildslave/jenkins/sharedspace/lldb@2/lldb/packages/Python/lldbsuite/test/functionalities/asan/TestReportData.py",
line 30, in test
self.asan_tests()
  File 
"/Users/buildslave/jenkins/sharedspace/lldb@2/lldb/packages/Python/lldbsuite/test/functionalities/asan/TestReportData.py",
line 59, in asan_tests
'stop reason = Use of deallocated memory detected'])
  File 
"/Users/buildslave/jenkins/sharedspace/lldb@2/lldb/packages/Python/lldbsuite/test/lldbtest.py",
line 2247, in expect
msg if msg else EXP_MSG(str, output, exe))
AssertionError: False is not True : Process should be stopped due to ASan
report
Config=x86_64-/Users/buildslave/jenkins/sharedspace/lldb@2
/host-compiler/bin/clang-4.0




On Fri, Dec 2, 2016 at 1:12 PM, Kuba (Brecka) Mracek via Phabricator via
lldb-commits  wrote:

> kubabrecka added a comment.
>
> Thanks for reviewing this!
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D27017
>
>
>
> ___
> lldb-commits mailing list
> lldb-commits@lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
>



-- 
Tim 
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [lldb] r288386 - Handle UTF-16 and UTF-32 constant CFStrings

[Tim Hammerquist via lldb-commits]

Thanks, Sean!

On Thu, Dec 1, 2016 at 11:25 AM, Sean Callanan  wrote:

> $ svn commit
> Sendingsource/Plugins/ExpressionParser/Clang/IRForTarget.cpp
> Transmitting file data .done
> Committing transaction...
> Committed revision 288403.
>
> Sorry for the noise, folks.
>
> Sean
>
> On Dec 1, 2016, at 11:21 AM, Sean Callanan  wrote:
>
> It'll be a fix.  ETA 10 minutes.
>
> On Dec 1, 2016, at 11:16 AM, Sean Callanan via lldb-commits <
> lldb-commits@lists.llvm.org> wrote:
>
> It's definitely this one.  I'll have a fix or a revert in the next 30
> minutes.
>
> On Dec 1, 2016, at 10:58 AM, Tim Hammerquist  wrote:
>
> Builds with this patch have been failing due to a segfaulting testcase.
> See:
>
> http://lab.llvm.org:8080/green/view/LLDB/job/lldb_build_test/22721/
> http://lab.llvm.org:8080/green/view/LLDB/job/lldb_build_test/22722/
>
> At first glance, it's possible the failure was introduced by either this
> commit (r288386) or possibly r288372.
>
> -Tim
>
>
> On Thu, Dec 1, 2016 at 9:46 AM, Sean Callanan via lldb-commits <
> lldb-commits@lists.llvm.org> wrote:
>
>> Author: spyffe
>> Date: Thu Dec  1 11:46:51 2016
>> New Revision: 288386
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=288386=rev
>> Log:
>> Handle UTF-16 and UTF-32 constant CFStrings
>>
>> We have a longstanding issue where the expression parser does not handle
>> wide CFStrings (e.g., @"凸凹") correctly, producing the useless error message
>>
>> Internal error [IRForTarget]: An Objective-C constant string's string
>> initializer is not an array
>> error: warning: expression result unused
>> error: The expression could not be prepared to run in the target
>>
>> This is just a side effect of the fact that we don't handle wide string
>> constants when converting these to CFStringCreateWithBytes. That function
>> takes the string's encoding as an argument, so I made it work and added a
>> testcase.
>>
>> https://reviews.llvm.org/D27291
>> 
>>
>> Added:
>> lldb/trunk/packages/Python/lldbsuite/test/lang/objc/unicode-string/
>> lldb/trunk/packages/Python/lldbsuite/test/lang/objc/unicode-
>> string/TestUnicodeString.py
>> lldb/trunk/packages/Python/lldbsuite/test/lang/objc/unicode-
>> string/main.m
>> Modified:
>> lldb/trunk/source/Plugins/ExpressionParser/Clang/IRForTarget.cpp
>>
>> Added: lldb/trunk/packages/Python/lldbsuite/test/lang/objc/unicode-
>> string/TestUnicodeString.py
>> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Pyth
>> on/lldbsuite/test/lang/objc/unicode-string/TestUnicodeStri
>> ng.py?rev=288386=auto
>> 
>> ==
>> --- 
>> lldb/trunk/packages/Python/lldbsuite/test/lang/objc/unicode-string/TestUnicodeString.py
>> (added)
>> +++ 
>> lldb/trunk/packages/Python/lldbsuite/test/lang/objc/unicode-string/TestUnicodeString.py
>> Thu Dec  1 11:46:51 2016
>> @@ -0,0 +1,6 @@
>> +from lldbsuite.test import lldbinline
>> +from lldbsuite.test import decorators
>> +
>> +lldbinline.MakeInlineTest(
>> +__file__, globals(), [
>> +decorators.skipUnlessDarwin])
>>
>> Added: lldb/trunk/packages/Python/lldbsuite/test/lang/objc/unicode-
>> string/main.m
>> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Pyth
>> on/lldbsuite/test/lang/objc/unicode-string/main.m?rev=288386=auto
>> 
>> ==
>> --- lldb/trunk/packages/Python/lldbsuite/test/lang/objc/unicode-string/main.m
>> (added)
>> +++ lldb/trunk/packages/Python/lldbsuite/test/lang/objc/unicode-string/main.m
>> Thu Dec  1 11:46:51 2016
>> @@ -0,0 +1,5 @@
>> +#import 
>> +
>> +int main() {
>> +  NSLog(@"凸"); //% self.expect("po @\"凹\"",
>> DATA_TYPES_DISPLAYED_CORRECTLY, substrs = ["凹"])
>> +}
>>
>> Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/IRForTarget
>> .cpp
>> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugin
>> s/ExpressionParser/Clang/IRForTarget.cpp?rev=288386=
>> 288385=288386=diff
>> 
>> ==
>> --- lldb/trunk/source/Plugins/ExpressionParser/Clang/IRForTarget.cpp
>> (original)
>> +++ lldb/trunk/source/Plugins/ExpressionParser/Clang/IRForTarget.cpp Thu
>> Dec  1 11:46:51 2016
>> @@ -498,42 +498,60 @@ bool IRForTarget::RewriteObjCConstString
>>Constant *bytes_arg = cstr ? ConstantExpr::getBitCast(cstr, i8_ptr_ty)
>>   : Constant::getNullValue(i8_ptr_ty);
>>Constant *numBytes_arg = ConstantInt::get(
>> -  m_intptr_ty, cstr ? string_array->getNumElements() - 1 : 0, false);
>> -  Constant *encoding_arg = ConstantInt::get(
>> -  i32_ty, 0x0600, false); /* 0x0600 is kCFStringEncodingASCII */
>> -  Constant *isExternal_arg =
>> -  ConstantInt::get(i8_ty, 0x0, false); /* 0x0 is false */
>> -
>> -  Value *argument_array[5];
>> -
>> -  argument_array[0] = alloc_arg;
>> -  

Re: [Lldb-commits] [lldb] r288386 - Handle UTF-16 and UTF-32 constant CFStrings

[Tim Hammerquist via lldb-commits]

Builds with this patch have been failing due to a segfaulting testcase. See:

http://lab.llvm.org:8080/green/view/LLDB/job/lldb_build_test/22721/
http://lab.llvm.org:8080/green/view/LLDB/job/lldb_build_test/22722/

At first glance, it's possible the failure was introduced by either this
commit (r288386) or possibly r288372.

-Tim


On Thu, Dec 1, 2016 at 9:46 AM, Sean Callanan via lldb-commits <
lldb-commits@lists.llvm.org> wrote:

> Author: spyffe
> Date: Thu Dec  1 11:46:51 2016
> New Revision: 288386
>
> URL: http://llvm.org/viewvc/llvm-project?rev=288386=rev
> Log:
> Handle UTF-16 and UTF-32 constant CFStrings
>
> We have a longstanding issue where the expression parser does not handle
> wide CFStrings (e.g., @"凸凹") correctly, producing the useless error message
>
> Internal error [IRForTarget]: An Objective-C constant string's string
> initializer is not an array
> error: warning: expression result unused
> error: The expression could not be prepared to run in the target
>
> This is just a side effect of the fact that we don't handle wide string
> constants when converting these to CFStringCreateWithBytes. That function
> takes the string's encoding as an argument, so I made it work and added a
> testcase.
>
> https://reviews.llvm.org/D27291
> 
>
> Added:
> lldb/trunk/packages/Python/lldbsuite/test/lang/objc/unicode-string/
> lldb/trunk/packages/Python/lldbsuite/test/lang/objc/unicode-string/
> TestUnicodeString.py
> lldb/trunk/packages/Python/lldbsuite/test/lang/objc/
> unicode-string/main.m
> Modified:
> lldb/trunk/source/Plugins/ExpressionParser/Clang/IRForTarget.cpp
>
> Added: lldb/trunk/packages/Python/lldbsuite/test/lang/objc/unicode-string/
> TestUnicodeString.py
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/
> Python/lldbsuite/test/lang/objc/unicode-string/TestUnicodeString.py?rev=
> 288386=auto
> 
> ==
> --- 
> lldb/trunk/packages/Python/lldbsuite/test/lang/objc/unicode-string/TestUnicodeString.py
> (added)
> +++ 
> lldb/trunk/packages/Python/lldbsuite/test/lang/objc/unicode-string/TestUnicodeString.py
> Thu Dec  1 11:46:51 2016
> @@ -0,0 +1,6 @@
> +from lldbsuite.test import lldbinline
> +from lldbsuite.test import decorators
> +
> +lldbinline.MakeInlineTest(
> +__file__, globals(), [
> +decorators.skipUnlessDarwin])
>
> Added: lldb/trunk/packages/Python/lldbsuite/test/lang/objc/
> unicode-string/main.m
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/
> Python/lldbsuite/test/lang/objc/unicode-string/main.m?rev=288386=auto
> 
> ==
> --- lldb/trunk/packages/Python/lldbsuite/test/lang/objc/unicode-string/main.m
> (added)
> +++ lldb/trunk/packages/Python/lldbsuite/test/lang/objc/unicode-string/main.m
> Thu Dec  1 11:46:51 2016
> @@ -0,0 +1,5 @@
> +#import 
> +
> +int main() {
> +  NSLog(@"凸"); //% self.expect("po @\"凹\"", 
> DATA_TYPES_DISPLAYED_CORRECTLY,
> substrs = ["凹"])
> +}
>
> Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/IRForTarget.cpp
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/
> Plugins/ExpressionParser/Clang/IRForTarget.cpp?rev=
> 288386=288385=288386=diff
> 
> ==
> --- lldb/trunk/source/Plugins/ExpressionParser/Clang/IRForTarget.cpp
> (original)
> +++ lldb/trunk/source/Plugins/ExpressionParser/Clang/IRForTarget.cpp Thu
> Dec  1 11:46:51 2016
> @@ -498,42 +498,60 @@ bool IRForTarget::RewriteObjCConstString
>Constant *bytes_arg = cstr ? ConstantExpr::getBitCast(cstr, i8_ptr_ty)
>   : Constant::getNullValue(i8_ptr_ty);
>Constant *numBytes_arg = ConstantInt::get(
> -  m_intptr_ty, cstr ? string_array->getNumElements() - 1 : 0, false);
> -  Constant *encoding_arg = ConstantInt::get(
> -  i32_ty, 0x0600, false); /* 0x0600 is kCFStringEncodingASCII */
> -  Constant *isExternal_arg =
> -  ConstantInt::get(i8_ty, 0x0, false); /* 0x0 is false */
> -
> -  Value *argument_array[5];
> -
> -  argument_array[0] = alloc_arg;
> -  argument_array[1] = bytes_arg;
> -  argument_array[2] = numBytes_arg;
> -  argument_array[3] = encoding_arg;
> -  argument_array[4] = isExternal_arg;
> -
> -  ArrayRef CFSCWB_arguments(argument_array, 5);
> -
> -  FunctionValueCache CFSCWB_Caller(
> -  [this, _arguments](llvm::Function *function) -> llvm::Value
> * {
> -return CallInst::Create(
> -m_CFStringCreateWithBytes, CFSCWB_arguments,
> -"CFStringCreateWithBytes",
> -llvm::cast(
> -m_entry_instruction_finder.GetValue(function)));
> -  });
> -
> -  if (!UnfoldConstant(ns_str, nullptr, CFSCWB_Caller,
> -  m_entry_instruction_finder, m_error_stream)) {
> -if (log)
> -  log->PutCString(
> -  "Couldn't replace the NSString with the result of the 

Re: [Lldb-commits] [lldb] r286479 - Unify Darwin and Non-Darwin printing of version output

[Tim Hammerquist via lldb-commits]

Thanks, Chris!

On Thu, Nov 10, 2016 at 2:22 PM, Todd Fiala  wrote:

> Okay cool, thanks Chris!
>
> -Todd
>
> On Nov 10, 2016, at 1:40 PM, Chris Bieneman  wrote:
>
> I just pushed r286504, which expects the string to not be quoted. This
> should solve the bot failures.
>
> -Chris
>
> On Nov 10, 2016, at 1:30 PM, Todd Fiala  wrote:
>
> I'm at a point where I can look at it.
>
> On Thu, Nov 10, 2016 at 12:17 PM, Tim Hammerquist 
> wrote:
>
>> Looks like the quotes around the lldb version string aren't properly
>> preserved in the xcodeproj file as they are in CMake.
>>
>> Can any of the LLDB devs more comfortable with plumbing the depths of
>> Xcode project configuration provide some guidance here?
>>
>> http://lab.llvm.org:8080/green/job/lldb_build_test/21828/
>>
>> /Users/buildslave/jenkins/sharedspace/lldb@2/lldb/source/lldb.cpp:63:22:
>> error: unexpected namespace name 'lldb': expected expression
>> g_version_str += LLDB_VERSION_STRING;
>>  ^
>> In file included from :356:
>> :4:29: note: expanded from here
>> #define LLDB_VERSION_STRING lldb-360.99.0
>> ^
>> /Users/buildslave/jenkins/sharedspace/lldb@2/lldb/source/lldb.cpp:63:22:
>> error: invalid suffix '.0' on floating constant
>> In file included from :356:
>> :4:40: note: expanded from here
>> #define LLDB_VERSION_STRING lldb-360.99.0
>>^
>> 2 errors generated.
>>
>>
>> On Thu, Nov 10, 2016 at 9:33 AM, Chris Bieneman via lldb-commits <
>> lldb-commits@lists.llvm.org> wrote:
>>
>>> Author: cbieneman
>>> Date: Thu Nov 10 11:33:19 2016
>>> New Revision: 286479
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=286479=rev
>>> Log:
>>> Unify Darwin and Non-Darwin printing of version output
>>>
>>> Summary:
>>> This change unifies and simplifies the code paths between the Darwin and
>>> non-Darwin code to print the LLDB version information.
>>>
>>> It also introduces a new variable in CMake LLDB_VERSION_STRING which can
>>> be used to specify custom version information. On Darwin this value is
>>> implicitly set based on the resource/LLDB-Info.plist file.
>>>
>>> With the LLDB_VERSION_STRING variable set to lldb-360.99.0, the -version
>>> output is:
>>>
>>> > ./bin/lldb -version
>>> lldb version 4.0.0 (lldb-360.99.0)
>>>   clang revision 286264
>>>   llvm revision 286265
>>>
>>> This behavior is unified across all target platforms.
>>>
>>> Reviewers: lldb-commits
>>>
>>> Subscribers: mgorny, tfiala
>>>
>>> Differential Revision: https://reviews.llvm.org/D26478
>>>
>>> Added:
>>> lldb/trunk/cmake/modules/EmbedAppleVersion.cmake
>>> Modified:
>>> lldb/trunk/lldb.xcodeproj/project.pbxproj
>>> lldb/trunk/source/CMakeLists.txt
>>> lldb/trunk/source/lldb.cpp
>>>
>>> Added: lldb/trunk/cmake/modules/EmbedAppleVersion.cmake
>>> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/cmake/modules
>>> /EmbedAppleVersion.cmake?rev=286479=auto
>>> 
>>> ==
>>> --- lldb/trunk/cmake/modules/EmbedAppleVersion.cmake (added)
>>> +++ lldb/trunk/cmake/modules/EmbedAppleVersion.cmake Thu Nov 10
>>> 11:33:19 2016
>>> @@ -0,0 +1,11 @@
>>> +execute_process(COMMAND /usr/libexec/PlistBuddy -c
>>> "Print:CFBundleVersion" ${LLDB_INFO_PLIST}
>>> +OUTPUT_VARIABLE BundleVersion
>>> +OUTPUT_STRIP_TRAILING_WHITESPACE)
>>> +
>>> +file(APPEND "${HEADER_FILE}.tmp"
>>> +"#define LLDB_VERSION_STRING \"lldb-${BundleVersion}\"\n")
>>> +
>>> +execute_process(COMMAND ${CMAKE_COMMAND} -E copy_if_different
>>> +  "${HEADER_FILE}.tmp" "${HEADER_FILE}")
>>> +
>>> +file(REMOVE "${HEADER_FILE}.tmp")
>>>
>>> Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
>>> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/lldb.xcodepro
>>> j/project.pbxproj?rev=286479=286478=286479=diff
>>> 
>>> ==
>>> --- lldb/trunk/lldb.xcodeproj/project.pbxproj (original)
>>> +++ lldb/trunk/lldb.xcodeproj/project.pbxproj Thu Nov 10 11:33:19 2016
>>> @@ -8775,6 +8775,20 @@
>>> "\"$(SYSTEM_LIBRARY_DIR)/Priva
>>> teFrameworks\"",
>>> );
>>> GCC_INLINES_ARE_PRIVATE_EXTERN = NO;
>>> +   GCC_PREPROCESSOR_DEFINITIONS = (
>>> +   __STDC_CONSTANT_MACROS,
>>> +   __STDC_LIMIT_MACROS,
>>> +   LLDB_CONFIGURATION_DEBUG,
>>> +   "LLDB_VERSION_STRING=\"lldb-$
>>> {CURRENT_PROJECT_VERSION}\"",
>>> +   );
>>> +   
>>> "GCC_PREPROCESSOR_DEFINITIONS[sdk=iphoneos*][arch=*]"
>>> = (
>>> +   __STDC_CONSTANT_MACROS,
>>> +  

Re: [Lldb-commits] [lldb] r286479 - Unify Darwin and Non-Darwin printing of version output

[Tim Hammerquist via lldb-commits]

Failing differently here. Progress!

2016-11-10 13:47:14.203 xcodebuild[65554:42448173] Error
Domain=NSCocoaErrorDomain Code=3840 "Unexpected character / at line 1"
UserInfo={NSDebugDescription=Unexpected character / at line 1,
kCFPropertyListOldStyleParsingError=Error Domain=NSCocoaErrorDomain
Code=3840 "Expected terminating ')' for array at line 8782"
UserInfo={NSDebugDescription=Expected terminating ')' for array at line
8782}} xcodebuild: error: Unable to read project 'lldb.xcodeproj'. Reason:
Project /Users/buildslave/jenkins/sharedspace/lldb@2/lldb/lldb.xcodeproj
cannot be opened because the project file cannot be parsed.


On Thu, Nov 10, 2016 at 1:40 PM, Chris Bieneman  wrote:

> I just pushed r286504, which expects the string to not be quoted. This
> should solve the bot failures.
>
> -Chris
>
> On Nov 10, 2016, at 1:30 PM, Todd Fiala  wrote:
>
> I'm at a point where I can look at it.
>
> On Thu, Nov 10, 2016 at 12:17 PM, Tim Hammerquist 
> wrote:
>
>> Looks like the quotes around the lldb version string aren't properly
>> preserved in the xcodeproj file as they are in CMake.
>>
>> Can any of the LLDB devs more comfortable with plumbing the depths of
>> Xcode project configuration provide some guidance here?
>>
>> http://lab.llvm.org:8080/green/job/lldb_build_test/21828/
>>
>> /Users/buildslave/jenkins/sharedspace/lldb@2/lldb/source/lldb.cpp:63:22:
>> error: unexpected namespace name 'lldb': expected expression
>> g_version_str += LLDB_VERSION_STRING;
>>  ^
>> In file included from :356:
>> :4:29: note: expanded from here
>> #define LLDB_VERSION_STRING lldb-360.99.0
>> ^
>> /Users/buildslave/jenkins/sharedspace/lldb@2/lldb/source/lldb.cpp:63:22:
>> error: invalid suffix '.0' on floating constant
>> In file included from :356:
>> :4:40: note: expanded from here
>> #define LLDB_VERSION_STRING lldb-360.99.0
>>^
>> 2 errors generated.
>>
>>
>> On Thu, Nov 10, 2016 at 9:33 AM, Chris Bieneman via lldb-commits <
>> lldb-commits@lists.llvm.org> wrote:
>>
>>> Author: cbieneman
>>> Date: Thu Nov 10 11:33:19 2016
>>> New Revision: 286479
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=286479=rev
>>> Log:
>>> Unify Darwin and Non-Darwin printing of version output
>>>
>>> Summary:
>>> This change unifies and simplifies the code paths between the Darwin and
>>> non-Darwin code to print the LLDB version information.
>>>
>>> It also introduces a new variable in CMake LLDB_VERSION_STRING which can
>>> be used to specify custom version information. On Darwin this value is
>>> implicitly set based on the resource/LLDB-Info.plist file.
>>>
>>> With the LLDB_VERSION_STRING variable set to lldb-360.99.0, the -version
>>> output is:
>>>
>>> > ./bin/lldb -version
>>> lldb version 4.0.0 (lldb-360.99.0)
>>>   clang revision 286264
>>>   llvm revision 286265
>>>
>>> This behavior is unified across all target platforms.
>>>
>>> Reviewers: lldb-commits
>>>
>>> Subscribers: mgorny, tfiala
>>>
>>> Differential Revision: https://reviews.llvm.org/D26478
>>>
>>> Added:
>>> lldb/trunk/cmake/modules/EmbedAppleVersion.cmake
>>> Modified:
>>> lldb/trunk/lldb.xcodeproj/project.pbxproj
>>> lldb/trunk/source/CMakeLists.txt
>>> lldb/trunk/source/lldb.cpp
>>>
>>> Added: lldb/trunk/cmake/modules/EmbedAppleVersion.cmake
>>> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/cmake/modules
>>> /EmbedAppleVersion.cmake?rev=286479=auto
>>> 
>>> ==
>>> --- lldb/trunk/cmake/modules/EmbedAppleVersion.cmake (added)
>>> +++ lldb/trunk/cmake/modules/EmbedAppleVersion.cmake Thu Nov 10
>>> 11:33:19 2016
>>> @@ -0,0 +1,11 @@
>>> +execute_process(COMMAND /usr/libexec/PlistBuddy -c
>>> "Print:CFBundleVersion" ${LLDB_INFO_PLIST}
>>> +OUTPUT_VARIABLE BundleVersion
>>> +OUTPUT_STRIP_TRAILING_WHITESPACE)
>>> +
>>> +file(APPEND "${HEADER_FILE}.tmp"
>>> +"#define LLDB_VERSION_STRING \"lldb-${BundleVersion}\"\n")
>>> +
>>> +execute_process(COMMAND ${CMAKE_COMMAND} -E copy_if_different
>>> +  "${HEADER_FILE}.tmp" "${HEADER_FILE}")
>>> +
>>> +file(REMOVE "${HEADER_FILE}.tmp")
>>>
>>> Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
>>> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/lldb.xcodepro
>>> j/project.pbxproj?rev=286479=286478=286479=diff
>>> 
>>> ==
>>> --- lldb/trunk/lldb.xcodeproj/project.pbxproj (original)
>>> +++ lldb/trunk/lldb.xcodeproj/project.pbxproj Thu Nov 10 11:33:19 2016
>>> @@ -8775,6 +8775,20 @@
>>> "\"$(SYSTEM_LIBRARY_DIR)/Priva
>>> teFrameworks\"",
>>> );
>>> GCC_INLINES_ARE_PRIVATE_EXTERN = NO;
>>> +   GCC_PREPROCESSOR_DEFINITIONS = (
>>> +  

Re: [Lldb-commits] [lldb] r286479 - Unify Darwin and Non-Darwin printing of version output

[Tim Hammerquist via lldb-commits]

Looks like the quotes around the lldb version string aren't properly
preserved in the xcodeproj file as they are in CMake.

Can any of the LLDB devs more comfortable with plumbing the depths of Xcode
project configuration provide some guidance here?

http://lab.llvm.org:8080/green/job/lldb_build_test/21828/

/Users/buildslave/jenkins/sharedspace/lldb@2/lldb/source/lldb.cpp:63:22:
error: unexpected namespace name 'lldb': expected expression
g_version_str += LLDB_VERSION_STRING;
 ^
In file included from :356:
:4:29: note: expanded from here
#define LLDB_VERSION_STRING lldb-360.99.0
^
/Users/buildslave/jenkins/sharedspace/lldb@2/lldb/source/lldb.cpp:63:22:
error: invalid suffix '.0' on floating constant
In file included from :356:
:4:40: note: expanded from here
#define LLDB_VERSION_STRING lldb-360.99.0
   ^
2 errors generated.


On Thu, Nov 10, 2016 at 9:33 AM, Chris Bieneman via lldb-commits <
lldb-commits@lists.llvm.org> wrote:

> Author: cbieneman
> Date: Thu Nov 10 11:33:19 2016
> New Revision: 286479
>
> URL: http://llvm.org/viewvc/llvm-project?rev=286479=rev
> Log:
> Unify Darwin and Non-Darwin printing of version output
>
> Summary:
> This change unifies and simplifies the code paths between the Darwin and
> non-Darwin code to print the LLDB version information.
>
> It also introduces a new variable in CMake LLDB_VERSION_STRING which can
> be used to specify custom version information. On Darwin this value is
> implicitly set based on the resource/LLDB-Info.plist file.
>
> With the LLDB_VERSION_STRING variable set to lldb-360.99.0, the -version
> output is:
>
> > ./bin/lldb -version
> lldb version 4.0.0 (lldb-360.99.0)
>   clang revision 286264
>   llvm revision 286265
>
> This behavior is unified across all target platforms.
>
> Reviewers: lldb-commits
>
> Subscribers: mgorny, tfiala
>
> Differential Revision: https://reviews.llvm.org/D26478
>
> Added:
> lldb/trunk/cmake/modules/EmbedAppleVersion.cmake
> Modified:
> lldb/trunk/lldb.xcodeproj/project.pbxproj
> lldb/trunk/source/CMakeLists.txt
> lldb/trunk/source/lldb.cpp
>
> Added: lldb/trunk/cmake/modules/EmbedAppleVersion.cmake
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/cmake/
> modules/EmbedAppleVersion.cmake?rev=286479=auto
> 
> ==
> --- lldb/trunk/cmake/modules/EmbedAppleVersion.cmake (added)
> +++ lldb/trunk/cmake/modules/EmbedAppleVersion.cmake Thu Nov 10 11:33:19
> 2016
> @@ -0,0 +1,11 @@
> +execute_process(COMMAND /usr/libexec/PlistBuddy -c
> "Print:CFBundleVersion" ${LLDB_INFO_PLIST}
> +OUTPUT_VARIABLE BundleVersion
> +OUTPUT_STRIP_TRAILING_WHITESPACE)
> +
> +file(APPEND "${HEADER_FILE}.tmp"
> +"#define LLDB_VERSION_STRING \"lldb-${BundleVersion}\"\n")
> +
> +execute_process(COMMAND ${CMAKE_COMMAND} -E copy_if_different
> +  "${HEADER_FILE}.tmp" "${HEADER_FILE}")
> +
> +file(REMOVE "${HEADER_FILE}.tmp")
>
> Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/lldb.
> xcodeproj/project.pbxproj?rev=286479=286478=286479=diff
> 
> ==
> --- lldb/trunk/lldb.xcodeproj/project.pbxproj (original)
> +++ lldb/trunk/lldb.xcodeproj/project.pbxproj Thu Nov 10 11:33:19 2016
> @@ -8775,6 +8775,20 @@
> "\"$(SYSTEM_LIBRARY_DIR)/
> PrivateFrameworks\"",
> );
> GCC_INLINES_ARE_PRIVATE_EXTERN = NO;
> +   GCC_PREPROCESSOR_DEFINITIONS = (
> +   __STDC_CONSTANT_MACROS,
> +   __STDC_LIMIT_MACROS,
> +   LLDB_CONFIGURATION_DEBUG,
> +   "LLDB_VERSION_STRING=\"lldb-${
> CURRENT_PROJECT_VERSION}\"",
> +   );
> +   
> "GCC_PREPROCESSOR_DEFINITIONS[sdk=iphoneos*][arch=*]"
> = (
> +   __STDC_CONSTANT_MACROS,
> +   __STDC_LIMIT_MACROS,
> +   LLDB_CONFIGURATION_DEBUG,
> +   LLDB_DISABLE_PYTHON,
> +   NO_XPC_SERVICES,
> +   "LLDB_VERSION_STRING=\"lldb-${
> CURRENT_PROJECT_VERSION}\"",
> +   );
> HEADER_SEARCH_PATHS = /usr/include/libxml2;
> LLDB_COMPRESSION_CFLAGS = "";
> "LLDB_COMPRESSION_CFLAGS[sdk=macosx10.11]"
> = "-DHAVE_LIBCOMPRESSION=1";
> @@ -8820,6 +8834,20 @@
> "\"$(SYSTEM_LIBRARY_DIR)/
> PrivateFrameworks\"",
>

Re: [Lldb-commits] [lldb] r285068 - Revert "Improve the libstdc++ smart pointer formatters"

[Tim Hammerquist via lldb-commits]

Hi Pavel,

Looks like some code left after this revert is still expecting this file
(added contemporary to r284828) that was removed in this revision.

--- lldb/trunk/source/Plugins/Language/CPlusPlus/LibStdcppSmartPointer.cpp
(original)
+++ lldb/trunk/source/Plugins/Language/CPlusPlus/LibStdcppSmartPointer.cpp
(removed)

This is causing the build to break. Does this require additional changes,
or perhaps further reverts?

-Tim


On Tue, Oct 25, 2016 at 6:24 AM, Pavel Labath via lldb-commits <
lldb-commits@lists.llvm.org> wrote:

> Author: labath
> Date: Tue Oct 25 08:24:53 2016
> New Revision: 285068
>
> URL: http://llvm.org/viewvc/llvm-project?rev=285068=rev
> Log:
> Revert "Improve the libstdc++ smart pointer formatters"
>
> This reverts commit r284828, as it causes an infinite loop in
> TestPrintStackTraces (funnily enough, only when logging is enabled).
>
> Removed:
> lldb/trunk/source/Plugins/Language/CPlusPlus/LibStdcppSmartPointer.cpp
> Modified:
> lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-
> formatter/data-formatter-stl/libstdcpp/smart_ptr/Makefile
> lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-
> formatter/data-formatter-stl/libstdcpp/smart_ptr/
> TestDataFormatterStdSmartPtr.py
> lldb/trunk/source/Plugins/Language/CPlusPlus/CMakeLists.txt
> lldb/trunk/source/Plugins/Language/CPlusPlus/LibStdcpp.cpp
>
> Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-
> formatter/data-formatter-stl/libstdcpp/smart_ptr/Makefile
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/
> Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/
> libstdcpp/smart_ptr/Makefile?rev=285068=285067=285068=diff
> 
> ==
> --- lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-
> formatter/data-formatter-stl/libstdcpp/smart_ptr/Makefile (original)
> +++ lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-
> formatter/data-formatter-stl/libstdcpp/smart_ptr/Makefile Tue Oct 25
> 08:24:53 2016
> @@ -2,7 +2,14 @@ LEVEL = ../../../../../make
>
>  CXX_SOURCES := main.cpp
>
> +CXXFLAGS := -O0
>  USE_LIBSTDCPP := 1
> -CFLAGS_EXTRAS += $(NO_LIMIT_DEBUG_INFO_FLAGS)
> +
> +# clang-3.5+ outputs FullDebugInfo by default for Darwin/FreeBSD
> +# targets.  Other targets do not, which causes this test to fail.
> +# This flag enables FullDebugInfo for all targets.
> +ifneq (,$(findstring clang,$(CC)))
> +  CFLAGS_EXTRAS += -fno-limit-debug-info
> +endif
>
>  include $(LEVEL)/Makefile.rules
>
> Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-
> formatter/data-formatter-stl/libstdcpp/smart_ptr/
> TestDataFormatterStdSmartPtr.py
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/
> Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/
> libstdcpp/smart_ptr/TestDataFormatterStdSmartPtr.
> py?rev=285068=285067=285068=diff
> 
> ==
> --- lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-
> formatter/data-formatter-stl/libstdcpp/smart_ptr/
> TestDataFormatterStdSmartPtr.py (original)
> +++ lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-
> formatter/data-formatter-stl/libstdcpp/smart_ptr/
> TestDataFormatterStdSmartPtr.py Tue Oct 25 08:24:53 2016
> @@ -31,58 +31,19 @@ class StdSmartPtrDataFormatterTestCase(T
>  substrs=['stopped', 'stop reason = breakpoint'])
>
>  self.expect("frame variable nsp", substrs=['nsp = nullptr'])
> -self.expect("frame variable isp", substrs=['isp = 123',
> 'strong=1', 'weak=1'])
> -self.expect("frame variable ssp", substrs=['ssp = "foobar"',
> 'strong=1', 'weak=1'])
> -self.expect("frame variable nwp", substrs=['nwp = nullptr'])
> -self.expect("frame variable iwp", substrs=['iwp = 123',
> 'strong=1', 'weak=1'])
> -self.expect("frame variable swp", substrs=['swp = "foobar"',
> 'strong=1', 'weak=1'])
> -
> -frame = self.frame()
> -self.assertTrue(frame.IsValid())
> -
> -self.assertEqual(0, frame.GetValueForVariablePath("nsp.pointer").
> GetValueAsUnsigned())
> -self.assertEqual(0, frame.GetValueForVariablePath("nwp.pointer").
> GetValueAsUnsigned())
> -
> -self.assertNotEqual(0, frame.GetValueForVariablePath(
> "isp.pointer").GetValueAsUnsigned())
> -self.assertEqual(123, frame.GetValueForVariablePath(
> "isp.object").GetValueAsUnsigned())
> -self.assertEqual(1, frame.GetValueForVariablePath("isp.count").
> GetValueAsUnsigned())
> -self.assertEqual(1, frame.GetValueForVariablePath(
> "isp.weak_count").GetValueAsUnsigned())
> -self.assertFalse(frame.GetValueForVariablePath("isp.
> foobar").IsValid())
> +self.expect("frame variable isp", substrs=['isp = 123'])
> +self.expect("frame variable ssp", substrs=['ssp = 

[Lldb-commits] [lldb] r283082 - Fix regex in lldb lit test TestCallStopAndContinue

[Tim Hammerquist via lldb-commits]

Author: penryu
Date: Sun Oct  2 19:07:24 2016
New Revision: 283082

URL: http://llvm.org/viewvc/llvm-project?rev=283082=rev
Log:
Fix regex in lldb lit test TestCallStopAndContinue

https://reviews.llvm.org/D25167

Modified:
lldb/trunk/lit/Expr/TestCallStopAndContinue.test

Modified: lldb/trunk/lit/Expr/TestCallStopAndContinue.test
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/lit/Expr/TestCallStopAndContinue.test?rev=283082=283081=283082=diff
==
--- lldb/trunk/lit/Expr/TestCallStopAndContinue.test (original)
+++ lldb/trunk/lit/Expr/TestCallStopAndContinue.test Sun Oct  2 19:07:24 2016
@@ -9,4 +9,4 @@ breakpoint set --file call-function.cpp
 expression -i false -- returnsFive()
 # CHECK: Execution was interrupted, reason: breakpoint
 # CHECK: stop reason = User Expression thread plan
-# CHECK: Completed expression: (Five) $0 = (number = 5 {{.*}}, name = "five")
+# CHECK: Completed expression: (Five) $0 = (number = 5{{.*}}, name = "five")


___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [lldb] r282529 - Adding a RegisterContextMinidump_x86_64 converter

[Tim Hammerquist via lldb-commits]

Yep, looks like r282565 fixed the llvm.org tests, but broke another bot.
r282566 fixed the other bot, but broke the llvm.org tests again.

http://lab.llvm.org:8080/green/view/LLDB/job/lldb_build_test/20757/

On Wed, Sep 28, 2016 at 1:48 PM, Tim Hammerquist  wrote:

> Looks like there was some work to address this in r282565 here:
>
> http://lab.llvm.org:8080/green/view/LLDB/job/lldb_build_test/20756/
>
> However, the issue occurred again on the very next run.
>
> On Wed, Sep 28, 2016 at 1:41 PM, Tim Hammerquist  wrote:
>
>> This change seems to have introduced a linker failure while building the
>> gtest suite:
>>
>>
>> Ld build/Release/lldb-gtest normal x86_64
>> cd "/Users/buildslave/jenkins/sharedspace/lldb@2/lldb"
>> export MACOSX_DEPLOYMENT_TARGET=10.9
>> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeD
>> efault.xctoolchain/usr/bin/clang++ -arch x86_64 -isysroot
>> /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.
>> platform/Developer/SDKs/MacOSX10.11.sdk -L/Users/buildslave/jenkins/sh
>> aredspace/lldb@2/lldb/build/Release -F/Users/buildslave/jenkins/sh
>> aredspace/lldb@2/lldb/build/Release -F/Applications/Xcode.app/Cont
>> ents/Developer/Platforms/MacOSX.platform/Developer/SDKs/
>> MacOSX10.11.sdk/System/Library/PrivateFrameworks
>> -F/Applications/Xcode.app/Contents/Developer/Platforms/MacOS
>> X.platform/Developer/SDKs/MacOSX10.11.sdk/System/Library
>> /Frameworks/CoreServices.framework/Frameworks -filelist
>> /Users/buildslave/jenkins/sharedspace/lldb@2/lldb/build/lldb
>> .build/Release/lldb-gtest-build.build/Objects-normal/x86_64/lldb-gtest.LinkFileList
>> -mmacosx-version-min=10.9 -weak-lcompression -lz -filelist
>> /Users/buildslave/jenkins/sharedspace/lldb@2/lldb/llvm-build/Release+Asserts/archives.txt
>> -framework Foundation -framework DebugSymbols -framework Security
>> -framework CoreServices -framework ApplicationServices
>> /Users/buildslave/jenkins/sharedspace/lldb@2/lldb/llvm-build
>> /Release+Asserts/x86_64/lib/libgtest.a -L 
>> /System/Library/Frameworks/Python.framework/Versions/2.7/lib
>> -l python2.7 -stdlib=libc++ -lxml2.2 -lpanel -ledit -lz -lncurses
>> /Users/buildslave/jenkins/sharedspace/lldb@2/lldb/build/Release/liblldb-core.a
>> -Xlinker -dependency_info -Xlinker /Users/buildslave/jenkins/shar
>> edspace/lldb@2/lldb/build/lldb.build/Release/lldb-gtest-buil
>> d.build/Objects-normal/x86_64/lldb-gtest_dependency_info.dat -o
>> /Users/buildslave/jenkins/sharedspace/lldb@2/lldb/build/Rele
>> ase/lldb-gtest
>> Undefined symbols for architecture x86_64:
>>   
>> "lldb_private::minidump::ConvertMinidumpContextToRegIface(llvm::ArrayRef> char>, lldb_private::RegisterInfoInterface*)", referenced from:
>>   MinidumpParserTest_ConvertRegisterContext_Test::TestBody() in
>> MinidumpParserTest.o
>> ld: symbol(s) not found for architecture x86_64
>>
>>
>> It first struck yesterday afternoon:
>>
>> http://lab.llvm.org:8080/green/view/LLDB/job/lldb_build_
>> test/20745/console
>>
>> and recurring through today:
>>
>> http://lab.llvm.org:8080/green/view/LLDB/job/lldb_build_
>> test/20770/console
>>
>> Is there a change that needs to be made to the test suite to address this?
>>
>>
>> On Tue, Sep 27, 2016 at 12:05 PM, Dimitar Vlahovski via lldb-commits <
>> lldb-commits@lists.llvm.org> wrote:
>>
>>> Author: dvlahovski
>>> Date: Tue Sep 27 14:05:55 2016
>>> New Revision: 282529
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=282529=rev
>>> Log:
>>> Adding a RegisterContextMinidump_x86_64 converter
>>>
>>> Summary:
>>> This is a register context converter from Minidump to Linux reg context.
>>> This knows the layout of the register context in the Minidump file
>>> (which is the same as in Windows FYI) and as a result emits a binary data
>>> buffer that matches the Linux register context binary layout.
>>> This way we can reuse the existing RegisterContextLinux_x86_64 and
>>> RegisterContextCorePOSIX_x86_64 classes.
>>>
>>> Reviewers: labath, zturner
>>>
>>> Subscribers: beanz, mgorny, lldb-commits, amccarth
>>>
>>> Differential Revision: https://reviews.llvm.org/D24919
>>>
>>> Added:
>>> lldb/trunk/source/Plugins/Process/minidump/RegisterContextMi
>>> nidump_x86_64.cpp
>>> lldb/trunk/source/Plugins/Process/minidump/RegisterContextMi
>>> nidump_x86_64.h
>>> Modified:
>>> lldb/trunk/include/lldb/lldb-private-types.h
>>> lldb/trunk/source/Plugins/Process/minidump/CMakeLists.txt
>>> lldb/trunk/source/Plugins/Process/minidump/MinidumpParser.cpp
>>> lldb/trunk/source/Plugins/Process/minidump/MinidumpParser.h
>>> lldb/trunk/unittests/Process/minidump/MinidumpParserTest.cpp
>>>
>>> Modified: lldb/trunk/include/lldb/lldb-private-types.h
>>> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/
>>> lldb-private-types.h?rev=282529=282528=282529=diff
>>> 
>>> ==
>>> --- 

Re: [Lldb-commits] [lldb] r282529 - Adding a RegisterContextMinidump_x86_64 converter

[Tim Hammerquist via lldb-commits]

Looks like there was some work to address this in r282565 here:

http://lab.llvm.org:8080/green/view/LLDB/job/lldb_build_test/20756/

However, the issue occurred again on the very next run.

On Wed, Sep 28, 2016 at 1:41 PM, Tim Hammerquist  wrote:

> This change seems to have introduced a linker failure while building the
> gtest suite:
>
>
> Ld build/Release/lldb-gtest normal x86_64
> cd "/Users/buildslave/jenkins/sharedspace/lldb@2/lldb"
> export MACOSX_DEPLOYMENT_TARGET=10.9
> /Applications/Xcode.app/Contents/Developer/Toolchains/
> XcodeDefault.xctoolchain/usr/bin/clang++ -arch x86_64 -isysroot
> /Applications/Xcode.app/Contents/Developer/Platforms/
> MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk
> -L/Users/buildslave/jenkins/sharedspace/lldb@2/lldb/build/Release
> -F/Users/buildslave/jenkins/sharedspace/lldb@2/lldb/build/Release
> -F/Applications/Xcode.app/Contents/Developer/Platforms/
> MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk/System/Library/PrivateFrameworks
> -F/Applications/Xcode.app/Contents/Developer/Platforms/
> MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk/System/Library/Frameworks/
> CoreServices.framework/Frameworks -filelist /Users/buildslave/jenkins/
> sharedspace/lldb@2/lldb/build/lldb.build/Release/lldb-gtest-
> build.build/Objects-normal/x86_64/lldb-gtest.LinkFileList
> -mmacosx-version-min=10.9 -weak-lcompression -lz -filelist
> /Users/buildslave/jenkins/sharedspace/lldb@2/lldb/llvm-
> build/Release+Asserts/archives.txt -framework Foundation -framework
> DebugSymbols -framework Security -framework CoreServices -framework
> ApplicationServices /Users/buildslave/jenkins/sharedspace/lldb@2
> /lldb/llvm-build/Release+Asserts/x86_64/lib/libgtest.a -L
> /System/Library/Frameworks/Python.framework/Versions/2.7/lib -l python2.7
> -stdlib=libc++ -lxml2.2 -lpanel -ledit -lz -lncurses
> /Users/buildslave/jenkins/sharedspace/lldb@2/lldb/build/Release/liblldb-core.a
> -Xlinker -dependency_info -Xlinker /Users/buildslave/jenkins/
> sharedspace/lldb@2/lldb/build/lldb.build/Release/lldb-gtest-
> build.build/Objects-normal/x86_64/lldb-gtest_dependency_info.dat -o
> /Users/buildslave/jenkins/sharedspace/lldb@2/lldb/build/Release/lldb-gtest
> Undefined symbols for architecture x86_64:
>   
> "lldb_private::minidump::ConvertMinidumpContextToRegIface(llvm::ArrayRef char>, lldb_private::RegisterInfoInterface*)", referenced from:
>   MinidumpParserTest_ConvertRegisterContext_Test::TestBody() in
> MinidumpParserTest.o
> ld: symbol(s) not found for architecture x86_64
>
>
> It first struck yesterday afternoon:
>
> http://lab.llvm.org:8080/green/view/LLDB/job/lldb_build_test/20745/console
>
> and recurring through today:
>
> http://lab.llvm.org:8080/green/view/LLDB/job/lldb_build_test/20770/console
>
> Is there a change that needs to be made to the test suite to address this?
>
>
> On Tue, Sep 27, 2016 at 12:05 PM, Dimitar Vlahovski via lldb-commits <
> lldb-commits@lists.llvm.org> wrote:
>
>> Author: dvlahovski
>> Date: Tue Sep 27 14:05:55 2016
>> New Revision: 282529
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=282529=rev
>> Log:
>> Adding a RegisterContextMinidump_x86_64 converter
>>
>> Summary:
>> This is a register context converter from Minidump to Linux reg context.
>> This knows the layout of the register context in the Minidump file
>> (which is the same as in Windows FYI) and as a result emits a binary data
>> buffer that matches the Linux register context binary layout.
>> This way we can reuse the existing RegisterContextLinux_x86_64 and
>> RegisterContextCorePOSIX_x86_64 classes.
>>
>> Reviewers: labath, zturner
>>
>> Subscribers: beanz, mgorny, lldb-commits, amccarth
>>
>> Differential Revision: https://reviews.llvm.org/D24919
>>
>> Added:
>> lldb/trunk/source/Plugins/Process/minidump/RegisterContextMi
>> nidump_x86_64.cpp
>> lldb/trunk/source/Plugins/Process/minidump/RegisterContextMi
>> nidump_x86_64.h
>> Modified:
>> lldb/trunk/include/lldb/lldb-private-types.h
>> lldb/trunk/source/Plugins/Process/minidump/CMakeLists.txt
>> lldb/trunk/source/Plugins/Process/minidump/MinidumpParser.cpp
>> lldb/trunk/source/Plugins/Process/minidump/MinidumpParser.h
>> lldb/trunk/unittests/Process/minidump/MinidumpParserTest.cpp
>>
>> Modified: lldb/trunk/include/lldb/lldb-private-types.h
>> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/
>> lldb-private-types.h?rev=282529=282528=282529=diff
>> 
>> ==
>> --- lldb/trunk/include/lldb/lldb-private-types.h (original)
>> +++ lldb/trunk/include/lldb/lldb-private-types.h Tue Sep 27 14:05:55 2016
>> @@ -14,6 +14,8 @@
>>
>>  #include "lldb/lldb-private.h"
>>
>> +#include "llvm/ADT/ArrayRef.h"
>> +
>>  namespace llvm {
>>  namespace sys {
>>  class DynamicLibrary;
>> @@ -61,6 +63,15 @@ struct RegisterInfo {
>>// the byte size of this register.
>>size_t dynamic_size_dwarf_len; // The length of the 

Re: [Lldb-commits] [lldb] r282529 - Adding a RegisterContextMinidump_x86_64 converter

[Tim Hammerquist via lldb-commits]

This change seems to have introduced a linker failure while building the
gtest suite:


Ld build/Release/lldb-gtest normal x86_64
cd "/Users/buildslave/jenkins/sharedspace/lldb@2/lldb"
export MACOSX_DEPLOYMENT_TARGET=10.9

/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++
-arch x86_64 -isysroot
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk
-L/Users/buildslave/jenkins/sharedspace/lldb@2/lldb/build/Release
-F/Users/buildslave/jenkins/sharedspace/lldb@2/lldb/build/Release
-F/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk/System/Library/PrivateFrameworks
-F/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk/System/Library/Frameworks/CoreServices.framework/Frameworks
-filelist 
/Users/buildslave/jenkins/sharedspace/lldb@2/lldb/build/lldb.build/Release/lldb-gtest-build.build/Objects-normal/x86_64/lldb-gtest.LinkFileList
-mmacosx-version-min=10.9 -weak-lcompression -lz -filelist
/Users/buildslave/jenkins/sharedspace/lldb@2/lldb/llvm-build/Release+Asserts/archives.txt
-framework Foundation -framework DebugSymbols -framework Security
-framework CoreServices -framework ApplicationServices
/Users/buildslave/jenkins/sharedspace/lldb@2/lldb/llvm-build/Release+Asserts/x86_64/lib/libgtest.a
-L /System/Library/Frameworks/Python.framework/Versions/2.7/lib -l
python2.7 -stdlib=libc++ -lxml2.2 -lpanel -ledit -lz -lncurses
/Users/buildslave/jenkins/sharedspace/lldb@2/lldb/build/Release/liblldb-core.a
-Xlinker -dependency_info -Xlinker
/Users/buildslave/jenkins/sharedspace/lldb@2/lldb/build/lldb.build/Release/lldb-gtest-build.build/Objects-normal/x86_64/lldb-gtest_dependency_info.dat
-o /Users/buildslave/jenkins/sharedspace/lldb@2
/lldb/build/Release/lldb-gtest
Undefined symbols for architecture x86_64:

"lldb_private::minidump::ConvertMinidumpContextToRegIface(llvm::ArrayRef, lldb_private::RegisterInfoInterface*)", referenced from:
  MinidumpParserTest_ConvertRegisterContext_Test::TestBody() in
MinidumpParserTest.o
ld: symbol(s) not found for architecture x86_64


It first struck yesterday afternoon:

http://lab.llvm.org:8080/green/view/LLDB/job/lldb_build_test/20745/console

and recurring through today:

http://lab.llvm.org:8080/green/view/LLDB/job/lldb_build_test/20770/console

Is there a change that needs to be made to the test suite to address this?


On Tue, Sep 27, 2016 at 12:05 PM, Dimitar Vlahovski via lldb-commits <
lldb-commits@lists.llvm.org> wrote:

> Author: dvlahovski
> Date: Tue Sep 27 14:05:55 2016
> New Revision: 282529
>
> URL: http://llvm.org/viewvc/llvm-project?rev=282529=rev
> Log:
> Adding a RegisterContextMinidump_x86_64 converter
>
> Summary:
> This is a register context converter from Minidump to Linux reg context.
> This knows the layout of the register context in the Minidump file
> (which is the same as in Windows FYI) and as a result emits a binary data
> buffer that matches the Linux register context binary layout.
> This way we can reuse the existing RegisterContextLinux_x86_64 and
> RegisterContextCorePOSIX_x86_64 classes.
>
> Reviewers: labath, zturner
>
> Subscribers: beanz, mgorny, lldb-commits, amccarth
>
> Differential Revision: https://reviews.llvm.org/D24919
>
> Added:
> lldb/trunk/source/Plugins/Process/minidump/
> RegisterContextMinidump_x86_64.cpp
> lldb/trunk/source/Plugins/Process/minidump/
> RegisterContextMinidump_x86_64.h
> Modified:
> lldb/trunk/include/lldb/lldb-private-types.h
> lldb/trunk/source/Plugins/Process/minidump/CMakeLists.txt
> lldb/trunk/source/Plugins/Process/minidump/MinidumpParser.cpp
> lldb/trunk/source/Plugins/Process/minidump/MinidumpParser.h
> lldb/trunk/unittests/Process/minidump/MinidumpParserTest.cpp
>
> Modified: lldb/trunk/include/lldb/lldb-private-types.h
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/
> lldb/lldb-private-types.h?rev=282529=282528=282529=diff
> 
> ==
> --- lldb/trunk/include/lldb/lldb-private-types.h (original)
> +++ lldb/trunk/include/lldb/lldb-private-types.h Tue Sep 27 14:05:55 2016
> @@ -14,6 +14,8 @@
>
>  #include "lldb/lldb-private.h"
>
> +#include "llvm/ADT/ArrayRef.h"
> +
>  namespace llvm {
>  namespace sys {
>  class DynamicLibrary;
> @@ -61,6 +63,15 @@ struct RegisterInfo {
>// the byte size of this register.
>size_t dynamic_size_dwarf_len; // The length of the DWARF expression in
> bytes
>   // in the dynamic_size_dwarf_expr_bytes
> member.
> +
> +  llvm::ArrayRef data(const uint8_t *context_base) const {
> +return llvm::ArrayRef(context_base + byte_offset,
> byte_size);
> +  }
> +
> +  llvm::MutableArrayRef mutable_data(uint8_t *context_base)
> const {
> +return llvm::MutableArrayRef(context_base + byte_offset,
> +   

Re: [Lldb-commits] [Project] LLDB

[Tim Hammerquist via lldb-commits]

penryu added a watcher: penryu.

PROJECT DETAIL
  https://reviews.llvm.org/project/profile/39/



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits