[Lldb-commits] [PATCH] D100193: [lldb] Require x86 backend for a bunch of DWARF tests

2021-04-13 Thread David Spickett via Phabricator via lldb-commits 
This revision was automatically updated to reflect the committed changes.
Closed by commit rG8a64d80a959b: [lldb] Require x86 backend for a bunch of 
DWARF tests (authored by DavidSpickett).

Changed prior to commit:
  https://reviews.llvm.org/D100193?vs=336783=337068#toc

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100193/new/

https://reviews.llvm.org/D100193

Files:
  lldb/test/Shell/SymbolFile/DWARF/DW_AT_const_value-bitfields.s
  lldb/test/Shell/SymbolFile/DWARF/DW_AT_const_value.s
  lldb/test/Shell/SymbolFile/DWARF/DW_AT_data_bit_offset-DW_OP_stack_value.s
  lldb/test/Shell/SymbolFile/DWARF/DW_AT_decl_file-DW_AT_specification-crosscu.s
  lldb/test/Shell/SymbolFile/DWARF/DW_AT_declaration-with-children.s
  lldb/test/Shell/SymbolFile/DWARF/DW_AT_location-DW_AT_const_value.s
  lldb/test/Shell/SymbolFile/DWARF/DW_AT_loclists_base.s
  lldb/test/Shell/SymbolFile/DWARF/DW_AT_low_pc-addrx.s
  lldb/test/Shell/SymbolFile/DWARF/DW_OP_piece-smaller-than-struct.s
  lldb/test/Shell/SymbolFile/DWARF/DW_OP_piece-struct.s
  lldb/test/Shell/SymbolFile/DWARF/DW_TAG_GNU_call_site-DW_AT_low_pc.s
  lldb/test/Shell/SymbolFile/DWARF/DW_TAG_basic_type_DW_ATE_UTF_nonC.ll
  lldb/test/Shell/SymbolFile/DWARF/DW_TAG_variable-DW_AT_const_value.s
  
lldb/test/Shell/SymbolFile/DWARF/DW_TAG_variable-DW_AT_decl_file-DW_AT_abstract_origin-crosscu1.s
  lldb/test/Shell/SymbolFile/DWARF/DW_TAG_variable-invalid_location.s
  
lldb/test/Shell/SymbolFile/DWARF/Inputs/DW_TAG_variable-DW_AT_decl_file-DW_AT_abstract_origin-crosscu2.s
  lldb/test/Shell/SymbolFile/DWARF/Inputs/ModuleOwnership/A.h
  lldb/test/Shell/SymbolFile/DWARF/Inputs/ModuleOwnership/B.h
  lldb/test/Shell/SymbolFile/DWARF/Inputs/ModuleOwnership/module.modulemap
  lldb/test/Shell/SymbolFile/DWARF/Inputs/debug-line-basic.script
  lldb/test/Shell/SymbolFile/DWARF/Inputs/debug-types-basic.cpp
  lldb/test/Shell/SymbolFile/DWARF/Inputs/debug_loc-aslr.yaml
  
lldb/test/Shell/SymbolFile/DWARF/Inputs/dir-separator-no-comp-dir-relative-name.lldbinit
  lldb/test/Shell/SymbolFile/DWARF/Inputs/dir-separator-posix.lldbinit
  lldb/test/Shell/SymbolFile/DWARF/Inputs/dir-separator-windows.lldbinit
  lldb/test/Shell/SymbolFile/DWARF/Inputs/find-variable-file-2.cpp
  lldb/test/Shell/SymbolFile/DWARF/Inputs/subprogram_ranges.s
  lldb/test/Shell/SymbolFile/DWARF/apple-index-is-used.cpp
  lldb/test/Shell/SymbolFile/DWARF/array-sizes.s
  lldb/test/Shell/SymbolFile/DWARF/childless-compile-unit.s
  lldb/test/Shell/SymbolFile/DWARF/compilercontext.ll
  lldb/test/Shell/SymbolFile/DWARF/debug-line-basic.s
  lldb/test/Shell/SymbolFile/DWARF/debug-names-compressed.cpp
  lldb/test/Shell/SymbolFile/DWARF/debug-types-address-ranges.s
  lldb/test/Shell/SymbolFile/DWARF/debug-types-basic.test
  lldb/test/Shell/SymbolFile/DWARF/debug-types-dwarf5.s
  lldb/test/Shell/SymbolFile/DWARF/debug-types-dwo-cross-reference.cpp
  lldb/test/Shell/SymbolFile/DWARF/debug-types-line-tables.s
  lldb/test/Shell/SymbolFile/DWARF/debug-types-missing-signature.test
  lldb/test/Shell/SymbolFile/DWARF/debug-types-signature-loop.s
  lldb/test/Shell/SymbolFile/DWARF/debug_aranges-empty-section.s
  lldb/test/Shell/SymbolFile/DWARF/debug_line-relative_path.s
  lldb/test/Shell/SymbolFile/DWARF/debug_line-tombstone.s
  lldb/test/Shell/SymbolFile/DWARF/debug_loc-aslr.s
  lldb/test/Shell/SymbolFile/DWARF/debug_loc.s
  lldb/test/Shell/SymbolFile/DWARF/debug_loc_and_loclists.s
  lldb/test/Shell/SymbolFile/DWARF/debug_loclists-dwo.s
  lldb/test/Shell/SymbolFile/DWARF/debug_ranges-missing-section.s
  lldb/test/Shell/SymbolFile/DWARF/debug_ranges.s
  lldb/test/Shell/SymbolFile/DWARF/debug_ranges_and_rnglists.test
  lldb/test/Shell/SymbolFile/DWARF/debug_rnglists-dwo.s
  lldb/test/Shell/SymbolFile/DWARF/debug_rnglists.s
  lldb/test/Shell/SymbolFile/DWARF/dir-separator-no-comp-dir-relative-name.s
  lldb/test/Shell/SymbolFile/DWARF/dir-separator-no-comp-dir.s
  lldb/test/Shell/SymbolFile/DWARF/dir-separator-posix.s
  lldb/test/Shell/SymbolFile/DWARF/dir-separator-windows.s
  lldb/test/Shell/SymbolFile/DWARF/dwarf5-atomic.s
  lldb/test/Shell/SymbolFile/DWARF/dwarf5-debug_line-file-index.s
  lldb/test/Shell/SymbolFile/DWARF/dwarf5-debug_line.s
  lldb/test/Shell/SymbolFile/DWARF/dwarf5-implicit-const.s
  lldb/test/Shell/SymbolFile/DWARF/dwarf5-index-is-used.cpp
  lldb/test/Shell/SymbolFile/DWARF/dwarf5-line-strp.s
  lldb/test/Shell/SymbolFile/DWARF/dwarf5-partial-index.cpp
  lldb/test/Shell/SymbolFile/DWARF/dwarf5-split.s
  lldb/test/Shell/SymbolFile/DWARF/dwarf5_locations.s
  lldb/test/Shell/SymbolFile/DWARF/dwarf5_tu_index_abbrev_offset.s
  lldb/test/Shell/SymbolFile/DWARF/dwo-type-in-main-file.s
  lldb/test/Shell/SymbolFile/DWARF/dwp-debug-types.s
  lldb/test/Shell/SymbolFile/DWARF/dwp-separate-debug-file.cpp
  lldb/test/Shell/SymbolFile/DWARF/dwp.s
  lldb/test/Shell/SymbolFile/DWARF/find-basic-function.cpp
  lldb/test/Shell/SymbolFile/DWARF/find-basic-namespace.cpp

[Lldb-commits] [PATCH] D100193: [lldb] Require x86 backend for a bunch of DWARF tests

2021-04-12 Thread Jonas Devlieghere via Phabricator via lldb-commits 
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.

Thanks, LGTM.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100193/new/

https://reviews.llvm.org/D100193

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D100193: [lldb] Require x86 backend for a bunch of DWARF tests

2021-04-09 Thread Jonas Devlieghere via Phabricator via lldb-commits 
JDevlieghere requested changes to this revision.
JDevlieghere added a comment.
This revision now requires changes to proceed.

Rather than updating all the these tests, please move them into an x86 
subdirectory and add a `lit.local.cfg` to mark the whole folder as unsupported 
without x86 support. Something like:

  if not 'x86' in config.available_features:
config.unsupported = True


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100193/new/

https://reviews.llvm.org/D100193

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D100193: [lldb] Require x86 backend for a bunch of DWARF tests

2021-04-09 Thread David Spickett via Phabricator via lldb-commits 
DavidSpickett created this revision.
Herald added subscribers: pengfei, arphaman.
DavidSpickett requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

All these tests use x86 target triples.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D100193

Files:
  lldb/test/Shell/SymbolFile/DWARF/DW_AT_const_value-bitfields.s
  lldb/test/Shell/SymbolFile/DWARF/DW_AT_data_bit_offset-DW_OP_stack_value.s
  lldb/test/Shell/SymbolFile/DWARF/DW_OP_piece-struct.s
  lldb/test/Shell/SymbolFile/DWARF/DW_TAG_basic_type_DW_ATE_UTF_nonC.ll
  lldb/test/Shell/SymbolFile/DWARF/DW_TAG_variable-invalid_location.s
  lldb/test/Shell/SymbolFile/DWARF/apple-index-is-used.cpp
  lldb/test/Shell/SymbolFile/DWARF/compilercontext.ll
  lldb/test/Shell/SymbolFile/DWARF/debug-names-compressed.cpp
  lldb/test/Shell/SymbolFile/DWARF/debug-types-basic.test
  lldb/test/Shell/SymbolFile/DWARF/debug-types-dwarf5.s
  lldb/test/Shell/SymbolFile/DWARF/debug-types-dwo-cross-reference.cpp
  lldb/test/Shell/SymbolFile/DWARF/debug-types-missing-signature.test
  lldb/test/Shell/SymbolFile/DWARF/debug_line-tombstone.s
  lldb/test/Shell/SymbolFile/DWARF/debug_ranges_and_rnglists.test
  lldb/test/Shell/SymbolFile/DWARF/dwarf5-index-is-used.cpp
  lldb/test/Shell/SymbolFile/DWARF/dwarf5-partial-index.cpp
  lldb/test/Shell/SymbolFile/DWARF/dwarf5-split.s
  lldb/test/Shell/SymbolFile/DWARF/dwarf5_tu_index_abbrev_offset.s
  lldb/test/Shell/SymbolFile/DWARF/dwp-separate-debug-file.cpp
  lldb/test/Shell/SymbolFile/DWARF/find-basic-function.cpp
  lldb/test/Shell/SymbolFile/DWARF/find-basic-namespace.cpp
  lldb/test/Shell/SymbolFile/DWARF/find-basic-type.cpp
  lldb/test/Shell/SymbolFile/DWARF/find-basic-variable.cpp
  lldb/test/Shell/SymbolFile/DWARF/find-function-regex.cpp
  lldb/test/Shell/SymbolFile/DWARF/find-method-local-struct.cpp
  lldb/test/Shell/SymbolFile/DWARF/find-method.cpp
  lldb/test/Shell/SymbolFile/DWARF/find-qualified-variable.cpp
  lldb/test/Shell/SymbolFile/DWARF/find-variable-dwo.cpp
  lldb/test/Shell/SymbolFile/DWARF/find-variable-file.cpp
  lldb/test/Shell/SymbolFile/DWARF/gnu-style-compression.cpp
  lldb/test/Shell/SymbolFile/DWARF/module-ownership.mm
  lldb/test/Shell/SymbolFile/DWARF/split-dwarf-inlining.cpp
  lldb/test/Shell/SymbolFile/DWARF/split-dwarf-multiple-cu.ll

Index: lldb/test/Shell/SymbolFile/DWARF/split-dwarf-multiple-cu.ll
===
--- lldb/test/Shell/SymbolFile/DWARF/split-dwarf-multiple-cu.ll
+++ lldb/test/Shell/SymbolFile/DWARF/split-dwarf-multiple-cu.ll
@@ -1,6 +1,8 @@
 ; Check handling of dwo files with multiple compile units. Right now this is not
 ; supported, but it should not cause us to crash or misbehave either...
 
+; REQUIRES: x86
+
 ; RUN: llc %s -filetype=obj -o %t.o --split-dwarf-file=%t.o
 ; RUN: %lldb %t.o -o "image lookup -s x1 -v" -o "image lookup -s x2 -v" -b | FileCheck %s
 
Index: lldb/test/Shell/SymbolFile/DWARF/split-dwarf-inlining.cpp
===
--- lldb/test/Shell/SymbolFile/DWARF/split-dwarf-inlining.cpp
+++ lldb/test/Shell/SymbolFile/DWARF/split-dwarf-inlining.cpp
@@ -1,3 +1,5 @@
+// REQUIRES: x86
+
 // RUN: %clangxx -target x86_64-pc-linux -gsplit-dwarf -g -fsplit-dwarf-inlining \
 // RUN:   -c %s -o %t
 // RUN: %lldb %t -o "breakpoint set -n foo" -b | FileCheck %s
Index: lldb/test/Shell/SymbolFile/DWARF/module-ownership.mm
===
--- lldb/test/Shell/SymbolFile/DWARF/module-ownership.mm
+++ lldb/test/Shell/SymbolFile/DWARF/module-ownership.mm
@@ -1,3 +1,5 @@
+// REQUIRES: x86
+
 // RUN: %clang --target=x86_64-apple-macosx -g -gmodules -Wno-objc-root-class \
 // RUN:-fmodules -fmodules-cache-path=%t.cache \
 // RUN:-c -o %t.o %s -I%S/Inputs
Index: lldb/test/Shell/SymbolFile/DWARF/gnu-style-compression.cpp
===
--- lldb/test/Shell/SymbolFile/DWARF/gnu-style-compression.cpp
+++ lldb/test/Shell/SymbolFile/DWARF/gnu-style-compression.cpp
@@ -1,4 +1,4 @@
-// REQUIRES: zlib
+// REQUIRES: zlib, x86
 
 // RUN: %clang %s -target x86_64-pc-linux -g -gsplit-dwarf -c -o %t \
 // RUN:   -Wa,--compress-debug-sections=zlib-gnu
Index: lldb/test/Shell/SymbolFile/DWARF/find-variable-file.cpp
===
--- lldb/test/Shell/SymbolFile/DWARF/find-variable-file.cpp
+++ lldb/test/Shell/SymbolFile/DWARF/find-variable-file.cpp
@@ -1,4 +1,4 @@
-// REQUIRES: lld
+// REQUIRES: lld, x86
 
 // RUN: %clang -g -c -o %t-1.o --target=x86_64-pc-linux -gno-pubnames %s
 // RUN: %clang -g -c -o %t-2.o --target=x86_64-pc-linux -gno-pubnames %S/Inputs/find-variable-file-2.cpp
Index: lldb/test/Shell/SymbolFile/DWARF/find-variable-dwo.cpp
===
--- lldb/test/Shell/SymbolFile/DWARF/find-variable-dwo.cpp
+++