[Lldb-commits] [PATCH] D100195: [lldb] Require x86 for unwind no-return test

[David Spickett via Phabricator via lldb-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rGa1f3187ca8a3: [lldb] Require x86 for unwind no-return test 
(authored by DavidSpickett).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100195/new/

https://reviews.llvm.org/D100195

Files:
  
lldb/test/API/functionalities/unwind/noreturn/module-end/TestNoReturnModuleEnd.py


Index: 
lldb/test/API/functionalities/unwind/noreturn/module-end/TestNoReturnModuleEnd.py
===
--- 
lldb/test/API/functionalities/unwind/noreturn/module-end/TestNoReturnModuleEnd.py
+++ 
lldb/test/API/functionalities/unwind/noreturn/module-end/TestNoReturnModuleEnd.py
@@ -15,6 +15,7 @@
 NO_DEBUG_INFO_TESTCASE = True
 mydir = TestBase.compute_mydir(__file__)
 
+@skipIfLLVMTargetMissing("X86")
 def test(self):
 target = self.dbg.CreateTarget("test.out")
 process = target.LoadCore("test.core")


Index: lldb/test/API/functionalities/unwind/noreturn/module-end/TestNoReturnModuleEnd.py
===
--- lldb/test/API/functionalities/unwind/noreturn/module-end/TestNoReturnModuleEnd.py
+++ lldb/test/API/functionalities/unwind/noreturn/module-end/TestNoReturnModuleEnd.py
@@ -15,6 +15,7 @@
 NO_DEBUG_INFO_TESTCASE = True
 mydir = TestBase.compute_mydir(__file__)
 
+@skipIfLLVMTargetMissing("X86")
 def test(self):
 target = self.dbg.CreateTarget("test.out")
 process = target.LoadCore("test.core")
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D100195: [lldb] Require x86 for unwind no-return test

[Pavel Labath via Phabricator via lldb-commits]

labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

In D100195#2679590 , @DavidSpickett 
wrote:

> (apologies for the review spam, you're the author of the test in this case)

np

> lldb in fact crashes when you try to load the core file. Would be nice to 
> give a good failure message if we can but skipping this test makes sense 
> anyway.

Agree completely.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100195/new/

https://reviews.llvm.org/D100195

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D100195: [lldb] Require x86 for unwind no-return test

[David Spickett via Phabricator via lldb-commits]

DavidSpickett added a reviewer: labath.
DavidSpickett added a comment.
Herald added a subscriber: JDevlieghere.

(apologies for the review spam, you're the author of the test in this case)

lldb in fact crashes when you try to load the core file. Would be nice to give 
a good failure message if we can but skipping this test makes sense anyway.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100195/new/

https://reviews.llvm.org/D100195

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D100195: [lldb] Require x86 for unwind no-return test

[David Spickett via Phabricator via lldb-commits]

DavidSpickett created this revision.
Herald added a subscriber: pengfei.
DavidSpickett requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

The core file used is built for i386 so we
need the x86 backend to be able to load it.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D100195

Files:
  
lldb/test/API/functionalities/unwind/noreturn/module-end/TestNoReturnModuleEnd.py


Index: 
lldb/test/API/functionalities/unwind/noreturn/module-end/TestNoReturnModuleEnd.py
===
--- 
lldb/test/API/functionalities/unwind/noreturn/module-end/TestNoReturnModuleEnd.py
+++ 
lldb/test/API/functionalities/unwind/noreturn/module-end/TestNoReturnModuleEnd.py
@@ -15,6 +15,7 @@
 NO_DEBUG_INFO_TESTCASE = True
 mydir = TestBase.compute_mydir(__file__)
 
+@skipIfLLVMTargetMissing("X86")
 def test(self):
 target = self.dbg.CreateTarget("test.out")
 process = target.LoadCore("test.core")


Index: lldb/test/API/functionalities/unwind/noreturn/module-end/TestNoReturnModuleEnd.py
===
--- lldb/test/API/functionalities/unwind/noreturn/module-end/TestNoReturnModuleEnd.py
+++ lldb/test/API/functionalities/unwind/noreturn/module-end/TestNoReturnModuleEnd.py
@@ -15,6 +15,7 @@
 NO_DEBUG_INFO_TESTCASE = True
 mydir = TestBase.compute_mydir(__file__)
 
+@skipIfLLVMTargetMissing("X86")
 def test(self):
 target = self.dbg.CreateTarget("test.out")
 process = target.LoadCore("test.core")
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits