[Lldb-commits] [PATCH] D104041: [lldb] Replace default bodies of special member functions with = default;

2021-06-14 Thread Raphael Isemann via Phabricator via lldb-commits 
teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.

Not sure what happened to my accept, but I'll LGTM this again. Thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104041/new/

https://reviews.llvm.org/D104041

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D104041: [lldb] Replace default bodies of special member functions with = default;

2021-06-14 Thread Shafik Yaghmour via Phabricator via lldb-commits 
shafik added a comment.

I am sure I could find  a bunch of other ends and odds but perhaps you have 
other checks that will cover these coming up.




Comment at: lldb/include/lldb/Core/ThreadSafeValue.h:21
   // Constructors and Destructors
   ThreadSafeValue() : m_value(), m_mutex() {}
 

We can also default this as well, we can use member initializers for these 
values.



Comment at: lldb/include/lldb/Core/UserSettingsController.h:35
 public:
   Properties() : m_collection_sp() {}
 

I believe this should be defaultable as well.



Comment at: lldb/include/lldb/DataFormatters/DumpValueObjectOptions.h:137
   PointerAsArraySettings m_pointer_as_array;
   bool m_use_synthetic : 1;
   bool m_scope_already_checked : 1;

It looks like these members somehow got missed in the last PR that changed to 
use in class member initializers.



Comment at: lldb/include/lldb/Host/HostNativeProcessBase.h:27
 public:
   HostNativeProcessBase() : m_process(LLDB_INVALID_PROCESS) {}
   explicit HostNativeProcessBase(lldb::process_t process)

This looks like another case that got missed in the last PR to change to use in 
class member init.



Comment at: lldb/include/lldb/Host/HostNativeThreadBase.h:30
 public:
   HostNativeThreadBase();
   explicit HostNativeThreadBase(lldb::thread_t thread);

I think we can switch this to `=default` as well.



Comment at: lldb/include/lldb/Host/HostNativeThreadBase.h:48
 
   lldb::thread_t m_thread;
   lldb::thread_result_t m_result = 0;

` lldb::thread_t m_thread = LLDB_INVALID_HOST_THREAD`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104041/new/

https://reviews.llvm.org/D104041

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D104041: [lldb] Replace default bodies of special member functions with = default;

2021-06-11 Thread Jonas Devlieghere via Phabricator via lldb-commits 
JDevlieghere added inline comments.



Comment at: lldb/include/lldb/Expression/ExpressionParser.h:45
+  virtual ~ExpressionParser() = default;
+  ;
 

teemperor wrote:
> Please drop that when you land it.
Dropped.



Comment at: lldb/include/lldb/Target/Process.h:227
 
-  {}
+  = default;
 

teemperor wrote:
> format
formatted



Comment at: lldb/include/lldb/Target/StackFrameRecognizer.h:41
+  virtual ~RecognizedStackFrame() = default;
+  ;
 

teemperor wrote:
> please remove that pointy boy
pointy boy gone



Comment at: lldb/include/lldb/Target/StackFrameRecognizer.h:68
+  virtual ~StackFrameRecognizer() = default;
+  ;
 };

teemperor wrote:
> and that one too
gone too



Comment at: lldb/source/Interpreter/OptionValueFileColonLine.cpp:26
 
-{}
+= default;
 

teemperor wrote:
> formaat
doone



Comment at: 
lldb/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.h:219
 
-{}
+= default;
 

teemperor wrote:
> formato
hecho



Comment at: 
lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOSXDYLD.h:111
 
-{}
+= default;
 

teemperor wrote:
> formatione
factum



Comment at: 
lldb/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptRuntime.h:50
+  RSCoordinate() = default;
+  ;
 

teemperor wrote:
> goodbye
ciao



Comment at: 
lldb/source/Plugins/SystemRuntime/MacOSX/AppleGetPendingItemsHandler.h:60
 
-{}
+= default;
   };

teemperor wrote:
> フォーマット
完了



Comment at: lldb/source/Plugins/SystemRuntime/MacOSX/AppleGetQueuesHandler.h:57
 
-{}
+= default;
   };

teemperor wrote:
> хэлбэр хэмжээ
хэлбэртэй, хэмжээтэй



Comment at: lldb/source/Plugins/SystemRuntime/MacOSX/SystemRuntimeMacOSX.h:195
 
-{}
+= default;
 

teemperor wrote:
> formoup
doune



Comment at: lldb/source/Plugins/SystemRuntime/MacOSX/SystemRuntimeMacOSX.h:219
 
-{}
+= default;
 

teemperor wrote:
> isimo
isimo sixazululiwe


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104041/new/

https://reviews.llvm.org/D104041

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D104041: [lldb] Replace default bodies of special member functions with = default;

2021-06-10 Thread Raphael Isemann via Phabricator via lldb-commits 
teemperor added a comment.

LGTM beside some minor formatting bugs that got exacerbated by the clang-tidy 
run. I got bored of writing 'format' everywhere so I translated every comment 
into a different language via Google translate. I'll already accept this as 
this is easy to fix.




Comment at: lldb/include/lldb/Expression/ExpressionParser.h:45
+  virtual ~ExpressionParser() = default;
+  ;
 

Please drop that when you land it.



Comment at: lldb/include/lldb/Target/Process.h:227
 
-  {}
+  = default;
 

format



Comment at: lldb/include/lldb/Target/StackFrameRecognizer.h:41
+  virtual ~RecognizedStackFrame() = default;
+  ;
 

please remove that pointy boy



Comment at: lldb/include/lldb/Target/StackFrameRecognizer.h:68
+  virtual ~StackFrameRecognizer() = default;
+  ;
 };

and that one too



Comment at: lldb/source/Interpreter/OptionValueFileColonLine.cpp:26
 
-{}
+= default;
 

formaat



Comment at: 
lldb/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.h:219
 
-{}
+= default;
 

formato



Comment at: 
lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOSXDYLD.h:111
 
-{}
+= default;
 

formatione



Comment at: 
lldb/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptRuntime.h:50
+  RSCoordinate() = default;
+  ;
 

goodbye



Comment at: 
lldb/source/Plugins/SystemRuntime/MacOSX/AppleGetPendingItemsHandler.h:60
 
-{}
+= default;
   };

フォーマット



Comment at: lldb/source/Plugins/SystemRuntime/MacOSX/AppleGetQueuesHandler.h:57
 
-{}
+= default;
   };

хэлбэр хэмжээ



Comment at: lldb/source/Plugins/SystemRuntime/MacOSX/SystemRuntimeMacOSX.h:195
 
-{}
+= default;
 

formoup



Comment at: lldb/source/Plugins/SystemRuntime/MacOSX/SystemRuntimeMacOSX.h:219
 
-{}
+= default;
 

isimo


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104041/new/

https://reviews.llvm.org/D104041

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D104041: [lldb] Replace default bodies of special member functions with = default;

2021-06-10 Thread Jonas Devlieghere via Phabricator via lldb-commits 
JDevlieghere added inline comments.



Comment at: lldb/include/lldb/Interpreter/CommandInterpreter.h:103-105
   CommandInterpreterRunOptions()
 
+  = default;

Interesting, I would've expected clang-format to get this. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104041/new/

https://reviews.llvm.org/D104041

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits