subject:"\[Lldb\-commits\] \[PATCH\] D113047\: \[lldb\] update TestEchoCommands"

[Lldb-commits] [PATCH] D113047: [lldb] update TestEchoCommands

2021-11-04 Thread Lawrence D'Anna via Phabricator via lldb-commits

lawrence_danna added a comment.

@stella.stamenova fixed


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113047/new/

https://reviews.llvm.org/D113047

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D113047: [lldb] update TestEchoCommands

2021-11-03 Thread Lawrence D'Anna via Phabricator via lldb-commits

lawrence_danna added a comment.

In D113047#3106732 , 
@stella.stamenova wrote:

> The Windows buildbot is still broken after this change:
>
> https://lab.llvm.org/buildbot/#/builders/83/builds/11630

sorry again :/

I will fix.   It's takaing  me a alittle while to get a a windows VM set up


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113047/new/

https://reviews.llvm.org/D113047

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D113047: [lldb] update TestEchoCommands

2021-11-03 Thread Stella Stamenova via Phabricator via lldb-commits

stella.stamenova added a comment.

The Windows buildbot is still broken after this change:

https://lab.llvm.org/buildbot/#/builders/83/builds/11630


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113047/new/

https://reviews.llvm.org/D113047

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D113047: [lldb] update TestEchoCommands

2021-11-02 Thread Stella Stamenova via Phabricator via lldb-commits

stella.stamenova added inline comments.



Comment at: lldb/test/Shell/Settings/TestEchoCommands.test:4
 # RUN: %lldb -x -b -o 'settings set interpreter.echo-commands false' 
-s %S/Inputs/EchoCommandsTest.in | FileCheck %S/Inputs/EchoCommandsNone.out
-# RUN: %lldb -x -b --source-quietly  
-s %S/Inputs/EchoCommandsTest.in | FileCheck %S/Inputs/EchoCommandsQuiet.out
+# RUN: ( echo start ; %lldb -x -b --source-quietly -s 
%S/Inputs/EchoCommandsTest.in ; echo done ) | FileCheck  
%S/Inputs/EchoCommandsQuiet.out

The Windows buildbot is not happy with this line:

https://lab.llvm.org/buildbot/#/builders/83/builds/11630


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113047/new/

https://reviews.llvm.org/D113047

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D113047: [lldb] update TestEchoCommands

2021-11-02 Thread Lawrence D'Anna via Phabricator via lldb-commits

This revision was automatically updated to reflect the committed changes.
Closed by commit rG7f01f78593d6: [lldb] update TestEchoCommands (authored by 
lawrence_danna).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113047/new/

https://reviews.llvm.org/D113047

Files:
  lldb/test/Shell/Settings/Inputs/EchoCommandsQuiet.out
  lldb/test/Shell/Settings/TestEchoCommands.test


Index: lldb/test/Shell/Settings/TestEchoCommands.test
===
--- lldb/test/Shell/Settings/TestEchoCommands.test
+++ lldb/test/Shell/Settings/TestEchoCommands.test
@@ -1,4 +1,4 @@
 # RUN: %lldb -x -b -o 'settings set interpreter.echo-comment-commands true'  
-s %S/Inputs/EchoCommandsTest.in | FileCheck %S/Inputs/EchoCommandsAll.out
 # RUN: %lldb -x -b -o 'settings set interpreter.echo-comment-commands false' 
-s %S/Inputs/EchoCommandsTest.in | FileCheck 
%S/Inputs/EchoCommandsNoComments.out
 # RUN: %lldb -x -b -o 'settings set interpreter.echo-commands false' 
-s %S/Inputs/EchoCommandsTest.in | FileCheck %S/Inputs/EchoCommandsNone.out
-# RUN: %lldb -x -b --source-quietly  
-s %S/Inputs/EchoCommandsTest.in | FileCheck %S/Inputs/EchoCommandsQuiet.out
+# RUN: ( echo start ; %lldb -x -b --source-quietly -s 
%S/Inputs/EchoCommandsTest.in ; echo done ) | FileCheck  
%S/Inputs/EchoCommandsQuiet.out
Index: lldb/test/Shell/Settings/Inputs/EchoCommandsQuiet.out
===
--- lldb/test/Shell/Settings/Inputs/EchoCommandsQuiet.out
+++ lldb/test/Shell/Settings/Inputs/EchoCommandsQuiet.out
@@ -1,2 +1,4 @@
-# CHECK: (lldb) command source -s 1 {{.*\n}}
-# CHECK-NEXT: (lldb) command source -s 1 {{.*\n}}
+CHECK: start
+CHECK-NOT: source
+CHECK-NOT: lldb
+CHECK-NEXT: done


Index: lldb/test/Shell/Settings/TestEchoCommands.test
===
--- lldb/test/Shell/Settings/TestEchoCommands.test
+++ lldb/test/Shell/Settings/TestEchoCommands.test
@@ -1,4 +1,4 @@
 # RUN: %lldb -x -b -o 'settings set interpreter.echo-comment-commands true'  -s %S/Inputs/EchoCommandsTest.in | FileCheck %S/Inputs/EchoCommandsAll.out
 # RUN: %lldb -x -b -o 'settings set interpreter.echo-comment-commands false' -s %S/Inputs/EchoCommandsTest.in | FileCheck %S/Inputs/EchoCommandsNoComments.out
 # RUN: %lldb -x -b -o 'settings set interpreter.echo-commands false' -s %S/Inputs/EchoCommandsTest.in | FileCheck %S/Inputs/EchoCommandsNone.out
-# RUN: %lldb -x -b --source-quietly  -s %S/Inputs/EchoCommandsTest.in | FileCheck %S/Inputs/EchoCommandsQuiet.out
+# RUN: ( echo start ; %lldb -x -b --source-quietly -s %S/Inputs/EchoCommandsTest.in ; echo done ) | FileCheck  %S/Inputs/EchoCommandsQuiet.out
Index: lldb/test/Shell/Settings/Inputs/EchoCommandsQuiet.out
===
--- lldb/test/Shell/Settings/Inputs/EchoCommandsQuiet.out
+++ lldb/test/Shell/Settings/Inputs/EchoCommandsQuiet.out
@@ -1,2 +1,4 @@
-# CHECK: (lldb) command source -s 1 {{.*\n}}
-# CHECK-NEXT: (lldb) command source -s 1 {{.*\n}}
+CHECK: start
+CHECK-NOT: source
+CHECK-NOT: lldb
+CHECK-NEXT: done
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D113047: [lldb] update TestEchoCommands

2021-11-02 Thread Jonas Devlieghere via Phabricator via lldb-commits

JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.

LGTM


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113047/new/

https://reviews.llvm.org/D113047

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D113047: [lldb] update TestEchoCommands

2021-11-02 Thread Lawrence D'Anna via Phabricator via lldb-commits

lawrence_danna created this revision.
lawrence_danna added reviewers: jasonmolenda, JDevlieghere, jingham, 
stella.stamenova.
lawrence_danna requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

Followup to https://reviews.llvm.org/D112988

Sorry, I broke this test.   The test was verifying the bad behavior
of --source-quietly that the previous change fixed -- namely that
it still echos the initial list of startup commands while
sourcing them.

Updated the test to verify that --source-quietly is quiet, rather than
loud.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D113047

Files:
  lldb/test/Shell/Settings/Inputs/EchoCommandsQuiet.out
  lldb/test/Shell/Settings/TestEchoCommands.test


Index: lldb/test/Shell/Settings/TestEchoCommands.test
===
--- lldb/test/Shell/Settings/TestEchoCommands.test
+++ lldb/test/Shell/Settings/TestEchoCommands.test
@@ -1,4 +1,4 @@
 # RUN: %lldb -x -b -o 'settings set interpreter.echo-comment-commands true'  
-s %S/Inputs/EchoCommandsTest.in | FileCheck %S/Inputs/EchoCommandsAll.out
 # RUN: %lldb -x -b -o 'settings set interpreter.echo-comment-commands false' 
-s %S/Inputs/EchoCommandsTest.in | FileCheck 
%S/Inputs/EchoCommandsNoComments.out
 # RUN: %lldb -x -b -o 'settings set interpreter.echo-commands false' 
-s %S/Inputs/EchoCommandsTest.in | FileCheck %S/Inputs/EchoCommandsNone.out
-# RUN: %lldb -x -b --source-quietly  
-s %S/Inputs/EchoCommandsTest.in | FileCheck %S/Inputs/EchoCommandsQuiet.out
+# RUN: ( echo start ; %lldb -x -b --source-quietly -s 
%S/Inputs/EchoCommandsTest.in ; echo done ) | FileCheck  
%S/Inputs/EchoCommandsQuiet.out
Index: lldb/test/Shell/Settings/Inputs/EchoCommandsQuiet.out
===
--- lldb/test/Shell/Settings/Inputs/EchoCommandsQuiet.out
+++ lldb/test/Shell/Settings/Inputs/EchoCommandsQuiet.out
@@ -1,2 +1,4 @@
-# CHECK: (lldb) command source -s 1 {{.*\n}}
-# CHECK-NEXT: (lldb) command source -s 1 {{.*\n}}
+CHECK: start
+CHECK-NOT: source
+CHECK-NOT: lldb
+CHECK-NEXT: done


Index: lldb/test/Shell/Settings/TestEchoCommands.test
===
--- lldb/test/Shell/Settings/TestEchoCommands.test
+++ lldb/test/Shell/Settings/TestEchoCommands.test
@@ -1,4 +1,4 @@
 # RUN: %lldb -x -b -o 'settings set interpreter.echo-comment-commands true'  -s %S/Inputs/EchoCommandsTest.in | FileCheck %S/Inputs/EchoCommandsAll.out
 # RUN: %lldb -x -b -o 'settings set interpreter.echo-comment-commands false' -s %S/Inputs/EchoCommandsTest.in | FileCheck %S/Inputs/EchoCommandsNoComments.out
 # RUN: %lldb -x -b -o 'settings set interpreter.echo-commands false' -s %S/Inputs/EchoCommandsTest.in | FileCheck %S/Inputs/EchoCommandsNone.out
-# RUN: %lldb -x -b --source-quietly  -s %S/Inputs/EchoCommandsTest.in | FileCheck %S/Inputs/EchoCommandsQuiet.out
+# RUN: ( echo start ; %lldb -x -b --source-quietly -s %S/Inputs/EchoCommandsTest.in ; echo done ) | FileCheck  %S/Inputs/EchoCommandsQuiet.out
Index: lldb/test/Shell/Settings/Inputs/EchoCommandsQuiet.out
===
--- lldb/test/Shell/Settings/Inputs/EchoCommandsQuiet.out
+++ lldb/test/Shell/Settings/Inputs/EchoCommandsQuiet.out
@@ -1,2 +1,4 @@
-# CHECK: (lldb) command source -s 1 {{.*\n}}
-# CHECK-NEXT: (lldb) command source -s 1 {{.*\n}}
+CHECK: start
+CHECK-NOT: source
+CHECK-NOT: lldb
+CHECK-NEXT: done
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D113047: [lldb] update TestEchoCommands

[Lldb-commits] [PATCH] D113047: [lldb] update TestEchoCommands

[Lldb-commits] [PATCH] D113047: [lldb] update TestEchoCommands

[Lldb-commits] [PATCH] D113047: [lldb] update TestEchoCommands

[Lldb-commits] [PATCH] D113047: [lldb] update TestEchoCommands

[Lldb-commits] [PATCH] D113047: [lldb] update TestEchoCommands

[Lldb-commits] [PATCH] D113047: [lldb] update TestEchoCommands

7 matches

Site Navigation

Mail list logo

Footer information