[Lldb-commits] [PATCH] D149641: [docs] Hide collaboration and include graphs in doxygen docs
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeadf6db585e1: [docs] Hide collaboration and include graphs in doxygen docs (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149641/new/ https://reviews.llvm.org/D149641 Files: bolt/docs/doxygen.cfg.in clang-tools-extra/docs/doxygen.cfg.in clang/docs/doxygen.cfg.in flang/docs/doxygen.cfg.in lldb/docs/doxygen.cfg.in llvm/docs/doxygen.cfg.in mlir/docs/doxygen.cfg.in openmp/docs/doxygen.cfg.in openmp/runtime/doc/doxygen/config polly/docs/doxygen.cfg.in Index: polly/docs/doxygen.cfg.in === --- polly/docs/doxygen.cfg.in +++ polly/docs/doxygen.cfg.in @@ -2103,7 +2103,7 @@ # The default value is: YES. # This tag requires that the tag HAVE_DOT is set to YES. -COLLABORATION_GRAPH= YES +COLLABORATION_GRAPH= NO # If the GROUP_GRAPHS tag is set to YES then doxygen will generate a graph for # groups, showing the direct groups dependencies. @@ -2148,7 +2148,7 @@ # The default value is: YES. # This tag requires that the tag HAVE_DOT is set to YES. -INCLUDE_GRAPH = YES +INCLUDE_GRAPH = NO # If the INCLUDED_BY_GRAPH, ENABLE_PREPROCESSING and SEARCH_INCLUDES tags are # set to YES then doxygen will generate a graph for each documented file showing @@ -2157,7 +2157,7 @@ # The default value is: YES. # This tag requires that the tag HAVE_DOT is set to YES. -INCLUDED_BY_GRAPH = YES +INCLUDED_BY_GRAPH = NO # If the CALL_GRAPH tag is set to YES then doxygen will generate a call # dependency graph for every global function or class method. Index: openmp/runtime/doc/doxygen/config === --- openmp/runtime/doc/doxygen/config +++ openmp/runtime/doc/doxygen/config @@ -1671,7 +1671,7 @@ # indirect implementation dependencies (inheritance, containment, and # class references variables) of the class with other documented classes. -COLLABORATION_GRAPH= YES +COLLABORATION_GRAPH= NO # If the GROUP_GRAPHS and HAVE_DOT tags are set to YES then doxygen # will generate a graph for groups, showing the direct groups dependencies @@ -1703,14 +1703,14 @@ # file showing the direct and indirect include dependencies of the file with # other documented files. -INCLUDE_GRAPH = YES +INCLUDE_GRAPH = NO # If the ENABLE_PREPROCESSING, SEARCH_INCLUDES, INCLUDED_BY_GRAPH, and # HAVE_DOT tags are set to YES then doxygen will generate a graph for each # documented header file showing the documented files that directly or # indirectly include this file. -INCLUDED_BY_GRAPH = YES +INCLUDED_BY_GRAPH = NO # If the CALL_GRAPH and HAVE_DOT options are set to YES then # doxygen will generate a call dependency graph for every global function Index: openmp/docs/doxygen.cfg.in === --- openmp/docs/doxygen.cfg.in +++ openmp/docs/doxygen.cfg.in @@ -2091,7 +2091,7 @@ # The default value is: YES. # This tag requires that the tag HAVE_DOT is set to YES. -COLLABORATION_GRAPH= YES +COLLABORATION_GRAPH= NO # If the GROUP_GRAPHS tag is set to YES then doxygen will generate a graph for # groups, showing the direct groups dependencies. @@ -2136,7 +2136,7 @@ # The default value is: YES. # This tag requires that the tag HAVE_DOT is set to YES. -INCLUDE_GRAPH = YES +INCLUDE_GRAPH = NO # If the INCLUDED_BY_GRAPH, ENABLE_PREPROCESSING and SEARCH_INCLUDES tags are # set to YES then doxygen will generate a graph for each documented file showing @@ -2145,7 +2145,7 @@ # The default value is: YES. # This tag requires that the tag HAVE_DOT is set to YES. -INCLUDED_BY_GRAPH = YES +INCLUDED_BY_GRAPH = NO # If the CALL_GRAPH tag is set to YES then doxygen will generate a call # dependency graph for every global function or class method. Index: mlir/docs/doxygen.cfg.in === --- mlir/docs/doxygen.cfg.in +++ mlir/docs/doxygen.cfg.in @@ -2091,7 +2091,7 @@ # The default value is: YES. # This tag requires that the tag HAVE_DOT is set to YES. -COLLABORATION_GRAPH= YES +COLLABORATION_GRAPH= NO # If the GROUP_GRAPHS tag is set to YES then doxygen will generate a graph for # groups, showing the direct groups dependencies. @@ -2136,7 +2136,7 @@ # The default value is: YES. # This tag requires that the tag HAVE_DOT is set to YES. -INCLUDE_GRAPH = YES +INCLUDE_GRAPH = NO # If the INCLUDED_BY_GRAPH, ENABLE_PREPROCESSING and SEARCH_INCLUDES tags are # set to YES then doxygen will generate a graph for each documented file showing @@ -2145,7 +2145,7 @@ # The default value is: YES. # This tag requires that the
[Lldb-commits] [PATCH] D149641: [docs] Hide collaboration and include graphs in doxygen docs
kwk accepted this revision. kwk added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149641/new/ https://reviews.llvm.org/D149641 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D149641: [docs] Hide collaboration and include graphs in doxygen docs
nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. Herald added a subscriber: StephenFan. LGTM, only the inheritance graph is useful, which this preserves if I understand correctly (CLASS_GRAPH is still YES). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149641/new/ https://reviews.llvm.org/D149641 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D149641: [docs] Hide collaboration and include graphs in doxygen docs
tianshilei1992 added a comment. Looks good on the OpenMP side as we don’t generally have a good API doc anyway. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149641/new/ https://reviews.llvm.org/D149641 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D149641: [docs] Hide collaboration and include graphs in doxygen docs
aaron.ballman added a comment. Herald added a reviewer: jdoerfert. Herald added subscribers: jplehr, sstefan1, JDevlieghere. I think this is a reasonable change -- I don't see a whole lot of value out from the include or collaboration graphs, so unless someone has strong opinions otherwise, I think this LG for the Clang side of things. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149641/new/ https://reviews.llvm.org/D149641 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D149641: [docs] Hide collaboration and include graphs in doxygen docs
tbaeder created this revision. tbaeder added reviewers: aaron.ballman, shafik. Herald added a reviewer: bollu. Herald added subscribers: bviyer, Moerafaat, zero9178, bzcheeseman, ayermolo, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, antiagainst, shauheen, rriddle, mehdi_amini, thopre. Herald added a reviewer: rafauler. Herald added a reviewer: Amir. Herald added a reviewer: maksfb. Herald added projects: Flang, All. tbaeder requested review of this revision. Herald added subscribers: cfe-commits, llvm-commits, openmp-commits, lldb-commits, yota9, stephenneuendorffer, nicolasvasilache, jdoerfert. Herald added projects: clang, LLDB, OpenMP, MLIR, LLVM, clang-tools-extra. I think they are pretty useless and make the docs harder to read. Set the `COLLABORATION_GRAPH`, `INCLUDE_GRAPH` and `INCLUDED_BY_GRAPH` variables all to `NO`. The changes are similar to the ones done in https://github.com/googleapis/google-cloud-cpp/pull/397, but I did not remove the class graph, I think that one is actually helpful. Not sure who to add as reviewers (none of the codeowners files seem to mention a owner for docs...), so adding some frontend people. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D149641 Files: bolt/docs/doxygen.cfg.in clang-tools-extra/docs/doxygen.cfg.in clang/docs/doxygen.cfg.in flang/docs/doxygen.cfg.in lldb/docs/doxygen.cfg.in llvm/docs/doxygen.cfg.in mlir/docs/doxygen.cfg.in openmp/docs/doxygen.cfg.in openmp/runtime/doc/doxygen/config polly/docs/doxygen.cfg.in Index: polly/docs/doxygen.cfg.in === --- polly/docs/doxygen.cfg.in +++ polly/docs/doxygen.cfg.in @@ -2103,7 +2103,7 @@ # The default value is: YES. # This tag requires that the tag HAVE_DOT is set to YES. -COLLABORATION_GRAPH= YES +COLLABORATION_GRAPH= NO # If the GROUP_GRAPHS tag is set to YES then doxygen will generate a graph for # groups, showing the direct groups dependencies. @@ -2148,7 +2148,7 @@ # The default value is: YES. # This tag requires that the tag HAVE_DOT is set to YES. -INCLUDE_GRAPH = YES +INCLUDE_GRAPH = NO # If the INCLUDED_BY_GRAPH, ENABLE_PREPROCESSING and SEARCH_INCLUDES tags are # set to YES then doxygen will generate a graph for each documented file showing @@ -2157,7 +2157,7 @@ # The default value is: YES. # This tag requires that the tag HAVE_DOT is set to YES. -INCLUDED_BY_GRAPH = YES +INCLUDED_BY_GRAPH = NO # If the CALL_GRAPH tag is set to YES then doxygen will generate a call # dependency graph for every global function or class method. Index: openmp/runtime/doc/doxygen/config === --- openmp/runtime/doc/doxygen/config +++ openmp/runtime/doc/doxygen/config @@ -1671,7 +1671,7 @@ # indirect implementation dependencies (inheritance, containment, and # class references variables) of the class with other documented classes. -COLLABORATION_GRAPH= YES +COLLABORATION_GRAPH= NO # If the GROUP_GRAPHS and HAVE_DOT tags are set to YES then doxygen # will generate a graph for groups, showing the direct groups dependencies @@ -1703,14 +1703,14 @@ # file showing the direct and indirect include dependencies of the file with # other documented files. -INCLUDE_GRAPH = YES +INCLUDE_GRAPH = NO # If the ENABLE_PREPROCESSING, SEARCH_INCLUDES, INCLUDED_BY_GRAPH, and # HAVE_DOT tags are set to YES then doxygen will generate a graph for each # documented header file showing the documented files that directly or # indirectly include this file. -INCLUDED_BY_GRAPH = YES +INCLUDED_BY_GRAPH = NO # If the CALL_GRAPH and HAVE_DOT options are set to YES then # doxygen will generate a call dependency graph for every global function Index: openmp/docs/doxygen.cfg.in === --- openmp/docs/doxygen.cfg.in +++ openmp/docs/doxygen.cfg.in @@ -2091,7 +2091,7 @@ # The default value is: YES. # This tag requires that the tag HAVE_DOT is set to YES. -COLLABORATION_GRAPH= YES +COLLABORATION_GRAPH= NO # If the GROUP_GRAPHS tag is set to YES then doxygen will generate a graph for # groups, showing the direct groups dependencies. @@ -2136,7 +2136,7 @@ # The default value is: YES. # This tag requires that the tag HAVE_DOT is set to YES. -INCLUDE_GRAPH = YES +INCLUDE_GRAPH = NO # If the INCLUDED_BY_GRAPH, ENABLE_PREPROCESSING and SEARCH_INCLUDES tags are # set to YES then doxygen will generate a graph for each documented file showing @@ -2145,7 +2145,7 @@ # The default value is: YES. # This tag requires that the tag HAVE_DOT is set to YES. -INCLUDED_BY_GRAPH = YES +INCLUDED_BY_GRAPH = NO # If the CALL_GRAPH tag is set to YES then doxygen
