[Lldb-commits] [PATCH] D152922: [lldb][RISCV] Replace enumeration of RVV builtin types with inclusion to RISCVVTypes.def

2023-06-15 Thread Yueh-Ting (eop) Chen via Phabricator via lldb-commits
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG3f9f9e0d9273: [lldb][RISCV] Replace enumeration of RVV 
builtin types with inclusion to… (authored by eopXD).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152922/new/

https://reviews.llvm.org/D152922

Files:
  lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp

Index: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp
===
--- lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp
+++ lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp
@@ -5041,298 +5041,8 @@
   break;
 
 // RISC-V V builtin types.
-case clang::BuiltinType::RvvInt8mf8:
-case clang::BuiltinType::RvvInt8mf4:
-case clang::BuiltinType::RvvInt8mf2:
-case clang::BuiltinType::RvvInt8m1:
-case clang::BuiltinType::RvvInt8m2:
-case clang::BuiltinType::RvvInt8m4:
-case clang::BuiltinType::RvvInt8m8:
-case clang::BuiltinType::RvvUint8mf8:
-case clang::BuiltinType::RvvUint8mf4:
-case clang::BuiltinType::RvvUint8mf2:
-case clang::BuiltinType::RvvUint8m1:
-case clang::BuiltinType::RvvUint8m2:
-case clang::BuiltinType::RvvUint8m4:
-case clang::BuiltinType::RvvUint8m8:
-case clang::BuiltinType::RvvInt16mf4:
-case clang::BuiltinType::RvvInt16mf2:
-case clang::BuiltinType::RvvInt16m1:
-case clang::BuiltinType::RvvInt16m2:
-case clang::BuiltinType::RvvInt16m4:
-case clang::BuiltinType::RvvInt16m8:
-case clang::BuiltinType::RvvUint16mf4:
-case clang::BuiltinType::RvvUint16mf2:
-case clang::BuiltinType::RvvUint16m1:
-case clang::BuiltinType::RvvUint16m2:
-case clang::BuiltinType::RvvUint16m4:
-case clang::BuiltinType::RvvUint16m8:
-case clang::BuiltinType::RvvInt32mf2:
-case clang::BuiltinType::RvvInt32m1:
-case clang::BuiltinType::RvvInt32m2:
-case clang::BuiltinType::RvvInt32m4:
-case clang::BuiltinType::RvvInt32m8:
-case clang::BuiltinType::RvvUint32mf2:
-case clang::BuiltinType::RvvUint32m1:
-case clang::BuiltinType::RvvUint32m2:
-case clang::BuiltinType::RvvUint32m4:
-case clang::BuiltinType::RvvUint32m8:
-case clang::BuiltinType::RvvInt64m1:
-case clang::BuiltinType::RvvInt64m2:
-case clang::BuiltinType::RvvInt64m4:
-case clang::BuiltinType::RvvInt64m8:
-case clang::BuiltinType::RvvUint64m1:
-case clang::BuiltinType::RvvUint64m2:
-case clang::BuiltinType::RvvUint64m4:
-case clang::BuiltinType::RvvUint64m8:
-case clang::BuiltinType::RvvFloat16mf4:
-case clang::BuiltinType::RvvFloat16mf2:
-case clang::BuiltinType::RvvFloat16m1:
-case clang::BuiltinType::RvvFloat16m2:
-case clang::BuiltinType::RvvFloat16m4:
-case clang::BuiltinType::RvvFloat16m8:
-case clang::BuiltinType::RvvFloat32mf2:
-case clang::BuiltinType::RvvFloat32m1:
-case clang::BuiltinType::RvvFloat32m2:
-case clang::BuiltinType::RvvFloat32m4:
-case clang::BuiltinType::RvvFloat32m8:
-case clang::BuiltinType::RvvFloat64m1:
-case clang::BuiltinType::RvvFloat64m2:
-case clang::BuiltinType::RvvFloat64m4:
-case clang::BuiltinType::RvvFloat64m8:
-case clang::BuiltinType::RvvBool1:
-case clang::BuiltinType::RvvBool2:
-case clang::BuiltinType::RvvBool4:
-case clang::BuiltinType::RvvBool8:
-case clang::BuiltinType::RvvBool16:
-case clang::BuiltinType::RvvBool32:
-case clang::BuiltinType::RvvBool64:
-case clang::BuiltinType::RvvInt8mf8x2:
-case clang::BuiltinType::RvvInt8mf8x3:
-case clang::BuiltinType::RvvInt8mf8x4:
-case clang::BuiltinType::RvvInt8mf8x5:
-case clang::BuiltinType::RvvInt8mf8x6:
-case clang::BuiltinType::RvvInt8mf8x7:
-case clang::BuiltinType::RvvInt8mf8x8:
-case clang::BuiltinType::RvvInt8mf4x2:
-case clang::BuiltinType::RvvInt8mf4x3:
-case clang::BuiltinType::RvvInt8mf4x4:
-case clang::BuiltinType::RvvInt8mf4x5:
-case clang::BuiltinType::RvvInt8mf4x6:
-case clang::BuiltinType::RvvInt8mf4x7:
-case clang::BuiltinType::RvvInt8mf4x8:
-case clang::BuiltinType::RvvInt8mf2x2:
-case clang::BuiltinType::RvvInt8mf2x3:
-case clang::BuiltinType::RvvInt8mf2x4:
-case clang::BuiltinType::RvvInt8mf2x5:
-case clang::BuiltinType::RvvInt8mf2x6:
-case clang::BuiltinType::RvvInt8mf2x7:
-case clang::BuiltinType::RvvInt8mf2x8:
-case clang::BuiltinType::RvvInt8m1x2:
-case clang::BuiltinType::RvvInt8m1x3:
-case clang::BuiltinType::RvvInt8m1x4:
-case clang::BuiltinType::RvvInt8m1x5:
-case clang::BuiltinType::RvvInt8m1x6:
-case clang::BuiltinType::RvvInt8m1x7:
-case clang::BuiltinType::RvvInt8m1x8:
-case clang::BuiltinType::RvvInt8m2x2:
-case clang::BuiltinType::RvvInt8m2x3:
-case clang::BuiltinType::RvvInt8m2x4:
-case 

[Lldb-commits] [PATCH] D152922: [lldb][RISCV] Replace enumeration of RVV builtin types with inclusion to RISCVVTypes.def

2023-06-15 Thread Yueh-Ting (eop) Chen via Phabricator via lldb-commits
eopXD updated this revision to Diff 531616.
eopXD added a comment.

Rebase to latest main.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152922/new/

https://reviews.llvm.org/D152922

Files:
  lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp

Index: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp
===
--- lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp
+++ lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp
@@ -5041,298 +5041,8 @@
   break;
 
 // RISC-V V builtin types.
-case clang::BuiltinType::RvvInt8mf8:
-case clang::BuiltinType::RvvInt8mf4:
-case clang::BuiltinType::RvvInt8mf2:
-case clang::BuiltinType::RvvInt8m1:
-case clang::BuiltinType::RvvInt8m2:
-case clang::BuiltinType::RvvInt8m4:
-case clang::BuiltinType::RvvInt8m8:
-case clang::BuiltinType::RvvUint8mf8:
-case clang::BuiltinType::RvvUint8mf4:
-case clang::BuiltinType::RvvUint8mf2:
-case clang::BuiltinType::RvvUint8m1:
-case clang::BuiltinType::RvvUint8m2:
-case clang::BuiltinType::RvvUint8m4:
-case clang::BuiltinType::RvvUint8m8:
-case clang::BuiltinType::RvvInt16mf4:
-case clang::BuiltinType::RvvInt16mf2:
-case clang::BuiltinType::RvvInt16m1:
-case clang::BuiltinType::RvvInt16m2:
-case clang::BuiltinType::RvvInt16m4:
-case clang::BuiltinType::RvvInt16m8:
-case clang::BuiltinType::RvvUint16mf4:
-case clang::BuiltinType::RvvUint16mf2:
-case clang::BuiltinType::RvvUint16m1:
-case clang::BuiltinType::RvvUint16m2:
-case clang::BuiltinType::RvvUint16m4:
-case clang::BuiltinType::RvvUint16m8:
-case clang::BuiltinType::RvvInt32mf2:
-case clang::BuiltinType::RvvInt32m1:
-case clang::BuiltinType::RvvInt32m2:
-case clang::BuiltinType::RvvInt32m4:
-case clang::BuiltinType::RvvInt32m8:
-case clang::BuiltinType::RvvUint32mf2:
-case clang::BuiltinType::RvvUint32m1:
-case clang::BuiltinType::RvvUint32m2:
-case clang::BuiltinType::RvvUint32m4:
-case clang::BuiltinType::RvvUint32m8:
-case clang::BuiltinType::RvvInt64m1:
-case clang::BuiltinType::RvvInt64m2:
-case clang::BuiltinType::RvvInt64m4:
-case clang::BuiltinType::RvvInt64m8:
-case clang::BuiltinType::RvvUint64m1:
-case clang::BuiltinType::RvvUint64m2:
-case clang::BuiltinType::RvvUint64m4:
-case clang::BuiltinType::RvvUint64m8:
-case clang::BuiltinType::RvvFloat16mf4:
-case clang::BuiltinType::RvvFloat16mf2:
-case clang::BuiltinType::RvvFloat16m1:
-case clang::BuiltinType::RvvFloat16m2:
-case clang::BuiltinType::RvvFloat16m4:
-case clang::BuiltinType::RvvFloat16m8:
-case clang::BuiltinType::RvvFloat32mf2:
-case clang::BuiltinType::RvvFloat32m1:
-case clang::BuiltinType::RvvFloat32m2:
-case clang::BuiltinType::RvvFloat32m4:
-case clang::BuiltinType::RvvFloat32m8:
-case clang::BuiltinType::RvvFloat64m1:
-case clang::BuiltinType::RvvFloat64m2:
-case clang::BuiltinType::RvvFloat64m4:
-case clang::BuiltinType::RvvFloat64m8:
-case clang::BuiltinType::RvvBool1:
-case clang::BuiltinType::RvvBool2:
-case clang::BuiltinType::RvvBool4:
-case clang::BuiltinType::RvvBool8:
-case clang::BuiltinType::RvvBool16:
-case clang::BuiltinType::RvvBool32:
-case clang::BuiltinType::RvvBool64:
-case clang::BuiltinType::RvvInt8mf8x2:
-case clang::BuiltinType::RvvInt8mf8x3:
-case clang::BuiltinType::RvvInt8mf8x4:
-case clang::BuiltinType::RvvInt8mf8x5:
-case clang::BuiltinType::RvvInt8mf8x6:
-case clang::BuiltinType::RvvInt8mf8x7:
-case clang::BuiltinType::RvvInt8mf8x8:
-case clang::BuiltinType::RvvInt8mf4x2:
-case clang::BuiltinType::RvvInt8mf4x3:
-case clang::BuiltinType::RvvInt8mf4x4:
-case clang::BuiltinType::RvvInt8mf4x5:
-case clang::BuiltinType::RvvInt8mf4x6:
-case clang::BuiltinType::RvvInt8mf4x7:
-case clang::BuiltinType::RvvInt8mf4x8:
-case clang::BuiltinType::RvvInt8mf2x2:
-case clang::BuiltinType::RvvInt8mf2x3:
-case clang::BuiltinType::RvvInt8mf2x4:
-case clang::BuiltinType::RvvInt8mf2x5:
-case clang::BuiltinType::RvvInt8mf2x6:
-case clang::BuiltinType::RvvInt8mf2x7:
-case clang::BuiltinType::RvvInt8mf2x8:
-case clang::BuiltinType::RvvInt8m1x2:
-case clang::BuiltinType::RvvInt8m1x3:
-case clang::BuiltinType::RvvInt8m1x4:
-case clang::BuiltinType::RvvInt8m1x5:
-case clang::BuiltinType::RvvInt8m1x6:
-case clang::BuiltinType::RvvInt8m1x7:
-case clang::BuiltinType::RvvInt8m1x8:
-case clang::BuiltinType::RvvInt8m2x2:
-case clang::BuiltinType::RvvInt8m2x3:
-case clang::BuiltinType::RvvInt8m2x4:
-case clang::BuiltinType::RvvInt8m4x2:
-case clang::BuiltinType::RvvUint8mf8x2:
-case clang::BuiltinType::RvvUint8mf8x3:
-case clang::BuiltinType::RvvUint8mf8x4:
-case 

[Lldb-commits] [PATCH] D152922: [lldb][RISCV] Replace enumeration of RVV builtin types with inclusion to RISCVVTypes.def

2023-06-14 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett accepted this revision.
DavidSpickett added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: JDevlieghere.

LGTM, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152922/new/

https://reviews.llvm.org/D152922

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits


[Lldb-commits] [PATCH] D152922: [lldb][RISCV] Replace enumeration of RVV builtin types with inclusion to RISCVVTypes.def

2023-06-14 Thread Yueh-Ting (eop) Chen via Phabricator via lldb-commits
eopXD created this revision.
eopXD added a reviewer: DavidSpickett.
Herald added subscribers: jobnoorman, VincentWu, vkmr, luismarques, 
sameer.abuasal, s.egerton, Jim, benna, psnobl, rogfer01, shiva0217, kito-cheng, 
simoncook, asb, arichardson.
Herald added a project: All.
eopXD requested review of this revision.
Herald added subscribers: lldb-commits, pcwang-thead.
Herald added a project: LLDB.

This approach prevents us from adding new lines into the switch case when new 
types are introduced.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D152922

Files:
  lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp


Index: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp
===
--- lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp
+++ lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp
@@ -5041,73 +5041,8 @@
   break;
 
 // RISC-V V builtin types.
-case clang::BuiltinType::RvvInt8mf8:
-case clang::BuiltinType::RvvInt8mf4:
-case clang::BuiltinType::RvvInt8mf2:
-case clang::BuiltinType::RvvInt8m1:
-case clang::BuiltinType::RvvInt8m2:
-case clang::BuiltinType::RvvInt8m4:
-case clang::BuiltinType::RvvInt8m8:
-case clang::BuiltinType::RvvUint8mf8:
-case clang::BuiltinType::RvvUint8mf4:
-case clang::BuiltinType::RvvUint8mf2:
-case clang::BuiltinType::RvvUint8m1:
-case clang::BuiltinType::RvvUint8m2:
-case clang::BuiltinType::RvvUint8m4:
-case clang::BuiltinType::RvvUint8m8:
-case clang::BuiltinType::RvvInt16mf4:
-case clang::BuiltinType::RvvInt16mf2:
-case clang::BuiltinType::RvvInt16m1:
-case clang::BuiltinType::RvvInt16m2:
-case clang::BuiltinType::RvvInt16m4:
-case clang::BuiltinType::RvvInt16m8:
-case clang::BuiltinType::RvvUint16mf4:
-case clang::BuiltinType::RvvUint16mf2:
-case clang::BuiltinType::RvvUint16m1:
-case clang::BuiltinType::RvvUint16m2:
-case clang::BuiltinType::RvvUint16m4:
-case clang::BuiltinType::RvvUint16m8:
-case clang::BuiltinType::RvvInt32mf2:
-case clang::BuiltinType::RvvInt32m1:
-case clang::BuiltinType::RvvInt32m2:
-case clang::BuiltinType::RvvInt32m4:
-case clang::BuiltinType::RvvInt32m8:
-case clang::BuiltinType::RvvUint32mf2:
-case clang::BuiltinType::RvvUint32m1:
-case clang::BuiltinType::RvvUint32m2:
-case clang::BuiltinType::RvvUint32m4:
-case clang::BuiltinType::RvvUint32m8:
-case clang::BuiltinType::RvvInt64m1:
-case clang::BuiltinType::RvvInt64m2:
-case clang::BuiltinType::RvvInt64m4:
-case clang::BuiltinType::RvvInt64m8:
-case clang::BuiltinType::RvvUint64m1:
-case clang::BuiltinType::RvvUint64m2:
-case clang::BuiltinType::RvvUint64m4:
-case clang::BuiltinType::RvvUint64m8:
-case clang::BuiltinType::RvvFloat16mf4:
-case clang::BuiltinType::RvvFloat16mf2:
-case clang::BuiltinType::RvvFloat16m1:
-case clang::BuiltinType::RvvFloat16m2:
-case clang::BuiltinType::RvvFloat16m4:
-case clang::BuiltinType::RvvFloat16m8:
-case clang::BuiltinType::RvvFloat32mf2:
-case clang::BuiltinType::RvvFloat32m1:
-case clang::BuiltinType::RvvFloat32m2:
-case clang::BuiltinType::RvvFloat32m4:
-case clang::BuiltinType::RvvFloat32m8:
-case clang::BuiltinType::RvvFloat64m1:
-case clang::BuiltinType::RvvFloat64m2:
-case clang::BuiltinType::RvvFloat64m4:
-case clang::BuiltinType::RvvFloat64m8:
-case clang::BuiltinType::RvvBool1:
-case clang::BuiltinType::RvvBool2:
-case clang::BuiltinType::RvvBool4:
-case clang::BuiltinType::RvvBool8:
-case clang::BuiltinType::RvvBool16:
-case clang::BuiltinType::RvvBool32:
-case clang::BuiltinType::RvvBool64:
-case clang::BuiltinType::RvvInt32m1x2:
+#define RVV_TYPE(Name, Id, SingletonId) case clang::BuiltinType::Id:
+#include "clang/Basic/RISCVVTypes.def"
   break;
 
 // WebAssembly builtin types.


Index: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp
===
--- lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp
+++ lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp
@@ -5041,73 +5041,8 @@
   break;
 
 // RISC-V V builtin types.
-case clang::BuiltinType::RvvInt8mf8:
-case clang::BuiltinType::RvvInt8mf4:
-case clang::BuiltinType::RvvInt8mf2:
-case clang::BuiltinType::RvvInt8m1:
-case clang::BuiltinType::RvvInt8m2:
-case clang::BuiltinType::RvvInt8m4:
-case clang::BuiltinType::RvvInt8m8:
-case clang::BuiltinType::RvvUint8mf8:
-case clang::BuiltinType::RvvUint8mf4:
-case clang::BuiltinType::RvvUint8mf2:
-case clang::BuiltinType::RvvUint8m1:
-case clang::BuiltinType::RvvUint8m2:
-case clang::BuiltinType::RvvUint8m4:
-case clang::BuiltinType::RvvUint8m8:
-case clang::BuiltinType::RvvInt16mf4:
-case clang::BuiltinType::RvvInt16mf2: