[Lldb-commits] [PATCH] D154843: [lldb] Disable TestNamespaceLookup in DWARF 5 + dSYM setting
This revision was automatically updated to reflect the committed changes.
Closed by commit rG6890ad3f41c5: [lldb] Disable TestNamespaceLookup in DWARF 5
+ dSYM setting (authored by fdeazeve).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154843/new/
https://reviews.llvm.org/D154843
Files:
lldb/test/API/lang/cpp/namespace/TestNamespaceLookup.py
Index: lldb/test/API/lang/cpp/namespace/TestNamespaceLookup.py
===
--- lldb/test/API/lang/cpp/namespace/TestNamespaceLookup.py
+++ lldb/test/API/lang/cpp/namespace/TestNamespaceLookup.py
@@ -164,7 +164,11 @@
# Continue to BP_file_scope at file scope
self.runToBkpt("continue")
-self.expect_expr("func()", result_type="int", result_value="2")
+# FIXME: In DWARF 5 with dsyms, the ordering of functions is slightly
+# different, which also hits the same issues mentioned previously.
+if (configuration.dwarf_version <= 4 or
+self.getDebugInfo() == 'dwarf'):
+self.expect_expr("func()", result_type="int", result_value="2")
# Continue to BP_ns_scope at ns scope
self.runToBkpt("continue")
Index: lldb/test/API/lang/cpp/namespace/TestNamespaceLookup.py
===
--- lldb/test/API/lang/cpp/namespace/TestNamespaceLookup.py
+++ lldb/test/API/lang/cpp/namespace/TestNamespaceLookup.py
@@ -164,7 +164,11 @@
# Continue to BP_file_scope at file scope
self.runToBkpt("continue")
-self.expect_expr("func()", result_type="int", result_value="2")
+# FIXME: In DWARF 5 with dsyms, the ordering of functions is slightly
+# different, which also hits the same issues mentioned previously.
+if (configuration.dwarf_version <= 4 or
+self.getDebugInfo() == 'dwarf'):
+self.expect_expr("func()", result_type="int", result_value="2")
# Continue to BP_ns_scope at ns scope
self.runToBkpt("continue")
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D154843: [lldb] Disable TestNamespaceLookup in DWARF 5 + dSYM setting
fdeazeve created this revision.
Herald added a project: All.
fdeazeve requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
The ordering in which functions are presented to the expression evaluator in
this test setting triggers a known bug in LLDB.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D154843
Files:
lldb/test/API/lang/cpp/namespace/TestNamespaceLookup.py
Index: lldb/test/API/lang/cpp/namespace/TestNamespaceLookup.py
===
--- lldb/test/API/lang/cpp/namespace/TestNamespaceLookup.py
+++ lldb/test/API/lang/cpp/namespace/TestNamespaceLookup.py
@@ -164,7 +164,11 @@
# Continue to BP_file_scope at file scope
self.runToBkpt("continue")
-self.expect_expr("func()", result_type="int", result_value="2")
+# FIXME: In DWARF 5 with dsyms, the ordering of functions is slightly
+# different, which also hits the same issues mentioned previously.
+if (configuration.dwarf_version <= 4 or
+self.getDebugInfo() == 'dwarf'):
+self.expect_expr("func()", result_type="int", result_value="2")
# Continue to BP_ns_scope at ns scope
self.runToBkpt("continue")
Index: lldb/test/API/lang/cpp/namespace/TestNamespaceLookup.py
===
--- lldb/test/API/lang/cpp/namespace/TestNamespaceLookup.py
+++ lldb/test/API/lang/cpp/namespace/TestNamespaceLookup.py
@@ -164,7 +164,11 @@
# Continue to BP_file_scope at file scope
self.runToBkpt("continue")
-self.expect_expr("func()", result_type="int", result_value="2")
+# FIXME: In DWARF 5 with dsyms, the ordering of functions is slightly
+# different, which also hits the same issues mentioned previously.
+if (configuration.dwarf_version <= 4 or
+self.getDebugInfo() == 'dwarf'):
+self.expect_expr("func()", result_type="int", result_value="2")
# Continue to BP_ns_scope at ns scope
self.runToBkpt("continue")
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
