[Lldb-commits] [PATCH] D158024: [lldb][NFCI] Remove unused method overload of ValueObject::GetChildAtNamePath

[Alex Langford via Phabricator via lldb-commits]

This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG2f382bfb14e3: [lldb][NFCI] Remove unused method overload of 
ValueObject::GetChildAtNamePath (authored by bulbazord).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158024/new/

https://reviews.llvm.org/D158024

Files:
  lldb/include/lldb/Core/ValueObject.h
  lldb/source/Core/ValueObject.cpp


Index: lldb/source/Core/ValueObject.cpp
===
--- lldb/source/Core/ValueObject.cpp
+++ lldb/source/Core/ValueObject.cpp
@@ -440,23 +440,6 @@
   return root;
 }
 
-lldb::ValueObjectSP ValueObject::GetChildAtNamePath(
-llvm::ArrayRef> names,
-ConstString *name_of_error) {
-  if (names.size() == 0)
-return GetSP();
-  ValueObjectSP root(GetSP());
-  for (std::pair name : names) {
-root = root->GetChildMemberWithName(name.first, name.second);
-if (!root) {
-  if (name_of_error)
-*name_of_error = name.first;
-  return root;
-}
-  }
-  return root;
-}
-
 size_t ValueObject::GetIndexOfChildWithName(llvm::StringRef name) {
   bool omit_empty_base_classes = true;
   return GetCompilerType().GetIndexOfChildWithName(name,
Index: lldb/include/lldb/Core/ValueObject.h
===
--- lldb/include/lldb/Core/ValueObject.h
+++ lldb/include/lldb/Core/ValueObject.h
@@ -479,10 +479,6 @@
   // this will always create the children if necessary
   lldb::ValueObjectSP GetChildAtNamePath(llvm::ArrayRef 
names);
 
-  lldb::ValueObjectSP
-  GetChildAtNamePath(llvm::ArrayRef> names,
- ConstString *name_of_error = nullptr);
-
   virtual lldb::ValueObjectSP GetChildMemberWithName(llvm::StringRef name,
  bool can_create = true);
 


Index: lldb/source/Core/ValueObject.cpp
===
--- lldb/source/Core/ValueObject.cpp
+++ lldb/source/Core/ValueObject.cpp
@@ -440,23 +440,6 @@
   return root;
 }
 
-lldb::ValueObjectSP ValueObject::GetChildAtNamePath(
-llvm::ArrayRef> names,
-ConstString *name_of_error) {
-  if (names.size() == 0)
-return GetSP();
-  ValueObjectSP root(GetSP());
-  for (std::pair name : names) {
-root = root->GetChildMemberWithName(name.first, name.second);
-if (!root) {
-  if (name_of_error)
-*name_of_error = name.first;
-  return root;
-}
-  }
-  return root;
-}
-
 size_t ValueObject::GetIndexOfChildWithName(llvm::StringRef name) {
   bool omit_empty_base_classes = true;
   return GetCompilerType().GetIndexOfChildWithName(name,
Index: lldb/include/lldb/Core/ValueObject.h
===
--- lldb/include/lldb/Core/ValueObject.h
+++ lldb/include/lldb/Core/ValueObject.h
@@ -479,10 +479,6 @@
   // this will always create the children if necessary
   lldb::ValueObjectSP GetChildAtNamePath(llvm::ArrayRef names);
 
-  lldb::ValueObjectSP
-  GetChildAtNamePath(llvm::ArrayRef> names,
- ConstString *name_of_error = nullptr);
-
   virtual lldb::ValueObjectSP GetChildMemberWithName(llvm::StringRef name,
  bool can_create = true);
 
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D158024: [lldb][NFCI] Remove unused method overload of ValueObject::GetChildAtNamePath

[Alex Langford via Phabricator via lldb-commits]

bulbazord created this revision.
bulbazord added reviewers: JDevlieghere, kastiglione, jingham.
Herald added a project: All.
bulbazord requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D158024

Files:
  lldb/include/lldb/Core/ValueObject.h
  lldb/source/Core/ValueObject.cpp


Index: lldb/source/Core/ValueObject.cpp
===
--- lldb/source/Core/ValueObject.cpp
+++ lldb/source/Core/ValueObject.cpp
@@ -440,23 +440,6 @@
   return root;
 }
 
-lldb::ValueObjectSP ValueObject::GetChildAtNamePath(
-llvm::ArrayRef> names,
-ConstString *name_of_error) {
-  if (names.size() == 0)
-return GetSP();
-  ValueObjectSP root(GetSP());
-  for (std::pair name : names) {
-root = root->GetChildMemberWithName(name.first, name.second);
-if (!root) {
-  if (name_of_error)
-*name_of_error = name.first;
-  return root;
-}
-  }
-  return root;
-}
-
 size_t ValueObject::GetIndexOfChildWithName(llvm::StringRef name) {
   bool omit_empty_base_classes = true;
   return GetCompilerType().GetIndexOfChildWithName(name,
Index: lldb/include/lldb/Core/ValueObject.h
===
--- lldb/include/lldb/Core/ValueObject.h
+++ lldb/include/lldb/Core/ValueObject.h
@@ -479,10 +479,6 @@
   // this will always create the children if necessary
   lldb::ValueObjectSP GetChildAtNamePath(llvm::ArrayRef 
names);
 
-  lldb::ValueObjectSP
-  GetChildAtNamePath(llvm::ArrayRef> names,
- ConstString *name_of_error = nullptr);
-
   virtual lldb::ValueObjectSP GetChildMemberWithName(llvm::StringRef name,
  bool can_create = true);
 


Index: lldb/source/Core/ValueObject.cpp
===
--- lldb/source/Core/ValueObject.cpp
+++ lldb/source/Core/ValueObject.cpp
@@ -440,23 +440,6 @@
   return root;
 }
 
-lldb::ValueObjectSP ValueObject::GetChildAtNamePath(
-llvm::ArrayRef> names,
-ConstString *name_of_error) {
-  if (names.size() == 0)
-return GetSP();
-  ValueObjectSP root(GetSP());
-  for (std::pair name : names) {
-root = root->GetChildMemberWithName(name.first, name.second);
-if (!root) {
-  if (name_of_error)
-*name_of_error = name.first;
-  return root;
-}
-  }
-  return root;
-}
-
 size_t ValueObject::GetIndexOfChildWithName(llvm::StringRef name) {
   bool omit_empty_base_classes = true;
   return GetCompilerType().GetIndexOfChildWithName(name,
Index: lldb/include/lldb/Core/ValueObject.h
===
--- lldb/include/lldb/Core/ValueObject.h
+++ lldb/include/lldb/Core/ValueObject.h
@@ -479,10 +479,6 @@
   // this will always create the children if necessary
   lldb::ValueObjectSP GetChildAtNamePath(llvm::ArrayRef names);
 
-  lldb::ValueObjectSP
-  GetChildAtNamePath(llvm::ArrayRef> names,
- ConstString *name_of_error = nullptr);
-
   virtual lldb::ValueObjectSP GetChildMemberWithName(llvm::StringRef name,
  bool can_create = true);
 
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits