Re: [Lldb-commits] [PATCH] D18631: Make sure to update Target arch if environment changed

2016-04-05 Thread Stephane Sezer via lldb-commits 
sas closed this revision.
sas added a comment.

Committed as r265419.


http://reviews.llvm.org/D18631



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D18631: Make sure to update Target arch if environment changed

2016-03-31 Thread Francis Ricci via lldb-commits 
fjricci added a comment.

android is detected from the ELF, so we can get around using the gdb-remote 
info.


http://reviews.llvm.org/D18631



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D18631: Make sure to update Target arch if environment changed

2016-03-31 Thread Tamas Berghammer via lldb-commits 
tberghammer accepted this revision.
tberghammer added a reviewer: tberghammer.
tberghammer added a comment.

Looks good but I don't understand why android is working while other linux 
platforms isn't.


http://reviews.llvm.org/D18631



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D18631: Make sure to update Target arch if environment changed

2016-03-30 Thread Francis Ricci via lldb-commits 
fjricci created this revision.
fjricci added reviewers: jasonmolenda, tfiala, clayborg.
fjricci added subscribers: sas, lldb-commits.
Herald added subscribers: danalbert, tberghammer.

Fixes "target list" for non-android linux platforms (ie gnu, gnueabi)

http://reviews.llvm.org/D18631

Files:
  source/Target/Target.cpp

Index: source/Target/Target.cpp
===
--- source/Target/Target.cpp
+++ source/Target/Target.cpp
@@ -1301,7 +1301,7 @@
   os_ver_changed,
   env_changed);
 
-if (!arch_changed && !vendor_changed && !os_changed)
+if (!arch_changed && !vendor_changed && !os_changed && 
!env_changed)
 replace_local_arch = false;
 }
 }


Index: source/Target/Target.cpp
===
--- source/Target/Target.cpp
+++ source/Target/Target.cpp
@@ -1301,7 +1301,7 @@
   os_ver_changed,
   env_changed);
 
-if (!arch_changed && !vendor_changed && !os_changed)
+if (!arch_changed && !vendor_changed && !os_changed && !env_changed)
 replace_local_arch = false;
 }
 }
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits