[Lldb-commits] [PATCH] D25488: Fix test suite lookup path for LLDB.h

2016-10-13 Thread Todd Fiala via lldb-commits
tfiala added a comment.

(Retro) LGTM.


Repository:
  rL LLVM

https://reviews.llvm.org/D25488



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits


[Lldb-commits] [PATCH] D25488: Fix test suite lookup path for LLDB.h

2016-10-12 Thread Chris Bieneman via lldb-commits
beanz added a comment.

@labath I think having them running is useful. At the moment that is probably 
the only Darwin bot building LLDB using CMake.


https://reviews.llvm.org/D25488



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits


[Lldb-commits] [PATCH] D25488: Fix test suite lookup path for LLDB.h

2016-10-12 Thread Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284043: Fix test suite lookup path for LLDB.h (authored by 
cbieneman).

Changed prior to commit:
  https://reviews.llvm.org/D25488?vs=74294&id=74431#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D25488

Files:
  lldb/trunk/packages/Python/lldbsuite/test/decorators.py


Index: lldb/trunk/packages/Python/lldbsuite/test/decorators.py
===
--- lldb/trunk/packages/Python/lldbsuite/test/decorators.py
+++ lldb/trunk/packages/Python/lldbsuite/test/decorators.py
@@ -512,13 +512,15 @@
 'Current',
 'Headers',
 'LLDB.h')
-else:
-header = os.path.join(
-os.environ["LLDB_SRC"],
-"include",
-"lldb",
-"API",
-"LLDB.h")
+if os.path.exists(header):
+return None
+
+header = os.path.join(
+os.environ["LLDB_SRC"],
+"include",
+"lldb",
+"API",
+"LLDB.h")
 if not os.path.exists(header):
 return "skip because LLDB.h header not found"
 return None


Index: lldb/trunk/packages/Python/lldbsuite/test/decorators.py
===
--- lldb/trunk/packages/Python/lldbsuite/test/decorators.py
+++ lldb/trunk/packages/Python/lldbsuite/test/decorators.py
@@ -512,13 +512,15 @@
 'Current',
 'Headers',
 'LLDB.h')
-else:
-header = os.path.join(
-os.environ["LLDB_SRC"],
-"include",
-"lldb",
-"API",
-"LLDB.h")
+if os.path.exists(header):
+return None
+
+header = os.path.join(
+os.environ["LLDB_SRC"],
+"include",
+"lldb",
+"API",
+"LLDB.h")
 if not os.path.exists(header):
 return "skip because LLDB.h header not found"
 return None
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits


[Lldb-commits] [PATCH] D25488: Fix test suite lookup path for LLDB.h

2016-10-12 Thread Pavel Labath via lldb-commits
labath added a comment.

Our darwin buildbot is also running the local test suite with cmake: 
http://lab.llvm.org:8011/builders/lldb-x86_64-darwin-13.4, look under build 
step "test9 local test". We've been considering turning these tests off as we 
don't have bandwidth to monitor and fix them, but if you find them helpful, we 
can certainly keep them running.


https://reviews.llvm.org/D25488



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits


[Lldb-commits] [PATCH] D25488: Fix test suite lookup path for LLDB.h

2016-10-11 Thread Chris Bieneman via lldb-commits
beanz created this revision.
beanz added reviewers: tfiala, zturner.
beanz added a subscriber: lldb-commits.

When running on Darwin, the test suite assumes a specific directory structure 
for the build directory. This works for the Xcode project builds, but fails for 
CMake builds regardless of whether or not you are generating the LLDB framework.

This patch allows the Darwin code path to fall back to the more generic code 
path used by other platforms in the event that LLDB.h isn't where the test 
suite expects it.

This allows API tests to run on Darwin when building with CMake with the 
framework build enabled or disabled.


https://reviews.llvm.org/D25488

Files:
  packages/Python/lldbsuite/test/decorators.py


Index: packages/Python/lldbsuite/test/decorators.py
===
--- packages/Python/lldbsuite/test/decorators.py
+++ packages/Python/lldbsuite/test/decorators.py
@@ -512,13 +512,15 @@
 'Current',
 'Headers',
 'LLDB.h')
-else:
-header = os.path.join(
-os.environ["LLDB_SRC"],
-"include",
-"lldb",
-"API",
-"LLDB.h")
+if os.path.exists(header):
+return None
+
+header = os.path.join(
+os.environ["LLDB_SRC"],
+"include",
+"lldb",
+"API",
+"LLDB.h")
 if not os.path.exists(header):
 return "skip because LLDB.h header not found"
 return None


Index: packages/Python/lldbsuite/test/decorators.py
===
--- packages/Python/lldbsuite/test/decorators.py
+++ packages/Python/lldbsuite/test/decorators.py
@@ -512,13 +512,15 @@
 'Current',
 'Headers',
 'LLDB.h')
-else:
-header = os.path.join(
-os.environ["LLDB_SRC"],
-"include",
-"lldb",
-"API",
-"LLDB.h")
+if os.path.exists(header):
+return None
+
+header = os.path.join(
+os.environ["LLDB_SRC"],
+"include",
+"lldb",
+"API",
+"LLDB.h")
 if not os.path.exists(header):
 return "skip because LLDB.h header not found"
 return None
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits