[Lldb-commits] [PATCH] D27126: Merge Linux and FreeBSD arm register contexts

[Pavel Labath via Phabricator via lldb-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL296335: Merge Linux and FreeBSD arm register contexts 
(authored by labath).

Changed prior to commit:
  https://reviews.llvm.org/D27126?vs=79287=89866#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D27126

Files:
  lldb/trunk/source/Plugins/Process/FreeBSD/FreeBSDThread.cpp
  lldb/trunk/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm.cpp
  lldb/trunk/source/Plugins/Process/Utility/CMakeLists.txt
  lldb/trunk/source/Plugins/Process/Utility/RegisterContextFreeBSD_arm.cpp
  lldb/trunk/source/Plugins/Process/Utility/RegisterContextFreeBSD_arm.h
  lldb/trunk/source/Plugins/Process/Utility/RegisterContextLinux_arm.cpp
  lldb/trunk/source/Plugins/Process/Utility/RegisterContextLinux_arm.h
  lldb/trunk/source/Plugins/Process/Utility/RegisterInfoPOSIX_arm.cpp
  lldb/trunk/source/Plugins/Process/Utility/RegisterInfoPOSIX_arm.h
  lldb/trunk/source/Plugins/Process/elf-core/ThreadElfCore.cpp

Index: lldb/trunk/source/Plugins/Process/elf-core/ThreadElfCore.cpp
===
--- lldb/trunk/source/Plugins/Process/elf-core/ThreadElfCore.cpp
+++ lldb/trunk/source/Plugins/Process/elf-core/ThreadElfCore.cpp
@@ -14,15 +14,14 @@
 #include "lldb/Target/Target.h"
 #include "lldb/Target/Unwind.h"
 
-#include "Plugins/Process/Utility/RegisterContextFreeBSD_arm.h"
 #include "Plugins/Process/Utility/RegisterContextFreeBSD_i386.h"
 #include "Plugins/Process/Utility/RegisterContextFreeBSD_mips64.h"
 #include "Plugins/Process/Utility/RegisterContextFreeBSD_powerpc.h"
 #include "Plugins/Process/Utility/RegisterContextFreeBSD_x86_64.h"
-#include "Plugins/Process/Utility/RegisterContextLinux_arm.h"
 #include "Plugins/Process/Utility/RegisterContextLinux_i386.h"
 #include "Plugins/Process/Utility/RegisterContextLinux_s390x.h"
 #include "Plugins/Process/Utility/RegisterContextLinux_x86_64.h"
+#include "Plugins/Process/Utility/RegisterInfoPOSIX_arm.h"
 #include "Plugins/Process/Utility/RegisterInfoPOSIX_arm64.h"
 #include "ProcessElfCore.h"
 #include "RegisterContextPOSIXCore_arm.h"
@@ -88,7 +87,7 @@
 reg_interface = new RegisterInfoPOSIX_arm64(arch);
 break;
   case llvm::Triple::arm:
-reg_interface = new RegisterContextFreeBSD_arm(arch);
+reg_interface = new RegisterInfoPOSIX_arm(arch);
 break;
   case llvm::Triple::ppc:
 reg_interface = new RegisterContextFreeBSD_powerpc32(arch);
@@ -114,7 +113,7 @@
 case llvm::Triple::Linux: {
   switch (arch.GetMachine()) {
   case llvm::Triple::arm:
-reg_interface = new RegisterContextLinux_arm(arch);
+reg_interface = new RegisterInfoPOSIX_arm(arch);
 break;
   case llvm::Triple::aarch64:
 reg_interface = new RegisterInfoPOSIX_arm64(arch);
Index: lldb/trunk/source/Plugins/Process/FreeBSD/FreeBSDThread.cpp
===
--- lldb/trunk/source/Plugins/Process/FreeBSD/FreeBSDThread.cpp
+++ lldb/trunk/source/Plugins/Process/FreeBSD/FreeBSDThread.cpp
@@ -18,11 +18,11 @@
 // Project includes
 #include "FreeBSDThread.h"
 #include "POSIXStopInfo.h"
-#include "Plugins/Process/Utility/RegisterContextFreeBSD_arm.h"
 #include "Plugins/Process/Utility/RegisterContextFreeBSD_i386.h"
 #include "Plugins/Process/Utility/RegisterContextFreeBSD_mips64.h"
 #include "Plugins/Process/Utility/RegisterContextFreeBSD_powerpc.h"
 #include "Plugins/Process/Utility/RegisterContextFreeBSD_x86_64.h"
+#include "Plugins/Process/Utility/RegisterInfoPOSIX_arm.h"
 #include "Plugins/Process/Utility/RegisterInfoPOSIX_arm64.h"
 #include "Plugins/Process/Utility/UnwindLLDB.h"
 #include "ProcessFreeBSD.h"
@@ -137,7 +137,7 @@
   reg_interface = new RegisterInfoPOSIX_arm64(target_arch);
   break;
 case llvm::Triple::arm:
-  reg_interface = new RegisterContextFreeBSD_arm(target_arch);
+  reg_interface = new RegisterInfoPOSIX_arm(target_arch);
   break;
 case llvm::Triple::ppc:
 #ifndef __powerpc64__
Index: lldb/trunk/source/Plugins/Process/Utility/RegisterInfoPOSIX_arm.cpp
===
--- lldb/trunk/source/Plugins/Process/Utility/RegisterInfoPOSIX_arm.cpp
+++ lldb/trunk/source/Plugins/Process/Utility/RegisterInfoPOSIX_arm.cpp
@@ -0,0 +1,94 @@
+//===-- RegisterInfoPOSIX_arm.cpp --*- C++ -*-===//
+//
+// The LLVM Compiler Infrastructure
+//
+// This file is distributed under the University of Illinois Open Source
+// License. See LICENSE.TXT for details.
+//
+//===-===//
+
+#include 
+#include 
+#include 
+
+#include "lldb/lldb-defines.h"
+#include "llvm/Support/Compiler.h"
+
+#include "RegisterInfoPOSIX_arm.h"
+
+using namespace lldb;
+using namespace lldb_private;
+
+// Based on RegisterContextDarwin_arm.cpp
+#define 

[Lldb-commits] [PATCH] D27126: Merge Linux and FreeBSD arm register contexts

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

Just found this lying on the bottom of my stack. Ed, if you don't object, I'd 
like to check in it. I think it is quite a safe change, so we probably don't 
need to do too much testing.


https://reviews.llvm.org/D27126



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D27126: Merge Linux and FreeBSD arm register contexts

[Ed Maste via Phabricator via lldb-commits]

emaste added a comment.

In https://reviews.llvm.org/D27126#609150, @labath wrote:

> In https://reviews.llvm.org/D27126#607057, @dmikulin wrote:
>
> > I can run tests on 32bit ARM FreeBSD 11.RC3 rpi2, but without software 
> > single step not a lot of tests pass on ARM FreeBSD ;)
> >  Can we get https://reviews.llvm.org/D25756 committed?
>
>
> I'll leave that decision up to Ed.
>  I am not particularly fond of copying code around, but I do see the value of 
> having some freebsd arm support instead of none.


I'd be happy for https://reviews.llvm.org/D25756 to go in, but have a few 
comments added just now that should be addressed.


https://reviews.llvm.org/D27126



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D27126: Merge Linux and FreeBSD arm register contexts

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

In https://reviews.llvm.org/D27126#607057, @dmikulin wrote:

> I can run tests on 32bit ARM FreeBSD 11.RC3 rpi2, but without software single 
> step not a lot of tests pass on ARM FreeBSD ;)
>  Can we get https://reviews.llvm.org/D25756 committed?


I'll leave that decision up to Ed.
I am not particularly fond of copying code around, but I do see the value of 
having some freebsd arm support instead of none.

As for this patch. A basic does-it-compile test should be enough, but I am 
pretty confident this is fine even without it, as I am just merging two 
identical files.


https://reviews.llvm.org/D27126



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits