[Lldb-commits] [PATCH] D54886: Add support for the Dylan language to ClangASTContext
This revision was automatically updated to reflect the committed changes. Closed by commit rL347637: Add support for the Dylan language to ClangASTContext (authored by brucem, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54886/new/ https://reviews.llvm.org/D54886 Files: lldb/trunk/source/Symbol/ClangASTContext.cpp Index: lldb/trunk/source/Symbol/ClangASTContext.cpp === --- lldb/trunk/source/Symbol/ClangASTContext.cpp +++ lldb/trunk/source/Symbol/ClangASTContext.cpp @@ -119,7 +119,9 @@ language == eLanguageTypeRust || language == eLanguageTypeExtRenderScript || // Use Clang for D until there is a proper language plugin for it - language == eLanguageTypeD; + language == eLanguageTypeD || + // Open Dylan compiler debug info is designed to be Clang-compatible + language == eLanguageTypeDylan; } // Checks whether m1 is an overload of m2 (as opposed to an override). This is Index: lldb/trunk/source/Symbol/ClangASTContext.cpp === --- lldb/trunk/source/Symbol/ClangASTContext.cpp +++ lldb/trunk/source/Symbol/ClangASTContext.cpp @@ -119,7 +119,9 @@ language == eLanguageTypeRust || language == eLanguageTypeExtRenderScript || // Use Clang for D until there is a proper language plugin for it - language == eLanguageTypeD; + language == eLanguageTypeD || + // Open Dylan compiler debug info is designed to be Clang-compatible + language == eLanguageTypeDylan; } // Checks whether m1 is an overload of m2 (as opposed to an override). This is ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D54886: Add support for the Dylan language to ClangASTContext
housel updated this revision to Diff 175391. housel added a comment. Updated against r347619 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54886/new/ https://reviews.llvm.org/D54886 Files: source/Symbol/ClangASTContext.cpp Index: source/Symbol/ClangASTContext.cpp === --- source/Symbol/ClangASTContext.cpp +++ source/Symbol/ClangASTContext.cpp @@ -119,7 +119,9 @@ language == eLanguageTypeRust || language == eLanguageTypeExtRenderScript || // Use Clang for D until there is a proper language plugin for it - language == eLanguageTypeD; + language == eLanguageTypeD || + // Open Dylan compiler debug info is designed to be Clang-compatible + language == eLanguageTypeDylan; } // Checks whether m1 is an overload of m2 (as opposed to an override). This is Index: source/Symbol/ClangASTContext.cpp === --- source/Symbol/ClangASTContext.cpp +++ source/Symbol/ClangASTContext.cpp @@ -119,7 +119,9 @@ language == eLanguageTypeRust || language == eLanguageTypeExtRenderScript || // Use Clang for D until there is a proper language plugin for it - language == eLanguageTypeD; + language == eLanguageTypeD || + // Open Dylan compiler debug info is designed to be Clang-compatible + language == eLanguageTypeDylan; } // Checks whether m1 is an overload of m2 (as opposed to an override). This is ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D54886: Add support for the Dylan language to ClangASTContext
brucem added a comment. I can land this today. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54886/new/ https://reviews.llvm.org/D54886 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D54886: Add support for the Dylan language to ClangASTContext
housel added a comment. I don't have commit access; could someone land this please? Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54886/new/ https://reviews.llvm.org/D54886 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D54886: Add support for the Dylan language to ClangASTContext
housel updated this revision to Diff 175385. housel added a comment. Adds an inline comment about Open Dylan debug info CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54886/new/ https://reviews.llvm.org/D54886 Files: source/Symbol/ClangASTContext.cpp Index: source/Symbol/ClangASTContext.cpp === --- source/Symbol/ClangASTContext.cpp +++ source/Symbol/ClangASTContext.cpp @@ -119,7 +119,9 @@ language == eLanguageTypeRust || language == eLanguageTypeExtRenderScript || // Use Clang for D until there is a proper language plugin for it - language == eLanguageTypeD; + language == eLanguageTypeD || + // Open Dylan compiler debug info is designed to be Clang-compatible + language == eLanguageTypeDylan; } // Checks whether m1 is an overload of m2 (as opposed to an override). This is Index: source/Symbol/ClangASTContext.cpp === --- source/Symbol/ClangASTContext.cpp +++ source/Symbol/ClangASTContext.cpp @@ -119,7 +119,9 @@ language == eLanguageTypeRust || language == eLanguageTypeExtRenderScript || // Use Clang for D until there is a proper language plugin for it - language == eLanguageTypeD; + language == eLanguageTypeD || + // Open Dylan compiler debug info is designed to be Clang-compatible + language == eLanguageTypeDylan; } // Checks whether m1 is an overload of m2 (as opposed to an override). This is ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D54886: Add support for the Dylan language to ClangASTContext
aprantl added inline comments. Comment at: source/Symbol/ClangASTContext.cpp:123 + language == eLanguageTypeD || + language == eLanguageTypeDylan; } Please add a comment explaining that "The Debug info generated by the Open Dylan compiler's LLVM back-end was designed to be compatible with C debug info." CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54886/new/ https://reviews.llvm.org/D54886 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
