[Lldb-commits] [lldb] [LLDB][easy] Fix a bug in DummySyntheticFrontEnd (PR #71143)

2023-11-02 Thread Walter Erquinigo via lldb-commits 

https://github.com/walter-erquinigo closed 
https://github.com/llvm/llvm-project/pull/71143
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][easy] Fix a bug in DummySyntheticFrontEnd (PR #71143)

2023-11-02 Thread Jonas Devlieghere via lldb-commits 

https://github.com/JDevlieghere approved this pull request.

Seems obvious. LGTM!

https://github.com/llvm/llvm-project/pull/71143
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][easy] Fix a bug in DummySyntheticFrontEnd (PR #71143)

2023-11-02 Thread via lldb-commits 

llvmbot wrote:




@llvm/pr-subscribers-lldb

Author: Walter Erquinigo (walter-erquinigo)


Changes

DummySyntheticFrontEnd is implementing correctly CalculateNumChildren but not 
MightHaveChildren, where instead of delegating its action, it was returning 
true.
This fixes that simple bug.


---
Full diff: https://github.com/llvm/llvm-project/pull/71143.diff


1 Files Affected:

- (modified) lldb/source/Core/ValueObjectSyntheticFilter.cpp (+1-1) 


``diff
diff --git a/lldb/source/Core/ValueObjectSyntheticFilter.cpp 
b/lldb/source/Core/ValueObjectSyntheticFilter.cpp
index 59ed780b654f3af..43bc532c4a0410b 100644
--- a/lldb/source/Core/ValueObjectSyntheticFilter.cpp
+++ b/lldb/source/Core/ValueObjectSyntheticFilter.cpp
@@ -41,7 +41,7 @@ class DummySyntheticFrontEnd : public 
SyntheticChildrenFrontEnd {
 return m_backend.GetIndexOfChildWithName(name);
   }
 
-  bool MightHaveChildren() override { return true; }
+  bool MightHaveChildren() override { return m_backend.MightHaveChildren(); }
 
   bool Update() override { return false; }
 };

``




https://github.com/llvm/llvm-project/pull/71143
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][easy] Fix a bug in DummySyntheticFrontEnd (PR #71143)

2023-11-02 Thread Walter Erquinigo via lldb-commits 

https://github.com/walter-erquinigo created 
https://github.com/llvm/llvm-project/pull/71143

DummySyntheticFrontEnd is implementing correctly CalculateNumChildren but not 
MightHaveChildren, where instead of delegating its action, it was returning 
true.
This fixes that simple bug.


>From 57d19fdd476b293a87f1c14b743ba636350af7a1 Mon Sep 17 00:00:00 2001
From: walter erquinigo 
Date: Fri, 3 Nov 2023 00:50:36 -0400
Subject: [PATCH] [LLDB][easy] Fix a bug in DummySyntheticFrontEnd

DummySyntheticFrontEnd is implementing correctly CalculateNumChildren but not 
MightHaveChildren, where instead of delegating its action, it was returning 
true.
This fixes that simple bug.
---
 lldb/source/Core/ValueObjectSyntheticFilter.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lldb/source/Core/ValueObjectSyntheticFilter.cpp 
b/lldb/source/Core/ValueObjectSyntheticFilter.cpp
index 59ed780b654f3af..43bc532c4a0410b 100644
--- a/lldb/source/Core/ValueObjectSyntheticFilter.cpp
+++ b/lldb/source/Core/ValueObjectSyntheticFilter.cpp
@@ -41,7 +41,7 @@ class DummySyntheticFrontEnd : public 
SyntheticChildrenFrontEnd {
 return m_backend.GetIndexOfChildWithName(name);
   }
 
-  bool MightHaveChildren() override { return true; }
+  bool MightHaveChildren() override { return m_backend.MightHaveChildren(); }
 
   bool Update() override { return false; }
 };

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits