[Lldb-commits] [lldb] [lldb][debugger][NFC] Add broadcast bit for category-based progress events. (PR #81169)

2024-02-08 Thread Chelsea Cassanova via lldb-commits 

https://github.com/chelcassanova created 
https://github.com/llvm/llvm-project/pull/81169

This commit adds a new broadcast bit to the debugger. When in use, it will be 
listened to for progress events that will be delivered and kept track of by 
category as opposed to the current behaviour of coming in one by one.

>From d9bed21614aff84176766a63fdc691203352ef6b Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova 
Date: Thu, 8 Feb 2024 10:22:14 -0800
Subject: [PATCH] [lldb][debugger][NFC] Add broadcast bit for category-based
 progress events.

This commit adds a new broadcast bit to the debugger. When in use, it
will be listened to for progress events that will be delivered and kept
track of by category as opposed to the current behaviour of coming in
one by one.
---
 lldb/include/lldb/API/SBDebugger.h | 1 +
 lldb/include/lldb/Core/Debugger.h  | 1 +
 2 files changed, 2 insertions(+)

diff --git a/lldb/include/lldb/API/SBDebugger.h 
b/lldb/include/lldb/API/SBDebugger.h
index 218113a7a391f..62b2f91f5076d 100644
--- a/lldb/include/lldb/API/SBDebugger.h
+++ b/lldb/include/lldb/API/SBDebugger.h
@@ -46,6 +46,7 @@ class LLDB_API SBDebugger {
   eBroadcastBitProgress = (1 << 0),
   eBroadcastBitWarning = (1 << 1),
   eBroadcastBitError = (1 << 2),
+  eBroadcastBitProgressCategory = (1 << 3),
   };
 
   SBDebugger();
diff --git a/lldb/include/lldb/Core/Debugger.h 
b/lldb/include/lldb/Core/Debugger.h
index c6d603ca5dcde..6ba90eb6ed8fd 100644
--- a/lldb/include/lldb/Core/Debugger.h
+++ b/lldb/include/lldb/Core/Debugger.h
@@ -84,6 +84,7 @@ class Debugger : public 
std::enable_shared_from_this,
 eBroadcastBitWarning = (1 << 1),
 eBroadcastBitError = (1 << 2),
 eBroadcastSymbolChange = (1 << 3),
+eBroadcastBitProgressCategory = (1 << 4),
   };
 
   using DebuggerList = std::vector;

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][debugger][NFC] Add broadcast bit for category-based progress events. (PR #81169)

2024-02-08 Thread via lldb-commits 

llvmbot wrote:




@llvm/pr-subscribers-lldb

Author: Chelsea Cassanova (chelcassanova)


Changes

This commit adds a new broadcast bit to the debugger. When in use, it will be 
listened to for progress events that will be delivered and kept track of by 
category as opposed to the current behaviour of coming in one by one.

---
Full diff: https://github.com/llvm/llvm-project/pull/81169.diff


2 Files Affected:

- (modified) lldb/include/lldb/API/SBDebugger.h (+1) 
- (modified) lldb/include/lldb/Core/Debugger.h (+1) 


``diff
diff --git a/lldb/include/lldb/API/SBDebugger.h 
b/lldb/include/lldb/API/SBDebugger.h
index 218113a7a391f3..62b2f91f5076d5 100644
--- a/lldb/include/lldb/API/SBDebugger.h
+++ b/lldb/include/lldb/API/SBDebugger.h
@@ -46,6 +46,7 @@ class LLDB_API SBDebugger {
   eBroadcastBitProgress = (1 << 0),
   eBroadcastBitWarning = (1 << 1),
   eBroadcastBitError = (1 << 2),
+  eBroadcastBitProgressCategory = (1 << 3),
   };
 
   SBDebugger();
diff --git a/lldb/include/lldb/Core/Debugger.h 
b/lldb/include/lldb/Core/Debugger.h
index c6d603ca5dcde0..6ba90eb6ed8fdf 100644
--- a/lldb/include/lldb/Core/Debugger.h
+++ b/lldb/include/lldb/Core/Debugger.h
@@ -84,6 +84,7 @@ class Debugger : public 
std::enable_shared_from_this,
 eBroadcastBitWarning = (1 << 1),
 eBroadcastBitError = (1 << 2),
 eBroadcastSymbolChange = (1 << 3),
+eBroadcastBitProgressCategory = (1 << 4),
   };
 
   using DebuggerList = std::vector;

``




https://github.com/llvm/llvm-project/pull/81169
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][debugger][NFC] Add broadcast bit for category-based progress events. (PR #81169)

2024-02-08 Thread Greg Clayton via lldb-commits 

https://github.com/clayborg approved this pull request.


https://github.com/llvm/llvm-project/pull/81169
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][debugger][NFC] Add broadcast bit for category-based progress events. (PR #81169)

2024-02-08 Thread Jonas Devlieghere via lldb-commits 

https://github.com/JDevlieghere approved this pull request.

This doesn't do much by itself but based on the discussion in #81026 we have 
consensus on this part. LGTM.

https://github.com/llvm/llvm-project/pull/81169
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][debugger][NFC] Add broadcast bit for category-based progress events. (PR #81169)

2024-02-08 Thread Chelsea Cassanova via lldb-commits 

https://github.com/chelcassanova closed 
https://github.com/llvm/llvm-project/pull/81169
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits