[Lldb-commits] [lldb] [lldb][test] Remove expected failure marker for TestPlatformAttach on windows (PR #68193)

2023-10-04 Thread antoine moynault via lldb-commits

https://github.com/antmox closed https://github.com/llvm/llvm-project/pull/68193
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits


[Lldb-commits] [lldb] [lldb][test] Remove expected failure marker for TestPlatformAttach on windows (PR #68193)

2023-10-04 Thread antoine moynault via lldb-commits

https://github.com/antmox edited https://github.com/llvm/llvm-project/pull/68193
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits


[Lldb-commits] [lldb] [lldb][test] Remove expected failure marker for TestPlatformAttach on windows (PR #68193)

2023-10-04 Thread David Spickett via lldb-commits

https://github.com/DavidSpickett approved this pull request.

Might as well go ahead and try this. If it's still unstable by end of your work 
day, add a skipifwindows and let Jonas look into it.

https://github.com/llvm/llvm-project/pull/68193
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits


[Lldb-commits] [lldb] [lldb][test] Remove expected failure marker for TestPlatformAttach on windows (PR #68193)

2023-10-04 Thread via lldb-commits

llvmbot wrote:




@llvm/pr-subscribers-lldb


Changes


Looks like this test pass since #68050.

---
Full diff: https://github.com/llvm/llvm-project/pull/68193.diff


1 Files Affected:

- (modified) 
lldb/test/API/functionalities/gdb_remote_client/TestPlatformAttach.py (-1) 


``diff
diff --git 
a/lldb/test/API/functionalities/gdb_remote_client/TestPlatformAttach.py 
b/lldb/test/API/functionalities/gdb_remote_client/TestPlatformAttach.py
index d62e86b2a3c1d20..2aaf962b9e4f9a5 100644
--- a/lldb/test/API/functionalities/gdb_remote_client/TestPlatformAttach.py
+++ b/lldb/test/API/functionalities/gdb_remote_client/TestPlatformAttach.py
@@ -7,7 +7,6 @@
 
 class TestPlatformAttach(GDBRemoteTestBase):
 @skipIfRemote
-@expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr52451")
 def test_attach(self):
 """Test attaching by name"""
 

``




https://github.com/llvm/llvm-project/pull/68193
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits


[Lldb-commits] [lldb] [lldb][test] Remove expected failure marker for TestPlatformAttach on windows (PR #68193)

2023-10-04 Thread antoine moynault via lldb-commits

https://github.com/antmox created 
https://github.com/llvm/llvm-project/pull/68193


Looks like this test pass since #68050.

>From 24ae4ebf70c2b6884b31ca99a72eb0ba16bddf33 Mon Sep 17 00:00:00 2001
From: Antoine Moynault 
Date: Wed, 4 Oct 2023 09:27:46 +
Subject: [PATCH] [lldb][test] Remove expected failure marker for
 TestPlatformAttach on windows

Looks like this test pass since #68050.
---
 .../API/functionalities/gdb_remote_client/TestPlatformAttach.py  | 1 -
 1 file changed, 1 deletion(-)

diff --git 
a/lldb/test/API/functionalities/gdb_remote_client/TestPlatformAttach.py 
b/lldb/test/API/functionalities/gdb_remote_client/TestPlatformAttach.py
index d62e86b2a3c1d20..2aaf962b9e4f9a5 100644
--- a/lldb/test/API/functionalities/gdb_remote_client/TestPlatformAttach.py
+++ b/lldb/test/API/functionalities/gdb_remote_client/TestPlatformAttach.py
@@ -7,7 +7,6 @@
 
 class TestPlatformAttach(GDBRemoteTestBase):
 @skipIfRemote
-@expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr52451")
 def test_attach(self):
 """Test attaching by name"""
 

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits