[Lldb-commits] [lldb] [lldb] Enable a test that was never enabled (PR #83925)

2024-03-04 Thread Felipe de Azevedo Piovezan via lldb-commits

https://github.com/felipepiovezan closed 
https://github.com/llvm/llvm-project/pull/83925
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits


[Lldb-commits] [lldb] [lldb] Enable a test that was never enabled (PR #83925)

2024-03-04 Thread Jonas Devlieghere via lldb-commits

https://github.com/JDevlieghere approved this pull request.


https://github.com/llvm/llvm-project/pull/83925
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits


[Lldb-commits] [lldb] [lldb] Enable a test that was never enabled (PR #83925)

2024-03-04 Thread Felipe de Azevedo Piovezan via lldb-commits

felipepiovezan wrote:

@JDevlieghere  I believe you were the last one to touch this test, so I'll let 
you approve this :D 

https://github.com/llvm/llvm-project/pull/83925
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits


[Lldb-commits] [lldb] [lldb] Enable a test that was never enabled (PR #83925)

2024-03-04 Thread via lldb-commits

llvmbot wrote:




@llvm/pr-subscribers-lldb

Author: Felipe de Azevedo Piovezan (felipepiovezan)


Changes

According to the git log (d9442afba1bd6), this test has never been 
enabled/disabled, it was checked in without being called anywhere. But it 
passes and it is useful, so this commit enables it.

---
Full diff: https://github.com/llvm/llvm-project/pull/83925.diff


1 Files Affected:

- (modified) 
lldb/test/API/functionalities/breakpoint/breakpoint_options/TestBreakpointOptions.py
 (+1) 


``diff
diff --git 
a/lldb/test/API/functionalities/breakpoint/breakpoint_options/TestBreakpointOptions.py
 
b/lldb/test/API/functionalities/breakpoint/breakpoint_options/TestBreakpointOptions.py
index b2c9551eda6acb..129290909029a1 100644
--- 
a/lldb/test/API/functionalities/breakpoint/breakpoint_options/TestBreakpointOptions.py
+++ 
b/lldb/test/API/functionalities/breakpoint/breakpoint_options/TestBreakpointOptions.py
@@ -13,6 +13,7 @@ def test(self):
 """Test breakpoint command for different options."""
 self.build()
 self.breakpoint_options_test()
+self.breakpoint_options_language_test()
 
 def setUp(self):
 # Call super's setUp().

``




https://github.com/llvm/llvm-project/pull/83925
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits


[Lldb-commits] [lldb] [lldb] Enable a test that was never enabled (PR #83925)

2024-03-04 Thread Felipe de Azevedo Piovezan via lldb-commits

https://github.com/felipepiovezan created 
https://github.com/llvm/llvm-project/pull/83925

According to the git log (d9442afba1bd6), this test has never been 
enabled/disabled, it was checked in without being called anywhere. But it 
passes and it is useful, so this commit enables it.

>From 009fafe5034fcc569951d0fbcca83adb354b97c5 Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan 
Date: Mon, 4 Mar 2024 15:17:00 -0800
Subject: [PATCH] [lldb] Enable a test that was never enabled

According to the git log (d9442afba1bd6), this test has never been
enabled/disabled, it was checked in without being called anywhere. But it passes
and it is useful, so this commit enables it.
---
 .../breakpoint/breakpoint_options/TestBreakpointOptions.py   | 1 +
 1 file changed, 1 insertion(+)

diff --git 
a/lldb/test/API/functionalities/breakpoint/breakpoint_options/TestBreakpointOptions.py
 
b/lldb/test/API/functionalities/breakpoint/breakpoint_options/TestBreakpointOptions.py
index b2c9551eda6acb..129290909029a1 100644
--- 
a/lldb/test/API/functionalities/breakpoint/breakpoint_options/TestBreakpointOptions.py
+++ 
b/lldb/test/API/functionalities/breakpoint/breakpoint_options/TestBreakpointOptions.py
@@ -13,6 +13,7 @@ def test(self):
 """Test breakpoint command for different options."""
 self.build()
 self.breakpoint_options_test()
+self.breakpoint_options_language_test()
 
 def setUp(self):
 # Call super's setUp().

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits