[Lldb-commits] [lldb] [lldb] Fixed the TestGdbRemoteLibrariesSvr4Support test running on a remote target (PR #93825)

2024-05-30 Thread Dmitry Vasilyev via lldb-commits

https://github.com/slydiman closed 
https://github.com/llvm/llvm-project/pull/93825
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits


[Lldb-commits] [lldb] [lldb] Fixed the TestGdbRemoteLibrariesSvr4Support test running on a remote target (PR #93825)

2024-05-30 Thread Pavel Labath via lldb-commits

https://github.com/labath approved this pull request.


https://github.com/llvm/llvm-project/pull/93825
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits


[Lldb-commits] [lldb] [lldb] Fixed the TestGdbRemoteLibrariesSvr4Support test running on a remote target (PR #93825)

2024-05-30 Thread via lldb-commits

llvmbot wrote:




@llvm/pr-subscribers-lldb

Author: Dmitry Vasilyev (slydiman)


Changes

The TestGdbRemoteLibrariesSvr4Support test failed in case of Linux x86_64 host 
and Linux Aarch64 target. Installing libraries to the remote target is not 
enough. This test actively uses self.getBuildDir() and os.path.realpath() which 
does not work in case of the remote target. So, disable this test for remote 
target now.

---
Full diff: https://github.com/llvm/llvm-project/pull/93825.diff


1 Files Affected:

- (modified) 
lldb/test/API/tools/lldb-server/libraries-svr4/TestGdbRemoteLibrariesSvr4Support.py
 (+1) 


``diff
diff --git 
a/lldb/test/API/tools/lldb-server/libraries-svr4/TestGdbRemoteLibrariesSvr4Support.py
 
b/lldb/test/API/tools/lldb-server/libraries-svr4/TestGdbRemoteLibrariesSvr4Support.py
index 02c9d318525fb..76173a095da93 100644
--- 
a/lldb/test/API/tools/lldb-server/libraries-svr4/TestGdbRemoteLibrariesSvr4Support.py
+++ 
b/lldb/test/API/tools/lldb-server/libraries-svr4/TestGdbRemoteLibrariesSvr4Support.py
@@ -6,6 +6,7 @@
 
 # Windows does not allow quotes in file names.
 @skipIf(hostoslist=["windows"])
+@skipIfRemote
 class 
TestGdbRemoteLibrariesSvr4Support(gdbremote_testcase.GdbRemoteTestCaseBase):
 FEATURE_NAME = "qXfer:libraries-svr4:read"
 

``




https://github.com/llvm/llvm-project/pull/93825
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits


[Lldb-commits] [lldb] [lldb] Fixed the TestGdbRemoteLibrariesSvr4Support test running on a remote target (PR #93825)

2024-05-30 Thread Dmitry Vasilyev via lldb-commits

https://github.com/slydiman created 
https://github.com/llvm/llvm-project/pull/93825

The TestGdbRemoteLibrariesSvr4Support test failed in case of Linux x86_64 host 
and Linux Aarch64 target. Installing libraries to the remote target is not 
enough. This test actively uses self.getBuildDir() and os.path.realpath() which 
does not work in case of the remote target. So, disable this test for remote 
target now.

>From 559ccdabf96071c5d9f066ebd67424713c8e1b7a Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev 
Date: Thu, 30 May 2024 18:04:13 +0400
Subject: [PATCH] [lldb] Fixed the TestGdbRemoteLibrariesSvr4Support test
 running on a remote target

The TestGdbRemoteLibrariesSvr4Support test failed in case of Linux x86_64 host 
and Linux Aarch64 target.
Installing libraries to the remote target is not enough. This test actively 
uses self.getBuildDir() and os.path.realpath() which does not work in case of 
the remote target. So, disable this test for remote target now.
---
 .../libraries-svr4/TestGdbRemoteLibrariesSvr4Support.py  | 1 +
 1 file changed, 1 insertion(+)

diff --git 
a/lldb/test/API/tools/lldb-server/libraries-svr4/TestGdbRemoteLibrariesSvr4Support.py
 
b/lldb/test/API/tools/lldb-server/libraries-svr4/TestGdbRemoteLibrariesSvr4Support.py
index 02c9d318525fb..76173a095da93 100644
--- 
a/lldb/test/API/tools/lldb-server/libraries-svr4/TestGdbRemoteLibrariesSvr4Support.py
+++ 
b/lldb/test/API/tools/lldb-server/libraries-svr4/TestGdbRemoteLibrariesSvr4Support.py
@@ -6,6 +6,7 @@
 
 # Windows does not allow quotes in file names.
 @skipIf(hostoslist=["windows"])
+@skipIfRemote
 class 
TestGdbRemoteLibrariesSvr4Support(gdbremote_testcase.GdbRemoteTestCaseBase):
 FEATURE_NAME = "qXfer:libraries-svr4:read"
 

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits