[Lldb-commits] [lldb] [lldb] Remove duplicate else-if branch (NFC) (PR #81018)

2024-02-07 Thread Dave Lee via lldb-commits 

https://github.com/kastiglione updated 
https://github.com/llvm/llvm-project/pull/81018

>From f9d4abddb0f93d27ed14278566796babad9f7f4e Mon Sep 17 00:00:00 2001
From: Dave Lee 
Date: Wed, 7 Feb 2024 10:17:51 -0800
Subject: [PATCH] [lldb] Add comment to ParseInternal in FormatEntity

---
 lldb/source/Core/FormatEntity.cpp | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/lldb/source/Core/FormatEntity.cpp 
b/lldb/source/Core/FormatEntity.cpp
index 3c665c2eb2133..b206b6e9983b8 100644
--- a/lldb/source/Core/FormatEntity.cpp
+++ b/lldb/source/Core/FormatEntity.cpp
@@ -2204,7 +2204,9 @@ static Status ParseInternal(llvm::StringRef , 
Entry _entry,
   return error;
 }
   } else if (FormatManager::GetFormatFromCString(
- entry.printf_format.c_str(), true, entry.fmt)) {
+ entry.printf_format.c_str(), true,
+ entry.fmt)) { // Try GetFormatFromCString again,
+   // with partial_match_ok = true.
 clear_printf = true;
   } else if (entry.printf_format == "tid") {
 verify_is_thread_id = true;

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove duplicate else-if branch (NFC) (PR #81018)

2024-02-07 Thread Dave Lee via lldb-commits 

https://github.com/kastiglione reopened 
https://github.com/llvm/llvm-project/pull/81018
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove duplicate else-if branch (NFC) (PR #81018)

2024-02-07 Thread Dave Lee via lldb-commits 

kastiglione wrote:

never mind, I see the slight difference

https://github.com/llvm/llvm-project/pull/81018
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove duplicate else-if branch (NFC) (PR #81018)

2024-02-07 Thread Dave Lee via lldb-commits 

https://github.com/kastiglione closed 
https://github.com/llvm/llvm-project/pull/81018
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove duplicate else-if branch (NFC) (PR #81018)

2024-02-07 Thread Dave Lee via lldb-commits 

https://github.com/kastiglione edited 
https://github.com/llvm/llvm-project/pull/81018
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove duplicate else-if branch (NFC) (PR #81018)

2024-02-07 Thread via lldb-commits 

llvmbot wrote:




@llvm/pr-subscribers-lldb

Author: Dave Lee (kastiglione)


Changes



---
Full diff: https://github.com/llvm/llvm-project/pull/81018.diff


1 Files Affected:

- (modified) lldb/source/Core/FormatEntity.cpp (-3) 


``diff
diff --git a/lldb/source/Core/FormatEntity.cpp 
b/lldb/source/Core/FormatEntity.cpp
index 3c665c2eb2133..2a68d3938a201 100644
--- a/lldb/source/Core/FormatEntity.cpp
+++ b/lldb/source/Core/FormatEntity.cpp
@@ -2203,9 +2203,6 @@ static Status ParseInternal(llvm::StringRef , 
Entry _entry,
  entry.printf_format.c_str());
   return error;
 }
-  } else if (FormatManager::GetFormatFromCString(
- entry.printf_format.c_str(), true, entry.fmt)) {
-clear_printf = true;
   } else if (entry.printf_format == "tid") {
 verify_is_thread_id = true;
   } else {

``




https://github.com/llvm/llvm-project/pull/81018
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove duplicate else-if branch (NFC) (PR #81018)

2024-02-07 Thread Dave Lee via lldb-commits 

https://github.com/kastiglione created 
https://github.com/llvm/llvm-project/pull/81018

None

>From 4f5b30fcb038c942df6a2fce975678c5b7ee1725 Mon Sep 17 00:00:00 2001
From: Dave Lee 
Date: Wed, 7 Feb 2024 08:43:14 -0800
Subject: [PATCH] [lldb] Remove duplicate else-if branch (NFC)

---
 lldb/source/Core/FormatEntity.cpp | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/lldb/source/Core/FormatEntity.cpp 
b/lldb/source/Core/FormatEntity.cpp
index 3c665c2eb2133b..2a68d3938a201d 100644
--- a/lldb/source/Core/FormatEntity.cpp
+++ b/lldb/source/Core/FormatEntity.cpp
@@ -2203,9 +2203,6 @@ static Status ParseInternal(llvm::StringRef , 
Entry _entry,
  entry.printf_format.c_str());
   return error;
 }
-  } else if (FormatManager::GetFormatFromCString(
- entry.printf_format.c_str(), true, entry.fmt)) {
-clear_printf = true;
   } else if (entry.printf_format == "tid") {
 verify_is_thread_id = true;
   } else {

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits