[Lldb-commits] [lldb] [lldb] Save the edited line before clearing it in Editline::PrintAsync (PR #84154)
DavidSpickett wrote: This failed on our AArch64 bot but due to zombie processes hanging about from other runs, not anything to do with this change specifically. https://github.com/llvm/llvm-project/pull/84154 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] [lldb] Save the edited line before clearing it in Editline::PrintAsync (PR #84154)
github-actions[bot] wrote: @karzanWang Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a build, you may recieve a report in an email or a comment on this PR. Please check whether problems have been caused by your change specifically, as the builds can include changes from many authors. It is not uncommon for your change to be included in a build that fails due to someone else's changes, or infrastructure issues. How to do this, and the rest of the post-merge process, is covered in detail [here](https://llvm.org/docs/MyFirstTypoFix.html#myfirsttypofix-issues-after-landing-your-pr). If your change does cause a problem, it may be reverted, or you can revert it yourself. This is a normal part of [LLVM development](https://llvm.org/docs/DeveloperPolicy.html#patch-reversion-policy). You can fix your changes and open a new PR to merge them again. If you don't get any reports, no action is required from you. Your changes are working as expected, well done! https://github.com/llvm/llvm-project/pull/84154 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] [lldb] Save the edited line before clearing it in Editline::PrintAsync (PR #84154)
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/84154 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] [lldb] Save the edited line before clearing it in Editline::PrintAsync (PR #84154)
https://github.com/JDevlieghere approved this pull request. Coincidentally, I ran into the same issue a few weeks ago when I was messing around with a different way of displaying the progress reports. LGTM! https://github.com/llvm/llvm-project/pull/84154 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] [lldb] Save the edited line before clearing it in Editline::PrintAsync (PR #84154)
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: karzan (karzanWang)
Changes
If the `m_editor_status` is `EditorStatus::Editing`, PrintAsync clears the
currently edited line. In some situations, the edited line is not saved. After
the stream flushes, PrintAsync tries to display the unsaved line, causing the
loss of the edited line.
The issue arose while I was debugging REPRLRun in
[Fuzzilli](https://github.com/googleprojectzero/fuzzilli). I started LLDB and
attempted to set a breakpoint in libreprl-posix.c. I entered `breakpoint set -f
lib` and used the "tab" key for command completion. After completion, the
edited line was flushed, leaving a blank line.
---
Full diff: https://github.com/llvm/llvm-project/pull/84154.diff
1 Files Affected:
- (modified) lldb/source/Host/common/Editline.cpp (+1)
``diff
diff --git a/lldb/source/Host/common/Editline.cpp
b/lldb/source/Host/common/Editline.cpp
index e66271e8a6ee99..ed61aecc23b9b0 100644
--- a/lldb/source/Host/common/Editline.cpp
+++ b/lldb/source/Host/common/Editline.cpp
@@ -1597,6 +1597,7 @@ bool Editline::GetLines(int first_line_number, StringList
,
void Editline::PrintAsync(Stream *stream, const char *s, size_t len) {
std::lock_guard guard(m_output_mutex);
if (m_editor_status == EditorStatus::Editing) {
+SaveEditedLine();
MoveCursor(CursorLocation::EditingCursor, CursorLocation::BlockStart);
fprintf(m_output_file, ANSI_CLEAR_BELOW);
}
``
https://github.com/llvm/llvm-project/pull/84154
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] [lldb] Save the edited line before clearing it in Editline::PrintAsync (PR #84154)
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using `@` followed by their GitHub username. If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers. If you have further questions, they may be answered by the [LLVM GitHub User Guide](https://llvm.org/docs/GitHub.html). You can also ask questions in a comment on this PR, on the [LLVM Discord](https://discord.com/invite/xS7Z362) or on the [forums](https://discourse.llvm.org/). https://github.com/llvm/llvm-project/pull/84154 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] [lldb] Save the edited line before clearing it in Editline::PrintAsync (PR #84154)
https://github.com/karzanWang created
https://github.com/llvm/llvm-project/pull/84154
If the `m_editor_status` is `EditorStatus::Editing`, PrintAsync clears the
currently edited line. In some situations, the edited line is not saved. After
the stream flushes, PrintAsync tries to display the unsaved line, causing the
loss of the edited line.
The issue arose while I was debugging REPRLRun in
[Fuzzilli](https://github.com/googleprojectzero/fuzzilli). I started LLDB and
attempted to set a breakpoint in libreprl-posix.c. I entered `breakpoint set -f
lib` and used the "tab" key for command completion. After completion, the
edited line was flushed, leaving a blank line.
>From 84634135c0c0b15026568b988632c3e12c96105e Mon Sep 17 00:00:00 2001
From: wanghaiwei
Date: Wed, 6 Mar 2024 19:17:14 +0800
Subject: [PATCH] [lldb] Save the edited line before clearing it in
Editline::PrintAsync If the `m_editor_status` is `EditorStatus::Editing`,
PrintAsync clears the currently edited line. In some situations, the edited
line is not saved. After the stream flushes, PrintAsync tries to display the
unsaved line, causing the loss of the edited line.
---
lldb/source/Host/common/Editline.cpp | 1 +
1 file changed, 1 insertion(+)
diff --git a/lldb/source/Host/common/Editline.cpp
b/lldb/source/Host/common/Editline.cpp
index e66271e8a6ee99..ed61aecc23b9b0 100644
--- a/lldb/source/Host/common/Editline.cpp
+++ b/lldb/source/Host/common/Editline.cpp
@@ -1597,6 +1597,7 @@ bool Editline::GetLines(int first_line_number, StringList
,
void Editline::PrintAsync(Stream *stream, const char *s, size_t len) {
std::lock_guard guard(m_output_mutex);
if (m_editor_status == EditorStatus::Editing) {
+SaveEditedLine();
MoveCursor(CursorLocation::EditingCursor, CursorLocation::BlockStart);
fprintf(m_output_file, ANSI_CLEAR_BELOW);
}
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
