[Lldb-commits] [lldb] [lldb] Skip ObjC timezone tests on macOS >= 14 (NFC) (PR #78817)

2024-01-21 Thread Dave Lee via lldb-commits 

https://github.com/kastiglione closed 
https://github.com/llvm/llvm-project/pull/78817
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Skip ObjC timezone tests on macOS >= 14 (NFC) (PR #78817)

2024-01-21 Thread Alex Langford via lldb-commits 

https://github.com/bulbazord approved this pull request.


https://github.com/llvm/llvm-project/pull/78817
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Skip ObjC timezone tests on macOS >= 14 (NFC) (PR #78817)

2024-01-20 Thread Jonas Devlieghere via lldb-commits 

https://github.com/JDevlieghere approved this pull request.


https://github.com/llvm/llvm-project/pull/78817
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Skip ObjC timezone tests on macOS >= 14 (NFC) (PR #78817)

2024-01-19 Thread Dave Lee via lldb-commits 

https://github.com/kastiglione edited 
https://github.com/llvm/llvm-project/pull/78817
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Skip ObjC timezone tests on macOS >= 14 (NFC) (PR #78817)

2024-01-19 Thread via lldb-commits 

llvmbot wrote:




@llvm/pr-subscribers-lldb

Author: Dave Lee (kastiglione)


Changes



---
Full diff: https://github.com/llvm/llvm-project/pull/78817.diff


1 Files Affected:

- (modified) 
lldb/test/API/functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjCNSDate.py
 (+16-10) 


``diff
diff --git 
a/lldb/test/API/functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjCNSDate.py
 
b/lldb/test/API/functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjCNSDate.py
index a1ffe84ad556f0..c56b887a3f5088 100644
--- 
a/lldb/test/API/functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjCNSDate.py
+++ 
b/lldb/test/API/functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjCNSDate.py
@@ -19,6 +19,11 @@ def test_nsdate_with_run_command(self):
 """Test formatters for  NSDate."""
 self.appkit_tester_impl(self.nsdate_data_formatter_commands, False)
 
+@skipIf(macos_version=[">=", "14.0"])
+def test_timezone_with_run_command(self):
+"""Test formatters for NSTimeZone and CFTimeZone."""
+self.appkit_tester_impl(self.timezone_data_formatter_commands, False)
+
 def nsdate_data_formatter_commands(self):
 self.expect(
 "frame variable date1 date2",
@@ -51,16 +56,6 @@ def nsdate_data_formatter_commands(self):
 self.expect_expr("date_1970_plus_05", result_summary="1970-01-01 
00:00:00 UTC")
 self.expect_expr("date_1970_plus_04", result_summary="1970-01-01 
00:00:00 UTC")
 
-self.expect(
-"frame variable cupertino home europe",
-substrs=['"America/Los_Angeles"', '"Europe/Rome"', 
'"Europe/Paris"'],
-)
-
-self.expect(
-"frame variable cupertino_ns home_ns europe_ns",
-substrs=['"America/Los_Angeles"', '"Europe/Rome"', 
'"Europe/Paris"'],
-)
-
 self.expect(
 "frame variable mut_bv",
 substrs=[
@@ -71,3 +66,14 @@ def nsdate_data_formatter_commands(self):
 
 self.expect_expr("distant_past", result_summary="0001-01-01 00:00:00 
UTC")
 self.expect_expr("distant_future", result_summary="4001-01-01 00:00:00 
UTC")
+
+def timezone_data_formatter_commands(self):
+self.expect(
+"frame variable cupertino home europe",
+substrs=['"America/Los_Angeles"', '"Europe/Rome"', 
'"Europe/Paris"'],
+)
+
+self.expect(
+"frame variable cupertino_ns home_ns europe_ns",
+substrs=['"America/Los_Angeles"', '"Europe/Rome"', 
'"Europe/Paris"'],
+)

``




https://github.com/llvm/llvm-project/pull/78817
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Skip ObjC timezone tests on macOS >= 14 (NFC) (PR #78817)

2024-01-19 Thread Dave Lee via lldb-commits 

https://github.com/kastiglione created 
https://github.com/llvm/llvm-project/pull/78817

None

>From 52b3baa5905b7562fc5872bae8a2f6599ec9e040 Mon Sep 17 00:00:00 2001
From: Dave Lee 
Date: Fri, 19 Jan 2024 16:17:17 -0800
Subject: [PATCH] [lldb] Skip ObjC timezone tests on macOS >= 14 (NFC)

---
 .../TestDataFormatterObjCNSDate.py| 26 ---
 1 file changed, 16 insertions(+), 10 deletions(-)

diff --git 
a/lldb/test/API/functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjCNSDate.py
 
b/lldb/test/API/functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjCNSDate.py
index a1ffe84ad556f0..c56b887a3f5088 100644
--- 
a/lldb/test/API/functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjCNSDate.py
+++ 
b/lldb/test/API/functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjCNSDate.py
@@ -19,6 +19,11 @@ def test_nsdate_with_run_command(self):
 """Test formatters for  NSDate."""
 self.appkit_tester_impl(self.nsdate_data_formatter_commands, False)
 
+@skipIf(macos_version=[">=", "14.0"])
+def test_timezone_with_run_command(self):
+"""Test formatters for NSTimeZone and CFTimeZone."""
+self.appkit_tester_impl(self.timezone_data_formatter_commands, False)
+
 def nsdate_data_formatter_commands(self):
 self.expect(
 "frame variable date1 date2",
@@ -51,16 +56,6 @@ def nsdate_data_formatter_commands(self):
 self.expect_expr("date_1970_plus_05", result_summary="1970-01-01 
00:00:00 UTC")
 self.expect_expr("date_1970_plus_04", result_summary="1970-01-01 
00:00:00 UTC")
 
-self.expect(
-"frame variable cupertino home europe",
-substrs=['"America/Los_Angeles"', '"Europe/Rome"', 
'"Europe/Paris"'],
-)
-
-self.expect(
-"frame variable cupertino_ns home_ns europe_ns",
-substrs=['"America/Los_Angeles"', '"Europe/Rome"', 
'"Europe/Paris"'],
-)
-
 self.expect(
 "frame variable mut_bv",
 substrs=[
@@ -71,3 +66,14 @@ def nsdate_data_formatter_commands(self):
 
 self.expect_expr("distant_past", result_summary="0001-01-01 00:00:00 
UTC")
 self.expect_expr("distant_future", result_summary="4001-01-01 00:00:00 
UTC")
+
+def timezone_data_formatter_commands(self):
+self.expect(
+"frame variable cupertino home europe",
+substrs=['"America/Los_Angeles"', '"Europe/Rome"', 
'"Europe/Paris"'],
+)
+
+self.expect(
+"frame variable cupertino_ns home_ns europe_ns",
+substrs=['"America/Los_Angeles"', '"Europe/Rome"', 
'"Europe/Paris"'],
+)

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits