Re: [Lldb-commits] [lldb] 8d2f252 - lldb: Run TestCrossDSOTailCalls.py and TestCrossObjectTailCalls.py on Darwin only

[Pavel Labath via lldb-commits]

On 16/01/2020 23:49, v...@apple.com wrote:
> I've reverted this and just xfailed the tests on arm/aarch64 in 6c4d37733. 
> I'll keep an eye on the bots.
> 
> vedant
> 
Thanks.
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [lldb] 8d2f252 - lldb: Run TestCrossDSOTailCalls.py and TestCrossObjectTailCalls.py on Darwin only

[via lldb-commits]

I've reverted this and just xfailed the tests on arm/aarch64 in 6c4d37733. I'll 
keep an eye on the bots.

vedant

> On Jan 16, 2020, at 6:58 AM, Pavel Labath  wrote:
> 
> On 15/01/2020 23:00, Vedant Kumar via lldb-commits wrote:
>> 
>> Author: Vedant Kumar
>> Date: 2020-01-15T14:00:05-08:00
>> New Revision: 8d2f252bb8e4d199be8498c4ee2245117ef08fd2
>> 
>> URL: 
>> https://github.com/llvm/llvm-project/commit/8d2f252bb8e4d199be8498c4ee2245117ef08fd2
>> DIFF: 
>> https://github.com/llvm/llvm-project/commit/8d2f252bb8e4d199be8498c4ee2245117ef08fd2.diff
>> 
>> LOG: lldb: Run TestCrossDSOTailCalls.py and TestCrossObjectTailCalls.py on 
>> Darwin only
>> 
> 
> That seems pretty drastic given that the test works fine on linux/x86.
> 
> Can you change that to xfail: arm (or xfail: arm-linux, if you're
> certain that the tests actually work on arm-macos)?
> 
> pl

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [lldb] 8d2f252 - lldb: Run TestCrossDSOTailCalls.py and TestCrossObjectTailCalls.py on Darwin only

[Pavel Labath via lldb-commits]

On 15/01/2020 23:00, Vedant Kumar via lldb-commits wrote:
> 
> Author: Vedant Kumar
> Date: 2020-01-15T14:00:05-08:00
> New Revision: 8d2f252bb8e4d199be8498c4ee2245117ef08fd2
> 
> URL: 
> https://github.com/llvm/llvm-project/commit/8d2f252bb8e4d199be8498c4ee2245117ef08fd2
> DIFF: 
> https://github.com/llvm/llvm-project/commit/8d2f252bb8e4d199be8498c4ee2245117ef08fd2.diff
> 
> LOG: lldb: Run TestCrossDSOTailCalls.py and TestCrossObjectTailCalls.py on 
> Darwin only
> 

That seems pretty drastic given that the test works fine on linux/x86.

Can you change that to xfail: arm (or xfail: arm-linux, if you're
certain that the tests actually work on arm-macos)?

pl
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 8d2f252 - lldb: Run TestCrossDSOTailCalls.py and TestCrossObjectTailCalls.py on Darwin only

[Vedant Kumar via lldb-commits]

Author: Vedant Kumar
Date: 2020-01-15T14:00:05-08:00
New Revision: 8d2f252bb8e4d199be8498c4ee2245117ef08fd2

URL: 
https://github.com/llvm/llvm-project/commit/8d2f252bb8e4d199be8498c4ee2245117ef08fd2
DIFF: 
https://github.com/llvm/llvm-project/commit/8d2f252bb8e4d199be8498c4ee2245117ef08fd2.diff

LOG: lldb: Run TestCrossDSOTailCalls.py and TestCrossObjectTailCalls.py on 
Darwin only

See https://bugs.llvm.org/show_bug.cgi?id=44561, these tests are failing
on an aarch64/Linux bot:

http://lab.llvm.org:8011/builders/lldb-aarch64-ubuntu/builds/655

For some reason the backtrace the tests are expecting to find is
incomplete.

Added: 


Modified: 

lldb/packages/Python/lldbsuite/test/functionalities/tail_call_frames/cross_dso/TestCrossDSOTailCalls.py

lldb/packages/Python/lldbsuite/test/functionalities/tail_call_frames/cross_object/TestCrossObjectTailCalls.py

Removed: 




diff  --git 
a/lldb/packages/Python/lldbsuite/test/functionalities/tail_call_frames/cross_dso/TestCrossDSOTailCalls.py
 
b/lldb/packages/Python/lldbsuite/test/functionalities/tail_call_frames/cross_dso/TestCrossDSOTailCalls.py
index d0a4b69c27d4..4581a75fa0a5 100644
--- 
a/lldb/packages/Python/lldbsuite/test/functionalities/tail_call_frames/cross_dso/TestCrossDSOTailCalls.py
+++ 
b/lldb/packages/Python/lldbsuite/test/functionalities/tail_call_frames/cross_dso/TestCrossDSOTailCalls.py
@@ -17,7 +17,7 @@ def setUp(self):
 
 @skipIf(compiler="clang", compiler_version=['<', '8.0'])
 @skipIf(dwarf_version=['<', '4'])
-@expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr26265")
+@skipUnlessDarwin # llvm.org/PR44561
 def test_cross_dso_tail_calls(self):
 self.build()
 exe = self.getBuildArtifact("a.out")

diff  --git 
a/lldb/packages/Python/lldbsuite/test/functionalities/tail_call_frames/cross_object/TestCrossObjectTailCalls.py
 
b/lldb/packages/Python/lldbsuite/test/functionalities/tail_call_frames/cross_object/TestCrossObjectTailCalls.py
index 80f20a874f06..dcdf95911de2 100644
--- 
a/lldb/packages/Python/lldbsuite/test/functionalities/tail_call_frames/cross_object/TestCrossObjectTailCalls.py
+++ 
b/lldb/packages/Python/lldbsuite/test/functionalities/tail_call_frames/cross_object/TestCrossObjectTailCalls.py
@@ -17,7 +17,7 @@ def setUp(self):
 
 @skipIf(compiler="clang", compiler_version=['<', '8.0'])
 @skipIf(dwarf_version=['<', '4'])
-@expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr26265")
+@skipUnlessDarwin # llvm.org/PR44561
 def test_cross_object_tail_calls(self):
 self.build()
 exe = self.getBuildArtifact("a.out")



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits