Re: [Lldb-commits] [lldb] r296925 - Fix Darwin failures introduced in r296909

2017-04-10 Thread Tim Hammerquist via lldb-commits 
Hi Zachary!

Thank you for your prompt attention!

I notice you added DumpHexBytes() back, but Dump() is still missing. Was Dump() 
slated for a later patch?

-Tim

> On 3 Mar 2017, at 15:48, Zachary Turner  wrote:
> 
> Yea, it was a static method of DataExtractor before.  I noticed the same 
> thing when i saw it wasn't using any methods of DataExtractor.  Oops!  Anyway 
> since this is no less weird than before I'll leave it this way for now until 
> we figure out something better.
> 
> On Fri, Mar 3, 2017 at 3:46 PM Jim Ingham  > wrote:
> Yeah, looks like you need to keep DumpHexBytes in DumpDataExtractor.  That's 
> a little weird because it doesn't actually take a DataExtractor, but...
> 
> Jim
> 
> > On Mar 3, 2017, at 3:45 PM, Zachary Turner via lldb-commits 
> > > wrote:
> >
> > I can fix that, I didn't see it in my tests because it doesn't compile that 
> > file on Windows.  I'll get a fix in shortly.
> >
> > On Fri, Mar 3, 2017 at 3:38 PM Tim Hammerquist  > > wrote:
> > Sure, Zachary. I try to step in when I can.
> >
> > Now that you mention it, your r296910 (DumpDataExtractor) patch is breaking 
> > building CommunicationKDP.cpp in MacOSX-Kernel. Namely, the removal of 
> > Dump/DumpHexBytes from DataExtractor. I've coordinated with the Apple LLDB 
> > team on how they want to follow up on that, but they might want to reach 
> > out to you about it.
> >
> > -Tim
> >
> >> On 3 Mar 2017, at 15:33, Zachary Turner  >> > wrote:
> >>
> >> Thanks Tim!
> >>
> >> I have a few more file moves coming up as well, sorry for the trouble!
> >>
> >> On Fri, Mar 3, 2017 at 3:29 PM Tim Hammerquist via lldb-commits 
> >> > wrote:
> >> Author: penryu
> >> Date: Fri Mar  3 17:17:29 2017
> >> New Revision: 296925
> >>
> >> URL: http://llvm.org/viewvc/llvm-project?rev=296925=rev 
> >> 
> >> Log:
> >> Fix Darwin failures introduced in r296909
> >>
> >> Modified:
> >> lldb/trunk/lldb.xcodeproj/project.pbxproj
> >>
> >> Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
> >> URL: 
> >> http://llvm.org/viewvc/llvm-project/lldb/trunk/lldb.xcodeproj/project.pbxproj?rev=296925=296924=296925=diff
> >>  
> >> 
> >> ==
> >> --- lldb/trunk/lldb.xcodeproj/project.pbxproj (original)
> >> +++ lldb/trunk/lldb.xcodeproj/project.pbxproj Fri Mar  3 17:17:29 2017
> >> @@ -2052,7 +2052,7 @@
> >> 26BC7D6310F1B77400F91463 /* FileSpecList.h */ = {isa = 
> >> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; 
> >> name = FileSpecList.h; path = include/lldb/Core/FileSpecList.h; sourceTree 
> >> = ""; };
> >> 26BC7D6510F1B77400F91463 /* IOStreamMacros.h */ = {isa = 
> >> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; 
> >> name = IOStreamMacros.h; path = include/lldb/Core/IOStreamMacros.h; 
> >> sourceTree = ""; };
> >> 26BC7D6710F1B77400F91463 /* Listener.h */ = {isa = 
> >> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; 
> >> name = Listener.h; path = include/lldb/Core/Listener.h; sourceTree = 
> >> ""; };
> >> -   26BC7D6810F1B77400F91463 /* Log.h */ = {isa = 
> >> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; 
> >> name = Log.h; path = include/lldb/Core/Log.h; sourceTree = ""; };
> >> +   26BC7D6810F1B77400F91463 /* Log.h */ = {isa = 
> >> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; 
> >> name = Log.h; path = include/lldb/Utility/Log.h; sourceTree = ""; };
> >> 26BC7D6910F1B77400F91463 /* Mangled.h */ = {isa = 
> >> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; 
> >> name = Mangled.h; path = include/lldb/Core/Mangled.h; sourceTree = 
> >> ""; };
> >> 26BC7D6A10F1B77400F91463 /* Module.h */ = {isa = 
> >> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; 
> >> name = Module.h; path = include/lldb/Core/Module.h; sourceTree = 
> >> ""; };
> >> 26BC7D6B10F1B77400F91463 /* ModuleChild.h */ = {isa = 
> >> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; 
> >> name = ModuleChild.h; path = include/lldb/Core/ModuleChild.h; sourceTree = 
> >> ""; };
> >> @@ -2139,7 +2139,7 @@
> >> 26BC7E7910F1B85900F91463 /* Event.cpp */ = {isa = 
> >> PBXFileReference; fileEncoding = 4; lastKnownFileType = 
> >> sourcecode.cpp.cpp; name = Event.cpp; path = source/Core/Event.cpp; 
> >> sourceTree = "";

Re: [Lldb-commits] [lldb] r296925 - Fix Darwin failures introduced in r296909

2017-04-10 Thread Tim Hammerquist via lldb-commits 
Sure, Zachary. I try to step in when I can.

Now that you mention it, your r296910 (DumpDataExtractor) patch is breaking 
building CommunicationKDP.cpp in MacOSX-Kernel. Namely, the removal of 
Dump/DumpHexBytes from DataExtractor. I've coordinated with the Apple LLDB team 
on how they want to follow up on that, but they might want to reach out to you 
about it.

-Tim

> On 3 Mar 2017, at 15:33, Zachary Turner  wrote:
> 
> Thanks Tim!
> 
> I have a few more file moves coming up as well, sorry for the trouble!
> 
> On Fri, Mar 3, 2017 at 3:29 PM Tim Hammerquist via lldb-commits 
> > wrote:
> Author: penryu
> Date: Fri Mar  3 17:17:29 2017
> New Revision: 296925
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=296925=rev 
> 
> Log:
> Fix Darwin failures introduced in r296909
> 
> Modified:
> lldb/trunk/lldb.xcodeproj/project.pbxproj
> 
> Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
> URL: 
> http://llvm.org/viewvc/llvm-project/lldb/trunk/lldb.xcodeproj/project.pbxproj?rev=296925=296924=296925=diff
>  
> 
> ==
> --- lldb/trunk/lldb.xcodeproj/project.pbxproj (original)
> +++ lldb/trunk/lldb.xcodeproj/project.pbxproj Fri Mar  3 17:17:29 2017
> @@ -2052,7 +2052,7 @@
> 26BC7D6310F1B77400F91463 /* FileSpecList.h */ = {isa = 
> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name 
> = FileSpecList.h; path = include/lldb/Core/FileSpecList.h; sourceTree = 
> ""; };
> 26BC7D6510F1B77400F91463 /* IOStreamMacros.h */ = {isa = 
> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name 
> = IOStreamMacros.h; path = include/lldb/Core/IOStreamMacros.h; sourceTree = 
> ""; };
> 26BC7D6710F1B77400F91463 /* Listener.h */ = {isa = 
> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name 
> = Listener.h; path = include/lldb/Core/Listener.h; sourceTree = ""; };
> -   26BC7D6810F1B77400F91463 /* Log.h */ = {isa = 
> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name 
> = Log.h; path = include/lldb/Core/Log.h; sourceTree = ""; };
> +   26BC7D6810F1B77400F91463 /* Log.h */ = {isa = 
> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name 
> = Log.h; path = include/lldb/Utility/Log.h; sourceTree = ""; };
> 26BC7D6910F1B77400F91463 /* Mangled.h */ = {isa = 
> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name 
> = Mangled.h; path = include/lldb/Core/Mangled.h; sourceTree = ""; };
> 26BC7D6A10F1B77400F91463 /* Module.h */ = {isa = 
> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name 
> = Module.h; path = include/lldb/Core/Module.h; sourceTree = ""; };
> 26BC7D6B10F1B77400F91463 /* ModuleChild.h */ = {isa = 
> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name 
> = ModuleChild.h; path = include/lldb/Core/ModuleChild.h; sourceTree = 
> ""; };
> @@ -2139,7 +2139,7 @@
> 26BC7E7910F1B85900F91463 /* Event.cpp */ = {isa = 
> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; 
> name = Event.cpp; path = source/Core/Event.cpp; sourceTree = ""; };
> 26BC7E7B10F1B85900F91463 /* FileSpecList.cpp */ = {isa = 
> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; 
> name = FileSpecList.cpp; path = source/Core/FileSpecList.cpp; sourceTree = 
> ""; };
> 26BC7E7E10F1B85900F91463 /* Listener.cpp */ = {isa = 
> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; 
> name = Listener.cpp; path = source/Core/Listener.cpp; sourceTree = ""; 
> };
> -   26BC7E7F10F1B85900F91463 /* Log.cpp */ = {isa = 
> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; 
> name = Log.cpp; path = source/Core/Log.cpp; sourceTree = ""; };
> +   26BC7E7F10F1B85900F91463 /* Log.cpp */ = {isa = 
> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; 
> name = Log.cpp; path = source/Utility/Log.cpp; sourceTree = ""; };
> 26BC7E8010F1B85900F91463 /* Mangled.cpp */ = {isa = 
> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; 
> name = Mangled.cpp; path = source/Core/Mangled.cpp; sourceTree = ""; };
> 26BC7E8110F1B85900F91463 /* Module.cpp */ = {isa = 
> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; 
> name = Module.cpp; path = source/Core/Module.cpp; sourceTree = ""; };
> 26BC7E8210F1B85900F91463 /* ModuleChild.cpp */ = {isa = 
> PBXFileReference;

Re: [Lldb-commits] [lldb] r296925 - Fix Darwin failures introduced in r296909

2017-03-03 Thread Jim Ingham via lldb-commits 
Might also be useful to have a list of "files only compiled on platform X" 
somewhere.  Then in this sort of case, you could compile, then scrutinize 
carefully all the files in the "not my platform list."

Jim



> On Mar 3, 2017, at 4:51 PM, Jim Ingham via lldb-commits 
>  wrote:
> 
> Yeah, you could have grepped (is that how you spell that?) for "#include 
> "lldb/Core/DataExtractor.h" then looked at any Dump method in the files that 
> turned up.  That would have reduced the noise.
> 
> Ah, staircase wit...
> 
> Jim
> 
>> On Mar 3, 2017, at 4:46 PM, Zachary Turner  wrote:
>> 
>> I usually do this, like when I'm changing #includes I do grep / replace.  In 
>> this case it was a little tricky because a name liked Dump is so common that 
>> if my code doesn't compile it, I might not catch it.  (Granted, I should 
>> have caught DumpHexBytes, not sure how I missed that one).
>> 
>> On Fri, Mar 3, 2017 at 4:45 PM Jim Ingham  wrote:
>> I'll get this working, but in the future when you are making changes of this 
>> sort please chase down all the instances of functions you are changing, even 
>> in files you aren't building locally. There might be a use that your 
>> conversion doesn't handle, and you don't want to find that out after you've 
>> gone a ways down a particular path.
>> 
>> Jim
>> 
>> 
>>> On Mar 3, 2017, at 4:34 PM, Zachary Turner  wrote:
>>> 
>>> Is that still failing?  Extractor.dump(...) should be replaced by 
>>> DumpDataExtractor(Extractor, ...) and then everything will work
>>> 
>>> On Fri, Mar 3, 2017 at 4:29 PM Tim Hammerquist  
>>> wrote:
>>> Hi Zachary!
>>> 
>>> Thank you for your prompt attention!
>>> 
>>> I notice you added DumpHexBytes() back, but Dump() is still missing. Was 
>>> Dump() slated for a later patch?
>>> 
>>> -Tim
>>> 
 On 3 Mar 2017, at 15:48, Zachary Turner  wrote:
 
 Yea, it was a static method of DataExtractor before.  I noticed the same 
 thing when i saw it wasn't using any methods of DataExtractor.  Oops!  
 Anyway since this is no less weird than before I'll leave it this way for 
 now until we figure out something better.
 
 On Fri, Mar 3, 2017 at 3:46 PM Jim Ingham  wrote:
 Yeah, looks like you need to keep DumpHexBytes in DumpDataExtractor.  
 That's a little weird because it doesn't actually take a DataExtractor, 
 but...
 
 Jim
 
> On Mar 3, 2017, at 3:45 PM, Zachary Turner via lldb-commits 
>  wrote:
> 
> I can fix that, I didn't see it in my tests because it doesn't compile 
> that file on Windows.  I'll get a fix in shortly.
> 
> On Fri, Mar 3, 2017 at 3:38 PM Tim Hammerquist  
> wrote:
> Sure, Zachary. I try to step in when I can.
> 
> Now that you mention it, your r296910 (DumpDataExtractor) patch is 
> breaking building CommunicationKDP.cpp in MacOSX-Kernel. Namely, the 
> removal of Dump/DumpHexBytes from DataExtractor. I've coordinated with 
> the Apple LLDB team on how they want to follow up on that, but they might 
> want to reach out to you about it.
> 
> -Tim
> 
>> On 3 Mar 2017, at 15:33, Zachary Turner  wrote:
>> 
>> Thanks Tim!
>> 
>> I have a few more file moves coming up as well, sorry for the trouble!
>> 
>> On Fri, Mar 3, 2017 at 3:29 PM Tim Hammerquist via lldb-commits 
>>  wrote:
>> Author: penryu
>> Date: Fri Mar  3 17:17:29 2017
>> New Revision: 296925
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=296925=rev
>> Log:
>> Fix Darwin failures introduced in r296909
>> 
>> Modified:
>>lldb/trunk/lldb.xcodeproj/project.pbxproj
>> 
>> Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
>> URL: 
>> http://llvm.org/viewvc/llvm-project/lldb/trunk/lldb.xcodeproj/project.pbxproj?rev=296925=296924=296925=diff
>> ==
>> --- lldb/trunk/lldb.xcodeproj/project.pbxproj (original)
>> +++ lldb/trunk/lldb.xcodeproj/project.pbxproj Fri Mar  3 17:17:29 2017
>> @@ -2052,7 +2052,7 @@
>>26BC7D6310F1B77400F91463 /* FileSpecList.h */ = {isa = 
>> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; 
>> name = FileSpecList.h; path = include/lldb/Core/FileSpecList.h; 
>> sourceTree = ""; };
>>26BC7D6510F1B77400F91463 /* IOStreamMacros.h */ = {isa = 
>> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; 
>> name = IOStreamMacros.h; path = include/lldb/Core/IOStreamMacros.h; 
>> sourceTree = ""; };
>>26BC7D6710F1B77400F91463 /* Listener.h */ = {isa = 
>> PBXFileReference;

Re: [Lldb-commits] [lldb] r296925 - Fix Darwin failures introduced in r296909

2017-03-03 Thread Jim Ingham via lldb-commits 
Yeah, you could have grepped (is that how you spell that?) for "#include 
"lldb/Core/DataExtractor.h" then looked at any Dump method in the files that 
turned up.  That would have reduced the noise.

Ah, staircase wit...

Jim

> On Mar 3, 2017, at 4:46 PM, Zachary Turner  wrote:
> 
> I usually do this, like when I'm changing #includes I do grep / replace.  In 
> this case it was a little tricky because a name liked Dump is so common that 
> if my code doesn't compile it, I might not catch it.  (Granted, I should have 
> caught DumpHexBytes, not sure how I missed that one).
> 
> On Fri, Mar 3, 2017 at 4:45 PM Jim Ingham  wrote:
> I'll get this working, but in the future when you are making changes of this 
> sort please chase down all the instances of functions you are changing, even 
> in files you aren't building locally. There might be a use that your 
> conversion doesn't handle, and you don't want to find that out after you've 
> gone a ways down a particular path.
> 
> Jim
> 
> 
> > On Mar 3, 2017, at 4:34 PM, Zachary Turner  wrote:
> >
> > Is that still failing?  Extractor.dump(...) should be replaced by 
> > DumpDataExtractor(Extractor, ...) and then everything will work
> >
> > On Fri, Mar 3, 2017 at 4:29 PM Tim Hammerquist  
> > wrote:
> > Hi Zachary!
> >
> > Thank you for your prompt attention!
> >
> > I notice you added DumpHexBytes() back, but Dump() is still missing. Was 
> > Dump() slated for a later patch?
> >
> > -Tim
> >
> >> On 3 Mar 2017, at 15:48, Zachary Turner  wrote:
> >>
> >> Yea, it was a static method of DataExtractor before.  I noticed the same 
> >> thing when i saw it wasn't using any methods of DataExtractor.  Oops!  
> >> Anyway since this is no less weird than before I'll leave it this way for 
> >> now until we figure out something better.
> >>
> >> On Fri, Mar 3, 2017 at 3:46 PM Jim Ingham  wrote:
> >> Yeah, looks like you need to keep DumpHexBytes in DumpDataExtractor.  
> >> That's a little weird because it doesn't actually take a DataExtractor, 
> >> but...
> >>
> >> Jim
> >>
> >> > On Mar 3, 2017, at 3:45 PM, Zachary Turner via lldb-commits 
> >> >  wrote:
> >> >
> >> > I can fix that, I didn't see it in my tests because it doesn't compile 
> >> > that file on Windows.  I'll get a fix in shortly.
> >> >
> >> > On Fri, Mar 3, 2017 at 3:38 PM Tim Hammerquist  
> >> > wrote:
> >> > Sure, Zachary. I try to step in when I can.
> >> >
> >> > Now that you mention it, your r296910 (DumpDataExtractor) patch is 
> >> > breaking building CommunicationKDP.cpp in MacOSX-Kernel. Namely, the 
> >> > removal of Dump/DumpHexBytes from DataExtractor. I've coordinated with 
> >> > the Apple LLDB team on how they want to follow up on that, but they 
> >> > might want to reach out to you about it.
> >> >
> >> > -Tim
> >> >
> >> >> On 3 Mar 2017, at 15:33, Zachary Turner  wrote:
> >> >>
> >> >> Thanks Tim!
> >> >>
> >> >> I have a few more file moves coming up as well, sorry for the trouble!
> >> >>
> >> >> On Fri, Mar 3, 2017 at 3:29 PM Tim Hammerquist via lldb-commits 
> >> >>  wrote:
> >> >> Author: penryu
> >> >> Date: Fri Mar  3 17:17:29 2017
> >> >> New Revision: 296925
> >> >>
> >> >> URL: http://llvm.org/viewvc/llvm-project?rev=296925=rev
> >> >> Log:
> >> >> Fix Darwin failures introduced in r296909
> >> >>
> >> >> Modified:
> >> >> lldb/trunk/lldb.xcodeproj/project.pbxproj
> >> >>
> >> >> Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
> >> >> URL: 
> >> >> http://llvm.org/viewvc/llvm-project/lldb/trunk/lldb.xcodeproj/project.pbxproj?rev=296925=296924=296925=diff
> >> >> ==
> >> >> --- lldb/trunk/lldb.xcodeproj/project.pbxproj (original)
> >> >> +++ lldb/trunk/lldb.xcodeproj/project.pbxproj Fri Mar  3 17:17:29 2017
> >> >> @@ -2052,7 +2052,7 @@
> >> >> 26BC7D6310F1B77400F91463 /* FileSpecList.h */ = {isa = 
> >> >> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; 
> >> >> name = FileSpecList.h; path = include/lldb/Core/FileSpecList.h; 
> >> >> sourceTree = ""; };
> >> >> 26BC7D6510F1B77400F91463 /* IOStreamMacros.h */ = {isa 
> >> >> = PBXFileReference; fileEncoding = 4; lastKnownFileType = 
> >> >> sourcecode.c.h; name = IOStreamMacros.h; path = 
> >> >> include/lldb/Core/IOStreamMacros.h; sourceTree = ""; };
> >> >> 26BC7D6710F1B77400F91463 /* Listener.h */ = {isa = 
> >> >> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; 
> >> >> name = Listener.h; path = include/lldb/Core/Listener.h; sourceTree = 
> >> >> ""; };
> >> >> -   26BC7D6810F1B77400F91463 /* Log.h */ = {isa = 
> >> >> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; 
> >> >> name =

Re: [Lldb-commits] [lldb] r296925 - Fix Darwin failures introduced in r296909

2017-03-03 Thread Jim Ingham via lldb-commits 
I'll get this working, but in the future when you are making changes of this 
sort please chase down all the instances of functions you are changing, even in 
files you aren't building locally. There might be a use that your conversion 
doesn't handle, and you don't want to find that out after you've gone a ways 
down a particular path.

Jim


> On Mar 3, 2017, at 4:34 PM, Zachary Turner  wrote:
> 
> Is that still failing?  Extractor.dump(...) should be replaced by 
> DumpDataExtractor(Extractor, ...) and then everything will work
> 
> On Fri, Mar 3, 2017 at 4:29 PM Tim Hammerquist  wrote:
> Hi Zachary!
> 
> Thank you for your prompt attention!
> 
> I notice you added DumpHexBytes() back, but Dump() is still missing. Was 
> Dump() slated for a later patch?
> 
> -Tim
> 
>> On 3 Mar 2017, at 15:48, Zachary Turner  wrote:
>> 
>> Yea, it was a static method of DataExtractor before.  I noticed the same 
>> thing when i saw it wasn't using any methods of DataExtractor.  Oops!  
>> Anyway since this is no less weird than before I'll leave it this way for 
>> now until we figure out something better.
>> 
>> On Fri, Mar 3, 2017 at 3:46 PM Jim Ingham  wrote:
>> Yeah, looks like you need to keep DumpHexBytes in DumpDataExtractor.  That's 
>> a little weird because it doesn't actually take a DataExtractor, but...
>> 
>> Jim
>> 
>> > On Mar 3, 2017, at 3:45 PM, Zachary Turner via lldb-commits 
>> >  wrote:
>> >
>> > I can fix that, I didn't see it in my tests because it doesn't compile 
>> > that file on Windows.  I'll get a fix in shortly.
>> >
>> > On Fri, Mar 3, 2017 at 3:38 PM Tim Hammerquist  
>> > wrote:
>> > Sure, Zachary. I try to step in when I can.
>> >
>> > Now that you mention it, your r296910 (DumpDataExtractor) patch is 
>> > breaking building CommunicationKDP.cpp in MacOSX-Kernel. Namely, the 
>> > removal of Dump/DumpHexBytes from DataExtractor. I've coordinated with the 
>> > Apple LLDB team on how they want to follow up on that, but they might want 
>> > to reach out to you about it.
>> >
>> > -Tim
>> >
>> >> On 3 Mar 2017, at 15:33, Zachary Turner  wrote:
>> >>
>> >> Thanks Tim!
>> >>
>> >> I have a few more file moves coming up as well, sorry for the trouble!
>> >>
>> >> On Fri, Mar 3, 2017 at 3:29 PM Tim Hammerquist via lldb-commits 
>> >>  wrote:
>> >> Author: penryu
>> >> Date: Fri Mar  3 17:17:29 2017
>> >> New Revision: 296925
>> >>
>> >> URL: http://llvm.org/viewvc/llvm-project?rev=296925=rev
>> >> Log:
>> >> Fix Darwin failures introduced in r296909
>> >>
>> >> Modified:
>> >> lldb/trunk/lldb.xcodeproj/project.pbxproj
>> >>
>> >> Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
>> >> URL: 
>> >> http://llvm.org/viewvc/llvm-project/lldb/trunk/lldb.xcodeproj/project.pbxproj?rev=296925=296924=296925=diff
>> >> ==
>> >> --- lldb/trunk/lldb.xcodeproj/project.pbxproj (original)
>> >> +++ lldb/trunk/lldb.xcodeproj/project.pbxproj Fri Mar  3 17:17:29 2017
>> >> @@ -2052,7 +2052,7 @@
>> >> 26BC7D6310F1B77400F91463 /* FileSpecList.h */ = {isa = 
>> >> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; 
>> >> name = FileSpecList.h; path = include/lldb/Core/FileSpecList.h; 
>> >> sourceTree = ""; };
>> >> 26BC7D6510F1B77400F91463 /* IOStreamMacros.h */ = {isa = 
>> >> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; 
>> >> name = IOStreamMacros.h; path = include/lldb/Core/IOStreamMacros.h; 
>> >> sourceTree = ""; };
>> >> 26BC7D6710F1B77400F91463 /* Listener.h */ = {isa = 
>> >> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; 
>> >> name = Listener.h; path = include/lldb/Core/Listener.h; sourceTree = 
>> >> ""; };
>> >> -   26BC7D6810F1B77400F91463 /* Log.h */ = {isa = 
>> >> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; 
>> >> name = Log.h; path = include/lldb/Core/Log.h; sourceTree = ""; };
>> >> +   26BC7D6810F1B77400F91463 /* Log.h */ = {isa = 
>> >> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; 
>> >> name = Log.h; path = include/lldb/Utility/Log.h; sourceTree = ""; 
>> >> };
>> >> 26BC7D6910F1B77400F91463 /* Mangled.h */ = {isa = 
>> >> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; 
>> >> name = Mangled.h; path = include/lldb/Core/Mangled.h; sourceTree = 
>> >> ""; };
>> >> 26BC7D6A10F1B77400F91463 /* Module.h */ = {isa = 
>> >> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; 
>> >> name = Module.h; path = include/lldb/Core/Module.h; sourceTree = 
>> >> ""; };
>> >> 26BC7D6B10F1B77400F91463 /* ModuleChild.h */ = {isa = 
>> >> PBXFileReference;

Re: [Lldb-commits] [lldb] r296925 - Fix Darwin failures introduced in r296909

2017-03-03 Thread Zachary Turner via lldb-commits 
Is that still failing?  Extractor.dump(...) should be replaced by
DumpDataExtractor(Extractor, ...) and then everything will work

On Fri, Mar 3, 2017 at 4:29 PM Tim Hammerquist 
wrote:

> Hi Zachary!
>
> Thank you for your prompt attention!
>
> I notice you added DumpHexBytes() back, but Dump() is still missing. Was
> Dump() slated for a later patch?
>
> -Tim
>
> On 3 Mar 2017, at 15:48, Zachary Turner  wrote:
>
> Yea, it was a static method of DataExtractor before.  I noticed the same
> thing when i saw it wasn't using any methods of DataExtractor.  Oops!
> Anyway since this is no less weird than before I'll leave it this way for
> now until we figure out something better.
>
> On Fri, Mar 3, 2017 at 3:46 PM Jim Ingham  wrote:
>
> Yeah, looks like you need to keep DumpHexBytes in DumpDataExtractor.
> That's a little weird because it doesn't actually take a DataExtractor,
> but...
>
> Jim
>
> > On Mar 3, 2017, at 3:45 PM, Zachary Turner via lldb-commits <
> lldb-commits@lists.llvm.org> wrote:
> >
> > I can fix that, I didn't see it in my tests because it doesn't compile
> that file on Windows.  I'll get a fix in shortly.
> >
> > On Fri, Mar 3, 2017 at 3:38 PM Tim Hammerquist 
> wrote:
> > Sure, Zachary. I try to step in when I can.
> >
> > Now that you mention it, your r296910 (DumpDataExtractor) patch is
> breaking building CommunicationKDP.cpp in MacOSX-Kernel. Namely, the
> removal of Dump/DumpHexBytes from DataExtractor. I've coordinated with the
> Apple LLDB team on how they want to follow up on that, but they might want
> to reach out to you about it.
> >
> > -Tim
> >
> >> On 3 Mar 2017, at 15:33, Zachary Turner  wrote:
> >>
> >> Thanks Tim!
> >>
> >> I have a few more file moves coming up as well, sorry for the trouble!
> >>
> >> On Fri, Mar 3, 2017 at 3:29 PM Tim Hammerquist via lldb-commits <
> lldb-commits@lists.llvm.org> wrote:
> >> Author: penryu
> >> Date: Fri Mar  3 17:17:29 2017
> >> New Revision: 296925
> >>
> >> URL: http://llvm.org/viewvc/llvm-project?rev=296925=rev
> >> Log:
> >> Fix Darwin failures introduced in r296909
> >>
> >> Modified:
> >> lldb/trunk/lldb.xcodeproj/project.pbxproj
> >>
> >> Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
> >> URL:
> http://llvm.org/viewvc/llvm-project/lldb/trunk/lldb.xcodeproj/project.pbxproj?rev=296925=296924=296925=diff
> >>
> ==
> >> --- lldb/trunk/lldb.xcodeproj/project.pbxproj (original)
> >> +++ lldb/trunk/lldb.xcodeproj/project.pbxproj Fri Mar  3 17:17:29 2017
> >> @@ -2052,7 +2052,7 @@
> >> 26BC7D6310F1B77400F91463 /* FileSpecList.h */ = {isa =
> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h;
> name = FileSpecList.h; path = include/lldb/Core/FileSpecList.h; sourceTree
> = ""; };
> >> 26BC7D6510F1B77400F91463 /* IOStreamMacros.h */ = {isa
> = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h;
> name = IOStreamMacros.h; path = include/lldb/Core/IOStreamMacros.h;
> sourceTree = ""; };
> >> 26BC7D6710F1B77400F91463 /* Listener.h */ = {isa =
> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h;
> name = Listener.h; path = include/lldb/Core/Listener.h; sourceTree =
> ""; };
> >> -   26BC7D6810F1B77400F91463 /* Log.h */ = {isa =
> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h;
> name = Log.h; path = include/lldb/Core/Log.h; sourceTree = ""; };
> >> +   26BC7D6810F1B77400F91463 /* Log.h */ = {isa =
> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h;
> name = Log.h; path = include/lldb/Utility/Log.h; sourceTree = ""; };
> >> 26BC7D6910F1B77400F91463 /* Mangled.h */ = {isa =
> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h;
> name = Mangled.h; path = include/lldb/Core/Mangled.h; sourceTree =
> ""; };
> >> 26BC7D6A10F1B77400F91463 /* Module.h */ = {isa =
> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h;
> name = Module.h; path = include/lldb/Core/Module.h; sourceTree = "";
> };
> >> 26BC7D6B10F1B77400F91463 /* ModuleChild.h */ = {isa =
> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h;
> name = ModuleChild.h; path = include/lldb/Core/ModuleChild.h; sourceTree =
> ""; };
> >> @@ -2139,7 +2139,7 @@
> >> 26BC7E7910F1B85900F91463 /* Event.cpp */ = {isa =
> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp;
> name = Event.cpp; path = source/Core/Event.cpp; sourceTree = ""; };
> >> 26BC7E7B10F1B85900F91463 /* FileSpecList.cpp */ = {isa
> = PBXFileReference; fileEncoding = 4; lastKnownFileType =
> sourcecode.cpp.cpp; name = FileSpecList.cpp; path =
> source/Core/FileSpecList.cpp; sourceTree = ""; };
> >>

Re: [Lldb-commits] [lldb] r296925 - Fix Darwin failures introduced in r296909

2017-03-03 Thread Jim Ingham via lldb-commits 
I guess you could fudge by changing DumpDataExtractor.h to DataDumper.h to 
indicate that it is more general than just data extractors.

Jim

> On Mar 3, 2017, at 3:48 PM, Zachary Turner  wrote:
> 
> Yea, it was a static method of DataExtractor before.  I noticed the same 
> thing when i saw it wasn't using any methods of DataExtractor.  Oops!  Anyway 
> since this is no less weird than before I'll leave it this way for now until 
> we figure out something better.
> 
> On Fri, Mar 3, 2017 at 3:46 PM Jim Ingham  wrote:
> Yeah, looks like you need to keep DumpHexBytes in DumpDataExtractor.  That's 
> a little weird because it doesn't actually take a DataExtractor, but...
> 
> Jim
> 
> > On Mar 3, 2017, at 3:45 PM, Zachary Turner via lldb-commits 
> >  wrote:
> >
> > I can fix that, I didn't see it in my tests because it doesn't compile that 
> > file on Windows.  I'll get a fix in shortly.
> >
> > On Fri, Mar 3, 2017 at 3:38 PM Tim Hammerquist  
> > wrote:
> > Sure, Zachary. I try to step in when I can.
> >
> > Now that you mention it, your r296910 (DumpDataExtractor) patch is breaking 
> > building CommunicationKDP.cpp in MacOSX-Kernel. Namely, the removal of 
> > Dump/DumpHexBytes from DataExtractor. I've coordinated with the Apple LLDB 
> > team on how they want to follow up on that, but they might want to reach 
> > out to you about it.
> >
> > -Tim
> >
> >> On 3 Mar 2017, at 15:33, Zachary Turner  wrote:
> >>
> >> Thanks Tim!
> >>
> >> I have a few more file moves coming up as well, sorry for the trouble!
> >>
> >> On Fri, Mar 3, 2017 at 3:29 PM Tim Hammerquist via lldb-commits 
> >>  wrote:
> >> Author: penryu
> >> Date: Fri Mar  3 17:17:29 2017
> >> New Revision: 296925
> >>
> >> URL: http://llvm.org/viewvc/llvm-project?rev=296925=rev
> >> Log:
> >> Fix Darwin failures introduced in r296909
> >>
> >> Modified:
> >> lldb/trunk/lldb.xcodeproj/project.pbxproj
> >>
> >> Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
> >> URL: 
> >> http://llvm.org/viewvc/llvm-project/lldb/trunk/lldb.xcodeproj/project.pbxproj?rev=296925=296924=296925=diff
> >> ==
> >> --- lldb/trunk/lldb.xcodeproj/project.pbxproj (original)
> >> +++ lldb/trunk/lldb.xcodeproj/project.pbxproj Fri Mar  3 17:17:29 2017
> >> @@ -2052,7 +2052,7 @@
> >> 26BC7D6310F1B77400F91463 /* FileSpecList.h */ = {isa = 
> >> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; 
> >> name = FileSpecList.h; path = include/lldb/Core/FileSpecList.h; sourceTree 
> >> = ""; };
> >> 26BC7D6510F1B77400F91463 /* IOStreamMacros.h */ = {isa = 
> >> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; 
> >> name = IOStreamMacros.h; path = include/lldb/Core/IOStreamMacros.h; 
> >> sourceTree = ""; };
> >> 26BC7D6710F1B77400F91463 /* Listener.h */ = {isa = 
> >> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; 
> >> name = Listener.h; path = include/lldb/Core/Listener.h; sourceTree = 
> >> ""; };
> >> -   26BC7D6810F1B77400F91463 /* Log.h */ = {isa = 
> >> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; 
> >> name = Log.h; path = include/lldb/Core/Log.h; sourceTree = ""; };
> >> +   26BC7D6810F1B77400F91463 /* Log.h */ = {isa = 
> >> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; 
> >> name = Log.h; path = include/lldb/Utility/Log.h; sourceTree = ""; };
> >> 26BC7D6910F1B77400F91463 /* Mangled.h */ = {isa = 
> >> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; 
> >> name = Mangled.h; path = include/lldb/Core/Mangled.h; sourceTree = 
> >> ""; };
> >> 26BC7D6A10F1B77400F91463 /* Module.h */ = {isa = 
> >> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; 
> >> name = Module.h; path = include/lldb/Core/Module.h; sourceTree = 
> >> ""; };
> >> 26BC7D6B10F1B77400F91463 /* ModuleChild.h */ = {isa = 
> >> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; 
> >> name = ModuleChild.h; path = include/lldb/Core/ModuleChild.h; sourceTree = 
> >> ""; };
> >> @@ -2139,7 +2139,7 @@
> >> 26BC7E7910F1B85900F91463 /* Event.cpp */ = {isa = 
> >> PBXFileReference; fileEncoding = 4; lastKnownFileType = 
> >> sourcecode.cpp.cpp; name = Event.cpp; path = source/Core/Event.cpp; 
> >> sourceTree = ""; };
> >> 26BC7E7B10F1B85900F91463 /* FileSpecList.cpp */ = {isa = 
> >> PBXFileReference; fileEncoding = 4; lastKnownFileType = 
> >> sourcecode.cpp.cpp; name = FileSpecList.cpp; path = 
> >> source/Core/FileSpecList.cpp; sourceTree = ""; };
> >> 26BC7E7E10F1B85900F91463 /* Listener.cpp */ = {isa = 
> >> PBXFileReference; fileEncoding = 4;

Re: [Lldb-commits] [lldb] r296925 - Fix Darwin failures introduced in r296909

2017-03-03 Thread Jim Ingham via lldb-commits 
Yeah, looks like you need to keep DumpHexBytes in DumpDataExtractor.  That's a 
little weird because it doesn't actually take a DataExtractor, but...

Jim

> On Mar 3, 2017, at 3:45 PM, Zachary Turner via lldb-commits 
>  wrote:
> 
> I can fix that, I didn't see it in my tests because it doesn't compile that 
> file on Windows.  I'll get a fix in shortly.
> 
> On Fri, Mar 3, 2017 at 3:38 PM Tim Hammerquist  wrote:
> Sure, Zachary. I try to step in when I can.
> 
> Now that you mention it, your r296910 (DumpDataExtractor) patch is breaking 
> building CommunicationKDP.cpp in MacOSX-Kernel. Namely, the removal of 
> Dump/DumpHexBytes from DataExtractor. I've coordinated with the Apple LLDB 
> team on how they want to follow up on that, but they might want to reach out 
> to you about it.
> 
> -Tim
> 
>> On 3 Mar 2017, at 15:33, Zachary Turner  wrote:
>> 
>> Thanks Tim!
>> 
>> I have a few more file moves coming up as well, sorry for the trouble!
>> 
>> On Fri, Mar 3, 2017 at 3:29 PM Tim Hammerquist via lldb-commits 
>>  wrote:
>> Author: penryu
>> Date: Fri Mar  3 17:17:29 2017
>> New Revision: 296925
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=296925=rev
>> Log:
>> Fix Darwin failures introduced in r296909
>> 
>> Modified:
>> lldb/trunk/lldb.xcodeproj/project.pbxproj
>> 
>> Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
>> URL: 
>> http://llvm.org/viewvc/llvm-project/lldb/trunk/lldb.xcodeproj/project.pbxproj?rev=296925=296924=296925=diff
>> ==
>> --- lldb/trunk/lldb.xcodeproj/project.pbxproj (original)
>> +++ lldb/trunk/lldb.xcodeproj/project.pbxproj Fri Mar  3 17:17:29 2017
>> @@ -2052,7 +2052,7 @@
>> 26BC7D6310F1B77400F91463 /* FileSpecList.h */ = {isa = 
>> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name 
>> = FileSpecList.h; path = include/lldb/Core/FileSpecList.h; sourceTree = 
>> ""; };
>> 26BC7D6510F1B77400F91463 /* IOStreamMacros.h */ = {isa = 
>> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name 
>> = IOStreamMacros.h; path = include/lldb/Core/IOStreamMacros.h; sourceTree = 
>> ""; };
>> 26BC7D6710F1B77400F91463 /* Listener.h */ = {isa = 
>> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name 
>> = Listener.h; path = include/lldb/Core/Listener.h; sourceTree = ""; };
>> -   26BC7D6810F1B77400F91463 /* Log.h */ = {isa = 
>> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name 
>> = Log.h; path = include/lldb/Core/Log.h; sourceTree = ""; };
>> +   26BC7D6810F1B77400F91463 /* Log.h */ = {isa = 
>> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name 
>> = Log.h; path = include/lldb/Utility/Log.h; sourceTree = ""; };
>> 26BC7D6910F1B77400F91463 /* Mangled.h */ = {isa = 
>> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name 
>> = Mangled.h; path = include/lldb/Core/Mangled.h; sourceTree = ""; };
>> 26BC7D6A10F1B77400F91463 /* Module.h */ = {isa = 
>> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name 
>> = Module.h; path = include/lldb/Core/Module.h; sourceTree = ""; };
>> 26BC7D6B10F1B77400F91463 /* ModuleChild.h */ = {isa = 
>> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name 
>> = ModuleChild.h; path = include/lldb/Core/ModuleChild.h; sourceTree = 
>> ""; };
>> @@ -2139,7 +2139,7 @@
>> 26BC7E7910F1B85900F91463 /* Event.cpp */ = {isa = 
>> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; 
>> name = Event.cpp; path = source/Core/Event.cpp; sourceTree = ""; };
>> 26BC7E7B10F1B85900F91463 /* FileSpecList.cpp */ = {isa = 
>> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; 
>> name = FileSpecList.cpp; path = source/Core/FileSpecList.cpp; sourceTree = 
>> ""; };
>> 26BC7E7E10F1B85900F91463 /* Listener.cpp */ = {isa = 
>> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; 
>> name = Listener.cpp; path = source/Core/Listener.cpp; sourceTree = 
>> ""; };
>> -   26BC7E7F10F1B85900F91463 /* Log.cpp */ = {isa = 
>> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; 
>> name = Log.cpp; path = source/Core/Log.cpp; sourceTree = ""; };
>> +   26BC7E7F10F1B85900F91463 /* Log.cpp */ = {isa = 
>> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; 
>> name = Log.cpp; path = source/Utility/Log.cpp; sourceTree = ""; };
>> 26BC7E8010F1B85900F91463 /* Mangled.cpp */ = {isa = 
>> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; 
>> name = Mangled.cpp; path =

Re: [Lldb-commits] [lldb] r296925 - Fix Darwin failures introduced in r296909

2017-03-03 Thread Zachary Turner via lldb-commits 
I can fix that, I didn't see it in my tests because it doesn't compile that
file on Windows.  I'll get a fix in shortly.

On Fri, Mar 3, 2017 at 3:38 PM Tim Hammerquist 
wrote:

> Sure, Zachary. I try to step in when I can.
>
> Now that you mention it, your r296910 (DumpDataExtractor) patch is
> breaking building CommunicationKDP.cpp in MacOSX-Kernel. Namely, the
> removal of Dump/DumpHexBytes from DataExtractor. I've coordinated with the
> Apple LLDB team on how they want to follow up on that, but they might want
> to reach out to you about it.
>
> -Tim
>
> On 3 Mar 2017, at 15:33, Zachary Turner  wrote:
>
> Thanks Tim!
>
> I have a few more file moves coming up as well, sorry for the trouble!
>
> On Fri, Mar 3, 2017 at 3:29 PM Tim Hammerquist via lldb-commits <
> lldb-commits@lists.llvm.org> wrote:
>
> Author: penryu
> Date: Fri Mar  3 17:17:29 2017
> New Revision: 296925
>
> URL: http://llvm.org/viewvc/llvm-project?rev=296925=rev
> Log:
> Fix Darwin failures introduced in r296909
>
> Modified:
> lldb/trunk/lldb.xcodeproj/project.pbxproj
>
> Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
> URL:
> http://llvm.org/viewvc/llvm-project/lldb/trunk/lldb.xcodeproj/project.pbxproj?rev=296925=296924=296925=diff
>
> ==
> --- lldb/trunk/lldb.xcodeproj/project.pbxproj (original)
> +++ lldb/trunk/lldb.xcodeproj/project.pbxproj Fri Mar  3 17:17:29 2017
> @@ -2052,7 +2052,7 @@
> 26BC7D6310F1B77400F91463 /* FileSpecList.h */ = {isa =
> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h;
> name = FileSpecList.h; path = include/lldb/Core/FileSpecList.h; sourceTree
> = ""; };
> 26BC7D6510F1B77400F91463 /* IOStreamMacros.h */ = {isa =
> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h;
> name = IOStreamMacros.h; path = include/lldb/Core/IOStreamMacros.h;
> sourceTree = ""; };
> 26BC7D6710F1B77400F91463 /* Listener.h */ = {isa =
> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h;
> name = Listener.h; path = include/lldb/Core/Listener.h; sourceTree =
> ""; };
> -   26BC7D6810F1B77400F91463 /* Log.h */ = {isa =
> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h;
> name = Log.h; path = include/lldb/Core/Log.h; sourceTree = ""; };
> +   26BC7D6810F1B77400F91463 /* Log.h */ = {isa =
> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h;
> name = Log.h; path = include/lldb/Utility/Log.h; sourceTree = ""; };
> 26BC7D6910F1B77400F91463 /* Mangled.h */ = {isa =
> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h;
> name = Mangled.h; path = include/lldb/Core/Mangled.h; sourceTree =
> ""; };
> 26BC7D6A10F1B77400F91463 /* Module.h */ = {isa =
> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h;
> name = Module.h; path = include/lldb/Core/Module.h; sourceTree = "";
> };
> 26BC7D6B10F1B77400F91463 /* ModuleChild.h */ = {isa =
> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h;
> name = ModuleChild.h; path = include/lldb/Core/ModuleChild.h; sourceTree =
> ""; };
> @@ -2139,7 +2139,7 @@
> 26BC7E7910F1B85900F91463 /* Event.cpp */ = {isa =
> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp;
> name = Event.cpp; path = source/Core/Event.cpp; sourceTree = ""; };
> 26BC7E7B10F1B85900F91463 /* FileSpecList.cpp */ = {isa =
> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp;
> name = FileSpecList.cpp; path = source/Core/FileSpecList.cpp; sourceTree =
> ""; };
> 26BC7E7E10F1B85900F91463 /* Listener.cpp */ = {isa =
> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp;
> name = Listener.cpp; path = source/Core/Listener.cpp; sourceTree =
> ""; };
> -   26BC7E7F10F1B85900F91463 /* Log.cpp */ = {isa =
> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp;
> name = Log.cpp; path = source/Core/Log.cpp; sourceTree = ""; };
> +   26BC7E7F10F1B85900F91463 /* Log.cpp */ = {isa =
> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp;
> name = Log.cpp; path = source/Utility/Log.cpp; sourceTree = ""; };
> 26BC7E8010F1B85900F91463 /* Mangled.cpp */ = {isa =
> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp;
> name = Mangled.cpp; path = source/Core/Mangled.cpp; sourceTree = "";
> };
> 26BC7E8110F1B85900F91463 /* Module.cpp */ = {isa =
> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp;
> name = Module.cpp; path = source/Core/Module.cpp; sourceTree = ""; };
> 26BC7E8210F1B85900F91463 /* ModuleChild.cpp */ = {isa =
> PBXFileReference; fileEncoding = 4;

Re: [Lldb-commits] [lldb] r296925 - Fix Darwin failures introduced in r296909

2017-03-03 Thread Zachary Turner via lldb-commits 
Thanks Tim!

I have a few more file moves coming up as well, sorry for the trouble!

On Fri, Mar 3, 2017 at 3:29 PM Tim Hammerquist via lldb-commits <
lldb-commits@lists.llvm.org> wrote:

> Author: penryu
> Date: Fri Mar  3 17:17:29 2017
> New Revision: 296925
>
> URL: http://llvm.org/viewvc/llvm-project?rev=296925=rev
> Log:
> Fix Darwin failures introduced in r296909
>
> Modified:
> lldb/trunk/lldb.xcodeproj/project.pbxproj
>
> Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
> URL:
> http://llvm.org/viewvc/llvm-project/lldb/trunk/lldb.xcodeproj/project.pbxproj?rev=296925=296924=296925=diff
>
> ==
> --- lldb/trunk/lldb.xcodeproj/project.pbxproj (original)
> +++ lldb/trunk/lldb.xcodeproj/project.pbxproj Fri Mar  3 17:17:29 2017
> @@ -2052,7 +2052,7 @@
> 26BC7D6310F1B77400F91463 /* FileSpecList.h */ = {isa =
> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h;
> name = FileSpecList.h; path = include/lldb/Core/FileSpecList.h; sourceTree
> = ""; };
> 26BC7D6510F1B77400F91463 /* IOStreamMacros.h */ = {isa =
> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h;
> name = IOStreamMacros.h; path = include/lldb/Core/IOStreamMacros.h;
> sourceTree = ""; };
> 26BC7D6710F1B77400F91463 /* Listener.h */ = {isa =
> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h;
> name = Listener.h; path = include/lldb/Core/Listener.h; sourceTree =
> ""; };
> -   26BC7D6810F1B77400F91463 /* Log.h */ = {isa =
> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h;
> name = Log.h; path = include/lldb/Core/Log.h; sourceTree = ""; };
> +   26BC7D6810F1B77400F91463 /* Log.h */ = {isa =
> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h;
> name = Log.h; path = include/lldb/Utility/Log.h; sourceTree = ""; };
> 26BC7D6910F1B77400F91463 /* Mangled.h */ = {isa =
> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h;
> name = Mangled.h; path = include/lldb/Core/Mangled.h; sourceTree =
> ""; };
> 26BC7D6A10F1B77400F91463 /* Module.h */ = {isa =
> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h;
> name = Module.h; path = include/lldb/Core/Module.h; sourceTree = "";
> };
> 26BC7D6B10F1B77400F91463 /* ModuleChild.h */ = {isa =
> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h;
> name = ModuleChild.h; path = include/lldb/Core/ModuleChild.h; sourceTree =
> ""; };
> @@ -2139,7 +2139,7 @@
> 26BC7E7910F1B85900F91463 /* Event.cpp */ = {isa =
> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp;
> name = Event.cpp; path = source/Core/Event.cpp; sourceTree = ""; };
> 26BC7E7B10F1B85900F91463 /* FileSpecList.cpp */ = {isa =
> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp;
> name = FileSpecList.cpp; path = source/Core/FileSpecList.cpp; sourceTree =
> ""; };
> 26BC7E7E10F1B85900F91463 /* Listener.cpp */ = {isa =
> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp;
> name = Listener.cpp; path = source/Core/Listener.cpp; sourceTree =
> ""; };
> -   26BC7E7F10F1B85900F91463 /* Log.cpp */ = {isa =
> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp;
> name = Log.cpp; path = source/Core/Log.cpp; sourceTree = ""; };
> +   26BC7E7F10F1B85900F91463 /* Log.cpp */ = {isa =
> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp;
> name = Log.cpp; path = source/Utility/Log.cpp; sourceTree = ""; };
> 26BC7E8010F1B85900F91463 /* Mangled.cpp */ = {isa =
> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp;
> name = Mangled.cpp; path = source/Core/Mangled.cpp; sourceTree = "";
> };
> 26BC7E8110F1B85900F91463 /* Module.cpp */ = {isa =
> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp;
> name = Module.cpp; path = source/Core/Module.cpp; sourceTree = ""; };
> 26BC7E8210F1B85900F91463 /* ModuleChild.cpp */ = {isa =
> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp;
> name = ModuleChild.cpp; path = source/Core/ModuleChild.cpp; sourceTree =
> ""; };
> @@ -2335,8 +2335,8 @@
> 33E5E8411A672A240024ED68 /* StringConvert.cpp */ = {isa =
> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp;
> path = StringConvert.cpp; sourceTree = ""; };
> 33E5E8451A6736D30024ED68 /* StringConvert.h */ = {isa =
> PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h;
> name = StringConvert.h; path = include/lldb/Host/StringConvert.h;
> sourceTree = SOURCE_ROOT; };
> 3F5E8AF31A40D4A500A73232 /* PipeBase.h */ = {isa =
> PBXFileReference;

[Lldb-commits] [lldb] r296925 - Fix Darwin failures introduced in r296909

2017-03-03 Thread Tim Hammerquist via lldb-commits 
Author: penryu
Date: Fri Mar  3 17:17:29 2017
New Revision: 296925

URL: http://llvm.org/viewvc/llvm-project?rev=296925=rev
Log:
Fix Darwin failures introduced in r296909

Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj

Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/lldb.xcodeproj/project.pbxproj?rev=296925=296924=296925=diff
==
--- lldb/trunk/lldb.xcodeproj/project.pbxproj (original)
+++ lldb/trunk/lldb.xcodeproj/project.pbxproj Fri Mar  3 17:17:29 2017
@@ -2052,7 +2052,7 @@
26BC7D6310F1B77400F91463 /* FileSpecList.h */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = 
FileSpecList.h; path = include/lldb/Core/FileSpecList.h; sourceTree = 
""; };
26BC7D6510F1B77400F91463 /* IOStreamMacros.h */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = 
IOStreamMacros.h; path = include/lldb/Core/IOStreamMacros.h; sourceTree = 
""; };
26BC7D6710F1B77400F91463 /* Listener.h */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = 
Listener.h; path = include/lldb/Core/Listener.h; sourceTree = ""; };
-   26BC7D6810F1B77400F91463 /* Log.h */ = {isa = PBXFileReference; 
fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = Log.h; path = 
include/lldb/Core/Log.h; sourceTree = ""; };
+   26BC7D6810F1B77400F91463 /* Log.h */ = {isa = PBXFileReference; 
fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = Log.h; path = 
include/lldb/Utility/Log.h; sourceTree = ""; };
26BC7D6910F1B77400F91463 /* Mangled.h */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = 
Mangled.h; path = include/lldb/Core/Mangled.h; sourceTree = ""; };
26BC7D6A10F1B77400F91463 /* Module.h */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = 
Module.h; path = include/lldb/Core/Module.h; sourceTree = ""; };
26BC7D6B10F1B77400F91463 /* ModuleChild.h */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = 
ModuleChild.h; path = include/lldb/Core/ModuleChild.h; sourceTree = ""; 
};
@@ -2139,7 +2139,7 @@
26BC7E7910F1B85900F91463 /* Event.cpp */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; 
name = Event.cpp; path = source/Core/Event.cpp; sourceTree = ""; };
26BC7E7B10F1B85900F91463 /* FileSpecList.cpp */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; 
name = FileSpecList.cpp; path = source/Core/FileSpecList.cpp; sourceTree = 
""; };
26BC7E7E10F1B85900F91463 /* Listener.cpp */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; 
name = Listener.cpp; path = source/Core/Listener.cpp; sourceTree = ""; };
-   26BC7E7F10F1B85900F91463 /* Log.cpp */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; 
name = Log.cpp; path = source/Core/Log.cpp; sourceTree = ""; };
+   26BC7E7F10F1B85900F91463 /* Log.cpp */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; 
name = Log.cpp; path = source/Utility/Log.cpp; sourceTree = ""; };
26BC7E8010F1B85900F91463 /* Mangled.cpp */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; 
name = Mangled.cpp; path = source/Core/Mangled.cpp; sourceTree = ""; };
26BC7E8110F1B85900F91463 /* Module.cpp */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; 
name = Module.cpp; path = source/Core/Module.cpp; sourceTree = ""; };
26BC7E8210F1B85900F91463 /* ModuleChild.cpp */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; 
name = ModuleChild.cpp; path = source/Core/ModuleChild.cpp; sourceTree = 
""; };
@@ -2335,8 +2335,8 @@
33E5E8411A672A240024ED68 /* StringConvert.cpp */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; 
path = StringConvert.cpp; sourceTree = ""; };
33E5E8451A6736D30024ED68 /* StringConvert.h */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = 
StringConvert.h; path = include/lldb/Host/StringConvert.h; sourceTree = 
SOURCE_ROOT; };
3F5E8AF31A40D4A500A73232 /* PipeBase.h */ = {isa = 
PBXFileReference; lastKnownFileType = sourcecode.c.h; name = PipeBase.h; path = 
include/lldb/Host/PipeBase.h; sourceTree = ""; };
-   3F8160A51AB9F7DD001DA9DF /* Logging.cpp */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; 
name = Logging.cpp; path = source/Core/Logging.cpp;