Re: [Lldb-commits] [lldb] r354890 - Fix short options syntax in Minidump test

2019-02-26 Thread Davide Italiano via lldb-commits
Looks like it's green now.

Thanks!

On Tue, Feb 26, 2019 at 8:32 AM Tatyana Krasnukha
 wrote:
>
> This was fixed with r354890 ->  
> http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/20544/
> Do you still have the issue?
>
> -Original Message-
> From: Davide Italiano 
> Sent: Tuesday, February 26, 2019 7:28 PM
> To: Tatyana Krasnukha 
> Cc: lldb-commits 
> Subject: Re: [Lldb-commits] [lldb] r354890 - Fix short options syntax in 
> Minidump test
>
> lldb: unrecognized option `--C'
> error: unknown or ambiguous option
> /Users/buildslave/jenkins/workspace/lldb-cmake/llvm/tools/lldb/lit/Minidump/dump-all.test:55:13:
> error: CHECKCPU: expected string not found in input
>
> this seems to be the issue. Can you give another shot at fixing this or 
> reverting? Thanks!
>
> On Tue, Feb 26, 2019 at 8:16 AM Tatyana Krasnukha 
>  wrote:
> >
> > Those build didn't contain r354890 yet.
> >
> > -Original Message-
> > From: Davide Italiano 
> > Sent: Tuesday, February 26, 2019 7:05 PM
> > To: Tatyana Krasnukha 
> > Cc: lldb-commits 
> > Subject: Re: [Lldb-commits] [lldb] r354890 - Fix short options syntax
> > in Minidump test
> >
> > Link to the failure:
> > https://urldefense.proofpoint.com/v2/url?u=http-3A__green.lab.llvm.org
> > _green_job_lldb-2Dcmake__20543_console&d=DwIBaQ&c=DPL6_X_6JkXFx7AXWqB0
> > tg&r=8NZfjV_ZLY_S7gZyQMq8mj7tiN4vlymPiSt0Wl0jegw&m=g6rcurKPvoK7uD68Vi8
> > adZfyKmJS9bRAr63MKkywSXk&s=jdhvETIBQFdrr0fN0efcvAVZ3EOQdqaYgbWsDZDdEEA
> > &e=
> >
> > On Tue, Feb 26, 2019 at 8:04 AM Davide Italiano  
> > wrote:
> > >
> > > Tatyana, this commit broke one of the bots:
> > >
> > > Testing Time: 315.65s
> > > 
> > > Failing Tests (1):
> > > LLDB :: Minidump/dump-all.test
> > >
> > >   Expected Passes: 1466
> > >   Unsupported Tests  : 64
> > >   Unexpected Failures: 1
> > >
> > >
> > > I'm a little confused if I look at it because it modifies heavily a
> > > test but there's no code change associated? Did you by any chance
> > > forget to add a file?
> > > Anyway, please take a look and let me know if there's anything I can
> > > help you with.
> > >
> > > Best,
> > >
> > > --
> > > Davide
> > >
> > > On Tue, Feb 26, 2019 at 7:37 AM Tatyana Krasnukha via lldb-commits
> > >  wrote:
> > > >
> > > > Author: tkrasnukha
> > > > Date: Tue Feb 26 07:38:30 2019
> > > > New Revision: 354890
> > > >
> > > > URL:
> > > > https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewv
> > > > c_
> > > > llvm-2Dproject-3Frev-3D354890-26view-3Drev&d=DwIBaQ&c=DPL6_X_6JkXF
> > > > x7
> > > > AXWqB0tg&r=8NZfjV_ZLY_S7gZyQMq8mj7tiN4vlymPiSt0Wl0jegw&m=g6rcurKPv
> > > > oK
> > > > 7uD68Vi8adZfyKmJS9bRAr63MKkywSXk&s=-rE0GqyxP9jq55OdKHCMEDhWIfqRpjW
> > > > Xj
> > > > acBkREdhm8&e=
> > > > Log:
> > > > Fix short options syntax in Minidump test
> > > >
> > > > Modified:
> > > > lldb/trunk/lit/Minidump/dump-all.test
> > > >
> > > > Modified: lldb/trunk/lit/Minidump/dump-all.test
> > > > URL:
> > > > https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewv
> > > > c_
> > > > llvm-2Dproject_lldb_trunk_lit_Minidump_dump-2Dall.test-3Frev-3D354
> > > > 89
> > > > 0-26r1-3D354889-26r2-3D354890-26view-3Ddiff&d=DwIBaQ&c=DPL6_X_6JkX
> > > > Fx
> > > > 7AXWqB0tg&r=8NZfjV_ZLY_S7gZyQMq8mj7tiN4vlymPiSt0Wl0jegw&m=g6rcurKP
> > > > vo
> > > > K7uD68Vi8adZfyKmJS9bRAr63MKkywSXk&s=fhMMfmhf9JBV-5F86-iQ8U2aGD73sY
> > > > kJ
> > > > yY5lZd79lrQ&e=
> > > > ==
> > > > ==
> > > > ==
> > > > --- lldb/trunk/lit/Minidump/dump-all.test (original)
> > > > +++ lldb/trunk/lit/Minidump/dump-all.test Tue Feb 26 07:38:30 2019
> > > > @@ -11,32 +11,32 @@
> > > >  # RUN: --check-prefix=CHECKAUX --check-prefix=CHECKMAP \  # RUN:
> > > > --check-prefix=CHECKSTAT --check-prefix=CHECKUP
> > > > --check-prefix=CHECKFD %s  # RUN: %lldb -c
> > > > %p/Inputs/dump-content.dmp -o 'process plugin dump -

Re: [Lldb-commits] [lldb] r354890 - Fix short options syntax in Minidump test

2019-02-26 Thread Tatyana Krasnukha via lldb-commits
This was fixed with r354890 ->  
http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/20544/
Do you still have the issue?

-Original Message-
From: Davide Italiano  
Sent: Tuesday, February 26, 2019 7:28 PM
To: Tatyana Krasnukha 
Cc: lldb-commits 
Subject: Re: [Lldb-commits] [lldb] r354890 - Fix short options syntax in 
Minidump test

lldb: unrecognized option `--C'
error: unknown or ambiguous option
/Users/buildslave/jenkins/workspace/lldb-cmake/llvm/tools/lldb/lit/Minidump/dump-all.test:55:13:
error: CHECKCPU: expected string not found in input

this seems to be the issue. Can you give another shot at fixing this or 
reverting? Thanks!

On Tue, Feb 26, 2019 at 8:16 AM Tatyana Krasnukha 
 wrote:
>
> Those build didn't contain r354890 yet.
>
> -Original Message-
> From: Davide Italiano 
> Sent: Tuesday, February 26, 2019 7:05 PM
> To: Tatyana Krasnukha 
> Cc: lldb-commits 
> Subject: Re: [Lldb-commits] [lldb] r354890 - Fix short options syntax 
> in Minidump test
>
> Link to the failure:
> https://urldefense.proofpoint.com/v2/url?u=http-3A__green.lab.llvm.org
> _green_job_lldb-2Dcmake__20543_console&d=DwIBaQ&c=DPL6_X_6JkXFx7AXWqB0
> tg&r=8NZfjV_ZLY_S7gZyQMq8mj7tiN4vlymPiSt0Wl0jegw&m=g6rcurKPvoK7uD68Vi8
> adZfyKmJS9bRAr63MKkywSXk&s=jdhvETIBQFdrr0fN0efcvAVZ3EOQdqaYgbWsDZDdEEA
> &e=
>
> On Tue, Feb 26, 2019 at 8:04 AM Davide Italiano  wrote:
> >
> > Tatyana, this commit broke one of the bots:
> >
> > Testing Time: 315.65s
> > 
> > Failing Tests (1):
> > LLDB :: Minidump/dump-all.test
> >
> >   Expected Passes: 1466
> >   Unsupported Tests  : 64
> >   Unexpected Failures: 1
> >
> >
> > I'm a little confused if I look at it because it modifies heavily a 
> > test but there's no code change associated? Did you by any chance 
> > forget to add a file?
> > Anyway, please take a look and let me know if there's anything I can 
> > help you with.
> >
> > Best,
> >
> > --
> > Davide
> >
> > On Tue, Feb 26, 2019 at 7:37 AM Tatyana Krasnukha via lldb-commits 
> >  wrote:
> > >
> > > Author: tkrasnukha
> > > Date: Tue Feb 26 07:38:30 2019
> > > New Revision: 354890
> > >
> > > URL:
> > > https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewv
> > > c_
> > > llvm-2Dproject-3Frev-3D354890-26view-3Drev&d=DwIBaQ&c=DPL6_X_6JkXF
> > > x7 
> > > AXWqB0tg&r=8NZfjV_ZLY_S7gZyQMq8mj7tiN4vlymPiSt0Wl0jegw&m=g6rcurKPv
> > > oK 
> > > 7uD68Vi8adZfyKmJS9bRAr63MKkywSXk&s=-rE0GqyxP9jq55OdKHCMEDhWIfqRpjW
> > > Xj
> > > acBkREdhm8&e=
> > > Log:
> > > Fix short options syntax in Minidump test
> > >
> > > Modified:
> > > lldb/trunk/lit/Minidump/dump-all.test
> > >
> > > Modified: lldb/trunk/lit/Minidump/dump-all.test
> > > URL:
> > > https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewv
> > > c_
> > > llvm-2Dproject_lldb_trunk_lit_Minidump_dump-2Dall.test-3Frev-3D354
> > > 89 
> > > 0-26r1-3D354889-26r2-3D354890-26view-3Ddiff&d=DwIBaQ&c=DPL6_X_6JkX
> > > Fx 
> > > 7AXWqB0tg&r=8NZfjV_ZLY_S7gZyQMq8mj7tiN4vlymPiSt0Wl0jegw&m=g6rcurKP
> > > vo 
> > > K7uD68Vi8adZfyKmJS9bRAr63MKkywSXk&s=fhMMfmhf9JBV-5F86-iQ8U2aGD73sY
> > > kJ
> > > yY5lZd79lrQ&e=
> > > ==
> > > ==
> > > ==
> > > --- lldb/trunk/lit/Minidump/dump-all.test (original)
> > > +++ lldb/trunk/lit/Minidump/dump-all.test Tue Feb 26 07:38:30 2019
> > > @@ -11,32 +11,32 @@
> > >  # RUN: --check-prefix=CHECKAUX --check-prefix=CHECKMAP \  # RUN:
> > > --check-prefix=CHECKSTAT --check-prefix=CHECKUP 
> > > --check-prefix=CHECKFD %s  # RUN: %lldb -c 
> > > %p/Inputs/dump-content.dmp -o 'process plugin dump --directory' | 
> > > FileCheck --check-prefix=CHECKDIR %s -# RUN: %lldb -c 
> > > %p/Inputs/dump-content.dmp -o 'process plugin dump --d' | 
> > > FileCheck --check-prefix=CHECKDIR %s
> > > +# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin 
> > > +dump -d' | FileCheck --check-prefix=CHECKDIR %s
> > >  # RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin 
> > > dump --linux' | \  # RUN: FileCheck --check-prefix=CHECKCPU 
> > > --check-prefix=CHECKSTATUS \  # RUN: --check-prefix=CHECKLSB 
> > > --check-prefix=C

Re: [Lldb-commits] [lldb] r354890 - Fix short options syntax in Minidump test

2019-02-26 Thread Davide Italiano via lldb-commits
lldb: unrecognized option `--C'
error: unknown or ambiguous option
/Users/buildslave/jenkins/workspace/lldb-cmake/llvm/tools/lldb/lit/Minidump/dump-all.test:55:13:
error: CHECKCPU: expected string not found in input

this seems to be the issue. Can you give another shot at fixing this
or reverting? Thanks!

On Tue, Feb 26, 2019 at 8:16 AM Tatyana Krasnukha
 wrote:
>
> Those build didn't contain r354890 yet.
>
> -Original Message-
> From: Davide Italiano 
> Sent: Tuesday, February 26, 2019 7:05 PM
> To: Tatyana Krasnukha 
> Cc: lldb-commits 
> Subject: Re: [Lldb-commits] [lldb] r354890 - Fix short options syntax in 
> Minidump test
>
> Link to the failure:
> https://urldefense.proofpoint.com/v2/url?u=http-3A__green.lab.llvm.org_green_job_lldb-2Dcmake__20543_console&d=DwIBaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=8NZfjV_ZLY_S7gZyQMq8mj7tiN4vlymPiSt0Wl0jegw&m=g6rcurKPvoK7uD68Vi8adZfyKmJS9bRAr63MKkywSXk&s=jdhvETIBQFdrr0fN0efcvAVZ3EOQdqaYgbWsDZDdEEA&e=
>
> On Tue, Feb 26, 2019 at 8:04 AM Davide Italiano  wrote:
> >
> > Tatyana, this commit broke one of the bots:
> >
> > Testing Time: 315.65s
> > 
> > Failing Tests (1):
> > LLDB :: Minidump/dump-all.test
> >
> >   Expected Passes: 1466
> >   Unsupported Tests  : 64
> >   Unexpected Failures: 1
> >
> >
> > I'm a little confused if I look at it because it modifies heavily a
> > test but there's no code change associated? Did you by any chance
> > forget to add a file?
> > Anyway, please take a look and let me know if there's anything I can
> > help you with.
> >
> > Best,
> >
> > --
> > Davide
> >
> > On Tue, Feb 26, 2019 at 7:37 AM Tatyana Krasnukha via lldb-commits
> >  wrote:
> > >
> > > Author: tkrasnukha
> > > Date: Tue Feb 26 07:38:30 2019
> > > New Revision: 354890
> > >
> > > URL:
> > > https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_
> > > llvm-2Dproject-3Frev-3D354890-26view-3Drev&d=DwIBaQ&c=DPL6_X_6JkXFx7
> > > AXWqB0tg&r=8NZfjV_ZLY_S7gZyQMq8mj7tiN4vlymPiSt0Wl0jegw&m=g6rcurKPvoK
> > > 7uD68Vi8adZfyKmJS9bRAr63MKkywSXk&s=-rE0GqyxP9jq55OdKHCMEDhWIfqRpjWXj
> > > acBkREdhm8&e=
> > > Log:
> > > Fix short options syntax in Minidump test
> > >
> > > Modified:
> > > lldb/trunk/lit/Minidump/dump-all.test
> > >
> > > Modified: lldb/trunk/lit/Minidump/dump-all.test
> > > URL:
> > > https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_
> > > llvm-2Dproject_lldb_trunk_lit_Minidump_dump-2Dall.test-3Frev-3D35489
> > > 0-26r1-3D354889-26r2-3D354890-26view-3Ddiff&d=DwIBaQ&c=DPL6_X_6JkXFx
> > > 7AXWqB0tg&r=8NZfjV_ZLY_S7gZyQMq8mj7tiN4vlymPiSt0Wl0jegw&m=g6rcurKPvo
> > > K7uD68Vi8adZfyKmJS9bRAr63MKkywSXk&s=fhMMfmhf9JBV-5F86-iQ8U2aGD73sYkJ
> > > yY5lZd79lrQ&e=
> > > 
> > > ==
> > > --- lldb/trunk/lit/Minidump/dump-all.test (original)
> > > +++ lldb/trunk/lit/Minidump/dump-all.test Tue Feb 26 07:38:30 2019
> > > @@ -11,32 +11,32 @@
> > >  # RUN: --check-prefix=CHECKAUX --check-prefix=CHECKMAP \  # RUN:
> > > --check-prefix=CHECKSTAT --check-prefix=CHECKUP
> > > --check-prefix=CHECKFD %s  # RUN: %lldb -c
> > > %p/Inputs/dump-content.dmp -o 'process plugin dump --directory' |
> > > FileCheck --check-prefix=CHECKDIR %s -# RUN: %lldb -c
> > > %p/Inputs/dump-content.dmp -o 'process plugin dump --d' | FileCheck
> > > --check-prefix=CHECKDIR %s
> > > +# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump
> > > +-d' | FileCheck --check-prefix=CHECKDIR %s
> > >  # RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump
> > > --linux' | \  # RUN: FileCheck --check-prefix=CHECKCPU
> > > --check-prefix=CHECKSTATUS \  # RUN: --check-prefix=CHECKLSB
> > > --check-prefix=CHECKCMD --check-prefix=CHECKENV \  # RUN:
> > > --check-prefix=CHECKAUX --check-prefix=CHECKMAP
> > > --check-prefix=CHECKSTAT \  # RUN: --check-prefix=CHECKUP
> > > --check-prefix=CHECKFD %s -# RUN: %lldb -c
> > > %p/Inputs/dump-content.dmp -o 'process plugin dump --cpuinfo' |
> > > FileCheck --check-prefix=CHECKCPU %s -# RUN: %lldb -c
> > > %p/Inputs/dump-content.dmp -o 'process plugin dump --C' | FileCheck
> > > --check-prefix=CHECKCPU %s -# RUN: %lldb -c
> > &g

Re: [Lldb-commits] [lldb] r354890 - Fix short options syntax in Minidump test

2019-02-26 Thread Tatyana Krasnukha via lldb-commits
Those build didn't contain r354890 yet.

-Original Message-
From: Davide Italiano  
Sent: Tuesday, February 26, 2019 7:05 PM
To: Tatyana Krasnukha 
Cc: lldb-commits 
Subject: Re: [Lldb-commits] [lldb] r354890 - Fix short options syntax in 
Minidump test

Link to the failure:
https://urldefense.proofpoint.com/v2/url?u=http-3A__green.lab.llvm.org_green_job_lldb-2Dcmake__20543_console&d=DwIBaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=8NZfjV_ZLY_S7gZyQMq8mj7tiN4vlymPiSt0Wl0jegw&m=g6rcurKPvoK7uD68Vi8adZfyKmJS9bRAr63MKkywSXk&s=jdhvETIBQFdrr0fN0efcvAVZ3EOQdqaYgbWsDZDdEEA&e=

On Tue, Feb 26, 2019 at 8:04 AM Davide Italiano  wrote:
>
> Tatyana, this commit broke one of the bots:
>
> Testing Time: 315.65s
> 
> Failing Tests (1):
> LLDB :: Minidump/dump-all.test
>
>   Expected Passes: 1466
>   Unsupported Tests  : 64
>   Unexpected Failures: 1
>
>
> I'm a little confused if I look at it because it modifies heavily a 
> test but there's no code change associated? Did you by any chance 
> forget to add a file?
> Anyway, please take a look and let me know if there's anything I can 
> help you with.
>
> Best,
>
> --
> Davide
>
> On Tue, Feb 26, 2019 at 7:37 AM Tatyana Krasnukha via lldb-commits 
>  wrote:
> >
> > Author: tkrasnukha
> > Date: Tue Feb 26 07:38:30 2019
> > New Revision: 354890
> >
> > URL: 
> > https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_
> > llvm-2Dproject-3Frev-3D354890-26view-3Drev&d=DwIBaQ&c=DPL6_X_6JkXFx7
> > AXWqB0tg&r=8NZfjV_ZLY_S7gZyQMq8mj7tiN4vlymPiSt0Wl0jegw&m=g6rcurKPvoK
> > 7uD68Vi8adZfyKmJS9bRAr63MKkywSXk&s=-rE0GqyxP9jq55OdKHCMEDhWIfqRpjWXj
> > acBkREdhm8&e=
> > Log:
> > Fix short options syntax in Minidump test
> >
> > Modified:
> > lldb/trunk/lit/Minidump/dump-all.test
> >
> > Modified: lldb/trunk/lit/Minidump/dump-all.test
> > URL: 
> > https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_
> > llvm-2Dproject_lldb_trunk_lit_Minidump_dump-2Dall.test-3Frev-3D35489
> > 0-26r1-3D354889-26r2-3D354890-26view-3Ddiff&d=DwIBaQ&c=DPL6_X_6JkXFx
> > 7AXWqB0tg&r=8NZfjV_ZLY_S7gZyQMq8mj7tiN4vlymPiSt0Wl0jegw&m=g6rcurKPvo
> > K7uD68Vi8adZfyKmJS9bRAr63MKkywSXk&s=fhMMfmhf9JBV-5F86-iQ8U2aGD73sYkJ
> > yY5lZd79lrQ&e= 
> > 
> > ==
> > --- lldb/trunk/lit/Minidump/dump-all.test (original)
> > +++ lldb/trunk/lit/Minidump/dump-all.test Tue Feb 26 07:38:30 2019
> > @@ -11,32 +11,32 @@
> >  # RUN: --check-prefix=CHECKAUX --check-prefix=CHECKMAP \  # RUN: 
> > --check-prefix=CHECKSTAT --check-prefix=CHECKUP 
> > --check-prefix=CHECKFD %s  # RUN: %lldb -c 
> > %p/Inputs/dump-content.dmp -o 'process plugin dump --directory' | 
> > FileCheck --check-prefix=CHECKDIR %s -# RUN: %lldb -c 
> > %p/Inputs/dump-content.dmp -o 'process plugin dump --d' | FileCheck 
> > --check-prefix=CHECKDIR %s
> > +# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump 
> > +-d' | FileCheck --check-prefix=CHECKDIR %s
> >  # RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump 
> > --linux' | \  # RUN: FileCheck --check-prefix=CHECKCPU 
> > --check-prefix=CHECKSTATUS \  # RUN: --check-prefix=CHECKLSB 
> > --check-prefix=CHECKCMD --check-prefix=CHECKENV \  # RUN: 
> > --check-prefix=CHECKAUX --check-prefix=CHECKMAP 
> > --check-prefix=CHECKSTAT \  # RUN: --check-prefix=CHECKUP 
> > --check-prefix=CHECKFD %s -# RUN: %lldb -c 
> > %p/Inputs/dump-content.dmp -o 'process plugin dump --cpuinfo' | 
> > FileCheck --check-prefix=CHECKCPU %s -# RUN: %lldb -c 
> > %p/Inputs/dump-content.dmp -o 'process plugin dump --C' | FileCheck 
> > --check-prefix=CHECKCPU %s -# RUN: %lldb -c 
> > %p/Inputs/dump-content.dmp -o 'process plugin dump --status' | 
> > FileCheck --check-prefix=CHECKSTATUS %s -# RUN: %lldb -c 
> > %p/Inputs/dump-content.dmp -o 'process plugin dump --s' | FileCheck 
> > --check-prefix=CHECKSTATUS %s
> > +# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump 
> > --cpuinfo' | FileCheck --check-prefix=CHECKCPU %s
> > +# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump -C' 
> >| FileCheck --check-prefix=CHECKCPU %s
> > +# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump 
> > --status'  | FileCheck --check-prefix=CHECKSTATUS %s
> > +# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'proces

Re: [Lldb-commits] [lldb] r354890 - Fix short options syntax in Minidump test

2019-02-26 Thread Davide Italiano via lldb-commits
Link to the failure:
http://green.lab.llvm.org/green/job/lldb-cmake//20543/console

On Tue, Feb 26, 2019 at 8:04 AM Davide Italiano  wrote:
>
> Tatyana, this commit broke one of the bots:
>
> Testing Time: 315.65s
> 
> Failing Tests (1):
> LLDB :: Minidump/dump-all.test
>
>   Expected Passes: 1466
>   Unsupported Tests  : 64
>   Unexpected Failures: 1
>
>
> I'm a little confused if I look at it because it modifies heavily a
> test but there's no code change associated? Did you by any chance
> forget to add a file?
> Anyway, please take a look and let me know if there's anything I can
> help you with.
>
> Best,
>
> --
> Davide
>
> On Tue, Feb 26, 2019 at 7:37 AM Tatyana Krasnukha via lldb-commits
>  wrote:
> >
> > Author: tkrasnukha
> > Date: Tue Feb 26 07:38:30 2019
> > New Revision: 354890
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=354890&view=rev
> > Log:
> > Fix short options syntax in Minidump test
> >
> > Modified:
> > lldb/trunk/lit/Minidump/dump-all.test
> >
> > Modified: lldb/trunk/lit/Minidump/dump-all.test
> > URL: 
> > http://llvm.org/viewvc/llvm-project/lldb/trunk/lit/Minidump/dump-all.test?rev=354890&r1=354889&r2=354890&view=diff
> > ==
> > --- lldb/trunk/lit/Minidump/dump-all.test (original)
> > +++ lldb/trunk/lit/Minidump/dump-all.test Tue Feb 26 07:38:30 2019
> > @@ -11,32 +11,32 @@
> >  # RUN: --check-prefix=CHECKAUX --check-prefix=CHECKMAP \
> >  # RUN: --check-prefix=CHECKSTAT --check-prefix=CHECKUP 
> > --check-prefix=CHECKFD %s
> >  # RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump 
> > --directory' | FileCheck --check-prefix=CHECKDIR %s
> > -# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump --d' | 
> > FileCheck --check-prefix=CHECKDIR %s
> > +# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump -d' | 
> > FileCheck --check-prefix=CHECKDIR %s
> >  # RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump 
> > --linux' | \
> >  # RUN: FileCheck --check-prefix=CHECKCPU --check-prefix=CHECKSTATUS \
> >  # RUN: --check-prefix=CHECKLSB --check-prefix=CHECKCMD 
> > --check-prefix=CHECKENV \
> >  # RUN: --check-prefix=CHECKAUX --check-prefix=CHECKMAP 
> > --check-prefix=CHECKSTAT \
> >  # RUN: --check-prefix=CHECKUP --check-prefix=CHECKFD %s
> > -# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump 
> > --cpuinfo' | FileCheck --check-prefix=CHECKCPU %s
> > -# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump --C' | 
> > FileCheck --check-prefix=CHECKCPU %s
> > -# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump 
> > --status' | FileCheck --check-prefix=CHECKSTATUS %s
> > -# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump --s' | 
> > FileCheck --check-prefix=CHECKSTATUS %s
> > +# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump 
> > --cpuinfo' | FileCheck --check-prefix=CHECKCPU %s
> > +# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump -C' 
> >| FileCheck --check-prefix=CHECKCPU %s
> > +# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump 
> > --status'  | FileCheck --check-prefix=CHECKSTATUS %s
> > +# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump -s' 
> >| FileCheck --check-prefix=CHECKSTATUS %s
> >  # RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump 
> > --lsb-release' | FileCheck --check-prefix=CHECKLSB %s
> > -# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump --r' | 
> > FileCheck --check-prefix=CHECKLSB %s
> > -# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump 
> > --cmdline' | FileCheck --check-prefix=CHECKCMD %s
> > -# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump --c' | 
> > FileCheck --check-prefix=CHECKCMD %s
> > -# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump 
> > --environ' | FileCheck --check-prefix=CHECKENV %s
> > -# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump --e' | 
> > FileCheck --check-prefix=CHECKENV %s
> > -# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump --auxv' 
> > | FileCheck --check-prefix=CHECKAUX %s
> > -# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump --x' | 
> > FileCheck --check-prefix=CHECKAUX %s
> > -# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump --maps' 
> > | FileCheck --check-prefix=CHECKMAP %s
> > -# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump --m' | 
> > FileCheck --check-prefix=CHECKMAP %s
> > -# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump --stat' 
> > | FileCheck --check-prefix=CHECKSTAT %s
> > -# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump --S' | 
> > FileCheck --check-prefix=CHECKSTAT %s
> > -# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump 
> > --uptime' | FileCheck --check-prefix

Re: [Lldb-commits] [lldb] r354890 - Fix short options syntax in Minidump test

2019-02-26 Thread Davide Italiano via lldb-commits
Tatyana, this commit broke one of the bots:

Testing Time: 315.65s

Failing Tests (1):
LLDB :: Minidump/dump-all.test

  Expected Passes: 1466
  Unsupported Tests  : 64
  Unexpected Failures: 1


I'm a little confused if I look at it because it modifies heavily a
test but there's no code change associated? Did you by any chance
forget to add a file?
Anyway, please take a look and let me know if there's anything I can
help you with.

Best,

--
Davide

On Tue, Feb 26, 2019 at 7:37 AM Tatyana Krasnukha via lldb-commits
 wrote:
>
> Author: tkrasnukha
> Date: Tue Feb 26 07:38:30 2019
> New Revision: 354890
>
> URL: http://llvm.org/viewvc/llvm-project?rev=354890&view=rev
> Log:
> Fix short options syntax in Minidump test
>
> Modified:
> lldb/trunk/lit/Minidump/dump-all.test
>
> Modified: lldb/trunk/lit/Minidump/dump-all.test
> URL: 
> http://llvm.org/viewvc/llvm-project/lldb/trunk/lit/Minidump/dump-all.test?rev=354890&r1=354889&r2=354890&view=diff
> ==
> --- lldb/trunk/lit/Minidump/dump-all.test (original)
> +++ lldb/trunk/lit/Minidump/dump-all.test Tue Feb 26 07:38:30 2019
> @@ -11,32 +11,32 @@
>  # RUN: --check-prefix=CHECKAUX --check-prefix=CHECKMAP \
>  # RUN: --check-prefix=CHECKSTAT --check-prefix=CHECKUP 
> --check-prefix=CHECKFD %s
>  # RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump 
> --directory' | FileCheck --check-prefix=CHECKDIR %s
> -# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump --d' | 
> FileCheck --check-prefix=CHECKDIR %s
> +# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump -d' | 
> FileCheck --check-prefix=CHECKDIR %s
>  # RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump --linux' 
> | \
>  # RUN: FileCheck --check-prefix=CHECKCPU --check-prefix=CHECKSTATUS \
>  # RUN: --check-prefix=CHECKLSB --check-prefix=CHECKCMD 
> --check-prefix=CHECKENV \
>  # RUN: --check-prefix=CHECKAUX --check-prefix=CHECKMAP 
> --check-prefix=CHECKSTAT \
>  # RUN: --check-prefix=CHECKUP --check-prefix=CHECKFD %s
> -# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump 
> --cpuinfo' | FileCheck --check-prefix=CHECKCPU %s
> -# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump --C' | 
> FileCheck --check-prefix=CHECKCPU %s
> -# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump --status' 
> | FileCheck --check-prefix=CHECKSTATUS %s
> -# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump --s' | 
> FileCheck --check-prefix=CHECKSTATUS %s
> +# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump 
> --cpuinfo' | FileCheck --check-prefix=CHECKCPU %s
> +# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump -C'   
>  | FileCheck --check-prefix=CHECKCPU %s
> +# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump --status' 
>  | FileCheck --check-prefix=CHECKSTATUS %s
> +# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump -s'   
>  | FileCheck --check-prefix=CHECKSTATUS %s
>  # RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump 
> --lsb-release' | FileCheck --check-prefix=CHECKLSB %s
> -# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump --r' | 
> FileCheck --check-prefix=CHECKLSB %s
> -# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump 
> --cmdline' | FileCheck --check-prefix=CHECKCMD %s
> -# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump --c' | 
> FileCheck --check-prefix=CHECKCMD %s
> -# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump 
> --environ' | FileCheck --check-prefix=CHECKENV %s
> -# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump --e' | 
> FileCheck --check-prefix=CHECKENV %s
> -# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump --auxv' | 
> FileCheck --check-prefix=CHECKAUX %s
> -# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump --x' | 
> FileCheck --check-prefix=CHECKAUX %s
> -# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump --maps' | 
> FileCheck --check-prefix=CHECKMAP %s
> -# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump --m' | 
> FileCheck --check-prefix=CHECKMAP %s
> -# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump --stat' | 
> FileCheck --check-prefix=CHECKSTAT %s
> -# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump --S' | 
> FileCheck --check-prefix=CHECKSTAT %s
> -# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump --uptime' 
> | FileCheck --check-prefix=CHECKUP %s
> -# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump --u' | 
> FileCheck --check-prefix=CHECKUP %s
> -# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump --fd' | 
> FileCheck --check-prefix=CHECKFD %s
> -# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump --f' | 
> FileCheck --chec

[Lldb-commits] [lldb] r354890 - Fix short options syntax in Minidump test

2019-02-26 Thread Tatyana Krasnukha via lldb-commits
Author: tkrasnukha
Date: Tue Feb 26 07:38:30 2019
New Revision: 354890

URL: http://llvm.org/viewvc/llvm-project?rev=354890&view=rev
Log:
Fix short options syntax in Minidump test

Modified:
lldb/trunk/lit/Minidump/dump-all.test

Modified: lldb/trunk/lit/Minidump/dump-all.test
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/lit/Minidump/dump-all.test?rev=354890&r1=354889&r2=354890&view=diff
==
--- lldb/trunk/lit/Minidump/dump-all.test (original)
+++ lldb/trunk/lit/Minidump/dump-all.test Tue Feb 26 07:38:30 2019
@@ -11,32 +11,32 @@
 # RUN: --check-prefix=CHECKAUX --check-prefix=CHECKMAP \
 # RUN: --check-prefix=CHECKSTAT --check-prefix=CHECKUP --check-prefix=CHECKFD 
%s
 # RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump 
--directory' | FileCheck --check-prefix=CHECKDIR %s
-# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump --d' | 
FileCheck --check-prefix=CHECKDIR %s
+# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump -d' | 
FileCheck --check-prefix=CHECKDIR %s
 # RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump --linux' | \
 # RUN: FileCheck --check-prefix=CHECKCPU --check-prefix=CHECKSTATUS \
 # RUN: --check-prefix=CHECKLSB --check-prefix=CHECKCMD --check-prefix=CHECKENV 
\
 # RUN: --check-prefix=CHECKAUX --check-prefix=CHECKMAP 
--check-prefix=CHECKSTAT \
 # RUN: --check-prefix=CHECKUP --check-prefix=CHECKFD %s
-# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump --cpuinfo' 
| FileCheck --check-prefix=CHECKCPU %s
-# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump --C' | 
FileCheck --check-prefix=CHECKCPU %s
-# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump --status' | 
FileCheck --check-prefix=CHECKSTATUS %s
-# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump --s' | 
FileCheck --check-prefix=CHECKSTATUS %s
+# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump --cpuinfo'  
   | FileCheck --check-prefix=CHECKCPU %s
+# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump -C' 
   | FileCheck --check-prefix=CHECKCPU %s
+# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump --status'   
   | FileCheck --check-prefix=CHECKSTATUS %s
+# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump -s' 
   | FileCheck --check-prefix=CHECKSTATUS %s
 # RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump 
--lsb-release' | FileCheck --check-prefix=CHECKLSB %s
-# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump --r' | 
FileCheck --check-prefix=CHECKLSB %s
-# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump --cmdline' 
| FileCheck --check-prefix=CHECKCMD %s
-# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump --c' | 
FileCheck --check-prefix=CHECKCMD %s
-# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump --environ' 
| FileCheck --check-prefix=CHECKENV %s
-# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump --e' | 
FileCheck --check-prefix=CHECKENV %s
-# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump --auxv' | 
FileCheck --check-prefix=CHECKAUX %s
-# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump --x' | 
FileCheck --check-prefix=CHECKAUX %s
-# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump --maps' | 
FileCheck --check-prefix=CHECKMAP %s
-# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump --m' | 
FileCheck --check-prefix=CHECKMAP %s
-# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump --stat' | 
FileCheck --check-prefix=CHECKSTAT %s
-# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump --S' | 
FileCheck --check-prefix=CHECKSTAT %s
-# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump --uptime' | 
FileCheck --check-prefix=CHECKUP %s
-# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump --u' | 
FileCheck --check-prefix=CHECKUP %s
-# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump --fd' | 
FileCheck --check-prefix=CHECKFD %s
-# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump --f' | 
FileCheck --check-prefix=CHECKFD %s
+# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump -r' 
   | FileCheck --check-prefix=CHECKLSB %s
+# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump --cmdline'  
   | FileCheck --check-prefix=CHECKCMD %s
+# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump -c' 
   | FileCheck --check-prefix=CHECKCMD %s
+# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump --environ'  
   | FileCheck --check-prefix=CHECKENV %s
+# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump -e' 
   | FileCheck --check-prefix=CHECKENV %s
+# RUN: %lldb -c %p/Inputs/dump-content.dmp -o 'process plugin dump --auxv' 
   | Fil