Re: [lldb-dev] [cfe-dev] [GitHub] RFC: Enforcing no merge commit policy
> Github PRs are how everyone who is not already super-involved in the llvm > project is going to want to contribute changes, and we ought to be as > welcoming as possible to such users. Still we'd need some policy & checks here. Say, what if someone will issue a PR to LLVM 4.0 branch? With clear code style violations, etc. -- With best regards, Anton Korobeynikov Department of Statistical Modelling, Saint Petersburg State University ___ lldb-dev mailing list lldb-dev@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
Re: [lldb-dev] [Release-testers] [8.0.0 Release] The final tag is in
On 18 Mar 2019, at 14:04, Hans Wennborg via Release-testers wrote: > The final version of 8.0.0 was just tagged from the release_80 branch > at r356364. It's identical to rc5 except for a few documentation > changes. Again, I had to disable compiler-rt for this test run, as most of the sanitizers are totally broken. This is tracked in PR40761. Main test results on amd64-freebsd11: Expected Passes: 53244 (rc5: 53896) Expected Failures : 213 (rc5: 220) Unsupported Tests : 1716 (rc5: 1081) Unresolved Tests : 7 (rc5:10) Unexpected Passes : 3 (rc5: 3) Unexpected Failures:62 (rc5:65) Main test results on i386-freebsd11: Expected Passes: 53098 (rc5: 53749) Expected Failures : 229 (rc5: 236) Unsupported Tests : 1538 (rc5: 903) Unresolved Tests : 8 (rc5:10) Unexpected Passes : 5 (rc5: 5) Unexpected Failures: 172 (rc5: 177) The unresolved tests are due to a number of tests hanging in state, forcing me to kill their parent .py processes. Uploaded: SHA256 (clang+llvm-8.0.0-amd64-unknown-freebsd11.tar.xz) = af15d14bd25e469e35ed7c43cb7e035bc1b2aa7b55d26ad597a43e72768750a8 SHA256 (clang+llvm-8.0.0-i386-unknown-freebsd11.tar.xz) = 1ba88663ccda4e9fad93f8f35dde7ce04854abc0bcbb1d12a90cdc863e4a77b8 -Dimitry signature.asc Description: Message signed with OpenPGP ___ lldb-dev mailing list lldb-dev@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
Re: [lldb-dev] [cfe-dev] [GitHub] RFC: Enforcing no merge commit policy
Honestly I'm looking forward to GitHub's interface here. On Tue, Mar 19, 2019, 1:25 PM James Y Knight via lldb-dev < lldb-dev@lists.llvm.org> wrote: > I think we definitely will want to support github PRs, at the very least > as an _option_, even if we continue running/preferring phabricator. > > Github PRs are how everyone who is not already super-involved in the llvm > project is going to want to contribute changes, and we ought to be as > welcoming as possible to such users. > > On Tue, Mar 19, 2019 at 3:15 PM Roman Lebedev via cfe-dev < > cfe-...@lists.llvm.org> wrote: > >> On Tue, Mar 19, 2019 at 10:00 PM Tom Stellard via cfe-dev >> wrote: >> > >> > Hi, >> > >> > I would like to follow up on the previous thread[1], where there was a >> consensus >> > to disallow merge commits in the llvm github repository, and start a >> discussion >> > about how we should enforce this policy. >> > >> > Unfortunately, GitHub does not provide a convenient way to fully >> enforce this policy. >> > We can enforce it for pull requests, but not for direct pushes to the >> master branch, >> > so we will have to come up with our own solution if we want to >> completely prevent >> > merge commits. I've spent some time looking into this and here are a >> few >> > options that I've come up with (If you are a GitHub expert and have >> other >> > suggestions, please let us know): >> > >> > 1. Have either a status check or use the "Rebase and Merge" policy for >> pull requests >> > to disallow merge commits. Disable direct pushes to the master branch >> and update the >> > git-llvm script to create a pull request when a developer does `git >> llvm push` and >> > then have it automatically merged if there are no merge commits. >> > >> > 2. Enforce no merge commits for pull requests, but sill allow >> developers to push directly >> > to master without checking for merge requests. This is essentially a >> best effort >> > approach where we avoid having to implement our own custom work-flow >> for committing, >> > while accepting the possibility that someone might accidentally push a >> merge commit. >> > >> > 3. Disable direct pushes to master, don't update the git-llvm script >> and require all >> > developers to use pull requests, where this policy will be enforced. >> > >> > Which option do you prefer? >> All these options include at least partial usage of/switch to github pr's. >> I don't think that was discussed before. (FWIW i'm opposed to that.) >> >> Is there a fourth option - ask github whether they could make an exception >> for LLVM to use server-side hooks? They are available in github >> enterprise. >> >> > -Tom >> Roman. >> >> > [1] http://lists.llvm.org/pipermail/llvm-dev/2019-January/129723.html >> > ___ >> > cfe-dev mailing list >> > cfe-...@lists.llvm.org >> > https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev >> ___ >> cfe-dev mailing list >> cfe-...@lists.llvm.org >> https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev >> > ___ > lldb-dev mailing list > lldb-dev@lists.llvm.org > https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev > ___ lldb-dev mailing list lldb-dev@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
Re: [lldb-dev] [cfe-dev] [GitHub] RFC: Enforcing no merge commit policy
I think we definitely will want to support github PRs, at the very least as an _option_, even if we continue running/preferring phabricator. Github PRs are how everyone who is not already super-involved in the llvm project is going to want to contribute changes, and we ought to be as welcoming as possible to such users. On Tue, Mar 19, 2019 at 3:15 PM Roman Lebedev via cfe-dev < cfe-...@lists.llvm.org> wrote: > On Tue, Mar 19, 2019 at 10:00 PM Tom Stellard via cfe-dev > wrote: > > > > Hi, > > > > I would like to follow up on the previous thread[1], where there was a > consensus > > to disallow merge commits in the llvm github repository, and start a > discussion > > about how we should enforce this policy. > > > > Unfortunately, GitHub does not provide a convenient way to fully enforce > this policy. > > We can enforce it for pull requests, but not for direct pushes to the > master branch, > > so we will have to come up with our own solution if we want to > completely prevent > > merge commits. I've spent some time looking into this and here are a few > > options that I've come up with (If you are a GitHub expert and have other > > suggestions, please let us know): > > > > 1. Have either a status check or use the "Rebase and Merge" policy for > pull requests > > to disallow merge commits. Disable direct pushes to the master branch > and update the > > git-llvm script to create a pull request when a developer does `git llvm > push` and > > then have it automatically merged if there are no merge commits. > > > > 2. Enforce no merge commits for pull requests, but sill allow developers > to push directly > > to master without checking for merge requests. This is essentially a > best effort > > approach where we avoid having to implement our own custom work-flow for > committing, > > while accepting the possibility that someone might accidentally push a > merge commit. > > > > 3. Disable direct pushes to master, don't update the git-llvm script and > require all > > developers to use pull requests, where this policy will be enforced. > > > > Which option do you prefer? > All these options include at least partial usage of/switch to github pr's. > I don't think that was discussed before. (FWIW i'm opposed to that.) > > Is there a fourth option - ask github whether they could make an exception > for LLVM to use server-side hooks? They are available in github enterprise. > > > -Tom > Roman. > > > [1] http://lists.llvm.org/pipermail/llvm-dev/2019-January/129723.html > > ___ > > cfe-dev mailing list > > cfe-...@lists.llvm.org > > https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev > ___ > cfe-dev mailing list > cfe-...@lists.llvm.org > https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev > ___ lldb-dev mailing list lldb-dev@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
[lldb-dev] [GitHub] RFC: Enforcing no merge commit policy
Hi, I would like to follow up on the previous thread[1], where there was a consensus to disallow merge commits in the llvm github repository, and start a discussion about how we should enforce this policy. Unfortunately, GitHub does not provide a convenient way to fully enforce this policy. We can enforce it for pull requests, but not for direct pushes to the master branch, so we will have to come up with our own solution if we want to completely prevent merge commits. I've spent some time looking into this and here are a few options that I've come up with (If you are a GitHub expert and have other suggestions, please let us know): 1. Have either a status check or use the "Rebase and Merge" policy for pull requests to disallow merge commits. Disable direct pushes to the master branch and update the git-llvm script to create a pull request when a developer does `git llvm push` and then have it automatically merged if there are no merge commits. 2. Enforce no merge commits for pull requests, but sill allow developers to push directly to master without checking for merge requests. This is essentially a best effort approach where we avoid having to implement our own custom work-flow for committing, while accepting the possibility that someone might accidentally push a merge commit. 3. Disable direct pushes to master, don't update the git-llvm script and require all developers to use pull requests, where this policy will be enforced. Which option do you prefer? -Tom [1] http://lists.llvm.org/pipermail/llvm-dev/2019-January/129723.html ___ lldb-dev mailing list lldb-dev@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
Re: [lldb-dev] confirm 84b5fef811e7c8b2836d1c76914c276609d50299
___ lldb-dev mailing list lldb-dev@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
