Re: [lldb-dev] Win64 lldb build broken, llvm::call_once and _mm_mfence

[Reid Kleckner via lldb-dev]

These issues should be resolved by r295013 and r295014.

On Thu, Feb 9, 2017 at 1:55 PM, Hans Wennborg  wrote:

> I'm happy as long as it builds :-)
>
> On Wed, Feb 8, 2017 at 2:26 PM, Zachary Turner  wrote:
> > Should we do that now, as a way to fix this issue, or should we try to
> get
> > another fix in first so we have more time to think about using std
> > call_once?
> >
> > On Wed, Feb 8, 2017 at 2:19 PM Reid Kleckner  wrote:
> >>
> >> I think we can. MSVC's std::once_flag default constructor is constexpr
> >> now. It still generates dynamic initialization code if you use it as a
> >> static local, but MSVC defaults to using thread safe static
> initialization,
> >> so that isn't a problem unless you disable it, which we don't. We
> disable it
> >> in compiler-rt (/Zc:threadSafeInit-), but that doesn't use this code.
> >>
> >> On Wed, Feb 8, 2017 at 1:18 PM, Zachary Turner 
> wrote:
> >>>
> >>> Is this the right review?  https://reviews.llvm.org/D5922
> >>>
> >>> Being that this was over 2 years ago, I suspect it was when we were
> >>> supporting MSVC2012 and 2013.  Now that we're requiring MSVC2015, is
> it time
> >>> to reconsider? I don't see any links to an MS Connect issue, so I
> don't know
> >>> what the original bug was to know if it has been fixed.
> >>>
> >>>
> >>> On Wed, Feb 8, 2017 at 1:03 PM Reid Kleckner  wrote:
> 
>  It's a sad story. Read the comments and the review threads. It's
>  hilarious.
> 
>  On Wed, Feb 8, 2017 at 1:00 PM, Zachary Turner via lldb-dev
>   wrote:
> >
> > Why doesn't llvm::call_once() just use std::call_once on Windows?
> >
> > On Wed, Feb 8, 2017 at 12:40 PM Hans Wennborg 
> > wrote:
> >>
> >> The Win64 lldb build seems broken (at 294367).
> >>
> >> I ran into this when trying to build the weekly snapshot
> >> (http://www.llvm.org/builds/) which includes LLDB these days.
> >>
> >> I suspect this might be related to Kamil's changes a few days ago. I
> >> see Pavel committed something to fix Darwin afterwards.
> >>
> >> Zach, do you know what's going on here? Do we have any buildbot
> >> coverage for this?
> >>
> >>Creating library lib\liblldb.lib and object lib\liblldb.exp
> >> lldbHost.lib(HostInfoWindows.cpp.obj) : error LNK2019: unresolved
> >> external symbo
> >> l "void __cdecl llvm::sys::_mm_mfence(void)"
> >> (?_mm_mfence@sys@llvm@@YAXXZ) refer
> >> enced in function "void __cdecl llvm::call_once >>  >> 713e15728a6adc> >(struct llvm::once_flag &,class
> >>  >> 5728a6adc> &&)"
> >> (??$call_once@V@@$$V@ll
> >>
> >> vm@@YAXAEAUonce_flag@0@$$QEAV dc>@@@Z)
> >> bin\liblldb.dll : fatal error LNK1120: 1 unresolved externals
> >> LINK failed. with 1120
> >
> >
> > ___
> > lldb-dev mailing list
> > lldb-dev@lists.llvm.org
> > http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
> >
> >>
> >
>
___
lldb-dev mailing list
lldb-dev@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev

Re: [lldb-dev] Win64 lldb build broken, llvm::call_once and _mm_mfence

[Hans Wennborg via lldb-dev]

I'm happy as long as it builds :-)

On Wed, Feb 8, 2017 at 2:26 PM, Zachary Turner  wrote:
> Should we do that now, as a way to fix this issue, or should we try to get
> another fix in first so we have more time to think about using std
> call_once?
>
> On Wed, Feb 8, 2017 at 2:19 PM Reid Kleckner  wrote:
>>
>> I think we can. MSVC's std::once_flag default constructor is constexpr
>> now. It still generates dynamic initialization code if you use it as a
>> static local, but MSVC defaults to using thread safe static initialization,
>> so that isn't a problem unless you disable it, which we don't. We disable it
>> in compiler-rt (/Zc:threadSafeInit-), but that doesn't use this code.
>>
>> On Wed, Feb 8, 2017 at 1:18 PM, Zachary Turner  wrote:
>>>
>>> Is this the right review?  https://reviews.llvm.org/D5922
>>>
>>> Being that this was over 2 years ago, I suspect it was when we were
>>> supporting MSVC2012 and 2013.  Now that we're requiring MSVC2015, is it time
>>> to reconsider? I don't see any links to an MS Connect issue, so I don't know
>>> what the original bug was to know if it has been fixed.
>>>
>>>
>>> On Wed, Feb 8, 2017 at 1:03 PM Reid Kleckner  wrote:

 It's a sad story. Read the comments and the review threads. It's
 hilarious.

 On Wed, Feb 8, 2017 at 1:00 PM, Zachary Turner via lldb-dev
  wrote:
>
> Why doesn't llvm::call_once() just use std::call_once on Windows?
>
> On Wed, Feb 8, 2017 at 12:40 PM Hans Wennborg 
> wrote:
>>
>> The Win64 lldb build seems broken (at 294367).
>>
>> I ran into this when trying to build the weekly snapshot
>> (http://www.llvm.org/builds/) which includes LLDB these days.
>>
>> I suspect this might be related to Kamil's changes a few days ago. I
>> see Pavel committed something to fix Darwin afterwards.
>>
>> Zach, do you know what's going on here? Do we have any buildbot
>> coverage for this?
>>
>>Creating library lib\liblldb.lib and object lib\liblldb.exp
>> lldbHost.lib(HostInfoWindows.cpp.obj) : error LNK2019: unresolved
>> external symbo
>> l "void __cdecl llvm::sys::_mm_mfence(void)"
>> (?_mm_mfence@sys@llvm@@YAXXZ) refer
>> enced in function "void __cdecl llvm::call_once> > 713e15728a6adc> >(struct llvm::once_flag &,class
>> > 5728a6adc> &&)"
>> (??$call_once@V@@$$V@ll
>>
>> vm@@YAXAEAUonce_flag@0@$$QEAV@@@Z)
>> bin\liblldb.dll : fatal error LNK1120: 1 unresolved externals
>> LINK failed. with 1120
>
>
> ___
> lldb-dev mailing list
> lldb-dev@lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
>
>>
>
___
lldb-dev mailing list
lldb-dev@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev

Re: [lldb-dev] Win64 lldb build broken, llvm::call_once and _mm_mfence

[Zachary Turner via lldb-dev]

Should we do that now, as a way to fix this issue, or should we try to get
another fix in first so we have more time to think about using std
call_once?
On Wed, Feb 8, 2017 at 2:19 PM Reid Kleckner  wrote:

> I think we can. MSVC's std::once_flag default constructor is constexpr
> now. It still generates dynamic initialization code if you use it as a
> static local, but MSVC defaults to using thread safe static initialization,
> so that isn't a problem unless you disable it, which we don't. We disable
> it in compiler-rt (/Zc:threadSafeInit-), but that doesn't use this code.
>
> On Wed, Feb 8, 2017 at 1:18 PM, Zachary Turner  wrote:
>
> Is this the right review?  https://reviews.llvm.org/D5922
>
> Being that this was over 2 years ago, I suspect it was when we were
> supporting MSVC2012 and 2013.  Now that we're requiring MSVC2015, is it
> time to reconsider? I don't see any links to an MS Connect issue, so I
> don't know what the original bug was to know if it has been fixed.
>
>
> On Wed, Feb 8, 2017 at 1:03 PM Reid Kleckner  wrote:
>
> It's a sad story. Read the comments and the review threads. It's hilarious.
>
> On Wed, Feb 8, 2017 at 1:00 PM, Zachary Turner via lldb-dev <
> lldb-dev@lists.llvm.org> wrote:
>
> Why doesn't llvm::call_once() just use std::call_once on Windows?
>
> On Wed, Feb 8, 2017 at 12:40 PM Hans Wennborg  wrote:
>
> The Win64 lldb build seems broken (at 294367).
>
> I ran into this when trying to build the weekly snapshot
> (http://www.llvm.org/builds/) which includes LLDB these days.
>
> I suspect this might be related to Kamil's changes a few days ago. I
> see Pavel committed something to fix Darwin afterwards.
>
> Zach, do you know what's going on here? Do we have any buildbot
> coverage for this?
>
>Creating library lib\liblldb.lib and object lib\liblldb.exp
> lldbHost.lib(HostInfoWindows.cpp.obj) : error LNK2019: unresolved external
> symbo
> l "void __cdecl llvm::sys::_mm_mfence(void)" (?_mm_mfence@sys@llvm@@YAXXZ)
> refer
> enced in function "void __cdecl llvm::call_once  713e15728a6adc> >(struct llvm::once_flag &,class
>  5728a6adc> &&)" (??$call_once@V
> @@$$V@ll
> vm@@YAXAEAUonce_flag@0
> @$$QEAV@@@Z)
> bin\liblldb.dll : fatal error LNK1120: 1 unresolved externals
> LINK failed. with 1120
>
>
> ___
> lldb-dev mailing list
> lldb-dev@lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
>
>
>
___
lldb-dev mailing list
lldb-dev@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev

Re: [lldb-dev] Win64 lldb build broken, llvm::call_once and _mm_mfence

[Reid Kleckner via lldb-dev]

I think we can. MSVC's std::once_flag default constructor is constexpr now.
It still generates dynamic initialization code if you use it as a static
local, but MSVC defaults to using thread safe static initialization, so
that isn't a problem unless you disable it, which we don't. We disable it
in compiler-rt (/Zc:threadSafeInit-), but that doesn't use this code.

On Wed, Feb 8, 2017 at 1:18 PM, Zachary Turner  wrote:

> Is this the right review?  https://reviews.llvm.org/D5922
>
> Being that this was over 2 years ago, I suspect it was when we were
> supporting MSVC2012 and 2013.  Now that we're requiring MSVC2015, is it
> time to reconsider? I don't see any links to an MS Connect issue, so I
> don't know what the original bug was to know if it has been fixed.
>
>
> On Wed, Feb 8, 2017 at 1:03 PM Reid Kleckner  wrote:
>
>> It's a sad story. Read the comments and the review threads. It's
>> hilarious.
>>
>> On Wed, Feb 8, 2017 at 1:00 PM, Zachary Turner via lldb-dev <
>> lldb-dev@lists.llvm.org> wrote:
>>
>> Why doesn't llvm::call_once() just use std::call_once on Windows?
>>
>> On Wed, Feb 8, 2017 at 12:40 PM Hans Wennborg  wrote:
>>
>> The Win64 lldb build seems broken (at 294367).
>>
>> I ran into this when trying to build the weekly snapshot
>> (http://www.llvm.org/builds/) which includes LLDB these days.
>>
>> I suspect this might be related to Kamil's changes a few days ago. I
>> see Pavel committed something to fix Darwin afterwards.
>>
>> Zach, do you know what's going on here? Do we have any buildbot
>> coverage for this?
>>
>>Creating library lib\liblldb.lib and object lib\liblldb.exp
>> lldbHost.lib(HostInfoWindows.cpp.obj) : error LNK2019: unresolved
>> external symbo
>> l "void __cdecl llvm::sys::_mm_mfence(void)" (?_mm_mfence@sys@llvm@@YAXXZ)
>> refer
>> enced in function "void __cdecl llvm::call_once> > 713e15728a6adc> >(struct llvm::once_flag &,class > e212a11f7f891e804e713e1
>> 5728a6adc> &&)" (??$call_once@V> dc>@@$$V@ll
>> vm@@YAXAEAUonce_flag@0@$$QEAV> dc>@@@Z)
>> bin\liblldb.dll : fatal error LNK1120: 1 unresolved externals
>> LINK failed. with 1120
>>
>>
>> ___
>> lldb-dev mailing list
>> lldb-dev@lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
>>
>>
___
lldb-dev mailing list
lldb-dev@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev

Re: [lldb-dev] Win64 lldb build broken, llvm::call_once and _mm_mfence

[Hans Wennborg via lldb-dev]

I only ran into problems on Win64. I guess your bot is doing a 32-bit build.

On Wed, Feb 8, 2017 at 1:41 PM, Pavel Labath  wrote:
> My fix was just correcting places Kamil forgot to update (or updated
> over-excessively). It does not touch the root problem.
>
> That said, our windows bot
>  is building
> lldb with vs2015. It does not seem to have a problem with this.
>
> On 8 February 2017 at 12:40, Hans Wennborg  wrote:
>> The Win64 lldb build seems broken (at 294367).
>>
>> I ran into this when trying to build the weekly snapshot
>> (http://www.llvm.org/builds/) which includes LLDB these days.
>>
>> I suspect this might be related to Kamil's changes a few days ago. I
>> see Pavel committed something to fix Darwin afterwards.
>>
>> Zach, do you know what's going on here? Do we have any buildbot
>> coverage for this?
>>
>>Creating library lib\liblldb.lib and object lib\liblldb.exp
>> lldbHost.lib(HostInfoWindows.cpp.obj) : error LNK2019: unresolved external 
>> symbo
>> l "void __cdecl llvm::sys::_mm_mfence(void)" (?_mm_mfence@sys@llvm@@YAXXZ) 
>> refer
>> enced in function "void __cdecl llvm::call_once> > 713e15728a6adc> >(struct llvm::once_flag &,class 
>> > 5728a6adc> &&)" 
>> (??$call_once@V@@$$V@ll
>> vm@@YAXAEAUonce_flag@0@$$QEAV@@@Z)
>> bin\liblldb.dll : fatal error LNK1120: 1 unresolved externals
>> LINK failed. with 1120
___
lldb-dev mailing list
lldb-dev@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev

Re: [lldb-dev] Win64 lldb build broken, llvm::call_once and _mm_mfence

[Kamil Rytarowski via lldb-dev]

On 08.02.2017 22:41, Pavel Labath wrote:
> My fix was just correcting places Kamil forgot to update (or updated
> over-excessively). It does not touch the root problem.
> 
> That said, our windows bot
>  is building
> lldb with vs2015. It does not seem to have a problem with this.
> 

Thank you for fixing it.

It was forgotten - I wanted to use consistently llvm:: namespace for
these functions across the LLDB codebase, especially since duplicated
code can be refactored to be shared and it would silently break in the
std:: version.



signature.asc
Description: OpenPGP digital signature
___
lldb-dev mailing list
lldb-dev@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev

Re: [lldb-dev] Win64 lldb build broken, llvm::call_once and _mm_mfence

[Pavel Labath via lldb-dev]

My fix was just correcting places Kamil forgot to update (or updated
over-excessively). It does not touch the root problem.

That said, our windows bot
 is building
lldb with vs2015. It does not seem to have a problem with this.

On 8 February 2017 at 12:40, Hans Wennborg  wrote:
> The Win64 lldb build seems broken (at 294367).
>
> I ran into this when trying to build the weekly snapshot
> (http://www.llvm.org/builds/) which includes LLDB these days.
>
> I suspect this might be related to Kamil's changes a few days ago. I
> see Pavel committed something to fix Darwin afterwards.
>
> Zach, do you know what's going on here? Do we have any buildbot
> coverage for this?
>
>Creating library lib\liblldb.lib and object lib\liblldb.exp
> lldbHost.lib(HostInfoWindows.cpp.obj) : error LNK2019: unresolved external 
> symbo
> l "void __cdecl llvm::sys::_mm_mfence(void)" (?_mm_mfence@sys@llvm@@YAXXZ) 
> refer
> enced in function "void __cdecl llvm::call_once  713e15728a6adc> >(struct llvm::once_flag &,class 
>  5728a6adc> &&)" 
> (??$call_once@V@@$$V@ll
> vm@@YAXAEAUonce_flag@0@$$QEAV@@@Z)
> bin\liblldb.dll : fatal error LNK1120: 1 unresolved externals
> LINK failed. with 1120
___
lldb-dev mailing list
lldb-dev@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev

Re: [lldb-dev] Win64 lldb build broken, llvm::call_once and _mm_mfence

[Zachary Turner via lldb-dev]

Is this the right review?  https://reviews.llvm.org/D5922

Being that this was over 2 years ago, I suspect it was when we were
supporting MSVC2012 and 2013.  Now that we're requiring MSVC2015, is it
time to reconsider? I don't see any links to an MS Connect issue, so I
don't know what the original bug was to know if it has been fixed.

On Wed, Feb 8, 2017 at 1:03 PM Reid Kleckner  wrote:

> It's a sad story. Read the comments and the review threads. It's hilarious.
>
> On Wed, Feb 8, 2017 at 1:00 PM, Zachary Turner via lldb-dev <
> lldb-dev@lists.llvm.org> wrote:
>
> Why doesn't llvm::call_once() just use std::call_once on Windows?
>
> On Wed, Feb 8, 2017 at 12:40 PM Hans Wennborg  wrote:
>
> The Win64 lldb build seems broken (at 294367).
>
> I ran into this when trying to build the weekly snapshot
> (http://www.llvm.org/builds/) which includes LLDB these days.
>
> I suspect this might be related to Kamil's changes a few days ago. I
> see Pavel committed something to fix Darwin afterwards.
>
> Zach, do you know what's going on here? Do we have any buildbot
> coverage for this?
>
>Creating library lib\liblldb.lib and object lib\liblldb.exp
> lldbHost.lib(HostInfoWindows.cpp.obj) : error LNK2019: unresolved external
> symbo
> l "void __cdecl llvm::sys::_mm_mfence(void)" (?_mm_mfence@sys@llvm@@YAXXZ)
> refer
> enced in function "void __cdecl llvm::call_once  713e15728a6adc> >(struct llvm::once_flag &,class
>  5728a6adc> &&)" (??$call_once@V
> @@$$V@ll
> vm@@YAXAEAUonce_flag@0
> @$$QEAV@@@Z)
> bin\liblldb.dll : fatal error LNK1120: 1 unresolved externals
> LINK failed. with 1120
>
>
> ___
> lldb-dev mailing list
> lldb-dev@lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
>
>
___
lldb-dev mailing list
lldb-dev@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev

Re: [lldb-dev] Win64 lldb build broken, llvm::call_once and _mm_mfence

[Kamil Rytarowski via lldb-dev]

On 08.02.2017 22:14, Kamil Rytarowski wrote:
> // std::call_once from libc++ is used on all Unix platforms. Other
> // implementations like libstdc++ are known to have problems on NetBSD,
> // OpenBSD and PowerPC.
> #if defined(LLVM_ON_UNIX) && (defined(_LIBCPP_VERSION) ||
>   \
> !(defined(__NetBSD__) || defined(__OpenBSD__) || defined(__ppc__)))
> #define LLVM_THREADING_USE_STD_CALL_ONCE 1
> #else
> #define LLVM_THREADING_USE_STD_CALL_ONCE 0
> #endif
> 
> This check defined(LLVM_ON_UNIX) looks wrong it assumes that Windows
> needs call_once walkaround.
> 

Ah not, it's OK.

If the file is windows-only it can be switched back to std:: version.



signature.asc
Description: OpenPGP digital signature
___
lldb-dev mailing list
lldb-dev@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev

Re: [lldb-dev] Win64 lldb build broken, llvm::call_once and _mm_mfence

[Kamil Rytarowski via lldb-dev]

It looks fine:

diff --git a/source/Host/windows/HostInfoWindows.cpp
b/source/Host/windows/HostInfoWindows.cpp
index a965ec0ea..5b38e6021 100644
--- a/source/Host/windows/HostInfoWindows.cpp
+++ b/source/Host/windows/HostInfoWindows.cpp
@@ -18,6 +18,7 @@
 #include "llvm/Support/ConvertUTF.h"
 #include "llvm/Support/FileSystem.h"
 #include "llvm/Support/Path.h"
+#include "llvm/Support/Threading.h"
 #include "llvm/Support/raw_ostream.h"

 using namespace lldb_private;
@@ -90,8 +91,8 @@ bool HostInfoWindows::GetHostname(std::string ) {
 }

 FileSpec HostInfoWindows::GetProgramFileSpec() {
-  static std::once_flag g_once_flag;
-  std::call_once(g_once_flag, []() {
+  static llvm::once_flag g_once_flag;
+  llvm::call_once(g_once_flag, []() {
 std::vector buffer(PATH_MAX);
 ::GetModuleFileNameW(NULL, buffer.data(), buffer.size());
 std::string path;

and this looks suspicious

// std::call_once from libc++ is used on all Unix platforms. Other
// implementations like libstdc++ are known to have problems on NetBSD,
// OpenBSD and PowerPC.
#if defined(LLVM_ON_UNIX) && (defined(_LIBCPP_VERSION) ||
  \
!(defined(__NetBSD__) || defined(__OpenBSD__) || defined(__ppc__)))
#define LLVM_THREADING_USE_STD_CALL_ONCE 1
#else
#define LLVM_THREADING_USE_STD_CALL_ONCE 0
#endif

This check defined(LLVM_ON_UNIX) looks wrong it assumes that Windows
needs call_once walkaround.

On 08.02.2017 22:00, Zachary Turner wrote:
> Why doesn't llvm::call_once() just use std::call_once on Windows?
> 
> On Wed, Feb 8, 2017 at 12:40 PM Hans Wennborg  > wrote:
> 
> The Win64 lldb build seems broken (at 294367).
> 
> I ran into this when trying to build the weekly snapshot
> (http://www.llvm.org/builds/) which includes LLDB these days.
> 
> I suspect this might be related to Kamil's changes a few days ago. I
> see Pavel committed something to fix Darwin afterwards.
> 
> Zach, do you know what's going on here? Do we have any buildbot
> coverage for this?
> 
>Creating library lib\liblldb.lib and object lib\liblldb.exp
> lldbHost.lib(HostInfoWindows.cpp.obj) : error LNK2019: unresolved
> external symbo
> l "void __cdecl llvm::sys::_mm_mfence(void)"
> (?_mm_mfence@sys@llvm@@YAXXZ) refer
> enced in function "void __cdecl llvm::call_once  713e15728a6adc> >(struct llvm::once_flag &,class
>  5728a6adc> &&)"
> (??$call_once@V@@$$V@ll
> 
> vm@@YAXAEAUonce_flag@0@$$QEAV@@@Z)
> bin\liblldb.dll : fatal error LNK1120: 1 unresolved externals
> LINK failed. with 1120
> 




signature.asc
Description: OpenPGP digital signature
___
lldb-dev mailing list
lldb-dev@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev

Re: [lldb-dev] Win64 lldb build broken, llvm::call_once and _mm_mfence

[Reid Kleckner via lldb-dev]

It's a sad story. Read the comments and the review threads. It's hilarious.

On Wed, Feb 8, 2017 at 1:00 PM, Zachary Turner via lldb-dev <
lldb-dev@lists.llvm.org> wrote:

> Why doesn't llvm::call_once() just use std::call_once on Windows?
>
> On Wed, Feb 8, 2017 at 12:40 PM Hans Wennborg  wrote:
>
>> The Win64 lldb build seems broken (at 294367).
>>
>> I ran into this when trying to build the weekly snapshot
>> (http://www.llvm.org/builds/) which includes LLDB these days.
>>
>> I suspect this might be related to Kamil's changes a few days ago. I
>> see Pavel committed something to fix Darwin afterwards.
>>
>> Zach, do you know what's going on here? Do we have any buildbot
>> coverage for this?
>>
>>Creating library lib\liblldb.lib and object lib\liblldb.exp
>> lldbHost.lib(HostInfoWindows.cpp.obj) : error LNK2019: unresolved
>> external symbo
>> l "void __cdecl llvm::sys::_mm_mfence(void)" (?_mm_mfence@sys@llvm@@YAXXZ)
>> refer
>> enced in function "void __cdecl llvm::call_once> > 713e15728a6adc> >(struct llvm::once_flag &,class > e212a11f7f891e804e713e1
>> 5728a6adc> &&)" (??$call_once@V> dc>@@$$V@ll
>> vm@@YAXAEAUonce_flag@0@$$QEAV> dc>@@@Z)
>> bin\liblldb.dll : fatal error LNK1120: 1 unresolved externals
>> LINK failed. with 1120
>>
>
> ___
> lldb-dev mailing list
> lldb-dev@lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
>
>
___
lldb-dev mailing list
lldb-dev@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev

Re: [lldb-dev] Win64 lldb build broken, llvm::call_once and _mm_mfence

[Zachary Turner via lldb-dev]

Why doesn't llvm::call_once() just use std::call_once on Windows?

On Wed, Feb 8, 2017 at 12:40 PM Hans Wennborg  wrote:

> The Win64 lldb build seems broken (at 294367).
>
> I ran into this when trying to build the weekly snapshot
> (http://www.llvm.org/builds/) which includes LLDB these days.
>
> I suspect this might be related to Kamil's changes a few days ago. I
> see Pavel committed something to fix Darwin afterwards.
>
> Zach, do you know what's going on here? Do we have any buildbot
> coverage for this?
>
>Creating library lib\liblldb.lib and object lib\liblldb.exp
> lldbHost.lib(HostInfoWindows.cpp.obj) : error LNK2019: unresolved external
> symbo
> l "void __cdecl llvm::sys::_mm_mfence(void)" (?_mm_mfence@sys@llvm@@YAXXZ)
> refer
> enced in function "void __cdecl llvm::call_once  713e15728a6adc> >(struct llvm::once_flag &,class
>  5728a6adc> &&)" (??$call_once@V
> @@$$V@ll
> vm@@YAXAEAUonce_flag@0
> @$$QEAV@@@Z)
> bin\liblldb.dll : fatal error LNK1120: 1 unresolved externals
> LINK failed. with 1120
>
___
lldb-dev mailing list
lldb-dev@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev

Re: [lldb-dev] Win64 lldb build broken, llvm::call_once and _mm_mfence

[Reid Kleckner via lldb-dev]

Windows.h appears to `#define MemoryFence _mm_fence`. We should probably
undef MemoryFence in llvm/Support/Atomic.h.

On Wed, Feb 8, 2017 at 12:40 PM, Hans Wennborg via lldb-dev <
lldb-dev@lists.llvm.org> wrote:

> The Win64 lldb build seems broken (at 294367).
>
> I ran into this when trying to build the weekly snapshot
> (http://www.llvm.org/builds/) which includes LLDB these days.
>
> I suspect this might be related to Kamil's changes a few days ago. I
> see Pavel committed something to fix Darwin afterwards.
>
> Zach, do you know what's going on here? Do we have any buildbot
> coverage for this?
>
>Creating library lib\liblldb.lib and object lib\liblldb.exp
> lldbHost.lib(HostInfoWindows.cpp.obj) : error LNK2019: unresolved
> external symbo
> l "void __cdecl llvm::sys::_mm_mfence(void)" (?_mm_mfence@sys@llvm@@YAXXZ)
> refer
> enced in function "void __cdecl llvm::call_once  713e15728a6adc> >(struct llvm::once_flag &,class  e212a11f7f891e804e713e1
> 5728a6adc> &&)" (??$call_once@V dc>@@$$V@ll
> vm@@YAXAEAUonce_flag@0@$$QEAV dc>@@@Z)
> bin\liblldb.dll : fatal error LNK1120: 1 unresolved externals
> LINK failed. with 1120
> ___
> lldb-dev mailing list
> lldb-dev@lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
>
___
lldb-dev mailing list
lldb-dev@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev

[lldb-dev] Win64 lldb build broken, llvm::call_once and _mm_mfence

[Hans Wennborg via lldb-dev]

The Win64 lldb build seems broken (at 294367).

I ran into this when trying to build the weekly snapshot
(http://www.llvm.org/builds/) which includes LLDB these days.

I suspect this might be related to Kamil's changes a few days ago. I
see Pavel committed something to fix Darwin afterwards.

Zach, do you know what's going on here? Do we have any buildbot
coverage for this?

   Creating library lib\liblldb.lib and object lib\liblldb.exp
lldbHost.lib(HostInfoWindows.cpp.obj) : error LNK2019: unresolved external symbo
l "void __cdecl llvm::sys::_mm_mfence(void)" (?_mm_mfence@sys@llvm@@YAXXZ) refer
enced in function "void __cdecl llvm::call_once >(struct llvm::once_flag &,class  &&)" (??$call_once@V@@$$V@ll
vm@@YAXAEAUonce_flag@0@$$QEAV@@@Z)
bin\liblldb.dll : fatal error LNK1120: 1 unresolved externals
LINK failed. with 1120
___
lldb-dev mailing list
lldb-dev@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev