[llvm-branch-commits] [BOLT][BAT] Support multi-way split functions (PR #87123)

[Davide Italiano via llvm-branch-commits]

https://github.com/dcci approved this pull request.

LG with the question answered/addressed.

https://github.com/llvm/llvm-project/pull/87123
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [BOLT][BAT] Support multi-way split functions (PR #87123)

[Davide Italiano via llvm-branch-commits]

@@ -197,8 +197,10 @@ void BoltAddressTranslation::writeMaps(std::map ,
 ? SecondaryEntryPointsMap[Address].size()
 : 0;
 if (Cold) {
-  size_t HotIndex =
-  std::distance(ColdPartSource.begin(), ColdPartSource.find(Address));
+  // `Maps` is keyed by output addresses.

dcci wrote:

This comment seems self-explanatory. Maybe remove it?

https://github.com/llvm/llvm-project/pull/87123
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [BOLT][BAT] Support multi-way split functions (PR #87123)

[Amir Ayupov via llvm-branch-commits]

https://github.com/aaupov edited https://github.com/llvm/llvm-project/pull/87123
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [BOLT][BAT] Support multi-way split functions (PR #87123)

[Amir Ayupov via llvm-branch-commits]

https://github.com/aaupov created 
https://github.com/llvm/llvm-project/pull/87123

BAT writeMaps encoded the assumption that functions are only split into
two fragments (hot and cold). However, BOLT supports splitting into
arbitrary number of fragments. Relax that assumption and look up primary
(hot) fragment explicitly.

Test Plan: Updated bolt/test/X86/yaml-secondary-entry-discriminator.s



___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits