[llvm-branch-commits] [clang][CodeGen] Remove SimplifyCFGPass preceding RemoveTrapsPass (PR #84852)

2024-03-11 Thread Vitaly Buka via llvm-branch-commits 

https://github.com/vitalybuka created 
https://github.com/llvm/llvm-project/pull/84852

There is no performance difference after switching to
`llvm.experimental.hot`.



___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang][CodeGen] Remove SimplifyCFGPass preceding RemoveTrapsPass (PR #84852)

2024-03-11 Thread via llvm-branch-commits 

llvmbot wrote:




@llvm/pr-subscribers-clang

Author: Vitaly Buka (vitalybuka)


Changes

There is no performance difference after switching to
`llvm.experimental.hot`.


---
Full diff: https://github.com/llvm/llvm-project/pull/84852.diff


1 Files Affected:

- (modified) clang/lib/CodeGen/BackendUtil.cpp (-6) 


``diff
diff --git a/clang/lib/CodeGen/BackendUtil.cpp 
b/clang/lib/CodeGen/BackendUtil.cpp
index 7e53469a48d42c..7eab1c4ed44b89 100644
--- a/clang/lib/CodeGen/BackendUtil.cpp
+++ b/clang/lib/CodeGen/BackendUtil.cpp
@@ -84,7 +84,6 @@
 #include "llvm/Transforms/Scalar/EarlyCSE.h"
 #include "llvm/Transforms/Scalar/GVN.h"
 #include "llvm/Transforms/Scalar/JumpThreading.h"
-#include "llvm/Transforms/Scalar/SimplifyCFG.h"
 #include "llvm/Transforms/Utils/Debugify.h"
 #include "llvm/Transforms/Utils/EntryExitInstrumenter.h"
 #include "llvm/Transforms/Utils/ModuleUtils.h"
@@ -757,11 +756,6 @@ static void addSanitizers(const Triple &TargetTriple,
 // from `buildInlinerPipeline`, which called after profile matching.
 PB.registerScalarOptimizerLateEPCallback(
 [](FunctionPassManager &FPM, OptimizationLevel Level) {
-  // RemoveTrapsPass expects trap blocks preceded by conditional
-  // branches, which usually is not the case without SimplifyCFG.
-  // TODO: Remove `SimplifyCFGPass` after switching to dedicated
-  // intrinsic.
-  FPM.addPass(SimplifyCFGPass());
   FPM.addPass(RemoveTrapsPass());
 });
   }

``




https://github.com/llvm/llvm-project/pull/84852
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang][CodeGen] Remove SimplifyCFGPass preceding RemoveTrapsPass (PR #84852)

2024-03-11 Thread Vitaly Buka via llvm-branch-commits 

https://github.com/vitalybuka updated 
https://github.com/llvm/llvm-project/pull/84852


___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang][CodeGen] Remove SimplifyCFGPass preceding RemoveTrapsPass (PR #84852)

2024-03-11 Thread Vitaly Buka via llvm-branch-commits 

https://github.com/vitalybuka updated 
https://github.com/llvm/llvm-project/pull/84852


___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang][CodeGen] Remove SimplifyCFGPass preceding RemoveTrapsPass (PR #84852)

2024-03-11 Thread Arthur Eubanks via llvm-branch-commits 

https://github.com/aeubanks approved this pull request.


https://github.com/llvm/llvm-project/pull/84852
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang][CodeGen] Remove SimplifyCFGPass preceding RemoveTrapsPass (PR #84852)

2024-03-12 Thread Vitaly Buka via llvm-branch-commits 

https://github.com/vitalybuka updated 
https://github.com/llvm/llvm-project/pull/84852


___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang][CodeGen] Remove SimplifyCFGPass preceding RemoveTrapsPass (PR #84852)

2024-03-12 Thread Vitaly Buka via llvm-branch-commits 

https://github.com/vitalybuka updated 
https://github.com/llvm/llvm-project/pull/84852


___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang][CodeGen] Remove SimplifyCFGPass preceding RemoveTrapsPass (PR #84852)

2024-04-04 Thread Vitaly Buka via llvm-branch-commits 

https://github.com/vitalybuka updated 
https://github.com/llvm/llvm-project/pull/84852


___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang][CodeGen] Remove SimplifyCFGPass preceding RemoveTrapsPass (PR #84852)

2024-04-04 Thread Vitaly Buka via llvm-branch-commits 

https://github.com/vitalybuka updated 
https://github.com/llvm/llvm-project/pull/84852


___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits