[llvm-branch-commits] [compiler-rt] [llvm] [clang] [clang-tools-extra] [sanitizer_symbolizer] Add end to end test for symbolizer markup. (PR #77702)

[Andres Villegas via llvm-branch-commits]

=?utf-8?q?Andrés?= Villegas 
Message-ID:
In-Reply-To: 



@@ -0,0 +1,33 @@
+// COM: End to end test for the sanitizer symbolizer markup. Since it uses 
debug info

avillega wrote:

Yes, COM is for comments 
(https://llvm.org/docs/CommandGuide/FileCheck.html#the-com-directive) I am 
probably being too cautious here and not using COM maight be fine since the 
comment doesn't have anything like look like a directive.

https://github.com/llvm/llvm-project/pull/77702
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [compiler-rt] [llvm] [clang] [clang-tools-extra] [sanitizer_symbolizer] Add end to end test for symbolizer markup. (PR #77702)

[Paul Kirth via llvm-branch-commits]

=?utf-8?q?Andrés?= Villegas 
Message-ID:
In-Reply-To: 



@@ -0,0 +1,57 @@
+// REQUIRES: linux
+// RUN: %clangxx_tsan %s -Wl,--build-id=0x12345678 -O1 -o %t.main
+// RUN: mkdir -p %t/.build-id/12
+// RUN: cp %t.main %t/.build-id/12/345678.debug
+// RUN: %env_tsan_opts=enable_symbolizer_markup=1 %deflake %run %t.main 
>%t/sanitizer.out
+// RUN: llvm-symbolizer --filter-markup --debug-file-directory=%t < 
%t/sanitizer.out | FileCheck %s --dump-input=always
+
+#include "test.h"
+
+int Global;
+
+void __attribute__((noinline)) foo1() { Global = 42; }

ilovepi wrote:

why mix `[[gnu::noinline]]` and `__attribute__((noinline))`? I expect these are 
copied from existing test files, but I think you should be consistent in this 
patch. I think we prefer cpp style attributes when possible.

https://github.com/llvm/llvm-project/pull/77702
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits