[llvm-branch-commits] [flang] [Flang][OpenMP] NFC: Remove unused argument for omp.target lowering (PR #97564)
https://github.com/skatrak created https://github.com/llvm/llvm-project/pull/97564 This patch removes the `outerCombined` argument from `genTargetOp()` and the `processReduction` argument from `genTargetClauses()`, as they aren't used. >From 83d53c3299de2e7b9874ee0083d180674ab51c30 Mon Sep 17 00:00:00 2001 From: Sergio Afonso Date: Wed, 3 Jul 2024 11:59:23 +0100 Subject: [PATCH] [Flang][OpenMP] NFC: Remove unused argument for omp.target lowering This patch removes the `outerCombined` argument from `genTargetOp()` and the `processReduction` argument from `genTargetClauses()`, as they aren't used. --- flang/lib/Lower/OpenMP/OpenMP.cpp | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/flang/lib/Lower/OpenMP/OpenMP.cpp b/flang/lib/Lower/OpenMP/OpenMP.cpp index d8679fb693659..0d456dde630e2 100644 --- a/flang/lib/Lower/OpenMP/OpenMP.cpp +++ b/flang/lib/Lower/OpenMP/OpenMP.cpp @@ -1134,7 +1134,7 @@ static void genSingleClauses(lower::AbstractConverter &converter, static void genTargetClauses( lower::AbstractConverter &converter, semantics::SemanticsContext &semaCtx, lower::StatementContext &stmtCtx, const List &clauses, -mlir::Location loc, bool processHostOnlyClauses, bool processReduction, +mlir::Location loc, bool processHostOnlyClauses, mlir::omp::TargetClauseOps &clauseOps, llvm::SmallVectorImpl &mapSyms, llvm::SmallVectorImpl &mapLocs, @@ -1676,7 +1676,7 @@ static mlir::omp::TargetOp genTargetOp(lower::AbstractConverter &converter, lower::SymMap &symTable, semantics::SemanticsContext &semaCtx, lower::pft::Evaluation &eval, mlir::Location loc, const ConstructQueue &queue, -ConstructQueue::iterator item, bool outerCombined = false) { +ConstructQueue::iterator item) { fir::FirOpBuilder &firOpBuilder = converter.getFirOpBuilder(); lower::StatementContext stmtCtx; @@ -1690,10 +1690,9 @@ genTargetOp(lower::AbstractConverter &converter, lower::SymMap &symTable, llvm::SmallVector mapLocs, devicePtrLocs, deviceAddrLocs; llvm::SmallVector mapTypes, devicePtrTypes, deviceAddrTypes; genTargetClauses(converter, semaCtx, stmtCtx, item->clauses, loc, - processHostOnlyClauses, /*processReduction=*/outerCombined, - clauseOps, mapSyms, mapLocs, mapTypes, deviceAddrSyms, - deviceAddrLocs, deviceAddrTypes, devicePtrSyms, - devicePtrLocs, devicePtrTypes); + processHostOnlyClauses, clauseOps, mapSyms, mapLocs, + mapTypes, deviceAddrSyms, deviceAddrLocs, deviceAddrTypes, + devicePtrSyms, devicePtrLocs, devicePtrTypes); llvm::SmallVector privateSyms; DataSharingProcessor dsp(converter, semaCtx, item->clauses, eval, @@ -2099,8 +2098,7 @@ static void genOMPDispatch(lower::AbstractConverter &converter, genSingleOp(converter, symTable, semaCtx, eval, loc, queue, item); break; case llvm::omp::Directive::OMPD_target: -genTargetOp(converter, symTable, semaCtx, eval, loc, queue, item, -/*outerCombined=*/false); +genTargetOp(converter, symTable, semaCtx, eval, loc, queue, item); break; case llvm::omp::Directive::OMPD_target_data: genTargetDataOp(converter, symTable, semaCtx, eval, loc, queue, item); ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
[llvm-branch-commits] [flang] [Flang][OpenMP] NFC: Remove unused argument for omp.target lowering (PR #97564)
llvmbot wrote: @llvm/pr-subscribers-flang-fir-hlfir Author: Sergio Afonso (skatrak) Changes This patch removes the `outerCombined` argument from `genTargetOp()` and the `processReduction` argument from `genTargetClauses()`, as they aren't used. --- Full diff: https://github.com/llvm/llvm-project/pull/97564.diff 1 Files Affected: - (modified) flang/lib/Lower/OpenMP/OpenMP.cpp (+6-8) ``diff diff --git a/flang/lib/Lower/OpenMP/OpenMP.cpp b/flang/lib/Lower/OpenMP/OpenMP.cpp index d8679fb693659..0d456dde630e2 100644 --- a/flang/lib/Lower/OpenMP/OpenMP.cpp +++ b/flang/lib/Lower/OpenMP/OpenMP.cpp @@ -1134,7 +1134,7 @@ static void genSingleClauses(lower::AbstractConverter &converter, static void genTargetClauses( lower::AbstractConverter &converter, semantics::SemanticsContext &semaCtx, lower::StatementContext &stmtCtx, const List &clauses, -mlir::Location loc, bool processHostOnlyClauses, bool processReduction, +mlir::Location loc, bool processHostOnlyClauses, mlir::omp::TargetClauseOps &clauseOps, llvm::SmallVectorImpl &mapSyms, llvm::SmallVectorImpl &mapLocs, @@ -1676,7 +1676,7 @@ static mlir::omp::TargetOp genTargetOp(lower::AbstractConverter &converter, lower::SymMap &symTable, semantics::SemanticsContext &semaCtx, lower::pft::Evaluation &eval, mlir::Location loc, const ConstructQueue &queue, -ConstructQueue::iterator item, bool outerCombined = false) { +ConstructQueue::iterator item) { fir::FirOpBuilder &firOpBuilder = converter.getFirOpBuilder(); lower::StatementContext stmtCtx; @@ -1690,10 +1690,9 @@ genTargetOp(lower::AbstractConverter &converter, lower::SymMap &symTable, llvm::SmallVector mapLocs, devicePtrLocs, deviceAddrLocs; llvm::SmallVector mapTypes, devicePtrTypes, deviceAddrTypes; genTargetClauses(converter, semaCtx, stmtCtx, item->clauses, loc, - processHostOnlyClauses, /*processReduction=*/outerCombined, - clauseOps, mapSyms, mapLocs, mapTypes, deviceAddrSyms, - deviceAddrLocs, deviceAddrTypes, devicePtrSyms, - devicePtrLocs, devicePtrTypes); + processHostOnlyClauses, clauseOps, mapSyms, mapLocs, + mapTypes, deviceAddrSyms, deviceAddrLocs, deviceAddrTypes, + devicePtrSyms, devicePtrLocs, devicePtrTypes); llvm::SmallVector privateSyms; DataSharingProcessor dsp(converter, semaCtx, item->clauses, eval, @@ -2099,8 +2098,7 @@ static void genOMPDispatch(lower::AbstractConverter &converter, genSingleOp(converter, symTable, semaCtx, eval, loc, queue, item); break; case llvm::omp::Directive::OMPD_target: -genTargetOp(converter, symTable, semaCtx, eval, loc, queue, item, -/*outerCombined=*/false); +genTargetOp(converter, symTable, semaCtx, eval, loc, queue, item); break; case llvm::omp::Directive::OMPD_target_data: genTargetDataOp(converter, symTable, semaCtx, eval, loc, queue, item); `` https://github.com/llvm/llvm-project/pull/97564 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
[llvm-branch-commits] [flang] [Flang][OpenMP] NFC: Remove unused argument for omp.target lowering (PR #97564)
https://github.com/kparzysz approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/97564 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
[llvm-branch-commits] [flang] [Flang][OpenMP] NFC: Remove unused argument for omp.target lowering (PR #97564)
https://github.com/mjklemm approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/97564 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits