llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Kruse (Meinersbur)
Changes
Reviewers of #89153 suggested to break up the patch into per-subproject
patches. This is the LLDB part. See #89153 for the entire series and
motivation.
Update the folder titles for targets in the monorepository that have not seen
taken care of for some time. These are the folders that targets are organized
in Visual Studio and XCode (`set_property(TARGET PROPERTY FOLDER
"")`) when using the respective CMake's IDE generator.
* Ensure that every target is in a folder
* Use a folder hierarchy with each LLVM subproject as a top-level folder
* Use consistent folder names between subprojects
* When using target-creating functions from AddLLVM.cmake, automatically
deduce the folder. This reduces the number of
`set_property`/`set_target_property`, but are still necessary when
`add_custom_target`, `add_executable`, `add_library`, etc. are used. A
LLVM_SUBPROJECT_TITLE definition is used for that in each subproject's root
CMakeLists.txt.
---
Full diff: https://github.com/llvm/llvm-project/pull/89748.diff
21 Files Affected:
- (modified) lldb/CMakeLists.txt (+1)
- (modified) lldb/cmake/modules/AddLLDB.cmake (+2-4)
- (modified) lldb/cmake/modules/LLDBConfig.cmake (+1-1)
- (modified) lldb/cmake/modules/LLDBFramework.cmake (+1-1)
- (modified) lldb/cmake/modules/LLDBStandalone.cmake (+2-2)
- (modified) lldb/docs/CMakeLists.txt (+1)
- (modified) lldb/source/API/CMakeLists.txt (-2)
- (modified) lldb/test/API/CMakeLists.txt (+1)
- (modified) lldb/test/CMakeLists.txt (+2-2)
- (modified) lldb/test/Shell/CMakeLists.txt (+1)
- (modified) lldb/test/Unit/CMakeLists.txt (+1)
- (modified) lldb/tools/driver/CMakeLists.txt (-2)
- (modified)
lldb/tools/lldb-fuzzer/lldb-commandinterpreter-fuzzer/CMakeLists.txt (+1)
- (modified) lldb/tools/lldb-fuzzer/lldb-target-fuzzer/CMakeLists.txt (+1)
- (modified) lldb/tools/lldb-server/CMakeLists.txt (-1)
- (modified) lldb/unittests/CMakeLists.txt (+1-1)
- (modified) lldb/unittests/tools/lldb-server/CMakeLists.txt (+1-1)
- (modified) lldb/utils/TableGen/CMakeLists.txt (-1)
- (modified) lldb/utils/lit-cpuid/CMakeLists.txt (+1-1)
- (modified) lldb/utils/lldb-dotest/CMakeLists.txt (+1-1)
- (modified) lldb/utils/lldb-repro/CMakeLists.txt (+1-1)
``diff
diff --git a/lldb/CMakeLists.txt b/lldb/CMakeLists.txt
index 7844d93d78d29..db9e5517e287b 100644
--- a/lldb/CMakeLists.txt
+++ b/lldb/CMakeLists.txt
@@ -1,4 +1,5 @@
cmake_minimum_required(VERSION 3.20.0)
+set(LLVM_SUBPROJECT_TITLE "LLDB")
if(NOT DEFINED LLVM_COMMON_CMAKE_UTILS)
set(LLVM_COMMON_CMAKE_UTILS ${CMAKE_CURRENT_SOURCE_DIR}/../cmake)
diff --git a/lldb/cmake/modules/AddLLDB.cmake b/lldb/cmake/modules/AddLLDB.cmake
index fdc4ee0c05d75..538029037dd46 100644
--- a/lldb/cmake/modules/AddLLDB.cmake
+++ b/lldb/cmake/modules/AddLLDB.cmake
@@ -29,7 +29,6 @@ function(lldb_tablegen)
if(LTG_TARGET)
add_public_tablegen_target(${LTG_TARGET})
-set_target_properties( ${LTG_TARGET} PROPERTIES FOLDER "LLDB tablegenning")
set_property(GLOBAL APPEND PROPERTY LLDB_TABLEGEN_TARGETS ${LTG_TARGET})
endif()
endfunction(lldb_tablegen)
@@ -165,10 +164,10 @@ function(add_lldb_library name)
get_property(parent_dir DIRECTORY PROPERTY PARENT_DIRECTORY)
if(EXISTS ${parent_dir})
get_filename_component(category ${parent_dir} NAME)
- set_target_properties(${name} PROPERTIES FOLDER "lldb
plugins/${category}")
+ set_target_properties(${name} PROPERTIES FOLDER
"LLDB/Plugins/${category}")
endif()
else()
-set_target_properties(${name} PROPERTIES FOLDER "lldb libraries")
+set_target_properties(${name} PROPERTIES FOLDER "LLDB/Libraries")
endif()
# If we want to export all lldb symbols (i.e LLDB_EXPORT_ALL_SYMBOLS=ON), we
@@ -208,7 +207,6 @@ function(add_lldb_executable name)
else()
target_link_libraries(${name} PRIVATE ${ARG_CLANG_LIBS})
endif()
- set_target_properties(${name} PROPERTIES FOLDER "lldb executables")
if (ARG_BUILD_RPATH)
set_target_properties(${name} PROPERTIES BUILD_RPATH "${ARG_BUILD_RPATH}")
diff --git a/lldb/cmake/modules/LLDBConfig.cmake
b/lldb/cmake/modules/LLDBConfig.cmake
index a758261073ac5..13d07a4fabd6d 100644
--- a/lldb/cmake/modules/LLDBConfig.cmake
+++ b/lldb/cmake/modules/LLDBConfig.cmake
@@ -271,7 +271,7 @@ if (NOT LLVM_INSTALL_TOOLCHAIN_ONLY)
)
add_custom_target(lldb-headers)
- set_target_properties(lldb-headers PROPERTIES FOLDER "lldb misc")
+ set_target_properties(lldb-headers PROPERTIES FOLDER "LLDB/Resources")
if (NOT CMAKE_CONFIGURATION_TYPES)
add_llvm_install_targets(install-lldb-headers
diff --git a/lldb/cmake/modules/LLDBFramework.cmake
b/lldb/cmake/modules/LLDBFramework.cmake
index f915839f6b45a..88ea6a568ec4c 100644
--- a/lldb/cmake/modules/LLDBFramework.cmake
+++ b/lldb/cmake/modules/LLDBFramework.cmake
@@ -104,7 +104,7 @@ endforeach()
# Wrap output in a tar</pre></span>
</blockquote><br>
<h3><span class=subject><a href="/llvm-branch-commits@lists.llvm.org/msg20992.html">[llvm-branch-commits] [lldb] [lldb] Revise IDE folder structure (PR #89748)</a></span></h3>
<div class="darkgray font13">
<span class="sender pipe">
<span class=date><a href="/search?l=llvm-branch-commits%40lists.llvm.org&q=date:20240521&o=newest&f=1">2024-05-21</a></span></span>
<span class="sender pipe">
<span class=thead><a href="/search?l=llvm-branch-commits%40lists.llvm.org&q=subject:%22%5C%5Bllvm%5C-branch%5C-commits%5C%5D+%5C%5Blldb%5C%5D+%5C%5Blldb%5C%5D+Revise+IDE+folder+structure+%5C%28PR%09%2389748%5C%29%22&o=newest&f=1">Thread</a></span></span>
<span class=name><a href="/search?l=llvm-branch-commits%40lists.llvm.org&q=from:%22Jonas+Devlieghere+via+llvm%5C-branch%5C-commits%22&o=newest&f=1">Jonas Devlieghere via llvm-branch-commits</a></span>
</div>
<blockquote><span class="msgFragment"><pre>
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/89748
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
</pre></span>
</blockquote><br>
<h3><span class=subject><a href="/llvm-branch-commits@lists.llvm.org/msg21002.html">[llvm-branch-commits] [lldb] [lldb] Revise IDE folder structure (PR #89748)</a></span></h3>
<div class="darkgray font13">
<span class="sender pipe">
<span class=date><a href="/search?l=llvm-branch-commits%40lists.llvm.org&q=date:20240521&o=newest&f=1">2024-05-21</a></span></span>
<span class="sender pipe">
<span class=thead><a href="/search?l=llvm-branch-commits%40lists.llvm.org&q=subject:%22%5C%5Bllvm%5C-branch%5C-commits%5C%5D+%5C%5Blldb%5C%5D+%5C%5Blldb%5C%5D+Revise+IDE+folder+structure+%5C%28PR%09%2389748%5C%29%22&o=newest&f=1">Thread</a></span></span>
<span class=name><a href="/search?l=llvm-branch-commits%40lists.llvm.org&q=from:%22Alex+Langford+via+llvm%5C-branch%5C-commits%22&o=newest&f=1">Alex Langford via llvm-branch-commits</a></span>
</div>
<blockquote><span class="msgFragment"><pre>
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/89748
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
</pre></span>
</blockquote><br>
<h3><span class=subject><a href="/llvm-branch-commits@lists.llvm.org/msg21003.html">[llvm-branch-commits] [lldb] [lldb] Revise IDE folder structure (PR #89748)</a></span></h3>
<div class="darkgray font13">
<span class="sender pipe">
<span class=date><a href="/search?l=llvm-branch-commits%40lists.llvm.org&q=date:20240521&o=newest&f=1">2024-05-21</a></span></span>
<span class="sender pipe">
<span class=thead><a href="/search?l=llvm-branch-commits%40lists.llvm.org&q=subject:%22%5C%5Bllvm%5C-branch%5C-commits%5C%5D+%5C%5Blldb%5C%5D+%5C%5Blldb%5C%5D+Revise+IDE+folder+structure+%5C%28PR%09%2389748%5C%29%22&o=newest&f=1">Thread</a></span></span>
<span class=name><a href="/search?l=llvm-branch-commits%40lists.llvm.org&q=from:%22Med+Ismail+Bennani+via+llvm%5C-branch%5C-commits%22&o=newest&f=1">Med Ismail Bennani via llvm-branch-commits</a></span>
</div>
<blockquote><span class="msgFragment"><pre>
https://github.com/medismailben approved this pull request.
Nice! LGTM!
https://github.com/llvm/llvm-project/pull/89748
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
</pre></span>
</blockquote><br>
<h3><span class=subject><a href="/llvm-branch-commits@lists.llvm.org/msg21017.html">[llvm-branch-commits] [lldb] [lldb] Revise IDE folder structure (PR #89748)</a></span></h3>
<div class="darkgray font13">
<span class="sender pipe">
<span class=date><a href="/search?l=llvm-branch-commits%40lists.llvm.org&q=date:20240521&o=newest&f=1">2024-05-21</a></span></span>
<span class="sender pipe">
<span class=thead><a href="/search?l=llvm-branch-commits%40lists.llvm.org&q=subject:%22%5C%5Bllvm%5C-branch%5C-commits%5C%5D+%5C%5Blldb%5C%5D+%5C%5Blldb%5C%5D+Revise+IDE+folder+structure+%5C%28PR%09%2389748%5C%29%22&o=newest&f=1">Thread</a></span></span>
<span class=name><a href="/search?l=llvm-branch-commits%40lists.llvm.org&q=from:%22Michael+Kruse+via+llvm%5C-branch%5C-commits%22&o=newest&f=1">Michael Kruse via llvm-branch-commits</a></span>
</div>
<blockquote><span class="msgFragment"><pre>
https://github.com/Meinersbur updated
https://github.com/llvm/llvm-project/pull/89748
>From e29002224ef168934ae414e75e765cf197f65bc0 Mon Sep 17 00:00:00 2001
From: Michael Kruse
Date: Tue, 23 Apr 2024 13:21:43 +0200
Subject: [PATCH 1/3] [lldb] Revise IDE folder structure
---
lldb/CMakeLists.txt | 1 +
lldb/cmake/modules/AddLLDB.cmake| 6 ++
lldb/cmake/modules/LLDBConfig.cmake | 2 +-
lldb/cmake/modules/LLDBFramework.cmake | 2 +-
lldb/cmake/modules/LLDBStandalone.cmake | 4 ++--
lldb/docs/CMakeLists.txt| 1 +
lldb/source/API/CMakeLists.txt | 3 +--
lldb/test/API/CMakeLists.txt| 1 +
lldb/test/CMakeLists.txt| 4 ++--
lldb/test/Shell/CMakeLists.txt | 1 +
lldb/test/Unit/CMakeLists.txt | 1 +
lldb/tools/driver/CMakeLists.txt| 2 --
.../lldb-commandinterpreter-fuzzer/CMakeLists.txt | 1 +
lldb/tools/lldb-fuzzer/lldb-target-fuzzer/CMakeLists.txt| 1 +
lldb/tools/lldb-server/CMakeLists.txt | 1 -
lldb/unittests/CMakeLists.txt | 2 +-
lldb/unittests/tools/lldb-server/CMakeLists.txt | 2 +-
lldb/utils/TableGen/CMakeLists.txt | 1 -
lldb/utils/lit-cpuid/CMakeLists.txt | 2 +-
lldb/utils/lldb-dotest/CMakeLists.txt | 2 +-
lldb/utils/lldb-repro/CMakeLists.txt| 2 +-
21 files changed, 21 insertions(+), 21 deletions(-)
diff --git a/lldb/CMakeLists.txt b/lldb/CMakeLists.txt
index 7844d93d78d29..db9e5517e287b 100644
--- a/lldb/CMakeLists.txt
+++ b/lldb/CMakeLists.txt
@@ -1,4 +1,5 @@
cmake_minimum_required(VERSION 3.20.0)
+set(LLVM_SUBPROJECT_TITLE "LLDB")
if(NOT DEFINED LLVM_COMMON_CMAKE_UTILS)
set(LLVM_COMMON_CMAKE_UTILS ${CMAKE_CURRENT_SOURCE_DIR}/../cmake)
diff --git a/lldb/cmake/modules/AddLLDB.cmake b/lldb/cmake/modules/AddLLDB.cmake
index fdc4ee0c05d75..538029037dd46 100644
--- a/lldb/cmake/modules/AddLLDB.cmake
+++ b/lldb/cmake/modules/AddLLDB.cmake
@@ -29,7 +29,6 @@ function(lldb_tablegen)
if(LTG_TARGET)
add_public_tablegen_target(${LTG_TARGET})
-set_target_properties( ${LTG_TARGET} PROPERTIES FOLDER "LLDB tablegenning")
set_property(GLOBAL APPEND PROPERTY LLDB_TABLEGEN_TARGETS ${LTG_TARGET})
endif()
endfunction(lldb_tablegen)
@@ -165,10 +164,10 @@ function(add_lldb_library name)
get_property(parent_dir DIRECTORY PROPERTY PARENT_DIRECTORY)
if(EXISTS ${parent_dir})
get_filename_component(category ${parent_dir} NAME)
- set_target_properties(${name} PROPERTIES FOLDER "lldb
plugins/${category}")
+ set_target_properties(${name} PROPERTIES FOLDER
"LLDB/Plugins/${category}")
endif()
else()
-set_target_properties(${name} PROPERTIES FOLDER "lldb libraries")
+set_target_properties(${name} PROPERTIES FOLDER "LLDB/Libraries")
endif()
# If we want to export all lldb symbols (i.e LLDB_EXPORT_ALL_SYMBOLS=ON), we
@@ -208,7 +207,6 @@ function(add_lldb_executable name)
else()
target_link_libraries(${name} PRIVATE ${ARG_CLANG_LIBS})
endif()
- set_target_properties(${name} PROPERTIES FOLDER "lldb executables")
if (ARG_BUILD_RPATH)
set_target_properties(${name} PROPERTIES BUILD_RPATH "${ARG_BUILD_RPATH}")
diff --git a/lldb/cmake/modules/LLDBConfig.cmake
b/lldb/cmake/modules/LLDBConfig.cmake
index a758261073ac5..13d07a4fabd6d 100644
--- a/lldb/cmake/modules/LLDBConfig.cmake
+++ b/lldb/cmake/modules/LLDBConfig.cmake
@@ -271,7 +271,7 @@ if (NOT LLVM_INSTALL_TOOLCHAIN_ONLY)
)
add_custom_target(lldb-headers)
- set_target_properties(lldb-headers PROPERTIES FOLDER "lldb misc")
+ set_target_properties(lldb-headers PROPERTIES FOLDER "LLDB/Resources")
if (NOT CMAKE_CONFIGURATION_TYPES)
add_llvm_install_targets(install-lldb-headers
diff --git a/lldb/cmake/modules/LLDBFramework.cmake
b/lldb/cmake/modules/LLDBFramework.cmake
index f915839f6b45a..88ea6a568ec4c 100644
--- a/lldb/cmake/modules/LLDBFramework.cmake
+++ b/lldb/cmake/modules/LLDBFramework.cmake
@@ -104,7 +104,7 @@ endforeach()
# Wrap output in a target, so lldb-framework can depend on it.
add_custom_target(liblldb-resource-headers DEPENDS ${lldb_staged_headers})
-set_target_properties(liblldb-resource-headers PROPERTIES FOLDER "lldb misc")
+set_target_properties(liblldb-resource-headers PROPERTIES FOLDER
"LLDB/Resources")
add_dependencies(liblldb liblldb-resource-headers)
# At build time, copy the staged headers into the framework bundle (and do
diff --git a/lldb/cmake/modules/LLDBStandalone.cmake
b/lldb/cmake/modules/LLDBStandalone.cmake
index fd16716d71419..c9367214848fd 100644
--- a/lldb/cmake/modules/LLDBStandalone.cmak</pre></span>
</blockquote><br>
<h3><span class=subject><a href="/llvm-branch-commits@lists.llvm.org/msg21156.html">[llvm-branch-commits] [lldb] [lldb] Revise IDE folder structure (PR #89748)</a></span></h3>
<div class="darkgray font13">
<span class="sender pipe">
<span class=date><a href="/search?l=llvm-branch-commits%40lists.llvm.org&q=date:20240525&o=newest&f=1">2024-05-25</a></span></span>
<span class="sender pipe">
<span class=thead><a href="/search?l=llvm-branch-commits%40lists.llvm.org&q=subject:%22%5C%5Bllvm%5C-branch%5C-commits%5C%5D+%5C%5Blldb%5C%5D+%5C%5Blldb%5C%5D+Revise+IDE+folder+structure+%5C%28PR%09%2389748%5C%29%22&o=newest&f=1">Thread</a></span></span>
<span class=name><a href="/search?l=llvm-branch-commits%40lists.llvm.org&q=from:%22Michael+Kruse+via+llvm%5C-branch%5C-commits%22&o=newest&f=1">Michael Kruse via llvm-branch-commits</a></span>
</div>
<blockquote><span class="msgFragment"><pre>
https://github.com/Meinersbur closed
https://github.com/llvm/llvm-project/pull/89748
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
</pre></span>
</blockquote><br>
<h3><span class=subject><a href="/llvm-branch-commits@lists.llvm.org/msg21171.html">[llvm-branch-commits] [lldb] [lldb] Revise IDE folder structure (PR #89748)</a></span></h3>
<div class="darkgray font13">
<span class="sender pipe">
<span class=date><a href="/search?l=llvm-branch-commits%40lists.llvm.org&q=date:20240525&o=newest&f=1">2024-05-25</a></span></span>
<span class="sender pipe">
<span class=thead><a href="/search?l=llvm-branch-commits%40lists.llvm.org&q=subject:%22%5C%5Bllvm%5C-branch%5C-commits%5C%5D+%5C%5Blldb%5C%5D+%5C%5Blldb%5C%5D+Revise+IDE+folder+structure+%5C%28PR%09%2389748%5C%29%22&o=newest&f=1">Thread</a></span></span>
<span class=name><a href="/search?l=llvm-branch-commits%40lists.llvm.org&q=from:%22Michael+Kruse+via+llvm%5C-branch%5C-commits%22&o=newest&f=1">Michael Kruse via llvm-branch-commits</a></span>
</div>
<blockquote><span class="msgFragment"><pre>
https://github.com/Meinersbur reopened
https://github.com/llvm/llvm-project/pull/89748
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
</pre></span>
</blockquote><br>
<h3><span class=subject><a href="/llvm-branch-commits@lists.llvm.org/msg19236.html">[llvm-branch-commits] [lldb] [lldb] Revise IDE folder structure (PR #89748)</a></span></h3>
<div class="darkgray font13">
<span class="sender pipe">
<span class=date><a href="/search?l=llvm-branch-commits%40lists.llvm.org&q=date:20240423&o=newest&f=1">2024-04-23</a></span></span>
<span class="sender pipe">
<span class=thead><a href="/search?l=llvm-branch-commits%40lists.llvm.org&q=subject:%22%5C%5Bllvm%5C-branch%5C-commits%5C%5D+%5C%5Blldb%5C%5D+%5C%5Blldb%5C%5D+Revise+IDE+folder+structure+%5C%28PR%09%2389748%5C%29%22&o=newest&f=1">Thread</a></span></span>
<span class=name><a href="/search?l=llvm-branch-commits%40lists.llvm.org&q=from:%22Michael+Kruse+via+llvm%5C-branch%5C-commits%22&o=newest&f=1">Michael Kruse via llvm-branch-commits</a></span>
</div>
<blockquote><span class="msgFragment"><pre>
https://github.com/Meinersbur created
https://github.com/llvm/llvm-project/pull/89748
Reviewers of #89153 suggested to break up the patch into per-subproject
patches. This is the BOLT part. See #89153 for the entire series and motivation.
Update the folder titles for targets in the monorepository that have not seen
taken care of for some time. These are the folders that targets are organized
in Visual Studio and XCode (`set_property(TARGET PROPERTY FOLDER
"")`) when using the respective CMake's IDE generator.
* Ensure that every target is in a folder
* Use a folder hierarchy with each LLVM subproject as a top-level folder
* Use consistent folder names between subprojects
* When using target-creating functions from AddLLVM.cmake, automatically
deduce the folder. This reduces the number of
`set_property`/`set_target_property`, but are still necessary when
`add_custom_target`, `add_executable`, `add_library`, etc. are used. A
LLVM_SUBPROJECT_TITLE definition is used for that in each subproject's root
CMakeLists.txt.
>From e29002224ef168934ae414e75e765cf197f65bc0 Mon Sep 17 00:00:00 2001
From: Michael Kruse
Date: Tue, 23 Apr 2024 13:21:43 +0200
Subject: [PATCH] [lldb] Revise IDE folder structure
---
lldb/CMakeLists.txt | 1 +
lldb/cmake/modules/AddLLDB.cmake| 6 ++
lldb/cmake/modules/LLDBConfig.cmake | 2 +-
lldb/cmake/modules/LLDBFramework.cmake | 2 +-
lldb/cmake/modules/LLDBStandalone.cmake | 4 ++--
lldb/docs/CMakeLists.txt| 1 +
lldb/source/API/CMakeLists.txt | 3 +--
lldb/test/API/CMakeLists.txt| 1 +
lldb/test/CMakeLists.txt| 4 ++--
lldb/test/Shell/CMakeLists.txt | 1 +
lldb/test/Unit/CMakeLists.txt | 1 +
lldb/tools/driver/CMakeLists.txt| 2 --
.../lldb-commandinterpreter-fuzzer/CMakeLists.txt | 1 +
lldb/tools/lldb-fuzzer/lldb-target-fuzzer/CMakeLists.txt| 1 +
lldb/tools/lldb-server/CMakeLists.txt | 1 -
lldb/unittests/CMakeLists.txt | 2 +-
lldb/unittests/tools/lldb-server/CMakeLists.txt | 2 +-
lldb/utils/TableGen/CMakeLists.txt | 1 -
lldb/utils/lit-cpuid/CMakeLists.txt | 2 +-
lldb/utils/lldb-dotest/CMakeLists.txt | 2 +-
lldb/utils/lldb-repro/CMakeLists.txt| 2 +-
21 files changed, 21 insertions(+), 21 deletions(-)
diff --git a/lldb/CMakeLists.txt b/lldb/CMakeLists.txt
index 7844d93d78d29a..db9e5517e287b2 100644
--- a/lldb/CMakeLists.txt
+++ b/lldb/CMakeLists.txt
@@ -1,4 +1,5 @@
cmake_minimum_required(VERSION 3.20.0)
+set(LLVM_SUBPROJECT_TITLE "LLDB")
if(NOT DEFINED LLVM_COMMON_CMAKE_UTILS)
set(LLVM_COMMON_CMAKE_UTILS ${CMAKE_CURRENT_SOURCE_DIR}/../cmake)
diff --git a/lldb/cmake/modules/AddLLDB.cmake b/lldb/cmake/modules/AddLLDB.cmake
index fdc4ee0c05d755..538029037dd46a 100644
--- a/lldb/cmake/modules/AddLLDB.cmake
+++ b/lldb/cmake/modules/AddLLDB.cmake
@@ -29,7 +29,6 @@ function(lldb_tablegen)
if(LTG_TARGET)
add_public_tablegen_target(${LTG_TARGET})
-set_target_properties( ${LTG_TARGET} PROPERTIES FOLDER "LLDB tablegenning")
set_property(GLOBAL APPEND PROPERTY LLDB_TABLEGEN_TARGETS ${LTG_TARGET})
endif()
endfunction(lldb_tablegen)
@@ -165,10 +164,10 @@ function(add_lldb_library name)
get_property(parent_dir DIRECTORY PROPERTY PARENT_DIRECTORY)
if(EXISTS ${parent_dir})
get_filename_component(category ${parent_dir} NAME)
- set_target_properties(${name} PROPERTIES FOLDER "lldb
plugins/${category}")
+ set_target_properties(${name} PROPERTIES FOLDER
"LLDB/Plugins/${category}")
endif()
else()
-set_target_properties(${name} PROPERTIES FOLDER "lldb libraries")
+set_target_properties(${name} PROPERTIES FOLDER "LLDB/Libraries")
endif()
# If we want to export all lldb symbols (i.e LLDB_EXPORT_ALL_SYMBOLS=ON), we
@@ -208,7 +207,6 @@ function(add_lldb_executable name)
else()
target_link_libraries(${name} PRIVATE ${ARG_CLANG_LIBS})
endif()
- set_target_properties(${name} PROPERTIES FOLDER "lldb executables")
if (ARG_BUILD_RPATH)
set_target_properties(${name} PROPERTIES BUILD_RPATH "${ARG_BUILD_RPATH}")
diff --git a/lldb/cmake/modules/LLDBConfig.cmake
b/lldb/cmake/modules/LLDBConfig.cmake
index a758261073ac57..13d07a4fabd6de 100644
--- a/lldb/cmake/modules/LLDBConfig.cmake
+++ b/lldb/cmake/modules/LLDBConfig.cmake
@@ -271,7 +271,7 @@ if (NOT LLVM_INSTALL_TOOLCHAIN_ONLY)
)
add_custom_target(lldb-headers)
- set_target_properties(lldb-headers PROPERTIES FOLDER "lldb misc")
+ set_target_properties(lldb-headers PROPERTIES FOLDER "LLDB/Resources")
i</pre></span>
</blockquote><br>
<h3><span class=subject><a href="/llvm-branch-commits@lists.llvm.org/msg19237.html">[llvm-branch-commits] [lldb] [lldb] Revise IDE folder structure (PR #89748)</a></span></h3>
<div class="darkgray font13">
<span class="sender pipe">
<span class=date><a href="/search?l=llvm-branch-commits%40lists.llvm.org&q=date:20240423&o=newest&f=1">2024-04-23</a></span></span>
<span class="sender pipe">
<span class=thead><a href="/search?l=llvm-branch-commits%40lists.llvm.org&q=subject:%22%5C%5Bllvm%5C-branch%5C-commits%5C%5D+%5C%5Blldb%5C%5D+%5C%5Blldb%5C%5D+Revise+IDE+folder+structure+%5C%28PR%09%2389748%5C%29%22&o=newest&f=1">Thread</a></span></span>
<span class=name><a href="/search?l=llvm-branch-commits%40lists.llvm.org&q=from:%22Michael+Kruse+via+llvm%5C-branch%5C-commits%22&o=newest&f=1">Michael Kruse via llvm-branch-commits</a></span>
</div>
<blockquote><span class="msgFragment"><pre>
https://github.com/Meinersbur edited
https://github.com/llvm/llvm-project/pull/89748
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
</pre></span>
</blockquote><br>
<h3><span class=subject><a href="/llvm-branch-commits@lists.llvm.org/msg19297.html">[llvm-branch-commits] [lldb] [lldb] Revise IDE folder structure (PR #89748)</a></span></h3>
<div class="darkgray font13">
<span class="sender pipe">
<span class=date><a href="/search?l=llvm-branch-commits%40lists.llvm.org&q=date:20240423&o=newest&f=1">2024-04-23</a></span></span>
<span class="sender pipe">
<span class=thead><a href="/search?l=llvm-branch-commits%40lists.llvm.org&q=subject:%22%5C%5Bllvm%5C-branch%5C-commits%5C%5D+%5C%5Blldb%5C%5D+%5C%5Blldb%5C%5D+Revise+IDE+folder+structure+%5C%28PR%09%2389748%5C%29%22&o=newest&f=1">Thread</a></span></span>
<span class=name><a href="/search?l=llvm-branch-commits%40lists.llvm.org&q=from:%22Jonas+Devlieghere+via+llvm%5C-branch%5C-commits%22&o=newest&f=1">Jonas Devlieghere via llvm-branch-commits</a></span>
</div>
<blockquote><span class="msgFragment"><pre>
https://github.com/JDevlieghere approved this pull request.
Thanks for splitting this up. LGTM modulo one folder name.
https://github.com/llvm/llvm-project/pull/89748
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
</pre></span>
</blockquote><br>
<h3><span class=subject><a href="/llvm-branch-commits@lists.llvm.org/msg19298.html">[llvm-branch-commits] [lldb] [lldb] Revise IDE folder structure (PR #89748)</a></span></h3>
<div class="darkgray font13">
<span class="sender pipe">
<span class=date><a href="/search?l=llvm-branch-commits%40lists.llvm.org&q=date:20240423&o=newest&f=1">2024-04-23</a></span></span>
<span class="sender pipe">
<span class=thead><a href="/search?l=llvm-branch-commits%40lists.llvm.org&q=subject:%22%5C%5Bllvm%5C-branch%5C-commits%5C%5D+%5C%5Blldb%5C%5D+%5C%5Blldb%5C%5D+Revise+IDE+folder+structure+%5C%28PR%09%2389748%5C%29%22&o=newest&f=1">Thread</a></span></span>
<span class=name><a href="/search?l=llvm-branch-commits%40lists.llvm.org&q=from:%22Jonas+Devlieghere+via+llvm%5C-branch%5C-commits%22&o=newest&f=1">Jonas Devlieghere via llvm-branch-commits</a></span>
</div>
<blockquote><span class="msgFragment"><pre>
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/89748
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
</pre></span>
</blockquote><br>
<h3><span class=subject><a href="/llvm-branch-commits@lists.llvm.org/msg19299.html">[llvm-branch-commits] [lldb] [lldb] Revise IDE folder structure (PR #89748)</a></span></h3>
<div class="darkgray font13">
<span class="sender pipe">
<span class=date><a href="/search?l=llvm-branch-commits%40lists.llvm.org&q=date:20240423&o=newest&f=1">2024-04-23</a></span></span>
<span class="sender pipe">
<span class=thead><a href="/search?l=llvm-branch-commits%40lists.llvm.org&q=subject:%22%5C%5Bllvm%5C-branch%5C-commits%5C%5D+%5C%5Blldb%5C%5D+%5C%5Blldb%5C%5D+Revise+IDE+folder+structure+%5C%28PR%09%2389748%5C%29%22&o=newest&f=1">Thread</a></span></span>
<span class=name><a href="/search?l=llvm-branch-commits%40lists.llvm.org&q=from:%22Jonas+Devlieghere+via+llvm%5C-branch%5C-commits%22&o=newest&f=1">Jonas Devlieghere via llvm-branch-commits</a></span>
</div>
<blockquote><span class="msgFragment"><pre>
@@ -232,7 +231,7 @@ elseif (LLDB_EXPORT_ALL_SYMBOLS)
)
add_llvm_symbol_exports(liblldb ${exported_symbol_file})
- set_target_properties(liblldb_exports PROPERTIES FOLDER "lldb misc")
+ set_target_properties(liblldb PROPERTIES FOLDER "LLDB/Misc")
JDevlieghere wrote:
Should this be `LLDB/API`?
https://github.com/llvm/llvm-project/pull/89748
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
</pre></span>
</blockquote><br>
<h3><span class=subject><a href="/llvm-branch-commits@lists.llvm.org/msg19358.html">[llvm-branch-commits] [lldb] [lldb] Revise IDE folder structure (PR #89748)</a></span></h3>
<div class="darkgray font13">
<span class="sender pipe">
<span class=date><a href="/search?l=llvm-branch-commits%40lists.llvm.org&q=date:20240423&o=newest&f=1">2024-04-23</a></span></span>
<span class="sender pipe">
<span class=thead><a href="/search?l=llvm-branch-commits%40lists.llvm.org&q=subject:%22%5C%5Bllvm%5C-branch%5C-commits%5C%5D+%5C%5Blldb%5C%5D+%5C%5Blldb%5C%5D+Revise+IDE+folder+structure+%5C%28PR%09%2389748%5C%29%22&o=newest&f=1">Thread</a></span></span>
<span class=name><a href="/search?l=llvm-branch-commits%40lists.llvm.org&q=from:%22Michael+Kruse+via+llvm%5C-branch%5C-commits%22&o=newest&f=1">Michael Kruse via llvm-branch-commits</a></span>
</div>
<blockquote><span class="msgFragment"><pre>
@@ -232,7 +231,7 @@ elseif (LLDB_EXPORT_ALL_SYMBOLS)
)
add_llvm_symbol_exports(liblldb ${exported_symbol_file})
- set_target_properties(liblldb_exports PROPERTIES FOLDER "lldb misc")
+ set_target_properties(liblldb PROPERTIES FOLDER "LLDB/Misc")
Meinersbur wrote:
This `set_target_properties` is actually redundant: `add_llvm_symbol_exports`
already puts it into a folder. It is also `${LLVM_SUBPROJECT_TITLE}/Misc`. I
agree `${LLVM_SUBPROJECT_TITLE}/API` would be a better name. I am going to make
that change in #89741. Thanks.
https://github.com/llvm/llvm-project/pull/89748
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
</pre></span>
</blockquote><br>
<h3><span class=subject><a href="/llvm-branch-commits@lists.llvm.org/msg19359.html">[llvm-branch-commits] [lldb] [lldb] Revise IDE folder structure (PR #89748)</a></span></h3>
<div class="darkgray font13">
<span class="sender pipe">
<span class=date><a href="/search?l=llvm-branch-commits%40lists.llvm.org&q=date:20240423&o=newest&f=1">2024-04-23</a></span></span>
<span class="sender pipe">
<span class=thead><a href="/search?l=llvm-branch-commits%40lists.llvm.org&q=subject:%22%5C%5Bllvm%5C-branch%5C-commits%5C%5D+%5C%5Blldb%5C%5D+%5C%5Blldb%5C%5D+Revise+IDE+folder+structure+%5C%28PR%09%2389748%5C%29%22&o=newest&f=1">Thread</a></span></span>
<span class=name><a href="/search?l=llvm-branch-commits%40lists.llvm.org&q=from:%22Michael+Kruse+via+llvm%5C-branch%5C-commits%22&o=newest&f=1">Michael Kruse via llvm-branch-commits</a></span>
</div>
<blockquote><span class="msgFragment"><pre>
https://github.com/Meinersbur updated
https://github.com/llvm/llvm-project/pull/89748
>From e29002224ef168934ae414e75e765cf197f65bc0 Mon Sep 17 00:00:00 2001
From: Michael Kruse
Date: Tue, 23 Apr 2024 13:21:43 +0200
Subject: [PATCH 1/2] [lldb] Revise IDE folder structure
---
lldb/CMakeLists.txt | 1 +
lldb/cmake/modules/AddLLDB.cmake| 6 ++
lldb/cmake/modules/LLDBConfig.cmake | 2 +-
lldb/cmake/modules/LLDBFramework.cmake | 2 +-
lldb/cmake/modules/LLDBStandalone.cmake | 4 ++--
lldb/docs/CMakeLists.txt| 1 +
lldb/source/API/CMakeLists.txt | 3 +--
lldb/test/API/CMakeLists.txt| 1 +
lldb/test/CMakeLists.txt| 4 ++--
lldb/test/Shell/CMakeLists.txt | 1 +
lldb/test/Unit/CMakeLists.txt | 1 +
lldb/tools/driver/CMakeLists.txt| 2 --
.../lldb-commandinterpreter-fuzzer/CMakeLists.txt | 1 +
lldb/tools/lldb-fuzzer/lldb-target-fuzzer/CMakeLists.txt| 1 +
lldb/tools/lldb-server/CMakeLists.txt | 1 -
lldb/unittests/CMakeLists.txt | 2 +-
lldb/unittests/tools/lldb-server/CMakeLists.txt | 2 +-
lldb/utils/TableGen/CMakeLists.txt | 1 -
lldb/utils/lit-cpuid/CMakeLists.txt | 2 +-
lldb/utils/lldb-dotest/CMakeLists.txt | 2 +-
lldb/utils/lldb-repro/CMakeLists.txt| 2 +-
21 files changed, 21 insertions(+), 21 deletions(-)
diff --git a/lldb/CMakeLists.txt b/lldb/CMakeLists.txt
index 7844d93d78d29a..db9e5517e287b2 100644
--- a/lldb/CMakeLists.txt
+++ b/lldb/CMakeLists.txt
@@ -1,4 +1,5 @@
cmake_minimum_required(VERSION 3.20.0)
+set(LLVM_SUBPROJECT_TITLE "LLDB")
if(NOT DEFINED LLVM_COMMON_CMAKE_UTILS)
set(LLVM_COMMON_CMAKE_UTILS ${CMAKE_CURRENT_SOURCE_DIR}/../cmake)
diff --git a/lldb/cmake/modules/AddLLDB.cmake b/lldb/cmake/modules/AddLLDB.cmake
index fdc4ee0c05d755..538029037dd46a 100644
--- a/lldb/cmake/modules/AddLLDB.cmake
+++ b/lldb/cmake/modules/AddLLDB.cmake
@@ -29,7 +29,6 @@ function(lldb_tablegen)
if(LTG_TARGET)
add_public_tablegen_target(${LTG_TARGET})
-set_target_properties( ${LTG_TARGET} PROPERTIES FOLDER "LLDB tablegenning")
set_property(GLOBAL APPEND PROPERTY LLDB_TABLEGEN_TARGETS ${LTG_TARGET})
endif()
endfunction(lldb_tablegen)
@@ -165,10 +164,10 @@ function(add_lldb_library name)
get_property(parent_dir DIRECTORY PROPERTY PARENT_DIRECTORY)
if(EXISTS ${parent_dir})
get_filename_component(category ${parent_dir} NAME)
- set_target_properties(${name} PROPERTIES FOLDER "lldb
plugins/${category}")
+ set_target_properties(${name} PROPERTIES FOLDER
"LLDB/Plugins/${category}")
endif()
else()
-set_target_properties(${name} PROPERTIES FOLDER "lldb libraries")
+set_target_properties(${name} PROPERTIES FOLDER "LLDB/Libraries")
endif()
# If we want to export all lldb symbols (i.e LLDB_EXPORT_ALL_SYMBOLS=ON), we
@@ -208,7 +207,6 @@ function(add_lldb_executable name)
else()
target_link_libraries(${name} PRIVATE ${ARG_CLANG_LIBS})
endif()
- set_target_properties(${name} PROPERTIES FOLDER "lldb executables")
if (ARG_BUILD_RPATH)
set_target_properties(${name} PROPERTIES BUILD_RPATH "${ARG_BUILD_RPATH}")
diff --git a/lldb/cmake/modules/LLDBConfig.cmake
b/lldb/cmake/modules/LLDBConfig.cmake
index a758261073ac57..13d07a4fabd6de 100644
--- a/lldb/cmake/modules/LLDBConfig.cmake
+++ b/lldb/cmake/modules/LLDBConfig.cmake
@@ -271,7 +271,7 @@ if (NOT LLVM_INSTALL_TOOLCHAIN_ONLY)
)
add_custom_target(lldb-headers)
- set_target_properties(lldb-headers PROPERTIES FOLDER "lldb misc")
+ set_target_properties(lldb-headers PROPERTIES FOLDER "LLDB/Resources")
if (NOT CMAKE_CONFIGURATION_TYPES)
add_llvm_install_targets(install-lldb-headers
diff --git a/lldb/cmake/modules/LLDBFramework.cmake
b/lldb/cmake/modules/LLDBFramework.cmake
index f915839f6b45a5..88ea6a568ec4ca 100644
--- a/lldb/cmake/modules/LLDBFramework.cmake
+++ b/lldb/cmake/modules/LLDBFramework.cmake
@@ -104,7 +104,7 @@ endforeach()
# Wrap output in a target, so lldb-framework can depend on it.
add_custom_target(liblldb-resource-headers DEPENDS ${lldb_staged_headers})
-set_target_properties(liblldb-resource-headers PROPERTIES FOLDER "lldb misc")
+set_target_properties(liblldb-resource-headers PROPERTIES FOLDER
"LLDB/Resources")
add_dependencies(liblldb liblldb-resource-headers)
# At build time, copy the staged headers into the framework bundle (and do
diff --git a/lldb/cmake/modules/LLDBStandalone.cmake
b/lldb/cmake/modules/LLDBStandalone.cmake
index fd16716d71419c..c9367214848fda 100644
--- a/lldb/cmake/modules/LLDBStand</pre></span>
</blockquote><br>
<h2></h2>
</div>
<div class="aside" role="complementary">
<div class="logo">
<a href="/"><img src="/logo.png" width=247 height=88 alt="The Mail Archive"></a>
</div>
<h2>15 matches</h2>
<br>
<ul><li><a href="/search?l=llvm-branch-commits%40lists.llvm.org&q=subject%3A%22%5C%5Bllvm%5C-branch%5C-commits%5C%5D+%5C%5Blldb%5C%5D+%5C%5Blldb%5C%5D+Revise+IDE+folder+structure+%5C%28PR%09%2389748%5C%29%22&a=1&o=newest&f=1">Advanced search</a></li></ul>
<form class="overflow" action="/search" method="get">
<input type="hidden" name="l" value="llvm-branch-commits@lists.llvm.org">
<label class="hidden" for="q">Search the list</label>
<input class="submittext" type="text" id="q" name="q" placeholder="Search llvm-branch-commits" value="subject:"\[llvm\-branch\-commits\] \[lldb\] \[lldb\] Revise IDE folder structure \(PR #89748\)"">
<input class="submitbutton" id="submit" type="image" src="/submit.png" alt="Submit">
</form>
<div class="nav margintop" id="nav" role="navigation">
<h2 class="hidden">
Site Navigation
</h2>
<ul class="icons font16">
<li class="icons-home"><a href="/">The Mail Archive home</a></li>
<li class="icons-list">
<a href="/llvm-branch-commits@lists.llvm.org" title="c" id="c">llvm-branch-commits - all messages</a></li>
<li class="icons-about">
<a href="/llvm-branch-commits@lists.llvm.org/info.html">llvm-branch-commits - about the list</a></li>
<li class="icons-expand"><a href="/search?l=llvm-branch-commits%40lists.llvm.org&q=subject%3A%22%5C%5Bllvm%5C-branch%5C-commits%5C%5D+%5C%5Blldb%5C%5D+%5C%5Blldb%5C%5D+Revise+IDE+folder+structure+%5C%28PR%09%2389748%5C%29%22&o=newest" title="e" id="e">Expand</a></li>
</ul>
</div>
<div class="listlogo margintopdouble">
<h2 class="hidden">
Mail list logo
</h2>
</div>
</div>
<div class="footer" role="contentinfo">
<h2 class="hidden">
Footer information
</h2>
<ul>
<li><a href="/">The Mail Archive home</a></li>
<li><a href="/faq.html#newlist">Add your mailing list</a></li>
<li><a href="/faq.html">FAQ</a></li>
<li><a href="/faq.html#support">Support</a></li>
<li><a href="/faq.html#privacy">Privacy</a></li>
</ul>
</div>
<script language="javascript" type="text/javascript">
document.onkeydown = NavigateThrough;
function NavigateThrough (event)
{
if (!document.getElementById) return;
if (window.event) event = window.event;
if (event.target.tagName == 'INPUT') return;
if (event.ctrlKey || event.metaKey) return;
var link = null;
switch (event.keyCode ? event.keyCode : event.which ? event.which : null) {
case 69:
link = document.getElementById ('e');
break;
}
if (link && link.href) document.location = link.href;
}
</script>
</body>
</html>