[llvm-branch-commits] [llvm][NFC] Document cl::opt variable and fix typo (PR #90670)

2024-05-01 Thread Paul Kirth via llvm-branch-commits

ilovepi wrote:

> LGTM, thanks!
> 
> For the title, it might be clearer to explicitly mention the variable this is 
> documenting, commit title size permitting

Ah, good suggestion. I'll take care of that tomorrow, when I'm in front of my 
computer again.

https://github.com/llvm/llvm-project/pull/90670
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits


[llvm-branch-commits] [llvm][NFC] Document cl::opt variable and fix typo (PR #90670)

2024-05-01 Thread Florian Hahn via llvm-branch-commits

https://github.com/fhahn approved this pull request.

LGTM, thanks!

For the title, it might be clearer to explicitly mention the variable this is 
documenting, commit title size permitting

https://github.com/llvm/llvm-project/pull/90670
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits


[llvm-branch-commits] [llvm][NFC] Document cl::opt variable and fix typo (PR #90670)

2024-04-30 Thread via llvm-branch-commits

llvmbot wrote:




@llvm/pr-subscribers-llvm-transforms

Author: Paul Kirth (ilovepi)


Changes



---
Full diff: https://github.com/llvm/llvm-project/pull/90670.diff


1 Files Affected:

- (modified) llvm/lib/Transforms/Utils/MisExpect.cpp (+2-1) 


``diff
diff --git a/llvm/lib/Transforms/Utils/MisExpect.cpp 
b/llvm/lib/Transforms/Utils/MisExpect.cpp
index 9cb7c54e0c8c97..59e13795f0f247 100644
--- a/llvm/lib/Transforms/Utils/MisExpect.cpp
+++ b/llvm/lib/Transforms/Utils/MisExpect.cpp
@@ -59,9 +59,10 @@ static cl::opt PGOWarnMisExpect(
 cl::desc("Use this option to turn on/off "
  "warnings about incorrect usage of llvm.expect intrinsics."));
 
+// Command line option for setting the diagnostic tolerance threshold
 static cl::opt MisExpectTolerance(
 "misexpect-tolerance", cl::init(0),
-cl::desc("Prevents emiting diagnostics when profile counts are "
+cl::desc("Prevents emitting diagnostics when profile counts are "
  "within N% of the threshold.."));
 
 } // namespace llvm

``




https://github.com/llvm/llvm-project/pull/90670
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits


[llvm-branch-commits] [llvm][NFC] Document cl::opt variable and fix typo (PR #90670)

2024-04-30 Thread Paul Kirth via llvm-branch-commits

https://github.com/ilovepi created 
https://github.com/llvm/llvm-project/pull/90670

None


___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits