Re: [llvm-commits] [llvm] r36266 - /llvm/trunk/CREDITS.TXT
On Apr 20, 2007, at 9:06 PM, Reid Spencer wrote: On Fri, 2007-04-20 at 20:46 -0700, Chris Lattner wrote: Urg, this is going to come from [EMAIL PROTECTED] ? I've asked David to fix this. He said he would forward my request on to the authentication people at UIUC. He said they aren't likely to give us prefix-less user names. The more issues we run into with UIUC the more I'm not liking how this is turning out. Can we just have the post-commit script fakemail that it is [EMAIL PROTECTED] sending it? -Chris Reid. Yuck. Can we get a mapping table like we have for cvs committers? -Chris Begin forwarded message: From: [EMAIL PROTECTED] Date: April 20, 2007 8:40:04 PM PDT To: llvm-commits@cs.uiuc.edu Subject: [llvm-commits] [llvm] r36266 - /llvm/trunk/CREDITS.TXT Reply-To: CVS Commit Messages for LLVM repository llvm- [EMAIL PROTECTED] Author: cscollab-rspencer Date: Fri Apr 20 22:40:04 2007 New Revision: 36266 URL: http://subversion.cs.uiuc.edu/viewvc/llvm?rev=36266view=rev Log: Add a credit. Modified: llvm/trunk/CREDITS.TXT Modified: llvm/trunk/CREDITS.TXT URL: http://subversion.cs.uiuc.edu/viewvc/llvm/llvm/trunk/ CREDITS.TXT?rev=36266r1=36265r2=36266view=diff == --- llvm/trunk/CREDITS.TXT (original) +++ llvm/trunk/CREDITS.TXT Fri Apr 20 22:40:04 2007 @@ -191,7 +191,7 @@ D: Stacker, llvmc, llvm-ld, llvm-ar, llvm2cpp, lib/Archive, lib/ Linker, D: lib/System, bytecode enhancements, symtab hacking, unoverloading of D: intrinsics, makefile and configuration system, documentation, various bug -D: fixing. +D: fixing, Subversion migration. N: Adam Treat E: [EMAIL PROTECTED] ___ llvm-commits mailing list llvm-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits ___ llvm-commits mailing list llvm-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
Re: [llvm-commits] [llvm] r36266 - /llvm/trunk/CREDITS.TXT
Reid, I thought we were going to turn these into the actual user's name. Has that mapping gone away? I think the old CVS one make the reply-to field be the user's actual email address rather than [EMAIL PROTECTED]. I think we need to do the same here. Otherwise the process of commit review gets harder. Such mapping was done, but for all CVS-style accounts. David should just add corresponding mapping username = e-mail to the special section of the configuration file. Is this just failing because you were expecting reid instead of cscollab-rspencer. Definitely. Script was pre-populated with all current CVS accounts' Author: cscollab-rspencer Real name would be nice here too. Hmm. Ok, I'll see, what can be done here. If its a one line log comment, can we get it on the Log line, otherwise can we indent the lines a few of spaces, as in Modified: field below? I'll check this. Modified: llvm/trunk/CREDITS.TXT I thought we were going to run the diff output through diffstat and insert the histogram here like we did for CVS? Unfortunately, No. This isn't possible here, since diffs are generated per each files separately. Including diffstat will need to redesign everything. Modified: llvm/trunk/CREDITS.TXT The usual diff line here is Index: Is this the way svn diff generates it or can we fix it? Index is just CVS'ism. In fact, patch just ignores everything below --- and +++ and treat them as comment. -- With best regards, Anton Korobeynikov. Faculty of Mathematics Mechanics, Saint Petersburg State University. ___ llvm-commits mailing list llvm-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
Re: [llvm-commits] [llvm] r36266 - /llvm/trunk/CREDITS.TXT
Also, can we get a blank line after the URL? My mail client turns the URL and the into one url... Will check. -- With best regards, Anton Korobeynikov. Faculty of Mathematics Mechanics, Saint Petersburg State University. ___ llvm-commits mailing list llvm-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
Re: [llvm-commits] [llvm] r36266 - /llvm/trunk/CREDITS.TXT
Hello, Chris. Can we just have the post-commit script fakemail that it is [EMAIL PROTECTED] sending it? Exactly in this way it should work now. username=e-mail map just don't know what to do with user cscollab-rspencer, since is assumes, that Reid is using username reid :) -- With best regards, Anton Korobeynikov. Faculty of Mathematics Mechanics, Saint Petersburg State University. ___ llvm-commits mailing list llvm-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
Re: [llvm-commits] [llvm] r36266 - /llvm/trunk/CREDITS.TXT
On Sat, 2007-04-21 at 00:13 -0700, Chris Lattner wrote: On Apr 20, 2007, at 9:06 PM, Reid Spencer wrote: On Fri, 2007-04-20 at 20:46 -0700, Chris Lattner wrote: Urg, this is going to come from [EMAIL PROTECTED] ? I've asked David to fix this. He said he would forward my request on to the authentication people at UIUC. He said they aren't likely to give us prefix-less user names. The more issues we run into with UIUC the more I'm not liking how this is turning out. Can we just have the post-commit script fakemail that it is [EMAIL PROTECTED] sending it? We need to do that anyway, but having one set of user names for pre-conversion and one set for post-conversion is going to double and confuse historical queries like svn blame. It also makes things like gathering statistics on user activity harder because you have to merge pre-conversion and post-conversion results. Reid. -Chris Reid. Yuck. Can we get a mapping table like we have for cvs committers? -Chris Begin forwarded message: From: [EMAIL PROTECTED] Date: April 20, 2007 8:40:04 PM PDT To: llvm-commits@cs.uiuc.edu Subject: [llvm-commits] [llvm] r36266 - /llvm/trunk/CREDITS.TXT Reply-To: CVS Commit Messages for LLVM repository llvm- [EMAIL PROTECTED] Author: cscollab-rspencer Date: Fri Apr 20 22:40:04 2007 New Revision: 36266 URL: http://subversion.cs.uiuc.edu/viewvc/llvm?rev=36266view=rev Log: Add a credit. Modified: llvm/trunk/CREDITS.TXT Modified: llvm/trunk/CREDITS.TXT URL: http://subversion.cs.uiuc.edu/viewvc/llvm/llvm/trunk/ CREDITS.TXT?rev=36266r1=36265r2=36266view=diff == --- llvm/trunk/CREDITS.TXT (original) +++ llvm/trunk/CREDITS.TXT Fri Apr 20 22:40:04 2007 @@ -191,7 +191,7 @@ D: Stacker, llvmc, llvm-ld, llvm-ar, llvm2cpp, lib/Archive, lib/ Linker, D: lib/System, bytecode enhancements, symtab hacking, unoverloading of D: intrinsics, makefile and configuration system, documentation, various bug -D: fixing. +D: fixing, Subversion migration. N: Adam Treat E: [EMAIL PROTECTED] ___ llvm-commits mailing list llvm-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits ___ llvm-commits mailing list llvm-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
Re: [llvm-commits] [llvm] r36266 - /llvm/trunk/CREDITS.TXT
On Apr 21, 2007, at 1:49 AM, Anton Korobeynikov wrote: Hello, Chris. Can we just have the post-commit script fakemail that it is [EMAIL PROTECTED] sending it? Exactly in this way it should work now. username=e-mail map just don't know what to do with user cscollab-rspencer, since is assumes, that Reid is using username reid :) Great, thanks! -Chris ___ llvm-commits mailing list llvm-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
Re: [llvm-commits] [llvm] r36266 - /llvm/trunk/CREDITS.TXT
Anton, This is my first test commit on the test subversion repository. The email generated looks okay, but I think we need to have the email notification script enhanced slightly. I'm wondering if you could look into these things ... The subject line looks great! :) but .. On Sat, 2007-04-21 at 03:40 +, [EMAIL PROTECTED] wrote: I thought we were going to turn these into the actual user's name. Has that mapping gone away? I think the old CVS one make the reply-to field be the user's actual email address rather than [EMAIL PROTECTED]. I think we need to do the same here. Otherwise the process of commit review gets harder. Is this just failing because you were expecting reid instead of cscollab-rspencer. I have an email in to David asking if we can get rid of the prefix. He forwarded it on to the people that do the user authentication stuff. Reid Author: cscollab-rspencer Real name would be nice here too. Date: Fri Apr 20 22:40:04 2007 New Revision: 36266 URL: http://subversion.cs.uiuc.edu/viewvc/llvm?rev=36266view=rev Log: Add a credit. If its a one line log comment, can we get it on the Log line, otherwise can we indent the lines a few of spaces, as in Modified: field below? Modified: llvm/trunk/CREDITS.TXT I thought we were going to run the diff output through diffstat and insert the histogram here like we did for CVS? Modified: llvm/trunk/CREDITS.TXT The usual diff line here is Index: Is this the way svn diff generates it or can we fix it? Thanks, Reid. URL: http://subversion.cs.uiuc.edu/viewvc/llvm/llvm/trunk/CREDITS.TXT?rev=36266r1=36265r2=36266view=diff == --- llvm/trunk/CREDITS.TXT (original) +++ llvm/trunk/CREDITS.TXT Fri Apr 20 22:40:04 2007 @@ -191,7 +191,7 @@ D: Stacker, llvmc, llvm-ld, llvm-ar, llvm2cpp, lib/Archive, lib/Linker, D: lib/System, bytecode enhancements, symtab hacking, unoverloading of D: intrinsics, makefile and configuration system, documentation, various bug -D: fixing. +D: fixing, Subversion migration. N: Adam Treat E: [EMAIL PROTECTED] ___ llvm-commits mailing list llvm-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits ___ llvm-commits mailing list llvm-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
Re: [llvm-commits] [llvm] r36266 - /llvm/trunk/CREDITS.TXT
URL: http://subversion.cs.uiuc.edu/viewvc/llvm/llvm/trunk/ CREDITS.TXT?rev=36266r1=36265r2=36266view=diff == Also, can we get a blank line after the URL? My mail client turns the URL and the into one url... Thanks! -Chris --- llvm/trunk/CREDITS.TXT (original) +++ llvm/trunk/CREDITS.TXT Fri Apr 20 22:40:04 2007 @@ -191,7 +191,7 @@ D: Stacker, llvmc, llvm-ld, llvm-ar, llvm2cpp, lib/Archive, lib/ Linker, D: lib/System, bytecode enhancements, symtab hacking, unoverloading of D: intrinsics, makefile and configuration system, documentation, various bug -D: fixing. +D: fixing, Subversion migration. N: Adam Treat E: [EMAIL PROTECTED] ___ llvm-commits mailing list llvm-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits ___ llvm-commits mailing list llvm-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
