Re: [llvm-commits] CVS: llvm/include/llvm/CodeGen/SelectionDAGNodes.h

[Anton Korobeynikov]

Hello, Chris.

> Is there any reason not to use the parameter attribute enum directly?
Well. Actually not all attributes should be propagated to lowering
stage. Also, there can be possible another attributes. Maybe it's worth
to make just new enum for this?

-- 
With best regards, Anton Korobeynikov.

Faculty of Mathematics & Mechanics, Saint Petersburg State University.


___
llvm-commits mailing list
llvm-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

Re: [llvm-commits] CVS: llvm/include/llvm/CodeGen/SelectionDAGNodes.h

[Chris Lattner]

> +/// runs.  This has one result value for each argument / flag  
> pair, plus
> +/// a chain result. It must be custom legalized. Flag argument  
> indicates
> +/// misc. argument attributes. Currently:
> +/// Bit 0 - signness
> +/// Bit 1 - 'inreg' attribute
> +/// Bit 2 - 'sret' attribute
>  CALL,

Is there any reason not to use the parameter attribute enum directly?

-Chris
___
llvm-commits mailing list
llvm-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

Re: [llvm-commits] CVS: llvm/include/llvm/CodeGen/SelectionDAGNodes.h

[Chris Lattner]

On Wed, 12 Apr 2006, Reid Spencer wrote:

Make sure both member variables are initialized in the default constructor
for SDOperand. This gets rid of numerous warnings in lib/CodeGen and
lib/Target when compiled with GCC 4.0.2


It's lame when we have to sacrifice (even small amounts of) performance to 
work around buggy compiler warnings.  :(


-Chris


Diffs of the changes:  (+1 -1)

SelectionDAGNodes.h |2 +-
1 files changed, 1 insertion(+), 1 deletion(-)


Index: llvm/include/llvm/CodeGen/SelectionDAGNodes.h
diff -u llvm/include/llvm/CodeGen/SelectionDAGNodes.h:1.128 
llvm/include/llvm/CodeGen/SelectionDAGNodes.h:1.129
--- llvm/include/llvm/CodeGen/SelectionDAGNodes.h:1.128 Tue Apr 11 16:30:42 2006
+++ llvm/include/llvm/CodeGen/SelectionDAGNodes.h   Wed Apr 12 11:44:15 2006
@@ -609,7 +609,7 @@
  SDNode *Val;// The node defining the value we are using.
  unsigned ResNo; // Which return value of the node we are using.

-  SDOperand() : Val(0) {}
+  SDOperand() : Val(0), ResNo(0) {}
  SDOperand(SDNode *val, unsigned resno) : Val(val), ResNo(resno) {}

  bool operator==(const SDOperand &O) const {



___
llvm-commits mailing list
llvm-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits



-Chris

--
http://nondot.org/sabre/
http://llvm.org/

___
llvm-commits mailing list
llvm-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits