Re: [lng-odp] Scalable scheduler and scheduled timer queues.

[Bill Fischofer]

Brian, can you comment on this? David did you want to submit a PR for this?

On Wed, May 16, 2018 at 6:26 AM, David Nystrom 
wrote:

> Hi,
>
> All schedulers except the scalable scheduler seem to respect scheduled
> timer queues, except the scalable scheduler.
> Is this by design or mistake ?
>
> The below diff seem to "fix" the functional issue, please note that I have
> not measured the effects on scalability for this
> diff.
>
> --- a/platform/linux-generic/odp_schedule_scalable.c
> +++ b/platform/linux-generic/odp_schedule_scalable.c
> @@ -23,6 +23,7 @@
>  #include 
>  #include 
>  #include 
> +#include 
>
>  #include 
>  #include 
> @@ -889,6 +890,8 @@ static int _schedule(odp_queue_t *from, odp_event_t
> ev[], int num_evts)
> ts = sched_ts;
> atomq = ts->atomq;
>
> +   timer_run();
> +
> /* Once an atomic queue has been scheduled to a thread, it will
> stay
>  * on that thread until empty or 'rotated' by WRR
>  */
>
> Best Regards,
> David
>

[lng-odp] [Bug 3836] JATMA (jet another timer_main assert)

[bugzilla-daemon]

https://bugs.linaro.org/show_bug.cgi?id=3836

Dmitry Eremin-Solenikov  changed:

   What|Removed |Added

Summary|JATMA (jet another  |JATMA (jet another
   |timer_main failure) |timer_main assert)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[lng-odp] [Bug 3836] New: JATMA (jet another timer_main failure)

[bugzilla-daemon]

https://bugs.linaro.org/show_bug.cgi?id=3836

Bug ID: 3836
   Summary: JATMA (jet another timer_main failure)
   Product: OpenDataPlane - linux- generic reference
   Version: master
  Hardware: Other
OS: Linux
Status: UNCONFIRMED
  Severity: enhancement
  Priority: ---
 Component: Timers
  Assignee: lng-odp@lists.linaro.org
  Reporter: dmitry.ereminsoleni...@linaro.org
CC: lng-odp@lists.linaro.org
  Target Milestone: ---

I've got another timer_main failure in Shippable:

 Timer / Timer / timer_test_odp_timer_all
 :


Test failed at line  540  in file  timer.c :  CU_FAIL("odp_timeout_tick() too
small tick") 

https://app.shippable.com/github/Linaro/odp/runs/1340/3/console

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[lng-odp] Scalable scheduler and scheduled timer queues.

[David Nystrom]

Hi,

All schedulers except the scalable scheduler seem to respect scheduled
timer queues, except the scalable scheduler.
Is this by design or mistake ?

The below diff seem to "fix" the functional issue, please note that I have
not measured the effects on scalability for this
diff.

--- a/platform/linux-generic/odp_schedule_scalable.c
+++ b/platform/linux-generic/odp_schedule_scalable.c
@@ -23,6 +23,7 @@
 #include 
 #include 
 #include 
+#include 

 #include 
 #include 
@@ -889,6 +890,8 @@ static int _schedule(odp_queue_t *from, odp_event_t
ev[], int num_evts)
ts = sched_ts;
atomq = ts->atomq;

+   timer_run();
+
/* Once an atomic queue has been scheduled to a thread, it will stay
 * on that thread until empty or 'rotated' by WRR
 */

Best Regards,
David