Re: [lng-odp] [PATCH] example: ipsec: Poll mode fix.
Does it matter. We are just saving this to local structure. Also we will start polling on these queues after launching worker threads post init. Regards Nikhil -Original Message- From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Maxim Uvarov Sent: Thursday, September 08, 2016 9:37 PM To: lng-odp@lists.linaro.org Subject: Re: [lng-odp] [PATCH] example: ipsec: Poll mode fix. Hello Nikhil, I think it's better to add inq to poll before pktio start. Maxim. On 08/16/16 17:22, Nikhil Agarwal wrote: > Adding pktio queues in poll mode to polled queues. > > Signed-off-by: gagandeep singh > Signed-off-by: Nikhil Agarwal > --- > example/ipsec/odp_ipsec.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/example/ipsec/odp_ipsec.c b/example/ipsec/odp_ipsec.c > index 6a9a9fe..89ba1e9 100644 > --- a/example/ipsec/odp_ipsec.c > +++ b/example/ipsec/odp_ipsec.c > @@ -561,6 +561,12 @@ void initialize_intf(char *intf) > odp_queue_to_u64(inq), > mac_addr_str(src_mac_str, src_mac)); > > + if (pktio_param.in_mode == ODP_PKTIN_MODE_QUEUE) { > + poll_queues[num_polled_queues++] = inq; > + printf("%s: adding %"PRIu64"\n", __func__, > +odp_queue_to_u64(inq)); > + } > + > /* Resolve any routes using this interface for output */ > resolve_fwd_db(intf, pktout, src_mac); > }
Re: [lng-odp] [PATCH] example: ipsec: Poll mode fix.
Hello Nikhil, I think it's better to add inq to poll before pktio start. Maxim. On 08/16/16 17:22, Nikhil Agarwal wrote: Adding pktio queues in poll mode to polled queues. Signed-off-by: gagandeep singh Signed-off-by: Nikhil Agarwal --- example/ipsec/odp_ipsec.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/example/ipsec/odp_ipsec.c b/example/ipsec/odp_ipsec.c index 6a9a9fe..89ba1e9 100644 --- a/example/ipsec/odp_ipsec.c +++ b/example/ipsec/odp_ipsec.c @@ -561,6 +561,12 @@ void initialize_intf(char *intf) odp_queue_to_u64(inq), mac_addr_str(src_mac_str, src_mac)); + if (pktio_param.in_mode == ODP_PKTIN_MODE_QUEUE) { + poll_queues[num_polled_queues++] = inq; + printf("%s: adding %"PRIu64"\n", __func__, + odp_queue_to_u64(inq)); + } + /* Resolve any routes using this interface for output */ resolve_fwd_db(intf, pktout, src_mac); }
Re: [lng-odp] [PATCH] example: ipsec: Poll mode fix.
Ping. Please review. Regards Nikhil On 16 August 2016 at 19:52, Nikhil Agarwal wrote: > Adding pktio queues in poll mode to polled queues. > > Signed-off-by: gagandeep singh > Signed-off-by: Nikhil Agarwal > --- > example/ipsec/odp_ipsec.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/example/ipsec/odp_ipsec.c b/example/ipsec/odp_ipsec.c > index 6a9a9fe..89ba1e9 100644 > --- a/example/ipsec/odp_ipsec.c > +++ b/example/ipsec/odp_ipsec.c > @@ -561,6 +561,12 @@ void initialize_intf(char *intf) >odp_queue_to_u64(inq), >mac_addr_str(src_mac_str, src_mac)); > > + if (pktio_param.in_mode == ODP_PKTIN_MODE_QUEUE) { > + poll_queues[num_polled_queues++] = inq; > + printf("%s: adding %"PRIu64"\n", __func__, > + odp_queue_to_u64(inq)); > + } > + > /* Resolve any routes using this interface for output */ > resolve_fwd_db(intf, pktout, src_mac); > } > -- > 2.8.2 > >
Re: [lng-odp] [PATCH] example: ipsec: Poll mode fix.
ping. Please review. Maxim. On 08/16/16 17:22, Nikhil Agarwal wrote: Adding pktio queues in poll mode to polled queues. Signed-off-by: gagandeep singh Signed-off-by: Nikhil Agarwal --- example/ipsec/odp_ipsec.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/example/ipsec/odp_ipsec.c b/example/ipsec/odp_ipsec.c index 6a9a9fe..89ba1e9 100644 --- a/example/ipsec/odp_ipsec.c +++ b/example/ipsec/odp_ipsec.c @@ -561,6 +561,12 @@ void initialize_intf(char *intf) odp_queue_to_u64(inq), mac_addr_str(src_mac_str, src_mac)); + if (pktio_param.in_mode == ODP_PKTIN_MODE_QUEUE) { + poll_queues[num_polled_queues++] = inq; + printf("%s: adding %"PRIu64"\n", __func__, + odp_queue_to_u64(inq)); + } + /* Resolve any routes using this interface for output */ resolve_fwd_db(intf, pktout, src_mac); }
[lng-odp] [PATCH] example: ipsec: Poll mode fix.
Adding pktio queues in poll mode to polled queues. Signed-off-by: gagandeep singh Signed-off-by: Nikhil Agarwal --- example/ipsec/odp_ipsec.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/example/ipsec/odp_ipsec.c b/example/ipsec/odp_ipsec.c index 6a9a9fe..89ba1e9 100644 --- a/example/ipsec/odp_ipsec.c +++ b/example/ipsec/odp_ipsec.c @@ -561,6 +561,12 @@ void initialize_intf(char *intf) odp_queue_to_u64(inq), mac_addr_str(src_mac_str, src_mac)); + if (pktio_param.in_mode == ODP_PKTIN_MODE_QUEUE) { + poll_queues[num_polled_queues++] = inq; + printf("%s: adding %"PRIu64"\n", __func__, + odp_queue_to_u64(inq)); + } + /* Resolve any routes using this interface for output */ resolve_fwd_db(intf, pktout, src_mac); } -- 2.8.2