Re: [lng-odp] [PATCH] helper: ip: add IP protocol value for sctp
On Mon, Jan 19, 2015 at 06:49:35PM +0300, Maxim Uvarov wrote:
On 01/19/2015 02:44 PM, Jerin Jacob wrote:
Signed-off-by: Jerin Jacob jerin.ja...@caviumnetworks.com
---
helper/include/odph_ip.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/helper/include/odph_ip.h b/helper/include/odph_ip.h
index 272fd96..f2638ba 100644
--- a/helper/include/odph_ip.h
+++ b/helper/include/odph_ip.h
@@ -167,6 +167,7 @@ typedef struct ODP_PACKED {
#define ODPH_IPPROTO_FRAG0x2C /** IPv6 Fragment (44) */
#define ODPH_IPPROTO_AH 0x33 /** Authentication Header (51) */
#define ODPH_IPPROTO_ESP 0x32 /** Encapsulating Security Payload (50)
*/
+#define ODPH_IPPROTO_SCTP0x84 /** Stream Control Transmission (132) */
#define ODPH_IPPROTO_INVALID 0xFF /** Reserved invalid by IANA */
/**@}*/
We planned to remove IP stucturues and defines from ODP headers and use
systems.
If for now nobody uses that define can you, in your case use it from:
/usr/include/netinet/in.h
Including the system header files in bare metal build
is bit difficult as it has lot dependency.
IPPROTO_SCTP = 132,/* Stream Control Transmission Protocol. */
Regards,
Maxim.
___
lng-odp mailing list
lng-odp@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/lng-odp
___
lng-odp mailing list
lng-odp@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/lng-odp
Re: [lng-odp] [PATCH] helper: ip: add IP protocol value for sctp
I'd agree if it's to be added it should be to the odp helper file.
On Tue, Jan 20, 2015 at 9:00 AM, Mike Holmes mike.hol...@linaro.org wrote:
On 20 January 2015 at 09:52, Jerin Jacob jerin.ja...@caviumnetworks.com
wrote:
On Mon, Jan 19, 2015 at 06:49:35PM +0300, Maxim Uvarov wrote:
On 01/19/2015 02:44 PM, Jerin Jacob wrote:
Signed-off-by: Jerin Jacob jerin.ja...@caviumnetworks.com
---
helper/include/odph_ip.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/helper/include/odph_ip.h b/helper/include/odph_ip.h
index 272fd96..f2638ba 100644
--- a/helper/include/odph_ip.h
+++ b/helper/include/odph_ip.h
@@ -167,6 +167,7 @@ typedef struct ODP_PACKED {
#define ODPH_IPPROTO_FRAG0x2C /** IPv6 Fragment (44) */
#define ODPH_IPPROTO_AH 0x33 /** Authentication Header (51) */
#define ODPH_IPPROTO_ESP 0x32 /** Encapsulating Security
Payload (50) */
+#define ODPH_IPPROTO_SCTP0x84 /** Stream Control Transmission
(132) */
#define ODPH_IPPROTO_INVALID 0xFF /** Reserved invalid by IANA */
/**@}*/
We planned to remove IP stucturues and defines from ODP headers and use
systems.
If for now nobody uses that define can you, in your case use it from:
/usr/include/netinet/in.h
Including the system header files in bare metal build
is bit difficult as it has lot dependency.
I wonder if any decision to reuse /usr/include/netinet/in.h is wise, we
have been removing assert, errno and compiler specifics from the public
API, it would appear this is an extension to that.
IPPROTO_SCTP = 132,/* Stream Control Transmission Protocol. */
Regards,
Maxim.
___
lng-odp mailing list
lng-odp@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/lng-odp
___
lng-odp mailing list
lng-odp@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/lng-odp
--
*Mike Holmes*
Linaro Sr Technical Manager
LNG - ODP
___
lng-odp mailing list
lng-odp@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/lng-odp
___
lng-odp mailing list
lng-odp@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/lng-odp
[lng-odp] [PATCH] helper: ip: add IP protocol value for sctp
Signed-off-by: Jerin Jacob jerin.ja...@caviumnetworks.com
---
helper/include/odph_ip.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/helper/include/odph_ip.h b/helper/include/odph_ip.h
index 272fd96..f2638ba 100644
--- a/helper/include/odph_ip.h
+++ b/helper/include/odph_ip.h
@@ -167,6 +167,7 @@ typedef struct ODP_PACKED {
#define ODPH_IPPROTO_FRAG0x2C /** IPv6 Fragment (44) */
#define ODPH_IPPROTO_AH 0x33 /** Authentication Header (51) */
#define ODPH_IPPROTO_ESP 0x32 /** Encapsulating Security Payload (50) */
+#define ODPH_IPPROTO_SCTP0x84 /** Stream Control Transmission (132) */
#define ODPH_IPPROTO_INVALID 0xFF /** Reserved invalid by IANA */
/**@}*/
--
1.9.3
___
lng-odp mailing list
lng-odp@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/lng-odp
Re: [lng-odp] [PATCH] helper: ip: add IP protocol value for sctp
On Mon, Jan 19, 2015 at 06:13:42AM -0600, Bill Fischofer wrote:
Two questions:
1. We previously said we didn't need SCTP support for ODP v1.0, so why
is this needed?
Then there is a disconnect, exiting API has reference to SCTP
/**
* Check for SCTP
*
* @param pkt Packet handle
* @return 1 if packet contains an SCTP header, 0 otherwise
*/
int odp_packet_has_sctp(odp_packet_t pkt);
/**
* Check for L4 header, e.g. UDP, TCP, SCTP (also ICMP)
*
* @param pkt Packet handle
* @return 1 if packet contains a valid known L4 header, 0 otherwise
*/
int odp_packet_has_l4(odp_packet_t pkt);
2. This is a helper, so it's not necessarily constrained by what may be
covered by ODP v1.0, but in that case why limit this to SCTP? There are
lots of other IP protocols that this helper file doesn't define besides
SCTP. Should they be included as well?
On Mon, Jan 19, 2015 at 5:44 AM, Jerin Jacob jerin.ja...@caviumnetworks.com
wrote:
Signed-off-by: Jerin Jacob jerin.ja...@caviumnetworks.com
---
helper/include/odph_ip.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/helper/include/odph_ip.h b/helper/include/odph_ip.h
index 272fd96..f2638ba 100644
--- a/helper/include/odph_ip.h
+++ b/helper/include/odph_ip.h
@@ -167,6 +167,7 @@ typedef struct ODP_PACKED {
#define ODPH_IPPROTO_FRAG0x2C /** IPv6 Fragment (44) */
#define ODPH_IPPROTO_AH 0x33 /** Authentication Header (51) */
#define ODPH_IPPROTO_ESP 0x32 /** Encapsulating Security Payload
(50) */
+#define ODPH_IPPROTO_SCTP0x84 /** Stream Control Transmission (132)
*/
#define ODPH_IPPROTO_INVALID 0xFF /** Reserved invalid by IANA */
/**@}*/
--
1.9.3
___
lng-odp mailing list
lng-odp@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/lng-odp
___
lng-odp mailing list
lng-odp@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/lng-odp
Re: [lng-odp] [PATCH] helper: ip: add IP protocol value for sctp
On 01/19/2015 02:44 PM, Jerin Jacob wrote:
Signed-off-by: Jerin Jacob jerin.ja...@caviumnetworks.com
---
helper/include/odph_ip.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/helper/include/odph_ip.h b/helper/include/odph_ip.h
index 272fd96..f2638ba 100644
--- a/helper/include/odph_ip.h
+++ b/helper/include/odph_ip.h
@@ -167,6 +167,7 @@ typedef struct ODP_PACKED {
#define ODPH_IPPROTO_FRAG0x2C /** IPv6 Fragment (44) */
#define ODPH_IPPROTO_AH 0x33 /** Authentication Header (51) */
#define ODPH_IPPROTO_ESP 0x32 /** Encapsulating Security Payload (50) */
+#define ODPH_IPPROTO_SCTP0x84 /** Stream Control Transmission (132) */
#define ODPH_IPPROTO_INVALID 0xFF /** Reserved invalid by IANA */
/**@}*/
We planned to remove IP stucturues and defines from ODP headers and use
systems.
If for now nobody uses that define can you, in your case use it from:
/usr/include/netinet/in.h
IPPROTO_SCTP = 132,/* Stream Control Transmission Protocol. */
Regards,
Maxim.
___
lng-odp mailing list
lng-odp@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/lng-odp
Re: [lng-odp] [PATCH] helper: ip: add IP protocol value for sctp
Two questions:
1. We previously said we didn't need SCTP support for ODP v1.0, so why
is this needed?
2. This is a helper, so it's not necessarily constrained by what may be
covered by ODP v1.0, but in that case why limit this to SCTP? There are
lots of other IP protocols that this helper file doesn't define besides
SCTP. Should they be included as well?
On Mon, Jan 19, 2015 at 5:44 AM, Jerin Jacob jerin.ja...@caviumnetworks.com
wrote:
Signed-off-by: Jerin Jacob jerin.ja...@caviumnetworks.com
---
helper/include/odph_ip.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/helper/include/odph_ip.h b/helper/include/odph_ip.h
index 272fd96..f2638ba 100644
--- a/helper/include/odph_ip.h
+++ b/helper/include/odph_ip.h
@@ -167,6 +167,7 @@ typedef struct ODP_PACKED {
#define ODPH_IPPROTO_FRAG0x2C /** IPv6 Fragment (44) */
#define ODPH_IPPROTO_AH 0x33 /** Authentication Header (51) */
#define ODPH_IPPROTO_ESP 0x32 /** Encapsulating Security Payload
(50) */
+#define ODPH_IPPROTO_SCTP0x84 /** Stream Control Transmission (132)
*/
#define ODPH_IPPROTO_INVALID 0xFF /** Reserved invalid by IANA */
/**@}*/
--
1.9.3
___
lng-odp mailing list
lng-odp@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/lng-odp
___
lng-odp mailing list
lng-odp@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/lng-odp
