Re: [lng-odp] [PATCH] linux-gen: _ishm: fix normal page fallback

[Christophe Milard]

Shall I open a bug and mark it resolved immediately?

On 21 January 2017 at 23:29, Bill Fischofer  wrote:
> This appears to be a bug fix. Bug fix patches should reference the bug
> being resolved in the commit log. I'm not sure I see this in bugzilla,
> so one should be opened for this.
>
> On Fri, Jan 20, 2017 at 3:19 AM, Christophe Milard
>  wrote:
>> Fixing failure due to lack of huge pages.
>>
>> Signed-off-by: Christophe Milard 
>
> Reviewed-and-tested-by: Bill Fischofer 
>
>> ---
>>  platform/linux-generic/_ishm.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/platform/linux-generic/_ishm.c b/platform/linux-generic/_ishm.c
>> index f889834..3797f20 100644
>> --- a/platform/linux-generic/_ishm.c
>> +++ b/platform/linux-generic/_ishm.c
>> @@ -547,7 +547,7 @@ static void *do_map(int block_index, uint64_t len, 
>> uint32_t align,
>> addr = alloc_fragment(len, block_index, align, );
>> if (!addr) {
>> ODP_ERR("alloc_fragment failed.\n");
>> -   if (new_block->filename[0]) {
>> +   if (!new_block->external_fd) {
>> close(*fd);
>> *fd = -1;
>> delete_file(new_block);
>> @@ -562,7 +562,7 @@ static void *do_map(int block_index, uint64_t len, 
>> uint32_t align,
>> if (mapped_addr == NULL) {
>> if (flags & _ODP_ISHM_SINGLE_VA)
>> free_fragment(fragment);
>> -   if (new_block->filename[0]) {
>> +   if (!new_block->external_fd) {
>> close(*fd);
>> *fd = -1;
>> delete_file(new_block);
>> --
>> 2.7.4
>>

Re: [lng-odp] [PATCH] linux-gen: _ishm: fix normal page fallback

[Bill Fischofer]

This appears to be a bug fix. Bug fix patches should reference the bug
being resolved in the commit log. I'm not sure I see this in bugzilla,
so one should be opened for this.

On Fri, Jan 20, 2017 at 3:19 AM, Christophe Milard
 wrote:
> Fixing failure due to lack of huge pages.
>
> Signed-off-by: Christophe Milard 

Reviewed-and-tested-by: Bill Fischofer 

> ---
>  platform/linux-generic/_ishm.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/platform/linux-generic/_ishm.c b/platform/linux-generic/_ishm.c
> index f889834..3797f20 100644
> --- a/platform/linux-generic/_ishm.c
> +++ b/platform/linux-generic/_ishm.c
> @@ -547,7 +547,7 @@ static void *do_map(int block_index, uint64_t len, 
> uint32_t align,
> addr = alloc_fragment(len, block_index, align, );
> if (!addr) {
> ODP_ERR("alloc_fragment failed.\n");
> -   if (new_block->filename[0]) {
> +   if (!new_block->external_fd) {
> close(*fd);
> *fd = -1;
> delete_file(new_block);
> @@ -562,7 +562,7 @@ static void *do_map(int block_index, uint64_t len, 
> uint32_t align,
> if (mapped_addr == NULL) {
> if (flags & _ODP_ISHM_SINGLE_VA)
> free_fragment(fragment);
> -   if (new_block->filename[0]) {
> +   if (!new_block->external_fd) {
> close(*fd);
> *fd = -1;
> delete_file(new_block);
> --
> 2.7.4
>

[lng-odp] [PATCH] linux-gen: _ishm: fix normal page fallback

[Christophe Milard]

Fixing failure due to lack of huge pages.

Signed-off-by: Christophe Milard 
---
 platform/linux-generic/_ishm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/platform/linux-generic/_ishm.c b/platform/linux-generic/_ishm.c
index f889834..3797f20 100644
--- a/platform/linux-generic/_ishm.c
+++ b/platform/linux-generic/_ishm.c
@@ -547,7 +547,7 @@ static void *do_map(int block_index, uint64_t len, uint32_t 
align,
addr = alloc_fragment(len, block_index, align, );
if (!addr) {
ODP_ERR("alloc_fragment failed.\n");
-   if (new_block->filename[0]) {
+   if (!new_block->external_fd) {
close(*fd);
*fd = -1;
delete_file(new_block);
@@ -562,7 +562,7 @@ static void *do_map(int block_index, uint64_t len, uint32_t 
align,
if (mapped_addr == NULL) {
if (flags & _ODP_ISHM_SINGLE_VA)
free_fragment(fragment);
-   if (new_block->filename[0]) {
+   if (!new_block->external_fd) {
close(*fd);
*fd = -1;
delete_file(new_block);
-- 
2.7.4