Re: [lng-odp] [PATCH] linux-generic: fix tap compilation

[Ilya Maximets]

Thanks.

Reviewed-by: Ilya Maximets 

On 14.12.2015 18:26, Maxim Uvarov wrote:
> pktio/tap.c:267:21: error: comparison between signed and
> unsigned integer expressions [-Werror=sign-compare]
>} else if (retval != pkt_len) {
> 
> Cc: Ilya Maximets 
> Signed-off-by: Maxim Uvarov 
> ---
>  platform/linux-generic/pktio/tap.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/platform/linux-generic/pktio/tap.c 
> b/platform/linux-generic/pktio/tap.c
> index 7ecb300..99e15ce 100644
> --- a/platform/linux-generic/pktio/tap.c
> +++ b/platform/linux-generic/pktio/tap.c
> @@ -264,7 +264,7 @@ static int tap_pktio_send(pktio_entry_t *pktio_entry, 
> odp_packet_t pkts[],
>   return -1;
>   }
>   break;
> - } else if (retval != pkt_len) {
> + } else if ((uint32_t)retval != pkt_len) {
>   ODP_ERR("sent partial ethernet packet\n");
>   if (i == 0) {
>   __odp_errno = EMSGSIZE;
> 
___
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp

Re: [lng-odp] [PATCH] linux-generic: fix tap compilation

[Bill Fischofer]

On Mon, Dec 14, 2015 at 9:26 AM, Maxim Uvarov 
wrote:

> pktio/tap.c:267:21: error: comparison between signed and
> unsigned integer expressions [-Werror=sign-compare]
>} else if (retval != pkt_len) {
>
> Cc: Ilya Maximets 
> Signed-off-by: Maxim Uvarov 
>

Reviewed-by: Bill Fischofer 


> ---
>  platform/linux-generic/pktio/tap.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/platform/linux-generic/pktio/tap.c
> b/platform/linux-generic/pktio/tap.c
> index 7ecb300..99e15ce 100644
> --- a/platform/linux-generic/pktio/tap.c
> +++ b/platform/linux-generic/pktio/tap.c
> @@ -264,7 +264,7 @@ static int tap_pktio_send(pktio_entry_t *pktio_entry,
> odp_packet_t pkts[],
> return -1;
> }
> break;
> -   } else if (retval != pkt_len) {
> +   } else if ((uint32_t)retval != pkt_len) {
> ODP_ERR("sent partial ethernet packet\n");
> if (i == 0) {
> __odp_errno = EMSGSIZE;
> --
> 1.9.1
>
> ___
> lng-odp mailing list
> lng-odp@lists.linaro.org
> https://lists.linaro.org/mailman/listinfo/lng-odp
>
___
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp

[lng-odp] [PATCH] linux-generic: fix tap compilation

[Maxim Uvarov]

pktio/tap.c:267:21: error: comparison between signed and
unsigned integer expressions [-Werror=sign-compare]
   } else if (retval != pkt_len) {

Cc: Ilya Maximets 
Signed-off-by: Maxim Uvarov 
---
 platform/linux-generic/pktio/tap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/platform/linux-generic/pktio/tap.c 
b/platform/linux-generic/pktio/tap.c
index 7ecb300..99e15ce 100644
--- a/platform/linux-generic/pktio/tap.c
+++ b/platform/linux-generic/pktio/tap.c
@@ -264,7 +264,7 @@ static int tap_pktio_send(pktio_entry_t *pktio_entry, 
odp_packet_t pkts[],
return -1;
}
break;
-   } else if (retval != pkt_len) {
+   } else if ((uint32_t)retval != pkt_len) {
ODP_ERR("sent partial ethernet packet\n");
if (i == 0) {
__odp_errno = EMSGSIZE;
-- 
1.9.1

___
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp

Re: [lng-odp] [PATCH] linux-generic: fix tap compilation

[Maxim Uvarov]

Merged,
Maxim.

On 12/14/2015 18:31, Bill Fischofer wrote:



On Mon, Dec 14, 2015 at 9:26 AM, Maxim Uvarov > wrote:


pktio/tap.c:267:21: error: comparison between signed and
unsigned integer expressions [-Werror=sign-compare]
   } else if (retval != pkt_len) {

Cc: Ilya Maximets >
Signed-off-by: Maxim Uvarov >


Reviewed-by: Bill Fischofer >


---
 platform/linux-generic/pktio/tap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/platform/linux-generic/pktio/tap.c
b/platform/linux-generic/pktio/tap.c
index 7ecb300..99e15ce 100644
--- a/platform/linux-generic/pktio/tap.c
+++ b/platform/linux-generic/pktio/tap.c
@@ -264,7 +264,7 @@ static int tap_pktio_send(pktio_entry_t
*pktio_entry, odp_packet_t pkts[],
return -1;
}
break;
-   } else if (retval != pkt_len) {
+   } else if ((uint32_t)retval != pkt_len) {
ODP_ERR("sent partial ethernet packet\n");
if (i == 0) {
__odp_errno = EMSGSIZE;
--
1.9.1

___
lng-odp mailing list
lng-odp@lists.linaro.org 
https://lists.linaro.org/mailman/listinfo/lng-odp




___
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp