[lng-odp] [PATCH 00/10] Pktio checks
This series add several tests for pktios and fixes the issue they raised. The main features checked are: * RONLY pktio cannot be sent to * WONLY pktio cannot be read from * stopped pktio cannot be stopped * started pktio cannot be started * started pktio cannot be configured Nicolas Morey-Chaisemartin (10): linux-generic: pktio: check interface mode is compatible before receiving or sending validation: pktio: add customizable out mode for pktios validation: pktio: add tests for rrecv() on WONLY, and send on RONLY pktios validation: pktio: stop interfaces before removing the default inq validation: pktio: remove unneeded stop as interface is stopped after open() validation: classification: start pktio after setting inq and stop it before removing it validation: classification: stronger checks to avoid SEGV on pktio failure linux-generic: pktio: check for pktio_start when started and pktio_stop when stopped linux-generic: pktio: configuration functions check that interface is stopped validation: pktio: add test for start when started and stop when stopped() platform/linux-generic/odp_packet_io.c | 25 - .../classification/odp_classification_common.c | 2 + .../classification/odp_classification_test_pmr.c | 25 +++-- test/validation/pktio/pktio.c | 116 ++--- 4 files changed, 140 insertions(+), 28 deletions(-) ___ lng-odp mailing list lng-odp@lists.linaro.org https://lists.linaro.org/mailman/listinfo/lng-odp
Re: [lng-odp] [PATCH 00/10] Pktio checks
Patches looks good for me. Does anybody else reviewing? Maxim. On 11/10/2015 18:49, Nicolas Morey-Chaisemartin wrote: This series add several tests for pktios and fixes the issue they raised. The main features checked are: * RONLY pktio cannot be sent to * WONLY pktio cannot be read from * stopped pktio cannot be stopped * started pktio cannot be started * started pktio cannot be configured Nicolas Morey-Chaisemartin (10): linux-generic: pktio: check interface mode is compatible before receiving or sending validation: pktio: add customizable out mode for pktios validation: pktio: add tests for rrecv() on WONLY, and send on RONLY pktios validation: pktio: stop interfaces before removing the default inq validation: pktio: remove unneeded stop as interface is stopped after open() validation: classification: start pktio after setting inq and stop it before removing it validation: classification: stronger checks to avoid SEGV on pktio failure linux-generic: pktio: check for pktio_start when started and pktio_stop when stopped linux-generic: pktio: configuration functions check that interface is stopped validation: pktio: add test for start when started and stop when stopped() platform/linux-generic/odp_packet_io.c | 25 - .../classification/odp_classification_common.c | 2 + .../classification/odp_classification_test_pmr.c | 25 +++-- test/validation/pktio/pktio.c | 116 ++--- 4 files changed, 140 insertions(+), 28 deletions(-) ___ lng-odp mailing list lng-odp@lists.linaro.org https://lists.linaro.org/mailman/listinfo/lng-odp ___ lng-odp mailing list lng-odp@lists.linaro.org https://lists.linaro.org/mailman/listinfo/lng-odp
Re: [lng-odp] [PATCH 00/10] Pktio checks
On Tue, Nov 10, 2015 at 04:49:39PM +0100, Nicolas Morey-Chaisemartin wrote: > This series add several tests for pktios and fixes the issue they raised. > The main features checked are: > * RONLY pktio cannot be sent to > * WONLY pktio cannot be read from > * stopped pktio cannot be stopped > * started pktio cannot be started > * started pktio cannot be configured > > Nicolas Morey-Chaisemartin (10): > linux-generic: pktio: check interface mode is compatible before > receiving or sending > validation: pktio: add customizable out mode for pktios > validation: pktio: add tests for rrecv() on WONLY, and send on RONLY > pktios > validation: pktio: stop interfaces before removing the default inq > validation: pktio: remove unneeded stop as interface is stopped after > open() > validation: classification: start pktio after setting inq and stop it > before removing it > validation: classification: stronger checks to avoid SEGV on pktio > failure > linux-generic: pktio: check for pktio_start when started and > pktio_stop when stopped > linux-generic: pktio: configuration functions check that interface is > stopped > validation: pktio: add test for start when started and stop when > stopped() > > platform/linux-generic/odp_packet_io.c | 25 - > .../classification/odp_classification_common.c | 2 + > .../classification/odp_classification_test_pmr.c | 25 +++-- > test/validation/pktio/pktio.c | 116 > ++--- > 4 files changed, 140 insertions(+), 28 deletions(-) > For the series: Reviewed-by: Stuart Haslam -- Stuart. ___ lng-odp mailing list lng-odp@lists.linaro.org https://lists.linaro.org/mailman/listinfo/lng-odp
Re: [lng-odp] [PATCH 00/10] Pktio checks
Merged, Maxim. On 11/10/2015 18:49, Nicolas Morey-Chaisemartin wrote: This series add several tests for pktios and fixes the issue they raised. The main features checked are: * RONLY pktio cannot be sent to * WONLY pktio cannot be read from * stopped pktio cannot be stopped * started pktio cannot be started * started pktio cannot be configured Nicolas Morey-Chaisemartin (10): linux-generic: pktio: check interface mode is compatible before receiving or sending validation: pktio: add customizable out mode for pktios validation: pktio: add tests for rrecv() on WONLY, and send on RONLY pktios validation: pktio: stop interfaces before removing the default inq validation: pktio: remove unneeded stop as interface is stopped after open() validation: classification: start pktio after setting inq and stop it before removing it validation: classification: stronger checks to avoid SEGV on pktio failure linux-generic: pktio: check for pktio_start when started and pktio_stop when stopped linux-generic: pktio: configuration functions check that interface is stopped validation: pktio: add test for start when started and stop when stopped() platform/linux-generic/odp_packet_io.c | 25 - .../classification/odp_classification_common.c | 2 + .../classification/odp_classification_test_pmr.c | 25 +++-- test/validation/pktio/pktio.c | 116 ++--- 4 files changed, 140 insertions(+), 28 deletions(-) ___ lng-odp mailing list lng-odp@lists.linaro.org https://lists.linaro.org/mailman/listinfo/lng-odp ___ lng-odp mailing list lng-odp@lists.linaro.org https://lists.linaro.org/mailman/listinfo/lng-odp
Re: [lng-odp] [PATCH 00/10] Pktio checks
Could you merge this into api-next ASAP. Just lost couple of hours in debugging these same malfunctioning tests. -Petri > -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT > Maxim Uvarov > Sent: Tuesday, December 08, 2015 4:14 PM > To: lng-odp@lists.linaro.org > Subject: Re: [lng-odp] [PATCH 00/10] Pktio checks > > Merged, > Maxim. > > On 11/10/2015 18:49, Nicolas Morey-Chaisemartin wrote: > > This series add several tests for pktios and fixes the issue they > raised. > > The main features checked are: > > * RONLY pktio cannot be sent to > > * WONLY pktio cannot be read from > > * stopped pktio cannot be stopped > > * started pktio cannot be started > > * started pktio cannot be configured > > > > Nicolas Morey-Chaisemartin (10): > >linux-generic: pktio: check interface mode is compatible before > > receiving or sending > >validation: pktio: add customizable out mode for pktios > >validation: pktio: add tests for rrecv() on WONLY, and send on RONLY > > pktios > >validation: pktio: stop interfaces before removing the default inq > >validation: pktio: remove unneeded stop as interface is stopped after > > open() > >validation: classification: start pktio after setting inq and stop it > > before removing it > >validation: classification: stronger checks to avoid SEGV on pktio > > failure > >linux-generic: pktio: check for pktio_start when started and > > pktio_stop when stopped > >linux-generic: pktio: configuration functions check that interface is > > stopped > >validation: pktio: add test for start when started and stop when > > stopped() > > > > platform/linux-generic/odp_packet_io.c | 25 - > > .../classification/odp_classification_common.c | 2 + > > .../classification/odp_classification_test_pmr.c | 25 +++-- > > test/validation/pktio/pktio.c | 116 > ++--- > > 4 files changed, 140 insertions(+), 28 deletions(-) > > > > ___ > > lng-odp mailing list > > lng-odp@lists.linaro.org > > https://lists.linaro.org/mailman/listinfo/lng-odp > > ___ > lng-odp mailing list > lng-odp@lists.linaro.org > https://lists.linaro.org/mailman/listinfo/lng-odp ___ lng-odp mailing list lng-odp@lists.linaro.org https://lists.linaro.org/mailman/listinfo/lng-odp
Re: [lng-odp] [PATCH 00/10] Pktio checks
On 12/08/2015 17:20, Savolainen, Petri (Nokia - FI/Espoo) wrote: Could you merge this into api-next ASAP. Just lost couple of hours in debugging these same malfunctioning tests. -Petri If you can merge that master and api-next I can. But for now after time things 2 branches out of sync in many files. Maxim. -Original Message- From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT Maxim Uvarov Sent: Tuesday, December 08, 2015 4:14 PM To: lng-odp@lists.linaro.org Subject: Re: [lng-odp] [PATCH 00/10] Pktio checks Merged, Maxim. On 11/10/2015 18:49, Nicolas Morey-Chaisemartin wrote: This series add several tests for pktios and fixes the issue they raised. The main features checked are: * RONLY pktio cannot be sent to * WONLY pktio cannot be read from * stopped pktio cannot be stopped * started pktio cannot be started * started pktio cannot be configured Nicolas Morey-Chaisemartin (10): linux-generic: pktio: check interface mode is compatible before receiving or sending validation: pktio: add customizable out mode for pktios validation: pktio: add tests for rrecv() on WONLY, and send on RONLY pktios validation: pktio: stop interfaces before removing the default inq validation: pktio: remove unneeded stop as interface is stopped after open() validation: classification: start pktio after setting inq and stop it before removing it validation: classification: stronger checks to avoid SEGV on pktio failure linux-generic: pktio: check for pktio_start when started and pktio_stop when stopped linux-generic: pktio: configuration functions check that interface is stopped validation: pktio: add test for start when started and stop when stopped() platform/linux-generic/odp_packet_io.c | 25 - .../classification/odp_classification_common.c | 2 + .../classification/odp_classification_test_pmr.c | 25 +++-- test/validation/pktio/pktio.c | 116 ++--- 4 files changed, 140 insertions(+), 28 deletions(-) ___ lng-odp mailing list lng-odp@lists.linaro.org https://lists.linaro.org/mailman/listinfo/lng-odp ___ lng-odp mailing list lng-odp@lists.linaro.org https://lists.linaro.org/mailman/listinfo/lng-odp ___ lng-odp mailing list lng-odp@lists.linaro.org https://lists.linaro.org/mailman/listinfo/lng-odp
Re: [lng-odp] [PATCH 00/10] Pktio checks
The process states that API-NEXT takes master on master release points only. https://docs.google.com/drawings/d/1kWkr2qBV4xbqOCXMDVsoINhdxaNeHC-8sCm6SBVFI8o/edit On 8 December 2015 at 09:48, Maxim Uvarov wrote: > On 12/08/2015 17:20, Savolainen, Petri (Nokia - FI/Espoo) wrote: > >> Could you merge this into api-next ASAP. Just lost couple of hours in >> debugging these same malfunctioning tests. >> >> -Petri >> > > If you can merge that master and api-next I can. But for now after time > things 2 branches out of sync in many files. > > Maxim. > > > > >> -Original Message- >>> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT >>> Maxim Uvarov >>> Sent: Tuesday, December 08, 2015 4:14 PM >>> To: lng-odp@lists.linaro.org >>> Subject: Re: [lng-odp] [PATCH 00/10] Pktio checks >>> >>> Merged, >>> Maxim. >>> >>> On 11/10/2015 18:49, Nicolas Morey-Chaisemartin wrote: >>> >>>> This series add several tests for pktios and fixes the issue they >>>> >>> raised. >>> >>>> The main features checked are: >>>> * RONLY pktio cannot be sent to >>>> * WONLY pktio cannot be read from >>>> * stopped pktio cannot be stopped >>>> * started pktio cannot be started >>>> * started pktio cannot be configured >>>> >>>> Nicolas Morey-Chaisemartin (10): >>>> linux-generic: pktio: check interface mode is compatible before >>>> receiving or sending >>>> validation: pktio: add customizable out mode for pktios >>>> validation: pktio: add tests for rrecv() on WONLY, and send on RONLY >>>> pktios >>>> validation: pktio: stop interfaces before removing the default inq >>>> validation: pktio: remove unneeded stop as interface is stopped >>>> after >>>> open() >>>> validation: classification: start pktio after setting inq and stop >>>> it >>>> before removing it >>>> validation: classification: stronger checks to avoid SEGV on pktio >>>> failure >>>> linux-generic: pktio: check for pktio_start when started and >>>> pktio_stop when stopped >>>> linux-generic: pktio: configuration functions check that interface >>>> is >>>> stopped >>>> validation: pktio: add test for start when started and stop when >>>> stopped() >>>> >>>>platform/linux-generic/odp_packet_io.c | 25 - >>>>.../classification/odp_classification_common.c | 2 + >>>>.../classification/odp_classification_test_pmr.c | 25 +++-- >>>>test/validation/pktio/pktio.c | 116 >>>> >>> ++--- >>> >>>>4 files changed, 140 insertions(+), 28 deletions(-) >>>> >>>> ___ >>>> lng-odp mailing list >>>> lng-odp@lists.linaro.org >>>> https://lists.linaro.org/mailman/listinfo/lng-odp >>>> >>> ___ >>> lng-odp mailing list >>> lng-odp@lists.linaro.org >>> https://lists.linaro.org/mailman/listinfo/lng-odp >>> >> > ___ > lng-odp mailing list > lng-odp@lists.linaro.org > https://lists.linaro.org/mailman/listinfo/lng-odp > -- Mike Holmes Technical Manager - Linaro Networking Group Linaro.org <http://www.linaro.org/> *│ *Open source software for ARM SoCs ___ lng-odp mailing list lng-odp@lists.linaro.org https://lists.linaro.org/mailman/listinfo/lng-odp
Re: [lng-odp] [PATCH 00/10] Pktio checks
So, critical bug fixes from master side are not visible to api-next until a month or so? Most bug fixes should apply directly to api-next as well, since those are implementation/test code/build system fixes (not api changing fixes). Some fixes may touch the same lines that api-next have changed due to an api change (and would need more thinking), but generally that should not be the case. For example, without these fixes it’s impossible to write implementation (on api-next side) that is compatible to the API spec AND passes validation tests, since validation tests do not follow the spec. So, I could not send patches for api-next that follow the spec for one month (since ‘make check’ fails), OR I would need to include these same (or similar bug fix) patches in the front of my patch set. -Petri From: EXT Mike Holmes [mailto:mike.hol...@linaro.org] Sent: Tuesday, December 08, 2015 5:34 PM To: Maxim Uvarov Cc: Savolainen, Petri (Nokia - FI/Espoo); lng-odp@lists.linaro.org Subject: Re: [lng-odp] [PATCH 00/10] Pktio checks The process states that API-NEXT takes master on master release points only. https://docs.google.com/drawings/d/1kWkr2qBV4xbqOCXMDVsoINhdxaNeHC-8sCm6SBVFI8o/edit On 8 December 2015 at 09:48, Maxim Uvarov mailto:maxim.uva...@linaro.org>> wrote: On 12/08/2015 17:20, Savolainen, Petri (Nokia - FI/Espoo) wrote: Could you merge this into api-next ASAP. Just lost couple of hours in debugging these same malfunctioning tests. -Petri If you can merge that master and api-next I can. But for now after time things 2 branches out of sync in many files. Maxim. -Original Message- From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org<mailto:lng-odp-boun...@lists.linaro.org>] On Behalf Of EXT Maxim Uvarov Sent: Tuesday, December 08, 2015 4:14 PM To: lng-odp@lists.linaro.org<mailto:lng-odp@lists.linaro.org> Subject: Re: [lng-odp] [PATCH 00/10] Pktio checks Merged, Maxim. On 11/10/2015 18:49, Nicolas Morey-Chaisemartin wrote: This series add several tests for pktios and fixes the issue they raised. The main features checked are: * RONLY pktio cannot be sent to * WONLY pktio cannot be read from * stopped pktio cannot be stopped * started pktio cannot be started * started pktio cannot be configured Nicolas Morey-Chaisemartin (10): linux-generic: pktio: check interface mode is compatible before receiving or sending validation: pktio: add customizable out mode for pktios validation: pktio: add tests for rrecv() on WONLY, and send on RONLY pktios validation: pktio: stop interfaces before removing the default inq validation: pktio: remove unneeded stop as interface is stopped after open() validation: classification: start pktio after setting inq and stop it before removing it validation: classification: stronger checks to avoid SEGV on pktio failure linux-generic: pktio: check for pktio_start when started and pktio_stop when stopped linux-generic: pktio: configuration functions check that interface is stopped validation: pktio: add test for start when started and stop when stopped() platform/linux-generic/odp_packet_io.c | 25 - .../classification/odp_classification_common.c | 2 + .../classification/odp_classification_test_pmr.c | 25 +++-- test/validation/pktio/pktio.c | 116 ++--- 4 files changed, 140 insertions(+), 28 deletions(-) ___ lng-odp mailing list lng-odp@lists.linaro.org<mailto:lng-odp@lists.linaro.org> https://lists.linaro.org/mailman/listinfo/lng-odp ___ lng-odp mailing list lng-odp@lists.linaro.org<mailto:lng-odp@lists.linaro.org> https://lists.linaro.org/mailman/listinfo/lng-odp ___ lng-odp mailing list lng-odp@lists.linaro.org<mailto:lng-odp@lists.linaro.org> https://lists.linaro.org/mailman/listinfo/lng-odp -- Mike Holmes Technical Manager - Linaro Networking Group Linaro.org<http://www.linaro.org/> │ Open source software for ARM SoCs ___ lng-odp mailing list lng-odp@lists.linaro.org https://lists.linaro.org/mailman/listinfo/lng-odp
Re: [lng-odp] [PATCH 00/10] Pktio checks
On 12/09/2015 11:54, Savolainen, Petri (Nokia - FI/Espoo) wrote:
So, critical bug fixes from master side are not visible to api-next
until a month or so?
Exactly. api-next was broken with TM. Until issue if fixed and branch
operates as usual, there is no pull of critical bug and etc.
https://ci.linaro.org/view/odp-ci/job/odp-api-check
Now some people still see build fails with gcc4.9, but I can not
reproduce it and CI also passes. So only now I can pull changes from master.
Maxim.
Most bug fixes should apply directly to api-next as well, since those
are implementation/test code/build system fixes (not api changing
fixes). Some fixes may touch the same lines that api-next have changed
due to an api change (and would need more thinking), but generally
that should not be the case.
For example, without these fixes it’s impossible to write
implementation (on api-next side) that is compatible to the API spec
AND passes validation tests, since validation tests do not follow the
spec. So, I could not send patches for api-next that follow the spec
for one month (since ‘make check’ fails), OR I would need to include
these same (or similar bug fix) patches in the front of my patch set.
-Petri
*From:*EXT Mike Holmes [mailto:mike.hol...@linaro.org]
*Sent:* Tuesday, December 08, 2015 5:34 PM
*To:* Maxim Uvarov
*Cc:* Savolainen, Petri (Nokia - FI/Espoo); lng-odp@lists.linaro.org
*Subject:* Re: [lng-odp] [PATCH 00/10] Pktio checks
The process states that API-NEXT takes master on master release points
only.
https://docs.google.com/drawings/d/1kWkr2qBV4xbqOCXMDVsoINhdxaNeHC-8sCm6SBVFI8o/edit
On 8 December 2015 at 09:48, Maxim Uvarov <mailto:maxim.uva...@linaro.org>> wrote:
On 12/08/2015 17:20, Savolainen, Petri (Nokia - FI/Espoo) wrote:
Could you merge this into api-next ASAP. Just lost couple of
hours in debugging these same malfunctioning tests.
-Petri
If you can merge that master and api-next I can. But for now after
time things 2 branches out of sync in many files.
Maxim.
-Original Message-
From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org
<mailto:lng-odp-boun...@lists.linaro.org>] On Behalf Of EXT
Maxim Uvarov
Sent: Tuesday, December 08, 2015 4:14 PM
To: lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org>
Subject: Re: [lng-odp] [PATCH 00/10] Pktio checks
Merged,
Maxim.
On 11/10/2015 18:49, Nicolas Morey-Chaisemartin wrote:
This series add several tests for pktios and fixes the
issue they
raised.
The main features checked are:
* RONLY pktio cannot be sent to
* WONLY pktio cannot be read from
* stopped pktio cannot be stopped
* started pktio cannot be started
* started pktio cannot be configured
Nicolas Morey-Chaisemartin (10):
linux-generic: pktio: check interface mode is
compatible before
receiving or sending
validation: pktio: add customizable out mode for
pktios
validation: pktio: add tests for rrecv() on WONLY,
and send on RONLY
pktios
validation: pktio: stop interfaces before removing
the default inq
validation: pktio: remove unneeded stop as
interface is stopped after
open()
validation: classification: start pktio after
setting inq and stop it
before removing it
validation: classification: stronger checks to
avoid SEGV on pktio
failure
linux-generic: pktio: check for pktio_start when
started and
pktio_stop when stopped
linux-generic: pktio: configuration functions
check that interface is
stopped
validation: pktio: add test for start when started
and stop when
stopped()
platform/linux-generic/odp_packet_io.c |
25 -
.../classification/odp_classification_common.c| 2 +
.../classification/odp_classification_test_pmr.c |
25 +++--
test/validation/pktio/pktio.c | 116
++---
4 files changed, 140 insertions(+), 28 deletions(-)
___
lng-odp mailing list
lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.or
Re: [lng-odp] [PATCH 00/10] Pktio checks
Can we merge [1] that was ready and reviewed last week with no objections Maxim Petri - can you review that patch and if there are changes needed I can update. [1] [PATCH] doc: process-guide: add release process On 9 December 2015 at 04:35, Maxim Uvarov wrote: > On 12/09/2015 11:54, Savolainen, Petri (Nokia - FI/Espoo) wrote: > >> >> So, critical bug fixes from master side are not visible to api-next until >> a month or so? >> >> > Exactly. api-next was broken with TM. Until issue if fixed and branch > operates as usual, there is no pull of critical bug and etc. > https://ci.linaro.org/view/odp-ci/job/odp-api-check > > Now some people still see build fails with gcc4.9, but I can not reproduce > it and CI also passes. So only now I can pull changes from master. > > Maxim. > > > Most bug fixes should apply directly to api-next as well, since those are >> implementation/test code/build system fixes (not api changing fixes). Some >> fixes may touch the same lines that api-next have changed due to an api >> change (and would need more thinking), but generally that should not be the >> case. >> >> For example, without these fixes it’s impossible to write implementation >> (on api-next side) that is compatible to the API spec AND passes validation >> tests, since validation tests do not follow the spec. So, I could not send >> patches for api-next that follow the spec for one month (since ‘make check’ >> fails), OR I would need to include these same (or similar bug fix) patches >> in the front of my patch set. >> >> -Petri >> >> *From:*EXT Mike Holmes [mailto:mike.hol...@linaro.org] >> *Sent:* Tuesday, December 08, 2015 5:34 PM >> *To:* Maxim Uvarov >> *Cc:* Savolainen, Petri (Nokia - FI/Espoo); lng-odp@lists.linaro.org >> *Subject:* Re: [lng-odp] [PATCH 00/10] Pktio checks >> >> The process states that API-NEXT takes master on master release points >> only. >> >> >> https://docs.google.com/drawings/d/1kWkr2qBV4xbqOCXMDVsoINhdxaNeHC-8sCm6SBVFI8o/edit >> >> On 8 December 2015 at 09:48, Maxim Uvarov > <mailto:maxim.uva...@linaro.org>> wrote: >> >> On 12/08/2015 17:20, Savolainen, Petri (Nokia - FI/Espoo) wrote: >> >> Could you merge this into api-next ASAP. Just lost couple of >> hours in debugging these same malfunctioning tests. >> >> -Petri >> >> >> If you can merge that master and api-next I can. But for now after >> time things 2 branches out of sync in many files. >> >> Maxim. >> >> >> >> -Original Message----- >> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org >> <mailto:lng-odp-boun...@lists.linaro.org>] On Behalf Of EXT >> Maxim Uvarov >> Sent: Tuesday, December 08, 2015 4:14 PM >> To: lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org >> > >> Subject: Re: [lng-odp] [PATCH 00/10] Pktio checks >> >> Merged, >> Maxim. >> >> On 11/10/2015 18:49, Nicolas Morey-Chaisemartin wrote: >> >> This series add several tests for pktios and fixes the >> issue they >> >> raised. >> >> The main features checked are: >> * RONLY pktio cannot be sent to >> * WONLY pktio cannot be read from >> * stopped pktio cannot be stopped >> * started pktio cannot be started >> * started pktio cannot be configured >> >> Nicolas Morey-Chaisemartin (10): >> linux-generic: pktio: check interface mode is >> compatible before >> receiving or sending >> validation: pktio: add customizable out mode for >> pktios >> validation: pktio: add tests for rrecv() on WONLY, >> and send on RONLY >> pktios >> validation: pktio: stop interfaces before removing >> the default inq >> validation: pktio: remove unneeded stop as >> interface is stopped after >> open() >> validation: classification: start pktio after >> setting inq and stop it >> before removing it >> validation: classification: strong
Re: [lng-odp] [PATCH 00/10] Pktio checks
I’d really need the bug fix applied on api-next ASAP. It’s more urgent than a guide update. Buggy code slows down actual work. Buggy document is just annoying but does not prevent working efficiently. Anyway, this used to be our policy: bug fixes (to master) are merged to api-next soon after master. What is the rationale *not* to merge bug fixes ASAP? -Petri From: EXT Mike Holmes [mailto:mike.hol...@linaro.org] Sent: Wednesday, December 09, 2015 8:34 PM To: Maxim Uvarov Cc: Savolainen, Petri (Nokia - FI/Espoo); lng-odp@lists.linaro.org Subject: Re: [lng-odp] [PATCH 00/10] Pktio checks Can we merge [1] that was ready and reviewed last week with no objections Maxim Petri - can you review that patch and if there are changes needed I can update. [1] [PATCH] doc: process-guide: add release process On 9 December 2015 at 04:35, Maxim Uvarov mailto:maxim.uva...@linaro.org>> wrote: On 12/09/2015 11:54, Savolainen, Petri (Nokia - FI/Espoo) wrote: So, critical bug fixes from master side are not visible to api-next until a month or so? Exactly. api-next was broken with TM. Until issue if fixed and branch operates as usual, there is no pull of critical bug and etc. https://ci.linaro.org/view/odp-ci/job/odp-api-check Now some people still see build fails with gcc4.9, but I can not reproduce it and CI also passes. So only now I can pull changes from master. Maxim. Most bug fixes should apply directly to api-next as well, since those are implementation/test code/build system fixes (not api changing fixes). Some fixes may touch the same lines that api-next have changed due to an api change (and would need more thinking), but generally that should not be the case. For example, without these fixes it’s impossible to write implementation (on api-next side) that is compatible to the API spec AND passes validation tests, since validation tests do not follow the spec. So, I could not send patches for api-next that follow the spec for one month (since ‘make check’ fails), OR I would need to include these same (or similar bug fix) patches in the front of my patch set. -Petri *From:*EXT Mike Holmes [mailto:mike.hol...@linaro.org<mailto:mike.hol...@linaro.org>] *Sent:* Tuesday, December 08, 2015 5:34 PM *To:* Maxim Uvarov *Cc:* Savolainen, Petri (Nokia - FI/Espoo); lng-odp@lists.linaro.org<mailto:lng-odp@lists.linaro.org> *Subject:* Re: [lng-odp] [PATCH 00/10] Pktio checks The process states that API-NEXT takes master on master release points only. https://docs.google.com/drawings/d/1kWkr2qBV4xbqOCXMDVsoINhdxaNeHC-8sCm6SBVFI8o/edit On 8 December 2015 at 09:48, Maxim Uvarov mailto:maxim.uva...@linaro.org> <mailto:maxim.uva...@linaro.org<mailto:maxim.uva...@linaro.org>>> wrote: On 12/08/2015 17:20, Savolainen, Petri (Nokia - FI/Espoo) wrote: Could you merge this into api-next ASAP. Just lost couple of hours in debugging these same malfunctioning tests. -Petri If you can merge that master and api-next I can. But for now after time things 2 branches out of sync in many files. Maxim. -Original Message- From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org<mailto:lng-odp-boun...@lists.linaro.org> <mailto:lng-odp-boun...@lists.linaro.org<mailto:lng-odp-boun...@lists.linaro.org>>] On Behalf Of EXT Maxim Uvarov Sent: Tuesday, December 08, 2015 4:14 PM To: lng-odp@lists.linaro.org<mailto:lng-odp@lists.linaro.org> <mailto:lng-odp@lists.linaro.org<mailto:lng-odp@lists.linaro.org>> Subject: Re: [lng-odp] [PATCH 00/10] Pktio checks Merged, Maxim. On 11/10/2015 18:49, Nicolas Morey-Chaisemartin wrote: This series add several tests for pktios and fixes the issue they raised. The main features checked are: * RONLY pktio cannot be sent to * WONLY pktio cannot be read from * stopped pktio cannot be stopped * started pktio cannot be started * started pktio cannot be configured Nicolas Morey-Chaisemartin (10): linux-generic: pktio: check interface mode is compatible before receiving or sending validation: pktio: add customizable out mode for pktios validation: pktio: add tests for rrecv() on WONLY, and send on RONLY pktios validation: pktio: stop interfaces before removing the default inq validation: pktio: remove unneeded stop as interface is stopped after open() validation: classification: start pktio after
Re: [lng-odp] [PATCH 00/10] Pktio checks
On 12/10/2015 12:08, Savolainen, Petri (Nokia - FI/Espoo) wrote:
I’d really need the bug fix applied on api-next ASAP. It’s more urgent
than a guide update. Buggy code slows down actual work. Buggy document
is just annoying but does not prevent working efficiently.
Anyway, this used to be our policy: bug fixes (to master) are merged
to api-next soon after master. What is the rationale **not** to merge
bug fixes ASAP?
-Petri
working on sync master and api-next right now.
Maxim.
*From:*EXT Mike Holmes [mailto:mike.hol...@linaro.org]
*Sent:* Wednesday, December 09, 2015 8:34 PM
*To:* Maxim Uvarov
*Cc:* Savolainen, Petri (Nokia - FI/Espoo); lng-odp@lists.linaro.org
*Subject:* Re: [lng-odp] [PATCH 00/10] Pktio checks
Can we merge [1] that was ready and reviewed last week with no objections
Maxim Petri - can you review that patch and if there are changes
needed I can update.
[1] [PATCH] doc: process-guide: add release process
On 9 December 2015 at 04:35, Maxim Uvarov <mailto:maxim.uva...@linaro.org>> wrote:
On 12/09/2015 11:54, Savolainen, Petri (Nokia - FI/Espoo) wrote:
So, critical bug fixes from master side are not visible to
api-next until a month or so?
Exactly. api-next was broken with TM. Until issue if fixed and
branch operates as usual, there is no pull of critical bug and etc.
https://ci.linaro.org/view/odp-ci/job/odp-api-check
Now some people still see build fails with gcc4.9, but I can not
reproduce it and CI also passes. So only now I can pull changes
from master.
Maxim.
Most bug fixes should apply directly to api-next as well,
since those are implementation/test code/build system fixes
(not api changing fixes). Some fixes may touch the same lines
that api-next have changed due to an api change (and would
need more thinking), but generally that should not be the case.
For example, without these fixes it’s impossible to write
implementation (on api-next side) that is compatible to the
API spec AND passes validation tests, since validation tests
do not follow the spec. So, I could not send patches for
api-next that follow the spec for one month (since ‘make
check’ fails), OR I would need to include these same (or
similar bug fix) patches in the front of my patch set.
-Petri
*From:*EXT Mike Holmes [mailto:mike.hol...@linaro.org
<mailto:mike.hol...@linaro.org>]
*Sent:* Tuesday, December 08, 2015 5:34 PM
*To:* Maxim Uvarov
*Cc:* Savolainen, Petri (Nokia - FI/Espoo);
lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org>
*Subject:* Re: [lng-odp] [PATCH 00/10] Pktio checks
The process states that API-NEXT takes master on master
release points only.
https://docs.google.com/drawings/d/1kWkr2qBV4xbqOCXMDVsoINhdxaNeHC-8sCm6SBVFI8o/edit
On 8 December 2015 at 09:48, Maxim Uvarov
mailto:maxim.uva...@linaro.org>
<mailto:maxim.uva...@linaro.org
<mailto:maxim.uva...@linaro.org>>> wrote:
On 12/08/2015 17:20, Savolainen, Petri (Nokia - FI/Espoo)
wrote:
Could you merge this into api-next ASAP. Just lost
couple of
hours in debugging these same malfunctioning tests.
-Petri
If you can merge that master and api-next I can. But for
now after
time things 2 branches out of sync in many files.
Maxim.
-Original Message-
From: lng-odp
[mailto:lng-odp-boun...@lists.linaro.org
<mailto:lng-odp-boun...@lists.linaro.org>
<mailto:lng-odp-boun...@lists.linaro.org
<mailto:lng-odp-boun...@lists.linaro.org>>] On Behalf Of EXT
Maxim Uvarov
Sent: Tuesday, December 08, 2015 4:14 PM
To: lng-odp@lists.linaro.org
<mailto:lng-odp@lists.linaro.org>
<mailto:lng-odp@lists.linaro.org
<mailto:lng-odp@lists.linaro.org>>
Subject: Re: [lng-odp] [PATCH 00/10] Pktio checks
Merged,
Maxim.
On 11/10/2015 18:49, Nicolas Morey-Chaisemartin wrote:
This series add several tests for pktios and
fixes the
issue they
raised.
The main features checked are:
* RONLY pktio cannot be sent to
* WONLY pktio cannot be read from
* stopped pktio cannot be stopped
* started pktio cannot be started
* started pktio cannot be configured
Nicolas Morey-Chaisemartin (10)
Re: [lng-odp] [PATCH 00/10] Pktio checks
> -Original Message- > From: EXT Maxim Uvarov [mailto:maxim.uva...@linaro.org] > Sent: Thursday, December 10, 2015 11:15 AM > To: Savolainen, Petri (Nokia - FI/Espoo); EXT Mike Holmes > Cc: lng-odp@lists.linaro.org > Subject: Re: [lng-odp] [PATCH 00/10] Pktio checks > > On 12/10/2015 12:08, Savolainen, Petri (Nokia - FI/Espoo) wrote: > > > > I’d really need the bug fix applied on api-next ASAP. It’s more urgent > > than a guide update. Buggy code slows down actual work. Buggy document > > is just annoying but does not prevent working efficiently. > > > > Anyway, this used to be our policy: bug fixes (to master) are merged > > to api-next soon after master. What is the rationale **not** to merge > > bug fixes ASAP? > > > > -Petri > > > > working on sync master and api-next right now. > > Maxim. Thanks! -Petri > > > > *From:*EXT Mike Holmes [mailto:mike.hol...@linaro.org] > > *Sent:* Wednesday, December 09, 2015 8:34 PM > > *To:* Maxim Uvarov > > *Cc:* Savolainen, Petri (Nokia - FI/Espoo); lng-odp@lists.linaro.org > > *Subject:* Re: [lng-odp] [PATCH 00/10] Pktio checks > > > > Can we merge [1] that was ready and reviewed last week with no > objections > > > > Maxim Petri - can you review that patch and if there are changes > > needed I can update. > > > > [1] [PATCH] doc: process-guide: add release process > > > > On 9 December 2015 at 04:35, Maxim Uvarov > <mailto:maxim.uva...@linaro.org>> wrote: > > > > On 12/09/2015 11:54, Savolainen, Petri (Nokia - FI/Espoo) wrote: > > > > > > So, critical bug fixes from master side are not visible to > > api-next until a month or so? > > > > > > Exactly. api-next was broken with TM. Until issue if fixed and > > branch operates as usual, there is no pull of critical bug and etc. > > https://ci.linaro.org/view/odp-ci/job/odp-api-check > > > > Now some people still see build fails with gcc4.9, but I can not > > reproduce it and CI also passes. So only now I can pull changes > > from master. > > > > Maxim. > > > > Most bug fixes should apply directly to api-next as well, > > since those are implementation/test code/build system fixes > > (not api changing fixes). Some fixes may touch the same lines > > that api-next have changed due to an api change (and would > > need more thinking), but generally that should not be the case. > > > > For example, without these fixes it’s impossible to write > > implementation (on api-next side) that is compatible to the > > API spec AND passes validation tests, since validation tests > > do not follow the spec. So, I could not send patches for > > api-next that follow the spec for one month (since ‘make > > check’ fails), OR I would need to include these same (or > > similar bug fix) patches in the front of my patch set. > > > > -Petri > > > > *From:*EXT Mike Holmes [mailto:mike.hol...@linaro.org > > <mailto:mike.hol...@linaro.org>] > > *Sent:* Tuesday, December 08, 2015 5:34 PM > > *To:* Maxim Uvarov > > *Cc:* Savolainen, Petri (Nokia - FI/Espoo); > > lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org> > > *Subject:* Re: [lng-odp] [PATCH 00/10] Pktio checks > > > > The process states that API-NEXT takes master on master > > release points only. > > > > > https://docs.google.com/drawings/d/1kWkr2qBV4xbqOCXMDVsoINhdxaNeHC- > 8sCm6SBVFI8o/edit > > > > On 8 December 2015 at 09:48, Maxim Uvarov > > mailto:maxim.uva...@linaro.org> > > <mailto:maxim.uva...@linaro.org > > <mailto:maxim.uva...@linaro.org>>> wrote: > > > > On 12/08/2015 17:20, Savolainen, Petri (Nokia - FI/Espoo) > > wrote: > > > > Could you merge this into api-next ASAP. Just lost > > couple of > > hours in debugging these same malfunctioning tests. > > > > -Petri > > > > > > If you can merge that master and api-next I can. But for > > now after > > time things 2 branches out of sync in many files. > > > > Maxim. > > > > > > > > -Original Message- > > From: lng-odp > &
