Re: [lng-odp] [PATCHv2 2/2] example:generator : Fix UDP checksum computation

[Maxim Uvarov]

Merged,
Maxim.

On 10/02/15 13:39, ion.grig...@freescale.com wrote:

From: Grigore Ion 

The UDP checksum is computed in the CPU endianness. The returned result
must be converted to the BE ordering when it is used to update the UDP
checksum in a packet.

Signed-off-by: Grigore Ion 
---
  v2:
  - Add PATCH version information (Maxim Uvarov)
  - Check patch with checkpatch script. (Bill Fischofer)

  example/generator/odp_generator.c |2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/example/generator/odp_generator.c 
b/example/generator/odp_generator.c
index 4af82a9..443df8b 100644
--- a/example/generator/odp_generator.c
+++ b/example/generator/odp_generator.c
@@ -239,7 +239,7 @@ static odp_packet_t pack_udp_pkt(odp_pool_t pool)
udp->dst_port = 0;
udp->length = odp_cpu_to_be_16(args->appl.payload + ODPH_UDPHDR_LEN);
udp->chksum = 0;
-   udp->chksum = odph_ipv4_udp_chksum(pkt);
+   udp->chksum = odp_cpu_to_be_16(odph_ipv4_udp_chksum(pkt));
  
  	return pkt;

  }


___
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp

[lng-odp] [PATCHv2 2/2] example:generator : Fix UDP checksum computation

[ion.grigore]

From: Grigore Ion 

The UDP checksum is computed in the CPU endianness. The returned result
must be converted to the BE ordering when it is used to update the UDP
checksum in a packet.

Signed-off-by: Grigore Ion 
---
 v2:
 - Add PATCH version information (Maxim Uvarov)
 - Check patch with checkpatch script. (Bill Fischofer)

 example/generator/odp_generator.c |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/example/generator/odp_generator.c 
b/example/generator/odp_generator.c
index 4af82a9..443df8b 100644
--- a/example/generator/odp_generator.c
+++ b/example/generator/odp_generator.c
@@ -239,7 +239,7 @@ static odp_packet_t pack_udp_pkt(odp_pool_t pool)
udp->dst_port = 0;
udp->length = odp_cpu_to_be_16(args->appl.payload + ODPH_UDPHDR_LEN);
udp->chksum = 0;
-   udp->chksum = odph_ipv4_udp_chksum(pkt);
+   udp->chksum = odp_cpu_to_be_16(odph_ipv4_udp_chksum(pkt));
 
return pkt;
 }
-- 
1.7.3.4

___
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp