[lng-odp] [RFC v2 1/4] spinlock: allow platform to override odp_spinlock_t

2015-03-17 Thread Jerin Jacob
Signed-off-by: Jerin Jacob jerin.ja...@caviumnetworks.com
---
 include/odp/api/spinlock.h | 10 +
 .../include/odp/plat/spinlock_types.h  | 46 ++
 platform/linux-generic/include/odp/spinlock.h  |  2 +
 3 files changed, 50 insertions(+), 8 deletions(-)
 create mode 100644 platform/linux-generic/include/odp/plat/spinlock_types.h

diff --git a/include/odp/api/spinlock.h b/include/odp/api/spinlock.h
index 5cde123..9a5a929 100644
--- a/include/odp/api/spinlock.h
+++ b/include/odp/api/spinlock.h
@@ -18,21 +18,15 @@
 extern C {
 #endif
 
-
-#include odp/std_types.h
-
 /** @addtogroup odp_synchronizers
  *  Operations on spin locks.
  *  @{
  */
 
 /**
- * ODP spinlock type
+ * @typedef odp_spinlock_t
+ * ODP spinlock
  */
-typedef struct odp_spinlock_t {
-   char lock;  /** @private lock flag, should match odp_atomic_flag_t */
-} odp_spinlock_t;
-
 
 /**
  * Initialize spin lock.
diff --git a/platform/linux-generic/include/odp/plat/spinlock_types.h 
b/platform/linux-generic/include/odp/plat/spinlock_types.h
new file mode 100644
index 000..83d306b
--- /dev/null
+++ b/platform/linux-generic/include/odp/plat/spinlock_types.h
@@ -0,0 +1,46 @@
+/* Copyright (c) 2015, Linaro Limited
+ * All rights reserved.
+ *
+ * SPDX-License-Identifier: BSD-3-Clause
+ */
+
+
+/**
+ * @file
+ *
+ * ODP spinlock
+ */
+
+#ifndef ODP_SPINLOCK_TYPES_H_
+#define ODP_SPINLOCK_TYPES_H_
+
+#ifdef __cplusplus
+extern C {
+#endif
+
+#include odp/std_types.h
+
+/**
+ * @internal
+ * ODP spinlock
+ */
+struct odp_spinlock_s {
+   char lock;  /** lock flag, should match odp_atomic_flag_t */
+};
+
+
+/** @addtogroup odp_synchronizers
+ *  @{
+ */
+
+typedef struct odp_spinlock_s odp_spinlock_t;
+
+/**
+ * @}
+ */
+
+#ifdef __cplusplus
+}
+#endif
+
+#endif
diff --git a/platform/linux-generic/include/odp/spinlock.h 
b/platform/linux-generic/include/odp/spinlock.h
index e02df49..7dbb1c4 100644
--- a/platform/linux-generic/include/odp/spinlock.h
+++ b/platform/linux-generic/include/odp/spinlock.h
@@ -17,6 +17,8 @@
 extern C {
 #endif
 
+#include odp/plat/spinlock_types.h
+
 /** @ingroup odp_synchronizers
  *  @{
  */
-- 
2.1.0


___
lng-odp mailing list
lng-odp@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/lng-odp


Re: [lng-odp] [RFC v2 1/4] spinlock: allow platform to override odp_spinlock_t

2015-03-17 Thread Bill Fischofer
This part fails make distcheck with error:

In file included from
../../../platform/linux-generic/include/odp_packet_io_internal.h:21:0,
 from
../../../platform/linux-generic/odp_classification.c:15:
../../../platform/linux-generic/include/odp/spinlock.h:20:37: fatal error:
odp/plat/spinlock_types.h: No such file or directory
 #include odp/plat/spinlock_types.h
 ^
compilation terminated.

On Tue, Mar 17, 2015 at 5:10 AM, Jerin Jacob jerin.ja...@caviumnetworks.com
 wrote:

 Signed-off-by: Jerin Jacob jerin.ja...@caviumnetworks.com
 ---
  include/odp/api/spinlock.h | 10 +
  .../include/odp/plat/spinlock_types.h  | 46
 ++
  platform/linux-generic/include/odp/spinlock.h  |  2 +
  3 files changed, 50 insertions(+), 8 deletions(-)
  create mode 100644
 platform/linux-generic/include/odp/plat/spinlock_types.h

 diff --git a/include/odp/api/spinlock.h b/include/odp/api/spinlock.h
 index 5cde123..9a5a929 100644
 --- a/include/odp/api/spinlock.h
 +++ b/include/odp/api/spinlock.h
 @@ -18,21 +18,15 @@
  extern C {
  #endif

 -
 -#include odp/std_types.h
 -
  /** @addtogroup odp_synchronizers
   *  Operations on spin locks.
   *  @{
   */

  /**
 - * ODP spinlock type
 + * @typedef odp_spinlock_t
 + * ODP spinlock
   */
 -typedef struct odp_spinlock_t {
 -   char lock;  /** @private lock flag, should match
 odp_atomic_flag_t */
 -} odp_spinlock_t;
 -

  /**
   * Initialize spin lock.
 diff --git a/platform/linux-generic/include/odp/plat/spinlock_types.h
 b/platform/linux-generic/include/odp/plat/spinlock_types.h
 new file mode 100644
 index 000..83d306b
 --- /dev/null
 +++ b/platform/linux-generic/include/odp/plat/spinlock_types.h
 @@ -0,0 +1,46 @@
 +/* Copyright (c) 2015, Linaro Limited
 + * All rights reserved.
 + *
 + * SPDX-License-Identifier: BSD-3-Clause
 + */
 +
 +
 +/**
 + * @file
 + *
 + * ODP spinlock
 + */
 +
 +#ifndef ODP_SPINLOCK_TYPES_H_
 +#define ODP_SPINLOCK_TYPES_H_
 +
 +#ifdef __cplusplus
 +extern C {
 +#endif
 +
 +#include odp/std_types.h
 +
 +/**
 + * @internal
 + * ODP spinlock
 + */
 +struct odp_spinlock_s {
 +   char lock;  /** lock flag, should match odp_atomic_flag_t */
 +};
 +
 +
 +/** @addtogroup odp_synchronizers
 + *  @{
 + */
 +
 +typedef struct odp_spinlock_s odp_spinlock_t;
 +
 +/**
 + * @}
 + */
 +
 +#ifdef __cplusplus
 +}
 +#endif
 +
 +#endif
 diff --git a/platform/linux-generic/include/odp/spinlock.h
 b/platform/linux-generic/include/odp/spinlock.h
 index e02df49..7dbb1c4 100644
 --- a/platform/linux-generic/include/odp/spinlock.h
 +++ b/platform/linux-generic/include/odp/spinlock.h
 @@ -17,6 +17,8 @@
  extern C {
  #endif

 +#include odp/plat/spinlock_types.h
 +
  /** @ingroup odp_synchronizers
   *  @{
   */
 --
 2.1.0


 ___
 lng-odp mailing list
 lng-odp@lists.linaro.org
 http://lists.linaro.org/mailman/listinfo/lng-odp

___
lng-odp mailing list
lng-odp@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/lng-odp