Re: [lng-odp] [API-NEXT PATCH v2 1/5] api: packet_io: change word instance to interface
Hey Petri, I like the API changes. A very minor nit, looks like a few
places where extra whitespace got injected if you happen to be making other
changes. The review is for the patch set.
Reviewed-by: Robbie King robk...@cisco.com
-Original Message-
From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Petri
Savolainen
Sent: Thursday, April 23, 2015 6:29 AM
To: lng-odp@lists.linaro.org
Subject: [lng-odp] [API-NEXT PATCH v2 1/5] api: packet_io: change word instance
to interface
Signed-off-by: Petri Savolainen petri.savolai...@nokia.com
---
include/odp/api/packet_io.h | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/include/odp/api/packet_io.h b/include/odp/api/packet_io.h
index e960f10..5446999 100644
--- a/include/odp/api/packet_io.h
+++ b/include/odp/api/packet_io.h
@@ -45,11 +45,12 @@ extern C {
*/
/**
- * Open an ODP packet IO instance
+ * Open an ODP packet IO interface
*
- * Packet IO handles are single instance per device, attempts to open an
already
- * open device will fail, returning ODP_PKTIO_INVALID with errno set.
- * odp_pktio_lookup() may be used to obtain a handle to an already open device.
+ * An ODP program can open a single packet IO interface per device, attempts
+ * to open an already open device will fail, returning ODP_PKTIO_INVALID with
+ * errno set. Use odp_pktio_lookup() to obtain a handle to an already open
+ * device.
*
* @param devPacket IO device name
* @param pool Default pool from which to allocate buffers for storing
packets
@@ -72,7 +73,7 @@ extern C {
odp_pktio_t odp_pktio_open(const char *dev, odp_pool_t pool);
/**
- * Close an ODP packet IO instance
+ * Close an ODP packet IO interface
*
* @param pktio ODP packet IO handle
*
--
2.3.5
___
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp
___
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp
Re: [lng-odp] [API-NEXT PATCH v2 1/5] api: packet_io: change word instance to interface
Robbie, please also take a look at proposed pktio api change.
Thanks,
Maxim.
On 04/29/2015 09:56, Savolainen, Petri (Nokia - FI/Espoo) wrote:
Ping. Review for the series needed.
-Original Message-
From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of ext
Petri Savolainen
Sent: Thursday, April 23, 2015 1:29 PM
To: lng-odp@lists.linaro.org
Subject: [lng-odp] [API-NEXT PATCH v2 1/5] api: packet_io: change word
instance to interface
Signed-off-by: Petri Savolainen petri.savolai...@nokia.com
---
include/odp/api/packet_io.h | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/include/odp/api/packet_io.h b/include/odp/api/packet_io.h
index e960f10..5446999 100644
--- a/include/odp/api/packet_io.h
+++ b/include/odp/api/packet_io.h
@@ -45,11 +45,12 @@ extern C {
*/
/**
- * Open an ODP packet IO instance
+ * Open an ODP packet IO interface
*
- * Packet IO handles are single instance per device, attempts to open an
already
- * open device will fail, returning ODP_PKTIO_INVALID with errno set.
- * odp_pktio_lookup() may be used to obtain a handle to an already open
device.
+ * An ODP program can open a single packet IO interface per device,
attempts
+ * to open an already open device will fail, returning ODP_PKTIO_INVALID
with
+ * errno set. Use odp_pktio_lookup() to obtain a handle to an already
open
+ * device.
*
* @param devPacket IO device name
* @param pool Default pool from which to allocate buffers for storing
packets
@@ -72,7 +73,7 @@ extern C {
odp_pktio_t odp_pktio_open(const char *dev, odp_pool_t pool);
/**
- * Close an ODP packet IO instance
+ * Close an ODP packet IO interface
*
* @param pktio ODP packet IO handle
*
--
2.3.5
___
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp
___
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp
___
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp
