Re: [lng-odp] [PATCH] linux-generic: schedule: set sched_local.pool correctly

[Bill Fischofer]

Ping

On Tue, Dec 1, 2015 at 7:14 AM, Bill Fischofer 
wrote:

> This corrects bug https://bugs.linaro.org/show_bug.cgi?id=1921
>
> Signed-off-by: Bill Fischofer 
> ---
>  platform/linux-generic/odp_schedule.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/platform/linux-generic/odp_schedule.c
> b/platform/linux-generic/odp_schedule.c
> index 884ae60..9b7cd57 100644
> --- a/platform/linux-generic/odp_schedule.c
> +++ b/platform/linux-generic/odp_schedule.c
> @@ -553,6 +553,8 @@ static int schedule(odp_queue_t *out_queue,
> odp_event_t out_ev[],
> sched_local.origin_qe = qe;
> sched_local.order =
> sched_local.buf_hdr[0]->order;
> +   sched_local.pool =
> +   sched_local.buf_hdr[0]->pool_hdl;
> for (k = 0;
>  k < qe->s.param.sched.lock_count;
>  k++) {
> --
> 2.1.4
>
>
___
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp

Re: [lng-odp] [PATCH] linux-generic: schedule: set sched_local.pool correctly

[Maxim Uvarov]

Merged,
Maxim.

On 12/10/2015 22:58, Bill Fischofer wrote:

Ping

On Tue, Dec 1, 2015 at 7:14 AM, Bill Fischofer 
> wrote:


This corrects bug https://bugs.linaro.org/show_bug.cgi?id=1921

Signed-off-by: Bill Fischofer >
---
 platform/linux-generic/odp_schedule.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/platform/linux-generic/odp_schedule.c
b/platform/linux-generic/odp_schedule.c
index 884ae60..9b7cd57 100644
--- a/platform/linux-generic/odp_schedule.c
+++ b/platform/linux-generic/odp_schedule.c
@@ -553,6 +553,8 @@ static int schedule(odp_queue_t *out_queue,
odp_event_t out_ev[],
sched_local.origin_qe = qe;
sched_local.order =
sched_local.buf_hdr[0]->order;
+   sched_local.pool =
+  sched_local.buf_hdr[0]->pool_hdl;
for (k = 0;
 k < qe->s.param.sched.lock_count;
 k++) {
--
2.1.4




___
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp


___
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp

Re: [lng-odp] [PATCH] linux-generic: schedule: set sched_local.pool correctly

[Nicolas Morey-Chaisemartin]

I don't think there is any guarantee that all buffer returned by 
queue_deq_multi come from the same pool.
So this should probably be updated when we copy an event out of the local cache 
at the beginning of schedule()

Nicolas

On 12/01/2015 02:14 PM, Bill Fischofer wrote:
> This corrects bug https://bugs.linaro.org/show_bug.cgi?id=1921
>
> Signed-off-by: Bill Fischofer 
> ---
>  platform/linux-generic/odp_schedule.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/platform/linux-generic/odp_schedule.c 
> b/platform/linux-generic/odp_schedule.c
> index 884ae60..9b7cd57 100644
> --- a/platform/linux-generic/odp_schedule.c
> +++ b/platform/linux-generic/odp_schedule.c
> @@ -553,6 +553,8 @@ static int schedule(odp_queue_t *out_queue, odp_event_t 
> out_ev[],
>   sched_local.origin_qe = qe;
>   sched_local.order =
>   sched_local.buf_hdr[0]->order;
> + sched_local.pool =
> + sched_local.buf_hdr[0]->pool_hdl;
>   for (k = 0;
>k < qe->s.param.sched.lock_count;
>k++) {

___
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp

Re: [lng-odp] [PATCH] linux-generic: schedule: set sched_local.pool correctly

[Bill Fischofer]

At least in the linux-generic implementation, we force max_deq to be 1
since we want consecutive events from an ordered queue to be dispatched to
separate threads.  There's no advantage to batching things as is done in
parallel queues since if Thread A has events 1, 2,3, 4 while Thread B has
events 5, etc., then Thread B's processing of event 5 would just have to
wait until Thread A worked its way though it's backlog of cached events.

So this isn't an issue here.

On Tue, Dec 1, 2015 at 7:39 AM, Nicolas Morey-Chaisemartin  wrote:

> I don't think there is any guarantee that all buffer returned by
> queue_deq_multi come from the same pool.
> So this should probably be updated when we copy an event out of the local
> cache at the beginning of schedule()
>
> Nicolas
>
> On 12/01/2015 02:14 PM, Bill Fischofer wrote:
> > This corrects bug https://bugs.linaro.org/show_bug.cgi?id=1921
> >
> > Signed-off-by: Bill Fischofer 
> > ---
> >  platform/linux-generic/odp_schedule.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/platform/linux-generic/odp_schedule.c
> b/platform/linux-generic/odp_schedule.c
> > index 884ae60..9b7cd57 100644
> > --- a/platform/linux-generic/odp_schedule.c
> > +++ b/platform/linux-generic/odp_schedule.c
> > @@ -553,6 +553,8 @@ static int schedule(odp_queue_t *out_queue,
> odp_event_t out_ev[],
> >   sched_local.origin_qe = qe;
> >   sched_local.order =
> >   sched_local.buf_hdr[0]->order;
> > + sched_local.pool =
> > + sched_local.buf_hdr[0]->pool_hdl;
> >   for (k = 0;
> >k < qe->s.param.sched.lock_count;
> >k++) {
>
>
___
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp